1 2013-06-29T01:29:20 *** bilal
2 2013-06-29T02:29:16 *** bilal
3 2013-06-29T06:49:46 <sharky93> moin
4 2013-06-29T06:50:43 <pineapple_koala> moin
5 2013-06-29T07:48:29 *** mtdkw
6 2013-06-29T08:50:53 *** ashutosh1461
7 2013-06-29T08:51:06 <ashutosh1461> moin
8 2013-06-29T09:06:52 *** mtdkw
9 2013-06-29T09:30:25 <sharky93> TheSheep: ThomasWaldmann what is meant by the href scheme set as "wiki.local" ?
10 2013-06-29T09:44:42 <sharky93> TheSheep: ThomasWaldmann do query strings make any sense for ReST and MediaWiki markups ?
11 2013-06-29T09:56:54 <TheSheep> sharky93: sure they do
12 2013-06-29T09:57:17 <TheSheep> sharky93: it's the same image as with any other markup, after all
13 2013-06-29T09:57:54 <sharky93> TheSheep: how do we specify them then ?
14 2013-06-29T09:58:28 <TheSheep> no idea
15 2013-06-29T09:59:54 <sharky93> TheSheep: no scope as i see it in the ReST markup @
16 2013-06-29T09:59:56 <sharky93> http://docutils.sourceforge.net/docs/ref/rst/directives.html#image
17 2013-06-29T10:02:02 <sharky93> TheSheep: i mean, qs like what we have for the moin markup as in &w=50 etc for server side compression stuff ..
18 2013-06-29T10:02:14 <sharky93> TheSheep: if there is qs in the URL itself we can surely accomodate that
19 2013-06-29T10:02:20 <sharky93> TheSheep: is that what you meant ?
20 2013-06-29T10:06:59 <pineapple_koala> waTHTHrstrst
21 2013-06-29T10:07:48 <pineapple_koala> sorry. terminal got frozen
22 2013-06-29T10:08:58 <pineapple_koala> waldi, ThomasWaldmann: please review - https://codereview.appspot.com/10716043/ and https://codereview.appspot.com/10537043/
23 2013-06-29T10:14:58 <sharky93> n
24 2013-06-29T10:41:20 <sharky93> TheSheep: please review https://codereview.appspot.com/10782043 for the ReST markup
25 2013-06-29T10:42:00 * sharky93 looks up mediawiki_in
26 2013-06-29T10:45:04 *** ashutosh_singla1
27 2013-06-29T10:45:53 *** ashutosh1461
28 2013-06-29T11:01:07 <sharky93> TheSheep: i've defined query_keys prior to the url_decode .. the change you suggested would not work
29 2013-06-29T11:01:35 <sharky93> TheSheep: oh, i see, my bad.
30 2013-06-29T11:04:29 <TheSheep> you are creating an empty dict, and then updating it
31 2013-06-29T11:04:32 <TheSheep> that makes no sense
32 2013-06-29T11:05:03 <TheSheep> the whole query code makes no sense there, because you are not modifying the query
33 2013-06-29T11:07:48 <sharky93> TheSheep: there is an addition of "do:get" that is all
34 2013-06-29T11:08:44 <TheSheep> I missed that
35 2013-06-29T11:08:54 <sharky93> hmm
36 2013-06-29T11:09:27 <sharky93> TheSheep: perhaps we should modify the query only when the scheme is None .
37 2013-06-29T11:09:57 <sharky93> TheSheep: since the dict is modified only then .
38 2013-06-29T11:11:34 <TheSheep> try this
39 2013-06-29T11:11:40 <TheSheep> (new comment)
40 2013-06-29T11:12:13 <sharky93> yeah, precisely that :)
41 2013-06-29T11:12:52 <TheSheep> looking at how often this code repeats, maybe you should have an utility function like update_url_query(dict)
42 2013-06-29T11:13:50 <TheSheep> or the Iri object should have an update_query method
43 2013-06-29T11:14:16 <sharky93> hmm, maybe a different patchset later ?
44 2013-06-29T11:15:51 <sharky93> TheSheep: ^
45 2013-06-29T11:16:22 <TheSheep> ok
46 2013-06-29T11:17:28 <sharky93> TheSheep: this code renders object tags finally .. i guess that is okay?, the resize works as usual ..
47 2013-06-29T11:20:51 <TheSheep> sharky93: yeah, I wonder if it would be better to do the same thing with the moinmoin markup
48 2013-06-29T11:21:09 <TheSheep> sharky93: then you don't have strange things like xlink.width
49 2013-06-29T11:22:04 <sharky93> TheSheep: do we have alt texts in objects ?
50 2013-06-29T11:24:07 <TheSheep> we can, it's our code
51 2013-06-29T11:30:30 <ThomasWaldmann> moin
52 2013-06-29T11:35:06 <sharky93> TheSheep: updated cr @ https://codereview.appspot.com/10782043/
53 2013-06-29T11:38:33 <sharky93> TheSheep: this current code also deals with xlink.width but i wonder if we shoudl change that to moin_page.attribute.. will have to adjust handlers on the html emitter.
54 2013-06-29T11:39:46 <TheSheep> yeah, that would make more sense
55 2013-06-29T11:39:59 <sharky93> no reply from Bastian yet
56 2013-06-29T11:40:23 <TheSheep> by the way, I my availability next week will be pretty patchy
57 2013-06-29T11:40:39 <TheSheep> as well as ThomasWaldmann's and Dreimark's
58 2013-06-29T11:41:01 <sharky93> the whole week?
59 2013-06-29T11:43:43 <sharky93> TheSheep: i think then we should plan in advance the whole week, because i think i may hit blockers soon :(
60 2013-06-29T12:24:18 <ThomasWaldmann> ashutosh_singla1: you are working on doing some clean commits ASAP?
61 2013-06-29T12:27:16 <ThomasWaldmann> maybe first backup your local stuff, update the BB repo, update your local repo and then apply your changes in small, clean changesets.
62 2013-06-29T12:28:27 <ReimarBauer> spy_: yeah, great we meet there
63 2013-06-29T12:29:43 <ThomasWaldmann> spy_: you are there for sprints also?
64 2013-06-29T12:34:18 <TheSheep> https://github.com/twitter/bootstrap/issues/2054#issuecomment-20229013
65 2013-06-29T12:35:03 * ThomasWaldmann got a notify. thanks for trying to push them a bit.
66 2013-06-29T12:38:38 <pineapple_koala> ThomasWaldmann: can you take a look at that? I can't get in touch with waldi. https://codereview.appspot.com/10537043/ and https://codereview.appspot.com/10537043/
67 2013-06-29T12:39:03 <TheSheep> ThomasWaldmann: I'm thinking that if they just confirm that they *are* going to add that MIT license, then we could go ahead?
68 2013-06-29T12:40:49 <sharky93> TheSheep: you may want to tweet that to https://twitter.com/twbootstrap , they respond faster there.
69 2013-06-29T12:41:54 <ashutosh_singla1> ThomasWaldmann, should i commit https://codereview.appspot.com/10519045/ and https://codereview.appspot.com/10439044/ ?
70 2013-06-29T12:42:14 <ashutosh_singla1> once these are done i can present some more related cr's
71 2013-06-29T12:46:01 <TheSheep> sharky93: done :)
72 2013-06-29T12:46:41 <ashutosh_singla1> ThomasWaldmann, just read your second message, ok fine :)
73 2013-06-29T13:17:07 <sharky93> TheSheep: any ideas on lines 36+ @ http://etherpad.osuosl.org/moin-ui ..
74 2013-06-29T13:18:19 *** ashutosh_singla1
75 2013-06-29T13:19:35 <TheSheep> sharky93: the right thing would be to look into mediawiki's source and see how they do it
76 2013-06-29T13:28:46 <ThomasWaldmann> waldi: please be more communicative with pineapple_koala
77 2013-06-29T13:29:32 <ThomasWaldmann> TheSheep: i have no idea about who precisely has decision authority for twitter bootstrap.
78 2013-06-29T13:30:20 <waldi> ThomasWaldmann: i've seen no mail, so it can't be that important. also i've been away
79 2013-06-29T13:30:30 <ThomasWaldmann> but I agree, if a authoritative decision for MIT licensing would be taken, we could start using it.
80 2013-06-29T13:31:27 <ThomasWaldmann> waldi: i'ld like public communication, not private communication (except for really private issues)
81 2013-06-29T13:31:47 <ThomasWaldmann> so it is either IRC or mailing list
82 2013-06-29T13:32:40 <ThomasWaldmann> waldi: see 14:38
83 2013-06-29T14:02:43 <ThomasWaldmann> waldi: are you still there? are you looking at the code review? --verbose
84 2013-06-29T14:16:11 <ThomasWaldmann> pineapple_koala: at 14:38, you pointed at the same codereview twice. did you mean another one?
85 2013-06-29T14:16:28 <sharky93> TheSheep: mediawiki is all php :P
86 2013-06-29T14:16:44 <ThomasWaldmann> news of the day! :D
87 2013-06-29T14:16:54 <waldi> ThomasWaldmann: https://codereview.appspot.com/10716043/ i would presume
88 2013-06-29T14:16:57 <ThomasWaldmann> OMG, it's all PHP!!1
89 2013-06-29T14:23:27 <ThomasWaldmann> waldi: added a comment there
90 2013-06-29T14:23:28 <sharky93> :D
91 2013-06-29T14:23:30 <TheSheep> sharky93: it's still readable
92 2013-06-29T14:23:39 <TheSheep> sharky93: and the code is available for inspection
93 2013-06-29T14:25:06 * TheSheep works on his europython slides
94 2013-06-29T14:41:08 <waldi> ThomasWaldmann: i think i've got all
95 2013-06-29T15:12:52 <sharky93> TheSheep: it appears mediawiki performs a check for trailing "px" for the size attributes, code around line 5980+ @ https://doc.wikimedia.org/mediawiki-core/master/php/html/Parser_8php_source.html ..
96 2013-06-29T15:13:21 <sharky93> TheSheep: but it is still not so clear what happens when there is no caption at all, i have asked on #wikimedia-dev ..
97 2013-06-29T15:14:06 * sharky93 looks up the html ns spec.
98 2013-06-29T15:23:38 <sharky93> TheSheep as waldi suggested the xinclude ns doesnt have width and height attributes, they match the syntax specified @ http://www.w3.org/TR/html5/embedded-content-0.html#the-img-element so dropping back to this ..
99 2013-06-29T15:24:55 <sharky93> waldi: added reply @ https://codereview.appspot.com/10599043/diff/62001/MoinMoin/converter/moinwiki_in.py for the change to the parse block
100 2013-06-29T15:26:39 <TheSheep> sharky93: can you check what is the type of attributes in that attributes.keyword case?
101 2013-06-29T15:26:58 <TheSheep> sharky93: where is it getting called from?
102 2013-06-29T15:39:22 <sharky93> TheSheep: it gets called from the __call__ lines 139+ moinwiki_in, the way keyword is used in parse_block is similar to line 98
103 2013-06-29T15:41:49 <TheSheep> sharky93: but what exactly is args?
104 2013-06-29T15:43:06 <TheSheep> ah, it's _args.Arguments()
105 2013-06-29T15:43:38 <TheSheep> sharky93: then use _args.Arguments() for your arguments too!
106 2013-06-29T15:44:10 <TheSheep> MoinMoin.converter._args.Arguments
107 2013-06-29T17:07:59 *** ashutosh1461
108 2013-06-29T17:09:56 * ThomasWaldmann made some additional slides for password talk
109 2013-06-29T17:18:35 <sharky93> TheSheep: hmm, ok. doing the changes,
110 2013-06-29T17:22:53 <spy_> ThomasWaldmann: yes, also for sprints, why not :)
111 2013-06-29T17:24:44 <sharky93> TheSheep: what will you be working on ? during the sprint? :)
112 2013-06-29T17:25:58 * spy_ waiting for the flight to Milan at the airport
113 2013-06-29T17:25:59 <TheSheep> sharky93: no idea
114 2013-06-29T17:26:24 <TheSheep> sharky93: probably I will catch up on what changed in moin2
115 2013-06-29T17:30:31 <sharky93> TheSheep: will you be available tomorrow ?
116 2013-06-29T17:31:23 <TheSheep> yes
117 2013-06-29T17:31:32 <TheSheep> I leave Monday morning
118 2013-06-29T17:31:54 <ashutosh1461> ThomasWaldmann, what about tomorrow's meeting ?
119 2013-06-29T17:32:14 <sharky93> TheSheep: i'm not too sure, width and height, come in positional or keyword arguments ?
120 2013-06-29T17:32:47 <TheSheep> keyword
121 2013-06-29T17:34:27 <sharky93> TheSheep: btw waldi left comments @ https://codereview.appspot.com/10599043/diff/62001/MoinMoin/converter/moinwiki_in.py
122 2013-06-29T17:36:21 <TheSheep> yeah, I saw
123 2013-06-29T17:44:39 *** sunu
124 2013-06-29T17:45:34 *** [sunu]
125 2013-06-29T17:51:33 <ThomasWaldmann> ashutosh1461: someone who is not travelling will have to lead it. i.e. not me, not dreimark.
126 2013-06-29T17:54:00 *** [s|u|n|u]
127 2013-06-29T18:17:26 <ThomasWaldmann> ashutosh1461: btw, left some stuff on your EP
128 2013-06-29T18:19:23 <ashutosh1461> are we going to show nameless items in the index ?
129 2013-06-29T18:40:05 <sharky93> TheSheep: updated cr @ https://codereview.appspot.com/10599043/ ..
130 2013-06-29T18:54:13 <TheSheep> sharky93: looks much better!
131 2013-06-29T18:54:30 <TheSheep> sharky93: some small simplifications suggested
132 2013-06-29T18:58:53 <ReimarBauer> TheSheep: TheSheep don't miss the italien adapter
133 2013-06-29T18:58:59 <ReimarBauer> ThomasWaldmann:
134 2013-06-29T18:59:01 <ReimarBauer> ^
135 2013-06-29T19:00:25 <TheSheep> ReimarBauer: hmm?
136 2013-06-29T19:03:54 <ThomasWaldmann> hmm, shit, i borrowed one last time but don't have an own one
137 2013-06-29T19:04:53 <ThomasWaldmann> but i'll take a multi outlet power strip with me
138 2013-06-29T19:05:15 <TheSheep> the conference friend-maker :)
139 2013-06-29T19:09:19 <sharky93> TheSheep: @ https://codereview.appspot.com/10599043/diff/82001/MoinMoin/converter/image_in.py .. if not in the dict, it will be a separate var and a few lines of code extra to handle .. should i take it out ? .. btw the in the loop assign was a silly mistake, thanks for pointing that out :P
140 2013-06-29T19:11:22 <TheSheep> sharky93: it's the same number of lines, no?
141 2013-06-29T19:11:34 <TheSheep> sharky93: whether you make it a variable or a dict item
142 2013-06-29T19:12:15 <TheSheep> sharky93: if it was href, it would be fine, but it's just query
143 2013-06-29T19:13:15 <sharky93> TheSheep: let me check. btw how much longer would you be around? :)
144 2013-06-29T19:13:44 <TheSheep> around an hour
145 2013-06-29T19:45:47 <sharky93> TheSheep: cr https://codereview.appspot.com/10599043/
146 2013-06-29T19:45:56 <sharky93> ^ @
147 2013-06-29T19:49:30 <TheSheep> sharky93: what is that loop in line 845 of moinwiki_in for?
148 2013-06-29T19:49:41 <TheSheep> sharky93: why can't you just assign it like before?
149 2013-06-29T19:51:29 <sharky93> TheSheep: whitelisting ?
150 2013-06-29T19:51:59 <ashutosh1461> waldi, the split function returns a dict of key/value pairs that can be helpful in case of functions where we need to pass all of the (item_name, namespace, field) args
151 2013-06-29T19:52:06 <TheSheep> you only need whitelisting in one place
152 2013-06-29T19:52:12 <TheSheep> and you do it in image_in.py
153 2013-06-29T19:52:16 <sharky93> hmm, yeah
154 2013-06-29T19:52:21 <ashutosh1461> waldi eg url_for
155 2013-06-29T19:52:36 <TheSheep> and in html_out too, actually
156 2013-06-29T19:53:10 <sharky93> TheSheep: actually in html_out too
157 2013-06-29T19:53:28 <TheSheep> btw, that actual_args would be better called query_args
158 2013-06-29T19:53:30 <TheSheep> I think
159 2013-06-29T19:53:45 <TheSheep> or query_keys, come to think of it
160 2013-06-29T19:54:31 <TheSheep> then it get similar to the other places
161 2013-06-29T19:57:27 <sharky93> hmm
162 2013-06-29T19:57:40 <sharky93> TheSheep: should i also get rid of the whitelisting at image_in
163 2013-06-29T19:57:48 <sharky93> ?
164 2013-06-29T19:58:38 <TheSheep> sharky93: you only need it in one place, you decide where, but I think it's best to have it on one of the two ends
165 2013-06-29T19:59:01 <TheSheep> sharky93: so either in image_in or in moinmoin_in and every other converter
166 2013-06-29T19:59:19 <TheSheep> sharky93: sorry, either in html_out or moinmoin_in and every other converter
167 2013-06-29T19:59:52 <sharky93> hmm
168 2013-06-29T19:59:53 <TheSheep> html_out sounds like the best choice
169 2013-06-29T19:59:57 <TheSheep> just one place
170 2013-06-29T20:01:35 <sharky93> yeah
171 2013-06-29T20:03:47 <sharky93> TheSheep: i recall now, the whitelisting in image_in was because of converting from xincludes to xlinks :P .. thankfully much cleaner now
172 2013-06-29T20:04:24 <TheSheep> with a little more work we will make that change into a single-line change ;)
173 2013-06-29T20:05:34 <sharky93> heh
174 2013-06-29T20:21:58 <ashutosh1461> ThomasWaldmann, do you have time right now ?
175 2013-06-29T20:26:54 <sharky93> TheSheep: there is a slight issue, line 381 in html_out .. takes in the whole elem and makes a copy, makes all the whitelisting in attrib useless.
176 2013-06-29T20:30:47 <TheSheep> sharky93: but it takes the filtered attrib, no?
177 2013-06-29T20:31:19 <sharky93> TheSheep: the copy takes in the elem and updates it with the filtered attrib dict .. :P
178 2013-06-29T20:32:09 <TheSheep> sharky93: then I guess you need to do it differently -- remove all non-whitelisted attributes from elem
179 2013-06-29T20:32:58 <sharky93> TheSheep: or whitelist at moinwiki too ?
180 2013-06-29T20:33:30 <TheSheep> not too, only
181 2013-06-29T20:33:36 <TheSheep> that's another option
182 2013-06-29T20:33:50 <sharky93> TheSheep: yeah, i think it is better than removing from a dict.
183 2013-06-29T20:34:44 <sharky93> let me try
184 2013-06-29T20:43:35 <sharky93> TheSheep: ok works .. @ https://codereview.appspot.com/10599043/
185 2013-06-29T20:45:04 <sharky93> TheSheep: there's an unintended change in html_out, i'll get rid of that
186 2013-06-29T20:48:50 <sharky93> TheSheep: commit this ?
187 2013-06-29T20:49:06 <TheSheep> sharky93: excellent :)
188 2013-06-29T20:49:09 <TheSheep> sharky93: yes
189 2013-06-29T20:49:52 <TheSheep> sharky93: but in html_out, you don't need to copy the attributes from elem to attrib in case when it's not being copied?
190 2013-06-29T20:50:01 <TheSheep> sharky93: when it's an image
191 2013-06-29T20:51:08 <sharky93> TheSheep: yeah, that is triggered only in case of the object tag ..
192 2013-06-29T20:51:36 <sharky93> TheSheep: i didnt really look into code following that, was present from before
193 2013-06-29T20:51:42 <TheSheep> so in the case of image you need to copy it over
194 2013-06-29T20:52:25 <sharky93> TheSheep: but why ?
195 2013-06-29T20:52:54 <TheSheep> so that it will appear in there?
196 2013-06-29T20:53:11 <TheSheep> or maybe I'm missing something
197 2013-06-29T20:54:20 <TheSheep> attrib gets set to {} in line 354
198 2013-06-29T20:54:40 <sharky93> oh, crap -_-
199 2013-06-29T20:54:48 <TheSheep> then in line 369 attrib['href'] or attrib['data'] is set
200 2013-06-29T20:55:01 <TheSheep> sry, src or data
201 2013-06-29T20:55:34 <TheSheep> then, if it's an image, on line 375 attrib['alt'] is set
202 2013-06-29T20:55:43 <TheSheep> and then a new img tag is made with the attributes from attrib
203 2013-06-29T20:55:50 <sharky93> TheSheep: yeah you're right i'll have to set attrib to elem.attrib
204 2013-06-29T20:57:01 <TheSheep> not so fast, because then you will have an <img> with both src and href
205 2013-06-29T20:57:03 <sharky93> TheSheep: but that also copies all the other things elem.attrib has which we would not want.
206 2013-06-29T20:57:07 <sharky93> hmm yeah
207 2013-06-29T20:57:18 <TheSheep> yeah, so I guess we want that whitelisting on both ends
208 2013-06-29T20:57:54 <TheSheep> I wonder if that is a bug
209 2013-06-29T20:58:10 <TheSheep> the fact that the object tag gets all the attributes of elem
210 2013-06-29T20:58:25 <sharky93> TheSheep: hmm could be .. seems weird to me too
211 2013-06-29T21:00:04 * TheSheep is going to bed
212 2013-06-29T21:00:11 <TheSheep> goodnight
213 2013-06-29T21:03:55 <sharky93> TheSheep: ah, .. if you're still there :) .. cr @ https://codereview.appspot.com/10599043/
214 2013-06-29T22:32:57 <sharky93> goodnight
215 2013-06-29T22:56:52 <ashutosh1461> ThomasWaldmann, please review https://codereview.appspot.com/10707048/ when free :D
216 2013-06-29T23:54:14 * ashutosh1461 says gn :)
217 2013-06-29T23:54:15 *** ashutosh1461
218
