1 2013-06-28T08:25:37 *** ashutosh1461
2 2013-06-28T08:43:20 *** pineapple_koala
3 2013-06-28T08:43:20 *** sunu
4 2013-06-28T08:43:20 *** asingla
5 2013-06-28T08:43:20 *** eSyr-ng
6 2013-06-28T08:43:20 *** sharky93
7 2013-06-28T08:43:20 *** ReimarBauer
8 2013-06-28T08:43:20 *** ThomasWaldmann
9 2013-06-28T08:43:20 *** waldi
10 2013-06-28T08:47:22 *** ThomasWaldmann
11 2013-06-28T08:47:22 *** ThomasWaldmann
12 2013-06-28T08:48:29 *** waldi
13 2013-06-28T08:48:29 *** waldi
14 2013-06-28T08:49:12 <ashutosh1461> moin
15 2013-06-28T09:04:39 *** greg_f
16 2013-06-28T09:26:30 *** ana_ananasova
17 2013-06-28T09:27:03 *** ana_ananasova
18 2013-06-28T09:28:52 <ThomasWaldmann> moin
19 2013-06-28T09:29:02 <pineapple_koala> moin
20 2013-06-28T09:36:05 <ashutosh1461> ThomasWaldmann, ran tests everything ok. https://codereview.appspot.com/10439044/ and https://codereview.appspot.com/10519045/
21 2013-06-28T09:48:57 <ThomasWaldmann> waldi: https://codereview.appspot.com/10439044/ see my recent comments
22 2013-06-28T09:51:33 <ThomasWaldmann> ashutosh1461: waldi: that moinwiki19_in.py won't work "as is" any more for interwiki links
23 2013-06-28T09:53:50 <ThomasWaldmann> so the question is "what is the wanted interwiki markup" for moinwiki19_in? do we convert markup to generally use W/N instead of W:N?
24 2013-06-28T09:55:46 <ThomasWaldmann> ashutosh1461: this affects at least 2 places there: free interwiki markup (was: MoinMoin:FrontPage) and non-free iterwiki markup (was: [[MoinMoin:FrontPage|foo]])
25 2013-06-28T09:57:37 <ashutosh1461> ThomasWaldmann, would it be hard to fix it ? i have never seen the converter code ?
26 2013-06-28T10:03:49 <ThomasWaldmann> there is a regex doing the matching and some code processing the matched parts
27 2013-06-28T10:05:22 <ThomasWaldmann> maybe there is another way: not change the markup on importing from 1.9 but do it on the fly in moinwiki19_in
28 2013-06-28T10:05:50 <ThomasWaldmann> (like before calling functions that expect slashes, not dots)
29 2013-06-28T10:05:59 <ThomasWaldmann> not sure right now what's best
30 2013-06-28T10:06:16 <ThomasWaldmann> s/not dots/not colons/
31 2013-06-28T10:09:54 <ashutosh1461> ThomasWaldmann, removed the TODO, https://codereview.appspot.com/10439044/ and i am adding a ticket about the issue
32 2013-06-28T10:16:08 <ThomasWaldmann> eSyr: TheSheep: waldi: can one of you lead the GSOC meeting on sunday? I'll be travelling to EuroPython at meeting time.
33 2013-06-28T10:27:53 <ashutosh1461> ThomasWaldmann, also what should i start next ?
34 2013-06-28T10:38:03 <ThomasWaldmann> you can practically try functionality impacted by your changes, what still works, what needs fixing
35 2013-06-28T10:39:06 *** dreimark
36 2013-06-28T10:39:13 <ThomasWaldmann> also, try to create items in different namespaces, looks what functionality needs improvements to operate on just a single namespace
37 2013-06-28T10:39:17 *** dreimark
38 2013-06-28T10:39:17 *** dreimark
39 2013-06-28T10:46:03 *** dreimark_
40 2013-06-28T10:47:59 *** dreimark_
41 2013-06-28T11:06:35 *** sharky93
42 2013-06-28T11:07:15 <sharky93> moin
43 2013-06-28T11:07:23 <sharky93> what is meant by K-lined?, my irssi screen got klined yesterday, and didnt auto-rejoin .. :(
44 2013-06-28T11:08:16 <ThomasWaldmann> happened to multiple people here, no idea why...
45 2013-06-28T11:12:42 <eSyr> sharky93: kill line is a message which is provided to irc client when it is killed, forcedly disconnected from the server (by the logic of the server software or by ircop).
46 2013-06-28T11:13:19 <eSyr> (or it is some methaphor for killing the line between server and client)
47 2013-06-28T11:13:26 <sharky93> hmm
48 2013-06-28T11:19:18 <ThomasWaldmann> yeah, and now we now about as much as before :D
49 2013-06-28T11:19:26 <ThomasWaldmann> concerning the "why" :)
50 2013-06-28T11:21:18 <dav1d> #freenode should know
51 2013-06-28T11:37:49 *** dreimark
52 2013-06-28T12:00:49 *** mtdkw
53 2013-06-28T12:24:32 <pineapple_koala> ThomasWaldmann: please review -> https://codereview.appspot.com/10688044/
54 2013-06-28T12:35:00 *** dave_largo
55 2013-06-28T12:43:28 <sharky93> /query pineapple_koala
56 2013-06-28T12:43:50 <sharky93> :P
57 2013-06-28T12:46:22 <sharky93> /me confused
58 2013-06-28T12:46:35 <sharky93> ah space -_-
59 2013-06-28T12:50:01 <pineapple_koala> :D
60 2013-06-28T13:36:18 *** dreimark
61 2013-06-28T13:39:24 <sharky93> TheSheep: should i push the moinwiki resize patchset ?
62 2013-06-28T13:39:38 <sharky93> after the change you suggested on cr
63 2013-06-28T13:40:41 <TheSheep> sharky93: there is still one ugly part in it, but I'm not sure what to do with it
64 2013-06-28T13:41:26 <TheSheep> sharky93: in image_in, around line 33
65 2013-06-28T13:41:26 <sharky93> TheSheep: the xlink?
66 2013-06-28T13:41:51 <TheSheep> also, soon you will have copies of all variables with the 'actual' in front of them
67 2013-06-28T13:42:14 <TheSheep> I think that you should try to integrate it with the existing code a little better
68 2013-06-28T13:42:29 <TheSheep> and, finally, I see no tests for it :)
69 2013-06-28T13:42:53 <TheSheep> did you run unit tests?
70 2013-06-28T13:43:06 <sharky93> yes, existing tests pass.
71 2013-06-28T13:43:56 <TheSheep> then you only need to add the tests for your additions
72 2013-06-28T13:45:32 <sharky93> i had added a test earlier for svg to img tags ..
73 2013-06-28T13:45:43 <sharky93> maybe i'll look that up again.. should be along similar lines
74 2013-06-28T13:47:31 <sharky93> TheSheep: at the etherpad, thomas mentioned that it is not so important for us to support markups other than ReST and mediawiki for this resize
75 2013-06-28T13:48:50 <TheSheep> ok
76 2013-06-28T13:49:07 <TheSheep> sharky93: did you have any time to work on the mockups?
77 2013-06-28T13:51:04 <sharky93> TheSheep: no, have not been able to do much after the slight update to jm which you've seen :(
78 2013-06-28T13:58:37 <ThomasWaldmann> pineapple_koala: review done
79 2013-06-28T14:00:11 <sharky93> TheSheep: is this better @ https://codereview.appspot.com/10599043/
80 2013-06-28T14:03:00 *** sunu
81 2013-06-28T14:07:50 <TheSheep> sharky93: more comments
82 2013-06-28T14:10:06 <sharky93> TheSheep: i didnt quite understand this - "maybe iterate over attr, not arguments?"
83 2013-06-28T14:10:36 <pineapple_koala> ThomasWaldmann: how about returning the user object from create_user ? might be useful in some cases
84 2013-06-28T14:16:18 <sharky93> TheSheep: apart from that i updated the cr
85 2013-06-28T14:16:34 <pineapple_koala> bad idea. forget
86 2013-06-28T14:21:03 <ThomasWaldmann> btw, all students please try to make clean commits. AND, after you committed, push to your public repo.
87 2013-06-28T14:21:19 <pineapple_koala> ThomasWaldmann: https://codereview.appspot.com/10688044/
88 2013-06-28T14:21:27 <ThomasWaldmann> we know that it is a bit slow going in the beginning, but later this should happen multiple times daily.
89 2013-06-28T14:21:55 <pineapple_koala> i really hope to commit smth today :)
90 2013-06-28T14:22:01 *** mtdkw
91 2013-06-28T14:25:57 <pineapple_koala> all the tests are good. including pep
92 2013-06-28T14:25:59 <ThomasWaldmann> pineapple_koala: "`validate=True` and `is_encrypted=False` don't belong to meta, so maybe we
93 2013-06-28T14:26:04 <ThomasWaldmann> should leave them as default arguments."
94 2013-06-28T14:26:10 <ThomasWaldmann> that's a good idea, why didn't you do it?
95 2013-06-28T14:27:38 <pineapple_koala> yeah, i also wanted to say that those are not meta. i'll make them as default arguments
96 2013-06-28T14:27:41 <ThomasWaldmann> (in fact, username, email, password is also meta)
97 2013-06-28T14:28:27 <ThomasWaldmann> but you need to be careful there as they are likely used as positional arguments (check that also for all others)
98 2013-06-28T14:29:11 <TheSheep> sharky93: right now you are iterating over attributes, and checking if any of them is inside attr
99 2013-06-28T14:29:15 <pineapple_koala> hm... it's important to keep those mandatory, so better leave them as is.
100 2013-06-28T14:29:32 <TheSheep> sharky93: perhaps it would be better to iterate over attr and check if they are in attributes
101 2013-06-28T14:29:37 <ThomasWaldmann> pineapple_koala: validation would check that also. :)
102 2013-06-28T14:29:38 *** mtdkw
103 2013-06-28T14:30:03 <pineapple_koala> about the returning value - there are some tests that assert that the returning value is None. of course that can be changed...
104 2013-06-28T14:30:08 <sharky93> TheSheep: yeah, i just didnt understand why would it be better?
105 2013-06-28T14:30:29 <TheSheep> sharky93: because attr is shorter?
106 2013-06-28T14:30:36 <pineapple_koala> ThomasWaldmann: ^
107 2013-06-28T14:30:46 <sharky93> TheSheep: attr is 3, arguments would be 4 :)
108 2013-06-28T14:30:56 <TheSheep> sharky93: nevermind then
109 2013-06-28T14:31:11 <ThomasWaldmann> pineapple_koala: be a bit careful with returning the fresh user object. some stuff might get assigned when storing it to disk but is maybe not present in the object, like e.g. itemid/revid.
110 2013-06-28T14:31:43 <sharky93> TheSheep: even if we expand in the future, we'll have to increase the arguments and attr by the same amount
111 2013-06-28T14:32:04 <pineapple_koala> ThomasWaldmann: hence better not do it
112 2013-06-28T14:32:36 <TheSheep> sharky93: fine, fine, that code just somehow feels wrong and I can't quite say why
113 2013-06-28T14:32:47 <TheSheep> sharky93: well, not wrong, but somehow clumsy
114 2013-06-28T14:33:06 <TheSheep> sharky93: but I can't see how to improve it
115 2013-06-28T14:33:19 <sharky93> TheSheep: so push it? :)
116 2013-06-28T14:33:39 <pineapple_koala> ThomasWaldmann: so I'm changing validate and is_encrypted to default arguments
117 2013-06-28T14:34:03 <TheSheep> sharky93: did you get rid of that additional url_decode?
118 2013-06-28T14:35:21 <ThomasWaldmann> pineapple_koala: ok
119 2013-06-28T14:35:27 <sharky93> TheSheep: yes, @ https://codereview.appspot.com/10599043/
120 2013-06-28T14:35:51 <ThomasWaldmann> pineapple_koala: as everything in kw should be meta key/values then, maybe call it **meta?
121 2013-06-28T14:36:18 <TheSheep> ThomasWaldmann: do you want to take a look?
122 2013-06-28T14:37:05 <ThomasWaldmann> https://codereview.appspot.com/10599043/ there?
123 2013-06-28T14:37:10 <TheSheep> yes
124 2013-06-28T14:41:08 <pineapple_koala> ThomasWaldmann: yeah, meta is better
125 2013-06-28T14:57:13 <sharky93> TheSheep: i've been looking up ReST for resize, first will have to fix the markup for an image, that itself is broken
126 2013-06-28T14:58:14 <ThomasWaldmann> sharky93: TheSheep: did a one-pass review. about the stuff that feels unclean: i have no idea (except maybe using url), ask waldi, he's more used to that stuff.
127 2013-06-28T15:07:50 <pineapple_koala> ThomasWaldmann: https://codereview.appspot.com/10688044 if the docs are ok, i want to commit
128 2013-06-28T15:09:40 <sharky93> waldi: please have a look @ https://codereview.appspot.com/10599043/diff/62001/MoinMoin/converter/moinwiki_in.py .. the confusing part is the one with xlinks, possible suggestions .. ?
129 2013-06-28T15:17:28 <ThomasWaldmann> pineapple_koala: done
130 2013-06-28T15:26:40 <pineapple_koala> ThomasWaldmann: one more try https://codereview.appspot.com/10688044/
131 2013-06-28T15:30:37 <sharky93> ThomasWaldmann: added comments for more clarity @ https://codereview.appspot.com/10599043/ .. still not much idea about the unclean stuff.
132 2013-06-28T15:32:05 <sharky93> TheSheep: so we work on ReST, mediawiki markups while waiting for some clarity on xlinks .. ? This may take more time since it appears the ReST stuff for images itself is pretty broken.
133 2013-06-28T15:44:10 <ThomasWaldmann> pineapple_koala: see review
134 2013-06-28T15:46:40 <pineapple_koala> done.
135 2013-06-28T15:47:09 *** dreimark
136 2013-06-28T16:03:51 <TheSheep> sharky93: sounds good
137 2013-06-28T16:05:35 <ashutosh1461> ThomasWaldmann, ok to commit https://codereview.appspot.com/10519045/ and https://codereview.appspot.com/10439044/ ?
138 2013-06-28T16:16:01 * ThomasWaldmann needs to go, bbl
139 2013-06-28T16:58:38 *** sunu
140 2013-06-28T16:59:08 *** RMS
141 2013-06-28T16:59:20 *** Guest70023
142 2013-06-28T17:04:53 *** mtdkw
143 2013-06-28T17:37:14 *** dreimark
144 2013-06-28T17:49:26 *** greg_f
145 2013-06-28T18:00:33 *** dreimark
146 2013-06-28T18:25:39 <sunu> pineapple_koala: NIce nick :D
147 2013-06-28T18:27:55 *** dreimark
148 2013-06-28T18:55:48 *** dreimark
149 2013-06-28T20:31:40 <sharky93> TheSheep: ThomasWaldmann we can deal with the rest markup for images without treating them as transclusions, right ?
150 2013-06-28T20:32:19 <sharky93> *ReST
151 2013-06-28T20:46:59 <sharky93> TheSheep: ThomasWaldmann in the current code, rst_in.py lines 330+ it is directly put in a moin-page.object .. we can keep it the same way, just have to fetch the revision info of the image should I proceed by this way?
152 2013-06-28T20:53:10 <pineapple_koala> sunu: thx ;)
153 2013-06-28T21:16:04 <spy_> ReimarBauer: ThomasWaldmann: please have a look when you have free time https://codereview.appspot.com/10761044/
154 2013-06-28T21:26:35 *** dave_largo
155 2013-06-28T21:48:52 *** dreimark
156 2013-06-28T23:06:04 <sharky93> TheSheep: ThomasWaldmann updated etherpad @ http://etherpad.osuosl.org/moin-ui lines 20+ please have a look ..
157 2013-06-28T23:34:43 *** dreimark
158 2013-06-28T23:35:12 <sharky93> gn
159 2013-06-28T23:35:16 *** dreimark
160 2013-06-28T23:42:04 <ashutosh1461> gn sharky93
161 2013-06-28T23:42:41 *** ashutosh1461
162 2013-06-28T23:42:45 <ReimarBauer> re
163 2013-06-28T23:46:08 <ReimarBauer> spy_: please add regular what you are doint on the diary
164 2013-06-28T23:51:30 <spy_> ReimarBauer: ok, I will try to. Btw, I'm going to EuroPython this year, so I hope to meet you there ;)
165 2013-06-28T23:52:41 <spy_> ThomasWaldmann: ^
166 2013-06-28T23:53:06 <spy_> gn
167 2013-06-28T23:53:19 *** dreimark
168