1 2013-06-25T05:28:17  *** ashutosh1461 has quit IRC
   2 2013-06-25T05:29:05  *** ashutosh1461 has joined #moin-dev
   3 2013-06-25T05:44:15  <sharky93> waldi: one more query, does xinclude.width / height make any sense like "xinclude.href", which has been used @ https://bitbucket.org/thomaswaldmann/moin-2.0/src/ad303592c64c1743ac218d42835493cb9d97440b/MoinMoin/converter/moinwiki_in.py?at=default#cl-843
   4 2013-06-25T06:09:49  *** ashutosh1461 has quit IRC
   5 2013-06-25T06:13:03  *** greg_f has joined #moin-dev
   6 2013-06-25T06:23:47  *** ashutosh1461 has joined #moin-dev
   7 2013-06-25T06:54:34  *** ashutosh1461 has quit IRC
   8 2013-06-25T06:57:15  <waldi> sharky93: if you can tell me where in http://www.w3.org/TR/2006/REC-xinclude-20061115/ you find somthing about height and weight
   9 2013-06-25T06:57:22  <waldi> s,weight,width,
  10 2013-06-25T07:15:40  <TheSheep> waldi: then obviously we can't use xinclude there
  11 2013-06-25T07:19:19  <waldi> i'm still not 100% sure what you are trying to do anyway
  12 2013-06-25T07:20:51  <TheSheep> waldi: put a width and height attribute on the <img> tag
  13 2013-06-25T07:21:32  <TheSheep> waldi: to do that, the information about their values has to be passed to the html emitter
  14 2013-06-25T07:23:01  <TheSheep> this obviously doesn't belong in the url
  15 2013-06-25T07:30:28  <TheSheep> waldi: where does that xinclude spec say anything about including images or any other non-text non-xml data?
  16 2013-06-25T08:38:18  *** ashutosh1461 has joined #moin-dev
  17 2013-06-25T08:50:59  <ashutosh1461> ThomasWaldmann, did some changes so that the main functions in the items/__init__.py support fqnames,  https://codereview.appspot.com/10519045/ can move on to views once you review it. :)
  18 2013-06-25T09:23:29  <ana_ananasova> waldi: please review https://codereview.appspot.com/10537043/
  19 2013-06-25T09:39:17  <waldi> TheSheep: isn't the tag already in the html namespace?
  20 2013-06-25T09:39:55  <TheSheep> waldi: I mean it's not rally suitable for images
  21 2013-06-25T09:40:02  <TheSheep> really*
  22 2013-06-25T09:40:57  <waldi> ana_ananasova: please first remove stuff you don't longer need
  23 2013-06-25T09:42:04  *** ashutosh1461 has quit IRC
  24 2013-06-25T09:46:42  <ana_ananasova> well, i wanted to change first the user subscriptions, but thomas suggested working on that. or you mean smth else?
  25 2013-06-25T09:46:53  <ana_ananasova> waldi: ^
  26 2013-06-25T09:49:55  <waldi> later
  27 2013-06-25T11:30:30  <sharky93> waldi: we need to pass information about height and width to the HTML emitter via the tree element, to support markup like {{ someimage.jpg || width="100px", height="100px" }} ..
  28 2013-06-25T11:32:06  <sharky93> waldi: currently ' width="100px", height="100px" ' gets scanned as the query .. but we do not want this to remain in the query finally since we also have to support markup like {{ someimage.jpg || &width=10, &height=10 }} .. the '&' here will indicate that this has to go in the query string finally...
  29 2013-06-25T11:32:42  <sharky93> TheSheep: ^^
  30 2013-06-25T12:15:28  <ana_ananasova> ThomasWaldmann, waldi: is there anything else we need except emails and language of the user to send mail?
  31 2013-06-25T12:18:42  <TheSheep> sharky93: any progress?
  32 2013-06-25T12:22:40  <sharky93> TheSheep: i fixed the code so that now we have the query coming down to the html emitter .. previously this got lost in the include converter.
  33 2013-06-25T12:23:56  <sharky93> TheSheep: apart from that i thought of another way of using the query value itself to pass the attr values to the emitter .. but we need to setup a specific handler on the emitter which understands this.
  34 2013-06-25T12:25:30  <sharky93> like {{ some.jpg || &width=100, height=100 }} becomes .. " +width=100,height=100" .. we now setup a handler in the html emitter which knows that if the key starts with a '+' it has to go in the HTML
  35 2013-06-25T12:31:07  <sharky93> TheSheep: how about this ^ ?
  36 2013-06-25T12:32:06  <TheSheep> sharky93: no, that's a dirty hack
  37 2013-06-25T12:32:43  <TheSheep> sharky93: just use a moin_page.object instead if the xinclude, if xinclude doesn't allow you to pass those attributes
  38 2013-06-25T12:38:10  *** dave_largo has joined #moin-dev
  39 2013-06-25T13:45:06  <sharky93> TheSheep: xinclude is allowing me to pass the values ..
  40 2013-06-25T13:46:34  <TheSheep> sharky93: what is the problem then?
  41 2013-06-25T13:49:50  <sharky93> TheSheep: im not sure if that is the correct way or is it just working .. xinclude.width / height seems a bit different from say 'href' which is also mentioned about in the w3 link .. @ http://www.w3.org/TR/2006/REC-xinclude-20061115/
  42 2013-06-25T13:52:11  <TheSheep> sharky93: then talk to waldi to come up with the right tag for this
  43 2013-06-25T13:52:25  <TheSheep> sharky93: in the mean time you can try working on the mockups a little
  44 2013-06-25T13:58:38  <sharky93> TheSheep: ok, so we want to make the mockups a bit more detailed.. like for an ex: what more to introduce?
  45 2013-06-25T14:00:16  <TheSheep> sharky93: the jquery-mobile mockup can be improved by adding some classes, for example to make the corners rounded on the lists
  46 2013-06-25T14:00:34  <TheSheep> sharky93: and by adding some margins around them
  47 2013-06-25T14:01:01  *** birkenfeld_ has joined #moin-dev
  48 2013-06-25T14:01:56  <sharky93> TheSheep: hmm, true. btw have we discarded foundation? .. there's not much on the etherpad. did you have a look ?
  49 2013-06-25T14:02:50  <TheSheep> sharky93: me? no
  50 2013-06-25T14:04:48  <sharky93> TheSheep: do you want us to maybe dig deeper on foundation maybe? that is amoing the best we could work with i guess .. ?
  51 2013-06-25T14:11:47  *** birkenfeld has quit IRC
  52 2013-06-25T14:11:49  *** birkenfeld_ is now known as birkenfeld
  53 2013-06-25T14:49:19  *** greg_f has quit IRC
  54 2013-06-25T14:50:21  <sharky93> TheSheep: ThomasWaldmann anyway i could upload to static.moinmo.in ? or some other webspace, what i used is not allowing me access now .. some server side troubles.
  55 2013-06-25T14:50:21  <sharky93> need to post updated mockups
  56 2013-06-25T14:52:11  <sharky93> waldi: please have a look @ http://etherpad.osuosl.org/moin-ui lines 7-19 .. i've tried to be more clear ..
  57 2013-06-25T14:56:34  *** greg_f has joined #moin-dev
  58 2013-06-25T14:57:43  *** brunomartin has joined #moin-dev
  59 2013-06-25T14:59:54  *** bilal has joined #moin-dev
  60 2013-06-25T15:39:12  *** sunumonster has joined #moin-dev
  61 2013-06-25T15:40:47  *** tah has joined #moin-dev
  62 2013-06-25T15:46:27  *** sunu has quit IRC
  63 2013-06-25T15:46:27  *** asingla has quit IRC
  64 2013-06-25T15:46:28  *** ThomasAH has quit IRC
  65 2013-06-25T15:46:28  *** sunumons- has quit IRC
  66 2013-06-25T16:06:17  *** ashutosh1461 has joined #moin-dev
  67 2013-06-25T16:12:26  *** kolyaflash has joined #moin-dev
  68 2013-06-25T16:12:54  *** sunu has joined #moin-dev
  69 2013-06-25T16:12:54  *** asingla has joined #moin-dev
  70 2013-06-25T16:15:43  *** xiaq_ has joined #moin-dev
  71 2013-06-25T16:16:19  *** sharky93_ has joined #moin-dev
  72 2013-06-25T16:19:53  *** xiaq has quit IRC
  73 2013-06-25T16:19:54  *** sharky93 has quit IRC
  74 2013-06-25T16:19:54  *** eSyr-ng has quit IRC
  75 2013-06-25T16:19:54  *** dave_largo has quit IRC
  76 2013-06-25T16:19:56  *** ana_ananasova has quit IRC
  77 2013-06-25T16:19:56  *** ana_ananasova has joined #moin-dev
  78 2013-06-25T16:20:09  *** dave_largo has joined #moin-dev
  79 2013-06-25T16:22:17  *** eSyr-ng has joined #moin-dev
  80 2013-06-25T16:34:12  *** sharky93_ is now known as sharky93
  81 2013-06-25T16:58:02  *** brunomartin has quit IRC
  82 2013-06-25T17:04:47  *** jek has joined #moin-dev
  83 2013-06-25T17:10:57  *** greg_f has quit IRC
  84 2013-06-25T17:21:48  *** dave_largo has quit IRC
  85 2013-06-25T17:21:48  *** ashutosh1461 has quit IRC
  86 2013-06-25T17:28:19  *** dave_largo has joined #moin-dev
  87 2013-06-25T17:30:14  *** ashutosh1461 has joined #moin-dev
  88 2013-06-25T17:30:35  <sharky93> TheSheep: for j-m @ http://192.241.198.195/jm/jmobile.html
  89 2013-06-25T17:43:12  <sharky93> TheSheep: should we try more on foundation too?
  90 2013-06-25T17:43:28  *** BalluBear has joined #moin-dev
  91 2013-06-25T17:47:04  <sharky93> BalluBear: smells of the Ninja clan :P
  92 2013-06-25T17:49:37  *** BalluBear has quit IRC
  93 2013-06-25T17:58:12  *** BalluBear has joined #moin-dev
  94 2013-06-25T18:02:31  <TheSheep> sharky93: sure
  95 2013-06-25T18:03:05  *** BalluBear has quit IRC
  96 2013-06-25T18:04:54  *** kolyaflash has quit IRC
  97 2013-06-25T18:25:58  <sharky93> TheSheep: any more simplistic ways to improve the j-m mockup?
  98 2013-06-25T18:26:07  <sharky93> i.e @ http://192.241.198.195/jm/jmobile.html
  99 2013-06-25T18:26:22  <TheSheep> looks better already
 100 2013-06-25T18:26:33  <TheSheep> breadcrumbs would be useful
 101 2013-06-25T18:26:46  <TheSheep> and a message
 102 2013-06-25T18:27:20  <TheSheep> what does the (+) button in the upper left corner do?
 103 2013-06-25T18:33:30  <sharky93> TheSheep: what's breadcrumbs? .. i thought of associating actions like sign-out, profile settings etc onto it in a dropdown
 104 2013-06-25T18:33:42  <sharky93> but that would look good on the right i guess.
 105 2013-06-25T18:34:02  <TheSheep> a breadcrumb trail
 106 2013-06-25T18:34:14  <TheSheep> the list of pages that you have recently visited
 107 2013-06-25T18:37:11  <ana_ananasova> breadcrumbs -> http://twitter.github.io/bootstrap/components.html#breadcrumbs
 108 2013-06-25T18:39:32  <ana_ananasova> waldi: updated the cr https://codereview.appspot.com/10537043/
 109 2013-06-25T18:43:27  <sharky93> if only they were so easy with j-m :P
 110 2013-06-25T18:45:34  <sharky93> bootstrap- why u no MIT? :(
 111 2013-06-25T18:45:39  <ana_ananasova> :D
 112 2013-06-25T18:48:14  <sharky93> TheSheep: what should be our course of action till waldi can help us with the resizing stuff..
 113 2013-06-25T18:52:23  <TheSheep> sharky93: at do you need from waldi?
 114 2013-06-25T18:52:34  <TheSheep> sharky93: just use moin_page.object
 115 2013-06-25T19:10:29  *** DasIch-m has joined #moin-dev
 116 2013-06-25T19:11:23  *** DasIch-m has quit IRC
 117 2013-06-25T19:16:55  *** kolyaflash has joined #moin-dev
 118 2013-06-25T19:38:13  *** ashutosh1461 has quit IRC
 119 2013-06-25T19:48:11  <sharky93> TheSheep: you mean extend the attrib dictionary with a moin_page.object which has it's own attrib like 'height', 'widht'?
 120 2013-06-25T19:48:31  <TheSheep> no, use moin_page.object instead of xinclude
 121 2013-06-25T19:48:53  <TheSheep> and make the moin_page.object handler call the xinclude when needed
 122 2013-06-25T19:49:17  <TheSheep> just like the xinclude does with img handler now
 123 2013-06-25T19:55:06  <sharky93> TheSheep: ah, ok. that i think will lead to more changes in the include converter code.. but fine, i'll check.
 124 2013-06-25T19:57:02  <sharky93> TheSheep: i'll try to improve the j-m mockup a bit ..
 125 2013-06-25T19:58:12  <TheSheep> sharky93: btw, perhaps instead of using moin_page.object we should make moin_page.include or something?
 126 2013-06-25T19:58:40  <TheSheep> sharky93: and just add handlers to all converters
 127 2013-06-25T20:01:11  <sharky93> TheSheep: what would be a fundamental difference in moin_page.object and moin_page.include?
 128 2013-06-25T20:02:17  <TheSheep> different handler
 129 2013-06-25T20:02:37  <TheSheep> one that either calls the handler for the object or the one for the include
 130 2013-06-25T20:03:01  <TheSheep> it's just one of the many possible ways
 131 2013-06-25T20:03:19  <TheSheep> it's your code, I won't make all the decisions for you
 132 2013-06-25T20:03:34  <TheSheep> I can only give advice
 133 2013-06-25T20:12:22  <sharky93> hmm
 134 2013-06-25T20:42:28  <sharky93> TheSheep: i think we should not go for moin_page namespace before using the include converter.. since it is the job of the include converter to change "Page > Body > P > Include" to .. "Page > Body > P > Page > Body > Object" ..
 135 2013-06-25T20:45:34  <sharky93> TheSheep: at worst we could use xinclude.width or maybe use a different ns for such attr. and update them in the main attr dict.
 136 2013-06-25T20:48:55  <ThomasWaldmann> moin
 137 2013-06-25T21:05:33  *** dave_largo has quit IRC
 138 2013-06-25T21:42:32  <ThomasWaldmann> asingla: review done
 139 2013-06-25T22:06:30  <ThomasWaldmann> ana_ananasova: reviewing your stuff...
 140 2013-06-25T22:27:04  <ThomasWaldmann> ana_ananasova: done
 141 2013-06-25T22:55:53  *** kolyaflash has quit IRC
 142 2013-06-25T23:39:59  *** DasIch-m has joined #moin-dev
 143 2013-06-25T23:49:42  *** DasIch-m has quit IRC
 144 

MoinMoin: MoinMoinChat/Logs/moin-dev/2013-06-25 (last edited 2013-06-25 05:30:03 by IrcLogImporter)