1 2013-05-19T01:06:54 *** sunumonster
2 2013-05-19T03:51:17 *** ashutosh1461
3 2013-05-19T03:51:28 <ashutosh1461> moin everyone ! :)
4 2013-05-19T05:23:24 <dreimark> moin
5 2013-05-19T05:23:27 <dreimark> http://www.debian-administration.org/articles/187
6 2013-05-19T05:23:53 <dreimark> ^ an iptables surge protection ;)
7 2013-05-19T05:29:03 *** ronny_
8 2013-05-19T06:48:29 *** sharky_93
9 2013-05-19T07:36:45 *** ana_ananasova
10 2013-05-19T08:18:04 *** sharky_93
11 2013-05-19T08:30:59 *** sharky_93
12 2013-05-19T10:38:36 *** ana_ananasova
13 2013-05-19T11:14:31 *** ana_ananasova
14 2013-05-19T11:46:12 *** ashutosh1461
15 2013-05-19T12:50:02 <sharky_93> moin
16 2013-05-19T12:50:18 <ThomasWaldmann> moin
17 2013-05-19T12:51:20 <sharky9-> ThomasWaldmann, please review https://codereview.appspot.com/9104050 when free, i think its pretty much done.
18 2013-05-19T12:52:19 <sharky_93> btw, i'm facing a strange issue, it is showing, nick "sharky93" already logged in.. does this mean someone registered with freenode ? :(
19 2013-05-19T12:56:57 <sharky_93> ThomasWaldmann, is the sprint today too ?
20 2013-05-19T12:57:01 <ThomasWaldmann> either that or some other client of yours is still online
21 2013-05-19T12:57:24 <ThomasWaldmann> at least there is some activity on #pocoo-sprint
22 2013-05-19T12:57:43 <ThomasWaldmann> werkzeug is still biggest issue afaics
23 2013-05-19T12:58:44 *** chitrank
24 2013-05-19T14:32:51 *** dwcramer
25 2013-05-19T15:03:02 *** sharky_93
26 2013-05-19T15:04:29 *** sharky
27 2013-05-19T15:05:35 *** sharkyraj
28 2013-05-19T15:08:01 *** sharky
29 2013-05-19T15:10:10 *** sharky
30 2013-05-19T15:12:39 *** chitrank
31 2013-05-19T15:25:49 *** sharky
32 2013-05-19T15:25:55 *** TheRealSharky
33 2013-05-19T15:34:51 *** sharky93
34 2013-05-19T15:35:11 *** sharky93
35 2013-05-19T15:35:31 *** sharky
36 2013-05-19T15:41:26 *** sharky93
37 2013-05-19T15:41:52 *** sharky9-
38 2013-05-19T15:42:39 *** sharky93
39 2013-05-19T16:14:59 *** sharky93|pBNC
40 2013-05-19T16:22:32 *** sharky9-
41 2013-05-19T16:33:54 *** dwcramer
42 2013-05-19T17:05:36 *** dwcramer
43 2013-05-19T17:23:38 *** dwcramer
44 2013-05-19T18:09:47 *** chitrank
45 2013-05-19T18:50:40 *** ronny_
46 2013-05-19T18:58:28 <chitrank> Hello Moin developers made the changes to the moin2 _tests and other tests of moin2 as well
47 2013-05-19T18:58:53 <chitrank> please review my code : https://codereview.appspot.com/9478044/
48 2013-05-19T19:04:57 *** ronny_
49 2013-05-19T19:33:47 *** sharky_93
50 2013-05-19T19:35:03 *** sharky93
51 2013-05-19T19:43:20 *** sharky_93
52 2013-05-19T19:45:05 <ThomasWaldmann> chitrank: review done
53 2013-05-19T19:45:59 <ThomasWaldmann> chitrank: you maybe have heard that there was a pocoo sprint since yesterday about py3 porting of werkzeug,flask,jinja2
54 2013-05-19T19:46:50 <ThomasWaldmann> if you want to see some changesets, just look into https://github.com/mitsuhiko/ - misc. repos, "sprint-branch"
55 2013-05-19T19:57:43 *** chitrank
56 2013-05-19T20:05:52 <ThomasWaldmann> TheSheep: https://codereview.appspot.com/9104050/ ui stuff, can you review?
57 2013-05-19T20:06:18 <TheSheep> ThomasWaldmann: yes, but I might need some help using that
58 2013-05-19T20:19:32 <TheSheep> ThomasWaldmann: that $ in there is jquery?
59 2013-05-19T20:26:51 <TheSheep> ThomasWaldmann: how can I add a comment?
60 2013-05-19T20:29:02 <sharky93> TheSheep, you can double-click on the line-no. the comment box comes up, click save and then click "Publish+Mail"
61 2013-05-19T20:29:38 <sharky93> that is how it works for me, i'm not so sure reviewers have the same view or not ?
62 2013-05-19T20:30:03 <TheSheep> ok, thanks, double click does it, I didn't think to try it
63 2013-05-19T20:34:31 <sharky93> i seem to have missed this one, yep the '$' is jquery
64 2013-05-19T20:34:52 <TheSheep> sharky93: I wonder if it would make sense to have some "moin-hide-nojs" class, that would have visibility:hidden in css, that would be then removed by js
65 2013-05-19T20:35:09 <TheSheep> (the js would remove the style from that class)
66 2013-05-19T20:35:26 <TheSheep> this way we can easily hide things that don't work without js when js is disabled
67 2013-05-19T20:35:36 <TheSheep> what do you think?
68 2013-05-19T20:36:30 <ThomasWaldmann> sounds like a good idea :)
69 2013-05-19T20:38:38 <sharky93> hmm sounds good! :D
70 2013-05-19T20:39:31 <TheSheep> sharky93: you know what I mean by not using onclick?
71 2013-05-19T20:40:17 <sharky93> i don't understand it completely why is it an antipattern
72 2013-05-19T20:40:32 <TheSheep> because you are mixing code with html
73 2013-05-19T20:40:45 <TheSheep> also, it forces you to have a global function
74 2013-05-19T20:41:14 <TheSheep> and that function is not very universal
75 2013-05-19T20:42:39 <sharky93> hmm, the third point is what made me write it like that, ThomasWaldmann once suggested that onload, the script has to go through the entire DOM only to find that such a class does not exist since we'll have to load it on all pages, that is a drawback
76 2013-05-19T20:42:45 <sharky93> what do you think ?
77 2013-05-19T20:43:29 <TheSheep> if you do it by id, then it's just a dict lookup, as fast or faster as onclick
78 2013-05-19T20:44:04 <TheSheep> if you want to microoptimize such things, you really should measure first, anyways
79 2013-05-19T20:45:28 <sharky93> TheSheep, hmm i understand now :)
80 2013-05-19T20:46:05 * ThomasWaldmann didn't want to micro-optimize, but i didn't knew it is very fast.
81 2013-05-19T20:46:08 <TheSheep> sharky93: and if you are doing onclick, it has to call eval() on a string
82 2013-05-19T20:46:58 <TheSheep> ThomasWaldmann: browsers keep a mapping of id->element
83 2013-05-19T20:47:12 <TheSheep> ThomasWaldmann: so for id lookups they don't actually traverse the DOM
84 2013-05-19T20:48:08 <sharky93> i was not aware of the mapping backend it uses, sorry
85 2013-05-19T20:48:41 <TheSheep> lets just make it nice and clean :)
86 2013-05-19T20:49:57 <TheSheep> sharky93: by the way, when you are looking for syblings, wouldn't it be better to look for the closest <input type="file">, instead of a specific id?
87 2013-05-19T20:50:15 <TheSheep> sharky93: then we could reuse it in any place where there is a file upload form
88 2013-05-19T20:50:24 <TheSheep> siblings*
89 2013-05-19T20:50:26 * ThomasWaldmann runs moin2 tests with updated EmeraldTree
90 2013-05-19T20:52:25 *** ana_ananasova
91 2013-05-19T20:52:31 <sharky93> TheSheep, you mean search for the closest <input type="file"> even if it is not a sibling ?
92 2013-05-19T20:53:36 <TheSheep> sharky93: no, just search for a sibling that is an input tag with type="file"
93 2013-05-19T20:54:16 <TheSheep> sharky93: instead of searching for any sibling with the id="f_content_form_data_file"
94 2013-05-19T20:54:47 <TheSheep> this way it will work with other forms, or when you rename that field
95 2013-05-19T20:54:59 <sharky93> TheSheep, i am not a 100% sure, but from what i learnt going through the template files, any place in moin if it has a input with type="file" it will have the id "f_content_form_data_file"
96 2013-05-19T20:55:39 <TheSheep> sharky93: what if there are two?
97 2013-05-19T20:56:02 <sharky93> it still remains the same, hence the use of "this" with sibling.
98 2013-05-19T20:56:13 <sharky93> i tried inserting two forms
99 2013-05-19T20:56:31 <TheSheep> you mean there are two elements with the same id?
100 2013-05-19T20:56:33 <TheSheep> that's a bug
101 2013-05-19T20:56:36 <sharky93> yep it is
102 2013-05-19T20:57:20 <TheSheep> so, it will probably change in the future, so don't rely on it
103 2013-05-19T20:57:58 <TheSheep> just do .siblings('input[type="file"]')
104 2013-05-19T20:58:04 <TheSheep> should work the same
105 2013-05-19T20:58:22 <sharky93> hmm, okay, i'll try it right away.
106 2013-05-19T20:59:31 <sharky93> btw, i still haven't seen a use case in moin with multiple upload boxes.
107 2013-05-19T20:59:44 <TheSheep> yeah, but we never know
108 2013-05-19T20:59:45 <TheSheep> :)
109 2013-05-19T20:59:51 <TheSheep> we want to be future-proof
110 2013-05-19T20:59:57 <sharky93> yeah, sure!
111 2013-05-19T21:03:05 <sharky93> TheSheep, yes works as expected
112 2013-05-19T21:03:09 <ThomasWaldmann> waldi: some work done on EmeraldTree, see http://hg.moinmo.in/EmeraldTree
113 2013-05-19T21:03:36 <ThomasWaldmann> (the builtin tests now work on 2.7 and 3.3, the moin2 tests also still work the same)
114 2013-05-19T21:03:53 <TheSheep> sharky93: then just use a class instead of an id on that clearing button, and we can have as many of them on a page as we want
115 2013-05-19T21:04:46 <sharky93> the lookups for classes is also a dict lookup ?
116 2013-05-19T21:05:13 <sharky93> just curious :)
117 2013-05-19T21:05:48 <sharky93> TheSheep, ^
118 2013-05-19T21:06:18 <TheSheep> sharky93: no idea in that case, but you can be sure that they are optimized
119 2013-05-19T21:06:39 <TheSheep> sharky93: you can write a quick js program that compares it
120 2013-05-19T21:06:55 <TheSheep> doing 1000 lookups by id and 1000 lookups by class
121 2013-05-19T21:08:52 <sharky93> btw TheSheep what's your timezone ? umm. easier is what's the time their currently ? :D
122 2013-05-19T21:08:58 <sharky93> *there
123 2013-05-19T21:09:29 <TheSheep> sharky93: CEST
124 2013-05-19T21:09:33 <TheSheep> 23:09
125 2013-05-19T21:09:47 <sharky93> till when are you usually available ?
126 2013-05-19T21:10:41 <TheSheep> I should be going to bed around now, I'm normally online 9:00-17:00 (at work) and then 18:30-23:00
127 2013-05-19T21:11:34 <TheSheep> but if you highight me on a channel, I will reply as soon as I'm online
128 2013-05-19T21:11:53 <TheSheep> highlight
129 2013-05-19T21:12:51 <sharky93> ok, i'll get the patch ready, then highlight you
130 2013-05-19T21:16:28 <TheSheep> sharky93: what timezone are you?
131 2013-05-19T21:17:00 <sharky93> UTC +5:30
132 2013-05-19T21:17:13 <sharky93> its a monday, here 02:50
133 2013-05-19T21:17:28 <TheSheep> ouch
134 2013-05-19T21:18:00 <sharky93> i've probably sleep in a while too :)
135 2013-05-19T21:18:05 <sharky93> *i'll
136 2013-05-19T21:19:06 <sharky93> umm, should we consider changing 1054 @ https://codereview.appspot.com/9104050/diff/17001/MoinMoin/themes/foobar/static/css/stylus/main.styl to class too ?
137 2013-05-19T21:19:23 <sharky93> or maybe leave it for when we actually develop a use case for multiple uploads ?
138 2013-05-19T21:19:25 <sharky93> TheSheep, ^
139 2013-05-19T21:19:51 <TheSheep> yeah, obviously
140 2013-05-19T21:20:17 <TheSheep> hmm, but then you don't have a way to refer to the file input
141 2013-05-19T21:20:25 <sharky93> hmm
142 2013-05-19T21:20:27 <TheSheep> well, no cross-platform way
143 2013-05-19T21:20:50 <TheSheep> input[type="file"] should work in most browsers older then ie6, I think
144 2013-05-19T21:20:59 <TheSheep> than*
145 2013-05-19T21:21:27 <sharky93> so you suggest adding a class to that with the onload
146 2013-05-19T21:21:52 <TheSheep> no, let's not mix code and style
147 2013-05-19T21:22:12 <TheSheep> #moin-modify dd input[type="file"] { ... }
148 2013-05-19T21:22:48 <sharky93> hmm, right! :P, i guess i should sleep a bit early
149 2013-05-19T21:27:49 <TheSheep> goodnight
150 2013-05-19T21:29:14 <sharky93> good night
151 2013-05-19T21:33:54 *** ebo^
152 2013-05-19T21:34:48 *** sharky93
153 2013-05-19T21:39:29 *** sharky93
154 2013-05-19T21:43:33 * ThomasWaldmann just filed https://bitbucket.org/jek/flatland/issue/10/who-is-using-flatland-and-is-still
155 2013-05-19T22:20:25 *** ronny_
156 2013-05-19T22:56:46 *** ebo_
157 2013-05-19T22:57:19 *** ebo_
158 2013-05-19T23:00:05 *** ebo^
159 2013-05-19T23:08:52 *** sharky93
160 2013-05-19T23:29:16 *** Gnarlodious
161 2013-05-19T23:56:18 *** sharky93
162
