1 2013-04-12T00:08:12  *** spy_ has quit IRC
   2 2013-04-12T01:11:01  *** dwcramer has joined #moin-dev
   3 2013-04-12T01:37:28  *** desophos has quit IRC
   4 2013-04-12T01:51:08  *** desophos has joined #moin-dev
   5 2013-04-12T02:52:49  *** RogerHaase has joined #moin-dev
   6 2013-04-12T03:05:23  *** desophos has quit IRC
   7 2013-04-12T03:06:20  *** desophos has joined #moin-dev
   8 2013-04-12T03:45:00  *** dwcramer has quit IRC
   9 2013-04-12T04:07:01  *** dwcramer has joined #moin-dev
  10 2013-04-12T04:15:31  <RogerHaase> http://rn0.ru/show/Z0rY4Hdh6HR9OILa6th4/ here is one about a week old
  11 2013-04-12T04:19:10  *** desophos has quit IRC
  12 2013-04-12T05:03:14  *** dwcramer has quit IRC
  13 2013-04-12T05:05:03  <sharky93> ThomasWaldmann, dreimark some tests in converter/_tests, are being skipped, one of them being test_html_out.py, because of 'lxml' not being "installed" why is it not specified to install with quickinstall ?
  14 2013-04-12T05:17:32  *** ronny has joined #moin-dev
  15 2013-04-12T05:32:52  <dreimark> sharky93: we want to remove lxml completly and use emeraldtree too
  16 2013-04-12T05:34:12  <RogerHaase> gn
  17 2013-04-12T05:34:16  *** RogerHaase has left #moin-dev
  18 2013-04-12T05:36:17  <sharky93> dreimark, can you give some pointers on how torewrite that test (test_html_out.py) especially https://bitbucket.org/thomaswaldmann/moin-2.0/src/7c00da767896/MoinMoin/converter/_tests/test_html_out.py?at=default#cl-176
  19 2013-04-12T05:36:41  <sharky93> my guess is, for testing html_out.py, one needs to check the state of "doc" before this https://bitbucket.org/thomaswaldmann/moin-2.0/src/7c00da767896/MoinMoin/items/content.py?at=default#cl-244
  20 2013-04-12T05:36:53  <sharky93> but how can I generate that in the first place to pass to html_out for testing ?
  21 2013-04-12T05:36:55  <sharky93> dreimark, ^
  22 2013-04-12T05:40:30  <sharky93> ThomasWaldmann, ^^
  23 2013-04-12T05:43:58  <sharky93> with the current state of test_html_out.py, (6 failed , 7 passed ) after installing 'lxml' .. it is almost impossible for me to write a test for the svg change!
  24 2013-04-12T05:47:43  <dreimark> sharky93: do you write a test_image now?
  25 2013-04-12T05:50:41  <dreimark> look into test_link or test_smiley
  26 2013-04-12T05:53:59  <sharky93> dreimark, but do we want to remove 'lxml' ?
  27 2013-04-12T05:54:52  *** puneet has quit IRC
  28 2013-04-12T05:55:18  *** puneet has joined #moin-dev
  29 2013-04-12T05:55:37  <sharky93> the tests wont run without 'lxml'
  30 2013-04-12T06:00:08  <sharky93> dreimark, so test_html_out.py has to be ignored ?
  31 2013-04-12T06:01:25  <sharky93> i was thinking of adding a method to test_html_out
  32 2013-04-12T06:05:14  <sharky93> btw test_smiley gives an Error
  33 2013-04-12T06:07:39  <dreimark> sharky93: remove 'lxml' is on the projects idea page
  34 2013-04-12T06:08:34  <dreimark> as long it isn't removed we can only use lxml for the tests
  35 2013-04-12T06:10:01  *** desophos has joined #moin-dev
  36 2013-04-12T06:10:04  <sharky93> so, I should write the test keeping test_link in picture (runs without lxml)
  37 2013-04-12T06:13:00  <dreimark> if doable yes, if not it is just another test which needs to be converted later
  38 2013-04-12T06:13:03  <dreimark> bbl
  39 2013-04-12T06:21:18  <sharky93> ThomasWaldmann, dreimark can you direct me to some documentation on emeraldtree.
  40 2013-04-12T06:26:40  <sharky93> dreimark, is there some known issue with writing that kind of tests ? as in any specific reason for you to think it as not doable, apart from the fact that im still new to this..
  41 2013-04-12T07:57:40  *** ronny has quit IRC
  42 2013-04-12T08:39:40  *** greg_f has joined #moin-dev
  43 2013-04-12T08:58:49  *** kuzman0v has joined #moin-dev
  44 2013-04-12T08:59:01  *** kuzman0v has left #moin-dev
  45 2013-04-12T09:39:29  <sharky93> getting the hang of tests now :D, TDD is good!
  46 2013-04-12T10:04:37  *** desophos has quit IRC
  47 2013-04-12T10:24:58  <ThomasWaldmann> moin
  48 2013-04-12T10:27:54  <sharky93> moin
  49 2013-04-12T10:28:47  <ThomasWaldmann> sharky93: emeraldtree is similar to elementtree, so to get a rough overview, you can read that one's docs, too. it differs in some aspects, so for the details, read the emeraldtree README and docstrings.
  50 2013-04-12T10:29:35  <sharky93> ThomasWaldmann, I am trying to write a test for the svg in img enhancement #360, as dreimark suggested I read up test_link.py and am trying to implement something like https://bitbucket.org/thomaswaldmann/moin-2.0/src/7c00da767896c6cf52d94b1b1d936d480abe94b9/MoinMoin/converter/_tests/test_link.py?at=default#cl-106
  51 2013-04-12T10:29:46  <ThomasWaldmann> it's not very big, btw, so you could also just read the src
  52 2013-04-12T10:31:32  <ThomasWaldmann> that's arather special test for transclusions and links of items
  53 2013-04-12T10:33:10  <sharky93> IMO, one needs to check the state of "doc" for "svg" items before this https://bitbucket.org/thomaswaldmann/moin-2.0/src/7c00da767896/MoinMoin/items/content.py?at=default#cl-244 and get it into the "html_conv" converter and check for output ?
  54 2013-04-12T10:34:42  <ThomasWaldmann> yeah, do 2 tests: markup>dom and dom>html
  55 2013-04-12T10:35:28  <sharky93> so dom>html being the part I mentioned
  56 2013-04-12T10:36:09  <ThomasWaldmann> doing the other one first might make sense
  57 2013-04-12T10:37:42  <sharky93> hmm, yeah, since i'm in a fix as to how to incorporate the IRI portion of the "href" in the test, doing something like has been done in test_link.py (the line i mentioned earlier)
  58 2013-04-12T10:39:39  <sharky93> the IRI portion i'm referring to -> http://rn0.ru/show/o3zqqjebXrNbwg12mzVo/
  59 2013-04-12T10:49:35  <sharky93> ThomasWaldmann, ^
  60 2013-04-12T10:51:12  <ThomasWaldmann> well, having a unique id in there is a bit harder to test. you could extract the path and throw a regex match at it
  61 2013-04-12T10:51:24  * ThomasWaldmann gtg, bbl
  62 2013-04-12T10:53:51  <sharky93> ThomasWaldmann, yeah I agree to that. But my basic question is since I am creating the DOM by writing XML as in https://bitbucket.org/thomaswaldmann/moin-2.0/src/7c00da767896c6cf52d94b1b1d936d480abe94b9/MoinMoin/converter/_tests/test_link.py?at=default#cl-106
  63 2013-04-12T10:54:46  <sharky93> how can I create such a DOM which has an attribute to "href" like this "Iri(scheme=None, authority=None, path=IriPath(u'/+get/+2882c905b2ab409fbf79cd05637a112d/svgtest'), query=None, fragment=None)"
  64 2013-04-12T10:54:53  <sharky93> ThomasWaldmann, ^
  65 2013-04-12T11:00:59  <sharky93> please reply when you're back
  66 2013-04-12T11:03:39  <waldi> sharky93: <test xmlns="test:" href="/+get/+2882c905b2ab409fbf79cd05637a112d/svgtest"/>
  67 2013-04-12T11:08:02  <sharky93> waldi, that is what I had guessed :), now will have to confirm by running html_conv over this DOM
  68 2013-04-12T11:09:10  <sharky93> waldi, is it somehow because in html_conv it will convert Iri(...) finally to the same href ? and if the href is specified already in that form it wont transform it ?
  69 2013-04-12T11:10:03  <waldi> sharky93: you always have to use the constructor, nothing makes sure that the tree contains an object != unicode
  70 2013-04-12T11:12:38  <sharky93> but here i'm feeding the XML directly, for which a tree will be created
  71 2013-04-12T11:13:21  <sharky93> in the ideal case, html_conv gets the input as a tree which somewhat looks like http://rn0.ru/show/o3zqqjebXrNbwg12mzVo/
  72 2013-04-12T11:14:11  <sharky93> but here for creating that same DOM we are using XML like in https://bitbucket.org/thomaswaldmann/moin-2.0/src/7c00da767896c6cf52d94b1b1d936d480abe94b9/MoinMoin/converter/_tests/test_link.py?at=default#cl-106
  73 2013-04-12T11:15:28  <sharky93> waldi, will html_conv understand if the input is something like <test xmlns="test:" href="/+get/+2882c905b2ab409fbf79cd05637a112d/svgtest"/> directly, instead of being Iri(scheme=None, authority=None, path=IriPath(u'/+get/+2882c905b2ab409fbf79cd05637a112d/svgtest'), query=None, fragment=None)
  74 2013-04-12T12:05:22  <sharky93> waldi, thanks it is working I think, will have to get a cr
  75 2013-04-12T12:06:30  *** puneet has quit IRC
  76 2013-04-12T12:07:03  *** moin5 has joined #moin-dev
  77 2013-04-12T12:10:57  *** puneet has joined #moin-dev
  78 2013-04-12T12:24:03  *** moin5 has quit IRC
  79 2013-04-12T13:24:24  <sharky93> ThomasWaldmann, please review https://codereview.appspot.com/8660044 (basic test added for #360)
  80 2013-04-12T13:35:07  *** dwcramer has joined #moin-dev
  81 2013-04-12T14:15:43  *** ronny has joined #moin-dev
  82 2013-04-12T14:15:43  *** ronny has joined #moin-dev
  83 2013-04-12T14:22:27  *** rihnapstor has joined #moin-dev
  84 2013-04-12T14:44:26  *** rihnapstor has quit IRC
  85 2013-04-12T14:57:16  *** sharky93 has quit IRC
  86 2013-04-12T14:57:27  *** rihnapstor has joined #moin-dev
  87 2013-04-12T15:05:41  *** sharky93 has joined #moin-dev
  88 2013-04-12T15:16:42  *** puneet has quit IRC
  89 2013-04-12T15:20:20  *** dwcramer has quit IRC
  90 2013-04-12T15:36:15  *** dwcramer has joined #moin-dev
  91 2013-04-12T15:36:34  *** desophos has joined #moin-dev
  92 2013-04-12T15:56:05  *** dwcramer has quit IRC
  93 2013-04-12T16:06:37  <sunu> ThomasWaldmann: Great!! :D ( talking about whoosh pull request )
  94 2013-04-12T16:07:06  <sunu> So now whoosh should work well on gae. I'll give it a try.
  95 2013-04-12T16:09:41  *** dwcramer has joined #moin-dev
  96 2013-04-12T16:26:53  *** rihnapstor has quit IRC
  97 2013-04-12T16:39:38  *** dwcramer has quit IRC
  98 2013-04-12T16:46:17  *** rihnapstor has joined #moin-dev
  99 2013-04-12T17:37:21  <sharky93> at what point is the revision data, fetched and added to the Iri of the href for some item (say a jpeg) and change is made to the DOM ?
 100 2013-04-12T17:38:01  *** greg_f has quit IRC
 101 2013-04-12T17:43:16  *** desophos has quit IRC
 102 2013-04-12T17:47:56  *** desophos has joined #moin-dev
 103 2013-04-12T17:51:10  <desophos> is there a good way to get acquainted with the codebase? just delving into tickets is a bit overwhelming
 104 2013-04-12T18:10:30  *** dwcramer has joined #moin-dev
 105 2013-04-12T18:21:09  *** n00bz0rz has joined #moin-dev
 106 2013-04-12T18:24:32  *** dwcramer has quit IRC
 107 2013-04-12T18:29:57  *** dwcramer has joined #moin-dev
 108 2013-04-12T18:56:49  <desophos> i'd like to get started with moinmoin development, but i need some support
 109 2013-04-12T19:04:29  *** dwcramer has quit IRC
 110 2013-04-12T19:10:53  *** ashutosh1461 has joined #moin-dev
 111 2013-04-12T19:11:41  <ashutosh1461> moin everyone :)
 112 2013-04-12T19:13:24  <desophos> moin ashutosh1461
 113 2013-04-12T19:21:47  *** desophos has quit IRC
 114 2013-04-12T19:29:31  *** dwcramer has joined #moin-dev
 115 2013-04-12T19:34:29  *** dwcramer has quit IRC
 116 2013-04-12T19:48:01  *** desophos has joined #moin-dev
 117 2013-04-12T19:55:48  <ashutosh1461> ThomasWaldmann, are you free to discuss the issue (Rename uses comment from previous meta) ?
 118 2013-04-12T20:10:53  *** dwcramer has joined #moin-dev
 119 2013-04-12T20:22:26  *** rihnapstor has quit IRC
 120 2013-04-12T20:36:43  *** n00bz0rz has quit IRC
 121 2013-04-12T20:45:35  *** desophos has quit IRC
 122 2013-04-12T20:46:47  *** brunomartin has joined #moin-dev
 123 2013-04-12T21:03:34  *** dwcramer has quit IRC
 124 2013-04-12T21:12:48  *** marktraceur has quit IRC
 125 2013-04-12T21:18:43  *** n00bz0rz has joined #moin-dev
 126 2013-04-12T21:34:37  *** ashutosh1461 has quit IRC
 127 2013-04-12T21:56:39  *** desophos has joined #moin-dev
 128 2013-04-12T22:01:15  <ThomasWaldmann> desophos: did you read the docs?
 129 2013-04-12T22:01:28  *** desophos has quit IRC
 130 2013-04-12T22:13:25  *** desophos has joined #moin-dev
 131 2013-04-12T23:30:38  *** n00bz0rz has quit IRC
 132 2013-04-12T23:54:07  *** brunomartin has quit IRC
 133 2013-04-12T23:54:52  *** brunomartin has joined #moin-dev
 134 2013-04-12T23:56:05  *** n00bz0rz has joined #moin-dev
 135

MoinMoin: MoinMoinChat/Logs/moin-dev/2013-04-12 (last edited 2013-04-12 00:15:02 by IrcLogImporter)