1 2013-03-27T00:04:02 *** spinningarrow
2 2013-03-27T00:05:55 <ThomasWaldmann> ashutosh1461: well, after we decided that contenttype stuff, you can maybe finish that
3 2013-03-27T00:06:04 *** spinningarrow
4 2013-03-27T00:06:42 <ThomasWaldmann> (i mean the link/transclude button related code)
5 2013-03-27T00:07:00 <ThomasWaldmann> other than that, have a look at the issue tracker
6 2013-03-27T00:07:26 <ashutosh1461> umm .. fine, i have updated the code here https://codereview.appspot.com/7610050/
7 2013-03-27T00:07:56 <ashutosh1461> g2g now, gn :) bye!
8 2013-03-27T00:08:21 <ThomasWaldmann> ehrm that doesn't work that way
9 2013-03-27T00:08:46 <ThomasWaldmann> if you have different changesets, rather use different codereviews
10 2013-03-27T00:08:53 <ThomasWaldmann> gn :)
11 2013-03-27T00:10:40 *** ashutosh1461
12 2013-03-27T00:20:04 *** ronny_
13 2013-03-27T00:50:41 *** moin7
14 2013-03-27T00:59:54 *** spinningarrow
15 2013-03-27T01:35:58 *** spinningarrow
16 2013-03-27T01:42:23 *** spinningarrow
17 2013-03-27T01:56:49 <ThomasWaldmann> moin7: ah, already here
18 2013-03-27T01:57:41 <ThomasWaldmann> https://moinmo.in/GoogleSoc2013/InitialProjectIdeas start there and also read the pages linked from there
19 2013-03-27T02:23:36 *** banas
20 2013-03-27T05:17:08 *** rihnapstor
21 2013-03-27T05:17:34 *** rihnapstor
22 2013-03-27T05:17:34 *** rihnapstor
23 2013-03-27T06:07:33 *** ronny_
24 2013-03-27T06:10:06 *** banas
25 2013-03-27T06:17:08 *** banas
26 2013-03-27T06:20:03 *** rihnapstor
27 2013-03-27T06:32:36 *** rihnapstor
28 2013-03-27T07:09:05 *** rihnapstor
29 2013-03-27T07:09:12 *** rihen_
30 2013-03-27T07:23:27 *** moin7
31 2013-03-27T07:50:04 *** rihen_
32 2013-03-27T08:05:31 *** banas
33 2013-03-27T08:06:31 *** VJ
34 2013-03-27T08:26:02 *** ashutosh1461
35 2013-03-27T08:26:58 *** VJ
36 2013-03-27T08:54:39 *** greg_f
37 2013-03-27T08:58:17 *** banas
38 2013-03-27T09:02:31 *** banas
39 2013-03-27T09:07:47 *** greg_f
40 2013-03-27T09:09:14 *** greg_f
41 2013-03-27T09:24:55 *** ashutosh1461
42 2013-03-27T09:25:20 *** banas_
43 2013-03-27T09:26:57 *** banas
44 2013-03-27T09:36:54 *** ashutosh1461
45 2013-03-27T10:11:44 *** banas
46 2013-03-27T10:11:57 *** banas_
47 2013-03-27T10:17:39 *** banas_
48 2013-03-27T10:18:17 *** banas
49 2013-03-27T10:42:28 *** banas_
50 2013-03-27T10:43:00 *** banas_
51 2013-03-27T10:50:17 *** banas_
52 2013-03-27T10:54:28 *** banas
53 2013-03-27T11:16:19 *** ronny_
54 2013-03-27T11:24:53 *** ronny_
55 2013-03-27T11:32:32 *** ronny_
56 2013-03-27T12:23:17 *** ashutosh1461
57 2013-03-27T12:35:56 *** banas
58 2013-03-27T12:41:57 *** dave_largo
59 2013-03-27T12:58:19 *** ashutosh1461
60 2013-03-27T13:51:23 *** RogerHaase
61 2013-03-27T13:55:15 <ashutosh1461> RogerHaase, hi :) , I want to commit some changes related to the sub-item bugs, but my moin repo contains some changes that i did while solving the previous bug, should i discard those changes and start from scratch?
62 2013-03-27T14:00:47 <RogerHaase> ashutosh1461: hg diff > save.diff, then later you can do hg import --no-commit save.diff or...
63 2013-03-27T14:02:53 <RogerHaase> on windows I use tortoisehg and the commit tool allows you to select which files make up a commit - not sure that works in linux
64 2013-03-27T14:09:18 <dreimark> crecord extension makes it also easy to split commits
65 2013-03-27T14:11:58 <RogerHaase> http://test.moinmo.in/tortoisehg.png
66 2013-03-27T14:13:07 <ThomasWaldmann> ashutosh1461: yes, please have no unwanted changesets in your repo. it should be possible to pull everything from your repo without getting unwanted stuff.
67 2013-03-27T14:13:32 <ThomasWaldmann> if you didn't commit (make changesets) yet, it's easier, then you can decide now what to commit and what not
68 2013-03-27T14:15:07 <ashutosh1461> ThomasWaldmann, i meant to say that i made some changes while solving the rename bug, should i commit them as well ?
69 2013-03-27T14:21:16 <RogerHaase> ashutosh1461: maybe make a new CR and show us the problem of what you want to commit and not commit
70 2013-03-27T14:24:31 <ashutosh1461> RogerHaase, should I combine https://codereview.appspot.com/7610050/ and https://codereview.appspot.com/7856046/ and then commit ? as the pull request for 7856046 is pending?
71 2013-03-27T14:27:06 <RogerHaase> you have multiple repos, one for ...050 and one for ...046?
72 2013-03-27T14:28:20 <ashutosh1461> yes, as the pull request for 046 is not accepted yet.
73 2013-03-27T14:29:45 *** rihnapstor
74 2013-03-27T14:30:41 <RogerHaase> then on ...050 repo you commit, pull from tw bitbucket main repo to get changes, merge (+commit), then you pull from your bitbucket repo to pull in ...046, merge(+commit). but wait, make sure everyone agrees..
75 2013-03-27T14:31:20 *** rihnapstor
76 2013-03-27T14:31:45 *** rihnapstor
77 2013-03-27T14:33:00 *** MaikuMori
78 2013-03-27T14:34:33 *** MaikuMori
79 2013-03-27T14:37:02 <ashutosh1461> RogerHaase, i have already sent a pull request for 0046.
80 2013-03-27T14:38:47 <RogerHaase> that's fine, you can update you repo. when you push to your repoagain , you will have all these recent changes included. the 2041 rev is the cause of those appearing disappearing divs. http://test.moinmo.in/tortoisehg1.png
81 2013-03-27T14:43:30 <RogerHaase> does the ..050 have exactly what you want to commit? you could clone it and do a test for practice. on ...050 clone do commit, pull from tw bitbucket, merge, commit, pull from your bb repo, merge, commit, check the result
82 2013-03-27T14:44:07 <ashutosh1461> RogerHaase, checkout, https://bitbucket.org/ashu1461/moin-2.0/commits/63f8c1c7ec9bc0a150bd6f4184cdf5f3777c4c62
83 2013-03-27T14:51:23 <RogerHaase> do "hg incoming" on your repo
84 2013-03-27T14:57:37 <RogerHaase> ashutosh1461: ^^ that will show you changesets on tw's main repo that are not in your repo, should be at least one...
85 2013-03-27T14:58:43 <ThomasWaldmann> RogerHaase: btw, can you check that javascript insert link/insert markup discussion we had yesterday evening?
86 2013-03-27T14:59:27 <ThomasWaldmann> i think that code has a fundamental problem and it might get better and simpler by just not doing it, but just inserting NAMES (not full markup)
87 2013-03-27T15:04:10 <rihnapstor> moin everyone :)
88 2013-03-27T15:06:02 <sunu> ashutosh1461: In https://bitbucket.org/ashu1461/moin-2.0/commits/63f8c1c7ec9bc0a150bd6f4184cdf5f3777c4c62, you probably reversed every change you made to fix #346 in the previous commit. Have a look.
89 2013-03-27T15:06:02 <RogerHaase> ThomasWaldmann: I think the functionality is rather slick, presentation needs more work. As the functionality is seldom needed, we could use javascript to hide/show subitems based on client side local storage settings. Users could set subitems to hide and not see them.
90 2013-03-27T15:09:22 <ashutosh1461> sunu, yes i noticed that :) i am a bit confused right now. RogerHaase should i merge the changes of 346 and the current commit ?
91 2013-03-27T15:13:43 <RogerHaase> ashutosh1461: we need to slow down and not rush. you are having an hg learning experience :) We have all had them.
92 2013-03-27T15:18:39 <RogerHaase> ashutosh1461: what have your read about mercurial? normal flow is to get an up to date repo, make changes, commit, pull to get everyone else's changes, merge, commit, push...
93 2013-03-27T15:19:03 <ThomasWaldmann> RogerHaase: the fundamental issues is that moin supports arbitrary amounts of different markups (at some time using converter plugins)
94 2013-03-27T15:19:31 <ThomasWaldmann> and that piece of js needs to be adapted for each, so it knows the link/transclusion markup
95 2013-03-27T15:20:00 <rihnapstor> RogerHaase: i am more clear with your explain for issue #347 over here https://bitbucket.org/thomaswaldmann/moin-2.0/issue/347/navibar-link-for-home-should-be-item_root#comment-3514743. can the root_item be toggled for User/Admin or should i opt for firstalternatice ?
96 2013-03-27T15:20:10 <rihnapstor> *explaination
97 2013-03-27T15:20:11 <ThomasWaldmann> as that js code is not pluggable, ...
98 2013-03-27T15:21:15 <ThomasWaldmann> when using the text editor, users usually enter markup on their own, so it could be simplified to just "paste" the name
99 2013-03-27T15:21:45 <ThomasWaldmann> (so one saves remembering it and typing it in again)
100 2013-03-27T15:23:43 <RogerHaase> ThomasWaldmann: could each converter have a function that theme calls to embed name into appropriate markup?
101 2013-03-27T15:25:00 <ashutosh1461> RogerHaase, Thanks i am now getting it :)
102 2013-03-27T15:37:34 <RogerHaase> ashutosh1461: to sunu's point, I think you may have trashed your BB repo. To avoid pushing mistakes and corrections into main repo, probably delete it and make a new BB clone...
103 2013-03-27T15:44:21 <RogerHaase> then make a new clone on your PC, download ...046 patch from codereview, import patch, run tests, commit. then download ...050 patch from codereview, import patch, run tests, commit. Finally push to BB repo. Have you heard of "measure twice, cut once"?
104 2013-03-27T15:46:27 <ThomasWaldmann> RogerHaase: theoretically yes... - but that needs ajax-like stuff, dispatching to correct converter, ... - we don't have all that yet
105 2013-03-27T15:57:07 <RogerHaase> ThomasWaldmann: ah, didn't realize markup was buried in javascript function. We could fix that by passing markup down in moin-options-for-javascript div.
106 2013-03-27T16:00:08 <ThomasWaldmann> as the user can switch content-type to something different we would either have to pass infos about ALL markups or do it dynamically or just let it be
107 2013-03-27T16:01:33 * ThomasWaldmann thinks it would be best to strip it down for now to just "insert name" and do other stuff together with what we need to make it work correctly
108 2013-03-27T16:20:03 * rihnapstor brb
109 2013-03-27T16:20:07 *** rihnapstor
110 2013-03-27T16:28:05 <RogerHaase> ThomasWaldmann: passing constant info about all markups in template would be easier on server side, a bit more work in javascript. I was thinking about whether inserting links/transclusions from page trail might be useful.
111 2013-03-27T16:30:00 <RogerHaase> ThomasWaldmann: maybe kill it for now and open an enhancement issue to refine design of how it should work
112 2013-03-27T16:32:04 <ashutosh1461> RogerHaase, thanks for the help, the work is done :) http://goo.gl/UE9pP
113 2013-03-27T16:34:58 <RogerHaase> ashutosh1461: but you have a commit message of "hello"
114 2013-03-27T16:36:15 <ashutosh1461> that was a test commit, https://bitbucket.org/ashu1461/moin-2.0/commits/f5b9081da4836e8f544fc5b3b078f3918b9c2680 is the official one. :)
115 2013-03-27T16:37:49 <ashutosh1461> testing done, ============== 1 failed, 613 passed, 59 skipped in 44.90 seconds ===============
116 2013-03-27T16:42:40 <RogerHaase> https://bitbucket.org/ashu1461/moin-2.0/commits/all -- the commit messages are incorrect. a042dad should be something like "fix 346 item rename allows new name to reuse existing name" and f5b9081 commit message should say something like " fixes 335, 320, 351 ....."
117 2013-03-27T16:49:36 <RogerHaase> ashutosh1461: ^^ when I look at revision history for index.html, a description of hello is not helpful http://test.moinmo.in/tortoisehg2.png
118 2013-03-27T16:51:36 <ThomasWaldmann> and please use rather verbose commit msgs, not just numbers
119 2013-03-27T16:52:03 <ThomasWaldmann> tell what exactly you fixed / changed, look at hg diff for remembering better
120 2013-03-27T16:59:31 *** dave_largo
121 2013-03-27T17:01:25 <ashutosh1461> RogerHaase, fixed, https://bitbucket.org/ashu1461/moin-2.0/commits/all
122 2013-03-27T17:04:34 *** dave_largo
123 2013-03-27T17:04:46 *** rihnapstor
124 2013-03-27T17:06:44 *** rihnapstor
125 2013-03-27T17:07:01 <ThomasWaldmann> ashutosh1461: looks ok at first glance
126 2013-03-27T17:07:17 *** rihnapstor
127 2013-03-27T17:07:26 <RogerHaase> rihnapstor: sorry, missed your message, the next step for 347 is to propose a solution, no coding yet. I don't understand what you meant by toggled for User/Admin.
128 2013-03-27T17:12:33 <RogerHaase> rihnapstor: 347 may not be a good choice, the target is not well defined
129 2013-03-27T17:14:08 <ashutosh1461> RogerHaase, so what is the final decision regarding the transcluding/linking stuff ?
130 2013-03-27T17:14:11 <rihnapstor> RogerHaase: :) i meant that can we toggle the root_item = "Home" for Users and "Frontpage" for admin, or simply just eliminate the root link and keep icon as way to navigate to the root page.
131 2013-03-27T17:16:21 <RogerHaase> ashutosh1461: commit message on a52e0af may be overly verbose, but OK by me.
132 2013-03-27T17:16:39 <ThomasWaldmann> ashutosh1461: to simplify it to "insert name" and open an issue what's needed to change it back to insert link/transclusion markup
133 2013-03-27T17:20:17 <ashutosh1461> i read the point you made above, maybe we can simplify it to insert name for now and think about the link/transclusion markup later?
134 2013-03-27T17:21:49 <ThomasWaldmann> yes, that's what I just said :)
135 2013-03-27T17:22:14 <RogerHaase> rihnapstor: no, choose another issue to work on
136 2013-03-27T17:24:28 <rihnapstor> RogerHaase: ok
137 2013-03-27T17:24:30 <rihnapstor> ThomasWaldmann: we had discussed about the moin search bar attempting to make request to the server,even if the text field was empty ,so can we put this into issue tracker as a bug ?
138 2013-03-27T17:26:37 <ashutosh1461> ThomasWaldmann, are you fine with https://bitbucket.org/ashu1461/moin-2.0/commits/all , i mean should i send the pull request?
139 2013-03-27T17:27:19 <ThomasWaldmann> if you didn't make it worse in the last half hour: yes
140 2013-03-27T17:29:56 <ashutosh1461> :)
141 2013-03-27T17:31:20 *** greg_f
142 2013-03-27T17:38:02 <ashutosh1461> ThomasWaldmann, can i start working on simplifying the link/translusion thing to "insert name" ??
143 2013-03-27T17:50:46 <ThomasWaldmann> ashutosh1461: yes, sure.
144 2013-03-27T18:05:44 * ThomasWaldmann bbl
145 2013-03-27T18:10:18 *** rihnapstor
146 2013-03-27T18:23:41 *** rihnapstor
147 2013-03-27T18:25:09 *** rihnapstor
148 2013-03-27T18:25:17 *** rihnapstor
149 2013-03-27T18:25:57 *** rihnapstor
150 2013-03-27T19:19:12 <rihnapstor> ThomasWaldmann: i would like to solve issue #308 https://bitbucket.org/thomaswaldmann/moin-2.0/issue/308/remove-obsolete-html-table-attributes
151 2013-03-27T19:49:09 <ThomasWaldmann> rihnapstor: yeah, feel free.
152 2013-03-27T20:18:01 <ashutosh1461> ThomasWaldmann, should i remove the css and functions related to transcluding and linking buttons?
153 2013-03-27T20:24:13 <ThomasWaldmann> we still will have a button, but only one
154 2013-03-27T20:56:03 <dreimark> moin
155 2013-03-27T20:56:42 <dreimark> is that about the button in the edit bar ?
156 2013-03-27T20:57:08 <dreimark> something broke http://test.moinmo.in/Home
157 2013-03-27T21:11:09 *** dwcramer
158 2013-03-27T21:20:24 <rihnapstor> for issue #308 how can i test the atom.html ?
159 2013-03-27T21:23:19 *** dave_largo
160 2013-03-27T21:24:13 <ashutosh1461> ThomasWaldmann, check out https://codereview.appspot.com/7751045/ , i removed the link-action and transclude action classes and made an insertname class.
161 2013-03-27T21:25:10 <dreimark> rihnapstor: https://moinmo.in/MoinMoinChat/Logs/moin-dev/2013-01-26?highlight=%28atom%29#CA-9034a57c978dab53dc970856a966a575945f3048_51
162 2013-03-27T21:25:44 <dreimark> btw. you can easily search by entering e.g. t:MoinMoinChat/Logs/moin-dev/2013.* atom
163 2013-03-27T21:27:04 *** dwcramer
164 2013-03-27T21:29:25 <rihnapstor> thanks dreimark
165 2013-03-27T21:35:31 <dreimark> ashutosh1461: have you edited css or compiled stylus files
166 2013-03-27T21:37:21 <ashutosh1461> dreimark, yes, actually the class named need to be changed so editing of the css files was required.
167 2013-03-27T21:40:22 <ashutosh1461> needed*
168 2013-03-27T21:50:07 *** ronny
169 2013-03-27T21:50:07 *** ronny
170 2013-03-27T21:50:39 <dreimark> i meant it differently, have you edited the stylus files and then used stylus to create the css or have you edited both?
171 2013-03-27T21:54:28 <dreimark> gn
172 2013-03-27T21:54:49 <rihnapstor> dreimark:how can i use atom in moinmoin?
173 2013-03-27T22:00:50 <ashutosh1461> i edited both, gn :)
174 2013-03-27T22:01:57 * ashutosh1461 goes to sleep, has college tomorrow.
175 2013-03-27T22:02:00 *** ashutosh1461
176 2013-03-27T22:12:15 *** dwcramer
177 2013-03-27T22:25:08 * rihnapstor bed time, has college
178 2013-03-27T22:25:20 *** rihnapstor
179 2013-03-27T22:32:54 *** RogerHaase
180 2013-03-27T23:00:47 *** dwcramer
181 2013-03-27T23:21:37 *** xiaq
182 2013-03-27T23:21:46 *** xiaq
183 2013-03-27T23:22:12 *** xiaq
184
