1 2013-03-23T00:09:37 *** ronny
2 2013-03-23T01:42:40 *** spy_
3 2013-03-23T02:10:33 *** xorAxAx
4 2013-03-23T02:11:14 *** xorAxAx
5 2013-03-23T02:11:15 *** xorAxAx
6 2013-03-23T04:58:18 *** ashutosh1461
7 2013-03-23T05:53:38 *** ashutosh1461
8 2013-03-23T06:39:51 *** dwcramer
9 2013-03-23T07:37:24 *** ronny
10 2013-03-23T07:51:32 *** sharky
11 2013-03-23T09:38:19 *** rihnapstor
12 2013-03-23T10:24:50 *** ashutosh1461
13 2013-03-23T11:35:04 *** sharky
14 2013-03-23T11:54:20 *** rihnapstor
15 2013-03-23T12:20:14 *** greg_f
16 2013-03-23T12:24:34 <ThomasWaldmann> btw, if someone wants to do some UI work: i attached some minimalistic 2factor auth / otp code sample to the issue in the issue tracker
17 2013-03-23T12:25:21 <ThomasWaldmann> if we would improve the UI of that and integrate it into moin2, it would be a good improvement for security
18 2013-03-23T12:27:36 <ThomasWaldmann> btw, when playing with that yesterday, I also tried pillow. it just worked instead of PIL.
19 2013-03-23T12:32:11 <ashutosh1461> ThomasWaldmann, i want to work, but currently i am on the sub-items bug. Can i work on it after completing the sub-items bug?
20 2013-03-23T12:34:50 <ThomasWaldmann> whoever wants to start working on it will just make a comment on the issue tracker when doing so
21 2013-03-23T12:35:11 <ThomasWaldmann> but sure, first finish the current project :)
22 2013-03-23T12:36:14 * ThomasWaldmann gtg
23 2013-03-23T12:36:20 <ashutosh1461> hmm .. :)
24 2013-03-23T13:21:27 *** sharky
25 2013-03-23T13:48:27 *** ronny_
26 2013-03-23T13:51:44 *** ronny
27 2013-03-23T14:04:12 *** RogerHaase
28 2013-03-23T14:28:37 *** dwcramer
29 2013-03-23T14:37:33 <ashutosh1461> RogerHaase, earlier while accessing nested sub-items of the type (1/2/3) i was getting a TypeError: unhashable type: 'list' < line http://goo.gl/Vx8Tr >, but now suddenly the error got converted into another type of typerror and i am not able to recreate the previous type of error, should i ignore that for now?
30 2013-03-23T14:47:24 <RogerHaase> ashutosh1461: probably, we have 335 and 320 open dealing with names being lists. Sometimes one error can damage the index and cause another. Fixing the first error prevents the 2nd. I frequently delete the wiki data and rebuild it.
31 2013-03-23T14:49:14 *** dwcramer
32 2013-03-23T15:21:57 <RogerHaase> ThomasWaldmann: how did you test pillow? After downloading selftext.py and several lena.xxx, I got this on W/7: http://rn0.ru/show/eVZbzTcQ6lw093qpLnmP/
33 2013-03-23T15:45:42 *** haseeb
34 2013-03-23T15:49:22 *** haseeb
35 2013-03-23T15:58:12 *** sharky
36 2013-03-23T16:11:03 *** dwcramer
37 2013-03-23T16:11:58 <ashutosh1461> RogerHaase, the meta[NAME] is a list comprising of ?
38 2013-03-23T16:15:12 <RogerHaase> the original name and any aliases. When you create or modify an item, scroll down and add an alias to Name meta, like: "Home", "Home2"
39 2013-03-23T16:27:09 <ashutosh1461> RogerHaase, i guess we have a same rename like problem, what if we alias x into a previously existing item y ?
40 2013-03-23T16:29:30 <ashutosh1461> and should i solve #335 keeping multiple names in mind ?
41 2013-03-23T16:42:03 <RogerHaase> yes, and be aware of issue 320 as well
42 2013-03-23T16:52:01 <ashutosh1461> RogerHaase, please review https://codereview.appspot.com/7610050 .
43 2013-03-23T16:53:45 *** dwcramer
44 2013-03-23T17:03:44 *** rihnapstor
45 2013-03-23T17:13:04 *** rihnapstor
46 2013-03-23T17:15:33 *** dwcramer
47 2013-03-23T17:20:34 <RogerHaase> ashutosh1461: review done
48 2013-03-23T17:25:51 *** rihnapstor
49 2013-03-23T17:27:06 <ashutosh1461> hmm ... i see, my mistake. and in relation to rename bug, should i define an exception class in items/__init__.py and later import it to views.py ?
50 2013-03-23T17:33:21 *** haseeb
51 2013-03-23T17:33:58 *** dwcramer
52 2013-03-23T17:35:44 <RogerHaase> ashutosh1461: hmm, I think you define it and use it in __init__. I don't see a need to import to views...
53 2013-03-23T17:38:22 *** greg_f
54 2013-03-23T17:44:00 <RogerHaase> asutosh1461: scratch that, yes import it
55 2013-03-23T18:21:14 <ThomasWaldmann> moin
56 2013-03-23T18:22:04 <ThomasWaldmann> RogerHaase: i only used it for playing with otp/2factor, not with moin yet
57 2013-03-23T18:25:24 <ThomasWaldmann> RogerHaase: for moin2, the question is if the change to pillow is overall positive (platform support, available packages, etc.)
58 2013-03-23T18:26:08 <ThomasWaldmann> if it is completely compatible to PIL, we can also leave the choice to package builders and just use whatever is better for developers / virtualenv using admins in setup.py
59 2013-03-23T18:32:53 <ashutosh1461> RogerHaase, done https://codereview.appspot.com/7856046/#ps38001
60 2013-03-23T18:35:50 *** haseeb_
61 2013-03-23T18:39:46 *** haseeb
62 2013-03-23T19:02:15 <RogerHaase> ashutosh1461: done
63 2013-03-23T19:05:54 <ashutosh1461> RogerHaase, comments ??
64 2013-03-23T19:08:51 <RogerHaase> ThomasWaldmann: OK, I thought you knew of some special syntax like {{moin.png||size=200,rotate=90}} afaik none of that is supported yet
65 2013-03-23T19:09:46 <RogerHaase> ashutosh1461: sorry too many tabs open. I think I clicked publish on wrong one :)
66 2013-03-23T19:13:27 <ThomasWaldmann> RogerHaase: try +get on an image with params ?w=...&h=...&t=...
67 2013-03-23T19:15:34 *** haseeb_
68 2013-03-23T19:26:22 <ThomasWaldmann> MoinMoin/items/content.py 627++
69 2013-03-23T19:26:33 <rihnapstor> moin everyone :)
70 2013-03-23T19:26:53 *** haseeb
71 2013-03-23T19:27:04 <ThomasWaldmann> hi rihnapstor
72 2013-03-23T19:27:53 <rihnapstor> ThomasWaldmann: i am trying to fix issue #347 (item-"FrontPage") ,but i am no understanding few lines of code here http://dpaste.com/1032611/.
73 2013-03-23T19:28:52 <rihnapstor> where does self.cfg.navibar value come from ?
74 2013-03-23T19:30:06 <rihnapstor> *self.cfg.navi_bar used in the for loop
75 2013-03-23T19:32:07 <rihnapstor> i am more concerned about the "link_text" the navi_bar list returns.
76 2013-03-23T19:39:48 <ThomasWaldmann> rihnapstor: are you using current repo code? there was some recent change in that area.
77 2013-03-23T19:40:14 <ThomasWaldmann> ah, yes, you are
78 2013-03-23T19:40:24 * ThomasWaldmann just looked at the pastebin
79 2013-03-23T19:41:08 <ThomasWaldmann> it comes from the wiki config
80 2013-03-23T19:41:25 <ThomasWaldmann> (and that subclasses the builtin default config from MoinMoin.config.default
81 2013-03-23T19:41:27 <ThomasWaldmann> )
82 2013-03-23T19:44:47 <RogerHaase> ThomasWaldmann: still trying, result of +get...?w=200: http://rn0.ru/show/OY90p4Hr0JYJcHpNGFlz/ Also trying to install pillow on w/8, starting problem there is MS seems to have removed C++ 2008 from download center and pip does not work with 2010 or 2012 versions.
83 2013-03-23T19:47:53 <ThomasWaldmann> RogerHaase: rihnapstor: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/347 updated
84 2013-03-23T19:48:34 <ThomasWaldmann> the joy of non-pure-python packages :|
85 2013-03-23T19:49:17 <ThomasWaldmann> RogerHaase: can you file a bug to pillow? do they provide binary packages?
86 2013-03-23T19:55:49 <RogerHaase> ThomasWaldmann: There are unofficial pillow binaries, haven't tried them yet, still googling: https://gist.github.com/adrianer/4672457 At the moment, first bug would go against pip for not supporting current compiler
87 2013-03-23T19:57:22 <ThomasWaldmann> yeah, whatever is appropriate
88 2013-03-23T20:06:51 <ThomasWaldmann> sunu: did you look at the failures in gae branch and where the additional one comes from
89 2013-03-23T20:10:32 <rihnapstor> ThomasWaldmann: i solved the issue #347.
90 2013-03-23T20:11:03 <rihnapstor> can i use send a patch with upload.py
91 2013-03-23T20:11:06 <rihnapstor> ?
92 2013-03-23T20:16:03 <ThomasWaldmann> upload.py is to get it reviewed, yes
93 2013-03-23T20:30:38 *** haseeb
94 2013-03-23T20:35:03 <ashutosh1461> RogerHaase, please check https://codereview.appspot.com/7610050/#ps5001 the sub-items one and rename one https://codereview.appspot.com/7856046/#ps45001
95 2013-03-23T20:35:27 <ashutosh1461> ignore the views.py file in 7610050
96 2013-03-23T21:03:27 *** ronny_
97 2013-03-23T21:11:49 <ashutosh1461> ThomasWaldmann, please review the final patch i guess, https://codereview.appspot.com/7862046
98 2013-03-23T21:20:34 *** haseeb
99 2013-03-23T21:23:48 <RogerHaase> ashutosh1461: run tests on subitems 761005 (lots of breakage), traceback after click on global index link, traceback creating subitems 2 levels deep. A guess is you will have to fix 320 too.
100 2013-03-23T21:26:22 <rihnapstor> ThomasWaldmann: can you please review my first patch here https://codereview.appspot.com/7719054/patch/1/5
101 2013-03-23T21:26:39 <RogerHaase> ashutosh1461: I did not run tests on rename patch, you should
102 2013-03-23T21:28:31 <ashutosh1461> RogerHaase, is the current fix alright for the linking thing ? i mean apart from the nested sub-items issue ?
103 2013-03-23T21:37:11 <RogerHaase> ashutosh1461: If I display a page with subitems, the links are now correct. But it breaks other things that are working...
104 2013-03-23T21:39:10 <rihnapstor> ThomasWaldmann: I have to go to church tommorow,so i am leaving now, please review my changes,i will rework on it tommorow.
105 2013-03-23T21:39:46 <rihnapstor> gn RogerHaase
106 2013-03-23T21:39:54 * rihnapstor bed time
107 2013-03-23T21:41:01 *** rihnapstor
108 2013-03-23T21:41:08 <ashutosh1461> RogerHaase, ok I will improve the code further. :)
109 2013-03-23T21:41:26 <ashutosh1461> g2g ! gn everyone !
110 2013-03-23T21:41:27 <RogerHaase> ======== 118 failed, 350 passed, 53 skipped, 179 error in 54.31 seconds ========
111 2013-03-23T21:42:15 *** ashutosh1461
112 2013-03-23T22:07:29 *** RogerHaase
113 2013-03-23T22:14:11 *** eSyr
114 2013-03-23T22:22:26 *** eSyr
115 2013-03-23T22:34:27 *** eSyr
116 2013-03-23T22:35:08 *** eSyr
117 2013-03-23T23:20:08 *** haseeb_
118 2013-03-23T23:20:21 *** haseeb
119
