1 2013-03-20T02:06:24 <sunu> ThomasWaldmann: yes. on gae branch 4 failed, 629 passed, 331 skipped in 50.08 seconds.
2 2013-03-20T02:10:22 <sunu> Doesn't work on deafult branch though.
3 2013-03-20T02:13:23 <sunu> http://rn0.ru/show/Fz41Xqg5KqOFHBXzTup8/
4 2013-03-20T03:57:34 *** Pods
5 2013-03-20T04:00:36 <Pods> Do i still need a virtenv if i am already working in a linux based os??
6 2013-03-20T04:00:55 <Pods> ^dreimark
7 2013-03-20T04:01:14 <sunu> Pods: yes.
8 2013-03-20T04:01:24 <Pods> why is that??
9 2013-03-20T04:02:53 <sunu> virtualenvs let you create isolated python environments. So it's great to use them for all of your python projects
10 2013-03-20T04:03:09 *** rihnapstor
11 2013-03-20T04:03:16 <Pods> okay thanks
12 2013-03-20T04:03:46 <sunu> Isolated environments make dependecy management easier. :)
13 2013-03-20T04:04:34 <Pods> yes, although uptil now i have been achieving that by modifying PYTHONPATH whereever needed :)
14 2013-03-20T04:04:37 *** rihnapstor
15 2013-03-20T04:04:37 *** rihnapstor
16 2013-03-20T04:04:37 *** rihnapstor
17 2013-03-20T04:10:37 <Pods> sunu : I have my virtualenv all setup here and ready to use, could you direct me as to how do you use moin with the same??
18 2013-03-20T04:14:29 <rihnapstor> Pods: type "moin" in the virtualenv directory ,which will start the server listening on 127.0.0.1
19 2013-03-20T04:14:48 <rihnapstor> and by default port :5000
20 2013-03-20T04:16:07 <Pods> rihnapstor : thanks :) will do
21 2013-03-20T04:26:18 <sunu> Btw Pods you don't have to create a virtualenv manually for moin. quickinstall creates it for you.
22 2013-03-20T04:26:20 *** sharky93
23 2013-03-20T04:30:45 *** rihnapstor
24 2013-03-20T04:32:02 *** AndChat|119664
25 2013-03-20T04:32:36 <Pods> oh..
26 2013-03-20T04:32:51 <Pods> so i already have moin2 installed via quickinstall
27 2013-03-20T04:32:59 <Pods> thats is good enough to start then
28 2013-03-20T04:33:07 <Pods> ^ sunu
29 2013-03-20T04:35:48 <Pods> also, I have worked in subversion earlier wherein patches etc were handled by svndiffs, what is the equivalent of that here ??
30 2013-03-20T04:45:07 <Pods> ThomasWaldmann : Are there any bugs I could tackle for the validation of wikis, or the DOM tree projects which you are mentoring
31 2013-03-20T05:00:37 <sunu> Pods: just activate that virtualenv. On linux/os x that'll be source env/bin/activate. Then run moin.
32 2013-03-20T05:01:03 <sunu> All this stuff is documented in the docs/ directory btw.
33 2013-03-20T05:01:30 <Pods> yes, so I am through with mercurial, generating patches with it and stuff
34 2013-03-20T05:02:06 <Pods> The generated patches could then be attached with the issues reported in their respective wiki pages is it??
35 2013-03-20T05:03:31 <sunu> A better alternative is fork the repo on bitbucket, edit code, get your code reviewed, once your changes are approved commit them, push your changes to your bitbucket repo and then send a pull request.
36 2013-03-20T05:07:55 <Pods> got it :) thanks
37 2013-03-20T05:15:44 *** ronny
38 2013-03-20T06:06:46 *** sharky93
39 2013-03-20T06:39:16 <Pods> Question : would I look at addressing Issue #348 in the source moin-2.0 / MoinMoin / auth / ldap_login.py ??
40 2013-03-20T06:42:05 *** haseeb
41 2013-03-20T06:42:05 *** haseeb
42 2013-03-20T06:51:53 <Pods> sunu : I have forked the repo, i am intending to make changes in the moin-2.0 / MoinMoin / apps / frontend / views.py file , how should I go about doing that??
43 2013-03-20T06:53:51 <Pods> ^ rihnapstor
44 2013-03-20T07:15:54 <ronny> Pods, not sure what you are asking for
45 2013-03-20T07:16:30 <Pods> ronny : I need to edit some source code on bitbucket to resolve the issues listed
46 2013-03-20T07:16:31 <ronny> usual process is make changes, maybe send patch to thereviewboard, send pull request
47 2013-03-20T07:16:51 <ronny> Pods, ah, so you have forked it, but not cloned to a local thing?
48 2013-03-20T07:16:59 <Pods> so the make changes part , (without the terminal) as sunu suggested i not working
49 2013-03-20T07:17:07 <Pods> I have a repo in my local machine
50 2013-03-20T07:17:17 <ronny> then you just need to edit the local file
51 2013-03-20T07:17:21 <Pods> so would making changes and say using hg would do
52 2013-03-20T07:17:24 <ronny> and maybe add a test
53 2013-03-20T07:17:36 <Pods> right ..:)
54 2013-03-20T07:17:39 <Pods> thanks ronny
55 2013-03-20T07:17:51 <ronny> Pods, basically you do the changes, then hg diff will tell them, and hg commit will add them to the repo
56 2013-03-20T07:17:59 <ronny> after commit you can push the changes to bitbucket
57 2013-03-20T07:44:05 <Pods> yes got it :) thanks a lot ronny
58 2013-03-20T07:46:47 <ronny> np, hf
59 2013-03-20T08:00:34 <Pods> running test_frontend.py gives me the error :Traceback (most recent call last): File "test_frontend.py", line 15, in <module> from MoinMoin.apps.frontend import views ImportError: No module named MoinMoin.apps.frontend
60 2013-03-20T08:00:39 <Pods> Any fix ??
61 2013-03-20T08:00:41 <Pods> ^ ronny
62 2013-03-20T08:01:51 <ronny> Pods, not atm, currently i dont have a moin checkout, and no time to dig into it
63 2013-03-20T08:02:06 <Pods> okay thanks anyways :)
64 2013-03-20T08:10:17 <Pods> Okay figured the error
65 2013-03-20T08:21:54 <Pods> Cannot fetch index base URL http://pypi.python.org/simple/ , is the error I am getting when I try running pip install (say) flask , in order to run the tests for test_frontend.py
66 2013-03-20T08:22:08 <Pods> Can anyone help ??
67 2013-03-20T08:28:35 *** haseeb
68 2013-03-20T08:58:53 <ThomasWaldmann> try again, check your internet connection
69 2013-03-20T08:59:15 <ThomasWaldmann> if it still doesn't work, check for pypi mirrors
70 2013-03-20T09:02:48 <Pods> okay thans ThomasWaldmann
71 2013-03-20T09:04:07 <Pods> Also do i need to install all packages seperately for eg Werkzeug, flask etc
72 2013-03-20T09:14:36 <Pods> I installed a Werkzeug-0.3-py2.3.egg package from one of the mirrors and tried running it
73 2013-03-20T09:15:03 <Pods> It is still giving me an error when I try installing it with easy_install
74 2013-03-20T09:16:39 <Pods> ^ThomasWaldmann
75 2013-03-20T09:24:01 *** haseeb
76 2013-03-20T09:25:20 <Pods> Okay got it working :)
77 2013-03-20T09:40:17 <ThomasWaldmann> please just follow the docs when installing moin2
78 2013-03-20T09:44:16 *** greg_f
79 2013-03-20T09:46:19 *** Pods
80 2013-03-20T10:02:51 *** haseeb
81 2013-03-20T10:06:25 *** Pods
82 2013-03-20T10:08:46 <Pods> Have made changes in /moin-2.0/MoinMoin/config/default.py for solving issue #347 " Navibar link for Home should be item_root" , but when I use hg export tip > patch , it only gives the diff between subsequest revisions
83 2013-03-20T10:08:56 <Pods> And not the diff I require here
84 2013-03-20T10:10:45 <ThomasWaldmann> hg diff # gives diff between repo and workdir
85 2013-03-20T10:11:44 <Pods> thanks :)
86 2013-03-20T10:23:21 <Pods> Have generated a probable patch, in the scenarios I have seen before, we were supposed to mail the patches to the dev mailing list
87 2013-03-20T10:23:35 <Pods> How am i supposed to communicate the patch here ??
88 2013-03-20T10:23:44 <Pods> ^ThomasWaldmann
89 2013-03-20T10:24:28 *** haseeb
90 2013-03-20T10:27:52 <ThomasWaldmann> use codereview.appspot.com (upload.py)
91 2013-03-20T10:39:14 *** Pods
92 2013-03-20T10:50:50 <sunu> moin
93 2013-03-20T11:10:08 *** Pods
94 2013-03-20T11:12:43 <ThomasWaldmann> hi sunu
95 2013-03-20T11:14:39 *** haseeb
96 2013-03-20T11:22:05 <Pods> It seems since I called hg commit earlier upload.py cant find appropriate hg diff
97 2013-03-20T11:22:39 <Pods> Uploading it via the form manually is giving me an error saying Patch set contains no recognizable patches
98 2013-03-20T11:23:23 <Pods> ^ThomasWaldmann
99 2013-03-20T11:23:40 <ThomasWaldmann> i use upload.py (and i don't commit before)
100 2013-03-20T11:24:38 <ThomasWaldmann> see python upload.py --help
101 2013-03-20T11:25:08 <ThomasWaldmann> sunu: you can do some testing on gae branch, i updated it yesterday and it was a quite huge merge
102 2013-03-20T11:25:52 <ThomasWaldmann> and as the default branch does not show that include converter test failure, it would be interesting to find out when that was introduced
103 2013-03-20T11:29:39 *** Pods
104 2013-03-20T11:31:58 *** Pods
105 2013-03-20T11:37:41 <Pods> hg revert does not help me revert to the source code which I actually had prior to the commit . Any fix ??
106 2013-03-20T11:40:58 *** sharky93
107 2013-03-20T11:42:40 <ThomasWaldmann> there's a nice hgbook on the web
108 2013-03-20T11:42:45 <ronny> Pods, hg revert -r <id of previous commit>
109 2013-03-20T11:43:12 <ronny> hmm
110 2013-03-20T11:43:24 <ronny> but there will be another mess waiting
111 2013-03-20T11:43:30 <ronny> atm i dont have enough time tho
112 2013-03-20T11:43:51 <ThomasWaldmann> Pods: if you only did one wrong and local commit, consider rollback
113 2013-03-20T11:44:06 <ThomasWaldmann> (but first save your work to diff files)
114 2013-03-20T11:55:18 <Pods> okay
115 2013-03-20T12:10:47 *** sharky93
116 2013-03-20T12:21:27 <sunu> ThomasWaldmann: I have pulled the changes in the morning already. Those test results are for the newest code. Don't know what's going wrong with the tests in default branch though.
117 2013-03-20T12:23:56 *** bruno_
118 2013-03-20T12:24:15 <sunu> http://rn0.ru/show/Fz41Xqg5KqOFHBXzTup8/ - that's the make test output on default branch
119 2013-03-20T12:25:00 <sunu> 4 failed, 629 passed, 331 skipped in 50.08 seconds. on gae branch
120 2013-03-20T12:30:10 <sunu> and I am experiencing ImportErrors while tring to run on gae too
121 2013-03-20T12:30:12 <sunu> http://rn0.ru/show/12EDnfyee7utTkvULTzS/
122 2013-03-20T12:33:29 *** rihnapstor
123 2013-03-20T12:33:59 *** rihnapstor
124 2013-03-20T12:34:29 <sunu> flask exthook is supposed ti handle those imports
125 2013-03-20T12:35:15 <ThomasWaldmann> i have 1 failure on default branch (after fixing that pep8 issue recently)
126 2013-03-20T12:44:57 *** dave_largo
127 2013-03-20T12:47:48 <sunu> ThomasWaldmann: I get lots of pep8 errors. Is there a configuration I need to tweak ?
128 2013-03-20T12:54:34 <sunu> py.test -rs gives 1 failure on default.
129 2013-03-20T13:00:30 *** rihnapstor
130 2013-03-20T13:01:14 *** rihnapstor
131 2013-03-20T13:02:57 *** sharky93
132 2013-03-20T13:17:24 <sharky93> ThomasWaldmann, please review this, https://codereview.appspot.com/7897043
133 2013-03-20T13:26:14 <ThomasWaldmann> sunu: by just running make test? or how do you get them?
134 2013-03-20T13:26:22 <dreimark> ronny: Pods hg rollback, if it was the last action and it is not pushed to bitbucket
135 2013-03-20T13:28:51 <ThomasWaldmann> sharky93: do you run the code practically and the automated unit tests before asking for review?
136 2013-03-20T13:29:07 <sunu> ThomasWaldmann: if I run just make test I see lots of pep8 error.1 error is with py.test -rs
137 2013-03-20T13:32:01 <ThomasWaldmann> sunu: is that on gae branch or on default of on both?
138 2013-03-20T13:34:13 <sunu> on default only
139 2013-03-20T13:34:35 <rihnapstor> ThomasWaldmann: my latest version of moin 2.0 is unable to find cache module which terminates the local server .
140 2013-03-20T13:36:04 <sunu> ThomasWaldmann: 4 failed, 629 passed, 331 skipped in 51.05 seconds for gae
141 2013-03-20T13:36:27 <rihnapstor> ThomasWaldmann: the bug image here http://postimage.org/image/tqmau821d/full/
142 2013-03-20T13:37:04 <sunu> 1 blog, 1 issue tracker and 2 in converter in gae branch
143 2013-03-20T13:38:45 <sunu> rihnapstor: paste text, not images.
144 2013-03-20T13:40:56 <rihnapstor> ok sunu
145 2013-03-20T13:42:44 <ThomasWaldmann> sunu: i am interested in the pep8 fails. so how many do you have in both branches?
146 2013-03-20T13:47:39 <sunu> ThomasWaldmann: 1 on gae branch. the ticket one you just fixed for default.
147 2013-03-20T13:48:43 *** ronny_
148 2013-03-20T13:50:10 *** ronny
149 2013-03-20T13:50:15 <rihnapstor> server falis to load with revised version of moin 2.0 http://pastebin.com/RAYBwSe2
150 2013-03-20T13:50:16 <sunu> ThomasWaldmann: but in default tests fail with this traceback http://rn0.ru/show/Z56at6BA1mef0T1m1eQZ/
151 2013-03-20T13:51:18 <sunu> rihnapstor: update your env or build a new one.
152 2013-03-20T13:54:47 <rihnapstor> sunu: can you little more precise about which env you are talkiing about ?
153 2013-03-20T13:54:58 <rihnapstor> you mean virtualenv ?
154 2013-03-20T13:57:20 <sunu> yup
155 2013-03-20T13:58:30 <rihnapstor> ok
156 2013-03-20T14:09:52 <dreimark> rihnapstor: can you show the output of quickinstall please
157 2013-03-20T14:15:06 *** rihnapstor
158 2013-03-20T14:18:04 *** rihnapstor
159 2013-03-20T14:19:42 <rihnapstor> dreimark: output of quickinstall http://dpaste.com/1029032/
160 2013-03-20T14:21:19 * rihnapstor will be back within 15 minutes
161 2013-03-20T14:21:23 *** rihnapstor
162 2013-03-20T14:24:45 *** dave_largo
163 2013-03-20T14:25:55 <dreimark> "Bad md5 hash for package" ?
164 2013-03-20T14:27:10 <dreimark> Downloading Babel-0.9.6.tar.gz (1.8MB): 46kB downloaded
165 2013-03-20T14:27:23 <dreimark> sounds like interenet problems
166 2013-03-20T14:33:20 <sunu> ThomasWaldmann: cloned a fresh copy. Down to 1 error on default branch now. Everything is back to normal. \o/
167 2013-03-20T14:50:35 *** rihnapstor
168 2013-03-20T14:51:33 *** rihnapstor
169 2013-03-20T14:51:53 * rihnapstor is back
170 2013-03-20T14:58:11 *** rihnapstor
171 2013-03-20T15:01:13 *** rihnapstor
172 2013-03-20T15:01:45 *** rihnapstor
173 2013-03-20T15:04:36 *** spy
174 2013-03-20T15:05:00 *** spy
175 2013-03-20T15:40:07 *** Guest3394
176 2013-03-20T15:48:29 * rihnapstor will be back after dinner
177 2013-03-20T15:48:37 *** rihnapstor
178 2013-03-20T15:50:05 *** ashutosh1461
179 2013-03-20T16:36:48 *** AndChat|119664
180 2013-03-20T16:37:17 *** AndChat|119664
181 2013-03-20T16:55:59 *** rihnapstor
182 2013-03-20T16:56:54 *** rihnapstor
183 2013-03-20T16:56:54 *** rihnapstor
184 2013-03-20T17:04:35 *** AndChat|119664
185 2013-03-20T17:07:01 *** ronny_
186 2013-03-20T17:07:09 *** Pods
187 2013-03-20T17:08:06 *** Pods
188 2013-03-20T17:09:48 <Pods> options_no_group_name refers to the options which are not prefixed automatically with their groupname in MoinMoin/config/default.py, where exactly are we parsing these from??
189 2013-03-20T17:10:00 <Pods> Do they take in data from wikiconfig.py too ??
190 2013-03-20T17:16:50 <Pods> ^ ThomasWaldmann : If you are free could you please clarify the same
191 2013-03-20T17:18:50 *** haseeb
192 2013-03-20T17:18:51 *** haseeb
193 2013-03-20T17:26:56 *** diofeher
194 2013-03-20T17:27:24 <ashutosh1461> is there an option to modify the page/item type ? like from going to MoinMoin item to plain-text ?
195 2013-03-20T17:28:05 <ThomasWaldmann> Pods: it's not parsed, the config is python and gets imported
196 2013-03-20T17:29:15 *** greg_f
197 2013-03-20T17:29:47 <Pods> ThomasWaldmann : What accesses these imported option names??
198 2013-03-20T17:32:17 <ThomasWaldmann> the code
199 2013-03-20T17:32:32 <ThomasWaldmann> search for "cfg"
200 2013-03-20T17:33:47 <Pods> yes, so that is the configure() function for auth
201 2013-03-20T17:34:03 <Pods> show_root()
202 2013-03-20T17:34:56 <Pods> So i believe the frontend uses this data. And whatever changes I make here will be reflected by the frontend?? Where am i accessing wikiconfig.py then??
203 2013-03-20T17:45:29 <ThomasWaldmann> moin loads the config and makes it available as app.cfg (iirc)
204 2013-03-20T17:45:49 <ThomasWaldmann> that's the class Config instance you define in wikiconfig
205 2013-03-20T17:47:50 <Pods> yes i meant to write app not auth there , sorry
206 2013-03-20T17:48:03 <Pods> That is the function show_root() accesses
207 2013-03-20T17:48:05 *** ronny_
208 2013-03-20T17:52:55 *** diofeher
209 2013-03-20T18:25:51 *** ronny_
210 2013-03-20T18:32:09 *** Pods
211 2013-03-20T18:41:34 *** haseeb
212 2013-03-20T18:49:02 *** rihnapstor
213 2013-03-20T19:00:45 *** ronny_
214 2013-03-20T19:02:52 <sharky93> ThomasWaldmann, I'm not able to understand if there is a logical mistake in reference to -> https://codereview.appspot.com/7897043/diff/16001/MoinMoin/themes/__init__.py
215 2013-03-20T19:17:40 *** Pods
216 2013-03-20T19:21:37 <sharky93> ThomasWaldmann, please review this, https://codereview.appspot.com/7897043, complete with tests (2 failed, one in blog and one in ticket.py), this should be the final fix.
217 2013-03-20T19:34:14 *** Pods
218 2013-03-20T20:32:36 *** haseeb
219 2013-03-20T20:58:17 <ashutosh1461> dreimark, i think there an error comes if you try to create nested subitems, i mean of the type <mainitem>/2/3 the mainitem page does not show up. and also what is the use of parent-id field in the meta data?
220 2013-03-20T21:00:45 <ashutosh1461> here is the error, https://bitbucket.org/ashu1461/code/commits/bc6d9259ea13f67cbb06d741d375b24e6f51c2af#chg-nested_subitems
221 2013-03-20T21:03:07 <ashutosh1461> ThomasWaldmann, ^^
222 2013-03-20T21:25:24 *** sharky93
223 2013-03-20T21:25:55 *** sharky93
224 2013-03-20T21:32:13 *** sharky93
225 2013-03-20T21:32:49 *** sharky93
226 2013-03-20T21:33:25 *** sharky93
227 2013-03-20T21:34:00 *** sharky93
228 2013-03-20T21:35:00 *** sharky93
229 2013-03-20T21:35:20 *** sharky93
230 2013-03-20T21:35:35 *** sharky93
231 2013-03-20T21:35:44 <dreimark> ashutosh1461: it is parentid, look here http://hg.moinmo.in/moin/2.0/log?rev=parentid
232 2013-03-20T21:35:47 *** sharky93
233 2013-03-20T21:36:05 *** sharky93
234 2013-03-20T21:38:02 <ashutosh1461> dreimark, and what about the subitems issue ?
235 2013-03-20T21:45:07 *** haseeb
236 2013-03-20T21:45:15 <dreimark> ashutosh1461: you talk about the TypeError: can only concatenate list (not "unicode") to list ?
237 2013-03-20T21:47:08 <dreimark> I guess that is since the namespace branch merge
238 2013-03-20T21:48:27 <dreimark> and it is a bug
239 2013-03-20T21:48:33 <ashutosh1461> dreimark, yes it is giving TypeError (TypeError: unhashable type: 'list').
240 2013-03-20T21:53:20 <dreimark> same issue is in blog.py
241 2013-03-20T22:04:24 <dreimark> ashutosh1461: ok, what is your suggestion for a fix
242 2013-03-20T22:09:22 <ashutosh1461> dreimark, what about introducing a new filed in the meta mainly referring to the base-item (or the parent item), and referring to that field while doing stuff, that would ease the implementation of issue#76 as well as the current bug.
243 2013-03-20T22:09:58 <ashutosh1461> new field*
244 2013-03-20T22:16:39 <ThomasWaldmann> re
245 2013-03-20T22:32:03 <ashutosh1461> dreimark, ^^ ?
246 2013-03-20T23:03:39 *** spy_
247 2013-03-20T23:04:29 *** ashutosh1461
248 2013-03-20T23:40:26 *** bruno_
249 2013-03-20T23:58:58 *** ronny_
250