MoinMoin: MoinMoinChat/Logs/moin-dev/2012-12-23

   1 2012-12-23T00:03:26  *** MattMaker has joined #moin-dev
   2 2012-12-23T12:06:04  *** spy has joined #moin-dev
   3 2012-12-23T12:15:09  *** greg_f has joined #moin-dev
   4 2012-12-23T13:54:03  *** ChanServ has quit IRC
   5 2012-12-23T13:54:05  *** ChanServ has joined #moin-dev
   6 2012-12-23T13:54:05  *** services. sets mode: +o ChanServ
   7 2012-12-23T15:58:20  *** RogerHaase has joined #moin-dev
   8 2012-12-23T16:08:58  *** Gnarlodious has joined #moin-dev
   9 2012-12-23T16:09:51  *** Gnarlodious has quit IRC
  10 2012-12-23T16:13:37  <ThomasWaldmann> moin
  11 2012-12-23T16:17:23  <RogerHaase> ThomasWaldmann: moin, I think I am waiting for cr on https://codereview.appspot.com/6928049/  and  https://codereview.appspot.com/6965051/
  12 2012-12-23T16:18:56  <ThomasWaldmann> done 1
  13 2012-12-23T16:35:40  *** greg_f has quit IRC
  14 2012-12-23T16:48:30  <ThomasWaldmann> RogerHaase: done the other one. somehow that part of the code feels way to complex/specialcased.
  15 2012-12-23T16:48:35  <ThomasWaldmann> too*
  16 2012-12-23T16:59:12  <RogerHaase> agree on complexity, will try to make better comments
  17 2012-12-23T17:04:16  <RogerHaase> ThomasWaldmann:  any chance of getting this misplaced doctype error fixed one way or another?  https://codereview.appspot.com/6421052/
  18 2012-12-23T17:08:45  <ThomasWaldmann> well, I was hoping that waldi looks at this issue or giving some feedback there ( https://bitbucket.org/thomaswaldmann/moin-2.0/issue/192 ), but it does not seem to happen
  19 2012-12-23T17:09:46  <ThomasWaldmann> RogerHaase: looking at that CR now...
  20 2012-12-23T17:13:14  <waldi> ThomasWaldmann: someone, not me, added this somewhere in the middle
  21 2012-12-23T17:13:58  <ThomasWaldmann> this == what exactly?
  22 2012-12-23T17:14:25  <waldi> outputting doctype
  23 2012-12-23T17:14:33  <waldi> it is neither in the html nor xml output
  24 2012-12-23T17:17:49  <ThomasWaldmann> serialize_start is a base class method (empty there)
  25 2012-12-23T17:18:44  <ThomasWaldmann> and it is currently doing something for xml and polyglot (x)html(5)
  26 2012-12-23T17:19:47  <ThomasWaldmann> but i am not interested in what it is doing currently, but rather what it should do
  27 2012-12-23T17:24:03  * ThomasWaldmann looks at the elementtree inside py 2.7
  28 2012-12-23T17:29:00  <ThomasWaldmann> http://hg.python.org/cpython/file/c502a2dc0345/Lib/xml/etree/ElementTree.py#l810 that's what they are doing for the xml case (we have somehow similar code)
  29 2012-12-23T17:32:54  <waldi> okay. time for a cleanup
  30 2012-12-23T17:40:28  <ThomasWaldmann> waldi: maybe we just give a flag to write, whether we want to have that xml / doctype declaration?
  31 2012-12-23T17:42:32  <waldi> done
  32 2012-12-23T17:47:11  <ThomasWaldmann> typos detected
  33 2012-12-23T17:47:31  <ThomasWaldmann> http://hg.moinmo.in/EmeraldTree/rev/77a556fb6e1f#l1.60
  34 2012-12-23T17:49:21  <ThomasWaldmann> you checked that self.encoding is always a valid encoding value (== a str with some reasonable value)?
  35 2012-12-23T17:49:55  <waldi> no. this is up to the caller
  36 2012-12-23T17:50:11  <waldi> and unicode.encode will fail anyway
  37 2012-12-23T17:53:41  <ThomasWaldmann> just search for ".encoding"
  38 2012-12-23T17:54:09  <ThomasWaldmann> line 1132 1261
  39 2012-12-23T17:56:16  <waldi> 1263 is the only user and uses it with unicode.encode
  40 2012-12-23T17:56:41  <waldi> okay, you can bolt in base64 and similar encoding that makes no real sense
  41 2012-12-23T17:57:41  <ThomasWaldmann> if one just uses the "None" default value, the code does not encode, but just write out what it has
  42 2012-12-23T17:57:51  <ThomasWaldmann> looks like it is made to work with str
  43 2012-12-23T17:58:10  <ThomasWaldmann> but the line you changed will fail then
  44 2012-12-23T17:58:18  <ThomasWaldmann> or put "None" in there...
  45 2012-12-23T17:59:03  <ThomasWaldmann> not sure if it makes any sense, but it looks inconsistent in that respect now
  46 2012-12-23T17:59:06  <waldi> ah, this one
  47 2012-12-23T17:59:28  <waldi> this part is not tested
  48 2012-12-23T18:00:54  <waldi> okay, better this way
  49 2012-12-23T18:05:03  <ThomasWaldmann> do they check for utf-8 and us-ascii because utf-8 is default and us-ascii is a subset?
  50 2012-12-23T18:06:01  <ThomasWaldmann> (still thinking whether it would not be more consistent to just check "if self.encoding: ..."
  51 2012-12-23T18:07:44  * ThomasWaldmann runs pycharm code checker on ET
  52 2012-12-23T18:08:21  <waldi> no, because utf-8 and ascii are explicit excempt from the xml definition
  53 2012-12-23T18:13:55  <ThomasWaldmann> waldi: have a look at tree.py:1239
  54 2012-12-23T18:40:05  <ThomasWaldmann> waldi: still there?
  55 2012-12-23T18:40:31  * ThomasWaldmann prepares some minor et patches
  56 2012-12-23T18:46:55  <waldi> not really
  57 2012-12-23T18:47:07  <waldi> i'm finishing up another project
  58 2012-12-23T18:49:12  <ThomasWaldmann> ok, i fix it myself, thanks so far
  59 2012-12-23T18:54:56  * ThomasWaldmann looks at tree.tostringlist()
  60 2012-12-23T18:56:03  <ThomasWaldmann> .tostring looks like a case for StringIO, .tostringlist somehow looks like not needed at all
  61 2012-12-23T19:08:57  * ThomasWaldmann pushed et changes
  62 2012-12-23T19:17:41  * ThomasWaldmann pushed fix for tree.py:1239
  63 2012-12-23T19:19:05  * ThomasWaldmann now fixing moin doctype bug
  64 2012-12-23T19:36:43  <moinBot> http://hg.moinmo.in/moin/2.0/rev/42b5d70289f9 2012-12-23 Thomas Waldmann <tw AT waldmann-edv DOT de>  require emeraldtree 0.9.2, fixes #192
  65 2012-12-23T19:46:12  <ThomasWaldmann> everybody: pip install --upgrade -e .
  66 2012-12-23T19:46:29  <ThomasWaldmann> RogerHaase: dreimark: sunu: ^
  67 2012-12-23T20:43:15  <RogerHaase> ThomasWaldmann:  :)
  68 2012-12-23T23:13:42  *** RogerHaase has left #moin-dev
  69 2012-12-23T23:25:44  <moinBot> http://hg.moinmo.in/moin/2.0/rev/df3e72208eed 2012-12-23 Thomas Waldmann <tw AT waldmann-edv DOT de>  catch exceptions happening in the converters, show time/url for crash and hint to look into the log file
  70 2012-12-23T23:32:34  *** spy has quit IRC
  71