MoinMoin: MoinMoinChat/Logs/moin-dev/2012-10-09

   1 2012-10-09T00:18:25  *** MattMaker has quit IRC
   2 2012-10-09T00:18:29  *** Trip has joined #moin-dev
   3 2012-10-09T00:32:23  *** RogerHaase has left #moin-dev
   4 2012-10-09T01:33:39  *** dwcramer has joined #moin-dev
   5 2012-10-09T01:45:14  *** dwcramer has quit IRC
   6 2012-10-09T01:56:44  *** dwcramer has joined #moin-dev
   7 2012-10-09T03:24:51  *** diofeher has joined #moin-dev
   8 2012-10-09T03:33:58  *** diofeher has quit IRC
   9 2012-10-09T03:56:03  *** moin8 has joined #moin-dev
  10 2012-10-09T03:56:28  <moin8> I found a security issue in moin-1.9.5. Who should the details go to?
  11 2012-10-09T03:56:34  *** moin8 is now known as jimrandomh
  12 2012-10-09T04:52:09  *** jimrandomh has quit IRC
  13 2012-10-09T04:52:56  *** jimrandomh has joined #moin-dev
  14 2012-10-09T05:15:04  <sunu> moin :)
  15 2012-10-09T05:15:09  *** dwcramer has quit IRC
  16 2012-10-09T06:43:36  *** moin0 has joined #moin-dev
  17 2012-10-09T06:47:44  *** moin0 has quit IRC
  18 2012-10-09T06:52:32  *** jimrandomh has quit IRC
  19 2012-10-09T08:53:21  *** brunomartin has joined #moin-dev
  20 2012-10-09T09:17:36  *** waldi has quit IRC
  21 2012-10-09T09:24:29  *** waldi has joined #moin-dev
  22 2012-10-09T09:24:31  *** waldi has joined #moin-dev
  23 2012-10-09T09:25:27  *** MattMaker has joined #moin-dev
  24 2012-10-09T09:27:51  *** Trip has quit IRC
  25 2012-10-09T09:42:17  *** spy has joined #moin-dev
  26 2012-10-09T10:30:38  <ThomasWaldmann> moin
  27 2012-10-09T11:25:02  *** greg_f has joined #moin-dev
  28 2012-10-09T12:09:17  <sunu> ThomasWaldmann: http://codereview.appspot.com/6628043/ needs a review :)
  29 2012-10-09T13:51:42  <dreimark> moin
  30 2012-10-09T15:10:29  *** dave_largo has joined #moin-dev
  31 2012-10-09T15:11:58  *** dwcramer has joined #moin-dev
  32 2012-10-09T15:22:47  <sunu> moinmoin theme on the ubuntu wiki looks really nice :)
  33 2012-10-09T16:00:09  <dreimark> :)
  34 2012-10-09T16:10:08  *** RogerHaase has joined #moin-dev
  35 2012-10-09T17:02:30  <dreimark> bbl
  36 2012-10-09T17:07:59  <ThomasWaldmann> sunu: review done
  37 2012-10-09T17:14:00  <RogerHaase> ThomasWaldmann: display svg object with IE8:  http://codereview.appspot.com/6634044/
  38 2012-10-09T17:20:27  <ThomasWaldmann> hi roger
  39 2012-10-09T17:20:41  <RogerHaase> moin :)
  40 2012-10-09T17:23:48  <ThomasWaldmann> RogerHaase: btw, we (waldi and me) will be in california soon :)
  41 2012-10-09T17:24:17  <RogerHaase> yes, I saw
  42 2012-10-09T17:24:49  <ThomasWaldmann> but due to the dates and routing we have, we likely can't leave CA
  43 2012-10-09T17:28:27  <RogerHaase> well, maybe next year...
  44 2012-10-09T17:44:58  <ThomasWaldmann> RogerHaase: done
  45 2012-10-09T17:47:09  <sunu> ThomasWaldmann: http://codereview.appspot.com/6628043 ready for review :)
  46 2012-10-09T17:52:30  <RogerHaase> ThomasWaldmann: reason for moving scripts from head to body is to mitigate this svgweb/jquery bug:  http://code.google.com/p/svgweb/issues/detail?id=621&q=jquery  (given simple web page with no svg objects and no other js, just loading svg.js and jquery.minified.js causes an error if js script tags are in the head -- only effects IE8-)
  47 2012-10-09T17:52:58  <RogerHaase> IE8- /  IE8 -
  48 2012-10-09T17:54:00  <RogerHaase> 8-) / IE8 -
  49 2012-10-09T17:56:12  <ThomasWaldmann> hmm, but doesn't this cause other troubles when done in body?
  50 2012-10-09T18:02:30  <RogerHaase> no, js files may be in head or in body.  There are some performance guru's (Steve Souders, otheres) that suggest putting scripts just before </body> has advantages.
  51 2012-10-09T18:05:13  <ThomasWaldmann> ah, ok. well, then ok, do it. maybe we just call it scripts then or body_scripts?
  52 2012-10-09T18:06:25  <RogerHaase> OK, will rename and push later -- gtg
  53 2012-10-09T18:06:35  *** RogerHaase has left #moin-dev
  54 2012-10-09T18:33:41  *** dwcramer has quit IRC
  55 2012-10-09T18:34:39  <sunu> ThomasWaldmann: http://codereview.appspot.com/6628043 updated
  56 2012-10-09T18:44:59  *** dave_largo has quit IRC
  57 2012-10-09T18:59:56  <ThomasWaldmann> sunu: i suggest you at least try to run your code before asking for review
  58 2012-10-09T19:13:32  <ThomasWaldmann> (and also read it thoroughly)
  59 2012-10-09T19:43:16  *** greg_f has quit IRC
  60 2012-10-09T20:24:01  <sunu> ThomasWaldmann:sorry. That was really silly :( sometimes I get way too much excited. Now fixed and I ran on gae this time :) http://codereview.appspot.com/6628043
  61 2012-10-09T20:31:58  <ThomasWaldmann> sunu: check if you got something. rietveld told me 2 times "AssertionError".
  62 2012-10-09T20:34:27  <sunu> ThomasWaldmann: a blank comment
  63 2012-10-09T20:35:27  <ThomasWaldmann> all blank?
  64 2012-10-09T20:35:38  <sunu> yeah.
  65 2012-10-09T20:35:54  <ThomasWaldmann> ok, I retry
  66 2012-10-09T20:43:59  <ThomasWaldmann> sunu: look now
  67 2012-10-09T20:47:01  <sunu> ThomasWaldmann: ok :)
  68 2012-10-09T20:57:20  <dreimark> re
  69 2012-10-09T21:25:40  *** RogerHaase has joined #moin-dev
  70 2012-10-09T22:38:41  *** dwcramer has joined #moin-dev
  71 2012-10-09T22:39:30  *** grzywacz has joined #moin-dev
  72 2012-10-09T22:41:13  *** spy has quit IRC
  73 2012-10-09T23:30:14  *** dwcramer has quit IRC
  74 2012-10-09T23:37:43  *** grzywacz has quit IRC
  75