1 2012-09-27T00:09:56 *** spy
2 2012-09-27T00:15:10 <RogerHaase> ThomasWaldmann: one more review: http://codereview.appspot.com/6554072/
3 2012-09-27T00:34:52 *** RogerHaase
4 2012-09-27T00:36:06 *** Trip_
5 2012-09-27T00:36:27 *** MattMaker
6 2012-09-27T00:47:11 *** ronny
7 2012-09-27T00:47:11 *** dennda__
8 2012-09-27T00:47:37 *** dennda_
9 2012-09-27T00:47:50 *** ronny
10 2012-09-27T01:03:51 *** brunomartin
11 2012-09-27T02:01:14 *** bilal
12 2012-09-27T02:03:18 *** bilal
13 2012-09-27T03:52:57 *** sunu
14 2012-09-27T06:21:52 *** sunu
15 2012-09-27T08:17:06 *** MaikuMori
16 2012-09-27T08:17:24 *** MaikuMori
17 2012-09-27T08:20:33 *** breton
18 2012-09-27T10:09:25 <dreimark> moin
19 2012-09-27T10:13:11 *** spy
20 2012-09-27T10:16:39 *** sunu
21 2012-09-27T10:54:47 <dreimark> ping spy
22 2012-09-27T11:25:02 *** sunu
23 2012-09-27T11:28:47 *** greg_f
24 2012-09-27T11:35:44 <spy> dreimark: hi! I just arrived home from a vacation. I saw your letter about Thomas changes, of course will look at this soon.
25 2012-09-27T12:31:06 <dreimark> spy: hope you enjoyed your vacation, good weather and so on
26 2012-09-27T12:46:53 <ThomasWaldmann> wb spy
27 2012-09-27T13:01:09 <dreimark> tbbl
28 2012-09-27T13:16:21 *** sunu
29 2012-09-27T13:37:47 *** sunu
30 2012-09-27T13:43:15 *** sunu
31 2012-09-27T13:45:59 <sunu> ThomasWaldmann: Hello again. I have been thinking on the issue you suggested me to work on.
32 2012-09-27T13:46:08 <sunu> As far I understand
33 2012-09-27T13:50:49 *** sunu
34 2012-09-27T13:51:59 *** sunu
35 2012-09-27T13:53:35 <ThomasWaldmann> sunu: your msg was truncated after "as far i understand"
36 2012-09-27T13:53:52 *** sunu_
37 2012-09-27T13:54:21 *** sunu_
38 2012-09-27T13:54:35 *** sunu_
39 2012-09-27T13:56:29 *** sunu
40 2012-09-27T13:59:19 *** sunu_
41 2012-09-27T14:00:07 *** sunu
42 2012-09-27T14:00:37 <sunu> ThomasWaldmann: Hello again. I have been thinking on the issue you suggested me to work on.
43 2012-09-27T14:00:41 <sunu> As far I understand
44 2012-09-27T14:01:03 <sunu> I need you provide the libraries which are only GAE specific in the support folder , then we can add all the other dependency libraries by using setup.py
45 2012-09-27T14:01:32 <sunu> For that I have to edit the Makefile .
46 2012-09-27T14:02:32 <sunu> Is it the right approach ?
47 2012-09-27T14:06:43 <sunu> and my connection here kinda sucks :'( . And the telephone department is not listening either ..so sorry for the troubles.
48 2012-09-27T14:08:22 <sunu> And there doesn't seem to be a way to install the packages anywhere other than the site-packages directory using setup.py too.
49 2012-09-27T14:08:41 <sunu> So I am a bit confused.
50 2012-09-27T14:14:20 <ThomasWaldmann> no, it should work (for the end user) without using setup.py
51 2012-09-27T14:15:23 <ThomasWaldmann> i think we need 2 Makefile targets: one is gaesupport with all the stuff gae needs, one is support, with same stuff + jinja2
52 2012-09-27T14:16:59 <ThomasWaldmann> (you could also look how many files jinja2 is, so we can maybe just ignore that GAE environment can offer it and just use our own copy, so we only have 1 support file for standalone and gae)
53 2012-09-27T14:17:47 <ThomasWaldmann> if it helps you, download moin 1.9.5 and look how it handles dependencies
54 2012-09-27T14:18:23 <sunu> so no need for setup.py , we just download the support folder ?
55 2012-09-27T14:18:34 <ThomasWaldmann> the change you need to do is likely < 10 lines total (not committing thousand of files :)
56 2012-09-27T14:18:51 <sunu> thats encouraging :)
57 2012-09-27T14:19:18 <ThomasWaldmann> yes, using some support tgz for both standalone pc install and also for gae
58 2012-09-27T14:19:57 <sunu> ok.. let me try.
59 2012-09-27T14:22:01 <ThomasWaldmann> also have a look into that MoinMoin/appengine_main.py - most of what you see there is NOT appengine specific, except these 3 "HACK" lines in the middle
60 2012-09-27T14:23:45 <ThomasWaldmann> so maybe we could modify that script so it is able to work on GAE (and it detects whether it is on GAE and does the needed stuff) AND on desktop PC (and just starts the run_simple webserver of werkzeug)
61 2012-09-27T14:23:53 <sunu> it adds all the directories in the support folder to the system path from what I guess ?
62 2012-09-27T14:24:18 <ThomasWaldmann> yes
63 2012-09-27T14:25:09 <sunu> ok. I am trying :)
64 2012-09-27T14:25:22 <ThomasWaldmann> maybe also consider that "moin" command we have when using virtualenv/setup.py - it not only starts the moin webserver, it also can be used as CLI for index operation and other stuff.
65 2012-09-27T14:25:38 <ThomasWaldmann> not sure if we could even integrate with that somehow
66 2012-09-27T14:25:55 <ThomasWaldmann> but try small steps :) and use codereview.appspot.com
67 2012-09-27T14:27:28 <sunu> yeah I already test uploaded a patch there to see how things work :D
68 2012-09-27T14:27:58 <ThomasWaldmann> it makes discussing code changes much easier
69 2012-09-27T14:28:41 <sunu> yeah the way it shows the new and old file and lets you comment is grest
70 2012-09-27T14:28:46 <ThomasWaldmann> btw, i guess you need to strip your bb repo from that big changeset you committed
71 2012-09-27T14:28:47 <sunu> great*
72 2012-09-27T14:29:10 <ThomasWaldmann> (and also remove it from your local repo)
73 2012-09-27T14:29:31 <sunu> yeah I have removed from local repo already
74 2012-09-27T14:29:49 <sunu> can I remove that comment I left somehow ?
75 2012-09-27T14:30:27 <sunu> that seems pretty darn useless :D
76 2012-09-27T14:30:43 <ThomasWaldmann> on the issue?
77 2012-09-27T14:30:47 <sunu> yeah
78 2012-09-27T14:31:35 <ThomasWaldmann> i deleted it
79 2012-09-27T14:32:11 <sunu> thanks :)
80 2012-09-27T14:35:13 <ThomasWaldmann> i added a comment about jinja2 on the issue
81 2012-09-27T15:08:49 *** sunu_
82 2012-09-27T15:09:35 *** sunu
83 2012-09-27T15:09:44 *** sunu_
84 2012-09-27T15:13:13 *** sunu_
85 2012-09-27T15:14:01 *** sunu_
86 2012-09-27T15:14:41 *** sunu
87 2012-09-27T15:20:03 *** sunu
88 2012-09-27T15:20:31 <sunu> ThomasWaldmann: http://codereview.appspot.com/6573061/diff/1/Makefile
89 2012-09-27T15:20:40 <sunu> please take a look :)
90 2012-09-27T15:23:59 <ThomasWaldmann> for what is that good for?
91 2012-09-27T15:24:36 <ThomasWaldmann> the stuff you removed is needed so somebody can build that moin2 support tgz you download in your new code
92 2012-09-27T15:35:58 *** sunu
93 2012-09-27T15:38:31 *** dwcramer
94 2012-09-27T15:47:07 *** sunu
95 2012-09-27T15:51:51 <sunu> ThomasWaldmann: cant that support file + jinja2 be used for installations without on pcs without gae too ?
96 2012-09-27T15:54:49 <ThomasWaldmann> please rephrase, I didn't understand that
97 2012-09-27T15:58:16 <sunu> I mean can't we use the downloaded support directory for simple servers ? or are there any other additional modules we need ?
98 2012-09-27T15:58:45 <ThomasWaldmann> as moin developers, we need a way to build that support archive
99 2012-09-27T15:58:57 <ThomasWaldmann> that is what the gaesupport makefile target is for
100 2012-09-27T15:59:30 <ThomasWaldmann> the users then can download that (or similar) archive to have an easy setup.py-less installation locally or on GAE
101 2012-09-27T16:00:27 <ThomasWaldmann> (btw, you can't expect users to have make or wget, not everybody is using linux)
102 2012-09-27T16:10:49 *** sunu
103 2012-09-27T16:20:40 *** RogerHaase
104 2012-09-27T17:06:08 *** dwcramer
105 2012-09-27T17:38:30 *** dwcramer
106 2012-09-27T18:01:10 *** sunu
107 2012-09-27T18:05:39 *** sunu
108 2012-09-27T18:12:05 *** sunu
109 2012-09-27T18:43:41 *** greg_f
110 2012-09-27T19:09:13 *** sunu
111 2012-09-27T19:10:54 *** sunu
112 2012-09-27T19:37:04 *** sunu
113 2012-09-27T19:39:21 *** sunu
114 2012-09-27T20:12:20 <sunu> ThomasWaldmann: then should i just have a Makefile target that just runs appengine_main.py's code to add support folder to path and then use some condition to do GAE specific hacks if applicabe ?
115 2012-09-27T20:12:38 <sunu> applicable ?*
116 2012-09-27T20:12:54 <sunu> BTW sorry for being a pain :)
117 2012-09-27T20:20:06 *** sunu_
118 2012-09-27T20:20:34 *** sunu_
119 2012-09-27T20:21:15 *** sunu_
120 2012-09-27T20:21:40 *** sunu
121 2012-09-27T20:21:53 *** sunu
122 2012-09-27T20:23:20 <sunu> getting frequently disconnected due to poor connection today :(
123 2012-09-27T20:30:49 *** sunu
124 2012-09-27T21:23:52 <RogerHaase> ThomasWaldmann: I updated setup and wikiconfig, any more changes before I push? http://codereview.appspot.com/6554072/
125 2012-09-27T21:28:18 <RogerHaase> on FooBar theme, there were no changes for IE7, IE8. Starting to take a look at global Index action bar because it is broken & inconsistent for all browsers on modernized; tiny problem on foobar.
126 2012-09-27T21:32:32 *** dwcramer
127 2012-09-27T22:10:44 <ThomasWaldmann> hi RogerHaase
128 2012-09-27T22:10:50 * ThomasWaldmann looks...
129 2012-09-27T22:14:15 <ThomasWaldmann> RogerHaase: done
130 2012-09-27T22:25:51 <RogerHaase> re. comment, I did read the xstatic docs but I do not see a clue on http://pypi.python.org/pypi?%3Aaction=search&term=xstatic&submit=search or http://pypi.python.org/pypi/XStatic-JSON-js/0.0.0.40f3377a63.1 that tells me the package name is json_js. The only way to determine the package name is to download the tar.gz and look at the path?
131 2012-09-27T22:28:20 <ThomasWaldmann> well, if one has built the env, it is in xstatic/pkg/*
132 2012-09-27T22:31:35 <RogerHaase> haha, OK, first change setup.py, build the env and then change wikiconfig.py. Will change the comment and push
133 2012-09-27T22:32:47 *** diofeher
134 2012-09-27T22:33:51 *** diofeher
135 2012-09-27T22:40:48 *** dwcramer
136 2012-09-27T22:50:42 <RogerHaase> ThomasWaldmann: pushed
137 2012-09-27T23:03:03 *** spy
138 2012-09-27T23:40:43 *** dwcramer
139
