MoinMoin: MoinMoinChat/Logs/moin-dev/2012-09-01

   1 2012-09-01T00:32:57  *** RogerHaase has left #moin-dev
   2 2012-09-01T02:23:08  *** CIA-73 has quit IRC
   3 2012-09-01T02:40:02  *** CIA-72 has joined #moin-dev
   4 2012-09-01T05:12:54  <xiaq> ThomasWaldmann: preludes to index changesets: http://codereview.appspot.com/6495072 http://codereview.appspot.com/6506060
   5 2012-09-01T05:12:57  <xiaq> dreimark: ^^
   6 2012-09-01T05:45:54  *** Trip_ has joined #moin-dev
   7 2012-09-01T05:46:59  *** MattMaker has quit IRC
   8 2012-09-01T06:29:44  <xiaq> ThomasWaldmann: http://codereview.appspot.com/6496071 (clean up items/{__init__,content}.py imports)
   9 2012-09-01T06:30:00  <xiaq> just some imports (re)moved
  10 2012-09-01T06:30:01  <xiaq> dreimark: ^^
  11 2012-09-01T06:30:27  <xiaq> PS. i followd the structure of imports in apps/frontend/views.py
  12 2012-09-01T06:38:46  <xiaq> ThomasWaldmann: http://codereview.appspot.com/6490068/
  13 2012-09-01T06:39:03  <xiaq> i was adding some timers to benchmark the index code when i noticed that timinga function is quite common and perhaps deserves a helper decorator.
  14 2012-09-01T07:04:38  *** Trip_ has quit IRC
  15 2012-09-01T07:09:15  *** MattMaker has joined #moin-dev
  16 2012-09-01T08:51:16  *** MattMaker has quit IRC
  17 2012-09-01T09:50:16  <xiaq> http://foundation.zurb.com/ an interesting frontend framework - worth looking at if mobile user is among moin2's target :)
  18 2012-09-01T09:53:07  <xiaq> it features prepackaged css supporting a responsive (=adapting to different screen sizes) column layout, css for ui elements, etc.
  19 2012-09-01T09:53:55  <xiaq> hm, the problem is that moin2's css classes need to be prefixed with 'moin-' so Foundation can't be used directly
  20 2012-09-01T09:54:16  <xiaq> also, it uses scss which overlaps with stylus which we are already using...
  21 2012-09-01T12:17:20  <ThomasWaldmann> moin
  22 2012-09-01T12:52:17  <ThomasWaldmann> xiaq: 2 reviews done (more or less)
  23 2012-09-01T12:57:07  <ThomasWaldmann> 3
  24 2012-09-01T13:06:37  <ThomasWaldmann> 4
  25 2012-09-01T14:08:52  <xiaq> ThomasWaldmann: updated http://codereview.appspot.com/6495072
  26 2012-09-01T14:14:53  <xiaq> ThomasWaldmann: updated http://codereview.appspot.com/6490068/
  27 2012-09-01T14:24:52  <xiaq> ThomasWaldmann: updated http://codereview.appspot.com/6496071/ (just 2 comments)
  28 2012-09-01T14:24:55  <xiaq> dreimark: ^^
  29 2012-09-01T14:25:23  <xiaq> ThomasWaldmann: commented http://codereview.appspot.com/6506060/
  30 2012-09-01T14:43:38  <ThomasWaldmann> ok, replied
  31 2012-09-01T14:44:13  <xiaq> ThomasWaldmann: so all ok? :)
  32 2012-09-01T14:46:09  <ThomasWaldmann> yes
  33 2012-09-01T15:02:48  *** ChanServ has quit IRC
  34 2012-09-01T15:04:40  * xiaq sent pull req
  35 2012-09-01T15:07:44  *** ChanServ has joined #moin-dev
  36 2012-09-01T15:07:44  *** kornbluth.freenode.net sets mode: +o ChanServ
  37 2012-09-01T15:10:45  <CIA-72> Cheer Xiao <xiaqqaix@gmail.com> default * 1763:347d11826f95 2.0/MoinMoin/items/ (__init__.py content.py): Clean up imports in items/{__init__,content}.py
  38 2012-09-01T15:10:50  <CIA-72> Cheer Xiao <xiaqqaix@gmail.com> default * 1764:19b19d4d9291 2.0/MoinMoin/ (items/content.py themes/__init__.py util/clock.py):
  39 2012-09-01T15:10:50  <CIA-72> Add a @timed decorator.
  40 2012-09-01T15:10:50  <CIA-72> The decorator adds flaskg.clock.{start,stop} calls to entrance and exit of a
  41 2012-09-01T15:10:50  <CIA-72> function.
  42 2012-09-01T15:10:51  <CIA-72> Cheer Xiao <xiaqqaix@gmail.com> default * 1765:54160346e469 2.0/MoinMoin/items/__init__.py:
  43 2012-09-01T15:10:51  <CIA-72> items/__init__.py: Add function get_storage_revision().
  44 2012-09-01T15:10:52  <CIA-72> Code is taken from Item.create, and may be useful at other places.
  45 2012-09-01T15:10:52  <CIA-72> Cheer Xiao <xiaqqaix@gmail.com> default * 1766:b78098593483 2.0/MoinMoin/templates/index.html:
  46 2012-09-01T15:10:53  <CIA-72> templates/index.html: Add macro render_entry.
  47 2012-09-01T15:10:53  <CIA-72> Code is taken from the "content" block, and may be useful at other places.
  48 2012-09-01T15:13:37  <ThomasWaldmann> waldi: http://codereview.appspot.com/6421052/ can you review that?
  49 2012-09-01T15:21:48  * xiaq commented on https://bitbucket.org/thomaswaldmann/moin-2.0/issue/46/unifying-item-names-with-suffix
  50 2012-09-01T15:22:09  <xiaq> because i got bitten a bit earlier...
  51 2012-09-01T15:27:53  <xiaq> ThomasWaldmann: http://codereview.appspot.com/6488071
  52 2012-09-01T15:28:34  <ThomasWaldmann> xiaq: see my comment there
  53 2012-09-01T15:28:40  <ThomasWaldmann> my old comment
  54 2012-09-01T15:29:43  <xiaq> yeah, i saw it. just adding some notes
  55 2012-09-01T15:48:39  <ThomasWaldmann> xiaq: review done
  56 2012-09-01T15:48:49  <ThomasWaldmann> http://codereview.appspot.com/6488071/
  57 2012-09-01T16:18:31  <xiaq> ThomasWaldmann: updated http://codereview.appspot.com/6488071/
  58 2012-09-01T17:07:19  *** RogerHaase has joined #moin-dev
  59 2012-09-01T17:09:52  <ThomasWaldmann> xiaq: will have a look soon, must do some travel preparations currently
  60 2012-09-01T17:16:48  *** CIA-72 has quit IRC
  61 2012-09-01T17:21:38  <xiaq> ThomasWaldmann: no problem
  62 2012-09-01T17:41:27  *** CIA-77 has joined #moin-dev
  63 2012-09-01T20:28:21  <ThomasWaldmann> https://i.chzbgr.com/completestore/12/8/24/ExQdOP1Db0-nHYP7aoyXfA2.jpg < happens if you fuck up your font's kerning
  64 2012-09-01T21:22:24  *** jaiditya has joined #moin-dev
  65 2012-09-01T21:22:32  <jaiditya> moin
  66 2012-09-01T21:22:41  <ThomasWaldmann> hey jaiditya
  67 2012-09-01T21:22:54  <ThomasWaldmann> feeling better again?
  68 2012-09-01T21:22:58  <jaiditya> I missed a lot
  69 2012-09-01T21:23:21  <jaiditya> yeah...its like comming back from hell
  70 2012-09-01T21:24:49  <jaiditya> what all I missed
  71 2012-09-01T21:24:49  <ThomasWaldmann> did they find what it was?
  72 2012-09-01T21:25:07  <RogerHaase> hi jaiditya, hope you are feeling better
  73 2012-09-01T21:25:53  <jaiditya> yeah, they said I over stressed for a long period, and had some really bad food which lead to some liver problem,
  74 2012-09-01T21:26:41  <jaiditya> also they said I should have a eye test
  75 2012-09-01T21:27:23  * ThomasWaldmann hopes it was not just due to SOC
  76 2012-09-01T21:28:04  <jaiditya> I believe it was not
  77 2012-09-01T21:29:33  <jaiditya> but it was difficult to live without my laptop
  78 2012-09-01T21:30:25  <ThomasWaldmann> my father bought a laptop when he was in hospital and noticed that a pc is unpractical for such purposes :D
  79 2012-09-01T21:30:47  <jaiditya> docs were too cruel, I begged them so much but still they didn't allowed me to take my laptop with me
  80 2012-09-01T21:31:33  *** dcramer_ has quit IRC
  81 2012-09-01T21:32:29  <jaiditya> fun part I taught my nurse to wish me moin instead of Good Morning
  82 2012-09-01T21:32:37  <jaiditya> :D
  83 2012-09-01T21:33:19  <ThomasWaldmann> haha
  84 2012-09-01T21:34:51  <jaiditya> but now after all that I think I am lagging behind
  85 2012-09-01T21:34:55  <ThomasWaldmann> btw, I updated test.moinmo.in a week or so ago
  86 2012-09-01T21:35:31  <ThomasWaldmann> you can read the repo history to get an overview
  87 2012-09-01T21:35:39  <jaiditya> I have to even submit my SOC code
  88 2012-09-01T21:35:48  <ThomasWaldmann> (and just ask if you have questions)
  89 2012-09-01T21:36:17  <ThomasWaldmann> http://moinmo.in/GoogleSoc2012 < see there "What you need to do after..."
  90 2012-09-01T21:38:00  <jaiditya> ThomasWaldmann: what does this means FIRSTREVTOINCLUDEHERE:
  91 2012-09-01T21:40:19  <jaiditya> RogerHaase: any update regarding stylus ?
  92 2012-09-01T21:40:19  *** ThomasWaldmann has quit IRC
  93 2012-09-01T21:40:19  *** ThomasWaldmann has joined #moin-dev
  94 2012-09-01T21:40:19  *** ThomasWaldmann has joined #moin-dev
  95 2012-09-01T21:40:19  <ThomasWaldmann> jaiditya: see the line below
  96 2012-09-01T21:40:44  <jaiditya> I mean first rev from my changeset or repo ?
  97 2012-09-01T21:41:23  <RogerHaase> jaiditya:  yes, I fixed the indent issue, and some typos I found via css validation
  98 2012-09-01T21:42:17  <RogerHaase> jaiditya:  these is one css validation issue I left for you, it complains about a negative padding value
  99 2012-09-01T21:42:40  <jaiditya> thats great, I'll look at the changset of yours
 100 2012-09-01T21:43:10  <jaiditya> RogerHaase: can you point me to that error
 101 2012-09-01T21:43:14  <ThomasWaldmann> jaiditya: you have that changeset also in your repo, just use that specific rev, it is just before soc began
 102 2012-09-01T21:43:33  <jaiditya> ok
 103 2012-09-01T21:43:55  <ThomasWaldmann> and as you are filtering for you name, it does not matter which repo you use, assuming that both repos have all your soc work
 104 2012-09-01T21:44:26  <jaiditya> ThomasWaldmann: and name means full name or bitbucket name
 105 2012-09-01T21:44:35  <jaiditya> I guess bitbucket name
 106 2012-09-01T21:44:37  <ThomasWaldmann> as seen in your changesets
 107 2012-09-01T21:44:42  <jaiditya> ok
 108 2012-09-01T21:44:47  <ThomasWaldmann> just use hg log|less
 109 2012-09-01T21:47:30  <jaiditya> got it
 110 2012-09-01T21:47:44  <ThomasWaldmann> jaiditya: btw, i think you were not online when I said that we are happy about all contributions that happened during SOC and invite all students to be also moin developers in future.
 111 2012-09-01T21:48:12  <jaiditya> :D
 112 2012-09-01T21:48:26  <jaiditya> I am loving it
 113 2012-09-01T21:50:18  *** MattMaker has joined #moin-dev
 114 2012-09-01T21:50:34  <jaiditya> ThomasWaldmann: "hg log -m" is not recognized in windows
 115 2012-09-01T21:50:45  <jaiditya> RogerHaase: ^
 116 2012-09-01T21:50:46  <ThomasWaldmann> http://moinmo.in/MoinMoinAcknowledgements < i also added all contributors there
 117 2012-09-01T21:50:49  <RogerHaase> jaiditya: http://jigsaw.w3.org/css-validator, type in http://test.moinmo.in -- see line 286 (I fixed 260, 393, 499, 506 on repo tip)
 118 2012-09-01T21:51:14  <ThomasWaldmann> jaiditya: on windows, you need a bit different command as it does not know that `...` trick
 119 2012-09-01T21:52:09  <ThomasWaldmann> hg log -M --template '{rev} ' -k 'Your Name as seen in the log' -r 359d51f0fa90: > exportrevs.cmd
 120 2012-09-01T21:53:07  <ThomasWaldmann> then edit exportrevs.cmd and just add hg export at the beginning and > my_changesets.txt at the end
 121 2012-09-01T21:53:19  <ThomasWaldmann> (all in one single line)
 122 2012-09-01T21:55:37  <jaiditya> exportrevs.cmd is a 0 byte file
 123 2012-09-01T21:55:52  <jaiditya> empty file
 124 2012-09-01T21:57:09  <ThomasWaldmann> jaiditya: then your name did not match precisely
 125 2012-09-01T21:57:57  <jaiditya> changeset:   1721:b2461859808c
 126 2012-09-01T21:57:58  <jaiditya> user:        Jaiditya Mathur <jaiditya.mathur@gmail.com>
 127 2012-09-01T21:57:58  <jaiditya> date:        Thu Aug 23 02:32:20 2012 +0530
 128 2012-09-01T21:57:58  <jaiditya> summary:     Theme delevopment documentation added
 129 2012-09-01T21:58:06  <jaiditya> from hg log
 130 2012-09-01T21:58:26  <jaiditya> so my name is Jaiditya Mathur
 131 2012-09-01T21:58:34  <jaiditya> right ?
 132 2012-09-01T21:58:45  <ThomasWaldmann> sure
 133 2012-09-01T21:59:14  <ThomasWaldmann> the commandline you used was...?
 134 2012-09-01T22:00:13  <jaiditya> hg log -M --template '{rev} ' -k 'Jaiditya Mathur' -r 359d51f0fa90: > exportrevs.cmd
 135 2012-09-01T22:01:28  <ThomasWaldmann> hmm, strange
 136 2012-09-01T22:01:37  <ThomasWaldmann> can you try " instead of ' ?
 137 2012-09-01T22:01:48  <ThomasWaldmann> or just use your first name?
 138 2012-09-01T22:02:16  * ThomasWaldmann tested the command on linux, works there
 139 2012-09-01T22:03:35  <jaiditya> RogerHaase: have you tried this ?
 140 2012-09-01T22:03:41  <jaiditya> ThomasWaldmann: none worked
 141 2012-09-01T22:04:39  <ThomasWaldmann> jaiditya: if you omit the -k '...' does it write all revnos then?
 142 2012-09-01T22:06:26  <RogerHaase> empty file
 143 2012-09-01T22:06:46  <ThomasWaldmann> hmm, wtf? hg bug?
 144 2012-09-01T22:07:39  <ThomasWaldmann> $ hg log -M --template '{rev} ' -r 359d51f0fa90:
 145 2012-09-01T22:07:41  <ThomasWaldmann> 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 ...
 146 2012-09-01T22:08:25  <ThomasWaldmann> $ hg log -M --template '{rev} ' -k 'Jaiditya' -r 359d51f0fa90:
 147 2012-09-01T22:08:29  <ThomasWaldmann> 1465 1466 1467 1468 1469 1470 1471 1472 1473 1475 1476 1477 1...
 148 2012-09-01T22:09:39  <ThomasWaldmann> $ hg --version
 149 2012-09-01T22:09:39  <ThomasWaldmann> Mercurial Distributed SCM (version 2.0.2)
 150 2012-09-01T22:10:33  <RogerHaase> I have version 2.2.1, no output for any of above commands
 151 2012-09-01T22:11:28  <jaiditya> just a min
 152 2012-09-01T22:12:32  <jaiditya> 2.1.1
 153 2012-09-01T22:12:43  <jaiditya> no output to any command
 154 2012-09-01T22:12:53  <ThomasWaldmann> jaiditya: does your linux still work? :)
 155 2012-09-01T22:13:30  <ThomasWaldmann> someone(tm) maybe should file a bug to mercurial about this
 156 2012-09-01T22:14:44  <jaiditya> ThomasWaldmann: no I removed it
 157 2012-09-01T22:15:17  <jaiditya> ThomasWaldmann: I was planning to completely remove windows and install linux
 158 2012-09-01T22:15:27  <jaiditya> after it
 159 2012-09-01T22:16:04  <jaiditya> else I'd be only stuck with windows only
 160 2012-09-01T22:16:29  <ThomasWaldmann> not enough disk space?
 161 2012-09-01T22:17:04  <jaiditya> exactly
 162 2012-09-01T22:17:44  <RogerHaase> hg history works,  have a lot of output
 163 2012-09-01T22:18:01  <ThomasWaldmann> jaiditya: new hdds or ssds aren't that expensive
 164 2012-09-01T22:18:24  <ThomasWaldmann> and if it is a ssd, it's even much faster
 165 2012-09-01T22:19:31  <jaiditya> already ordered one
 166 2012-09-01T22:19:51  <ThomasWaldmann> ah :)
 167 2012-09-01T22:20:02  <ThomasWaldmann> which brand/type?
 168 2012-09-01T22:20:44  <jaiditya> Seagate, 2TB
 169 2012-09-01T22:21:26  <ThomasWaldmann> ah, no ssd, but big :)
 170 2012-09-01T22:22:45  <jaiditya> ThomasWaldmann: http://www.flipkart.com/seagate-freeagent-goflex-desk-kit-2tb-hard-drive/p/itmczcjhef5gtrrg?pid=ACCCWP99XQFGGJGG&ref=0c410cd0-9c67-4d46-b285-154d24bce7a0
 171 2012-09-01T22:24:32  <ThomasWaldmann> it'll take a while to fill it via usb2 ;)
 172 2012-09-01T22:25:27  *** dcramer_ has joined #moin-dev
 173 2012-09-01T22:26:36  *** MattMaker has quit IRC
 174 2012-09-01T22:26:57  <jaiditya> I am in no hurry... ;)
 175 2012-09-01T22:27:16  <jaiditya> btw how to export my changestes now ?
 176 2012-09-01T22:27:36  <ThomasWaldmann> jaiditya: i can send it to you by email
 177 2012-09-01T22:27:37  <RogerHaase> I have output by removing all of the single quotes, but no spaces between teh revision numbers
 178 2012-09-01T22:28:12  <jaiditya> ThomasWaldmann: would be great...:)
 179 2012-09-01T22:28:31  <jaiditya> RogerHaase: using same commandline ?
 180 2012-09-01T22:29:02  <RogerHaase> http://rn0.ru/show/nO4hGGOI1MR5DUYqisat/
 181 2012-09-01T22:29:51  <jaiditya> that looks like some encryption
 182 2012-09-01T22:30:41  <RogerHaase> try with double quotes instead of single
 183 2012-09-01T22:32:11  <ThomasWaldmann> jaiditya: see inbox
 184 2012-09-01T22:32:25  <jaiditya> ThomasWaldmann: got it...thanks :)
 185 2012-09-01T22:33:08  <RogerHaase> http://rn0.ru/show/BRiQrOpDmAqi6ne6SS7Q/
 186 2012-09-01T22:34:19  <jaiditya> RogerHaase: works
 187 2012-09-01T22:34:58  <ThomasWaldmann> jaiditya: try if it works with "firstname lastname" also
 188 2012-09-01T22:35:29  <RogerHaase> http://stackoverflow.com/questions/4731334/hg-commit-m-my-changes-error -- windows shell only supports double quotes
 189 2012-09-01T22:35:39  <jaiditya> ThomasWaldmann: yes
 190 2012-09-01T22:37:49  <ThomasWaldmann> http://moinmo.in/GoogleSoc2012 < added the procedure there, please verify
 191 2012-09-01T22:38:11  <ThomasWaldmann> next SOC's students working with windows will thank you :)
 192 2012-09-01T22:40:15  <jaiditya> all thanks to RogerHaase:
 193 2012-09-01T22:41:06  <jaiditya> ThomasWaldmann: yeah, its correct
 194 2012-09-01T22:41:46  <ThomasWaldmann> ok, great :)
 195 2012-09-01T22:42:00  <ThomasWaldmann> teh wonders of windows commandline parsing :D
 196 2012-09-01T22:44:34  <jaiditya> ThomasWaldmann: now I need to compressit to a Jaiditya.Mathur.tar.gz
 197 2012-09-01T22:47:00  <ThomasWaldmann> jaiditya: i don't know about the precise google submission guidelines, but iirc they are happy with anything reasonable
 198 2012-09-01T22:47:25  <ThomasWaldmann> you can even include a link to your repo
 199 2012-09-01T22:48:22  <jaiditya> ok
 200 2012-09-01T22:49:20  <dreimark> re
 201 2012-09-01T22:52:48  <jaiditya> hi dreimark:
 202 2012-09-01T22:56:12  <dreimark> wb jaiditya
 203 2012-09-01T22:56:29  <dreimark> readed backlog, you were a bit stressed
 204 2012-09-01T22:56:58  <dreimark> and now feel better since you have your laptop
 205 2012-09-01T22:57:24  <jaiditya> yeah, I feel much powerfull now
 206 2012-09-01T22:58:24  <dreimark> :)
 207 2012-09-01T22:59:02  <dreimark> jaiditya: i added some issues to the main tracker and assigned you too
 208 2012-09-01T22:59:23  <jaiditya> looking
 209 2012-09-01T22:59:29  <dreimark> it is not a hurry but may be if you want fix it
 210 2012-09-01T23:00:17  <dreimark> i currently look at how to rip out some xstatic based items
 211 2012-09-01T23:12:14  <jaiditya> dreimark: looks minor fixes so better will resolve them soon
 212 2012-09-01T23:19:04  <dreimark> ThomasWaldmann: out log.py has l as name.
 213 2012-09-01T23:19:12  <dreimark> s/t/r/
 214 2012-09-01T23:19:31  *** MattMaker has joined #moin-dev
 215 2012-09-01T23:24:00  *** MattMaker has quit IRC
 216 2012-09-01T23:31:05  *** MattMaker has joined #moin-dev
 217