MoinMoin: MoinMoinChat/Logs/moin-dev/2012-08-29

   1 2012-08-29T00:08:12  *** dwcramer has quit IRC
   2 2012-08-29T00:30:54  *** RogerHaase has left #moin-dev
   3 2012-08-29T02:23:26  *** dwcramer has joined #moin-dev
   4 2012-08-29T04:13:28  *** hughperkins has joined #moin-dev
   5 2012-08-29T04:17:38  *** hughperkins has quit IRC
   6 2012-08-29T05:33:57  <xiaq> ThomasWaldmann: updated http://codereview.appspot.com/6480067/ (fix scripts)
   7 2012-08-29T05:34:24  <xiaq> ThomasWaldmann: http://codereview.appspot.com/6476067/ do you think the "X" needs translating?
   8 2012-08-29T05:43:26  *** dwcramer has quit IRC
   9 2012-08-29T07:36:52  <ThomasWaldmann> ThomasWaldmann: your last upload happened before my last review and I don't now what X you mean
  10 2012-08-29T07:37:01  <ThomasWaldmann> xiaq:
  11 2012-08-29T07:37:07  * ThomasWaldmann still asleep
  12 2012-08-29T07:44:09  <dreimark> ThomasWaldmann: http://codereview.appspot.com/6476067/diff/4006/MoinMoin/templates/index.html#newcode143
  13 2012-08-29T07:44:19  <dreimark> see my comment there
  14 2012-08-29T07:44:23  <dreimark> btw. moin
  15 2012-08-29T07:44:55  <dreimark> may be we should use the awesome font there
  16 2012-08-29T07:45:02  <dreimark> no neexd to translate it then
  17 2012-08-29T07:55:16  <ThomasWaldmann> of course there is no need for translation, but this should be a separate CS (and also other places should be checked)
  18 2012-08-29T07:59:42  <ThomasWaldmann> der mittlere platz auf meinem thinkpad ist noch frei :)
  19 2012-08-29T08:26:00  <ThomasWaldmann> http://codereview.appspot.com/6488048/ < oops
  20 2012-08-29T11:01:34  *** greg_f has joined #moin-dev
  21 2012-08-29T11:07:06  <dreimark> hmm, is the idea of template_dirs still working or is that broken now
  22 2012-08-29T11:08:57  <dreimark> MaikuMori: have you some time?
  23 2012-08-29T11:09:33  <MaikuMori> dreimark: sure, in about 5mins, filling out some forms -_-'
  24 2012-08-29T11:11:55  <dreimark> I am thinking currently about all those "plugins" we have added at https://bitbucket.org/thomaswaldmann/moin-2.0/src/bff62fea804a/wikiconfig.py#cl-64
  25 2012-08-29T11:12:10  <dreimark> and those we haven't added there
  26 2012-08-29T11:14:44  <MaikuMori> Ah I see, you mean Xstatic?
  27 2012-08-29T11:16:51  <MaikuMori> It's a bit tricky, on one side I think thomas intended them to be used across multiple projects, but on the other hand they could very easily be done with the plugin system. Or maybe make it so that both are supported.
  28 2012-08-29T11:17:04  <MaikuMori> dreimark: ^^ (done with forms btw)
  29 2012-08-29T11:17:30  <dreimark> MaikuMori: we don't change the XStatic package
  30 2012-08-29T11:17:45  <dreimark> we need anyway a MoinPlugin Package for each plugin
  31 2012-08-29T11:18:20  <dreimark> there you can tell install_requires=['XStatic-XXX']
  32 2012-08-29T11:18:21  <MaikuMori> Could wrap it or make it so that the plugins expose same API.
  33 2012-08-29T11:18:44  <MaikuMori> Well if you make the plugins as external packages, you can do the same thing.
  34 2012-08-29T11:19:01  <dreimark> yes currently trying with mathjax
  35 2012-08-29T11:19:11  <MaikuMori> Ah
  36 2012-08-29T11:19:32  <MaikuMori> Is mathjax supported already?
  37 2012-08-29T11:19:34  <dreimark> I need a some jscript into a template added
  38 2012-08-29T11:19:52  <MaikuMori> ah
  39 2012-08-29T11:20:06  <dreimark> MaikuMori: yes, http://moin-20.readthedocs.org/en/latest/admin/configure.html?highlight=template_dirs
  40 2012-08-29T11:20:20  <dreimark> search on the page there
  41 2012-08-29T11:20:31  <dreimark> Adding XStatic Packages
  42 2012-08-29T11:20:39  <MaikuMori> Ah I see
  43 2012-08-29T11:20:42  <dreimark> this is far to complicated for a user
  44 2012-08-29T11:21:08  <dreimark> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/212/mathjax-docs
  45 2012-08-29T11:21:37  <dreimark> a) of that issue should be possible to solve having it a plugin
  46 2012-08-29T11:21:42  <MaikuMori> Hmm, currently there is no way to overrite a single theme file using my plugins. Unless you do something really funky.
  47 2012-08-29T11:21:58  <MaikuMori> There are 2 things that come to mind:
  48 2012-08-29T11:22:38  <MaikuMori> Have some sort of automatic install which can patch files (but can't be done unless templates are not in site-packages).
  49 2012-08-29T11:22:52  <dreimark> undo is complicated
  50 2012-08-29T11:22:54  <MaikuMori> Ship custom template file, but then you have issues with different versions
  51 2012-08-29T11:23:17  <MaikuMori> Yeah undo is, but a lot php system handle it somehow as far as I remember.
  52 2012-08-29T11:23:52  <MaikuMori> But for these simple changes (injecting javascript/css) it could be done via some custom fuction
  53 2012-08-29T11:23:57  <MaikuMori> function*
  54 2012-08-29T11:24:17  <MaikuMori> Which just appends it to the template output.
  55 2012-08-29T11:24:39  <dreimark> i think we need something similiar to http://moin-20.readthedocs.org/en/latest/admin/configure.html?highlight=snippet#using-a-custom-snippets-html-template
  56 2012-08-29T11:24:44  <dreimark> but not only one
  57 2012-08-29T11:24:55  <dreimark> maybe n placeholders
  58 2012-08-29T11:25:00  <MaikuMori> Hmm
  59 2012-08-29T11:25:45  <MaikuMori> I haven't worked a lot with templates in moin, but some other frames used to have methods such as view.addJavaScript("path_or_script_text")
  60 2012-08-29T11:25:49  <MaikuMori> same for CSS
  61 2012-08-29T11:26:05  <dreimark> that sounds interesting
  62 2012-08-29T11:26:32  <MaikuMori> I'm quite sure it wouldn't be too hard to do with Jinja
  63 2012-08-29T11:26:43  <MaikuMori> And then you can expose it to plugins.
  64 2012-08-29T11:26:49  *** gwork has joined #moin-dev
  65 2012-08-29T11:27:31  <MaikuMori> It wouldn't be anything close to changing a line in template html code, but for these kinda javascript init calls it would work. Same with CSS, you could overwrite stuff with it.
  66 2012-08-29T11:29:13  <MaikuMori> http://stackoverflow.com/questions/4292630/insert-javascript-at-top-of-including-file-in-jinja-2
  67 2012-08-29T11:30:54  <dreimark> yeah reading
  68 2012-08-29T11:31:31  <MaikuMori> I think you could make it easier. Just some module to which you add JS/CSS files/sources and then that module generates the html which will be inserted into template.
  69 2012-08-29T11:32:21  <dreimark> it sounds like we need to generate template code on the fly
  70 2012-08-29T11:33:20  <xiaq> oh... i uploaded the latest patch set for "fix scripts" to "foobar deduplicate"...
  71 2012-08-29T11:33:29  <MaikuMori> Just the header bit with JS/CSS includes (and bottom bit if you want to support having JS files at the bottom of page for speedup)
  72 2012-08-29T11:33:37  * xiaq deleted latest patch set of "foobar deduplicate" and re-uploaded to "fix scripts"
  73 2012-08-29T11:33:40  <xiaq> ThomasWaldmann: http://codereview.appspot.com/6480067
  74 2012-08-29T11:33:40  <xiaq> dreimark: ^^
  75 2012-08-29T11:34:28  <MaikuMori> This xxx.addJavaScript() was very common in php frameworks way, way back when I used php.
  76 2012-08-29T11:34:42  <xiaq> ThomasWaldmann: also, is http://codereview.appspot.com/6476067/ (deduplicating foobar templates) good enough (except for a few things that is better kept in another changeset)?
  77 2012-08-29T11:37:29  <MaikuMori> dreimark: http://framework.zend.com/manual/en/zend.view.helpers.html#zend.view.helpers.initial.headscript this is more or less my idea.
  78 2012-08-29T11:45:09  <MaikuMori> It proably would be some sort of wrapper around python list and a template helper which inserts the content. So in main template you only write something like InsertScripts()
  79 2012-08-29T12:22:01  * xiaq updated pull req to ThomasWaldmann 
  80 2012-08-29T12:52:41  * dreimark looks
  81 2012-08-29T14:40:56  *** dave_largo has joined #moin-dev
  82 2012-08-29T15:01:22  <ronny> MaikuMori: i'd be very sceptical about stealing ideas from php frameworks, they fuck up so much
  83 2012-08-29T15:10:04  <ThomasWaldmann> yup, also be careful with stealing from wikipedia. we did that with those underscores in names == blanks equivalence and I deeply regretted it later.
  84 2012-08-29T15:10:13  <ThomasWaldmann> mediawiki*
  85 2012-08-29T15:49:09  * dreimark plays with namespace packages currently
  86 2012-08-29T15:49:44  <dreimark> yeah don't invent php security holes in python
  87 2012-08-29T16:21:37  *** gwork has quit IRC
  88 2012-08-29T16:28:51  *** dwcramer has joined #moin-dev
  89 2012-08-29T16:29:18  *** dcramer_ has joined #moin-dev
  90 2012-08-29T16:33:12  *** dwcramer has quit IRC
  91 2012-08-29T16:57:17  *** Gnarlodious has joined #moin-dev
  92 2012-08-29T16:59:38  *** Gnarlodious has quit IRC
  93 2012-08-29T17:05:18  <dreimark> how much template dirs can we have per theme, somehow i think i want a template subdir hook for each plugin
  94 2012-08-29T17:28:15  *** RogerHaase has joined #moin-dev
  95 2012-08-29T17:30:31  <dreimark> eSyr-ng: eSyr MaikuMori: http://rn0.ru/show/WBYoivh21upw1K6qFXqa/
  96 2012-08-29T17:31:35  <dreimark> I am playing with mathjax in an additional namespace pypi package requiring the xstatic package
  97 2012-08-29T17:33:21  <dreimark> currently I use the template_dirs parameter to load my own snippet.html
  98 2012-08-29T17:33:40  <dreimark> what are your plans for loading template code by a plugin
  99 2012-08-29T17:34:03  <dreimark> bbl
 100 2012-08-29T18:31:05  <RogerHaase> ThomasWaldmann:  fix for #213 transcluded heading underline length is inconsistent ready for review:  http://codereview.appspot.com/6494053/
 101 2012-08-29T19:44:22  *** greg_f has quit IRC
 102 2012-08-29T22:01:54  *** dcramer_ has quit IRC
 103 2012-08-29T22:17:13  *** dcramer_ has joined #moin-dev
 104 2012-08-29T22:48:41  *** dcramer__ has joined #moin-dev
 105 2012-08-29T22:52:28  *** dcramer_ has quit IRC
 106 2012-08-29T23:15:12  *** dave_largo has quit IRC
 107 2012-08-29T23:23:45  *** dcramer__ has quit IRC
 108 2012-08-29T23:27:49  *** MattMaker has quit IRC
 109 2012-08-29T23:28:16  *** MattMaker has joined #moin-dev
 110 2012-08-29T23:37:09  <RogerHaase> ThomasWaldmann: moved common converter classes to new module:  http://codereview.appspot.com/6501060/