MoinMoin: MoinMoinChat/Logs/moin-dev/2012-08-22

   1 2012-08-22T00:01:40  *** RogerHaase has left #moin-dev
   2 2012-08-22T00:10:55  <spy> ThomasWaldmann: one more pull request
   3 2012-08-22T00:20:38  * ThomasWaldmann looks
   4 2012-08-22T00:25:17  <CIA-79> Pavel Sviderski <pavel@psviderski.name> default * 1725:9a0b6e93fb3c 2.0/MoinMoin/items/_tests/test_Blog.py: Add and polish tests for Blog itemtype in test_Blog.
   5 2012-08-22T03:55:00  *** MattMaker has quit IRC
   6 2012-08-22T03:55:23  *** MattMaker has joined #moin-dev
   7 2012-08-22T04:10:21  <xiaq> ThomasWaldmann: comment reworked: http://codereview.appspot.com/6457091/
   8 2012-08-22T04:36:28  *** jaiditya has quit IRC
   9 2012-08-22T06:46:57  *** dwcramer has joined #moin-dev
  10 2012-08-22T07:13:43  *** dwcramer has quit IRC
  11 2012-08-22T08:16:08  *** liyan has joined #moin-dev
  12 2012-08-22T08:18:19  *** hughperkins has joined #moin-dev
  13 2012-08-22T08:47:25  *** hughperkins has quit IRC
  14 2012-08-22T08:49:19  *** hughperkins has joined #moin-dev
  15 2012-08-22T09:02:35  *** hughperkins has quit IRC
  16 2012-08-22T09:07:56  *** hughperkins has joined #moin-dev
  17 2012-08-22T09:08:11  <liyan> Hi Thomas, here is a draft of a selenium test script for account creation, login and logout:  http://rn0.ru/show/tMbpUk9u1jsdxfzEUpTk/
  18 2012-08-22T09:09:05  <liyan> And here is documentation:   http://rn0.ru/show/2rWgTzhFxgdbTsFd34Pq/
  19 2012-08-22T09:10:32  <liyan> What are the next steps for code review? Please note that appspot is blocked in China.
  20 2012-08-22T09:16:17  *** hughperkins has quit IRC
  21 2012-08-22T09:16:35  *** liyan has quit IRC
  22 2012-08-22T09:19:03  <breton> and he quit
  23 2012-08-22T09:23:10  <xiaq> anybody knows are there any public codereview sites other than codereview.appspot.com?
  24 2012-08-22T09:27:10  * dreimark looks
  25 2012-08-22T09:37:19  <dreimark> http://stackoverflow.com/questions/2094306/public-code-review-tool
  26 2012-08-22T09:37:36  <dreimark> http://refactormycode.com/ mentioned there is currently offline
  27 2012-08-22T09:47:57  *** hughperkins has joined #moin-dev
  28 2012-08-22T09:48:30  *** liyan has joined #moin-dev
  29 2012-08-22T09:51:23  <liyan> Hi. Disconnected, back now.
  30 2012-08-22T10:03:33  <dreimark> moin liyan
  31 2012-08-22T10:03:52  <dreimark> line 45 make use new style of class definition
  32 2012-08-22T10:03:58  <xiaq> liyan: hi :)
  33 2012-08-22T10:04:47  <liyan> hi
  34 2012-08-22T10:05:09  * xiaq is querying liyan
  35 2012-08-22T10:06:43  <dreimark> in general for selenium tests and existing tests we should start with an etherpad session
  36 2012-08-22T10:07:12  <liyan> hi dreimark, what do you mean by 'new style of class definition'?
  37 2012-08-22T10:07:12  <dreimark> with the goal to find how both test sets could better interact
  38 2012-08-22T10:07:21  <dreimark> based on object
  39 2012-08-22T10:07:32  <dreimark> () is very old style
  40 2012-08-22T10:07:54  <xiaq> dreimark: that is "class C(object): ..."
  41 2012-08-22T10:08:02  <xiaq> uh oh, i meant liyan
  42 2012-08-22T10:08:04  <xiaq> liyan: ^^
  43 2012-08-22T10:08:35  <dreimark> if you look at http://hg.moinmo.in/moin/2.0/file/9a0b6e93fb3c/MoinMoin/_tests/test_user.py
  44 2012-08-22T10:08:41  <liyan> xiaq,我不太明白
  45 2012-08-22T10:09:15  <dreimark> wrong language
  46 2012-08-22T10:09:25  <liyan> sorry
  47 2012-08-22T10:09:32  <dreimark> " I do not quite understand"
  48 2012-08-22T10:10:12  <dreimark> we should use e.g. same parameters adopt the ideas for the sel tests
  49 2012-08-22T10:10:28  <xiaq> liyan: in python 2, class definitions default to the legacy "classic class", unless explicitly deriving from object (or object's subclass). cf. http://docs.python.org/reference/datamodel.html#new-style-and-classic-classes
  50 2012-08-22T10:10:53  *** hughperkins has quit IRC
  51 2012-08-22T10:12:43  <xiaq> classic classes are kept in the language for backward compatibility and should never be used in new code. it has some implications that may look weird today, like classic classes' instances always have the type "instance" instead of their classes...
  52 2012-08-22T10:14:20  <liyan> ok, I see.
  53 2012-08-22T10:16:48  *** hughperkins has joined #moin-dev
  54 2012-08-22T10:27:16  <liyan> dreimark, do you mean test with ascii passwords, and test with unicode passwords?
  55 2012-08-22T10:38:37  *** hughperkins has quit IRC
  56 2012-08-22T10:50:47  *** hughperkins has joined #moin-dev
  57 2012-08-22T11:04:02  *** greg_f has joined #moin-dev
  58 2012-08-22T11:37:10  *** liyan has quit IRC
  59 2012-08-22T11:37:59  *** hughperkins has quit IRC
  60 2012-08-22T11:59:53  <dreimark> no, that not
  61 2012-08-22T12:01:49  <ThomasWaldmann> moin
  62 2012-08-22T13:44:40  *** hughperkins has joined #moin-dev
  63 2012-08-22T13:56:32  *** liyan has joined #moin-dev
  64 2012-08-22T14:33:05  <gwork> moin
  65 2012-08-22T14:36:30  *** hughperkins has quit IRC
  66 2012-08-22T14:37:42  *** hughperkins has joined #moin-dev
  67 2012-08-22T14:45:02  *** dave_largo has joined #moin-dev
  68 2012-08-22T14:58:17  <xiaq> ThomasWaldmann: plz look at the latest version of index cleanup changeset http://codereview.appspot.com/6457091/ i'll push and send a pull req if it's ok.
  69 2012-08-22T15:31:07  * xiaq finished questionnaire
  70 2012-08-22T15:35:32  *** RogerHaase has joined #moin-dev
  71 2012-08-22T15:51:28  *** hughperkins has quit IRC
  72 2012-08-22T15:51:30  *** liyan has quit IRC
  73 2012-08-22T15:54:45  *** hughperkins has joined #moin-dev
  74 2012-08-22T15:56:34  *** liyan has joined #moin-dev
  75 2012-08-22T15:59:27  *** hughperkins has left #moin-dev
  76 2012-08-22T16:00:50  *** hughperkins has joined #moin-dev
  77 2012-08-22T16:07:43  <ThomasWaldmann> xiaq: looking at CR
  78 2012-08-22T16:11:03  <ThomasWaldmann> xiaq: done. sorry if i wasn't clear enough with that "example" idea.
  79 2012-08-22T16:16:39  <xiaq> ThomasWaldmann: no problem. updated again
  80 2012-08-22T16:19:03  <liyan> I have access to codereview, and I've downloaded upload.py. Question: what is an appropiate directory to store selenium test scripts in?
  81 2012-08-22T16:20:02  <xiaq> liyan: depending on which part you're testing against, one of apps/*/_tests/ may be appropriate
  82 2012-08-22T16:20:37  <xiaq> liyan: (apps is MoinMoin/apps)
  83 2012-08-22T16:21:54  <ThomasWaldmann> yeah. maybe depends a bit how in practice those scripts will be discovered and run then.
  84 2012-08-22T16:34:19  * ThomasWaldmann never used selenium yet, so take comments with a grain of salt
  85 2012-08-22T16:35:58  <xiaq> (env)~/src/moin2$ hg export `hg log -M -u 'Cheer Xiao' --template '{rev} '` | wc -l
  86 2012-08-22T16:36:01  <xiaq> 9312
  87 2012-08-22T16:36:58  <ThomasWaldmann> xiaq: i did similar stuff yesterday, but noticed that this is no good metrics.
  88 2012-08-22T16:42:55  <xiaq> ThomasWaldmann: yeah, but it gives me a basic idea
  89 2012-08-22T16:43:21  *** liyan has quit IRC
  90 2012-08-22T16:47:26  <ThomasWaldmann> i tried compressing it, to remove redundancy, but it didn't get much better metrics with that.
  91 2012-08-22T16:47:47  *** hughperkins has quit IRC
  92 2012-08-22T16:53:48  <xiaq> ThomasWaldmann: hm, is latest patch set of http://codereview.appspot.com/6457091/ good enough? :)
  93 2012-08-22T16:55:12  <ThomasWaldmann> yeah :)
  94 2012-08-22T17:05:47  * xiaq sent pull req
  95 2012-08-22T17:40:59  * xiaq updated pull req, adding 2 other ok'ed changesets
  96 2012-08-22T17:41:32  <dreimark> bbl
  97 2012-08-22T17:52:03  *** MattMaker has quit IRC
  98 2012-08-22T17:52:28  *** MattMaker has joined #moin-dev
  99 2012-08-22T18:12:26  *** RogerHaase has left #moin-dev
 100 2012-08-22T18:36:14  *** brunomartin has quit IRC
 101 2012-08-22T18:48:32  *** brunomartin has joined #moin-dev
 102 2012-08-22T18:54:26  <dreimark> wb brunomartin
 103 2012-08-22T18:59:19  <brunomartin> hi dreimark!
 104 2012-08-22T19:02:00  <brunomartin> ThomasWaldmann: hi!
 105 2012-08-22T19:03:32  <brunomartin> I am indebted to moin... I have to finish that work on namespaces... is there any news on it?
 106 2012-08-22T19:17:16  <xiaq> brunomartin: no big news for 3 months i suppose
 107 2012-08-22T19:17:37  <dreimark> besides that we have now more lines of source
 108 2012-08-22T19:34:01  *** ThomasWaldman2 has joined #moin-dev
 109 2012-08-22T19:37:51  <brunomartin> ok... I can back to it tomorrow.... should we merge the namespace branch before?
 110 2012-08-22T19:38:29  *** ChanServ has quit IRC
 111 2012-08-22T19:38:31  *** MaikuMori has quit IRC
 112 2012-08-22T19:38:31  *** ThomasWaldmann has quit IRC
 113 2012-08-22T19:38:35  *** bilal has quit IRC
 114 2012-08-22T19:38:35  *** waldi has quit IRC
 115 2012-08-22T19:38:36  *** jek has quit IRC
 116 2012-08-22T19:38:36  *** dennda_ has quit IRC
 117 2012-08-22T19:38:41  *** vpv has quit IRC
 118 2012-08-22T19:38:42  *** xiaq has quit IRC
 119 2012-08-22T19:38:44  *** gwork has quit IRC
 120 2012-08-22T19:38:44  *** eSyr-ng has quit IRC
 121 2012-08-22T19:38:48  *** dreimark has quit IRC
 122 2012-08-22T19:38:50  *** CIA-79 has quit IRC
 123 2012-08-22T19:39:23  *** bilal has joined #moin-dev
 124 2012-08-22T19:39:23  *** waldi has joined #moin-dev
 125 2012-08-22T19:39:23  *** jek has joined #moin-dev
 126 2012-08-22T19:39:23  *** dennda_ has joined #moin-dev
 127 2012-08-22T19:39:33  *** dreimark has joined #moin-dev
 128 2012-08-22T19:39:33  *** CIA-79 has joined #moin-dev
 129 2012-08-22T19:40:27  *** gwork has joined #moin-dev
 130 2012-08-22T19:40:27  *** eSyr-ng has joined #moin-dev
 131 2012-08-22T19:40:32  *** MaikuMori_ has joined #moin-dev
 132 2012-08-22T19:40:41  *** vpv has joined #moin-dev
 133 2012-08-22T19:41:16  *** xiaq has joined #moin-dev
 134 2012-08-22T19:46:01  *** greg_f has quit IRC
 135 2012-08-22T20:14:09  *** RogerHaase has joined #moin-dev
 136 2012-08-22T22:32:05  <dreimark> re
 137 2012-08-22T22:41:56  *** ChanServ has joined #moin-dev
 138 2012-08-22T22:41:56  *** kornbluth.freenode.net sets mode: +o ChanServ
 139 2012-08-22T22:59:43  *** jaiditya has joined #moin-dev
 140 2012-08-22T23:05:15  *** dave_largo has quit IRC
 141 2012-08-22T23:38:17  <RogerHaase> ThomasWaldmann2: fix for failing tests on windows:  http://codereview.appspot.com/6476049/   http://rn0.ru/show/bu9reZl7eaAPC3VvyHTQ/
 142 2012-08-22T23:56:59  *** RogerHaase has left #moin-dev
 143