1 2012-08-18T00:02:50 <jaiditya> dreimark: can you check https://bitbucket.org/Jaiditya/moin-2.0/changeset/6cd9347f7cc54e01258471eb0f75cf40ee546090
2 2012-08-18T00:03:08 <dreimark> yes
3 2012-08-18T00:03:26 <jaiditya> I did this in respose to this https://bitbucket.org/Jaiditya/moin-2.0/issue/39/hide-admin-for-non-admin
4 2012-08-18T00:04:29 <jaiditya> I might have misunderstood what ThomasWaldmann commented on issue as this has resulted in failed tests
5 2012-08-18T00:06:09 <dreimark> ok, i have to look at the test too. it can be also that the tests needs changes
6 2012-08-18T00:08:02 <jaiditya> dreimark: due to this change 4 tests failed
7 2012-08-18T00:08:24 <dreimark> i look at it after i have my env back
8 2012-08-18T00:08:44 <dreimark> had to do a full new installation
9 2012-08-18T00:09:12 <jaiditya> ok
10 2012-08-18T00:10:34 <dreimark> jaiditya: the tests cover always the current code
11 2012-08-18T00:11:16 <dreimark> if the code changes best is the tests where changed before in the expected way
12 2012-08-18T00:12:21 <dreimark> so the test fails and suceeds after the code change is done
13 2012-08-18T00:12:22 <spy> dreimark: some fixes http://codereview.appspot.com/6441151/
14 2012-08-18T00:12:23 <jaiditya> so I'll have to check the tests then
15 2012-08-18T00:12:47 <dreimark> yes check if they make sense for that change
16 2012-08-18T00:13:20 <dreimark> if the tests still look valid then the problem is in your change given
17 2012-08-18T00:19:58 *** RogerHaase
18 2012-08-18T00:45:03 <dreimark> jaiditya: you should change the tests which fails now to test for access denied
19 2012-08-18T00:47:17 <dreimark> gn
20 2012-08-18T00:47:19 <jaiditya> yes, I saw that the failed tests have to be corrected but one doubt I had in my changeset is that what if one directly entes the address of user browser
21 2012-08-18T00:47:52 <jaiditya> that way he'll bypass it without being a admin
22 2012-08-18T00:48:17 <jaiditya> ok will discuss it tomorrow...gn
23 2012-08-18T00:48:19 <dreimark> thatneeds to be catched to
24 2012-08-18T00:48:39 <dreimark> bypassing is a bug
25 2012-08-18T00:48:51 <jaiditya> yeah, will correct it then
26 2012-08-18T00:49:11 <dreimark> ok, now gn
27 2012-08-18T07:54:00 * xiaq sent pull req to ThomasWaldmann containing inline label changeset: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/80 http://codereview.appspot.com/6462051/
28 2012-08-18T07:54:03 <xiaq> ThomasWaldmann: ^
29 2012-08-18T07:54:06 <xiaq> jaiditya: ^
30 2012-08-18T07:54:08 <xiaq> dreimark: ^
31 2012-08-18T08:07:59 <dreimark> moin
32 2012-08-18T08:08:27 <dreimark> jaiditya: also have tests for superuser
33 2012-08-18T08:25:39 <dreimark> ThomasWaldmann: does tar zxvf moin-1.9.4.tar.gz works for you on 12.04?
34 2012-08-18T08:34:14 <dreimark> ignore, may be file was corrupted
35 2012-08-18T08:34:55 <jaiditya> dreimark: font have been changed to Helvetica, Arial as Verdana is not a default font for Mac
36 2012-08-18T08:35:03 <dreimark> ok
37 2012-08-18T08:35:30 <dreimark> i guess i missed the line in cr where it was done
38 2012-08-18T08:36:07 <xiaq> dreimark: there are some rebasing issues, so it's recommended to check the original diff (besides delta)
39 2012-08-18T08:36:16 <dreimark> ok
40 2012-08-18T08:36:48 <jaiditya> xiaq: this changeset is not complete if I an not wrong ?
41 2012-08-18T08:37:50 <xiaq> jaiditya: not enough for ticket styling, but it's atomic IMO
42 2012-08-18T08:38:18 <xiaq> jaiditya: it also fixes the checkbox on +search
43 2012-08-18T08:38:20 <jaiditya> dreimark: "moin-textcha" is a added class for textcha styling
44 2012-08-18T08:39:41 <jaiditya> xiaq: ok, but I think for ticket styling u'll have to make some more changes
45 2012-08-18T08:41:27 <dreimark> which one for example?
46 2012-08-18T08:42:29 <xiaq> jaiditya: yeah
47 2012-08-18T08:42:49 <xiaq> dreimark: eg. <dd>'s width:75% needs to be changed
48 2012-08-18T08:43:37 <xiaq> no, <dt>
49 2012-08-18T08:45:51 <jaiditya> dreimark: http://codereview.appspot.com/6454167/
50 2012-08-18T08:53:13 <dreimark> jaiditya: this is the simple solution, at least add a ToDo that it needs to be done for the case of superuser too
51 2012-08-18T08:56:29 <jaiditya> dreimark: you mean test to check if superuser page is locked or not ?
52 2012-08-18T09:01:01 <dreimark> if a user has superuser function attribute he should get 200
53 2012-08-18T09:01:39 <dreimark> may be add first a ToDo that this needs to be done
54 2012-08-18T09:02:45 <dreimark> i grepped for superuser and it looks like we have currently no test about this functionality
55 2012-08-18T09:03:43 <dreimark> it needs a review where all test changed had to be done
56 2012-08-18T09:04:51 <dreimark> or where we have to add tests for a different path
57 2012-08-18T09:12:04 <jaiditya> ok. So where do you think this test should be added ?
58 2012-08-18T09:14:05 <dreimark> no new test, it needs to be checked for a user with superuser and anonymous user
59 2012-08-18T09:14:25 <dreimark> currently it is only anonymous
60 2012-08-18T09:17:32 <jaiditya> ok
61 2012-08-18T09:18:56 <dreimark> http://moin-20.readthedocs.org/en/latest/admin/configure.html?highlight=superuser
62 2012-08-18T09:20:31 <dreimark> I don't see tests for acl_functions at all, so sorry I can't give an example
63 2012-08-18T09:20:37 <dreimark> better than docs
64 2012-08-18T09:43:44 <xiaq> ThomasWaldmann: updated http://codereview.appspot.com/6457091/
65 2012-08-18T09:43:44 <xiaq> dreimark: ^
66 2012-08-18T10:01:58 *** jaiditya
67 2012-08-18T10:09:45 <xiaq> an attempt to resolv ticket css issues: http://codereview.appspot.com/6458157
68 2012-08-18T10:09:50 <xiaq> dreimark: ^
69 2012-08-18T10:09:52 <xiaq> ThomasWaldmann: ^
70 2012-08-18T10:22:54 *** jaiditya|2
71 2012-08-18T13:18:15 <xiaq> jaiditya|2: hi
72 2012-08-18T13:18:31 *** jaiditya|2
73 2012-08-18T13:18:35 <jaiditya> hi
74 2012-08-18T13:19:28 <xiaq> do you find my idea about removing duplication of index.html viable?
75 2012-08-18T13:24:24 <jaiditya> jaiditya: what about 1) make the panel code a macro, thus pages that need an extra panel includes the macro rather than inherits from local.html 2) let foobar index.html inherit default index.html and add up the extra panel
76 2012-08-18T13:24:29 <jaiditya> this ides ?
77 2012-08-18T13:25:03 <xiaq> jaiditya: yup
78 2012-08-18T13:25:15 <jaiditya> or
79 2012-08-18T13:25:18 <jaiditya> what about putting action menu in a block at the same level of "content" (eg "action"), and in foobar's index.html, inherit "action" block and put it in the extra panel's <div>?
80 2012-08-18T13:25:19 <jaiditya> [17:59:50] <xiaq> {% block action %}
81 2012-08-18T13:25:19 <jaiditya> [17:59:57] <xiaq> <div id="extra-panel">
82 2012-08-18T13:25:19 <jaiditya> [18:00:00] <xiaq> {{ super() }}
83 2012-08-18T13:25:19 <jaiditya> [18:00:02] <xiaq> </div>
84 2012-08-18T13:25:19 <jaiditya> [18:00:08] <xiaq> {% endblock %}
85 2012-08-18T13:25:24 <jaiditya> this idea
86 2012-08-18T13:25:40 <xiaq> jaiditya: ah, i mean this one :)
87 2012-08-18T13:27:39 <jaiditya> xiaq: putting extra panel as a macro will result in more templates as all those template which need a side panel will have to be created in foobar theme folder
88 2012-08-18T13:28:02 <jaiditya> this way we'll have more number of themes
89 2012-08-18T13:28:17 <jaiditya> s/themes/templates
90 2012-08-18T13:30:07 <jaiditya> in out current approach we just have to check wether a template wants side panel or not and then just extend it correspondingly from show.html() or layout.html
91 2012-08-18T13:30:08 <xiaq> jaiditya: which templates need the extra panel currently?
92 2012-08-18T13:31:15 <jaiditya> check the default template folder, all those templates which are extended from show.html have that extra panel
93 2012-08-18T13:36:10 <jaiditya> MoinMoin/templates/delete.html
94 2012-08-18T13:36:10 <jaiditya> MoinMoin/templates/destroy.html
95 2012-08-18T13:36:10 <jaiditya> MoinMoin/templates/diff.html
96 2012-08-18T13:36:10 <jaiditya> MoinMoin/templates/highlight.html
97 2012-08-18T13:36:10 <jaiditya> MoinMoin/templates/item_link_list.html
98 2012-08-18T13:36:10 <jaiditya> MoinMoin/templates/meta.html
99 2012-08-18T13:36:10 <jaiditya> MoinMoin/templates/modify.html
100 2012-08-18T13:36:11 <jaiditya> MoinMoin/templates/modify_select_contenttype.html
101 2012-08-18T13:36:11 <jaiditya> MoinMoin/templates/modify_select_itemtype.html
102 2012-08-18T13:36:12 <jaiditya> MoinMoin/templates/modify_select_template.html
103 2012-08-18T13:36:12 <jaiditya> MoinMoin/templates/rename.html
104 2012-08-18T13:36:13 <jaiditya> MoinMoin/templates/sitemap.html
105 2012-08-18T13:36:22 <jaiditya> xiaq: ^
106 2012-08-18T13:37:05 <spy> dreimark: updated: http://codereview.appspot.com/6441151/
107 2012-08-18T13:37:34 <xiaq> jaiditya: yeah, i found them using grep 'extends.*show\.html'
108 2012-08-18T13:38:47 <xiaq> hm, seems the situation is a bit messy here, will require more sorting out...
109 2012-08-18T13:42:45 <jaiditya> xiaq: One thing which I can think of is we can move content of index.html to a new file and then import that back into the both files
110 2012-08-18T14:24:47 <xiaq> an idea about current situation:
111 2012-08-18T14:25:30 <xiaq> the problem is that templates needing the extra panel (show.html and index.html) extend from local.html rather than corresponding default templates...
112 2012-08-18T14:26:07 <xiaq> even if they can, it's nontrivial to move something from default template around (it is trivial to just *add* something by template inheritance)
113 2012-08-18T14:30:28 <xiaq> a problem i notice: foobar's layout.html contains a {% block local %} that is only useful for (foobar's) show.html. what about moving it to show.html instead?
114 2012-08-18T14:31:26 <ThomasWaldmann> moin
115 2012-08-18T14:34:25 <xiaq> ThomasWaldmann: http://codereview.appspot.com/6458157 and http://codereview.appspot.com/6457091 and the pull req :)
116 2012-08-18T14:38:24 <jaiditya> xiaq: block local is present in local.html and yes we can merge that to show.html
117 2012-08-18T14:38:44 <xiaq> jaiditya: just leave an empty {% block local %} there in local.html
118 2012-08-18T14:39:34 <xiaq> jaiditya: i wonder... will you continue to code for moin2 after soc? :)
119 2012-08-18T14:39:51 <jaiditya> of coarse
120 2012-08-18T14:39:58 <ThomasWaldmann> those floating point precision based changes in the generated css are a bit annoying
121 2012-08-18T14:40:18 <dreimark> re
122 2012-08-18T14:40:35 <ThomasWaldmann> ul.moin-tags li.weight2{font-size:.6944444444444445em}
123 2012-08-18T14:40:36 <ThomasWaldmann> ul.moin-tags li.weight2{font-size:.6944444444444444em}
124 2012-08-18T14:41:23 <xiaq> ThomasWaldmann: yeah, i guess it's due to either v8's inconsistent flop across platform
125 2012-08-18T14:41:36 <ThomasWaldmann> jaiditya: did you already file a bug for this? maybe couple with a question whether one could limit it to some specific precision and round?
126 2012-08-18T14:41:40 <xiaq> , or jaiditya generated it using an older stylus version...
127 2012-08-18T14:42:30 <xiaq> jaiditya: when did you last generate those css's, on which platform (version of os, v8, and stylus)?
128 2012-08-18T14:42:44 <jaiditya> ThomasWaldmann: no, not regarding this, will file it now
129 2012-08-18T14:43:21 <ThomasWaldmann> maybe have a quick look at the docs, whether one can set number of digits somehow
130 2012-08-18T14:43:21 <dreimark> can't there accuracy given or output format
131 2012-08-18T14:44:22 <xiaq> dreimark: hmm? :)
132 2012-08-18T14:44:32 <dreimark> for these digits
133 2012-08-18T14:44:54 * xiaq is feeling a bit dyslexical :)
134 2012-08-18T14:44:56 <dreimark> d5.3 orso
135 2012-08-18T14:45:59 * dreimark cools down by ice
136 2012-08-18T14:49:39 <jaiditya> ThomasWaldmann: on a quick look I didn't found anything to limit no of digits
137 2012-08-18T14:50:50 <jaiditya> find*
138 2012-08-18T14:51:07 <ThomasWaldmann> xiaq: i have one failing test after your last changes
139 2012-08-18T14:51:19 * xiaq uh oh
140 2012-08-18T14:51:33 <ThomasWaldmann> MoinMoin/apps/admin/_tests/test_admin.py:14: AssertionError
141 2012-08-18T14:52:20 <ThomasWaldmann> don't see how it is related to your changes, though. was it there even before these?
142 2012-08-18T14:52:24 * xiaq only changed templates...
143 2012-08-18T14:52:27 <xiaq> ThomasWaldmann: i suppose so :)
144 2012-08-18T14:52:44 * xiaq is getting *4 failures* actually, talked about this before...
145 2012-08-18T14:53:10 <ThomasWaldmann> is there a pastebin with them?
146 2012-08-18T14:53:15 <xiaq> yup
147 2012-08-18T14:53:24 * xiaq searches thru log...
148 2012-08-18T14:53:55 <ThomasWaldmann> ah, tickets looking much better now
149 2012-08-18T14:54:08 <xiaq> ThomasWaldmann: here: http://rn0.ru/show/zGnv1WD6mkQkfcJNHIja/
150 2012-08-18T14:54:23 <xiaq> ThomasWaldmann: you use Firefox too don't you :D
151 2012-08-18T14:54:37 <ThomasWaldmann> yes
152 2012-08-18T14:54:45 <xiaq> it didn't get any better with other browsers, weird
153 2012-08-18T14:54:57 <xiaq> and requring some more fix
154 2012-08-18T14:55:01 <ThomasWaldmann> except that "add comment" / "Message" stuff, that still looks strange
155 2012-08-18T14:55:04 <dreimark> 08:45 < jaiditya> dreimark: http://codereview.appspot.com/6454167/
156 2012-08-18T14:55:10 <dreimark> ThomasWaldmann: ^
157 2012-08-18T14:56:06 <xiaq> ThomasWaldmann: yes, for that see this: http://codereview.appspot.com/6458157/
158 2012-08-18T14:56:50 <CIA-65> Cheer Xiao <xiaqqaix@gmail.com> default * 1707:664f34873981 2.0/MoinMoin/ (5 files in 5 dirs):
159 2012-08-18T14:56:50 <CIA-65> Tag some <label>s with css class "moin-inline-label" and make them inline.
160 2012-08-18T14:56:50 <CIA-65> Default style for <label> changed to display:block at some point, but inline
161 2012-08-18T14:56:50 <CIA-65> labels are still required in some places.
162 2012-08-18T14:56:50 <CIA-65> The css files have been regnerated from stylus sources.
163 2012-08-18T14:57:37 <dreimark> http://thechangelog.com/post/3036532096/stylus-expressive-robust-feature-rich-css-language
164 2012-08-18T14:57:44 <dreimark> talk about stylus
165 2012-08-18T14:57:51 <xiaq> hm, the incompatibility is that when dd>input's width is specified in percentage, Firefox interprets it relative to dd, whilst other browsers interpret relative to the dd's container
166 2012-08-18T14:58:12 <ThomasWaldmann> ok, so whoever broke the admin views, please fix
167 2012-08-18T14:59:09 <jaiditya> ThomasWaldmann: It was my changeset, corrected it http://codereview.appspot.com/6454167/
168 2012-08-18T14:59:54 <dreimark> well the tests just don't cover the current useage
169 2012-08-18T15:00:12 <jaiditya> ThomasWaldmann: but I guess my changeset regarding changes in admin views.py has not been merged yet
170 2012-08-18T15:00:23 <ThomasWaldmann> meeting time. someone wants to be first?
171 2012-08-18T15:00:47 <jaiditya> pull request still exists I guess ?
172 2012-08-18T15:00:52 <jaiditya> me
173 2012-08-18T15:01:03 <ThomasWaldmann> ok, jaiditya you're first
174 2012-08-18T15:01:05 <jaiditya> LAST: Bugs resolving and Documentation
175 2012-08-18T15:01:06 <jaiditya> BLOCKERS: None
176 2012-08-18T15:01:06 <jaiditya> NEXT: Resolve bugs and documentation completion
177 2012-08-18T15:01:32 <jaiditya> http://etherpad.osuosl.org/theme-docs
178 2012-08-18T15:01:45 <ThomasWaldmann> note: "NEXT" now means "until firm pencils down"
179 2012-08-18T15:01:52 <jaiditya> I am not good with words
180 2012-08-18T15:02:15 <ThomasWaldmann> of course you do not need to stop coding after that SOC deadline, but it won't count for SOC any more
181 2012-08-18T15:02:43 <ThomasWaldmann> and of course we invite all student to continue helping with moin and continue working on their project
182 2012-08-18T15:03:12 <jaiditya> next Target is 12.12.12 - release of moin2
183 2012-08-18T15:03:20 <ThomasWaldmann> jaiditya: did you write documentation last week?
184 2012-08-18T15:03:24 <ThomasWaldmann> jaiditya: hehe, yes :D
185 2012-08-18T15:03:36 <jaiditya> http://etherpad.osuosl.org/theme-docs
186 2012-08-18T15:03:47 <dreimark> we are not sure if gci is announced this year again and if we could get a slot but we are also hope you like to help to mentor younger students
187 2012-08-18T15:04:04 <dreimark> if we get in again
188 2012-08-18T15:04:27 <jaiditya> sure
189 2012-08-18T15:04:30 <ThomasWaldmann> btw, on etherpad, better use monospace font
190 2012-08-18T15:04:37 * xiaq too :)
191 2012-08-18T15:04:55 <ThomasWaldmann> and maybe do it in rst-like syntax, so one can reuse more of it for sphinx based docs
192 2012-08-18T15:06:06 <jaiditya> ThomasWaldmann: thought first get content in place..
193 2012-08-18T15:06:40 <ThomasWaldmann> sure, content is most important. but if you underline headings anyway, monospace helps to use right amount of - chars.
194 2012-08-18T15:07:34 <jaiditya> yeah
195 2012-08-18T15:08:35 <ThomasWaldmann> jaiditya: btw, also have a look through your etherpad, whether there is something that should be kept long-term.
196 2012-08-18T15:08:47 <ThomasWaldmann> then it should get into the docs also.
197 2012-08-18T15:08:56 <jaiditya> ok
198 2012-08-18T15:09:11 <dreimark> also please make regular local copies of the content of ep
199 2012-08-18T15:09:24 <jaiditya> done
200 2012-08-18T15:09:27 <ThomasWaldmann> (or in the main issue tracker if it is a task that is still todo or bug still to fix)
201 2012-08-18T15:09:29 <dreimark> I have already lost all of a barcamp just one day after
202 2012-08-18T15:11:08 <ThomasWaldmann> jaiditya: maybe also have a look through your issue tracker
203 2012-08-18T15:11:46 <ThomasWaldmann> bugs that do not belong there (if any) should be filed whereever they belong to
204 2012-08-18T15:12:02 <ThomasWaldmann> close bugs that are fixed or that you won't fix
205 2012-08-18T15:12:22 <jaiditya> https://bitbucket.org/Jaiditya/moin-2.0/issue/66/stylus-0290-throws-parse-error-with
206 2012-08-18T15:12:26 <jaiditya> regarding this
207 2012-08-18T15:12:27 <ThomasWaldmann> if a bug is somehow invalid, close it as invalid
208 2012-08-18T15:12:42 <jaiditya> filed a issue on stylus tracker
209 2012-08-18T15:13:11 <jaiditya> https://github.com/LearnBoost/stylus/issues/795
210 2012-08-18T15:13:17 <ThomasWaldmann> also, avoid using pastebins in bug reports, they can't be regarded as permanent
211 2012-08-18T15:13:18 <jaiditya> no reply yet
212 2012-08-18T15:13:51 <ThomasWaldmann> ok, if that issue is filed there now, link to there from your tracker and put it on hold
213 2012-08-18T15:14:56 <ThomasWaldmann> jaiditya: xiaq: https://bitbucket.org/Jaiditya/moin-2.0/issue/65/inline_checkbox-and-small_natural-widgets
214 2012-08-18T15:15:03 <ThomasWaldmann> update & close?
215 2012-08-18T15:15:20 <jaiditya> yes...
216 2012-08-18T15:16:18 <ThomasWaldmann> ok, any more questions from/to jaiditya? waldi?
217 2012-08-18T15:16:38 <waldi> nope
218 2012-08-18T15:16:40 <jaiditya> no
219 2012-08-18T15:16:56 <ThomasWaldmann> ok, someone else in a hurry?
220 2012-08-18T15:18:04 <ThomasWaldmann> otherwise xiaq now and afterwards spy should be next.
221 2012-08-18T15:18:36 <ThomasWaldmann> (because there might be some common points with themes as they did the most UI work)
222 2012-08-18T15:18:53 <xiaq> LAST: push ticket code, publish index cleanup code, ticket css
223 2012-08-18T15:18:56 <xiaq> BLOCKER: nope
224 2012-08-18T15:20:05 <xiaq> NEXT: status meta is still missing; see if there are other broken style; push index cleanup code
225 2012-08-18T15:20:26 <ThomasWaldmann> xiaq: can you show your current stuff "live"?
226 2012-08-18T15:20:32 <xiaq> and NEXT-NEXT is finish the index stuff :)
227 2012-08-18T15:21:16 <xiaq> wait a moment
228 2012-08-18T15:21:55 <ThomasWaldmann> in general, I'ld suggest not to begin completely new stuff. except if you'ld get bored after finishing other unfinished stuff and cleaning up.
229 2012-08-18T15:23:01 <xiaq> yes, but i've been doing index stuff for quite a while :)
230 2012-08-18T15:25:30 <ThomasWaldmann> ok, you can show live stuff after the meeting
231 2012-08-18T15:26:07 <dreimark> xiaq: can you also look py.test --cov for your tests
232 2012-08-18T15:26:16 <xiaq> just updated http://z.tuna.tsinghua.edu.cn:8088/.
233 2012-08-18T15:26:31 <ThomasWaldmann> spy: xiaq: for both issue tracker and blog, it would be nice if the basic workflow somehow worked and would also be discoverable by people not knowing the internals
234 2012-08-18T15:26:34 <xiaq> it contains ticket-specific css and some of my index changesets. the latter are mostly "under the hood" for now.
235 2012-08-18T15:27:51 <xiaq> dreimark: py.test: error: no such option: --cov
236 2012-08-18T15:28:27 <ThomasWaldmann> xiaq: depends on has duplicates in the dropdown
237 2012-08-18T15:29:08 <xiaq> ThomasWaldmann: so is superseded by... weird
238 2012-08-18T15:29:18 <dreimark> xiaq: http://pypi.python.org/pypi/pytest-cov/
239 2012-08-18T15:29:35 <xiaq> perhaps the whoosh index somehow got corrupted
240 2012-08-18T15:29:49 <ThomasWaldmann> xiaq: can i see the tickets list / index somehow? how?
241 2012-08-18T15:31:25 <xiaq> a minute...
242 2012-08-18T15:32:23 <xiaq> uh, i broke itemtype filtering. will fix that a bit later
243 2012-08-18T15:33:56 <ThomasWaldmann> ok, after meeting then...
244 2012-08-18T15:34:10 <ThomasWaldmann> anything else for/from xiaq? dreimark?
245 2012-08-18T15:34:41 <ThomasWaldmann> spy: please prepare
246 2012-08-18T15:34:44 <dreimark> not now
247 2012-08-18T15:35:10 <spy> LAST: +show view for Blog and BlogEntry classes, PTIME preload, unittests for Blog.
248 2012-08-18T15:35:13 <spy> BLOCKERS: none
249 2012-08-18T15:35:15 <spy> NEXT: polish css for both themes. Talk a bit about commenting system, perhaps implement a simple comment itemtype.
250 2012-08-18T15:36:19 <ThomasWaldmann> can you show current stuff live?
251 2012-08-18T15:36:44 <spy> sure, http://vps.psviderski.name:8080/myblog
252 2012-08-18T15:37:00 <spy> also please register and login
253 2012-08-18T15:37:17 <spy> you will see "Modify entry" links
254 2012-08-18T15:38:10 <dreimark> there should somewhere also a simple link to make a new entry
255 2012-08-18T15:38:13 <spy> current acl: default=u'Known:read,write,create,destroy,admin All:read'
256 2012-08-18T15:39:04 <spy> dreimark: yeah, I thought about it since +index view is still under refactoring
257 2012-08-18T15:41:18 <ThomasWaldmann> http://vps.psviderski.name:8080/myblog/foo
258 2012-08-18T15:41:36 <ThomasWaldmann> looks strange
259 2012-08-18T15:41:40 <dreimark> xiaq: i just have seen the blue hg line on bottom http://z.tuna.tsinghua.edu.cn:8088/an
260 2012-08-18T15:41:57 * ThomasWaldmann MUST leave for some minutes, dreimark please take over...
261 2012-08-18T15:42:04 <dreimark> ok
262 2012-08-18T15:43:48 <spy> ThomasWaldmann: i'm not very good at css styling, so I hope it will be fixed with jaiditya's help
263 2012-08-18T15:44:10 <dreimark> ok, but then you should have a ticket
264 2012-08-18T15:44:49 <dreimark> because it is easier to discuss it
265 2012-08-18T15:44:49 <xiaq> dreimark: hg line? :)
266 2012-08-18T15:45:00 <dreimark> xiaq: hr line
267 2012-08-18T15:45:19 <dreimark> ob bottom
268 2012-08-18T15:45:25 <spy> dreimark: will create
269 2012-08-18T15:45:27 <dreimark> below Subsribers
270 2012-08-18T15:47:00 <xiaq> dreimark: seems a placeholder in some parent template - on show.html it's the action bar plus revision info
271 2012-08-18T15:47:37 <xiaq> i'll look into that.
272 2012-08-18T15:47:42 <dreimark> ok
273 2012-08-18T15:48:10 <dreimark> spy: the tags listed in the category they are all about all entries of the blog?
274 2012-08-18T15:48:29 <dreimark> on an entry http://vps.psviderski.name:8080/myblog/foo
275 2012-08-18T15:48:48 <spy> dreimark: it is an independent list ('supertags' meta on blog entry)
276 2012-08-18T15:48:56 <dreimark> ok
277 2012-08-18T15:49:28 <dreimark> this one just have no own tag
278 2012-08-18T15:49:42 <spy> I think supertags is a bit misleading for ordinary blog user, so I named it Categories
279 2012-08-18T15:50:29 <dreimark> ok
280 2012-08-18T15:50:36 <spy> internaly they are supertags, on ui they are categories :)
281 2012-08-18T15:50:52 <spy> do we plan to test ui/forms?
282 2012-08-18T15:51:32 <dreimark> is pllned by selenium webdriver - yes
283 2012-08-18T15:51:48 <dreimark> but it needs to stabilize a bit before doing this
284 2012-08-18T15:52:00 <dreimark> s/pllned/planned/
285 2012-08-18T15:52:07 <spy> agree
286 2012-08-18T15:52:11 <ThomasWaldmann> jaiditya: can you have a look at http://vps.psviderski.name:8080/myblog/foo and whether there is some css way to make it look less bad?
287 2012-08-18T15:55:27 <dreimark> further questions to me or spy ?
288 2012-08-18T15:56:07 <jaiditya> ThomasWaldmann: yes it looks messy
289 2012-08-18T15:56:17 <ThomasWaldmann> other than that, see my general comments from above (try to make basic workflow work and be somewhat obvious, do not add new functionality for now)
290 2012-08-18T15:56:38 <ThomasWaldmann> nothing more from me
291 2012-08-18T15:56:52 <jaiditya> will look and discuss with spy
292 2012-08-18T15:56:52 <ThomasWaldmann> MaikuMori: breton: are you with us?
293 2012-08-18T15:57:16 <dreimark> thanks spy
294 2012-08-18T15:57:47 <breton> +
295 2012-08-18T15:58:27 <ThomasWaldmann> ok, breton is next
296 2012-08-18T15:58:57 <ThomasWaldmann> MaikuMori: if you are here, you will be after breton, please prepare
297 2012-08-18T16:00:10 <breton> LAST: fixing failing tests (bug #1 on bitbucket), fixing what was mentioned on cr.
298 2012-08-18T16:00:13 <breton> BLOCKERS: None
299 2012-08-18T16:00:15 <breton> NEXT: http://etherpad.osuosl.org/moin2-bms :114 one of two bugs with branches left. Also tests for indexing need enhancing.
300 2012-08-18T16:02:01 <ThomasWaldmann> breton: can you show anything on the UI?
301 2012-08-18T16:05:57 <ThomasWaldmann> btw, did you improve the docs for the tests? can you give some overview what's working and what not?
302 2012-08-18T16:06:56 <breton> err, what do you mean by ui? There are branches on +history, ways to edit specific revision. Also, there is a variable which can be checked to decide whether to show a user a notification that he is not on his userhead
303 2012-08-18T16:07:44 <breton> working everything except for remaining. Tests fail only on that part (item.Item.rename, renaming in user groups)
304 2012-08-18T16:11:17 <breton> 5 failing tests now; docs on the tests - well, I don't know whether http://codereview.appspot.com/6459066/diff/17001/MoinMoin/search/_tests/test_search_helpers.py is enough, though I can describe them more verbose if something is obscure
305 2012-08-18T16:12:46 <ThomasWaldmann> maybe just write some docs that answers my 3 questions
306 2012-08-18T16:14:34 <ThomasWaldmann> about the test docs: getting better, but try to write complete sentences, not just fragments
307 2012-08-18T16:18:55 <xiaq> Ticket index: http://z.tuna.tsinghua.edu.cn:8088/%2Bindex/?itemtype=ticket&mode=detailed (the UI is not worked yet - no way to switch mode on UI, itemtype filtering squashed together with contenttype filtering)
308 2012-08-18T16:18:59 <xiaq> ThomasWaldmann: ^
309 2012-08-18T16:19:00 <xiaq> dreimark: ^
310 2012-08-18T16:19:28 <ThomasWaldmann> breton: UI means user interface and is the way the user could work with your code
311 2012-08-18T16:20:42 <ThomasWaldmann> breton: "working everything except for remaining."
312 2012-08-18T16:20:55 <ThomasWaldmann> isn't that always true? :P
313 2012-08-18T16:21:31 <breton> s/remaining/renaming/
314 2012-08-18T16:22:06 <ThomasWaldmann> i suggest you write that a bit more specifically into your docs. show me stuff that is working, document stuff that is TODO.
315 2012-08-18T16:22:41 <ThomasWaldmann> you can point to unit tests there, but it should also have references to the moin user interface.
316 2012-08-18T16:24:37 * ThomasWaldmann will need to look all over your project next week and write the final evaluation. if you make it more easy for me to find the good working parts, that could maybe improve the outcome.
317 2012-08-18T16:25:39 <ThomasWaldmann> also make sure all stuff that is in reasonable state is documented (in the src), committed and pushed
318 2012-08-18T16:25:49 <breton> ok.
319 2012-08-18T16:27:23 <ThomasWaldmann> did you do anything related to merging?
320 2012-08-18T16:27:49 <breton> no. Fixing tests took too much time.
321 2012-08-18T16:28:00 <ThomasWaldmann> ok
322 2012-08-18T16:28:20 * ThomasWaldmann remembers the cat
323 2012-08-18T16:28:48 <dreimark> cat?
324 2012-08-18T16:29:15 <ThomasWaldmann> see the imgur url from yesterday (and my video response)
325 2012-08-18T16:29:30 <ThomasWaldmann> any more questions to/from breton?
326 2012-08-18T16:30:17 <dreimark> not now
327 2012-08-18T16:30:29 <ThomasWaldmann> MaikuMori: with us now?
328 2012-08-18T16:30:46 <dreimark> eSyr-ng: ?
329 2012-08-18T16:30:55 <ThomasWaldmann> eSyr: ^
330 2012-08-18T16:31:28 <dreimark> ng == next generation?
331 2012-08-18T16:31:50 <ThomasWaldmann> maybe esyr can say something, otherwise it looks like we are through for today's meeting
332 2012-08-18T16:32:31 <ThomasWaldmann> as a final note (I already said it, but better repeating it once more): students have to be available until at least the eval deadline
333 2012-08-18T16:32:56 * breton afk for the next 9h. gn.
334 2012-08-18T16:32:59 <ThomasWaldmann> in case your mentor(s) have questions or remarks, make sure you are
335 2012-08-18T16:33:11 <ThomasWaldmann> gn breton
336 2012-08-18T16:33:12 <dreimark> gn breton
337 2012-08-18T16:37:20 <dreimark> bbl
338 2012-08-18T16:38:26 * ThomasWaldmann will have a phone call now, but will be looking at things afterward
339 2012-08-18T16:38:27 <ThomasWaldmann> s
340 2012-08-18T17:18:39 *** DasIch
341 2012-08-18T17:24:29 *** DasIch
342 2012-08-18T17:24:49 <spy> ThomasWaldmann: please review http://codereview.appspot.com/6441151/
343 2012-08-18T17:49:53 <spy> ThomasWaldmann: updated pull request
344 2012-08-18T18:26:56 <ThomasWaldmann> re
345 2012-08-18T19:14:33 <xiaq> weird, why does my pull req still show up as "open" https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/80 ???
346 2012-08-18T19:15:23 *** RogerHaase
347 2012-08-18T19:16:01 <ThomasWaldmann> because they broke bitbucket
348 2012-08-18T19:16:14 <ThomasWaldmann> i already filed 2 issues about this
349 2012-08-18T19:16:56 <xiaq> uh oh...
350 2012-08-18T19:21:36 <xiaq> ThomasWaldmann: http://codereview.appspot.com/6463067
351 2012-08-18T19:21:38 <xiaq> dreimark: ^
352 2012-08-18T19:23:20 <xiaq> ThomasWaldmann: http://codereview.appspot.com/6462082/
353 2012-08-18T19:23:22 <xiaq> dreimark: ^
354 2012-08-18T19:28:04 * xiaq sent another pull req to ThomasWaldmann. the pull req is now truely open. :)
355 2012-08-18T19:32:13 <ThomasWaldmann> ehrm, why is ticket.css separate?
356 2012-08-18T19:32:47 <ThomasWaldmann> xiaq:
357 2012-08-18T19:35:11 <xiaq> else i have to make the same additions to foobar and modernized's stylus sources...
358 2012-08-18T19:36:36 <ThomasWaldmann> are you the first having this problem?
359 2012-08-18T19:36:37 * xiaq looked for some css common to all themes but it turned out to be nonexisting.
360 2012-08-18T19:37:07 <ThomasWaldmann> reset.css is also common, right?
361 2012-08-18T19:37:42 <xiaq> ThomasWaldmann: there are two of them, though identical
362 2012-08-18T19:39:49 <xiaq> anyway, i wish ticket and blog will be turned into "itemtype plugins" at some time which will *require* separate css (and stylus) sources
363 2012-08-18T19:41:32 <xiaq> (we can ship them as official plugins. :)
364 2012-08-18T19:46:56 <ThomasWaldmann> ok
365 2012-08-18T19:49:18 <ThomasWaldmann> xiaq: why is the css/styl in templates and not in static?
366 2012-08-18T19:53:04 * xiaq put them in static, cr updated (http://codereview.appspot.com/6458157/)
367 2012-08-18T19:54:12 <xiaq> perhaps templates/{common,index_action}.js ought to be moved to static/ as well?
368 2012-08-18T19:54:27 <ThomasWaldmann> no, templates are templates :)
369 2012-08-18T19:54:33 <ThomasWaldmann> ehrm
370 2012-08-18T19:54:39 <ThomasWaldmann> wait
371 2012-08-18T19:55:11 <ThomasWaldmann> hmm, strange, since when are they there? :D
372 2012-08-18T19:55:18 <ThomasWaldmann> jaiditya: ^^
373 2012-08-18T19:55:19 * xiaq shrugs
374 2012-08-18T19:56:05 <ThomasWaldmann> (once there was the idea of serving js from a template to be able to do i18n, but iirc we are not doing that yet, right?)
375 2012-08-18T19:56:32 <xiaq> they were there since quite early as "hg blame" told me
376 2012-08-18T19:57:05 <xiaq> ThomasWaldmann: changeset a8d0a52bb45d. it was yours :)
377 2012-08-18T19:57:39 <xiaq> hm, that was not long ago...
378 2012-08-18T19:58:28 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0/rev/466a277c72a3 oh, i was wrong, it IS implemented
379 2012-08-18T19:58:48 <ThomasWaldmann> or at least i have begun with that
380 2012-08-18T19:59:55 <xiaq> hm, so js sources that have i18n-able strings get kept in templates/
381 2012-08-18T20:00:50 <ThomasWaldmann> templates are kept there :)
382 2012-08-18T20:01:02 <ThomasWaldmann> and that js file is in fact a template that expands to js
383 2012-08-18T20:01:24 <ThomasWaldmann> (like the html files there are templates that expand to html)
384 2012-08-18T20:02:05 <ThomasWaldmann> so, the question is whether your stuff should be a template
385 2012-08-18T20:02:33 <xiaq> ah, i saw some {{ }} in common.js
386 2012-08-18T20:12:15 <ThomasWaldmann> spy: i am pulling/merging your stuff now, but we need to talk about tests
387 2012-08-18T20:16:40 <dreimark> re
388 2012-08-18T20:19:40 * xiaq updated pull req
389 2012-08-18T20:19:42 <xiaq> ThomasWaldmann: ^^
390 2012-08-18T20:25:17 <CIA-65> Pavel Sviderski <pavel@psviderski.name> default * 1708:1972c90b0201 2.0/MoinMoin/ (_tests/__init__.py items/_tests/test_Blog.py): Add unittests for Blog and BlogEntry itemtypes.
391 2012-08-18T20:25:18 <CIA-65> Pavel Sviderski <pavel@psviderski.name> default * 1709:4bf5108b1d73 2.0/MoinMoin/ (_tests/__init__.py items/_tests/test_Blog.py): merged
392 2012-08-18T20:25:19 <CIA-65> Pavel Sviderski <pavel@psviderski.name> default * 1710:2bd2dad3cc74 2.0/MoinMoin/ (3 files in 3 dirs): Add 'Modify entry' link on a blog entry. It is displayed on the entry if the user has the right to modify this entry.
393 2012-08-18T20:25:19 <CIA-65> Pavel Sviderski <pavel@psviderski.name> default * 1711:6ba24e1114d5 2.0/MoinMoin/ (3 files in 3 dirs): Fix blog's layout (fixate the sidebar).
394 2012-08-18T20:27:50 <ThomasWaldmann> xiaq: colons
395 2012-08-18T20:28:00 <dreimark> i guess too much
396 2012-08-18T20:28:26 <dreimark> ignore, that was not for here
397 2012-08-18T20:29:07 <ThomasWaldmann> "this is not for you" ftw
398 2012-08-18T20:29:58 <ThomasWaldmann> spy: after merging your PR failing tests increased from 1 to 4 for me
399 2012-08-18T20:30:00 <xiaq> ThomasWaldmann: oh :(
400 2012-08-18T20:30:41 <xiaq> seems no way to fix the changeset log, is there?
401 2012-08-18T20:31:13 <xiaq> (except tear down and reinstall my bb repo)
402 2012-08-18T20:31:27 <CIA-65> Cheer Xiao <xiaqqaix@gmail.com> default * 1712:84b4ba208e8d 2.0/MoinMoin/templates/ (ticket.html ticket.css ticket.styl): Add ticket-specific stylesheet (stylus source and generated css).
403 2012-08-18T20:31:27 <CIA-65> Cheer Xiao <xiaqqaix@gmail.com> default * 1713:c924af7f5230 2.0/MoinMoin/ (5 files in 3 dirs): Move ticket.{css,styl} to MoinMoin/static/css.
404 2012-08-18T20:31:28 <CIA-65> Cheer Xiao <xiaqqaix@gmail.com> default * 1714:f38034fac8fc 2.0/MoinMoin/static/css/stylus/ticket.styl: Remove unnecessary commas in MoinMoin/static/css/stylus/ticket.styl.
405 2012-08-18T20:31:29 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1715:ed2bfccada9b 2.0/MoinMoin/ (3 files in 3 dirs): merged
406 2012-08-18T20:31:49 <ThomasWaldmann> xiaq: no problem, it is quite obvious from the cs
407 2012-08-18T20:33:29 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/pull-requests ok, everything there has now a comment reflecting the real state of the pull request
408 2012-08-18T20:34:15 <xiaq> ThomasWaldmann: ok :)
409 2012-08-18T20:35:13 <xiaq> ThomasWaldmann: updated http://codereview.appspot.com/6462082/ (constants.itemtype)
410 2012-08-18T20:35:16 <xiaq> dreimark: ^
411 2012-08-18T20:41:20 <ThomasWaldmann> commented there
412 2012-08-18T20:48:06 <dreimark> me replyed
413 2012-08-18T20:48:33 <xiaq> dreimark: was updated twice, your comments no longer apply :-P
414 2012-08-18T20:49:00 <dreimark> seen i was too slow
415 2012-08-18T20:49:26 <xiaq> ThomasWaldmann: ^^ (updated once after your comment)
416 2012-08-18T20:53:27 * xiaq wonders if moin2's smiley set is extensible
417 2012-08-18T20:53:51 <xiaq> (i mean strings that get converted to smily pics)
418 2012-08-18T20:54:21 <ThomasWaldmann> parser customizations are rather a problem than a solution
419 2012-08-18T20:54:26 <xiaq> answering my own question: not (yet)
420 2012-08-18T20:59:41 * xiaq goes to bed - it's almost dawn here :)
421 2012-08-18T21:00:22 * ThomasWaldmann commented
422 2012-08-18T21:00:29 <ThomasWaldmann> xiaq: gn
423 2012-08-18T21:00:59 <dreimark> gn xiaq
424 2012-08-18T21:03:08 *** ronny
425 2012-08-18T21:03:09 <ronny> sup
426 2012-08-18T21:14:10 <ThomasWaldmann> irc free time over? :P
427 2012-08-18T21:14:20 <ronny> ThomasWaldmann, taking a look
428 2012-08-18T21:14:27 <ronny> i'll leave again
429 2012-08-18T21:14:31 <ronny> my thesis isnt finished
430 2012-08-18T21:14:36 <ronny> but the programming part is
431 2012-08-18T21:26:55 <ThomasWaldmann> ronny: what was the topic again?
432 2012-08-18T21:57:42 <ronny> ThomasWaldmann, design & impl of a ci tool on top of a distributed db
433 2012-08-18T22:02:38 *** jaiditya
434 2012-08-18T22:06:18 <ThomasWaldmann> ah
435 2012-08-18T23:36:43 <spy> ThomasWaldmann: for me 1705:6cd9347f7cc5 revision breaks 4 tests in MoinMoin/apps/admin/_tests/test_admin.py. When i update to 1704 everything if fine. I doubt that my changes are to blame.
