1 2012-08-17T00:00:31  <jaiditya> RogerHaase: it ha a leading comma from line 1579 so its not needed there
   2 2012-08-17T00:01:32  <RogerHaase> hmm, similar situation at line 1597, 1598, and 1652.
   3 2012-08-17T00:01:50  <jaiditya> dreimark: there is some unwanted css in new reset.css, can I delete those lines ?
   4 2012-08-17T00:02:16  <dreimark> jaiditya: add the notice i got by twitter first, commit that
   5 2012-08-17T00:02:18  <dreimark> then remove
   6 2012-08-17T00:02:37  <dreimark> jaiditya: where got you stylus from
   7 2012-08-17T00:03:48  <RogerHaase> jaiditya: if I add spaces to the lines above, there is no change in the output.  No errors.  Maybe another stylus bug
   8 2012-08-17T00:05:58  <jaiditya> RogerHaase: yes you can add as many spaces you want when a comma is encountered it takes the next occuring as attributes
   9 2012-08-17T00:06:12  <jaiditya> no matter where it is
  10 2012-08-17T00:06:38  <jaiditya> dreimark: npm install stylus
  11 2012-08-17T00:07:16  <jaiditya> dreimark: npm install stylus -g
  12 2012-08-17T00:07:29  <jaiditya> on windows
  13 2012-08-17T00:08:23  <jaiditya> g for installing globally
  14 2012-08-17T00:12:36  <RogerHaase> "stylus -V" yields 0.29.0 here
  15 2012-08-17T00:14:12  <jaiditya> 0.27.0 here
  16 2012-08-17T00:16:45  <dreimark> http://rn0.ru/show/K9HDHDhlckKBKqEMgjs2/
  17 2012-08-17T00:16:52  <jaiditya> dreimark: by notice you mean reply of Rich Clark ?
  18 2012-08-17T00:16:55  <RogerHaase> to me, spy's pastebin error message seems correct.  Stylus should complain about the change in indenting
  19 2012-08-17T00:17:07  <dreimark> thats what i get
  20 2012-08-17T00:17:23  <dreimark> jaiditya: yes the text he sended in the tweet
  21 2012-08-17T00:17:48  <RogerHaase> dreimark: what stylus version do you have?
  22 2012-08-17T00:19:25  <dreimark> the recent one by npm installed not globally, nodejs has 0.6.12
  23 2012-08-17T00:19:41  <RogerHaase> stylus -V
  24 2012-08-17T00:20:34  <dreimark> stylus -V
  25 2012-08-17T00:20:35  <dreimark> 0.29.0
  26 2012-08-17T00:21:04  <dreimark> i read later , tired at the moment, gn
  27 2012-08-17T00:44:33  *** RogerHaase has left #moin-dev
  28 2012-08-17T04:44:36  *** jaiditya has quit IRC
  29 2012-08-17T05:29:52  *** RogerHaase has joined #moin-dev
  30 2012-08-17T05:41:18  <RogerHaase> spy: jaiditya: fyi, I ran stylus 0.28.2 on Linux Mint with 0 errors; upgraded to 0.29.0 and received same "expected indent" error.  As stated earlier, stylus 0.29.0 on windows does not put out the error message.  My take is to fix the 4 lines with indent problems and open another issue against stylus.
  31 2012-08-17T05:45:46  *** RogerHaase has left #moin-dev
  32 2012-08-17T06:24:06  *** bilal has quit IRC
  33 2012-08-17T06:25:18  *** bilal has joined #moin-dev
  34 2012-08-17T09:28:41  <ThomasWaldmann> moin
  35 2012-08-17T09:35:38  <dreimark> spy: review done
  36 2012-08-17T09:37:15  <dreimark> bbl
  37 2012-08-17T09:59:05  <ThomasWaldmann> xiaq: ticket metadata still looks crappy, can you fix it please?
  38 2012-08-17T09:59:11  <ThomasWaldmann> (css)
  39 2012-08-17T09:59:47  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1694:dfbddf51ef75 2.0/MoinMoin/themes/foobar/static/css/ (common.css stylus/main.styl): Foobar theme font changed
  40 2012-08-17T09:59:47  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1695:02d900e4fb2f 2.0/MoinMoin/themes/foobar/static/css/ (common.css stylus/main.styl): Foobar theme moin-breadcrumps padding changed
  41 2012-08-17T09:59:48  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1696:0538829f868e 2.0/MoinMoin/themes/foobar/static/css/ (common.css stylus/main.styl): Foobar theme global index elements styling changed
  42 2012-08-17T09:59:49  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1697:9c96d66ae73d 2.0/MoinMoin/themes/foobar/static/css/ (common.css stylus/main.styl): Foobar theme blog styling added
  43 2012-08-17T09:59:50  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1698:ed73f94cee2d 2.0/MoinMoin/ (5 files in 5 dirs): Textcha padding added
  44 2012-08-17T09:59:51  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1699:62b62246f8db 2.0/MoinMoin/themes/modernized/static/css/ (common.css stylus/main.styl): Modernized theme sub-item link and transclude button shadow removed
  45 2012-08-17T09:59:51  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1700:c9229a30bc0d 2.0/MoinMoin/themes/modernized/static/css/ (common.css stylus/main.styl): Modernized theme font styling
  46 2012-08-17T09:59:52  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1701:dd73d5e58e18 2.0/MoinMoin/themes/modernized/static/css/ (common.css stylus/main.styl): Modernized theme sub-item padding changed
  47 2012-08-17T09:59:55  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1702:d52910dd549f 2.0/MoinMoin/themes/modernized/static/css/ (common.css stylus/main.styl): Modernized theme header elements top padding changed
  48 2012-08-17T09:59:55  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1703:7311a1d8a5eb 2.0/MoinMoin/themes/modernized/static/css/ (common.css stylus/main.styl): Modernized theme item-views margin changed
  49 2012-08-17T09:59:55  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1704:067a8a0ed22a 2.0/MoinMoin/ (5 files in 3 dirs): merged
  50 2012-08-17T09:59:55  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1705:6cd9347f7cc5 2.0/MoinMoin/apps/admin/views.py: Admin menu hidded for non-admin users
  51 2012-08-17T09:59:56  <CIA-65> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1706:78a484e1d555 2.0/MoinMoin/themes/modernized/static/css/ (common.css stylus/main.styl): Modernized theme moin-flash margin changed
  52 2012-08-17T10:10:21  <ThomasWaldmann> https://bitbucket.org/site/master/issue/4520/detection-auto-removal-of-merged-pull
  53 2012-08-17T10:10:28  <ThomasWaldmann> https://bitbucket.org/site/master/issue/4519/rejecting-a-pull-request-does-not-work
  54 2012-08-17T10:36:34  <breton> http://i.imgur.com/wGUTG.gif
  55 2012-08-17T10:36:41  * breton will post something today.
  56 2012-08-17T10:41:43  <breton> ThomasWaldmann: reply to https://bitbucket.org/bretonium/moin-2.0/issue/2/history-display-of-branch-name#comment-1814271 please.
  57 2012-08-17T10:58:24  <xiaq> ThomasWaldmann: updated http://codereview.appspot.com/6462051 (better read the diff instead of delta since there has been some rebasing going on, sorry) this resolves the crappy css. :)
  58 2012-08-17T10:58:36  * xiaq has arrived at university
  59 2012-08-17T11:00:32  <xiaq> i'll wait for jaiditya tonight, he seems to be usually online at 1am in his timezone (+5:30) which is 3:30am in mine
  60 2012-08-17T11:03:27  <xiaq> dreimark: ^
  61 2012-08-17T11:04:11  <xiaq> an interesting phononemon is that stylus generated slight different numbers on my machine than main repo
  62 2012-08-17T11:04:55  <xiaq> also, stylus 0.29 won't accept foobar stylus source, so i used 0.28. filing a bug report on jaiditya's repo...
  63 2012-08-17T11:06:05  <xiaq> s/foobar/modernized/ in previous comment...
  64 2012-08-17T11:07:57  <xiaq> so https://bitbucket.org/Jaiditya/moin-2.0/issue/66
  65 2012-08-17T11:11:07  <xiaq> ThomasWaldmann: http://codereview.appspot.com/6457091/ (index cleanup) updated. the only geniune change from patch set 3 is "manufactured" -> "created"...
  66 2012-08-17T11:11:34  <xiaq> hm, it should be possible to avoid rebasing
  67 2012-08-17T11:20:23  *** greg_f has joined #moin-dev
  68 2012-08-17T12:06:42  <dreimark> xiaq: roger has filed a bug in the stylus tracker (or wanted to do that) 0.29 does not work correct on linux but on windows
  69 2012-08-17T12:07:04  <dreimark> or at least works different
  70 2012-08-17T12:09:50  <dreimark> we should have a Makefile entry for stylus
  71 2012-08-17T12:10:46  <xiaq> dreimark: alright
  72 2012-08-17T12:10:47  <dreimark> there are too much digits in that size output too
  73 2012-08-17T12:11:21  <xiaq> dreimark: i got that css with 0.28
  74 2012-08-17T12:11:46  <xiaq> ... which is inconsistent with the version in main repo...
  75 2012-08-17T12:12:16  * xiaq gets 4 failures with tip. is that what you guys get?
  76 2012-08-17T12:12:17  <dreimark> http://moinmo.in/MoinMoinChat/Logs/moin-dev/2012-08-17#CA-d0951bf4002c599b6c5ea6ce03ca3b2d3e05d5b9_23
  77 2012-08-17T12:12:55  <dreimark> xiaq: yes, see there there is a mismatch on os level with that version
  78 2012-08-17T12:14:28  <xiaq> http://rn0.ru/show/zGnv1WD6mkQkfcJNHIja/
  79 2012-08-17T12:14:45  *** jaiditya has joined #moin-dev
  80 2012-08-17T12:14:53  <dreimark> xiaq: http://rn0.ru/show/K9HDHDhlckKBKqEMgjs2/
  81 2012-08-17T12:15:02  <dreimark> moin jaiditya
  82 2012-08-17T12:15:15  <xiaq> jaiditya: hi
  83 2012-08-17T12:16:15  <jaiditya> hi
  84 2012-08-17T12:16:50  <jaiditya> xiaq: are you a linux user ?
  85 2012-08-17T12:17:18  <xiaq> jaiditya: of course
  86 2012-08-17T12:18:54  <jaiditya> dreimark: all linux user are getting same error while generating css from stylus file of modernized theme
  87 2012-08-17T12:19:27  <dreimark> ok, assumed that
  88 2012-08-17T12:20:40  <jaiditya> another stylus bug ?
  89 2012-08-17T12:20:59  <xiaq> jaiditya: could you help review this http://codereview.appspot.com/6462051/ :)
  90 2012-08-17T12:20:59  <dreimark> roger wanted to report it to stylus
  91 2012-08-17T12:21:22  <jaiditya> xiaq: just a min
  92 2012-08-17T12:21:50  <xiaq> jaiditya: also if you have time plz help looking into these two...
  93 2012-08-17T12:21:51  <xiaq> jaiditya: ok
  94 2012-08-17T12:22:01  <xiaq> jaiditya: https://bitbucket.org/xiaq/moin-2.0/issue/3/ and https://bitbucket.org/xiaq/moin-2.0/issue/6/
  95 2012-08-17T12:22:21  <xiaq> seems <dt> and <dd> in <dl> are a bit funny to style
  96 2012-08-17T12:23:05  <xiaq> (i mean, they have some funny default style :)
  97 2012-08-17T12:28:01  <jaiditya> xiaq: these issues are related to ticket page
  98 2012-08-17T12:31:31  <xiaq> jaiditya: yes, ticket page styling
  99 2012-08-17T12:34:11  <jaiditya> xiaq: your patch looks like this https://dl.dropbox.com/u/43518659/xiaq.jpg
 100 2012-08-17T12:34:29  <jaiditya> is this what it was intended to be ?
 101 2012-08-17T12:36:38  <xiaq> jaiditya: uh oh
 102 2012-08-17T12:36:44  * xiaq only tested with Fx...
 103 2012-08-17T12:37:17  <xiaq> weird browser incompatibility...
 104 2012-08-17T12:40:12  <xiaq> jaiditya: https://www.dropbox.com/s/wndqv2u24ne9jj2/inline-labels.png is what it's intended to be
 105 2012-08-17T12:42:09  <xiaq> hm, removing .moin-form dd input{width:75%}
 106 2012-08-17T12:42:12  <xiaq> does the trick
 107 2012-08-17T12:51:12  <jaiditya> xiaq: I don't see "moin-inline-label" applied to the radio buttons ?
 108 2012-08-17T12:52:00  <xiaq> jaiditya: it applies to the label after it
 109 2012-08-17T12:52:10  <dreimark> bbl
 110 2012-08-17T12:52:48  <xiaq> jaiditya: the label renders as "block", forcing each choice to be one a separate line
 111 2012-08-17T12:54:37  <xiaq> jaiditya: the radio button has "width:75%" applied is another issue, but somehow it's interpreted differently by Firefox
 112 2012-08-17T12:57:51  <jaiditya> xiaq: instead of giving a special class to lables, give a id to this form as it is different from other forms and then you can easily change properties of both lable and input radio button
 113 2012-08-17T12:59:13  <jaiditya> look at l 292 of foobar theme stylus file
 114 2012-08-17T12:59:49  <jaiditya> #moin-options needed a different styling then other forms
 115 2012-08-17T13:04:41  <xiaq> jaiditya: ok
 116 2012-08-17T13:06:30  <jaiditya> xiaq: have looked at issue related to link and transclude buttons on modify page
 117 2012-08-17T13:06:57  <xiaq> jaiditya: it's already fixed. :)
 118 2012-08-17T13:07:36  <jaiditya> xiaq: :) ...merged yet ?
 119 2012-08-17T13:07:41  <xiaq> jaiditya: yes
 120 2012-08-17T13:07:50  <jaiditya> when ?
 121 2012-08-17T13:08:28  <xiaq> jaiditya: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/74/fix-broken-link-to-subitem-and-transclude
 122 2012-08-17T13:08:38  <xiaq> 2 days ago
 123 2012-08-17T13:11:59  <jaiditya> xiaq: its still not working here
 124 2012-08-17T13:13:51  * xiaq checked original behavior on test.moinmo.in
 125 2012-08-17T13:14:14  <jaiditya> it just adds file name on current stage
 126 2012-08-17T13:14:34  <xiaq> jaiditya: ah yes, but previously it was more broken, it didn't insert anything at all. :)
 127 2012-08-17T13:15:23  <jaiditya> yes. It should add content of the file
 128 2012-08-17T13:16:26  <xiaq> ah
 129 2012-08-17T13:16:31  <jaiditya> xiaq: another issue is in foobar theme the search result page has missing pagename
 130 2012-08-17T13:16:34  <xiaq> guessContentType was broken too
 131 2012-08-17T13:17:02  <jaiditya> in header
 132 2012-08-17T13:17:57  <jaiditya> hmm...
 133 2012-08-17T13:19:15  * xiaq didn't touch search.html, but will have a look
 134 2012-08-17T13:21:34  <xiaq> jaiditya: i don't see what's missing in foobar theme's search results page
 135 2012-08-17T13:22:11  <jaiditya> xiaq: https://dl.dropbox.com/u/43518659/searchpage.jpg
 136 2012-08-17T13:22:36  <jaiditya> it had "Search" in header
 137 2012-08-17T13:24:49  <xiaq> jaiditya: in foobar's layout.html there is no "pagepath" block as in default layout.html
 138 2012-08-17T13:24:54  <xiaq> that's the problem
 139 2012-08-17T13:29:40  <jaiditya> xiaq: L 121 layout.html
 140 2012-08-17T13:30:35  <jaiditya> without block
 141 2012-08-17T13:31:01  <xiaq> jaiditya: yup
 142 2012-08-17T13:33:41  <jaiditya> xiaq: I have made the changes
 143 2012-08-17T13:33:51  <jaiditya> and will push to the main repo
 144 2012-08-17T13:38:01  <jaiditya> xiaq: while styling the ticket form don't forget to add a width(in %) to the textarea of "Message"
 145 2012-08-17T13:41:01  <xiaq> jaiditya: yeah. i think i can now solve the problem myself :)
 146 2012-08-17T13:41:32  <jaiditya> great :)
 147 2012-08-17T13:42:29  <xiaq> jaiditya: btw, there is still some duplicate code in foobar's index.html
 148 2012-08-17T13:45:49  <jaiditya> xiaq: you mean the content block ?
 149 2012-08-17T13:46:34  <xiaq> jaiditya: yes
 150 2012-08-17T13:58:07  <jaiditya> xiaq: you see a way out of it other than moving content block to a nother file ?
 151 2012-08-17T13:58:17  <jaiditya> another*
 152 2012-08-17T14:10:27  <xiaq> jaiditya: seems foobar-specific page contents all reside in the "local" block right?
 153 2012-08-17T14:11:23  <jaiditya> yeah
 154 2012-08-17T14:12:38  <xiaq> jaiditya: and i wonder what's the purpose for local.html? can it be just put into layout.html?
 155 2012-08-17T14:14:16  <jaiditya> xiaq: layout.html is for pages without local panel and local.html for those which have a local panel
 156 2012-08-17T14:14:45  <jaiditya> so two possible views for a single theme
 157 2012-08-17T14:16:50  <xiaq> jaiditya: an extra local panel
 158 2012-08-17T14:18:30  <jaiditya> In foobar theme we have two panels i.e. one global panel which is on left and is always present and one local panel on left which is present on few pages and absent on others
 159 2012-08-17T14:18:53  <jaiditya> *local panel on right
 160 2012-08-17T14:20:45  <xiaq> jaiditya: what about 1) make the panel code a macro, thus pages that need an extra panel includes the macro rather than inherits from local.html 2) let foobar index.html inherit default index.html and add up the extra panel
 161 2012-08-17T14:22:54  <xiaq> macros do not support inheritance like blocks too, so the code will be a bit tedious
 162 2012-08-17T14:22:59  <xiaq> s/too/do/
 163 2012-08-17T14:23:07  <jaiditya> but problem there is that action menus of default index page is in content box.
 164 2012-08-17T14:23:38  <jaiditya> which is not needed in foobar theme
 165 2012-08-17T14:24:14  <jaiditya> as they are present in the local panel
 166 2012-08-17T14:25:18  <xiaq> seems we need to do some restructure to default index.html to accomodate this
 167 2012-08-17T14:26:13  <jaiditya> xiaq: display none
 168 2012-08-17T14:27:03  <jaiditya> to moin-align right div would remove those menus
 169 2012-08-17T14:27:30  <jaiditya> no no
 170 2012-08-17T14:27:59  <xiaq> jaiditya: i'd rather see the code themselves taken out, rather than hidden using css trick
 171 2012-08-17T14:28:32  <jaiditya> yeah.
 172 2012-08-17T14:30:06  <xiaq> jaiditya: what about putting action menu in a block at the same level of "content" (eg "action"), and in foobar's index.html, inherit "action" block and put it in the extra panel's <div>?
 173 2012-08-17T14:30:22  <xiaq> {% block action %}
 174 2012-08-17T14:30:29  <xiaq> <div id="extra-panel">
 175 2012-08-17T14:30:32  <xiaq> {{ super() }}
 176 2012-08-17T14:30:34  <xiaq> </div>
 177 2012-08-17T14:30:40  <xiaq> {% endblock %}
 178 2012-08-17T14:30:55  <xiaq> (just some pseudocode, i didn't look at how the extra panel is named)
 179 2012-08-17T14:31:36  * xiaq afk for ~10min
 180 2012-08-17T14:35:11  <jaiditya> xiaq: dunno if by this we can even override the location of a block. Will have to check
 181 2012-08-17T14:43:41  <MaikuMori> moin
 182 2012-08-17T14:52:28  *** dave_largo has joined #moin-dev
 183 2012-08-17T15:02:40  <xiaq> jaiditya: isn't location fully controllable by css?
 184 2012-08-17T15:02:52  <xiaq> the location in code doesn't really matter, does it?
 185 2012-08-17T15:03:18  <xiaq> ThomasWaldmann: http://etherpad.osuosl.org/moin-rich-index line 84
 186 2012-08-17T15:03:19  <xiaq> spy: ^
 187 2012-08-17T15:03:21  <xiaq> dreimark: ^
 188 2012-08-17T15:57:23  *** MaikuMori has quit IRC
 189 2012-08-17T15:57:23  *** ThomasWaldmann has quit IRC
 190 2012-08-17T15:57:58  *** MaikuMori has joined #moin-dev
 191 2012-08-17T15:57:58  *** ThomasWaldmann has joined #moin-dev
 192 2012-08-17T16:03:20  *** DasIch has joined #moin-dev
 193 2012-08-17T16:04:54  <spy> dreimark: http://codereview.appspot.com/6441151/
 194 2012-08-17T16:04:56  <spy> ThomasWaldmann: ^
 195 2012-08-17T17:02:41  *** dwcramer has joined #moin-dev
 196 2012-08-17T17:09:09  *** Issif has joined #moin-dev
 197 2012-08-17T17:11:02  <Issif> I have a 1.5.7 MM installation, and I would like migrate datas to a 1.9.4 instance. Is it possible? Normally, I don't use special plugin.
 198 2012-08-17T17:19:23  <eSyr-ng> Issif: yes.
 199 2012-08-17T17:20:38  <Issif> So. I guess this procedure : http://moinmo.in/HowTo/Migrate%20from%201.5%20to%201.6 is still available for it?
 200 2012-08-17T17:21:16  <Issif> I found some part a little confuse
 201 2012-08-17T17:22:12  <Issif> I'll test that and make a report here if I've trouble
 202 2012-08-17T17:30:19  <dreimark> sure just read docs/upgrade.html
 203 2012-08-17T17:30:40  <dreimark> issif
 204 2012-08-17T17:33:53  <Issif> I have another questions, why the folder /underlay/pages is empty in the 1.9.4 archive?
 205 2012-08-17T17:35:03  <Issif> I've just looked in the 1.8.9 archive and the folder is full
 206 2012-08-17T17:47:15  <dreimark> read the docs
 207 2012-08-17T17:47:30  <dreimark> we have all these pages bundled
 208 2012-08-17T17:47:50  <dreimark> you have to visit languagesetup
 209 2012-08-17T17:48:04  <dreimark> and install those you want
 210 2012-08-17T17:48:43  <dreimark> btw. this channel is for development and #moin for all other requesrs
 211 2012-08-17T17:54:40  <dreimark> bbl
 212 2012-08-17T18:16:19  *** dave_largo has quit IRC
 213 2012-08-17T19:05:00  *** RogerHaase has joined #moin-dev
 214 2012-08-17T19:41:27  <ThomasWaldmann> breton: haha @ http://i.imgur.com/wGUTG.gif
 215 2012-08-17T19:43:31  <ThomasWaldmann> cool cats do it like this: http://www.youtube.com/watch?v=PYqXKk59fBg
 216 2012-08-17T19:54:34  *** greg_f has quit IRC
 217 2012-08-17T20:03:07  * ThomasWaldmann brb
 218 2012-08-17T20:13:43  *** jaiditya|2 has joined #moin-dev
 219 2012-08-17T20:16:19  *** jaiditya has quit IRC
 220 2012-08-17T20:33:12  <dreimark> re
 221 2012-08-17T20:55:10  *** jaiditya|2 has quit IRC
 222 2012-08-17T21:07:34  <spy> jaiditya's 1705:6cd9347f7cc5 revision brokes 'MoinMoin/apps/admin/_tests/test_admin.py' unittest. I wonder why he didn't check that doing such permissions refactoring.
 223 2012-08-17T21:22:31  <spy> ThomasWaldmann: sent a pull request
 224 2012-08-17T21:25:06  *** spy has quit IRC
 225 2012-08-17T21:37:32  <Issif> dreimark: ok sorry. thx
 226 2012-08-17T21:37:38  *** spy has joined #moin-dev
 227 2012-08-17T21:37:49  <Issif> :pqrt
 228 2012-08-17T21:37:56  *** Issif has left #moin-dev
 229 2012-08-17T21:57:34  *** dwcramer has quit IRC
 230 2012-08-17T21:58:35  *** jaiditya has joined #moin-dev
 231 2012-08-17T23:03:12  *** grzywacz has joined #moin-dev
 232 2012-08-17T23:03:13  *** grzywacz has joined #moin-dev
 233 2012-08-17T23:12:02  *** DasIch has joined #moin-dev
 234 2012-08-17T23:13:26  *** betelgeuse_ has joined #moin-dev
 235 2012-08-17T23:14:12  *** betelgeuse_ has left #moin-dev
 236 2012-08-17T23:24:09  <dreimark> re
 237 2012-08-17T23:32:01  <spy> jaiditya: hi, seems you have broken tests (rev. 6cd9347f7cc5)
 238 2012-08-17T23:33:08  *** grzywacz has quit IRC
 239 2012-08-17T23:34:10  <spy> jaiditya: change them in accordance with your code changes.
 240 2012-08-17T23:39:03  <jaiditya> spy: I saw that but I guess thats what ThomasWaldmann ment here https://bitbucket.org/Jaiditya/moin-2.0/issue/39/hide-admin-for-non-admin
 241 2012-08-17T23:41:10  <jaiditya> RogerHaase: CAn you check this I might have got it wrong here
 242 2012-08-17T23:41:16  <spy> dreimark: about the helper function, you mean a private method inside the TestBlog class that sets PTIME/ACL and updates those items, right?
 243 2012-08-17T23:56:33  *** dwcramer has joined #moin-dev
 244 2012-08-17T23:57:06  <dreimark> spy: there is some code duplication
 245 2012-08-17T23:59:08  <dreimark> if it makes sense you could add it also on tests/__init__

MoinMoin: MoinMoinChat/Logs/moin-dev/2012-08-17 (last edited 2012-08-16 22:45:03 by IrcLogImporter)