1 2012-08-11T01:44:47 <CIA-54> Pavel Sviderski <pavel@psviderski.name> default * 1653:57e864bb8852 2.0/MoinMoin/ (3 files in 2 dirs): Add the ability to create new Blog and Blog entry items.
2 2012-08-11T02:08:28 <ThomasWaldmann> hmm, not very intuitive yet (or I am doing sth wrong) ^
3 2012-08-11T02:20:22 <ThomasWaldmann> jaiditya: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/232/cant-create-item#comment-1781982 what does that link mean?
4 2012-08-11T02:21:58 <jaiditya> ThomasWaldmann: that issue is resolved I tried to comment the pointing changeset but was not able to do that
5 2012-08-11T02:23:11 <ThomasWaldmann> well, you need to say why you point to something
6 2012-08-11T02:23:46 <ThomasWaldmann> and the issue on the tracker is still open, not resolved
7 2012-08-11T02:24:44 <jaiditya> I mean I fixed that bug and when I tried comment that I was not able to do that
8 2012-08-11T02:26:07 <jaiditya> ThomasWaldmann: https://bitbucket.org/thomaswaldmann/moin-2.0/changeset/669779fc2fb19fc19c22ef407fb906a041fdbc5c
9 2012-08-11T02:30:44 <ThomasWaldmann> if you were not able to comment, how did you put that comment with the link there?
10 2012-08-11T02:32:47 <jaiditya> I can't see any of my comment there
11 2012-08-11T02:33:14 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/232/cant-create-item laste comment
12 2012-08-11T02:33:58 <ThomasWaldmann> anyway, shall i close that issue as that changeset fixed it?
13 2012-08-11T02:35:35 <jaiditya> yes...this is what I see https://dl.dropbox.com/u/43518659/no-comment.jpg
14 2012-08-11T02:38:01 <ThomasWaldmann> do you see it now?
15 2012-08-11T02:38:56 <ThomasWaldmann> there is a new "Approve" link below the comments. i clicked on it now.
16 2012-08-11T02:39:06 <breton> what's the right place for a dict with human-readable names of search types? I need to pass them to a view and add them as <option> for <select>.
17 2012-08-11T02:39:09 <jaiditya> yes
18 2012-08-11T02:39:55 <breton> or just simply add them to templates?
19 2012-08-11T02:41:24 <ThomasWaldmann> hm?
20 2012-08-11T02:46:10 <breton> ThomasWaldmann: that was 'hm' to me or to jaiditya?
21 2012-08-11T02:47:12 <ThomasWaldmann> to you
22 2012-08-11T02:48:20 <ThomasWaldmann> well, put it where you need it?
23 2012-08-11T02:50:08 * breton was looking for something like constant.* for such cases, but okay.
24 2012-08-11T02:58:31 <jaiditya> ThomasWaldmann: I'd like to write documentation regarding themes are there any specific steps that are to be followed ?
25 2012-08-11T03:01:50 <ThomasWaldmann> well, locate a nice place in the docs for it, use rst markup, reread it for typos, render it / look at it in the browser for markup errors
26 2012-08-11T04:44:02 *** moin1
27 2012-08-11T05:09:17 *** moin1
28 2012-08-11T07:57:03 *** MattMaker
29 2012-08-11T07:57:50 *** MattMaker
30 2012-08-11T08:10:23 *** MattMaker
31 2012-08-11T08:14:19 *** MattMaker
32 2012-08-11T09:06:20 <breton> http://codereview.appspot.com/6459066/ some more code for reviedw
33 2012-08-11T09:06:24 <breton> *review
34 2012-08-11T09:09:17 *** Trip_
35 2012-08-11T09:13:07 *** MattMaker
36 2012-08-11T09:13:12 *** Trip_
37 2012-08-11T09:17:57 <dreimark> moin
38 2012-08-11T09:18:19 <dreimark> spy_: i have a blog and two subitems of that blog
39 2012-08-11T09:18:33 <dreimark> Home Home/a Home/b
40 2012-08-11T09:18:59 <dreimark> but +blog/Home always tells "There are no entries in this blog. "
41 2012-08-11T09:57:07 *** MattMaker
42 2012-08-11T10:36:46 <dreimark> jaiditya: http://codereview.appspot.com/6443114/diff/2001/MoinMoin/themes/foobar/templates/index.html
43 2012-08-11T10:40:01 <dreimark> jaiditya: this change or you have to change url = $("#" + actionTrigger).attr("data-actionurl");
44 2012-08-11T10:40:16 <dreimark> and then the template in modernized too
45 2012-08-11T10:40:35 <dreimark> the line was from index_action.js
46 2012-08-11T10:47:30 <dreimark> also that code could be deduplicated
47 2012-08-11T10:50:19 <spy_> dreimark: did you set "Publication time" on Home/a and Home/b ?
48 2012-08-11T10:55:05 *** jaiditya
49 2012-08-11T11:02:27 *** MattMaker
50 2012-08-11T11:07:01 *** MattMaker
51 2012-08-11T11:08:46 *** jaiditya
52 2012-08-11T11:10:06 <jaiditya> I'll just check it
53 2012-08-11T11:11:42 <dreimark> spy_: yes
54 2012-08-11T11:14:02 <dreimark> spy_: works now
55 2012-08-11T11:14:12 <dreimark> i guess i did something wrong
56 2012-08-11T11:19:05 <dreimark> spy_: do you need a restart to get the time new evaluated?
57 2012-08-11T11:22:14 <dreimark> arg, i should know UTC working all day with it, that was my failure
58 2012-08-11T11:22:23 <jaiditya> dreimark: in the current tip while creating a wiki(moinmoin) do I need to change itemtype from default to something else ?
59 2012-08-11T11:22:38 <jaiditya> as I got this error with default http://dpaste.com/784735/
60 2012-08-11T11:23:38 <dreimark> jaiditya: no it is default
61 2012-08-11T11:24:14 <dreimark> jaiditya: have you done moin index-build -s -i
62 2012-08-11T11:24:34 <jaiditya> yes I did it yesterday
63 2012-08-11T11:24:34 <dreimark> currently we have to do that after each pull
64 2012-08-11T11:24:44 <jaiditya> ok
65 2012-08-11T11:24:57 <dreimark> have you some important stuff in your test wiki?
66 2012-08-11T11:25:17 <dreimark> otherwise I would suggest rm -r wiki and moin index-create -s -i afterwards
67 2012-08-11T11:25:20 <jaiditya> no
68 2012-08-11T11:25:43 <dreimark> then start moin process again
69 2012-08-11T11:25:50 <jaiditya> ok
70 2012-08-11T11:30:52 <dreimark> spy_: http://test.moinmo.in/Home/d
71 2012-08-11T11:31:16 <dreimark> this is the meta of my Home/d item which still is not shown as blog entry
72 2012-08-11T11:31:29 <dreimark> the tests from the morning are now shown
73 2012-08-11T11:32:08 <dreimark> 2012-08-11 09:24:00 UTC should already show up
74 2012-08-11T11:33:53 <dreimark> bbl
75 2012-08-11T11:44:56 *** spy
76 2012-08-11T12:01:56 *** spy
77 2012-08-11T12:03:47 *** bilal_
78 2012-08-11T12:09:30 *** bilal
79 2012-08-11T12:09:30 *** bilal_
80 2012-08-11T12:20:19 *** spy
81 2012-08-11T13:36:47 <ThomasWaldmann> breton: review done
82 2012-08-11T13:40:31 *** spy
83 2012-08-11T13:40:48 *** spy
84 2012-08-11T13:51:59 *** spy
85 2012-08-11T13:52:14 *** spy
86 2012-08-11T14:01:48 *** spy
87 2012-08-11T14:02:12 *** spy
88 2012-08-11T14:08:15 <spy_> ThomasWaldmann: http://etherpad.osuosl.org/moin-commenting line 56
89 2012-08-11T14:12:26 <xiaq> spy_: aha i read ThomasWaldmann's comment on 55 which made me wondering
90 2012-08-11T14:12:40 <xiaq> are we going to have refcount in moin2? :-P
91 2012-08-11T14:13:32 <xiaq> Comments can be nameless items, kept alive by the reference in main item's `associated_comments` meta property :-D
92 2012-08-11T14:13:44 <spy_> xiaq: no idea, want to ask Thomas about that :)
93 2012-08-11T14:14:54 <ThomasWaldmann> well, we considered having a trashbin view that just shows all nameless items
94 2012-08-11T14:16:04 <ThomasWaldmann> items with >= 1 names have normal existence, items that got their last name removed a pending for cleanup and living in that trashbin view
95 2012-08-11T14:17:08 <ThomasWaldmann> (this was just one of the ideas of namespaces branch, with items having N names)
96 2012-08-11T14:17:12 <xiaq> http://etherpad.osuosl.org/moin-rich-index everything below line 55 but "initial brain dump" is new
97 2012-08-11T14:17:22 <xiaq> ThomasWaldmann: spy_: dreimark: ^
98 2012-08-11T14:19:20 <xiaq> spy_: just curious, but does your IRC client highlight my last comment where your name wasn't at the beginning?
99 2012-08-11T14:19:27 <xiaq> dreimark: same question :)
100 2012-08-11T14:23:43 <spy_> xiaq: nope :)
101 2012-08-11T14:23:57 <spy_> btw, whta droid irc client do you use?
102 2012-08-11T14:25:11 * ThomasWaldmann uses ssh as "client" everywhere :)
103 2012-08-11T14:25:37 <xiaq> spy_: i ssh to the campus server
104 2012-08-11T14:26:09 <xiaq> spy_: i tried AndroIRC but decided that it was too fancy for me :)
105 2012-08-11T14:26:10 <spy_> xiaq: even on cellphone?
106 2012-08-11T14:26:21 <xiaq> spy_: why not :)
107 2012-08-11T14:26:36 <xiaq> spy_: not ssh but mosh to be exact
108 2012-08-11T14:26:59 <xiaq> spy_:
109 2012-08-11T14:27:10 <xiaq> spy_: uh, i mean http://mosh.mit.edu/
110 2012-08-11T14:27:56 * spy_ looks
111 2012-08-11T14:28:17 <xiaq> spy_: i run irssi in a tmux session. so i just `mosh alef` (server's name) and `tmux attach`
112 2012-08-11T14:29:21 <xiaq> tmux also synchronizes multiple clients attached to the same session, so i can view the same irssi in my mobile and laptop at the same time
113 2012-08-11T14:29:53 <xiaq> spy_: btw, i run mosh in a chrooted archlinuxarm (http://archlinuxarm.org/)
114 2012-08-11T14:30:05 <spy_> xiaq: btw, i prefer old-school screen :)
115 2012-08-11T14:31:10 <xiaq> spy_: i never managed to learn screen, cuz after going thru the docs i heard tmux and it felt really easy.
116 2012-08-11T14:32:17 <xiaq> another btw, i run terminal on Android with SL4A (http://code.google.com/p/android-scripting/) which comes bundled with a version of ConnectBot
117 2012-08-11T14:32:20 <spy_> xiaq: ctrl+b is too far that ctrl+a lol :D
118 2012-08-11T14:33:07 <xiaq> spy_: aha, but ^A is ocassionaly useful when you have a funny terminal where Home key doesn't work...
119 2012-08-11T14:40:17 <spy_> xiaq: thanks for new ideas to play with my droid one day :)
120 2012-08-11T14:43:51 <dreimark> spy_: xiaq bilal jaiditya prepare for meeting in 20 min :)
121 2012-08-11T14:44:01 <dreimark> sorry bilal
122 2012-08-11T14:44:06 <dreimark> breton: ^
123 2012-08-11T14:44:27 <dreimark> spy_: there is also connectbot for android
124 2012-08-11T14:44:42 <dreimark> works pretty good with screen ;)
125 2012-08-11T14:46:23 <dreimark> MaikuMori: if you are with us meeting starts in a quarter
126 2012-08-11T14:46:48 <spy_> dreimark: I use connectbot, but only for ssh stuff, not irc yet
127 2012-08-11T14:52:09 <dreimark> spy_: if you have irssi in screen running then it works perfect
128 2012-08-11T14:52:44 <dreimark> and if you want an account on the moin shell server send thomas a password protected pub key
129 2012-08-11T14:53:03 <dreimark> we offer this service to all moin developer
130 2012-08-11T14:53:21 *** spy
131 2012-08-11T14:54:17 <spy_> dreimark: hah, already sent yesterday :)
132 2012-08-11T14:54:56 <jaiditya> dreimark: resolved bug https://bitbucket.org/Jaiditya/moin-2.0/issue/45/subitems-with-no-index-item-should-not
133 2012-08-11T14:55:34 *** spy_
134 2012-08-11T14:56:16 <dreimark> jaiditya: me looks
135 2012-08-11T14:57:01 <spy> dreimark: btw, I have my own vps server in Germany where I do all the development and run irssi
136 2012-08-11T14:57:09 <dreimark> spy: :)
137 2012-08-11T14:59:23 <spy> who use vim for development, could you please suggest some useful extensions for it which you use.
138 2012-08-11T14:59:38 <spy> vim+python I mean
139 2012-08-11T14:59:49 <ThomasWaldmann> breton: are you here?
140 2012-08-11T15:00:26 * xiaq uses hardly any extension
141 2012-08-11T15:00:36 <xiaq> ah, except powerline for eye candy
142 2012-08-11T15:01:04 <ThomasWaldmann> ok, seems breton is late, xiaq can you begin?
143 2012-08-11T15:01:50 <xiaq> LAST: rich index EP, publishing ticket code (sorry delayed by the funny Internet here...)
144 2012-08-11T15:01:54 <xiaq> BLOCKER: none
145 2012-08-11T15:02:39 <ThomasWaldmann> there is still no way to create a ticket, right?
146 2012-08-11T15:02:40 <xiaq> NEXT: publish ticket code tomorrow, continue rich index
147 2012-08-11T15:03:06 <xiaq> ThomasWaldmann: http://z.tuna.tsinghua.edu.cn:8088/ here :)
148 2012-08-11T15:04:35 <ThomasWaldmann> ok, how about extracting the finished parts of what's visible there and committing them?
149 2012-08-11T15:04:52 <xiaq> ThomasWaldmann: sure, that was planned today...
150 2012-08-11T15:04:58 <dreimark> xiaq: what holds you back from pushing this
151 2012-08-11T15:04:59 <xiaq> i'll do this tomorrow.
152 2012-08-11T15:05:08 <breton> here
153 2012-08-11T15:05:20 <dreimark> ok, for me, just wanted to know the reason
154 2012-08-11T15:05:50 <xiaq> dreimark: where i temporaily live has a funny Internet connection that requires a Windows-only PPPoE client... they do some weird crypto so you can't just use Linux's general PPPoE dialer...
155 2012-08-11T15:06:16 <dreimark> ah, ok i remember you explained that already
156 2012-08-11T15:06:18 <ThomasWaldmann> hmm, submit doesn't work for ticket creation
157 2012-08-11T15:07:08 <ThomasWaldmann> but at least it looks promising :D
158 2012-08-11T15:07:49 <ThomasWaldmann> btw, when working on that index stuff, please also test the other places that use it
159 2012-08-11T15:08:10 <ThomasWaldmann> we are ok with changes for good, but don't break it
160 2012-08-11T15:08:15 <xiaq> ThomasWaldmann: sure
161 2012-08-11T15:09:34 <ThomasWaldmann> btw, suggested pencils down is coming soon, try to have all core functionality of your project committed until then
162 2012-08-11T15:09:50 <ThomasWaldmann> (that's a general note for all students)
163 2012-08-11T15:10:48 <ThomasWaldmann> it doesn't mean that you must be finished with it, but the time afterwards should be mostly fixes, cleanups, docs, etc. - not beginning completely new stuff
164 2012-08-11T15:10:59 <ThomasWaldmann> at least that is the idea ;)
165 2012-08-11T15:12:05 <ThomasWaldmann> ok, any questions for xiaq ?
166 2012-08-11T15:12:35 <dreimark> not now
167 2012-08-11T15:12:50 <waldi> no
168 2012-08-11T15:13:05 <ThomasWaldmann> btw about that commenting system stuff: the pretty much looks like such a totally new thing that was not really begun yet.
169 2012-08-11T15:13:32 <ThomasWaldmann> ok, thanks xiaq. spy, your stage. :)
170 2012-08-11T15:13:46 <spy> LAST: Published DateTimeUNIX widget, Blog/BlogEntry itemtype classes. Worked on new commenting system on EP.
171 2012-08-11T15:13:47 <dreimark> well noone should be held back to do also new stuff ;)
172 2012-08-11T15:13:49 <spy> BLOCKERS: none
173 2012-08-11T15:13:50 <spy> NEXT: There are several options either continue to work on the commenting system or work on +index view for blog management purposes (not preferred by me because xiaq is actively refactoring it now).
174 2012-08-11T15:14:45 <ThomasWaldmann> dreimark: it is just that having SOME stuff finished and in good state is preferable to beginning new stuff last-minute.
175 2012-08-11T15:15:10 <ThomasWaldmann> and have all stuff unfinished / unclean at the end
176 2012-08-11T15:15:12 <dreimark> I think continuing with commenting until index from xiaq is available then the priority should be to add blog there
177 2012-08-11T15:16:07 <ThomasWaldmann> spy: i tried to do a blog post with your code that is in main, but didn't manage to get it working
178 2012-08-11T15:16:09 <dreimark> and then continue with commenting
179 2012-08-11T15:16:40 <spy> ThomasWaldmann: what was the problem? Did you set "Publication time" on blog post?
180 2012-08-11T15:16:57 <ThomasWaldmann> i first tried without, then with
181 2012-08-11T15:17:12 <ThomasWaldmann> but it never showed up on main page
182 2012-08-11T15:17:22 <dreimark> i got it working but there is some delay to the time
183 2012-08-11T15:17:38 <ThomasWaldmann> is there some specific content expected to be on the main page, so it can work?
184 2012-08-11T15:17:55 <dreimark> no, just +blog/blogpage
185 2012-08-11T15:18:06 <spy> soon we will have "do_show" implementation on itemtype classes
186 2012-08-11T15:18:06 <ThomasWaldmann> spy: btw, i think you should preload the ptime metadata widget with the current datetime
187 2012-08-11T15:18:29 <spy> so I will move all these +blog/+blog_entry view to Blog and BlogEntry classes respectively
188 2012-08-11T15:18:48 <ThomasWaldmann> ah, ok, then i was at wrong url. explains a lot. ok, please put priority on that do_show stuff.
189 2012-08-11T15:19:04 <dreimark> spy: that is important
190 2012-08-11T15:19:08 <spy> xiaq: ^
191 2012-08-11T15:20:03 <dreimark> spy: is that also related to some of xiaq queues?
192 2012-08-11T15:20:27 <spy> is it ready to be commited? http://codereview.appspot.com/6457048/
193 2012-08-11T15:20:33 <ThomasWaldmann> and if ptime is required, better load something into it. maybe it could also get changed to be not required, so no PTIME just means it is published.
194 2012-08-11T15:20:59 <xiaq> spy: i'll commit, push and send pull req tomorrow (sorry for the delay)
195 2012-08-11T15:21:29 <spy> xiaq: ok
196 2012-08-11T15:21:43 <dreimark> ThomasWaldmann: spy that is already if you just add creation time to ptime too
197 2012-08-11T15:21:50 <dreimark> then one can change it
198 2012-08-11T15:22:01 <spy> ThomasWaldmann: maybe it better to add some js calendar sutff to PTIME widget now?
199 2012-08-11T15:22:06 <spy> to be more friendly
200 2012-08-11T15:22:16 <ThomasWaldmann> i think that can be done later
201 2012-08-11T15:22:28 <spy> well
202 2012-08-11T15:22:34 <dreimark> yeah
203 2012-08-11T15:22:43 <dreimark> if you you have now time
204 2012-08-11T15:22:47 <ThomasWaldmann> it likely would cost you a lot of time now and i think we first should see full basic functionality before adding comfort features.
205 2012-08-11T15:23:33 <spy> agreed, ok will polish PTIME a bit
206 2012-08-11T15:23:38 <dreimark> spy: is your changeset ready for doing the commit after push from xiaq ?
207 2012-08-11T15:23:59 <dreimark> with small changes may be?
208 2012-08-11T15:24:06 <spy> sure
209 2012-08-11T15:24:29 <dreimark> so we will have it tom too?
210 2012-08-11T15:24:50 <spy> what about global PTIME idea, will try to develop it now?
211 2012-08-11T15:25:02 <dreimark> xiaq: can you give a time for yours (not exactly)
212 2012-08-11T15:25:10 <ThomasWaldmann> btw, xiaq: that "add comment" headline with that indented "message" thing below it looks a bit strange. especially since the original ticket reporter does not see his original report as a "comment" or "message" usually.
213 2012-08-11T15:25:13 <spy> dreimark: I hope so
214 2012-08-11T15:26:02 <ThomasWaldmann> spy: if you have spare time, global ptime would be nice. but maybe first change it so it is optional.
215 2012-08-11T15:26:07 <xiaq> ThomasWaldmann: will fix that
216 2012-08-11T15:26:54 <ThomasWaldmann> spy: also, we are trying to avoid putting metadata that is basically saying nothing
217 2012-08-11T15:27:20 <ThomasWaldmann> e.g. if we do not want to store an IP address, there should be no such key/value rather than ADDR = ""
218 2012-08-11T15:27:49 <spy> is PTIME saying nothing?
219 2012-08-11T15:28:03 <ThomasWaldmann> same should be if you want to immediately publish, then maybe there should be no PTIME (IF(!) you can do it with whoosh or ACL that way)
220 2012-08-11T15:28:47 <ThomasWaldmann> and it likely should be ACL btw, whoosh is just hiding, but not really protecting it being view before ptime
221 2012-08-11T15:29:37 <ThomasWaldmann> (maybe we can even use both, not sure)
222 2012-08-11T15:30:09 <ThomasWaldmann> fsck, they play "bonanza" outside
223 2012-08-11T15:30:17 <dreimark> hä
224 2012-08-11T15:30:48 <ThomasWaldmann> (title music of some rather old western tv series)
225 2012-08-11T15:31:04 <xiaq> perhaps we can have "hard hiding" and "soft hiding"
226 2012-08-11T15:31:12 <ThomasWaldmann> ok, questions for/from spy?
227 2012-08-11T15:31:28 <spy> will add publish immediately functionality
228 2012-08-11T15:31:51 <ThomasWaldmann> xiaq: i think whoosh might be useful to just have less stuff to process, but the safety comes from protecting layer)
229 2012-08-11T15:32:32 <xiaq> spy: consider "publish" and "save draft" buttons in BlogEntry's ModifyForm. :)
230 2012-08-11T15:32:57 <xiaq> ThomasWaldmann: yeah, i mean to give the user a choice whether to impose ACL or not
231 2012-08-11T15:33:14 <ThomasWaldmann> jaiditya: breton: MaikuMori: are you here?
232 2012-08-11T15:33:20 <jaiditya> LAST: Worked on resolving bugs,removed template duplication, and implementation of CSS3PIE and very little on documentation (working on it)
233 2012-08-11T15:33:21 <jaiditya> BLOCKER: None
234 2012-08-11T15:33:21 <jaiditya> NEXT: Documentation, ContentEditable for text/html, CSS3PIE implementation and bugs resolving (also have to look on styling of blog pages)
235 2012-08-11T15:33:31 <dreimark> that was tooo fast
236 2012-08-11T15:33:35 <dreimark> but ok
237 2012-08-11T15:33:45 <ThomasWaldmann> heh, that was a bit more than i expected, but ok, jaiditya is next :)
238 2012-08-11T15:34:13 <ThomasWaldmann> trigger happy with copy&paste :)
239 2012-08-11T15:34:15 <jaiditya> was waiting since the meeting begun
240 2012-08-11T15:34:48 <ThomasWaldmann> (thanks spy :)
241 2012-08-11T15:34:55 * breton here
242 2012-08-11T15:35:03 <ThomasWaldmann> spy: we can talk later about acl, if you like
243 2012-08-11T15:35:06 <dreimark> breton: you are next after jaiditya
244 2012-08-11T15:35:18 <spy> ThomasWaldmann: okay
245 2012-08-11T15:35:38 <ThomasWaldmann> jaiditya: one thing that jumped into my face recently is that file upload field on modify view
246 2012-08-11T15:36:04 <dreimark> jaiditya: have you already that index deduplicated ?
247 2012-08-11T15:36:26 <ThomasWaldmann> there is a filename text field and right of it a button. the style of that text field looks different than other text input fields, can you fix that? (there is some shadow not present in other fields)
248 2012-08-11T15:37:19 <jaiditya> dreimark: do you mean index template ?
249 2012-08-11T15:37:25 <ThomasWaldmann> about index work: be careful, working at multiple places on same feature might give merge conflicts/double work
250 2012-08-11T15:37:42 <dreimark> jaiditya: yes
251 2012-08-11T15:37:49 <jaiditya> yes
252 2012-08-11T15:38:07 <jaiditya> I have send a pull request with those changes
253 2012-08-11T15:38:12 <dreimark> ok
254 2012-08-11T15:38:32 <jaiditya> ThomasWaldmann: yes I didn't noticed that
255 2012-08-11T15:38:40 <jaiditya> I'll do that
256 2012-08-11T15:38:54 <dreimark> but now there are less files where you can miss to change something
257 2012-08-11T15:39:26 <jaiditya> yes, just 6 templates in foobar template folder
258 2012-08-11T15:39:43 <dreimark> jaiditya: there should also an anchor in the modify view to jump to metadata editor
259 2012-08-11T15:40:23 <dreimark> that would also cont as hint to a user because he could completly miss the bottom area
260 2012-08-11T15:40:31 <dreimark> s/cont/count/
261 2012-08-11T15:40:37 <ThomasWaldmann> dreimark: hm? the metadata editor is right below the other editor currently, right?
262 2012-08-11T15:40:49 <dreimark> you have to scroll down
263 2012-08-11T15:41:03 <dreimark> on my screen I can't see it in foobar
264 2012-08-11T15:41:35 <xiaq> what about putting the "submit" button below metadata editor so that the user *has* to scroll down? :-P
265 2012-08-11T15:41:50 <jaiditya> yeah I understand that, will think about how to improve that
266 2012-08-11T15:41:57 <dreimark> and the comment also
267 2012-08-11T15:42:01 <dreimark> because it is meta
268 2012-08-11T15:42:08 <waldi> xiaq: optimizing the special vs. common case
269 2012-08-11T15:42:17 <ThomasWaldmann> xiaq: i think we had that in the far past and finally put it at the top
270 2012-08-11T15:42:41 <dreimark> so the common stuff should go on top
271 2012-08-11T15:43:10 <dreimark> or a better idea
272 2012-08-11T15:43:58 <ThomasWaldmann> https://bitbucket.org/Jaiditya/moin-2.0/issue/46/textcha-styling this is a rather old issue. is it unclear or why is it still open?
273 2012-08-11T15:45:07 <ThomasWaldmann> https://bitbucket.org/Jaiditya/moin-2.0/issue/39/hide-admin-for-non-admin same question
274 2012-08-11T15:46:02 <jaiditya> ThomasWaldmann: textcha are included from a macro so will have to change modify template for changing it and I thought I should first deal with template duplication
275 2012-08-11T15:46:40 <ThomasWaldmann> ok, was just wondering
276 2012-08-11T15:46:54 <dreimark> jaiditya: yes, bug fixing is in NEXT
277 2012-08-11T15:47:32 <ThomasWaldmann> jaiditya: did you file that stylus issues to stylus tracker btw?
278 2012-08-11T15:47:38 <ThomasWaldmann> -s
279 2012-08-11T15:48:09 <ThomasWaldmann> (i think i have that seen working in the past, so it might be a recent regression in stylus)
280 2012-08-11T15:49:09 <ThomasWaldmann> jaiditya: you could also try using some newer/older version of stylus whether it is maybe fixed already / not broken in an older version
281 2012-08-11T15:49:09 <jaiditya> RogerHasse asked me to first file it to moin tracker and then afterwards to stylus tracker
282 2012-08-11T15:49:30 <ThomasWaldmann> well, i verified it and also did not see reset.css stuff in output
283 2012-08-11T15:50:23 <ThomasWaldmann> ok, any more questions for/from jaiditya?
284 2012-08-11T15:50:28 <jaiditya> I try finding the reason but its strange as some files are imported and some are not
285 2012-08-11T15:50:40 <ThomasWaldmann> jaiditya: exactly
286 2012-08-11T15:51:36 <ThomasWaldmann> ok, thanks jaiditya, breton, your stage.
287 2012-08-11T15:52:39 <breton> LAST: search, history, fixes to ui.
288 2012-08-11T15:52:39 <breton> BLOCKER: None
289 2012-08-11T15:52:39 <breton> NEXT: Polish branches - tests, fixing issues from previous cr (1d). I don't know whether it's too late to do merging, but I think that I might do it (being in the regimen like I was last week).
290 2012-08-11T15:52:43 <breton> Also, uploaded new code to http://codereview.appspot.com/6459066/ and replied comments there.
291 2012-08-11T15:52:46 <breton> Also, I need to decide where to show notifications that a user is not on his userhead; I think I should discuss it with jaiditya.
292 2012-08-11T15:53:24 <ThomasWaldmann> breton: when looking at your latest codereview i somehow thought you should try to do stuff in smaller work units somehow. you implemented quite a lot of stuff, but it is likely not finished (missing tests, bugs, etc.). so implementing less, but with tests, less bugs might be better.
293 2012-08-11T15:54:10 <breton> everything I implemented was pratically tested and right now I am writing tests for it.
294 2012-08-11T15:54:29 <dreimark> patch set 5 has some tests
295 2012-08-11T15:54:55 <ThomasWaldmann> about merging: that's difficult topic. maybe carefully TRY. if you feel it is complicated enough so it would make you lose lots of time, then delay it until after soc.
296 2012-08-11T15:55:58 <ThomasWaldmann> (smaller work units might also fix issues like "no commit since 22d")
297 2012-08-11T15:56:00 <dreimark> breton: try to cover most changes with your test
298 2012-08-11T15:56:50 <ThomasWaldmann> (which is rather risky anyway, as you could lose quite some stuff due to hw/sw issues)
299 2012-08-11T15:57:20 <ThomasWaldmann> breton: did you read my comments about that pre-fork revisions?
300 2012-08-11T15:59:00 <breton> ThomasWaldmann: I have. But that part is pretty complex and I will not implement that type of search now. It is not listed on ep://moin2-bms, just a little attempt from me. I will either comment or remove that part.
301 2012-08-11T16:00:03 <ThomasWaldmann> well, as i said there, it might not make sense anyway as we do not know which branch the pre-fork stuff was back then
302 2012-08-11T16:00:40 <breton> I have some thoughts about that, but, complex.
303 2012-08-11T16:00:42 <ThomasWaldmann> so that feature would be rather unpredicably good or bad
304 2012-08-11T16:00:51 <ThomasWaldmann> +t
305 2012-08-11T16:01:52 <ThomasWaldmann> breton: is there currently anything to test practically or by unit tests or still all broken?
306 2012-08-11T16:04:08 <breton> feeds something else is completelly broken, everything else can be practcally tested. Just pushed to the repo.
307 2012-08-11T16:04:28 <breton> *feeds and
308 2012-08-11T16:04:52 <ThomasWaldmann> 2d left until soft pencils down, 9d until firm pencils down, use them wisely
309 2012-08-11T16:06:16 <ThomasWaldmann> btw, as a general comment for all students: you must be available at least until August 24 19:00 UTC (this is the final eval deadline)
310 2012-08-11T16:06:53 <ThomasWaldmann> breton: ok, i'll do some experiments with your repo code.
311 2012-08-11T16:07:43 * dreimark has to go soon
312 2012-08-11T16:07:44 <ThomasWaldmann> breton: ehrm, i maybe was misunderstanding "I don't know whether it's too late to do merging, but I think that I might do it (being in the regimen like I was last week).
313 2012-08-11T16:07:47 <ThomasWaldmann> "
314 2012-08-11T16:08:13 <ThomasWaldmann> did you mean merging of moin-wiki branches or merging code of main repo into your repo?
315 2012-08-11T16:08:26 <breton> merging of moin-wiki branches
316 2012-08-11T16:08:45 <ThomasWaldmann> ah, ok, i was talking about repo merge :)
317 2012-08-11T16:09:17 <ThomasWaldmann> ok, as i said, only begin new stuff if the old stuff is working and in good shape.
318 2012-08-11T16:09:36 <ThomasWaldmann> ok, anything else for/from breton?
319 2012-08-11T16:09:52 <ThomasWaldmann> MaikuMori: are you with us?
320 2012-08-11T16:09:54 <dreimark> not now, i am looking later on the repo too
321 2012-08-11T16:10:54 <ThomasWaldmann> in case there is no reply from maikumori: he told me he is having some private issues currently and he may or may not be able to work on SOC. Details are known to moin admins and his mentor.
322 2012-08-11T16:12:18 <ThomasWaldmann> ok, seems he is not here, so it looks like we are through with the meeting. thanks to everybody attending it.
323 2012-08-11T16:13:06 * ThomasWaldmann needs to make a short break of ~15 mins, but I am likely available afterwards.
324 2012-08-11T16:14:33 <ThomasWaldmann> breton: ah, you just forgot to push
325 2012-08-11T16:14:51 * ThomasWaldmann seeing some recent changesets now in public repo
326 2012-08-11T16:15:35 *** jaiditya
327 2012-08-11T16:16:45 *** jaiditya
328 2012-08-11T16:17:44 <dreimark> bbl
329 2012-08-11T16:20:07 * breton going to sleep for the next 9h
330 2012-08-11T16:23:42 <xiaq> hm, storage item creation seems pretty slow
331 2012-08-11T16:23:55 * xiaq is running a script to create 10000 items
332 2012-08-11T16:24:08 <xiaq> it is basically:
333 2012-08-11T16:24:14 <xiaq> for i in xrange(10000):
334 2012-08-11T16:24:46 <xiaq> item = Item.create(
335 2012-08-11T16:24:52 <xiaq> # no...
336 2012-08-11T16:25:14 <xiaq> item = Item.create('mua' + str(i), u'default', u'text/x.moin.wiki')
337 2012-08-11T16:25:25 <xiaq> item._save(item.meta, '', item.name)
338 2012-08-11T16:26:31 * xiaq scrolling back console and counting time
339 2012-08-11T16:27:00 <xiaq> mua2000 happened at 22:24:19,724
340 2012-08-11T16:27:36 <xiaq> mua0 at 22:20:30,216
341 2012-08-11T16:28:11 <xiaq> that's roughly 250s for 2000 items...
342 2012-08-11T16:28:32 <xiaq> 125ms for one item
343 2012-08-11T16:29:10 * xiaq thought creating 10000 items would just go "whoosh!" :)
344 2012-08-11T16:29:40 <xiaq> no, it's getting slower and slower...
345 2012-08-11T16:31:19 <xiaq> 2000 items are enough to get me a slow +index view. that way i can see whether it will get faster by doing filtering with whoosh. - ah i think should create another 2000 items with different itemtype...
346 2012-08-11T16:33:29 <xiaq> also, plz comment about http://etherpad.osuosl.org/moin-rich-index line 112 and below
347 2012-08-11T16:33:33 <xiaq> ThomasWaldmann: ^
348 2012-08-11T16:33:35 <xiaq> spy: ^
349 2012-08-11T16:33:37 <xiaq> dreimark: ^
350 2012-08-11T16:34:20 <xiaq> hm, this is unfair for dreimark since he has to iterate twice to get my original message :) i'll reverse the order next time.
351 2012-08-11T16:34:57 * xiaq is going to bed early tonight because i have to catch an early bus tomorrow to escape from here :D
352 2012-08-11T16:35:27 <xiaq> gn :)
353 2012-08-11T16:37:19 <ThomasWaldmann> gn xiaq
354 2012-08-11T16:39:15 <ThomasWaldmann> xiaq: well, you have to consider that it does not only need to store 2 files to disk (meta and data), but also needs to update the index.
355 2012-08-11T16:39:43 <ThomasWaldmann> but i agree, 125ms seems a bit slow
356 2012-08-11T16:41:16 <ThomasWaldmann> (or, to be more precise: it currently needs to update 2 indexes: all_revs and latest_revs)
357 2012-08-11T16:45:10 <ThomasWaldmann> but we have to consider: that is a rather unrealistic benchmark. putting in thousands of items likely only happens on restore from a backup. much more important is fast access for finding, selecting, listing, accessing items.
358 2012-08-11T17:09:41 <MaikuMori> I'm back home
359 2012-08-11T17:09:50 <MaikuMori> Can work tomorrow and maybe tonight.
360 2012-08-11T17:10:02 <MaikuMori> ThomasWaldmann: ^^
361 2012-08-11T17:15:29 <ThomasWaldmann> ah, welcome back :)
362 2012-08-11T17:16:31 <ThomasWaldmann> eSyr-ng: ^
363 2012-08-11T17:16:35 <ThomasWaldmann> eSyr:
364 2012-08-11T17:21:47 <ThomasWaldmann> MaikuMori: did you any work in the last week?
365 2012-08-11T17:22:32 <ThomasWaldmann> *in the last 8 days
366 2012-08-11T17:22:57 <MaikuMori> In last 8 yes, but not since monday.
367 2012-08-11T17:23:32 <ThomasWaldmann> ok, just check if your diary is uptodate
368 2012-08-11T17:23:35 <MaikuMori> Takeing shower and doing some other stuff now sine I arrived ~15mins ago.
369 2012-08-11T19:00:14 <dreimark> gn xiaq
370 2012-08-11T19:07:23 *** RogerHaase
371 2012-08-11T19:10:26 <dreimark> wb maikumori
372 2012-08-11T20:21:52 <ThomasWaldmann> jaiditya: can you comment on the template changes?
373 2012-08-11T20:23:18 <ThomasWaldmann> i am wondering why everything extends from show.html now (was: layout), except history, which changed from show to layout
374 2012-08-11T20:50:46 <dreimark> bbl
375 2012-08-11T20:50:46 <jaiditya> ThomasWaldmann: In the current structure of foobar theme there are two layouts one with local panel(show.html) and other without local panel(layout.html)
376 2012-08-11T20:52:32 <jaiditya> so most of the templates which are deleted were differing in the parent template i.e. they were extended from local.html
377 2012-08-11T20:53:16 <jaiditya> and main templates are extended from layout.html
378 2012-08-11T20:54:52 <jaiditya> so in order to bring it to same ground now those template which need a local panel are extended from show.html
379 2012-08-11T20:55:21 <jaiditya> and those which do not need a local panel are extended from layout.html
380 2012-08-11T20:56:29 <jaiditya> and to make it uniform throughout I did the same in main templates only difference there is both layout.html and show.html have same layout
381 2012-08-11T21:03:31 <ThomasWaldmann> so it looks like most needs a local panel now?
382 2012-08-11T21:03:47 <ThomasWaldmann> because most changed from layout to show?
383 2012-08-11T21:04:43 <jaiditya> yes
384 2012-08-11T21:05:27 <jaiditya> not most
385 2012-08-11T21:05:51 <jaiditya> I have just changed it for modify templates
386 2012-08-11T21:07:58 <jaiditya> you might be looking at templates of main template folder
387 2012-08-11T21:08:42 <jaiditya> If you look at deleted templates most of them were extended from local.html already
388 2012-08-11T21:10:29 <jaiditya> so if I had to remove them I should have a fallback template which point towards the template with local panel which in this case is show.html
389 2012-08-11T21:12:07 <jaiditya> and for modernized theme its not much difference wether we extend from layout.html or show.html
390 2012-08-11T21:12:57 <ThomasWaldmann> ok
391 2012-08-11T21:15:10 <jaiditya> so should I send a pull request now or later after resolving few bugs which have been reported today ?
392 2012-08-11T21:16:05 <ThomasWaldmann> i am pulling it right now
393 2012-08-11T21:16:32 <jaiditya> ok
394 2012-08-11T21:16:56 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1655:7ad66866b569 2.0/MoinMoin/ (5 files in 3 dirs): merged
395 2012-08-11T21:16:58 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1657:4ea7d844dcc5 2.0/MoinMoin/themes/modernized/static/css/ (common.css stylus/main.styl): Modernized theme itemviews border removed
396 2012-08-11T21:17:04 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1658:b58ef72e64e6 2.0/MoinMoin/themes/modernized/static/css/ (common.css stylus/main.styl): Foobar theme search field width changed
397 2012-08-11T21:17:07 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1661:ad8995d32748 2.0/MoinMoin/themes/foobar/templates/index.html: Foobar theme Item-index-page non-functional actions removed
398 2012-08-11T21:17:08 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1659:d7ba0ca0b4bb 2.0/MoinMoin/ (3 files in 2 dirs): merged
399 2012-08-11T21:17:09 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1656:84931b7c154f 2.0/MoinMoin/themes/foobar/templates/index.html: Foobar theme fix for index page actions
400 2012-08-11T21:17:11 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1660:9b133a70c982 2.0/MoinMoin/templates/index.html: Item-index-page non-functional actions removed
401 2012-08-11T21:17:15 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1654:5acaea38f1a2 2.0/MoinMoin/ (29 files in 2 dirs): Duplicate templates removed from foobar
402 2012-08-11T21:49:43 <ThomasWaldmann> jaiditya: search query field in modernized is hanging out of containing element to the right
403 2012-08-11T21:51:13 <ThomasWaldmann> jaiditya: history view is losing the navibar in modernized
404 2012-08-11T21:53:09 <ThomasWaldmann> input field labels are touching the field (e.g. Item type, Content type, Summary, Tags) in modernized
405 2012-08-11T21:56:25 <ThomasWaldmann> and maybe there should be also a little more vertical space between the bottom of the lower navibar and the text below it. the first line there is almost touching the navibar, but the next line has a quite bigger distance to the first lnie.
406 2012-08-11T21:56:53 <jaiditya> ThomasWaldmann: a snapshot of home page
407 2012-08-11T21:58:51 <ThomasWaldmann> hm?
408 2012-08-11T22:01:56 * ThomasWaldmann uses firefox in case that matters, should be easy to reproduce
409 2012-08-11T22:02:06 <jaiditya> ahh..got it
410 2012-08-11T22:02:28 <jaiditya> fixing \
411 2012-08-11T22:02:37 <ThomasWaldmann> there is also still the issue of the empty subitems panel (at least in foobar)
412 2012-08-11T22:05:18 <jaiditya> sorry,I think I'll look at all the issues tommorow morning feeling tired today
413 2012-08-11T22:06:34 <ThomasWaldmann> ok, gn
414 2012-08-11T22:07:43 <jaiditya> gn
415 2012-08-11T22:58:52 <breton> xiaq: don't worry about the speed, with branches it is MUCH slower now.
416 2012-08-11T22:59:19 <ThomasWaldmann> :P
417 2012-08-11T22:59:53 <ThomasWaldmann> breton: did you do comparable measurements?
418 2012-08-11T23:01:32 <breton> ThomasWaldmann: no. But theoratically it will be ~twice slower.
419 2012-08-11T23:01:47 <breton> also, seeing bugreports now.
420 2012-08-11T23:03:40 <breton> *theoretically
421 2012-08-11T23:12:32 *** jaiditya
422 2012-08-11T23:30:43 <dreimark> re
423 2012-08-11T23:59:16 *** RogerHaase
424
