1 2012-07-06T00:06:54 *** RogerHaase
2 2012-07-06T00:11:49 *** MattMaker
3 2012-07-06T00:18:11 *** MattMaker
4 2012-07-06T00:30:48 *** MattMaker
5 2012-07-06T00:31:52 *** MattMaker
6 2012-07-06T00:34:29 *** Trip_
7 2012-07-06T00:36:18 *** MattMaker
8 2012-07-06T00:41:58 *** MattMaker
9 2012-07-06T00:42:18 *** Trip_
10 2012-07-06T00:46:57 <MaikuMori> Whoop, got theme plugins working
11 2012-07-06T00:47:34 <MaikuMori> Still need a lot of polish since I implemented them so that I don't have to change too much core code, but they work.
12 2012-07-06T01:32:13 <MaikuMori> And all test now pass, just need to add more of my own.
13 2012-07-06T01:33:39 *** spy
14 2012-07-06T01:53:42 <MaikuMori> ThomasWaldmann: esyr: http://codereview.appspot.com/6344080/ and also http://etherpad.osuosl.org/moin2-PluginSystem-thoughts Lines 45+
15 2012-07-06T02:44:39 *** MattMaker
16 2012-07-06T05:17:34 *** franklin_
17 2012-07-06T05:18:48 *** franklin_
18 2012-07-06T06:10:12 *** jaiditya
19 2012-07-06T08:19:16 *** jaiditya
20 2012-07-06T09:06:22 <jaiditya> ThomasWaldmann: Except "Index", "Referrers", "Site Map" and "Similar" all itemview's links has been changed
21 2012-07-06T09:25:42 *** kanha
22 2012-07-06T09:45:09 <dreimark> moin
23 2012-07-06T09:45:18 <dreimark> MaikuMori: :)
24 2012-07-06T09:53:50 <MaikuMori> dreimark: moin
25 2012-07-06T10:07:34 *** spy
26 2012-07-06T10:14:12 <spy> xiaq: Hi, are you working on the metadata editor for your +ticket view?
27 2012-07-06T10:19:28 <spy> there is a problem similar to render-method problem. We should use different ModifyForm if an item is used as a ticket or blog entry.
28 2012-07-06T10:44:31 <MaikuMori> ThomasWaldmann: I would like to have a chat with you about the plugins and also GSoC.
29 2012-07-06T10:48:27 <ThomasWaldmann> hi MaikuMori
30 2012-07-06T10:48:31 <MaikuMori> Hey
31 2012-07-06T10:48:45 <ThomasWaldmann> i have some minutes right now, until next talk begins
32 2012-07-06T10:48:53 <MaikuMori> Have you look at my recent changeset
33 2012-07-06T10:48:58 <MaikuMori> it's a bit big
34 2012-07-06T10:49:03 <ThomasWaldmann> url?
35 2012-07-06T10:49:14 <MaikuMori> [02:53:40] <MaikuMori> ThomasWaldmann: esyr: http://codereview.appspot.com/6344080/ and also http://etherpad.osuosl.org/moin2-PluginSystem-thoughts Lines 45+
36 2012-07-06T10:49:31 <MaikuMori> Also private chat.
37 2012-07-06T10:57:56 <ThomasWaldmann> MaikuMori: btw, i asked in the flask talk about who is using flask-themes. nobody said "yes".
38 2012-07-06T10:59:11 <MaikuMori> Parts of the code are very similar/based on flask-themes to minimize rewriting which needs to be done.
39 2012-07-06T11:00:00 <MaikuMori> Also is there a problem with user loging/setting in the current repo code? I can login and properly access user settings for a while now.
40 2012-07-06T11:01:51 <MaikuMori> I'm quite sure themes still need work, but right now I'm quite happy everything works without flask-themes
41 2012-07-06T11:06:38 <MaikuMori> Right now I'm thinking about maybe adding storages as plugins which will probably mean I'll have to improve the plugin code which right now is very thin and could use some helper fuctions and better designed way of handling the plugin collection.
42 2012-07-06T11:11:01 <MaikuMori> ThomasWaldmann: added a comment to codereview, didn't notice something yesterday
43 2012-07-06T11:12:53 <ThomasWaldmann> ok, i need to interrupt review for next talk, cul8er.
44 2012-07-06T11:13:35 *** greg_f
45 2012-07-06T11:14:35 <MaikuMori> Alright, I might make a new changeset, there is some dead code which I didn't notice before.
46 2012-07-06T11:57:50 * dreimark looks currently on visual implemented unit tests
47 2012-07-06T12:00:29 <dreimark> in larch
48 2012-07-06T12:01:33 <dreimark> https://sites.google.com/site/larchenv/
49 2012-07-06T12:34:34 <dreimark> we maybe can use openpyxl for indexing of excel files
50 2012-07-06T12:44:59 <xiaq> spy: yes
51 2012-07-06T12:45:31 <xiaq> spy: i'll be updating my patch queue repo tonight (+8 tz) and you can have a look if you are interested
52 2012-07-06T12:52:50 * xiaq sent pull request to ThomasWaldmann, hoping to get the Flatland widgets patch set merged
53 2012-07-06T12:54:18 <spy> xiaq: I've looked at your forms refactoring
54 2012-07-06T12:55:28 <spy> xiaq: how are you planning to deal with ModifyForms? They depend on view_method meta key as we suppose to use it.
55 2012-07-06T12:58:58 <ThomasWaldmann> MaikuMori: review done
56 2012-07-06T12:59:00 <xiaq> spy: use a different ModifyForm for +ticket :)
57 2012-07-06T12:59:22 <MaikuMori> ThomasWaldmann: almost done with updated version, the one you have had several huge bugs
58 2012-07-06T12:59:34 <MaikuMori> also there are some problems with users
59 2012-07-06T12:59:57 <ThomasWaldmann> jaiditya: Except "Index", "Referrers", "Site Map" and "Similar" all itemview's links has been changed
60 2012-07-06T13:00:01 <ThomasWaldmann> why not these?
61 2012-07-06T13:00:06 <MaikuMori> Tried to test theme listing, but could loging and it throws exception when I try to register new account
62 2012-07-06T13:00:15 <MaikuMori> couldn't*
63 2012-07-06T13:01:46 <ThomasWaldmann> MaikuMori: jinja2 get_or_select_templates < mitsuhiko recommended that for theming
64 2012-07-06T13:04:20 <ThomasWaldmann> MaikuMori: please also fix everything i mentioned before putting up next patch to review
65 2012-07-06T13:05:25 <MaikuMori> yep going trough it right now
66 2012-07-06T13:05:49 <MaikuMori> The new code has something which potentialy fixed the long default theme name
67 2012-07-06T13:06:16 <MaikuMori> it would still be in uppercase though, any reason why not use uppercase?
68 2012-07-06T13:12:00 <ThomasWaldmann> ok, lunch :)
69 2012-07-06T13:12:49 <ThomasWaldmann> MaikuMori: well, having all lowercase is easier than having the user to remember that it is "Modernized" (and not modernized or ModernIzed)
70 2012-07-06T13:12:59 <ThomasWaldmann> bbl
71 2012-07-06T13:14:44 <spy> xiaq: don't sure about +ticket, but +blog_entry could be a Moin markup item or an Html markup item. There is a WYSIWYG on an Html modify view. So I can't specify only one modify template for a blog_entry.
72 2012-07-06T13:15:31 *** MattMaker
73 2012-07-06T13:28:29 <spy> xiaq: maybe we should somehow include various widget sets into modify templates? This sets would be defined by the item's view_method value.
74 2012-07-06T13:31:20 <xiaq> spy: hm, the WYSIWYG will be merged into +modify, i suppose?
75 2012-07-06T13:38:32 <spy> xiaq: so, where will you implement ModifyForm for ticket? There is a long sequence of inherited ModifyForms Base -> Binary -> Text
76 2012-07-06T13:39:51 <xiaq> spy: it's outside Items, in the +ticket view handler which doesn't call .do_modify at all
77 2012-07-06T13:47:35 * xiaq feels it's maybe appropriate to give items.Text some special "dignity" since the ticket, blog and pastebin project all need to deal with some Text item
78 2012-07-06T13:47:50 * xiaq looks at DOM stuff
79 2012-07-06T13:48:41 *** eSyr-ng
80 2012-07-06T14:01:12 <spy> xiaq: I saw you use +ticket view both for ticket data representation and meta modification (such as summary, effort, difficuly, ...). But in my case I want to modify metadata only on +modify view. According to item's view_method JSON textarea should be replaced by appripriate widgets. Am I wrong?
81 2012-07-06T14:03:41 <spy> every blog entry is just an ordinary wiki item but with some more specific metakeys
82 2012-07-06T14:05:40 <spy> xiaq: I need some advice on it since you worked a lot on forms
83 2012-07-06T14:07:51 <spy> a blog entry could be even an audio item, so there is no textarea field
84 2012-07-06T14:09:33 <spy> It seems there could not be a common modify template for all items
85 2012-07-06T14:24:10 *** MattMaker
86 2012-07-06T14:26:12 <xiaq> spy: can i take it for that you need to mix some blog-specific things into virtually all types of items (ie. not just Texts)?
87 2012-07-06T14:28:46 <xiaq> spy: i don't have need for that - ticket items are always text items. which is why i'm not talking much about render-method or meta-schema things i brought up, it doesn't block me now :)
88 2012-07-06T14:30:11 <xiaq> spy: seems your blog project will reveal more about this problem
89 2012-07-06T14:30:24 <spy> xiaq: ok, suppose it is always text, but there are a lot of text types (markup, plain, patches)
90 2012-07-06T14:31:31 <spy> xiaq: I don't want to concentrate on an item type, but rather on a metadata
91 2012-07-06T14:32:20 <xiaq> spy: same metadata editor for different item types, you mean?
92 2012-07-06T14:32:58 <spy> modify properties should correspond to how this item is used
93 2012-07-06T14:33:29 <spy> xiaq: yes
94 2012-07-06T14:35:29 <spy> it's better to hear our mentor's thought on this approach
95 2012-07-06T14:35:38 <spy> ThomasWaldmann: dreimark: ^^
96 2012-07-06T14:36:07 * xiaq revisits http://etherpad.osuosl.org/moin-render-method
97 2012-07-06T14:38:43 <xiaq> (not related to the question spy's talking about) can i store a DOM directly, or do i always have to convert it into some markup (using such converters as converter/moinwiki_out.py) in order to store it?
98 2012-07-06T14:59:20 *** dave_largo
99 2012-07-06T15:06:01 <dreimark> spy: i'm in a talk I read later backlog
100 2012-07-06T15:06:16 <dreimark> xiaq: you can look at serialize
101 2012-07-06T15:06:19 <spy> dreimark: I know, ok
102 2012-07-06T15:20:06 <MaikuMori> ThomasWaldmann: esyr: http://codereview.appspot.com/6344080
103 2012-07-06T15:20:24 <MaikuMori> Also: http://etherpad.osuosl.org/moin2-PluginSystem-thoughts
104 2012-07-06T15:21:29 <MaikuMori> it has most of the suggestions, I still need to research that jinja method you mentioned and I'll work on the plugin lookup by type and (maybe) short idetificator a bit later when I have more plugins.
105 2012-07-06T15:23:24 <ThomasWaldmann> xiaq: why would you want to store dom directly?
106 2012-07-06T15:30:35 *** RogerHaase
107 2012-07-06T16:11:42 <MaikuMori> This hit the top of hackernews: https://speakerdeck.com/u/mitsuhiko/p/advanced-flask-patterns
108 2012-07-06T16:30:45 <xiaq> ThomasWaldmann: just asking whether it is common or to be avoided
109 2012-07-06T17:14:40 <ThomasWaldmann> avoided means that you have something in dom-tree-format, so how do you get that?
110 2012-07-06T18:04:06 *** dwcramer
111 2012-07-06T18:12:15 *** franklin_
112 2012-07-06T18:23:01 <ThomasWaldmann> http://moinmo.in/MoinMoinTalks/EuroPython-2012-07-06
113 2012-07-06T18:24:15 <spy> ThomasWaldmann: Have you already made a talk?
114 2012-07-06T18:25:44 <spy> ThomasWaldmann: dreimark: http://codereview.appspot.com/6356070 this is a dirty sketch that shows you how I see the metadata editor.
115 2012-07-06T18:27:12 *** jaiditya
116 2012-07-06T18:27:32 *** jaiditya
117 2012-07-06T18:40:22 <jaiditya> ThomasWaldmann: "Index", "Referrers", "Site Map" and "Similar" these links are used just to check if any so one would like to know if he had already checked the referrers or similar . So I think visited link should have a different color
118 2012-07-06T19:00:37 *** dwcramer
119 2012-07-06T19:15:34 *** greg_f
120 2012-07-06T19:28:38 *** dwcramer
121 2012-07-06T19:42:02 *** dwcramer
122 2012-07-06T20:07:24 *** jaiditya
123 2012-07-06T20:18:01 *** jaiditya|2
124 2012-07-06T20:20:44 *** jaiditya|2
125 2012-07-06T21:40:49 <ThomasWaldmann> http://moinmo.in/4ct10n/AttachFile/MoinMoinTalks/EuroPython-2012-07-06?action=AttachFile < whoosh and moin2 lightning talks from EP
126 2012-07-06T21:43:38 <ThomasWaldmann> spy: those were just "5 minutes" lightning talks, no big talk
127 2012-07-06T21:49:58 <spy> ThomasWaldmann: I saw your talk about tomorrow's sprint
128 2012-07-06T21:51:52 <spy> ThomasWaldmann: what are you plans about the sprint?
129 2012-07-06T21:55:14 *** franklin_
130 2012-07-06T21:56:32 <ThomasWaldmann> spy: the announcement was rather short as i was having the lightning talk just 10 mins before and already had pointed to the sprints within that
131 2012-07-06T21:57:25 <ThomasWaldmann> and one can't make very specific plans if the participants (interests and capabilities) are unknown
132 2012-07-06T22:00:46 <spy> ThomasWaldmann: that's true. If your will have free time, could you please look at my cr changesets. http://codereview.appspot.com/6307082/ still one question remains. Some new ideas: http://codereview.appspot.com/6356070/
133 2012-07-06T22:03:13 <ThomasWaldmann> i am currently looking at sth else, but if i don't fall asleep before maybe after that :)
134 2012-07-06T22:04:38 <spy> ThomasWaldmann: okay, thank you
135 2012-07-06T22:06:18 <spy> so, what about the meeting tomorrow?
136 2012-07-06T22:07:46 <jaiditya> ThomasWaldmann: "Index", "Referrers", "Site Map" and "Similar" these links are used just to check if any so one would like to know if he had already checked the referrers or similar . So I think visited link should have a different color
137 2012-07-06T22:14:02 <ThomasWaldmann> spy: i will try to be there, but in case i am not, someone else will have to lead it.
138 2012-07-06T22:14:34 <ThomasWaldmann> dreimark is on a flight at that time, so only waldi and esyr are left.
139 2012-07-06T22:15:19 <ThomasWaldmann> jaiditya: you can say the same for all other actions
140 2012-07-06T22:15:55 <ThomasWaldmann> except destroy maybe :D
141 2012-07-06T22:16:15 <jaiditya> ahh...then what would you suggest
142 2012-07-06T22:17:17 <ThomasWaldmann> don't use different colors except in content or other places where you'ld want to visit one-after-the-other / all links
143 2012-07-06T22:18:32 <jaiditya> not even in Links and Trail ?
144 2012-07-06T22:19:38 <ThomasWaldmann> well, in trail you obviously visited them (otherwise they would not be in trail), so it is useless there also
145 2012-07-06T22:20:38 *** MattMaker
146 2012-07-06T22:20:48 <ThomasWaldmann> in links it would make a little bit sense, but the question is if it is useful enough there to rectify it being a little uglier than if using same colour
147 2012-07-06T22:22:51 <jaiditya> sorry can you please rephrase the last line
148 2012-07-06T22:25:44 <ThomasWaldmann> what's better: a) little uglier but seeing which Links were visited b) less ugly and not seeing which Links were visited
149 2012-07-06T22:27:10 <jaiditya> little uglier but seeing ehich Links were visited
150 2012-07-06T22:27:56 <jaiditya> which*
151 2012-07-06T22:28:39 <ThomasWaldmann> ok, then keep it for "Links" section
152 2012-07-06T22:29:52 <jaiditya> ok...So Views, Trail and User panel to have same visited and non-visited link color
153 2012-07-06T22:30:29 <jaiditya> and Links to have different visited and non-visited link color
154 2012-07-06T22:35:30 <ThomasWaldmann> yup
155 2012-07-06T22:36:01 <ThomasWaldmann> (and content area of course also has different colours)
156 2012-07-06T22:42:25 <jaiditya> ThomasWaldmann: except actions in History table
157 2012-07-06T22:43:37 <ThomasWaldmann> you don't want to have different colours for them? there it might make even sense.
158 2012-07-06T22:43:57 <ThomasWaldmann> e.g. if you want to diff or show all going backwards in history
159 2012-07-06T22:44:45 <jaiditya> hmm...got it
160 2012-07-06T22:45:23 <jaiditya> thank you
161 2012-07-06T22:52:47 <jaiditya> ThomasWaldmann: Have done tests with my changes ?
162 2012-07-06T22:53:18 <jaiditya> I mean is there anything else which should be corrected.
163 2012-07-06T22:53:53 <ThomasWaldmann> spy: answered the remaining question http://codereview.appspot.com/6307082/
164 2012-07-06T22:54:13 <jaiditya> Have you done*
165 2012-07-06T22:54:39 <ThomasWaldmann> jaiditya: not yet, but likely I'll do that tomorrow and show it to sprint participants to get their feedback
166 2012-07-06T22:54:56 <ThomasWaldmann> also please activate your mentor, waldi ^^
167 2012-07-06T22:55:05 <jaiditya> that would be great
168 2012-07-06T22:55:13 <jaiditya> yeah sure
169 2012-07-06T23:13:20 *** dwcramer
170 2012-07-06T23:15:24 *** dave_largo
171 2012-07-06T23:27:18 *** dwcramer
172 2012-07-06T23:40:23 * ThomasWaldmann too tired, will continue tomorrow
173 2012-07-06T23:40:26 <ThomasWaldmann> gn