MoinMoin: MoinMoinChat/Logs/moin-dev/2012-06-21

   1 2012-06-21T00:40:15  <spy> ThomasWaldmann: hi Thomas, are you here?
   2 2012-06-21T00:58:09  <dreimark> spy: you may want to ask the real question
   3 2012-06-21T01:02:07  <spy> dreimark: yes, http://etherpad.osuosl.org/moin-blog 169 please
   4 2012-06-21T01:10:03  * ThomasWaldmann looks
   5 2012-06-21T01:23:44  <dreimark> gn
   6 2012-06-21T01:47:34  *** spy has quit IRC
   7 2012-06-21T03:03:00  *** dwcramer has joined #moin-dev
   8 2012-06-21T03:36:32  *** sudo_dirk has quit IRC
   9 2012-06-21T03:50:56  *** sudo_dirk has joined #moin-dev
  10 2012-06-21T04:35:19  *** ChanServ has quit IRC
  11 2012-06-21T04:50:17  *** ChanServ has joined #moin-dev
  12 2012-06-21T04:50:17  *** kornbluth.freenode.net sets mode: +o ChanServ
  13 2012-06-21T05:08:21  <xiaq> ThomasWaldmann: updated http://codereview.appspot.com/6303091/
  14 2012-06-21T05:08:22  <xiaq> dreimark: ^^
  15 2012-06-21T05:10:12  <xiaq> ThomasWaldmann: after some thinking, i think what is unclean is not the mixture of html stuff and data structure - the views.py files and template files both deal with views
  16 2012-06-21T05:10:37  <xiaq> what is unclean is the mixture of two aspects of the views, structure and presentation
  17 2012-06-21T05:12:18  <xiaq> "data structure" refers to data and metadata in the items model, not the structure of Flatland forms
  18 2012-06-21T05:12:43  <xiaq> structure of Flatland forms differ from the underlying items' structure, more often than not
  19 2012-06-21T05:18:22  *** dwcramer has quit IRC
  20 2012-06-21T05:57:28  *** dwcramer has joined #moin-dev
  21 2012-06-21T05:57:35  *** kanha_ has joined #moin-dev
  22 2012-06-21T05:57:37  *** kanha has quit IRC
  23 2012-06-21T06:28:11  *** dwcramer has quit IRC
  24 2012-06-21T06:29:59  *** betelgeuse_ has joined #moin-dev
  25 2012-06-21T06:40:51  *** dwcramer has joined #moin-dev
  26 2012-06-21T09:49:43  *** dwcramer has quit IRC
  27 2012-06-21T11:39:24  *** greg_f has joined #moin-dev
  28 2012-06-21T13:50:33  *** dwcramer has joined #moin-dev
  29 2012-06-21T14:01:21  <ThomasWaldmann> xiaq: done. btw, did you ask jek for a review also?
  30 2012-06-21T14:03:04  <ThomasWaldmann> xiaq: and yes, structure and presentation. that's what i meant.
  31 2012-06-21T14:35:11  *** dave_largo has joined #moin-dev
  32 2012-06-21T14:58:03  *** dwcramer has quit IRC
  33 2012-06-21T15:21:16  *** spy has joined #moin-dev
  34 2012-06-21T15:46:13  *** dwcramer has joined #moin-dev
  35 2012-06-21T15:47:42  *** sudo_dirk has quit IRC
  36 2012-06-21T15:59:37  *** kanha has joined #moin-dev
  37 2012-06-21T15:59:55  *** kanha_ has quit IRC
  38 2012-06-21T16:02:12  *** sudo_dirk has joined #moin-dev
  39 2012-06-21T16:30:20  *** kanha_ has joined #moin-dev
  40 2012-06-21T16:30:24  *** kanha has quit IRC
  41 2012-06-21T16:39:07  *** jaiditya has joined #moin-dev
  42 2012-06-21T17:54:19  *** RogerHaase has joined #moin-dev
  43 2012-06-21T18:05:32  <xiaq> ThomasWaldmann: ah, should have asked him for a review
  44 2012-06-21T18:07:14  <xiaq> jek: hi, have time to review this patchset against moin2 i worked out? http://codereview.appspot.com/6303091/
  45 2012-06-21T18:07:58  <xiaq> jek: it's basically 1) application of the widget pattern described in http://readthedocs.org/docs/dag-flatland/en/latest/patterns/widgets/
  46 2012-06-21T18:08:41  <xiaq> 2) but i also went a little further to introduce widgets for entire forms, keeping the form layout as Form class attributes
  47 2012-06-21T18:40:30  <xiaq> jek: among the files the interesting one is MoinMoin/templates/forms.html (http://codereview.appspot.com/6303091/patch/1021/15035), MoinMoin/apps/frontend/views.py (http://codereview.appspot.com/6303091/patch/1021/15028) and MoinMoin/forms.py (http://codereview.appspot.com/6303091/patch/1021/15030)
  48 2012-06-21T18:43:03  *** sudo_dirk has quit IRC
  49 2012-06-21T18:56:30  *** sudo_dirk has joined #moin-dev
  50 2012-06-21T19:12:59  *** jaiditya|2 has joined #moin-dev
  51 2012-06-21T19:16:39  *** jaiditya has quit IRC
  52 2012-06-21T19:34:22  *** greg_f has quit IRC
  53 2012-06-21T20:03:33  *** sudo_dirk has quit IRC
  54 2012-06-21T20:18:36  *** sudo_dirk has joined #moin-dev
  55 2012-06-21T20:25:06  *** dwcramer has quit IRC
  56 2012-06-21T20:43:57  *** jaiditya|2 has quit IRC
  57 2012-06-21T20:44:16  *** jaiditya|2 has joined #moin-dev
  58 2012-06-21T20:59:41  *** dwcramer has joined #moin-dev
  59 2012-06-21T22:16:33  *** jaiditya|2 has quit IRC
  60 2012-06-21T22:21:58  *** dwcramer has quit IRC
  61 2012-06-21T22:37:09  *** dwcramer has joined #moin-dev
  62 2012-06-21T22:42:24  *** dwcramer has quit IRC
  63 2012-06-21T23:22:58  *** dave_largo has quit IRC
  64 2012-06-21T23:35:54  *** sudo_dirk1 has joined #moin-dev
  65 2012-06-21T23:36:32  *** sudo_dirk has quit IRC
  66 2012-06-21T23:43:44  *** dwcramer has joined #moin-dev
  67