1 2012-06-14T01:23:21 *** RogerHaase
2 2012-06-14T01:56:03 *** MattMaker
3 2012-06-14T02:15:29 *** MattMaker
4 2012-06-14T03:36:20 *** sudo_dirk
5 2012-06-14T03:38:03 *** sudo_dirk1
6 2012-06-14T06:37:09 *** dwcramer
7 2012-06-14T07:43:20 <dreimark> moin
8 2012-06-14T10:19:33 <CIA-54> Reimar Bauer <rb.proj AT googlemail DOT com> default * 599:31ef7dc6168a extensions/data/plugin/ (3 files in 2 dirs): bbb: action submit_bbb_start_meeting introduced and similar code from submit_bbb_create_meeting amd bbb_create removed. Meetings have to be started by the responsible moderator before someone else can join.
9 2012-06-14T10:19:34 <CIA-54> Reimar Bauer <rb.proj AT googlemail DOT com> default * 600:43461463758f extensions/data/plugin/parser/bbb_create.py: bbb: parser shows now also current number of participants and their state
10 2012-06-14T10:36:27 <xiaq> dreimark: please review patch set 6: http://codereview.appspot.com/6304060/
11 2012-06-14T10:36:29 <xiaq> ThomasWaldmann: ^^
12 2012-06-14T10:37:01 <xiaq> dreimark: i did a refactor on items module to make it easier to merge +modifymeta into +modify
13 2012-06-14T10:38:31 <xiaq> resulted in 53 fewer lines :)
14 2012-06-14T10:41:36 <CIA-54> Reimar Bauer <rb.proj AT googlemail DOT com> default * 601:2aa75cf87a0d extensions/data/plugin/action/submit_bbb_create_meeting.py: bbb: create_meeting action checks if meeting name already exist and rejects
15 2012-06-14T11:19:12 *** greg_f
16 2012-06-14T11:22:39 <dreimark> fsck that security policy did more than expected
17 2012-06-14T11:24:10 <xiaq> dreimark: care to review my code? :)
18 2012-06-14T12:00:05 *** RogerHaase
19 2012-06-14T12:30:57 *** RogerHaase
20 2012-06-14T12:56:49 <dreimark> xiaq: yeah, was in a meeting than lunch
21 2012-06-14T12:56:57 <dreimark> s/than/then
22 2012-06-14T12:59:34 <dreimark> xiaq: you hate constants in uppercase?
23 2012-06-14T13:00:10 <dreimark> oh, i see
24 2012-06-14T13:05:22 <xiaq> dreimark: if we do constants, we also need to put constants in the jinja env to be consistent
25 2012-06-14T13:07:45 <xiaq> dreimark: i don't "hate" them much, just doubt whether it makes sense to have constants for string literals whose names are identical except for the case... but since preventing typos is a valid argument to me so i agreed to accpet the convention afterwards
26 2012-06-14T13:21:40 <dreimark> xiaq: i did a short time review, have you tried that changes?
27 2012-06-14T13:33:34 <CIA-54> Reimar Bauer <rb.proj AT googlemail DOT com> default * 602:ba791ad6c846 extensions/data/plugin/security/bbb_access_data.snippet: security: bbb_access_data.snippet set for all other parser normal read behaviour
28 2012-06-14T13:46:45 <CIA-54> Reimar Bauer <rb.proj AT googlemail DOT com> default * 603:fa6bb1f3c86c extensions/data/plugin/security/bbb_access_data.snippet: security: bbb_access_data.snippet requires now logged in users for bbb parser
29 2012-06-14T14:06:52 *** spy
30 2012-06-14T14:20:18 *** dwcramer
31 2012-06-14T14:39:05 *** dave_largo
32 2012-06-14T15:05:36 <xiaq> dreimark: replied
33 2012-06-14T15:07:17 <dreimark> xiaq: ok
34 2012-06-14T15:08:16 <dreimark> xiaq: some code is older than our review process.
35 2012-06-14T15:08:39 <dreimark> (with cr)
36 2012-06-14T15:09:02 <dreimark> so sometimes something finds it way now into my eyes which I hadn't thought before
37 2012-06-14T15:09:13 <dreimark> or seen
38 2012-06-14T15:09:56 <dreimark> it is ok if it is the same than before the refactoring, but we should also be able to discuss if it is needed or why it is there
39 2012-06-14T15:10:12 <dreimark> not only with you but with ThomasWaldmann
40 2012-06-14T15:10:47 <dreimark> it is not related to your task but because we read that code again we can solve other issues too
41 2012-06-14T15:12:02 <xiaq> dreimark: uh, which part are you referring to?
42 2012-06-14T15:12:09 <dreimark> the GET question
43 2012-06-14T15:12:12 <xiaq> dreimark: handling GETs in items/__init__.py
44 2012-06-14T15:12:24 <dreimark> for modify
45 2012-06-14T15:12:31 <xiaq> dreimark: well i found it okay - the same flatland form is used in both GET and POST
46 2012-06-14T15:13:35 <dreimark> usually you make it a bit harder for bots if they can't send get requests including a valid textcha answer and a ticket
47 2012-06-14T15:14:11 <xiaq> dreimark: uh, that GET goes to +modify/
48 2012-06-14T15:15:00 <xiaq> dreimark: which is not supposed to be seen by bots anyway
49 2012-06-14T15:16:52 <xiaq> dreimark: don't think there is anything wrong with that...
50 2012-06-14T15:17:35 <ThomasWaldmann> xiaq: review done
51 2012-06-14T15:17:49 <dreimark> i should have looked 10 ines before
52 2012-06-14T15:18:06 <dreimark> sorry i have not seen the definition
53 2012-06-14T15:18:38 <xiaq> ThomasWaldmann: seems to separate new stuff and refactors
54 2012-06-14T15:19:01 <xiaq> ThomasWaldmann: i need to use make a few local commits and use upload.py --rev
55 2012-06-14T15:19:02 <xiaq> right?
56 2012-06-14T15:19:38 <ThomasWaldmann> well, i usually just do one after the other.
57 2012-06-14T15:22:31 <xiaq> ThomasWaldmann: hm, i'm refactoring things when i try to add new stuff :)
58 2012-06-14T15:24:33 <ThomasWaldmann> well, sometimes it is not possible otherwise, because you need the new stuff to do it
59 2012-06-14T15:25:13 <ThomasWaldmann> but if possible, then one should resist fixing and changing all stuff noted while working on a single topic
60 2012-06-14T15:25:34 <ThomasWaldmann> first do that single topic, commit, then fix all other stuff you noted in separate commits
61 2012-06-14T15:25:51 <xiaq> ThomasWaldmann: ok, i'll try to do that in future...
62 2012-06-14T15:25:52 <ThomasWaldmann> that makes review much easier
63 2012-06-14T15:26:26 <ThomasWaldmann> and btw, that drawing stuff was a mess
64 2012-06-14T15:27:06 <ThomasWaldmann> i resisted touching it because some stuff I didn't precisely know how it should be
65 2012-06-14T15:27:28 <ThomasWaldmann> and also, i had other priorities :)
66 2012-06-14T15:27:58 <ThomasWaldmann> so, if you clean it up: thanks. but make sure it still works at least as good as before. :)
67 2012-06-14T15:30:03 <dreimark> xiaq: crecord extension helps to group commits
68 2012-06-14T15:31:05 <xiaq> dreimark: yeah, but upload.py seems to recognize changesets only (ie. not hg queues)
69 2012-06-14T15:32:00 <xiaq> ThomasWaldmann: see my reply on cr...
70 2012-06-14T15:34:27 *** dwcramer
71 2012-06-14T15:40:38 <xiaq> okay...
72 2012-06-14T15:40:48 <xiaq> so i managed a refactor-only one
73 2012-06-14T15:40:58 <xiaq> please review! http://codereview.appspot.com/6296074
74 2012-06-14T15:41:40 <dreimark> fast
75 2012-06-14T15:41:51 <ThomasWaldmann> xiaq: java stuff is somehow a constant pain
76 2012-06-14T15:42:29 <ThomasWaldmann> especially some stuff only works with sun/oracle java but not with the java jres present in popular linux dists...
77 2012-06-14T15:42:39 <xiaq> ThomasWaldmann: yeah, but tdraw and adraw code was almost identical as svgdraw
78 2012-06-14T15:42:51 <ThomasWaldmann> but, as I said: if you change it, you have to test it.
79 2012-06-14T15:43:03 <dreimark> xiaq: almost but not completly
80 2012-06-14T15:43:06 <xiaq> and svgdraw was not broken by my refactor, i assume they are not broken either :)
81 2012-06-14T15:43:44 <xiaq> dreimark: yeah, that's why AnyWikiDraw has a different ModifyForm...
82 2012-06-14T15:44:04 <xiaq> but do_modify of TWikiDraw and SvgDraw was indeed identical...
83 2012-06-14T15:44:06 <xiaq> line by line
84 2012-06-14T15:44:13 <ThomasWaldmann> also all these other views you are touching, of course
85 2012-06-14T15:46:01 <ThomasWaldmann> + the usual py.test run
86 2012-06-14T15:46:19 <ThomasWaldmann> btw, i recently upgraded the pep8 stuff, did you already pull/merge it?
87 2012-06-14T15:47:33 <xiaq> ThomasWaldmann: going to do a pull soon...
88 2012-06-14T15:47:57 <xiaq> ThomasWaldmann: uh oh i broke +meta
89 2012-06-14T15:48:30 <ThomasWaldmann> the new pep8 code might find some more issues than the old one. if so, please do a separate commit with just fixing all pep8 stuff in your code.
90 2012-06-14T15:49:26 <xiaq> ThomasWaldmann: got it
91 2012-06-14T15:50:17 <dreimark> ThomasWaldmann: yesterday he did that step
92 2012-06-14T15:50:54 <ThomasWaldmann> bretonium: the calendar says you did no work in the past 12 days
93 2012-06-14T15:51:12 *** RogerHaase
94 2012-06-14T15:51:17 <ThomasWaldmann> dasich: "" 11 days
95 2012-06-14T15:52:08 <ThomasWaldmann> spy: "" 18 days!
96 2012-06-14T15:52:58 *** kanha__
97 2012-06-14T15:53:32 *** kanha_
98 2012-06-14T15:55:19 <RogerHaase> ThomasWaldmann: fix for global index problems ready for review: http://codereview.appspot.com/6297086/
99 2012-06-14T15:57:14 <dreimark> xiaq: format docstrings similar to others
100 2012-06-14T15:58:01 <dreimark> spy: check and verify that you have calendar entries there
101 2012-06-14T15:58:22 <xiaq> dreimark: seems docstring format of existing codes is not consistent... :)
102 2012-06-14T15:59:35 <xiaq> dreimark: this is what i followed:
103 2012-06-14T15:59:36 <xiaq> http://moin-20.readthedocs.org/en/latest/_modules/MoinMoin/app.html#create_app_ext
104 2012-06-14T16:01:15 <ThomasWaldmann> RogerHaase: hi. review done.
105 2012-06-14T16:02:10 <xiaq> ThomasWaldmann: review requested! http://codereview.appspot.com/6296074/ :)
106 2012-06-14T16:02:41 <ThomasWaldmann> xiaq: isn't that the same stuff again?
107 2012-06-14T16:03:12 <xiaq> ThomasWaldmann: ah yes...
108 2012-06-14T16:03:41 <xiaq> ThomasWaldmann: forgot that i already announced it :(
109 2012-06-14T16:05:50 <xiaq> I remember bretonium once expressed the concern that touching view codes would require every student to adapt to it, which can be a lot of work
110 2012-06-14T16:06:51 <xiaq> ThomasWaldmann: how did you deal with that during past soc's ?
111 2012-06-14T16:08:07 <ThomasWaldmann> if one suspects issues there, merging often helps
112 2012-06-14T16:11:23 <xiaq> ThomasWaldmann: i think bretonium's concern is about merging from a changeable upstream and solving conflicts might distract students working on their projects...
113 2012-06-14T16:13:37 <ThomasWaldmann> i suspect that currently lots of other stuff is distracting students from working on their projects, but not that :)
114 2012-06-14T16:14:41 <ThomasWaldmann> also, this is usual development stuff, if you work with other people, you'll have to get used to that
115 2012-06-14T16:14:42 <xiaq> ThomasWaldmann: ah yes :)
116 2012-06-14T16:15:39 <RogerHaase> ThomasWaldmann: pushed to clone https://bitbucket.org/RogerHaase/moin-2.0
117 2012-06-14T16:15:59 <ThomasWaldmann> of course one can try to avoid causing issues. e.g. for the pep8 stuff i did recently, I avoided doing stuff that would have created extremely widespread changes
118 2012-06-14T16:16:41 <xiaq> ThomasWaldmann: oh as for that,
119 2012-06-14T16:17:01 <xiaq> seems there are lots of failing tests related to test_sourcecode.py
120 2012-06-14T16:17:33 <ThomasWaldmann> before or after you merge the new pep8 stuff?
121 2012-06-14T16:17:49 <xiaq> ThomasWaldmann: after - i just did a `hg pull; hg update`
122 2012-06-14T16:18:14 <ThomasWaldmann> pip install -e .
123 2012-06-14T16:18:23 <xiaq> ThomasWaldmann: but the output of py.test refers to the source code of test_sourcecode.py, not the failing source files...
124 2012-06-14T16:18:27 <xiaq> ThomasWaldmann: did that too
125 2012-06-14T16:18:33 * dreimark does not have any pep8 failures
126 2012-06-14T16:18:49 <ThomasWaldmann> xiaq: put the output on a pastebin
127 2012-06-14T16:18:59 <xiaq> ThomasWaldmann: ok
128 2012-06-14T16:19:00 <dreimark> rm -r build
129 2012-06-14T16:19:06 <dreimark> pip install -e .
130 2012-06-14T16:19:42 <RogerHaase> I have just the usual 2 windows test failures: 2 failed, 870 passed, 58 skipped, 1 error in 125.91 seconds
131 2012-06-14T16:19:45 <xiaq> dreimark: there is not build and i did that pip...
132 2012-06-14T16:20:26 <CIA-54> Roger Haase <crosseyedpenguin@yahoo.com> default * 1384:7e67e84510b8 2.0/MoinMoin/static/js/ (index_action.js jfu.js countdown.js): jslint two .js files, delete unused .js file; fixes issue #38
133 2012-06-14T16:20:26 <CIA-54> Roger Haase <crosseyedpenguin@yahoo.com> default * 1385:895720920d4f 2.0/MoinMoin/templates/base.html: fix issue #195: HTML Validation error on subitem pages
134 2012-06-14T16:20:27 <CIA-54> Roger Haase <crosseyedpenguin@yahoo.com> default * 1386:ab98b4172d5a 2.0/MoinMoin/ (5 files in 4 dirs): fix for #191 part 2 - fix bugs created by eliminating html validation errors on Global Index page
135 2012-06-14T16:20:35 <xiaq> http://dpaste.com/759539/
136 2012-06-14T16:20:44 <xiaq> dpaste.com complained the full log is too long
137 2012-06-14T16:22:41 <ThomasWaldmann> xiaq: the assertion is triggered in test_sourcecode, but you have to look at the stdout section to see what the pep8 checker complained about
138 2012-06-14T16:23:06 <xiaq> ThomasWaldmann: that's all output i got, including stdout and stderr...
139 2012-06-14T16:23:07 <dreimark> xiaq: this is your code
140 2012-06-14T16:24:19 <ThomasWaldmann> xiaq: also, you said you did pull/update. did you merge?
141 2012-06-14T16:25:36 <xiaq> ThomasWaldmann: i have no diverging commits, only a dirty working directory
142 2012-06-14T16:26:43 <ThomasWaldmann> then it won't update that
143 2012-06-14T16:26:57 <ThomasWaldmann> and be careful not to lose stuff
144 2012-06-14T16:28:33 <xiaq> ThomasWaldmann: but when my dirty working directory conflicts with a commit hg will refuse to do `hg update` won't it?
145 2012-06-14T16:28:51 <dreimark> no you can have more stuff
146 2012-06-14T16:28:59 <dreimark> not under revision control
147 2012-06-14T16:29:05 <dreimark> or not committed
148 2012-06-14T16:29:09 <xiaq> dreimark: yeah but that's not conflict
149 2012-06-14T16:29:49 <dreimark> it will update the part it can the other must be merged
150 2012-06-14T16:29:54 <ThomasWaldmann> all test_sourcecode tests pass here
151 2012-06-14T16:29:56 *** dwcramer
152 2012-06-14T16:30:00 <dreimark> here too
153 2012-06-14T16:30:15 <ThomasWaldmann> but i did a lot of commits to fix all the stuff it complained about
154 2012-06-14T16:30:31 <dreimark> vim /home/xiaq/src/moin2/MoinMoin/apps/frontend/views.py +754
155 2012-06-14T16:30:45 <xiaq> **args
156 2012-06-14T16:30:48 <dreimark> and the python.vim pep checker should tell a whitespace issue
157 2012-06-14T16:32:52 <dreimark> hmm that one is strange /home/xiaq/src/moin2/MoinMoin/auth/ldap_login.py
158 2012-06-14T16:33:05 <dreimark> i guess you don't have touched it
159 2012-06-14T16:33:34 <xiaq> dreimark: yeah, and the views.py line above wasn't touched by me either
160 2012-06-14T16:35:32 <dreimark> xiaq: which python version
161 2012-06-14T16:35:59 <xiaq> (env)~/src/moin2% python --version
162 2012-06-14T16:36:00 <xiaq> Python 2.7.3
163 2012-06-14T16:36:05 <ThomasWaldmann> spy: how was that loading of serialized items negatively impacting your search results?
164 2012-06-14T16:36:34 <dreimark> it has not all attributes
165 2012-06-14T16:36:46 <dreimark> xiaq: do you run py.test from a terminal
166 2012-06-14T16:36:50 <xiaq> dreimark: yes
167 2012-06-14T16:37:02 <xiaq> dreimark: hm weird
168 2012-06-14T16:37:25 <ThomasWaldmann> xiaq: how should update work if you have a dirty workdir? it can't.
169 2012-06-14T16:37:52 <ThomasWaldmann> (and it should give an error msg that you maybe have missed)
170 2012-06-14T16:38:01 <xiaq> dreimark: i cloned my local repo, did quickinstall again, and in that virtualenv py.test has test_sourcecode.py tests pass...
171 2012-06-14T16:39:44 <xiaq> ThomasWaldmann: uh it was like this: http://dpaste.com/759546/
172 2012-06-14T16:40:11 <dreimark> http://stackoverflow.com/questions/6990501/python-proper-code-formatting-pep8
173 2012-06-14T16:41:11 <spy> ThomasWaldmann: When I load them and then build-index then I can't normally use newly created whoosh fields like PTIME or SUMMARY.
174 2012-06-14T16:41:15 <xiaq> dreimark: uh again that failing views.py line was not touched by me :)
175 2012-06-14T16:41:30 <spy> ThomasWaldmann: I can't even search Term(SUMMARY, "foo");
176 2012-06-14T16:41:38 <dreimark> xiaq: remove all pyc files and run py.test again
177 2012-06-14T16:41:50 <spy> ThomasWaldmann: this query doesn't provide anything
178 2012-06-14T16:42:31 <ThomasWaldmann> well, did you save a revision with SUMMARY="foo"?
179 2012-06-14T16:42:52 <xiaq> dreimark: ah that did the trick
180 2012-06-14T16:43:11 <xiaq> still pretty weird though
181 2012-06-14T16:43:15 <spy> ThomasWaldmann: of course
182 2012-06-14T16:43:20 <dreimark> have you done a py update?
183 2012-06-14T16:44:00 <ThomasWaldmann> xiaq: likely you had the old pep8.pyc still in MoinMoin/_tests/
184 2012-06-14T16:44:30 <ThomasWaldmann> and as the code just does "import pep8", it has taken the old one instead the one from the pypi package
185 2012-06-14T16:45:35 <ThomasWaldmann> spy: so you FIRST loaded the serialized sample items, then built and index, then saved your item and then search was not working?
186 2012-06-14T16:45:47 <ThomasWaldmann> an* index
187 2012-06-14T16:46:26 <ThomasWaldmann> (order might be important)
188 2012-06-14T16:47:33 * ThomasWaldmann brb
189 2012-06-14T16:52:14 <spy> ThomasWaldmann: I do the following: 1) moin index-create -s -i 2) moin load --file contrib/serialized/items.moin 3) moin index-build 4) create new item with "summary": "foo" 5) try to search it and it doesn't work
190 2012-06-14T16:53:03 <ThomasWaldmann> does searching for other metadata work?
191 2012-06-14T16:53:18 <spy> ThomasWaldmann: for MTIME, NAME and others do
192 2012-06-14T16:53:36 <ThomasWaldmann> you can use moin index-dump to look at index contents btw
193 2012-06-14T16:54:19 <xiaq> ThomasWaldmann: regarding the behavior of `hg update`
194 2012-06-14T16:54:20 <spy> ThomasWaldmann: yes, they are displayed there
195 2012-06-14T16:54:36 <xiaq> according to `hg help update`, `hg update` actually does a merge when the working directory is dirty
196 2012-06-14T16:55:04 <xiaq> and my working directory contains changes with no conflict with upstream repo commits, so simply doing a `hg update` works
197 2012-06-14T16:55:09 <ThomasWaldmann> xiaq: i would not even try such stuff :)
198 2012-06-14T16:55:56 <ThomasWaldmann> before i do any pull/merge, i have my workdir clean and my stuff safe
199 2012-06-14T16:56:20 <ThomasWaldmann> spy: including the summary: foo?
200 2012-06-14T16:56:31 <spy> ThomasWaldmann: yeah
201 2012-06-14T16:57:01 <xiaq> ThomasWaldmann: yeah but i haven't figured out how to fiddle with commit history with hg, so i keep the working copy dirty when i'm actively developing
202 2012-06-14T16:57:01 <ThomasWaldmann> Term(SUMMARY, u"foo") maybe?
203 2012-06-14T16:57:30 <ThomasWaldmann> whoosh does very much demand everything is unicode
204 2012-06-14T16:58:08 <ThomasWaldmann> xiaq: then don't merge at that time
205 2012-06-14T16:59:02 <ThomasWaldmann> you are just risking creating a big mess or even losing stuff
206 2012-06-14T17:00:00 <ThomasWaldmann> spy: if above does not work, show me the full code and the result of the search call
207 2012-06-14T17:00:27 <ThomasWaldmann> (on codereview)
208 2012-06-14T17:08:08 * ThomasWaldmann brb
209 2012-06-14T17:23:49 <ThomasWaldmann> spy: still there?
210 2012-06-14T17:24:18 <spy> ThomasWaldmann: just a moment
211 2012-06-14T17:34:13 <spy> ThomasWaldmann: http://codereview.appspot.com/6294072
212 2012-06-14T17:34:57 <spy> ThomasWaldmann: I was a little wrong about search Term(...). This works, but sorting don't
213 2012-06-14T17:36:51 <spy> ThomasWaldmann: and when I don't load any data so there is no problem with this code
214 2012-06-14T17:40:40 <spy> ThomasWaldmann: maybe this is useful: https://github.com/toastdriven/django-haystack/issues/418
215 2012-06-14T17:42:20 <ThomasWaldmann> well, i didn't work with facets yet
216 2012-06-14T17:43:03 <ThomasWaldmann> but if you suspect that there is a bug in whoosh, please produce some minimal code (== not within moin2) that reproduces the issue
217 2012-06-14T17:45:07 <ThomasWaldmann> btw, the +history view is using sortedby=[MTIME]
218 2012-06-14T17:47:09 <ThomasWaldmann> and that works
219 2012-06-14T17:47:51 <spy> ThomasWaldmann: yes, that works even with sortedby=[SUMMARY] when we starting from the empty index
220 2012-06-14T17:49:51 <spy> ThomasWaldmann: I will try to reproduce this behaviour not within moin2, but now I should work a lot on my project.
221 2012-06-14T17:53:08 * ThomasWaldmann did another try, using the serialized items, modifying one of them and +history is still reverse-sorted as expected
222 2012-06-14T17:55:30 <spy> ThomasWaldmann: with older created field (like MTIME, NAME_EXACT, ...) works well
223 2012-06-14T18:09:56 <ThomasWaldmann> spy: can you try killing the data and index directories and starting from scratch?
224 2012-06-14T18:12:45 <spy> ThomasWaldmann: exactly this I do (rm -rf wiki/*)
225 2012-06-14T18:12:58 <ThomasWaldmann> hmm, ok
226 2012-06-14T18:20:34 <ThomasWaldmann> spy: http://dpaste.com/759605/
227 2012-06-14T18:21:12 * ThomasWaldmann suspected it has to do with a field being not present, but obviously even that works as expected
228 2012-06-14T18:48:55 <CIA-54> DasIch <dasdasich@gmail.com> default * 1387:435a35537d13 2.0/.hgignore: Permanently ignore docs/devel/api/modules.rst
229 2012-06-14T18:48:55 <CIA-54> DasIch <dasdasich@gmail.com> default * 1388:805de343f48b 2.0/.hgignore: Ignore codereview upload tool
230 2012-06-14T18:48:56 <CIA-54> DasIch <dasdasich@gmail.com> default * 1389:522d2cea9ec8 2.0/MoinMoin/items/__init__.py: Fix string formatting in RegistryItem.__repr__
231 2012-06-14T18:48:57 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1390:3989635de0fb 2.0/ (.hgignore MoinMoin/items/__init__.py): merged DasIch's changes
232 2012-06-14T19:44:23 *** greg_f
233 2012-06-14T21:02:38 *** dwcramer
234 2012-06-14T21:15:00 *** dave_largo
235 2012-06-14T21:15:14 *** dwcramer
236 2012-06-14T22:15:36 *** dwcramer
237 2012-06-14T22:30:19 *** dwcramer
238
