1 2012-05-22T00:15:21 *** dwcramer
2 2012-05-22T00:38:09 *** MattMaker
3 2012-05-22T01:49:59 *** dwcramer
4 2012-05-22T02:46:20 *** MattMaker
5 2012-05-22T03:14:14 <eSyr-ng> jaiditya: unrelated note regarding color palettes: https://github.com/altercation/solarized
6 2012-05-22T03:28:09 <eSyr-ng> ThomasWaldmann: dreimark: http://moinmo.in/CodeReview some initial draft. I'm not consistent with style and such, but tried to provide main points.
7 2012-05-22T03:29:58 <eSyr-ng> (hm, and my grammar is not good too)
8 2012-05-22T04:20:58 *** dwcramer
9 2012-05-22T05:12:38 *** jaiditya
10 2012-05-22T07:42:12 <dreimark> moin
11 2012-05-22T08:01:39 *** MattMaker
12 2012-05-22T08:05:23 *** MattMaker
13 2012-05-22T09:05:57 <eSyr-ng> dreimark: moin
14 2012-05-22T09:47:41 <eSyr-ng> dreimark: btw, have you any caomments regarding CodeReview page? It's kinda personal guidelines, maybe there is some more general which you are aware of.
15 2012-05-22T09:50:25 <dreimark> eSyr-ng: me is thinking about it
16 2012-05-22T09:50:52 <dreimark> one point is to make clear that one himself can do the first review
17 2012-05-22T09:51:03 <dreimark> by just reafing hg diff and hg stat
18 2012-05-22T09:52:00 <eSyr-ng> well, heh.
19 2012-05-22T09:52:21 <dreimark> and running py.test before any cr so less pep8 issues
20 2012-05-22T09:52:21 <eSyr-ng> i implicitly mean it when mentioned them.
21 2012-05-22T09:52:44 <eSyr-ng> maybe explicitly state "read diffs before commiting"
22 2012-05-22T09:53:39 <eSyr-ng> regarding pep8 i use vim syntax file you gave me like 3 years ago and very happy with is :)
23 2012-05-22T09:53:42 <dreimark> my main point is i think to give not more than four-five rules, short described for basics
24 2012-05-22T09:53:44 <eSyr-ng> maybe mention it also.
25 2012-05-22T09:53:58 <dreimark> and a longer text for advanced
26 2012-05-22T09:54:37 * dreimark is also using vim pep8 syntax checker
27 2012-05-22T09:54:38 *** spy
28 2012-05-22T09:57:26 <dreimark> eSyr-ng: we had a screencast from a gci student for a good patch commit cycle.
29 2012-05-22T09:58:01 <dreimark> I have to look for that movie first
30 2012-05-22T10:31:46 <eSyr-ng> dreimark: can you provide a link?
31 2012-05-22T10:38:17 *** jaiditya
32 2012-05-22T10:40:26 *** spy
33 2012-05-22T10:48:55 *** greg_f
34 2012-05-22T10:49:45 <MaikuMori> ThomasWaldmann: are you available?
35 2012-05-22T11:25:33 <breton> ThomasWaldmann: sorry, couldn't post as promised - my phone died. Will post a bit later.
36 2012-05-22T11:26:31 <dreimark> eSyr-ng: http://static.moinmo.in/files/screencast/
37 2012-05-22T11:27:22 <eSyr> uh-oh.
38 2012-05-22T11:27:33 <eSyr> gpl-licensed video :|
39 2012-05-22T11:27:38 <dreimark> hehe
40 2012-05-22T11:27:49 * dreimark lunch bbl
41 2012-05-22T11:28:06 <eSyr> uh-oh, interlacing
42 2012-05-22T11:29:39 <dreimark> yeah not simple to show the workflow at all
43 2012-05-22T11:30:13 * eSyr-ng remember one screencast he makes
44 2012-05-22T11:30:22 * eSyr-ng would not like to repeat it again
45 2012-05-22T11:30:33 <eSyr-ng> *made
46 2012-05-22T11:31:41 <eSyr-ng> ah, no, i lied, something more, but not screencast definitely.
47 2012-05-22T12:02:20 <eSyr-ng> dreimark: http://moinmo.in/4ct10n/info/CodeReview?action=diff&rev2=4&rev1=3 tl'dr section added
48 2012-05-22T12:11:46 <dreimark> eSyr-ng: pytest before commit
49 2012-05-22T12:12:56 <dreimark> if one makes an upload before commit or after and the outcome depends a bit on the skill level
50 2012-05-22T12:13:38 <dreimark> we had already some contributors who had to redo all commits and reboot their repo
51 2012-05-22T12:13:43 <eSyr> well, i don't see reasons of uploading uncommitted stuff.
52 2012-05-22T12:14:23 <dreimark> the question is if we want to make a pull of lots of bad changes and only one good one
53 2012-05-22T12:14:34 <eSyr> (commits are pretty beautyfied diffs annotated with verbose comments and uncommitted stuff is ugly hacking)
54 2012-05-22T12:15:09 <dreimark> for someone who is experienced with the workflow and is known it makes no difference
55 2012-05-22T12:15:29 <dreimark> if someone comes new to the project we don't know
56 2012-05-22T12:16:01 <eSyr> dreimark: that's the point of history rewriting before pushing.
57 2012-05-22T12:16:11 <dreimark> ok
58 2012-05-22T12:16:15 <jaiditya> waiting since last night for the review http://codereview.appspot.com/6223057/
59 2012-05-22T12:16:29 <dreimark> waldi: ^
60 2012-05-22T12:16:58 <eSyr> dreimark: frequent commits provide many small diffs which can be combiuned and are themselves easier to analyse and edit.
61 2012-05-22T12:17:15 <eSyr> jaiditya: 05:15:02 < eSyr-ng> jaiditya: unrelated note regarding color palettes: https://github.com/altercation/solarized
62 2012-05-22T12:17:26 <dreimark> yes, but I had seen already some student who fail with small commits
63 2012-05-22T12:17:47 <eSyr> dreimark: aaaand, there's hg histedit takes in action.
64 2012-05-22T12:17:54 <eSyr> (well, from my point of view)
65 2012-05-22T12:18:39 <eSyr> we can fold multiple (edit-fixup-fixup-other edit-fixup#1-fixup#2) into (edit-another edit)
66 2012-05-22T12:19:55 <eSyr> (btw, i don't know how to revert hg histedit; in hg, i just pointed to previous HEAD manually and afaik hg does not provide such low-level command)
67 2012-05-22T12:20:01 <eSyr> *in git
68 2012-05-22T12:20:37 <MaikuMori> How is that different from different multiple changesets @ codereview and 1-2 commits? The end result is the same, isn't it?
69 2012-05-22T12:21:27 <eSyr> MaikuMori: well, imagine that some maniac who knows your address will maintain code after you and found that one of your 10000-line changesets introduced some error.
70 2012-05-22T12:21:36 * dreimark prefers in an open environment
71 2012-05-22T12:21:51 <dreimark> changes - cr - commit, push, pull
72 2012-05-22T12:21:52 <eSyr> *and find
73 2012-05-22T12:22:05 <ThomasWaldmann> hehe
74 2012-05-22T12:22:12 <dreimark> at our institute we have a checking repo before pull too
75 2012-05-22T12:23:05 <ThomasWaldmann> MaikuMori: if you just ask what you want to know, you have less roundtrip time likely
76 2012-05-22T12:23:27 <MaikuMori> Just work on EP mostly
77 2012-05-22T12:23:28 <eSyr> small diffs are easier to read, they make bisect working better and they can be easily cherrypicked.
78 2012-05-22T12:23:55 <dreimark> I mean with changes small diffs too
79 2012-05-22T12:24:08 <dreimark> but you are right we meet somewhere in the middle
80 2012-05-22T12:24:10 <eSyr> (and has virtually no overhead except providing commitmessaages in fact)
81 2012-05-22T12:24:18 <dreimark> sometimes you don't let review small changes that way
82 2012-05-22T12:25:03 <MaikuMori> eSyr: I get that, but doing 6 commits, then merging them into 2 still makes them appear as 2 in the main repo. So why don't you just make 2 commits total and 4 changesets @ codereview? It's the same.
83 2012-05-22T12:25:55 <MaikuMori> Unless misunderstood something.
84 2012-05-22T12:26:01 <dreimark> nnl
85 2012-05-22T12:26:03 <eSyr> MaikuMori: because when i'm doing first commit, i usually don't know that i'm introducing small error or incompleteness which i'll notice only after 2 or 3 another commits.
86 2012-05-22T12:26:08 <dreimark> sick
87 2012-05-22T12:26:09 <dreimark> bbl
88 2012-05-22T12:27:17 <eSyr> MaikuMori: aaand, that's why i don't bother to do very complete commits during hacking, i commit as soon as i give something working because i always know that i can make good commits later, before review/push.
89 2012-05-22T12:27:26 <MaikuMori> I do codereview without actually committing, then when codereview is done I commit. If it was bigger change I'd prob make 2 commits or more inbetween.
90 2012-05-22T12:28:07 <eSyr> well, ok, looks like we're talking about different usecases.
91 2012-05-22T12:28:15 <MaikuMori> Yeah I guess.
92 2012-05-22T12:28:47 <eSyr> i'm talking about hacking of some feature which consists of numerous changes in different files and parts of code, maybe chained.
93 2012-05-22T12:29:00 <eSyr> usually it takes 1-2-3 days.
94 2012-05-22T12:29:19 <eSyr> and grand total patchset about several hundred lines of code.
95 2012-05-22T12:30:19 <eSyr> and after hacking i usually have 10-20-30 commits which i combine into 5-10 ones and provide 2-5 changesets for review.
96 2012-05-22T12:31:25 <eSyr> when you're changing only one file, you surely have no need in all that stuff i described above.
97 2012-05-22T12:32:03 <eSyr> but for soc i suppose some intensive hacking (at least, at some points)
98 2012-05-22T12:32:40 <eSyr> like, you understand that you need to implement this, but in the middle you understand that you need to implement 5 more things and so on.
99 2012-05-22T12:33:19 <MaikuMori> I get it
100 2012-05-22T12:33:37 <MaikuMori> ThomasWaldmann: EP
101 2012-05-22T12:53:49 *** jaiditya
102 2012-05-22T12:54:04 *** jaiditya
103 2012-05-22T13:27:18 <dreimark> jaiditya: done
104 2012-05-22T14:42:32 <jaiditya> dreimark: replied. http://codereview.appspot.com/6223057/
105 2012-05-22T14:47:24 *** dave_largo
106 2012-05-22T15:24:20 *** kanha_
107 2012-05-22T15:25:16 *** kanha
108 2012-05-22T17:04:18 *** dwcramer
109 2012-05-22T17:10:54 *** greg_f
110 2012-05-22T17:10:55 *** betelgeuse_
111 2012-05-22T17:34:12 *** spy_
112 2012-05-22T17:38:19 <jaiditya> Sorry I just noticed but "Create it" on moin2 home is not a link anymore on localserver. Is anything wrong with my repo ?
113 2012-05-22T17:42:26 *** DasIch_
114 2012-05-22T17:44:05 *** DasIch
115 2012-05-22T17:44:05 *** DasIch_
116 2012-05-22T17:49:51 *** betelgeuse_
117 2012-05-22T18:03:09 *** dwcramer
118 2012-05-22T18:13:26 <ThomasWaldmann> jaiditya: sounds strange. where does it point to?
119 2012-05-22T18:14:04 <jaiditya> I am not able to create home
120 2012-05-22T18:18:18 *** dwcramer
121 2012-05-22T18:58:45 *** dwcramer
122 2012-05-22T19:08:48 *** spy
123 2012-05-22T19:13:37 *** dwcramer
124 2012-05-22T20:05:15 *** dwcramer
125 2012-05-22T20:20:39 *** dwcramer
126 2012-05-22T20:24:44 *** MattMaker
127 2012-05-22T20:30:30 *** MattMaker
128 2012-05-22T20:45:39 <spy_> ThomasWaldmann: I need advice, what should I work on now and what should I do first to start coding new blog features and to get a better understanding of the internal structure of the moin?
129 2012-05-22T20:49:21 *** dwcramer
130 2012-05-22T20:55:49 <dreimark> spy_: today coding phase starts, where have you been the last days?
131 2012-05-22T20:56:36 <dreimark> do you have already a fork / clone of the moin2 repo?
132 2012-05-22T21:00:33 <spy_> dreimark: I was from time to time online, yes already forked
133 2012-05-22T21:00:47 <dreimark> you can have a look at a recent changeset by xiaq for adding meta keys as shown here http://hg.moinmo.in/moin/2.0/rev/5b88a6ae67a5
134 2012-05-22T21:02:07 <spy_> sure, I've read that
135 2012-05-22T21:03:23 <dreimark> please do also next steps asap http://moinmo.in/GoogleSoc2012
136 2012-05-22T21:03:51 <dreimark> as you need meta keys for your blog posts you can start from that end
137 2012-05-22T21:06:45 <dreimark> the frontends can be defined in http://hg.moinmo.in/moin/2.0/file/359d51f0fa90/MoinMoin/apps/frontend/views.py
138 2012-05-22T21:07:07 *** dwcramer
139 2012-05-22T21:09:28 <dreimark> spy_: http://etherpad.osuosl.org/moin-render-method
140 2012-05-22T21:09:35 <dreimark> have you looked into that
141 2012-05-22T21:10:09 <spy_> I'm aware of what is happening with the render_method, but not yet fully understand what we need to add or change there to discuss explicitly.
142 2012-05-22T21:13:13 <dreimark> that is the view method later for your blog posts
143 2012-05-22T21:13:50 <dreimark> currently we have only show, which can't be used for blog, ticket and paste
144 2012-05-22T21:14:35 <eSyr-ng> well, it can, but you don't appreciate the way how it can be :)
145 2012-05-22T21:14:54 <dreimark> http://hg.moinmo.in/moin/2.0/file/359d51f0fa90/MoinMoin/apps/frontend/views.py#l266
146 2012-05-22T21:15:02 <dreimark> that is the old method
147 2012-05-22T21:15:17 <dreimark> your part is to develop the new method to render your posts
148 2012-05-22T21:16:49 <spy_> yeah, I see that I need it
149 2012-05-22T21:20:55 <dreimark> bbl
150 2012-05-22T21:35:30 *** dwcramer
151 2012-05-22T21:35:47 *** jaiditya
152 2012-05-22T21:51:02 *** dwcramer
153 2012-05-22T21:57:46 *** jaiditya|2
154 2012-05-22T22:30:33 *** dwcramer
155 2012-05-22T22:32:14 *** dwcramer
156 2012-05-22T23:19:06 *** dave_largo
157 2012-05-22T23:20:45 *** spy_
158
