1 2012-04-18T02:14:28 *** jaiditya
2 2012-04-18T02:21:02 *** spy
3 2012-04-18T03:21:58 *** czth
4 2012-04-18T03:23:26 <czth> I'm using Moin 1.9 from hg. I can get the local server running, but have no language packs. I tried "make pagepacks" and it fails with "ImportError: No module named support"
5 2012-04-18T03:23:55 <czth> failure is in the import line in "MoinMoin/_tests/maketestwiki.py"
6 2012-04-18T03:24:28 <czth> the import works just fine from the python shell
7 2012-04-18T03:33:59 <czth> ack, moin2 egg seems to be intercepting. agh.
8 2012-04-18T03:44:59 *** sudo_dirk1
9 2012-04-18T03:46:59 *** sudo_dirk
10 2012-04-18T05:36:27 *** moinBot
11 2012-04-18T06:42:51 *** dwcramer
12 2012-04-18T07:30:01 *** kanha
13 2012-04-18T07:30:23 *** kanha_
14 2012-04-18T08:40:43 <MaikuMori> ThomasWaldmann: http://codereview.appspot.com/6055048/
15 2012-04-18T08:51:19 <dreimark> MaikuMori: run test_sourcecode
16 2012-04-18T08:51:58 <MaikuMori> It passed
17 2012-04-18T08:52:13 <dreimark> it can't there are blanks
18 2012-04-18T08:52:17 <dreimark> line 344
19 2012-04-18T08:52:39 <dreimark> ah, sorry, that is a .
20 2012-04-18T08:53:11 <MaikuMori> The only test that failed is copytree and I think it always fails
21 2012-04-18T08:53:12 <dreimark> MaikuMori: line 354
22 2012-04-18T08:53:21 <dreimark> a missing blank
23 2012-04-18T08:54:01 <MaikuMori> I see, it didn't catch it though.
24 2012-04-18T08:55:26 <dreimark> http://hg.moinmo.in/moin/2.0/file/79ec6223a86c/MoinMoin/_tests/test_sourcecode.py#l59
25 2012-04-18T08:57:30 <dreimark> please verify if that is the reason
26 2012-04-18T09:00:13 *** dwcramer
27 2012-04-18T09:04:32 <MaikuMori> It could be the reason, thought the timestamp should have changed when I changed the file.
28 2012-04-18T09:06:59 *** DasIch
29 2012-04-18T09:07:03 <dreimark> normally it should find newer files
30 2012-04-18T09:07:19 <dreimark> MaikuMori: check if your file is catched or not
31 2012-04-18T09:08:00 <MaikuMori> dreimark: I reintroduced the formatting issue and updated the timestamp and it still didn't catch it
32 2012-04-18T09:08:18 <MaikuMori> Where would it cache it?
33 2012-04-18T09:08:51 <dreimark> MaikuMori: set the value temporary to 0
34 2012-04-18T09:09:15 <dreimark> if it didn't find that pep8 issue, file a bug about the pep8 checker
35 2012-04-18T09:10:31 <dreimark> why is app.py in cr, there is no change
36 2012-04-18T09:11:23 <MaikuMori> There is 1 line change
37 2012-04-18T09:11:42 <MaikuMori> + session['user.session_token'] = userobj.get_session_token()
38 2012-04-18T09:12:05 <MaikuMori> Setting it to 0 found issue in the other bigfix I did.
39 2012-04-18T09:12:20 <dreimark> ok, both
40 2012-04-18T09:12:34 <dreimark> so file an issue about the pep8 checker
41 2012-04-18T09:16:06 <MaikuMori> dreimark: Does it find " x =1" type formatting issues for you?
42 2012-04-18T09:18:40 <dreimark> not in 2.0 i compare to 1.9
43 2012-04-18T09:19:37 <dreimark> also not in 1.9
44 2012-04-18T09:19:48 <dreimark> MaikuMori: good catch
45 2012-04-18T09:20:41 <MaikuMori> Should I open it bugreport on bitbucket? I think there was another system for 1.9
46 2012-04-18T09:20:57 <dreimark> ignore 1.9, just add it for 2.0
47 2012-04-18T09:21:33 <MaikuMori> http://codereview.appspot.com/6055048/ should have formatting fixed
48 2012-04-18T09:24:00 <dreimark> I use that python.vim http://moinmo.in/CodingStyle Also if I develop with eclipse I sometimes use it to find my failures
49 2012-04-18T09:29:07 <MaikuMori> I'm using PyDev on linux at the moment, I'll try to add automatic checking to it.
50 2012-04-18T09:29:55 <MaikuMori> Most of my formatting issues are newlines containing spaces, I've never removed the spaces before, but the PEP8 checker doesn't like em.
51 2012-04-18T09:34:50 <MaikuMori> Turns out it has inbuilt pep8 checker, just had to enable it.
52 2012-04-18T09:38:20 <dreimark> MaikuMori: we had a lot of PEP8 issues before moin-1.6
53 2012-04-18T09:56:31 *** gwork
54 2012-04-18T09:58:58 <MaikuMori> dreimark: There are a lot of "E261 at least two spaces before inline comment" error in the source even though this particular error isn't ignored in test_sourcecode.py
55 2012-04-18T09:59:11 <MaikuMori> s/error/errors
56 2012-04-18T10:00:06 <gwork> moin
57 2012-04-18T10:01:52 <dreimark> MaikuMori: if you have a issue added about the pep8 checker add that.
58 2012-04-18T10:02:08 <dreimark> because one can do that in one cs refactoring those at once
59 2012-04-18T10:02:45 <dreimark> it is not important now, we should just not forget about
60 2012-04-18T10:03:09 <dreimark> moin gwork
61 2012-04-18T10:12:27 <gwork> How is life on the development side of moin? It has been a little out of focus for me for a while now, but i'm eager about anything new.
62 2012-04-18T10:16:44 <dreimark> gwork: we are working on moin2, taking part in gsoc
63 2012-04-18T10:17:31 <gwork> dreimark: that's good to hear. how are things going with moin2? Does it get to something releaseable or beta-useable?
64 2012-04-18T10:26:43 <dreimark> well that is the goal
65 2012-04-18T11:09:12 <gwork> That would be really nice. Is there an upgrade path planned? or is it manual?
66 2012-04-18T11:20:13 <dreimark> gwork: we have a mig script from 1.9 to 2.0, see our nice documentation at readthedocs.org/docs/moin-20/en/latest/admin/upgrade.html
67 2012-04-18T11:22:49 <gwork> One of the major drawbacks that many think about moin to whom i show it, is the gui editor. Did you guys manage to get a JS developer to maintain it?
68 2012-04-18T12:16:26 <ThomasWaldmann> gwork: no
69 2012-04-18T12:17:39 <gwork> ThomasWaldmann: that's to bad. any progress on the gui editor then?
70 2012-04-18T12:17:51 <ThomasWaldmann> and while we have ckeditor in moin2, we currently do not support that "gui edit html and transform it to wiki markup" mode yet, it currently is only used to edit html items (that are also stored as html).
71 2012-04-18T12:18:41 <ThomasWaldmann> we do have converters wiki<->html, though, but they likely need a lot more work
72 2012-04-18T12:22:14 <gwork> Hmm. thats interesting!
73 2012-04-18T12:22:57 <gwork> so it's now mix and match of different content types? Also, how do you do that in the database?
74 2012-04-18T12:23:58 <ThomasWaldmann> http://moinmo.in/MoinMoin2.0 see there
75 2012-04-18T12:24:53 <ThomasWaldmann> (one revision always is of one specific content-type)
76 2012-04-18T12:35:03 *** kanha_
77 2012-04-18T13:34:01 <gwork> is see the docs on the converter are updated somewhere around 2010. How's it going with that?
78 2012-04-18T13:35:18 <dreimark> bbl
79 2012-04-18T13:39:07 *** spy
80 2012-04-18T13:39:21 <gwork> ThomasWaldmann: i now use cas for authentication. Is it on the wishlist for m2 as well?
81 2012-04-18T13:41:27 *** Jiaqian
82 2012-04-18T13:51:57 <kanha_> ThomasWaldmann: <email>username@domain</email> works but output is username@domain simply its doesn't have any link.
83 2012-04-18T13:52:50 <kanha_> its for docbook module
84 2012-04-18T13:54:07 <kanha_> but this gives desired output <email><link xlink:href="mailto:foo@example.com">mailto:foo@example.com</link></email>
85 2012-04-18T14:24:55 <dreimark> gwork: add an issue about it to the tracker
86 2012-04-18T14:25:34 <gwork> dreimark: okay, will do
87 2012-04-18T14:43:54 *** kanha__
88 2012-04-18T14:44:12 *** kanha
89 2012-04-18T14:51:05 <ThomasWaldmann> gwork: i have no idea about cas and (afaik) noone is working on that. so, if you want to make it happen, contribute and maintain code for it. :)
90 2012-04-18T15:04:23 <gwork> ThomasWaldmann: felt something like that as i do m2, and sso on moin :D
91 2012-04-18T15:08:31 <gwork> gtg, bb
92 2012-04-18T15:08:36 *** gwork
93 2012-04-18T15:12:21 <kanha_> ThomasWaldmann: http://codereview.appspot.com/6007051
94 2012-04-18T15:34:54 <kanha_> <link xlink:href="mailto:username@domain.com">username@domain.com</link> for example. Works even in PDF output.
95 2012-04-18T15:38:45 <kanha_> it needs review http://codereview.appspot.com/6007051
96 2012-04-18T16:00:39 *** dwcramer
97 2012-04-18T16:02:04 <kanha_> dwcramer:Hi
98 2012-04-18T16:03:26 <dwcramer> Hi kanha_
99 2012-04-18T16:04:19 <kanha_> for moin docbook <email>username@domain</email> works but output is username@domain simply not with link
100 2012-04-18T16:04:46 <kanha_> http://codereview.appspot.com/6007051
101 2012-04-18T16:05:17 <kanha_> needs review
102 2012-04-18T16:05:34 <dwcramer> Ok. Output where?
103 2012-04-18T16:06:11 <dwcramer> If you use the DocBook xsl stylesheets to create html or pdf from a DocBook document, then it will turn <email>user@domain</email> into a link.
104 2012-04-18T16:06:11 <kanha_> on docbook
105 2012-04-18T16:08:09 <kanha_> ok but for 'docbook+xml' format its not turning into a link
106 2012-04-18T16:08:27 <dwcramer> Not sure what you mean by "on docbook"...oh, you mean if you feed the DocBook back to Moin2?
107 2012-04-18T16:09:58 <dwcramer> In that case it's a bug or limitation in the way moin2 is rendering the DocBook...what code it it using to convert the DocBook to html? xslts? straight css?
108 2012-04-18T16:10:13 <kanha_> we select some kind of pages like wiki,creole,html so just like them docbook is one of type
109 2012-04-18T16:11:29 <kanha_> or try test at http://test.moinmo.in/docbook
110 2012-04-18T16:24:25 <kanha_> while <link xlink:href="mailto:username@domain.com">username@domain.com</link> for example. Works even in PDF output.which all are covered in test patch http://codereview.appspot.com/6007051 along with when email works for (docbook)xsl stylesheets to create html or pdf
111 2012-04-18T16:44:45 <dwcramer> Ok. So I think you should be creating good DocBook. If moin doesn't do the right thing with that DocBook, it's a separate issue (Though we can ask ThomasWaldmann his opinion too).
112 2012-04-18T16:45:10 <kanha_> ok
113 2012-04-18T16:45:56 <ThomasWaldmann> the point is to have correct input and output data for the test
114 2012-04-18T16:46:13 <ThomasWaldmann> not to "somehow make it succeed"
115 2012-04-18T16:47:25 <ThomasWaldmann> (and as I don't know much about DB, i can't help you with this)
116 2012-04-18T16:52:28 <dreimark> kanha_: if the test has correct input and output and fails this just means the convertor has a failure
117 2012-04-18T16:53:17 <dreimark> and you have to fix the convertor afterwards
118 2012-04-18T16:53:30 <dreimark> but first you must be sure that your test is valid
119 2012-04-18T16:54:49 <kanha_> as for dockbook the above is the correct input afaik from docbook community and dwcramer
120 2012-04-18T16:56:23 <kanha_> I have also asked this question on docbook mailing list and got a reply that In some processing environments, email may automatically generate a hypertext link (a mailto: URL)."
121 2012-04-18T16:57:13 <dwcramer> I think what is confusing the issue is that <email>user@domain</email> does not render as a link when fed back to moin2. However, if you do <email>user@domain</email> and use the DocBook xslts, it would be rendered as a link.
122 2012-04-18T16:57:19 <kanha_> and while The 1.76.1 stylesheets definitely generate an active mailto:username@domain.com link from <link xlink:href="mailto:username@domain.com">username@domain.com</link> for example. Works for PDF output.
123 2012-04-18T16:57:31 <dwcramer> So the bug is really in the way moin2 handles DocBook.
124 2012-04-18T16:58:09 <dwcramer> I think it's more important to generate clean DocBook than to generate DocBook that moin2 can turn into html.
125 2012-04-18T16:58:41 <dwcramer> I can't think of a use case for generating DocBook from moin and then using moin to render that to html.
126 2012-04-18T16:58:41 <dreimark> http://stackoverflow.com/questions/1402405/docbook-formatting-email-addresses
127 2012-04-18T16:59:03 <dwcramer> I can think of use cases for taking a moin page, rendering DocBook and then feeding it to the DocBook xslts.
128 2012-04-18T16:59:35 <dwcramer> Indeed, there you have it from Norm Walsh himself.
129 2012-04-18T17:01:05 <dwcramer> Let's use DocBook, The Definitive Guide http://www.docbook.org/tdg5/en/html/docbook.html and DocBook XSL: The Complete Guide http://www.sagehill.net/docbookxsl/ (and the DocBook xsls generally) to decide what kind of DocBook to output.
130 2012-04-18T17:02:11 <dwcramer> Another piece of feedback is that a minimal DocBook article would actually look like this: <article xmlns="http://docbook.org/ns/docbook" version="5.0"><title>Ipsum</title><para>lorem</para></article>
131 2012-04-18T17:02:25 <dwcramer> The namespace and version are required on the root element for it to be DocBook 5.0.
132 2012-04-18T17:07:58 *** xjjk
133 2012-04-18T17:08:51 <kanha_> dreimark : <email><ulink url="mailto:SomeUser@someDomain.com"/></email> should be like <email><ulink url="mailto:SomeUser@someDomain.com"/>SomeUser@someDomain.com</email> for the kind output required as per question in http://stackoverflow.com/questions/1402405/docbook-formatting-email-addresses
134 2012-04-18T17:15:06 *** Jiaqian
135 2012-04-18T17:16:28 <dwcramer> <ulink> is a DocBook 4.x element and doesn't exist in DocBook 5.x.
136 2012-04-18T17:17:48 <dwcramer> Is the issue that the DocBook 1.76.1 xsls produce a hyperlink for <email>user@domain</email> but the pdf xsls don't? In that case, I can go fix the pdf xslts for DocBook so in the 1.77.0 release will treat both the same way.
137 2012-04-18T17:19:39 <kanha_> I didn't say like that,I said that and while The 1.76.1 stylesheets definitely generate an active mailto:username@domain.com link from <link xlink:href="mailto:username@domain.com">username@domain.com</link> for example. Works for PDF output.
138 2012-04-18T17:20:29 <dwcramer> Right, and I'd say that's a bug in the DocBook xslts for pdf.
139 2012-04-18T17:21:01 <dwcramer> The html and pdf output should be the same in that respect (there are cases where they do different things because of the different requirements of the format, but this isn't one of them).
140 2012-04-18T17:21:43 <dwcramer> See what Norm Walsh says here (the last answer): http://stackoverflow.com/questions/1402405/docbook-formatting-email-addresses
141 2012-04-18T17:23:57 <kanha_> but I am not sure about it as I didn't know whether email works correctly for pdf or not may be you should check it as you are better at it
142 2012-04-18T17:24:27 <kanha_> yeah,saw Norm's answer
143 2012-04-18T17:29:40 <dreimark> kanha_: he is the author of "the definitive guide"
144 2012-04-18T17:29:44 <dreimark> he knows
145 2012-04-18T17:30:02 <dreimark> bbl
146 2012-04-18T17:31:40 <kanha_> thanks dreimark ,well am quite busy this week(4 days) with exams.gtg,bye :)
147 2012-04-18T17:31:54 *** dwcramer
148 2012-04-18T17:32:24 *** kanha_
149 2012-04-18T17:36:40 *** dwcramer
150 2012-04-18T18:13:04 *** xjjk
151 2012-04-18T18:13:50 *** xjjk
152 2012-04-18T18:17:44 <MaikuMori> ThomasWaldmann: did you take a look at the lastest patch set ( http://codereview.appspot.com/6055048/ )
153 2012-04-18T18:22:03 *** xjjk
154 2012-04-18T18:25:16 *** dave_largo
155 2012-04-18T18:29:17 *** xjjk
156 2012-04-18T18:29:38 <ThomasWaldmann> MaikuMori: review done
157 2012-04-18T18:29:51 <ThomasWaldmann> (getting better :)
158 2012-04-18T20:34:55 <dreimark> spy: any progress with the Blog part of your project?
159 2012-04-18T20:48:04 *** dwcramer
160 2012-04-18T21:00:01 *** dwcramer
161 2012-04-18T21:08:36 *** dwcramer
162 2012-04-18T21:10:57 *** MattMaker
163 2012-04-18T21:11:23 *** MattMaker
164 2012-04-18T21:27:23 *** dwcramer
165 2012-04-18T21:37:05 <spy> dreimark: currently examine the existing blogs
166 2012-04-18T21:39:32 <ThomasWaldmann> do work a bit more visibly (e.g. on your protected wiki page)
167 2012-04-18T21:46:08 *** Trip_
168 2012-04-18T21:49:27 *** MattMaker
169 2012-04-18T21:51:03 <dreimark> spy: have a look at pelican
170 2012-04-18T21:54:23 <spy> ok, thank you
171 2012-04-18T21:58:23 <dreimark> ThomasWaldmann: we should look at pelican-import too
172 2012-04-18T21:58:30 <dreimark> http://pelican.notmyidea.org/en/2.8/importer.html#examples
173 2012-04-18T21:59:16 <dreimark> http://johnmacfarlane.net/pandoc/
174 2012-04-18T21:59:32 <dreimark> released under the GPL.
175 2012-04-18T22:01:43 <dreimark> arg wrong lang
176 2012-04-18T22:14:29 *** dwcramer
177 2012-04-18T22:27:35 *** dwcramer
178 2012-04-18T22:59:03 *** MattMaker
179 2012-04-18T23:05:11 *** dave_largo
180 2012-04-18T23:10:53 *** RogerHaase
181 2012-04-18T23:24:39 *** dwcramer
182 2012-04-18T23:37:33 <RogerHaase> ThomasWaldmann: small change ready for review, changed where js appends flash messages: http://codereview.appspot.com/6065043/
