1 2012-04-15T00:31:47  *** RogerHaase has quit IRC
   2 2012-04-15T05:07:24  *** xjjk has joined #moin-dev
   3 2012-04-15T05:14:25  *** RogerHaase has joined #moin-dev
   4 2012-04-15T06:19:51  *** dwcramer has quit IRC
   5 2012-04-15T06:20:41  *** dwcramer has joined #moin-dev
   6 2012-04-15T06:46:37  *** dwcramer has quit IRC
   7 2012-04-15T06:54:48  *** bilal has quit IRC
   8 2012-04-15T06:55:39  *** RogerHaase has quit IRC
   9 2012-04-15T06:56:19  *** bilal has joined #moin-dev
  10 2012-04-15T08:28:29  *** RogerHaase has joined #moin-dev
  11 2012-04-15T09:16:37  *** kanha_ has joined #moin-dev
  12 2012-04-15T09:20:15  *** RogerHaase has quit IRC
  13 2012-04-15T11:23:13  <dreimark> moin
  14 2012-04-15T12:03:34  <kanha_> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/127/footnote-placing-does-not-work which part of code is responsible for placing this footnote at the bottom of the page?
  15 2012-04-15T12:04:38  <kanha_> eSyr:waldi:^
  16 2012-04-15T12:23:21  <MaikuMori> ThomasWaldmann: any thoughts on https://bitbucket.org/thomaswaldmann/moin-2.0/issue/94/password-change-should-invalidate-sessions#comment-1278578 ?
  17 2012-04-15T12:39:52  *** MattMaker has quit IRC
  18 2012-04-15T12:52:04  <dreimark> kanha_: can you write first a unit test which covers this problem
  19 2012-04-15T12:54:56  <dreimark> and you can search easily by pydev search for that
  20 2012-04-15T12:55:47  <dreimark> bbl
  21 2012-04-15T13:04:38  <ThomasWaldmann> moin
  22 2012-04-15T13:08:24  <kanha_> moin
  23 2012-04-15T13:08:33  <ThomasWaldmann> MaikuMori: i don't think that is true.
  24 2012-04-15T13:09:54  <MaikuMori> ThomasWaldmann: at the moment there is no data saved on the server hence client only session. If you want to invalidate session created from multiple locations you need to save something on the server and invalidate that since you have no access to the client(s).
  25 2012-04-15T13:10:29  <ThomasWaldmann> yes, we have user profiles on the server
  26 2012-04-15T13:11:15  <MaikuMori> I guess you could use timestamp
  27 2012-04-15T13:12:42  <MaikuMori> As in "If password_reset and session_create_time < reset_time: invalidate session"
  28 2012-04-15T13:12:57  <kanha_> dreimark:sory was out for sometime.can you specify(particularise) about what i should write a unit test?
  29 2012-04-15T13:13:49  <MaikuMori> Most likely I could implement that kind of solution.
  30 2012-04-15T13:14:53  <bretonium> kanha_: if I understood him correctly, he wants you to write a unit test which will describe the correct behaviour and will fail
  31 2012-04-15T13:15:04  <ThomasWaldmann> MaikuMori: i don't think you need a timestamp. how about just storing a random "secret" into the user profile and use it for making the session cookie
  32 2012-04-15T13:15:57  <MaikuMori> That's a lot more hassle to implement as the secret your're talking about is implemented in flask as SECRET_KEY config value
  33 2012-04-15T13:16:05  <ThomasWaldmann> (if it is not directly used in the cookie, one could even use the password hash)
  34 2012-04-15T13:17:05  <MaikuMori> It can be done though by making our own http://flask.pocoo.org/docs/api/#session-interface
  35 2012-04-15T13:17:40  <ThomasWaldmann> SECRET_KEY is global, i don't mean that
  36 2012-04-15T13:18:10  <MaikuMori> That's the value which is used by flask to encode the cookie.
  37 2012-04-15T13:19:03  <ThomasWaldmann> what about just storing a random integer into profile and cookie?
  38 2012-04-15T13:19:07  <MaikuMori> Which is from what I understand what you propose, except instead of using global key, we'd use per user key.
  39 2012-04-15T13:19:23  <ThomasWaldmann> if it is same, accept cookie, if not, reject
  40 2012-04-15T13:20:12  <MaikuMori> That's almost the same as timestamp. Still seems like the cleanest way is to make new session interface no matter the method used
  41 2012-04-15T13:20:46  <ThomasWaldmann> a timestamp is more predictable
  42 2012-04-15T13:21:50  <MaikuMori> No one can change it anyway. As it's stored on server and the other is stored in encoded cookie which can't be changed unless you know the secret key
  43 2012-04-15T13:22:05  <ThomasWaldmann> and i currently don't see why we should implement a new session interface, when just putting one int is enough to solve the problem
  44 2012-04-15T13:22:12  <MaikuMori> But that's just 1LOC difference.
  45 2012-04-15T13:23:45  <MaikuMori> You're right. I think I saw session inicialization function somewhere, could do the check there.
  46 2012-04-15T13:26:35  <MaikuMori> Yeah setup_user in app.py
  47 2012-04-15T13:28:06  <MaikuMori> or rather setup_from_session in auth/__init__.py
  48 2012-04-15T13:29:56  * MaikuMori away for a while.
  49 2012-04-15T13:31:13  *** MattMaker has joined #moin-dev
  50 2012-04-15T14:00:21  *** moin1 has joined #moin-dev
  51 2012-04-15T14:04:48  *** moin1 has quit IRC
  52 2012-04-15T14:10:02  *** dwcramer has joined #moin-dev
  53 2012-04-15T14:39:07  *** kanha has quit IRC
  54 2012-04-15T14:39:13  *** kanha has joined #moin-dev
  55 2012-04-15T14:49:31  *** moin0 has joined #moin-dev
  56 2012-04-15T15:04:53  *** moin1 has joined #moin-dev
  57 2012-04-15T15:06:28  *** moin0 has quit IRC
  58 2012-04-15T15:09:13  *** bilal has quit IRC
  59 2012-04-15T15:09:23  *** moin1 has quit IRC
  60 2012-04-15T15:10:55  *** bilal has joined #moin-dev
  61 2012-04-15T15:12:17  *** bilal has quit IRC
  62 2012-04-15T15:17:58  *** bilal has joined #moin-dev
  63 2012-04-15T15:58:17  <kanha_> ThomasWaldmann:eSyr:I have wriiten tests for email for doc module (a part of my proposed project -----under misc (Includes writing proper test for <email> as there are no tests for checking whether the email is valid or not.)) http://codereview.appspot.com/6007051
  64 2012-04-15T15:59:44  <kanha_> it also has minor change under test_link.
  65 2012-04-15T16:05:08  <kanha_> I am still working on that footnote one.As I have exams in next week so I will be spending most of my times on preparation for exam from tomorrow,still i will try work on this whenever i will get some time.
  66 2012-04-15T16:15:45  *** DasIch_ has joined #moin-dev
  67 2012-04-15T16:18:03  *** DasIch has quit IRC
  68 2012-04-15T16:18:03  *** DasIch_ is now known as DasIch
  69 2012-04-15T16:18:05  <kanha_> bbl
  70 2012-04-15T16:18:29  *** kanha_ has quit IRC
  71 2012-04-15T16:32:56  *** RogerHaase has joined #moin-dev
  72 2012-04-15T16:35:31  *** dwcramer has quit IRC
  73 2012-04-15T17:15:04  <RogerHaase> ThomasWaldmann: try 2 of common.js cleanup ready for review:  http://codereview.appspot.com/5989056/
  74 2012-04-15T17:19:19  <RogerHaase> ThomasWaldmann:  fix for #165 +modify fails html5 validation ready for review:  http://codereview.appspot.com/6030048/
  75 2012-04-15T17:20:00  *** dwcramer has joined #moin-dev
  76 2012-04-15T17:30:58  <RogerHaase> kanha:  Hi.  While I wait for Thomas, I can try to help you get started with the footnote bug.  To start, please create a very simple page on http://test.moinmo.in that reproduces the bug.
  77 2012-04-15T17:48:04  <dreimark> i have some tests which are completly ignored not skipped
  78 2012-04-15T17:48:09  <dreimark> e.g. test_html_in_out.py
  79 2012-04-15T17:49:04  *** yufra_ has joined #moin-dev
  80 2012-04-15T17:49:29  <dreimark> test_html_in.py , test_html_out.py
  81 2012-04-15T17:50:24  <dreimark> no skip message
  82 2012-04-15T17:57:22  <RogerHaase> dreimark:  those tests do not run under Windows either:  http://paste.pocoo.org/show/581898/  I count 13 of 19 tests in the converter run.
  83 2012-04-15T17:57:47  <dreimark> ok, sucessfully build lxml fixed that
  84 2012-04-15T17:58:20  <dreimark> but it is bad that one did not get any information about those tests
  85 2012-04-15T18:00:45  <dreimark> RogerHaase: now it looks like this http://paste.pocoo.org/show/581902/
  86 2012-04-15T18:01:36  * dreimark files currently an issue about testing
  87 2012-04-15T18:04:39  <RogerHaase> dreimark: I have lxml 2.2.8 installed in python26 site-packages.  Will try upgrading...
  88 2012-04-15T18:17:36  <dreimark> I needed libxlt1 and libxml2 to built it correctly
  89 2012-04-15T18:17:54  <dreimark> s/libxlt1/libxslt1/
  90 2012-04-15T18:23:54  *** yufra_ has quit IRC
  91 2012-04-15T18:36:21  <RogerHaase> dreimark:  there were no windows binaries for 2.3.4, so the latest I could install was 2.3.  Still only 13 converter tests:  http://paste.pocoo.org/show/581916/
  92 2012-04-15T18:39:02  *** dwcramer has quit IRC
  93 2012-04-15T18:57:30  <ThomasWaldmann> moin
  94 2012-04-15T18:57:36  <ThomasWaldmann> kanha: review done
  95 2012-04-15T18:57:44  <ThomasWaldmann> RogerHaase: looking at the stuff
  96 2012-04-15T19:29:47  <ThomasWaldmann> RogerHaase: ok, done
  97 2012-04-15T19:38:12  <RogerHaase> ThomasWaldmann:  you think it is unlikely that moin2 will support rtl languages?
  98 2012-04-15T19:40:42  <ThomasWaldmann> it will happen when some native user of that will do it
  99 2012-04-15T19:41:33  <ThomasWaldmann> i had looked at rtl stuff now and then (I think we should have it), but I can't work with rtl languages
 100 2012-04-15T19:43:59  <ThomasWaldmann> DasIch: btw, moin has an own copy of subprocess
 101 2012-04-15T19:44:11  <RogerHaase> ThomasWaldmann:  so why remove the dir= now only to put it back later?
 102 2012-04-15T19:44:38  *** sudo_dirk has joined #moin-dev
 103 2012-04-15T19:49:21  *** RogerHaase1 has joined #moin-dev
 104 2012-04-15T19:50:30  *** RogerHaase has quit IRC
 105 2012-04-15T20:01:31  <dreimark> RogerHaase1: http://www.lfd.uci.edu/~gohlke/pythonlibs/ linked from http://stackoverflow.com/questions/3047542/building-lxml-for-python-2-7-on-windows
 106 2012-04-15T20:09:13  <dreimark> bbl
 107 2012-04-15T20:32:32  *** moin2 has joined #moin-dev
 108 2012-04-15T20:55:57  *** czth has joined #moin-dev
 109 2012-04-15T20:57:00  *** jaiditya has joined #moin-dev
 110 2012-04-15T20:57:16  <jaiditya> ThomasWaldmann: moin
 111 2012-04-15T21:00:33  <ThomasWaldmann> hi jaiditya
 112 2012-04-15T21:00:51  <jaiditya> sorry for my absence
 113 2012-04-15T21:01:10  <jaiditya> was having a test
 114 2012-04-15T21:01:21  <jaiditya> in university
 115 2012-04-15T21:03:01  <ThomasWaldmann> jaiditya: see query
 116 2012-04-15T21:05:53  <RogerHaase1> ThomasWaldmann: ready for another review:  http://codereview.appspot.com/5989056/
 117 2012-04-15T21:06:07  *** RogerHaase1 is now known as RogerHaase
 118 2012-04-15T21:09:56  <ThomasWaldmann> RogerHaase: looks ok. some of the smaller (1 line) functions could be optionally inlined.
 119 2012-04-15T21:18:22  *** jaiditya|2 has joined #moin-dev
 120 2012-04-15T21:19:17  *** jaiditya has quit IRC
 121 2012-04-15T21:20:12  <RogerHaase> ThomasWaldmann:  I agree, but I try not to pee on someone else's code to make it smell like mine :)  I will take a second look when I have some more time.
 122 2012-04-15T21:20:38  <ThomasWaldmann> :D
 123 2012-04-15T22:03:45  <RogerHaase> ThomasWaldmann: pushed changes to https://bitbucket.org/RogerHaase/moin-2.0
 124 2012-04-15T22:08:56  *** spy has joined #moin-dev
 125 2012-04-15T22:29:32  *** dwcramer has joined #moin-dev
 126 2012-04-15T22:50:46  <ThomasWaldmann> jaiditya|2: aside from issue tracker entries about theming, you can also fix some obvious stuff you seen when using moin2
 127 2012-04-15T22:53:01  <jaiditya|2> i'll be looking fr it..
 128 2012-04-15T23:39:50  *** czth has quit IRC
 129 2012-04-15T23:52:31  *** dwcramer has quit IRC
 130 2012-04-15T23:54:13  *** dwcramer has joined #moin-dev
 131

MoinMoin: MoinMoinChat/Logs/moin-dev/2012-04-15 (last edited 2012-04-14 22:45:03 by IrcLogImporter)