MoinMoin: MoinMoinChat/Logs/moin-dev/2012-03-09

   1 2012-03-09T03:01:08  *** yufra_ has joined #moin-dev
   2 2012-03-09T03:54:20  *** sudo_dirk has quit IRC
   3 2012-03-09T04:55:55  *** yufra_ has quit IRC
   4 2012-03-09T06:00:37  *** sudo_dirk has joined #moin-dev
   5 2012-03-09T06:56:49  *** sudo_dirk has quit IRC
   6 2012-03-09T08:34:43  <dreimark> moin
   7 2012-03-09T08:34:58  <dreimark> ThomasWaldmann: http://codereview.appspot.com/5744043/
   8 2012-03-09T08:35:07  <dreimark> have a look at update_defaults_by_wikiconfig(
   9 2012-03-09T08:35:33  <dreimark> we should add this to wikiutil
  10 2012-03-09T09:03:40  *** sudo_dirk has joined #moin-dev
  11 2012-03-09T09:38:05  <dreimark> bbl
  12 2012-03-09T09:38:16  <dreimark> sudo_dirk: see comments
  13 2012-03-09T12:41:47  *** greg_f has joined #moin-dev
  14 2012-03-09T13:00:24  *** kanha has joined #moin-dev
  15 2012-03-09T13:14:00  <ThomasWaldmann> dreimark: i don't think so
  16 2012-03-09T13:15:34  <ThomasWaldmann> extensions can just have sane defaults set by the developer of it. if someone wants to have something else, he can give it when calling the macro.
  17 2012-03-09T13:16:39  <ThomasWaldmann> if done like this, the same macro call will always lead to the same result. if everybody sets different default values in wikiconfig, that bloats wikiconfig and also you don't necessarily get the same result for the same content.
  18 2012-03-09T13:20:22  <ThomasWaldmann> and even if one would want it, it could be done more easily and cleanly by just putting a dict into the cfg for the extension and using these values for kw.get('x', defdict.get('x'))
  19 2012-03-09T13:20:59  <ThomasWaldmann> bbl
  20 2012-03-09T13:46:20  *** sravi has joined #moin-dev
  21 2012-03-09T14:16:18  *** sravi has quit IRC
  22 2012-03-09T14:59:46  *** kanha has quit IRC
  23 2012-03-09T15:51:49  *** yufra_ has joined #moin-dev
  24 2012-03-09T16:27:56  <dreimark> ThomasWaldmann: we do that sometimes with builtin functions by overwriting in wikiconfig
  25 2012-03-09T16:28:06  <dreimark> isn't that similiar?
  26 2012-03-09T17:07:17  *** sudo_dirk2 has joined #moin-dev
  27 2012-03-09T17:09:53  <sudo_dirk2> ThomasWaldmann: Getting different results by defaults in wikiconfig is also an advantage. You have a single source for defaults. if the screen resulution changes over the time, you possibly need to change settings.
  28 2012-03-09T17:11:04  <sudo_dirk2> so you have to change lots of pages with the new settings. or change the defaults only. and it is just a possibilty and there is no need to set defaults.
  29 2012-03-09T17:25:26  <sudo_dirk2> i mean a single source outside the plugin, which should not be edited by the user.
  30 2012-03-09T17:25:44  <ThomasWaldmann> sudo_dirk2: not all users have same screen resolution, so you can't use it for that anyway
  31 2012-03-09T17:26:40  <ThomasWaldmann> and as i said: even if one would want that, the proposed solution with inspect is strange and could be done much simpler
  32 2012-03-09T17:26:54  <sudo_dirk2> we are far away from 640x480 which was common years ago
  33 2012-03-09T17:27:10  <ThomasWaldmann> need to go, bbl
  34 2012-03-09T17:27:43  <sudo_dirk2> we talk again later bb
  35 2012-03-09T17:30:10  <sudo_dirk2> just one comment for later: i found the current implementation strage, using a function for setting defaults. if this is set, i think we have to change the function defaults. i would use a dicht for defaults, so a.update(b) can overwrite developer defaults.
  36 2012-03-09T17:31:00  <sudo_dirk2> strage->strange, dicht->dict
  37 2012-03-09T17:37:47  <sudo_dirk2> dreimark: comments changed
  38 2012-03-09T17:43:14  <sudo_dirk2> ThomasWaldmann: what do you think about including plugin.py (beneath wikiconfig.py) which does everything to register the plugin in moin2 and set everything which is needed. similar to apache configs (debian, ubuntu... i don't know if it is in all destributions that way?).
  39 2012-03-09T18:02:49  <sudo_dirk2> bbl
  40 2012-03-09T18:02:54  *** sudo_dirk2 has left #moin-dev
  41 2012-03-09T18:49:03  *** yufra_ has quit IRC
  42