MoinMoin: MoinMoinChat/Logs/moin-dev/2012-03-03

   1 2012-03-03T01:17:54  *** yufra has quit IRC
   2 2012-03-03T01:23:32  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1274:8c275efc6e8c 2.0/MoinMoin/ (11 files in 8 dirs): (log message trimmed)
   3 2012-03-03T01:23:32  <CIA-41> refactored and cleaned up user module code and tests
   4 2012-03-03T01:23:32  <CIA-41> implemented a separate UserProfile class, that just deals with separately
   5 2012-03-03T01:23:32  <CIA-41> holding the profile values (also loading, saving, using defaults, tracking
   6 2012-03-03T01:23:32  <CIA-41> changes).
   7 2012-03-03T01:23:32  <CIA-41> the User object now has a .profile attribute of class UserProfile.
   8 2012-03-03T01:23:33  <CIA-41> for ease of use and compatibility, there are quite some properties defined
   9 2012-03-03T01:23:33  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> namespaces * 1273:c5432dbae81c 2.0/ (21 files in 12 dirs): merged default branch into namespaces branch, validation exposes lots of issues that need cleanup
  10 2012-03-03T02:56:22  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1275:af630156f4ff 2.0/MoinMoin/user.py: user profiles: fix changing of mutable values like quicklinks and subscriptions
  11 2012-03-03T02:56:24  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1276:a3da549dc32e 2.0/MoinMoin/ (script/migration/moin19/import19.py user.py): always use interwiki item names for subscribed items and quicklinks
  12 2012-03-03T03:36:33  *** yufra has joined #moin-dev
  13 2012-03-03T03:56:25  *** sudo_dirk has quit IRC
  14 2012-03-03T06:02:42  *** sudo_dirk has joined #moin-dev
  15 2012-03-03T07:06:37  *** ashlurgen has joined #moin-dev
  16 2012-03-03T07:06:45  <ashlurgen> Hello
  17 2012-03-03T07:26:36  *** yufra has quit IRC
  18 2012-03-03T08:27:26  *** raignarok has joined #moin-dev
  19 2012-03-03T08:55:25  *** raignarok has quit IRC
  20 2012-03-03T09:03:52  *** MattMaker has quit IRC
  21 2012-03-03T10:01:50  *** raignarok has joined #moin-dev
  22 2012-03-03T10:08:21  *** raignarok has quit IRC
  23 2012-03-03T10:39:15  <dreimark> moin
  24 2012-03-03T10:39:18  <dreimark> hi ashlurgen
  25 2012-03-03T10:54:50  <vpv> I got an email from someone in India who would like to take part in GSoC for Moin. I wonder why it was sent to me... Who should I forward it to?
  26 2012-03-03T11:13:24  *** MattMaker has joined #moin-dev
  27 2012-03-03T11:20:35  <dreimark> vpv: forward it to ThomasWaldmann
  28 2012-03-03T11:21:03  <dreimark> hopefulle we get in
  29 2012-03-03T11:30:50  <vpv> alright, I forwarded it to Thomas
  30 2012-03-03T11:43:27  *** raignarok has joined #moin-dev
  31 2012-03-03T11:55:52  <dreimark> bbl
  32 2012-03-03T12:00:43  *** raignarok has quit IRC
  33 2012-03-03T12:31:12  *** kanha has joined #moin-dev
  34 2012-03-03T12:32:36  <kanha> moin
  35 2012-03-03T12:34:14  <kanha> yesterday i posted patch3 for review at http://codereview.appspot.com/5723046/#msg3.
  36 2012-03-03T12:47:43  *** raignarok has joined #moin-dev
  37 2012-03-03T12:59:55  <kanha> how test is used?
  38 2012-03-03T13:07:32  *** raignarok has quit IRC
  39 2012-03-03T13:09:50  <kanha> I have created a patch4 for usersetting bug fixing http://codereview.appspot.com/5723046 .please check it.
  40 2012-03-03T13:19:54  *** raignarok has joined #moin-dev
  41 2012-03-03T13:31:47  <ThomasWaldmann> vpv: some students seem to not have read the faqs/soc rules
  42 2012-03-03T13:32:28  <ThomasWaldmann> kanha: you just run py.test from the toplevel dir
  43 2012-03-03T13:32:56  <kanha> ok
  44 2012-03-03T13:33:13  <kanha> does my patch4 has any problem?
  45 2012-03-03T13:34:45  <ThomasWaldmann> i am just wondering why it shows test_error and test_sourcecode to me
  46 2012-03-03T13:36:08  <kanha> i run those files may be because of that
  47 2012-03-03T13:36:37  <ThomasWaldmann> running doesn't modify files. otoh i don't see a modification there, strange.
  48 2012-03-03T13:36:57  <ThomasWaldmann> can you show me "hg st" output?
  49 2012-03-03T13:39:14  <kanha> http://paste.pocoo.org/show/560262/
  50 2012-03-03T13:40:17  <ThomasWaldmann> yeah, you modified them somehow
  51 2012-03-03T13:40:29  <ThomasWaldmann> please also show "hg diff"
  52 2012-03-03T13:40:35  <kanha> does it matters?
  53 2012-03-03T13:40:57  <ThomasWaldmann> well, you should not commit random unintended modifications
  54 2012-03-03T13:41:52  <kanha> should i create a new patch?
  55 2012-03-03T13:42:05  *** sravi has joined #moin-dev
  56 2012-03-03T13:42:35  <ThomasWaldmann> sravi: did you clone the repo, quickinstall and run moin already?
  57 2012-03-03T13:42:45  <sravi> Yes. I did
  58 2012-03-03T13:43:24  <ThomasWaldmann> ok, great :)
  59 2012-03-03T13:43:56  <ThomasWaldmann> kanha: just look at hg diff
  60 2012-03-03T13:44:38  <sravi>  http://readthedocs.org/docs/moin-20/en/latest/devel/development.html#dom-based-transformations is this the doc to refer for dom
  61 2012-03-03T13:44:50  <kanha> http://paste.pocoo.org/show/560265/
  62 2012-03-03T13:44:56  <ThomasWaldmann> sravi: yes, but it is just very rough
  63 2012-03-03T13:45:17  <sravi> ok. So anything easy to start with?
  64 2012-03-03T13:45:33  <ThomasWaldmann> sravi: MoinMoin.converter - read some src
  65 2012-03-03T13:46:35  <ThomasWaldmann> kanha: ok, that looks valid
  66 2012-03-03T13:47:24  <kanha> :)
  67 2012-03-03T13:47:30  <ThomasWaldmann> as we have no idea why it tells those other 2 files are modified, i suggest you run "hg revert FILE" for the 2 files that have strange modifications
  68 2012-03-03T13:48:00  <kanha> ok i will do it
  69 2012-03-03T13:49:15  <kanha> I did it now?
  70 2012-03-03T13:49:53  <ThomasWaldmann> check hg st again, if it only shows the file you intentionally modified
  71 2012-03-03T13:50:12  <ThomasWaldmann> chech hg diff if it only shows the stuff changed that you wanted to change
  72 2012-03-03T13:51:08  <ThomasWaldmann> run py.test from toplevel dir and see if there are any test fails
  73 2012-03-03T13:51:31  <kanha> for hg st its good http://paste.pocoo.org/show/560269/
  74 2012-03-03T13:52:17  <ThomasWaldmann> (that btw is a generic procedure, one does that ALWAYS before committing)
  75 2012-03-03T13:52:24  <kanha> for hg diff http://paste.pocoo.org/show/560270/
  76 2012-03-03T13:53:56  <ThomasWaldmann> btw, if that is your first commit, did you put your name / email into .hgrc already, so hg knows you?
  77 2012-03-03T13:55:02  <kanha> no i havenot put my name and i havenot used commit command yet
  78 2012-03-03T13:56:04  <ThomasWaldmann> you use linux?
  79 2012-03-03T13:56:14  <kanha> yes
  80 2012-03-03T13:56:40  <ThomasWaldmann> http://moinmo.in/MoinDev/MercurialGuide see "Setting your name"
  81 2012-03-03T13:57:09  <kanha> output of pytest is http://paste.pocoo.org/show/560273/ i didnot understand it
  82 2012-03-03T13:58:13  <kanha> I know settings and committing but havenot commited after making changes to code
  83 2012-03-03T13:58:35  <kanha> thats what i was saying
  84 2012-03-03T14:00:37  <ThomasWaldmann> pip install pytest
  85 2012-03-03T14:01:12  <ThomasWaldmann> (in your moin virtual env)
  86 2012-03-03T14:02:54  <kanha> http://paste.pocoo.org/show/560278/
  87 2012-03-03T14:03:34  <kanha> should i upgrade it?
  88 2012-03-03T14:04:19  <ThomasWaldmann> ah, you always need to activate your virtual env when doing ANYTHING related to moin
  89 2012-03-03T14:04:27  <ThomasWaldmann> that includes running the tests
  90 2012-03-03T14:05:08  <kanha> got it :)
  91 2012-03-03T14:06:57  <sravi> @Thomas: http://readthedocs.org/docs/moin-20/en/latest/_modules/MoinMoin/converter/html_in.html .  Is this the one you asked me to read?
  92 2012-03-03T14:06:57  <moinBot> sravi: Error: "Thomas:" is not a valid command.
  93 2012-03-03T14:08:23  <kanha> yup here it is http://paste.pocoo.org/show/560282/
  94 2012-03-03T14:10:07  *** raignarok has quit IRC
  95 2012-03-03T14:13:07  <ThomasWaldmann> sravi: well, read the file dealing with footnotes
  96 2012-03-03T14:14:12  <ThomasWaldmann> kanha: hmm, the stuff in build/... is a bit strange
  97 2012-03-03T14:14:23  <ThomasWaldmann> looks like it is testing pytest also
  98 2012-03-03T14:15:24  <ThomasWaldmann> but looks good, all passed. so you can commit now. as the commit comment ".... - fixes #XXX"
  99 2012-03-03T14:15:35  <ThomasWaldmann> with XXX = the bug number from the issue tracker
 100 2012-03-03T14:17:06  <ThomasWaldmann> then push to your public repo and make a pull request for me
 101 2012-03-03T14:17:16  <kanha> after commiting how to push means where to push it?
 102 2012-03-03T14:19:10  <kanha> my public repo?
 103 2012-03-03T14:19:19  <sravi> ok
 104 2012-03-03T14:20:01  <kanha> where i can make my public repo?
 105 2012-03-03T14:21:18  <ThomasWaldmann> kanha: you have forked on bitbucket?
 106 2012-03-03T14:21:39  <kanha> no
 107 2012-03-03T14:21:46  <ThomasWaldmann> well, do it :)
 108 2012-03-03T14:21:58  <kanha> link?
 109 2012-03-03T14:22:09  <kanha> and forking mean?
 110 2012-03-03T14:22:31  <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0 click on fork, use moin-2.0 as your repo name also
 111 2012-03-03T14:23:12  <ThomasWaldmann> forking means to clone the repo to your bitbucket repos (you need an account there,for free)
 112 2012-03-03T14:23:39  <ThomasWaldmann> that's nice for publishing your changes
 113 2012-03-03T14:24:47  <kanha> thanks :)
 114 2012-03-03T14:28:56  <ThomasWaldmann> (naming that "forking" is technically correct, but creates a wrong impression for some people who rather think of diverging forks then)
 115 2012-03-03T14:29:37  <kanha> oh :D
 116 2012-03-03T14:49:47  *** sudo_dirk has quit IRC
 117 2012-03-03T14:50:27  *** sudo_dirk has joined #moin-dev
 118 2012-03-03T14:50:40  <sudo_dirk> moin moin
 119 2012-03-03T14:57:19  <ThomasWaldmann> moin2 :)
 120 2012-03-03T15:00:43  *** sravi has quit IRC
 121 2012-03-03T15:10:15  <kanha> for configuring mercurial for setting hgrc file is required so where is it location is it moin-2.0/.hg/hgrc ?
 122 2012-03-03T15:32:21  <sudo_dirk> moin2 is absolutlz correct ThomasWaldmann
 123 2012-03-03T15:34:35  <sudo_dirk> kanha: i think zou are able to use a file in zour home dir as well. google it i found something...
 124 2012-03-03T15:35:16  <kanha> ok
 125 2012-03-03T15:35:34  <sudo_dirk> i have the wrong kezboard setting via vnc, z->y...
 126 2012-03-03T15:37:34  *** kanha has quit IRC
 127 2012-03-03T15:42:39  * ThomasWaldmann refactors the "trusted" auth stuff
 128 2012-03-03T15:43:48  *** raignarok has joined #moin-dev
 129 2012-03-03T16:36:56  *** RogerHaase has joined #moin-dev
 130 2012-03-03T16:38:01  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1277:f0d1cbe58e53 2.0/MoinMoin/ (12 files in 6 dirs): (log message trimmed)
 131 2012-03-03T16:38:01  <CIA-41> refactored "trusted" user handling
 132 2012-03-03T16:38:01  <CIA-41> there is a new .trusted user object attribute now.
 133 2012-03-03T16:38:01  <CIA-41> all authenticator constructors have a parameter trusted=True/False now
 134 2012-03-03T16:38:01  <CIA-41> (implemented in the base class). if one sets it to True, user objects created
 135 2012-03-03T16:38:02  <CIA-41> by that authenticator will have u.trusted = True. The default is False.
 136 2012-03-03T16:38:03  <CIA-41> it is also stored into the session, so user object created from a session
 137 2012-03-03T17:24:55  *** raignarok has quit IRC
 138 2012-03-03T17:31:46  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1278:2c58cbcfeabe 2.0/MoinMoin/ (_tests/test_user.py themes/__init__.py user.py): quicklinks/subscribed_items: use attributes directly, simplify code
 139 2012-03-03T18:12:56  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1279:7c19f8bb7298 2.0/MoinMoin/user.py:
 140 2012-03-03T18:12:56  <CIA-41> user module: misc. cleanup
 141 2012-03-03T18:12:56  <CIA-41> removed unneeded imports, move some imports to global scope
 142 2012-03-03T18:12:56  <CIA-41> improved docstrings / comments
 143 2012-03-03T18:12:56  <CIA-41> included .trusted state in repr of User item
 144 2012-03-03T18:12:57  <CIA-41> renamed some methods (PEP-8)
 145 2012-03-03T18:28:03  *** raignarok has joined #moin-dev
 146 2012-03-03T18:45:22  *** yufra has joined #moin-dev
 147 2012-03-03T18:51:28  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1280:30634c59829b 2.0/MoinMoin/ (_tests/test_user.py apps/frontend/views.py user.py):
 148 2012-03-03T18:51:28  <CIA-41> user bookmarks: simplify code, make .bookmark property
 149 2012-03-03T18:51:28  <CIA-41> to remove a bookmark, set it to None.
 150 2012-03-03T18:51:28  <CIA-41> if a bookmark does not exist, None will be returned.
 151 2012-03-03T19:47:38  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1281:0a70177ce4de 2.0/MoinMoin/ (5 files in 5 dirs): user: changed method names for better PEP8 compliance
 152 2012-03-03T19:55:46  *** yufra has quit IRC
 153 2012-03-03T19:57:32  *** yufra has joined #moin-dev
 154 2012-03-03T20:25:10  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1282:fcf221d8814a 2.0/MoinMoin/ (error.py storage/error.py): cleanup unused / obsolete exception classes
 155 2012-03-03T20:48:36  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> namespaces * 1283:f5e17549eda3 2.0/MoinMoin/ (23 files in 14 dirs): merge default branch into namespaces branch
 156 2012-03-03T22:08:25  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1284:b5a5d35e935d 2.0/MoinMoin/user.py: fix User.__getattr__
 157 2012-03-03T23:16:58  *** RogerHaase has left #moin-dev
 158 2012-03-03T23:48:00  *** yufra has quit IRC
 159