1 2012-02-05T00:43:19 *** not-xjjk
2 2012-02-05T00:45:20 *** xjjk
3 2012-02-05T02:13:19 <CIA-64> Thomas Waldmann <tw AT waldmann-edv DOT de> namespaces * 1263:bf3ef935aced 2.0/ (6 files in 6 dirs): merged from default branch into namespaces branch
4 2012-02-05T03:06:37 *** raignarok_
5 2012-02-05T03:11:01 *** raignarok
6 2012-02-05T03:19:19 *** raignarok_
7 2012-02-05T03:59:19 *** sudo_dirk
8 2012-02-05T05:03:05 *** MattMaker
9 2012-02-05T06:06:29 *** sudo_dirk
10 2012-02-05T06:16:25 *** MattMaker
11 2012-02-05T08:32:17 *** MattMaker
12 2012-02-05T08:34:33 *** MattMaker
13 2012-02-05T09:03:18 *** qxcv
14 2012-02-05T09:19:49 *** franklin
15 2012-02-05T10:23:51 *** helixfelix
16 2012-02-05T10:37:32 * dreimark 1.9.4 has problem in SystemInfo with py2.6
17 2012-02-05T10:37:45 <dreimark> silent crash without traceback
18 2012-02-05T10:43:05 *** greg_f
19 2012-02-05T10:44:06 <dreimark> Speicherzugriffsfehler
20 2012-02-05T10:44:34 <dreimark> my SyncJob page works with py2.6 but not with py2.7
21 2012-02-05T10:44:44 * dreimark is comparing changes in py now
22 2012-02-05T11:13:31 *** raignarok_
23 2012-02-05T11:18:06 *** raignarok_
24 2012-02-05T11:23:10 *** raignarok
25 2012-02-05T11:44:50 *** raignarok
26 2012-02-05T12:13:21 *** sudo_dirk2
27 2012-02-05T12:14:32 <sudo_dirk2> dreimark: i added a xapian workaround for arnica. it works for my desktop moin where i added xapian :-). see http://codereview.appspot.com/5553068/diff2/10001:13001/data/plugin/parser/text_x_arnica.py
28 2012-02-05T12:16:23 <sudo_dirk2> and it is quite simple
29 2012-02-05T12:33:53 <dreimark> sudo_dirk2: :)
30 2012-02-05T12:36:40 <dreimark> sudo_dirk2: can you exchange the pull request with the new solved issues
31 2012-02-05T12:36:50 <dreimark> i get a 21 day old one
32 2012-02-05T12:37:42 * dreimark looks at ws with 1.9.2
33 2012-02-05T12:52:26 <sudo_dirk2> dreimark: do i have to do a new request or just check in the new file?
34 2012-02-05T12:52:42 <dreimark> new request please
35 2012-02-05T12:52:57 <sudo_dirk2> ok. you will get one ;-)
36 2012-02-05T12:53:19 <dreimark> and may be it is easier to remove the bb fork make a new one and apply the good changes
37 2012-02-05T13:14:35 *** raignarok
38 2012-02-05T13:19:17 *** qxcv
39 2012-02-05T13:30:07 <sudo_dirk2> dreimark: done. thanks for your help on the way.
40 2012-02-05T13:30:49 * dreimark looks - and will try the documentation page
41 2012-02-05T14:02:00 <dreimark> sudo_dirk2: do i see it right that you have now again only one changeset?
42 2012-02-05T14:03:25 <dreimark> you have added a feature and a bug or design fix
43 2012-02-05T14:08:23 <dreimark> oh, may be the interface is just confusing. i have still two requests
44 2012-02-05T14:09:37 <dreimark> btw. the content of the help page http://moinmo.in/ReimarBauer?action=AttachFile&do=get&target=HelpOnArnica.zip
45 2012-02-05T14:13:26 <sudo_dirk2> dreimark: no, i deleted the old fork and added in the new just the feature changes. no bug fixes are in there at the moment.
46 2012-02-05T14:13:56 <dreimark> yes, seen meanwhile. i try to reject the first pull request. no idea if it cummulates and purges mine
47 2012-02-05T14:14:50 <sudo_dirk2> i was wondering too cause the request was still there. it was unexpected for me....
48 2012-02-05T14:26:04 <ThomasWaldmann> re
49 2012-02-05T14:27:32 <sudo_dirk2> wb
50 2012-02-05T14:28:47 <CIA-64> sudo_dirk<d.alders@arcor.de> default * 569:df77d4563af1 extensions/data/plugin/parser/text_x_arnica.py: Added album-overview functionality.
51 2012-02-05T14:29:23 <dreimark> sudo_dirk2: please describe the paramteter on the HelpOnArnica page
52 2012-02-05T14:30:24 *** vedranm
53 2012-02-05T14:32:56 <ThomasWaldmann> dreimark: SystemInfo works for me. tried moinmo.in/SystemInfo - it took quite a while as I am superuser there, so it collects a lot of information (py 2.6.6, moin 1.9.current).
54 2012-02-05T14:33:12 <dreimark> hmm
55 2012-02-05T14:34:11 <ThomasWaldmann> where and with what python did you get the crash?
56 2012-02-05T14:49:30 <dreimark> can't reproduce anymore works now (me has 2.6.7 (r267:88850, Aug 11 2011, 12:18:09) [GCC 4.6.1])
57 2012-02-05T14:50:19 * dreimark cleans cache again
58 2012-02-05T14:51:35 <dreimark> now it works - i have had it many time (strange)
59 2012-02-05T14:53:25 <vedranm> ThomasWaldmann: hi
60 2012-02-05T14:53:39 <vedranm> I'm close to finishing % -> .format() fixes
61 2012-02-05T14:53:46 <vedranm> I have an error that I can't figure out
62 2012-02-05T14:53:50 <vedranm> can you take a look?
63 2012-02-05T14:54:55 <ThomasWaldmann> hi vedranm. sure.
64 2012-02-05T14:56:21 <vedranm> ThomasWaldmann: where should I upload it?
65 2012-02-05T14:57:19 <ThomasWaldmann> put the changeset on codereview and add a comment to the place that is unclear
66 2012-02-05T14:57:45 <vedranm> ok
67 2012-02-05T14:58:18 <sudo_dirk2> dreimark: added this to my todos ;-)
68 2012-02-05T14:58:54 <sudo_dirk2> means hope i do it today^^
69 2012-02-05T15:03:12 <vedranm> ThomasWaldmann: it's here http://codereview.appspot.com/5630058/
70 2012-02-05T15:03:37 <vedranm> it's commented with # vedranm ERROR this breaks
71 2012-02-05T15:06:57 <dreimark> where is the comment ?
72 2012-02-05T15:06:59 <ThomasWaldmann> ok, looking at it
73 2012-02-05T15:07:14 <dreimark> i have always 0 comments
74 2012-02-05T15:07:45 <ThomasWaldmann> vedranm: ^^ yes, i also see no comment
75 2012-02-05T15:08:01 <vedranm> are you looking at: http://codereview.appspot.com/download/issue5630058_1.diff
76 2012-02-05T15:08:14 <vedranm> or should I have added a comment via codereview?
77 2012-02-05T15:08:37 <dreimark> yes, because answering is easier there
78 2012-02-05T15:08:48 <vedranm> dreimark: oh, ok
79 2012-02-05T15:12:10 <dreimark> and may be also what it produces
80 2012-02-05T15:12:19 <dreimark> or how the breakage behave
81 2012-02-05T15:13:04 <vedranm> dreimark: I'm using py.test
82 2012-02-05T15:13:20 <vedranm> haven't tried anything in production yet since tests fail
83 2012-02-05T15:13:22 <vedranm> UnicodeEncodeError: 'ascii' codec can't encode characters in position 26-703: ordinal not in range(128)
84 2012-02-05T15:13:36 <vedranm> is the error message
85 2012-02-05T15:13:41 <vedranm> in ERROR collecting MoinMoin/converter/_tests/test_moinwiki19_in.py
86 2012-02-05T15:16:32 <sudo_dirk2> added my bug-fix to cr: http://codereview.appspot.com/5625055
87 2012-02-05T15:16:46 <sudo_dirk2> for arnica tool-bar
88 2012-02-05T15:22:13 <vedranm> ThomasWaldmann: any idea?
89 2012-02-05T15:22:26 <vedranm> I tried adding .encode('utf-8') but that didn't work
90 2012-02-05T15:26:46 <ThomasWaldmann> vedranm: you are trying to fix that .format related issue from the issue tracker, right?
91 2012-02-05T15:26:55 <vedranm> ThomasWaldmann: yes
92 2012-02-05T15:27:00 <vedranm> replace all % stuff
93 2012-02-05T15:27:06 <vedranm> we fixed %s
94 2012-02-05T15:27:23 <vedranm> the outstanding ones are %(foo)s and %d %X %f etc.
95 2012-02-05T15:27:59 <ThomasWaldmann> is it issue #99?
96 2012-02-05T15:28:13 <vedranm> let me check
97 2012-02-05T15:29:35 <vedranm> yes
98 2012-02-05T15:29:39 <vedranm> it's #99
99 2012-02-05T15:30:56 <ThomasWaldmann> i updated #99, please read.
100 2012-02-05T15:31:27 <ThomasWaldmann> (sorry, it seems you didn't see #124)
101 2012-02-05T15:32:10 <vedranm> ThomasWaldmann: yeah, that happens
102 2012-02-05T15:32:18 <vedranm> on Croatian characters as well
103 2012-02-05T15:32:23 <vedranm> čđšđđž
104 2012-02-05T15:32:30 <ThomasWaldmann> it happens on anythin except ascii
105 2012-02-05T15:32:36 <vedranm> yes
106 2012-02-05T15:32:51 <ThomasWaldmann> make sure you fully understand how to fix #124
107 2012-02-05T15:33:10 <ThomasWaldmann> as you'll need to do both #99 and #124 at the same time
108 2012-02-05T15:33:15 <vedranm> suoke
109 2012-02-05T15:33:21 <vedranm> sure, ok :D
110 2012-02-05T15:33:26 <ThomasWaldmann> otherwise it might get worse as it is now
111 2012-02-05T15:34:02 <vedranm> wait, this got broken by str.format?
112 2012-02-05T15:34:04 <ThomasWaldmann> (it is really a pain that the python devs didn't consider this)
113 2012-02-05T15:34:44 <ThomasWaldmann> the point is that if you are using str.format, you are likely already in trouble
114 2012-02-05T15:35:03 <vedranm> because format can't take unicode stuff or?
115 2012-02-05T15:35:05 <ThomasWaldmann> except if you made sure that all args are str also and not unicode
116 2012-02-05T15:35:24 <vedranm> oh, ok
117 2012-02-05T15:35:34 <ThomasWaldmann> so, usually you want to use unicode.format
118 2012-02-05T15:35:34 <vedranm> but in that particular case I commented on
119 2012-02-05T15:35:44 <vedranm> it's r"" string
120 2012-02-05T15:35:54 <vedranm> what should be done then?
121 2012-02-05T15:35:56 <ThomasWaldmann> give me a link, i did not find it
122 2012-02-05T15:36:11 <vedranm> let me add a comment
123 2012-02-05T15:36:16 *** sudo_dirk2
124 2012-02-05T15:37:35 <vedranm> ThomasWaldmann: ok, added
125 2012-02-05T15:40:04 <ThomasWaldmann> you need to use ur"""...
126 2012-02-05T15:40:30 <vedranm> good
127 2012-02-05T15:40:34 <vedranm> didn't know this existed
128 2012-02-05T15:40:49 <vedranm> so, the idea is to use u"" instead of "" everywhere or?
129 2012-02-05T15:40:57 <ThomasWaldmann> almost
130 2012-02-05T15:41:23 <ThomasWaldmann> of course you don't do that if you want a str and only have str args
131 2012-02-05T15:42:02 <ThomasWaldmann> but as soon as translatable text or user content is involved, you can safely assume unicode
132 2012-02-05T15:42:20 <vedranm> ok, good
133 2012-02-05T15:42:40 <ThomasWaldmann> if it gets rather lowlevel, like filenames or http headers, be careful. ask in case of doubt.
134 2012-02-05T15:44:08 <ThomasWaldmann> i have done a part of the review, but then stopped as it often was the same stuff.
135 2012-02-05T15:44:28 <ThomasWaldmann> have a look on what I commented.
136 2012-02-05T15:45:23 <vedranm> k
137 2012-02-05T15:46:00 <dreimark> just a question about the new syntax
138 2012-02-05T15:46:18 <dreimark> if there is nothing as format given it means automatically string?
139 2012-02-05T15:46:34 <dreimark> {memory} == {memory:s} ?
140 2012-02-05T15:47:11 <vedranm> dreimark: I don't think so
141 2012-02-05T15:47:38 <vedranm> {memory:s} would replace %(memory)s % str(memory)
142 2012-02-05T15:50:13 <dreimark> http://codereview.appspot.com/5630058/patch/1/46
143 2012-02-05T15:50:51 <dreimark> i am asking because here you always have ignored :s
144 2012-02-05T15:51:41 <vedranm> dreimark: yes, I use it only if it's in original code
145 2012-02-05T15:53:07 <vedranm> ThomasWaldmann: regarding MoinMoin/_tests/test_wikiutil.py
146 2012-02-05T15:53:23 <vedranm> testParentItemName()
147 2012-02-05T15:53:42 <vedranm> there is the same bug in original code?
148 2012-02-05T15:54:40 <dreimark> bbl
149 2012-02-05T15:57:07 <ThomasWaldmann> dreimark: http://docs.python.org/library/string.html#format-string-syntax
150 2012-02-05T15:58:29 <ThomasWaldmann> vedranm: in case of doubt, try if it works :)
151 2012-02-05T16:01:13 <vedranm> I doubt
152 2012-02-05T16:01:50 <vedranm> but if I'm going to fix it, then it would be nice to make it consistent with the rest of the test
153 2012-02-05T16:04:17 <ThomasWaldmann> you can also put some # XXX or TODO there
154 2012-02-05T16:04:42 <ThomasWaldmann> when working on one issue, one should avoid getting distracted by other stuff
155 2012-02-05T16:05:50 <vedranm> ok
156 2012-02-05T16:15:44 <ThomasWaldmann> Subj: [#PUP-109302]: Complaint due to wiki spam originating from your IPs
157 2012-02-05T16:15:52 <ThomasWaldmann> The servers has been suspended.
158 2012-02-05T16:16:29 <ThomasWaldmann> ^^ looks like we might get some less spam until that guy has moved to new servers.
159 2012-02-05T16:41:20 <sudo_dirk> dreimark: my comments at http://codereview.appspot.com/5625055/
160 2012-02-05T16:41:28 <sudo_dirk> bbl
161 2012-02-05T16:47:57 <vedranm> ThomasWaldmann: got it down to to Failuers
162 2012-02-05T16:48:11 <vedranm> I can't figure out those
163 2012-02-05T16:48:19 <vedranm> can you take a look?
164 2012-02-05T16:54:32 <ThomasWaldmann> yes
165 2012-02-05T16:55:26 <ThomasWaldmann> where?
166 2012-02-05T16:56:52 <vedranm> ThomasWaldmann: http://codereview.appspot.com/5627053/
167 2012-02-05T16:57:49 <ThomasWaldmann> btw, if you post the same stuff in a newer version, you can specific the old id to upload.py so it reuses it
168 2012-02-05T16:58:29 <ThomasWaldmann> and if you want me to look at something specific, give a specific url
169 2012-02-05T16:59:10 <vedranm> ThomasWaldmann: didn't know about old id
170 2012-02-05T16:59:15 <vedranm> let me retry
171 2012-02-05T16:59:17 <vedranm> it had an error
172 2012-02-05T17:00:20 <vedranm> ThomasWaldmann: it would be great if you could try py.test with it and see two tests that fail
173 2012-02-05T17:00:38 <ThomasWaldmann> (reusing is the preferred way as then you can see the changes between the versions)
174 2012-02-05T17:01:30 <ThomasWaldmann> ok
175 2012-02-05T17:02:05 <vedranm> ThomasWaldmann: ok, let me try something then
176 2012-02-05T17:02:10 <vedranm> let's try to reuse old issue
177 2012-02-05T17:02:56 <vedranm> ok, deleting is easy
178 2012-02-05T17:03:33 <ThomasWaldmann> deleting?
179 2012-02-05T17:04:29 <vedranm> ThomasWaldmann: yep
180 2012-02-05T17:04:34 <vedranm> it's at http://codereview.appspot.com/5630058/
181 2012-02-05T17:04:50 <vedranm> upload.py complained about Base files missing on new issue anyway
182 2012-02-05T17:09:48 <ThomasWaldmann> there seems to be a syntax problem in ldap_login.py
183 2012-02-05T17:10:07 <ThomasWaldmann> E TokenError: ('EOF in multi-line statement', (265, 0))
184 2012-02-05T17:14:45 <ThomasWaldmann> + return ContinueLogin(user_obj, _("LDAP server {server} failed.".format(server=server))
185 2012-02-05T17:14:49 <vedranm> ok
186 2012-02-05T17:14:54 <vedranm> what about 200 vs 500?
187 2012-02-05T17:15:07 <vedranm> I should probably add u" somewhere
188 2012-02-05T17:15:11 <ThomasWaldmann> after failed." there is a ) missing
189 2012-02-05T17:15:12 <vedranm> but I can't see where
190 2012-02-05T17:15:32 <vedranm> ThomasWaldmann: wow, good catch
191 2012-02-05T17:16:02 <ThomasWaldmann> _(u"...")
192 2012-02-05T17:16:38 <ThomasWaldmann> not sure what you mean with 200 vs 500
193 2012-02-05T17:19:21 *** greg_f
194 2012-02-05T17:19:42 <vedranm> ThomasWaldmann: the other error
195 2012-02-05T17:19:59 <vedranm> produces HTTP 500 where HTTP 200 is expected
196 2012-02-05T17:20:18 <vedranm> and, by the way, where is _( defined?
197 2012-02-05T17:20:33 <ThomasWaldmann> see the imports
198 2012-02-05T17:20:48 <ThomasWaldmann> and in my last test run, i only had 1 failure
199 2012-02-05T17:22:30 <vedranm> ThomasWaldmann: ldap one?
200 2012-02-05T17:22:58 <ThomasWaldmann> python-ldap failed to install into the virtualenv for me
201 2012-02-05T17:23:40 <ThomasWaldmann> but the error i quoted above was the one it found with the pep8 checker
202 2012-02-05T17:24:43 <ThomasWaldmann> what does hg id say in your local repo?
203 2012-02-05T17:26:34 <vedranm> $ hg tip
204 2012-02-05T17:26:34 <vedranm> changeset: 1263:bf3ef935aced
205 2012-02-05T17:26:46 <vedranm> wait
206 2012-02-05T17:26:47 <vedranm> $ hg id
207 2012-02-05T17:26:48 <vedranm> 65d36909177b+
208 2012-02-05T17:27:39 <ThomasWaldmann> yes, that is correct (you are on default branch)
209 2012-02-05T17:28:36 <ThomasWaldmann> maybe paste the test output into pastebin and tell me the line number you mean
210 2012-02-05T17:30:54 <vedranm> ok, second
211 2012-02-05T17:33:24 <vedranm> ThomasWaldmann: http://paste.pocoo.org/show/546248/
212 2012-02-05T17:33:33 <vedranm> that's after fixing LDAP
213 2012-02-05T17:39:27 <vedranm> sorry ThomasWaldmann but I have to leave now
214 2012-02-05T17:39:52 <vedranm> we will finish this off at some point this week
215 2012-02-05T17:40:04 <vedranm> I don't want to submit half-broken code
216 2012-02-05T17:40:09 <vedranm> thanks for your help
217 2012-02-05T17:42:34 <ThomasWaldmann> ValueError: unsupported format character 'B' (0x42) at index 43
218 2012-02-05T17:42:57 <ThomasWaldmann> the strange thing about that is that there is no B in the original string
219 2012-02-05T17:43:35 <ThomasWaldmann> but the ) is at the wrong place
220 2012-02-05T17:44:08 <ThomasWaldmann> always do _(u"...").format(...)
221 2012-02-05T17:44:17 <ThomasWaldmann> vedranm: ^^
222 2012-02-05T18:47:13 <vedranm> ThomasWaldmann: back
223 2012-02-05T18:47:19 <vedranm> %2B is +
224 2012-02-05T18:47:30 <vedranm> i.e. /+login becomes /%2Blogin
225 2012-02-05T18:47:38 <vedranm> but I don't understand why
226 2012-02-05T18:49:54 <ThomasWaldmann> maybe ignore + and %2B stuff, that is some fluctuation in werkzeug
227 2012-02-05T18:50:47 <ThomasWaldmann> before and including 0.8.1 it somehow was +, 0.8.2 and .3 use %2B (= quoted +)
228 2012-02-05T18:53:23 <vedranm> ThomasWaldmann: so it will break even without a patch?
229 2012-02-05T18:53:25 <vedranm> let me check that
230 2012-02-05T18:54:53 <vedranm> ThomasWaldmann: it doesn't break
231 2012-02-05T18:54:58 <vedranm> it's not a fluctuation
232 2012-02-05T18:55:29 <vedranm> you said that ) is in the wrong place?
233 2012-02-05T18:55:32 <vedranm> which file, which line?
234 2012-02-05T18:59:01 <ThomasWaldmann> "/home/vedranm/moin/2.0/MoinMoin/auth/__init__.py", line 253
235 2012-02-05T19:00:55 <vedranm> ThomasWaldmann: ok, I see the issue now
236 2012-02-05T19:00:55 <vedranm> thanks
237 2012-02-05T19:03:34 <vedranm> ThomasWaldmann: wait, I don't
238 2012-02-05T19:03:57 <ThomasWaldmann> first translate, then replace placeholders
239 2012-02-05T19:06:02 <vedranm> wee, it passes all the tests :-)
240 2012-02-05T19:06:30 <sudo_dirk> just a quick one? i want to get in moin2. when i want a new item, do i need a converter? or is there a possibility to handle things in a new item? or am i completely wrong?
241 2012-02-05T19:06:36 <vedranm> ok, I will finish off the patch tomorrow regarding _(u"") stuff
242 2012-02-05T19:06:41 <vedranm> and upload it to codereview
243 2012-02-05T19:07:53 <ThomasWaldmann> vedranm: yay! :) and thanks.
244 2012-02-05T19:08:32 <ThomasWaldmann> sudo_dirk: if you want a new contenttype being handled in some special way, then you need a new converter.
245 2012-02-05T19:09:19 <sudo_dirk> ThomasWaldmann: and when i need a new editor as well, is that in the item?
246 2012-02-05T19:09:23 <ThomasWaldmann> but, that is not the only way to create some output. you can also just have a new "view", that does not need an item.
247 2012-02-05T19:10:04 <ThomasWaldmann> if that editor is the only way to edit that type, yes, that would be a new item class
248 2012-02-05T19:12:03 <sudo_dirk> there is a render section in the item. is that called when creating the view of a page?
249 2012-02-05T19:12:15 <sudo_dirk> _render_data ???
250 2012-02-05T19:14:26 <ThomasWaldmann> yes
251 2012-02-05T19:16:14 <sudo_dirk> ok, then i add the item class in __init__.py, i tried use an external file like in converter. i think i start better step by step.
252 2012-02-05T19:16:18 <sudo_dirk> ThomasWaldmann: thanks
253 2012-02-05T19:17:18 <ThomasWaldmann> well, first get clear about what you want to do
254 2012-02-05T19:18:14 <ThomasWaldmann> if it is about the issue/todo tracking, then you do not need a converter or editor at all (at least not at the beginning)
255 2012-02-05T19:20:57 <sudo_dirk> so, the main issue is learn about the possibilities. it is not really for a special "project" yet.
256 2012-02-05T19:25:02 <sudo_dirk> ThomasWaldmann: for the todo, i want to add an editor (after getting the main functionailty). if some data is in metadata, i think it will be much easier to not edit metadata by hand.
257 2012-02-05T19:26:06 <sudo_dirk> ThomasWaldmann: and i think i also need a new diff, cause of the differences in metadata
258 2012-02-05T19:26:24 <ThomasWaldmann> that's step N
259 2012-02-05T19:26:36 <ThomasWaldmann> first do step 1, complete specs
260 2012-02-05T19:27:06 <sudo_dirk> ThomasWaldmann: i just a picture of the interface to the user ;-)
261 2012-02-05T19:27:12 <sudo_dirk> +have
262 2012-02-05T19:27:13 <ThomasWaldmann> after that, one can enter some items according to that spec and work on some view to visualize the list
263 2012-02-05T19:28:25 <sudo_dirk> sure, this is the first step. i have some other plugins running and therefore i want to learn about the possibilities in moin2
264 2012-02-05T19:28:47 <sudo_dirk> i handle my adressbook in moin ;-)
265 2012-02-05T19:29:37 <ThomasWaldmann> just make sure not to do it the old way. in moin1 we often had to have a page with some macro on it to do something. that's not the case in moin2.
266 2012-02-05T19:30:48 <sudo_dirk> what exactly do you mean?
267 2012-02-05T19:31:05 <ThomasWaldmann> well, look at RecentChanges page in 1.9
268 2012-02-05T19:31:39 <ThomasWaldmann> (at the page contents http://moinmo.in/RecentChanges?action=raw )
269 2012-02-05T19:32:13 <ThomasWaldmann> you see that it is a page living in the wiki page storage, but it's main function is in the macro
270 2012-02-05T19:32:52 <ThomasWaldmann> if you compare that with moin2: we just have /+history view there (and there is no page stored in the storage for that)
271 2012-02-05T19:34:01 <sudo_dirk> ah, see what you mean. (views)
272 2012-02-05T19:34:52 <sudo_dirk> ok. bbl.
273 2012-02-05T19:35:59 <sudo_dirk> just one at the end. recent changes, could't this be an action to get rid of the page?
274 2012-02-05T19:36:14 <dreimark> yes
275 2012-02-05T19:36:23 <dreimark> but it would be boring without jinja2
276 2012-02-05T19:36:52 <dreimark> sudo_dirk: i look at the mimetype issue with that image load button
277 2012-02-05T19:38:09 <sudo_dirk> dreimark: at least firefox and iceweasel does it
278 2012-02-05T19:38:55 <sudo_dirk> i can check iexplorer and konqueror
279 2012-02-05T19:39:18 <sudo_dirk> but iceweasel suggests html as extension
280 2012-02-05T19:39:25 <dreimark> i know
281 2012-02-05T19:39:42 <sudo_dirk> i check the two others later...
282 2012-02-05T19:39:46 <sudo_dirk> bbl
283 2012-02-05T19:39:48 <dreimark> you don'T need
284 2012-02-05T19:40:12 <dreimark> i just implement it correctly
285 2012-02-05T19:47:09 <sudo_dirk> which change? both? in cr.
286 2012-02-05T19:50:27 <dreimark> we have to just use the normal 1.9 logic
287 2012-02-05T19:50:41 <dreimark> we need <input type="hidden" name="do" value="view">
288 2012-02-05T19:51:17 <dreimark> that fixes two issues
289 2012-02-05T19:51:28 <dreimark> one with the download the other with the theme
290 2012-02-05T19:52:17 * dreimark pushes that
291 2012-02-05T19:58:10 <CIA-64> Reimar Bauer <rb.proj AT googlemail DOT com> default * 571:01fc8ba9809b extensions/data/plugin/ (macro/arnica.py parser/text_x_arnica.py): arnica: updated copyright
292 2012-02-05T19:58:11 <CIA-64> Reimar Bauer <rb.proj AT googlemail DOT com> default * 570:bf8bae241ec9 extensions/data/plugin/parser/text_x_arnica.py: arnica: fix download link for load image
293 2012-02-05T20:04:26 <dreimark> sudo_dirk: i updated bb too, have had first to install my key again, because of system upgrade
294 2012-02-05T20:05:44 <dreimark> btw. your credits of http://cia.vc/stats/author/sudo_dirk%3Cd.alders%40arcor.de%3E
295 2012-02-05T20:09:34 *** raignarok
296 2012-02-05T20:10:45 <dreimark> ThomasWaldmann: ohloh has a new theme. may be more updates
297 2012-02-05T20:11:49 <dreimark> https://www.ohloh.net/p/moinmoin
298 2012-02-05T20:17:28 <ThomasWaldmann> at least we are mostly written in python now :D
299 2012-02-05T20:18:04 <dreimark> I like this line "Extremely well-commented source code"
300 2012-02-05T20:18:45 <ThomasWaldmann> sept 2005, project receives the first commit
301 2012-02-05T20:18:57 <ThomasWaldmann> yeah, in hg ^^
302 2012-02-05T20:19:32 <dreimark> I joined in 2006
303 2012-02-05T20:21:56 <ThomasWaldmann> end 2005 was first 1.9 commit
304 2012-02-05T20:22:19 <ThomasWaldmann> stats are flawed because ohloh only has 1.9 and 2.0
305 2012-02-05T20:22:32 <sudo_dirk> dreimark: i never heard about cia.vc what is that.
306 2012-02-05T20:22:45 <ThomasWaldmann> they are watching us
307 2012-02-05T20:23:16 <dreimark> ThomasWaldmann: yes at least we have the last 6 years there
308 2012-02-05T20:24:45 <sudo_dirk> omg is that big brother?
309 2012-02-05T20:25:43 <dreimark> http://code.google.com/p/cia-vc/
310 2012-02-05T20:26:29 <ThomasWaldmann> ehrm, no, it is since 1.5 in that repo
311 2012-02-05T20:28:28 <ThomasWaldmann> dreimark: are you still working on bug fixes for 1.9?
312 2012-02-05T20:28:56 <sudo_dirk> so this is cause moin is on a internet version control...
313 2012-02-05T20:29:35 <dreimark> ThomasWaldmann: i am not sure how to handle the httplib change
314 2012-02-05T20:29:40 <dreimark> http://bugs.python.org/issue12398
315 2012-02-05T20:29:52 <dreimark> that causes some of the problems we have
316 2012-02-05T20:30:23 <dreimark> the simplest solution is to use that patched version in supprot
317 2012-02-05T20:31:10 <dreimark> because of some other changes for 2.7 we should not copy the old one
318 2012-02-05T20:31:19 <dreimark> I think that may make more problems
319 2012-02-05T20:32:12 <ThomasWaldmann> dreimark: can you just try the latest 2.6 httplib in support?
320 2012-02-05T20:32:18 <dreimark> the problems because of wikisync tag mismatch is not easy to solve in 1.9
321 2012-02-05T20:32:53 <dreimark> I gues we have to live with that problem until we add it to m2
322 2012-02-05T20:33:02 <dreimark> yes
323 2012-02-05T20:45:58 <sudo_dirk> dreimark: http://codereview.appspot.com/5625055/; the webnail fix is left...
324 2012-02-05T20:48:48 <dreimark> sudo_dirk: ok, can you make a new attempt. I have never had the idea that one wants to save a webnail
325 2012-02-05T20:49:19 <dreimark> there is only the name wrong, or?
326 2012-02-05T20:50:44 <dreimark> the same name issue is btw. with the thumbnail
327 2012-02-05T20:51:02 <dreimark> that should be one cs for both changes.
328 2012-02-05T20:51:19 <dreimark> I prefer that in post solved
329 2012-02-05T20:52:29 <sudo_dirk> no, it is a missing argument. it was the bug report where i already sent the traceback. i did not find the report yet.
330 2012-02-05T20:52:55 <dreimark> but it is on two places tbd
331 2012-02-05T20:53:08 <sudo_dirk> the other is correct
332 2012-02-05T20:53:15 <sudo_dirk> if you click the image
333 2012-02-05T20:53:27 <sudo_dirk> if you click in toolbar it is missing
334 2012-02-05T20:53:30 <dreimark> I get on both localhost.jpeg
335 2012-02-05T20:53:32 <dreimark> as name
336 2012-02-05T20:53:55 <sudo_dirk> i am confused
337 2012-02-05T20:54:20 <dreimark> me too
338 2012-02-05T20:54:32 <dreimark> i guess i speak on right click of an image
339 2012-02-05T20:54:42 <dreimark> and you about something in the toolbar?
340 2012-02-05T20:55:03 <sudo_dirk> there are two links to the thumbnail view. one is the image itself. the other is in the toolbar. if you compare the links, you see that thumbnail_width is missing in the toolbar.
341 2012-02-05T20:55:30 <sudo_dirk> i speak about the rest of my bug fix.
342 2012-02-05T20:55:59 <sudo_dirk> and yes it is in the toolbar
343 2012-02-05T20:56:32 <ThomasWaldmann> dreimark: did you try whether we have a regression regarding length of pathes in underlay.tar?
344 2012-02-05T20:57:09 <dreimark> ThomasWaldmann: the xpython repo is in branches, i decided to clone it with a slow connection ...
345 2012-02-05T20:57:22 <dreimark> s/xpython/cpython
346 2012-02-05T20:57:37 <dreimark> sudo_dirk: this were two issues
347 2012-02-05T20:58:14 <sudo_dirk> i thought about 1 toolbar bugfix :P
348 2012-02-05T20:58:17 <dreimark> I guess you mean the missing change for webnail_width = int(request.values.get('webnail_width', ''))
349 2012-02-05T20:58:40 <sudo_dirk> don't know that line...
350 2012-02-05T20:59:06 <sudo_dirk> the info is missing in the link from toolbar
351 2012-02-05T20:59:13 <sudo_dirk> see on cr
352 2012-02-05T20:59:29 <dreimark> soon, currently looking at cpython
353 2012-02-05T20:59:42 <sudo_dirk> all right.
354 2012-02-05T21:21:30 <dreimark> ThomasWaldmann: http://hg.python.org/cpython/file/9a4131ada792/Lib/httplib.py
355 2012-02-05T21:21:32 <dreimark> this works
356 2012-02-05T21:21:44 <dreimark> if there is no tag mismatch, which is a different issue
357 2012-02-05T21:22:46 <dreimark> I am testing with py2.6
358 2012-02-05T21:23:02 <dreimark> the question is what that makes in py2.7
359 2012-02-05T21:23:17 <ThomasWaldmann> dreimark: if that one works, add it to support
360 2012-02-05T21:23:34 * dreimark looks at py2.7
361 2012-02-05T21:23:54 <ThomasWaldmann> and please refer in the commit comment to http://hg.python.org/cpython/file/9a4131ada792/Lib/httplib.py and why we added it.
362 2012-02-05T21:24:00 <dreimark> sure
363 2012-02-05T21:24:47 <dreimark> sudo_dirk: send me a pull request, the failure i showed is fixed with that patch
364 2012-02-05T21:25:31 <dreimark> i separate functionality by cs.
365 2012-02-05T21:26:01 <dreimark> that were different problems, and you need many lines to describe the difference
366 2012-02-05T21:26:21 <dreimark> and just "fix the toolbar" is not very informative
367 2012-02-05T21:26:46 <dreimark> in half of year noone remembers the reason
368 2012-02-05T21:28:15 <dreimark> then there is another image dwl problem with the name. i am not sure if that can be solved
369 2012-02-05T21:28:37 <dreimark> for images from the cache the name is currently wrong
370 2012-02-05T21:29:40 <sudo_dirk> dreimark: ok, i'll send a pull request.
371 2012-02-05T21:30:29 <ThomasWaldmann> dreimark: so you used python 2.7.x and the httplib of 2.6 and it worked?
372 2012-02-05T21:30:31 <sudo_dirk> dreimark: do you mean that if you save a webnail, that you get wikiname.ext as name?
373 2012-02-05T21:30:46 <dreimark> ThomasWaldmann: I am waiting for rm `find . | grep .pyc$`
374 2012-02-05T21:31:11 <dreimark> sudo_dirk: i get localhost.jpeg
375 2012-02-05T21:31:12 <ThomasWaldmann> because i think xmlrpclib will call it in a different way
376 2012-02-05T21:31:46 <sudo_dirk> dreimark: is that your wikiname? i get mywiki.jpeg
377 2012-02-05T21:32:06 <dreimark> i tried in the morning first a simple script with xmlrpclib and getPage and this worked too
378 2012-02-05T21:32:17 <dreimark> sudo_dirk: yes dev wiki
379 2012-02-05T21:32:20 <dreimark> at localhost
380 2012-02-05T21:32:59 <sudo_dirk> ah, mine is running under /mywiki yours under /
381 2012-02-05T21:33:20 <dreimark> i guess you run it with apache?
382 2012-02-05T21:33:48 <dreimark> i just run wikiserver with different ports for developing on my various systems
383 2012-02-05T21:33:54 <sudo_dirk> correct. i tried it on my server wiki
384 2012-02-05T21:35:28 <dreimark> fsck
385 2012-02-05T21:37:51 <dreimark> ThomasWaldmann: http://paste.pocoo.org/show/546404/
386 2012-02-05T21:38:14 <dreimark> i get this with just http://localhost:8080/%D0%A1%D1%83%D0%B4%D0%B0%D0%BB%D0%B3%D0%B0%D0%B0%D0%BD%D1%8B%D0%A2%D0%B0%D0%BD%D0%B8%D0%BB%D1%86%D1%83%D1%83%D0%BB%D0%B3%D0%B0
387 2012-02-05T21:38:42 <dreimark> which is the cyrillic testpage name provided by the bug report
388 2012-02-05T21:39:19 * dreimark rename the new support lib
389 2012-02-05T21:40:05 <dreimark> hm, wait may be usual proble,
390 2012-02-05T21:40:14 <dreimark> cache in wrong py version
391 2012-02-05T21:42:09 <dreimark> ok ignore that error was based on cache
392 2012-02-05T21:42:39 * dreimark if we ever have cache in moin2 we should add in the first bits the py version
393 2012-02-05T21:43:24 <dreimark> it should invalidate immediatly without any headache
394 2012-02-05T21:44:16 * dreimark \o/
395 2012-02-05T21:46:27 <dreimark> feels now like -0-
396 2012-02-05T21:56:15 <dreimark> or better like /o\
397 2012-02-05T21:58:38 <dreimark> ThomasWaldmann: http://paste.pocoo.org/show/546418/
398 2012-02-05T21:59:23 <dreimark> in 2.7 xmlrpclib has changes too.
399 2012-02-05T22:01:05 <ThomasWaldmann> i just said that
400 2012-02-05T22:01:17 <dreimark> yes u are right
401 2012-02-05T22:02:32 <dreimark> ok, i try to break it down. because if there will be a 2.8 we can expect more changes
402 2012-02-05T22:05:38 <ThomasWaldmann> hmm, if we exchange httplib by a copy of 2.6, we could create other issues in other stuff calling it (aside from the xmlrpclib)
403 2012-02-05T22:05:42 <dreimark> i think we can't solve the wikisync tag problems in 1.9 without uuid and log of operations
404 2012-02-05T22:05:59 <sudo_dirk> dreimark: pull request is out
405 2012-02-05T22:06:11 <dreimark> yes, that is the problem i was thinking about
406 2012-02-05T22:06:29 <dreimark> it make more issues than we have tests for
407 2012-02-05T22:08:45 <CIA-64> sudo_dirk<d.alders@arcor.de> default * 572:d53b63f94da8 extensions/data/plugin/parser/text_x_arnica.py: arnica: fix for slide show link of toolbar. parameter webnail_width was missing.
408 2012-02-05T22:08:49 <dreimark> sudo_dirk: ^
409 2012-02-05T22:09:35 <sudo_dirk> so cia is irc push from cia.vc...
410 2012-02-05T22:09:59 <sudo_dirk> is that correct. and you accepted the pull request.
411 2012-02-05T22:10:34 <dreimark> yes, i have pulled into the bb repo and pushed it to our server
412 2012-02-05T22:10:47 <dreimark> and if i
413 2012-02-05T22:11:08 <dreimark> 've done my jon you see it in the logs on irc
414 2012-02-05T22:11:18 <dreimark> s/jon/job/
415 2012-02-05T22:11:46 <sudo_dirk> ah great. i see a lot new stuff here. i like that^^
416 2012-02-05T22:14:21 <sudo_dirk> dreimark: just one more arnica issue. in macro/Image.py you use os.path.getctime if no exif is available. ctime is the change time of a file.
417 2012-02-05T22:14:31 <sudo_dirk> that means it is the upload time.
418 2012-02-05T22:14:53 <dreimark> what do you want instead mtim?
419 2012-02-05T22:15:17 <sudo_dirk> i changed it to mtime here. it is the time of the last content change
420 2012-02-05T22:15:24 *** helixfelix
421 2012-02-05T22:15:36 <dreimark> makes sense
422 2012-02-05T22:15:42 <sudo_dirk> which is more useful from my point of view
423 2012-02-05T22:16:04 <dreimark> cr if you are unsure otherwise pullreq
424 2012-02-05T22:16:24 <sudo_dirk> it is just an c->m :-)
425 2012-02-05T22:18:30 <dreimark> so pr please
426 2012-02-05T22:18:46 <dreimark> and a good comment
427 2012-02-05T22:19:45 <sudo_dirk> too late. already in ;-)
428 2012-02-05T22:20:23 <dreimark> sudo_dirk: hg rollback
429 2012-02-05T22:20:30 <dreimark> if it was last
430 2012-02-05T22:21:24 <sudo_dirk> no, i hope it is ok for you. i try to improve these things. have a look...
431 2012-02-05T22:21:35 * dreimark likes it
432 2012-02-05T22:22:17 <sudo_dirk> just increasing your blood pressure ;-)
433 2012-02-05T22:22:50 <CIA-64> sudo_dirk<d.alders@arcor.de> default * 573:c760e6c61a0d extensions/data/plugin/macro/Image.py: arnica: the date of non exif images is changed to the modification time (not the upload time)
434 2012-02-05T22:23:20 <sudo_dirk> it was an effective evening :-))
435 2012-02-05T22:24:22 <ThomasWaldmann> huh?
436 2012-02-05T22:24:33 <ThomasWaldmann> the date of non exif images is changed to the modification time (not the upload time)
437 2012-02-05T22:24:45 <ThomasWaldmann> modification time means fs mtime?
438 2012-02-05T22:25:33 <dreimark> sudo_dirk: the parameter is wrong names
439 2012-02-05T22:26:28 <dreimark> you obfuscate it now and you need a fix for that because i was not looking in detailed
440 2012-02-05T22:27:32 <dreimark> and ThomasWaldmann is also right some fs moin can use have a very strange definition of times
441 2012-02-05T22:28:32 <dreimark> but if it is a brave user he has a server on a linux fs;)
442 2012-02-05T22:30:18 <ThomasWaldmann> what i mean is that fs mtime is rather volatile. just copy it and it will be different. the time in the edit-log (upload time) stays as it is.
443 2012-02-05T22:30:49 <sudo_dirk> sry, i didn't get it...
444 2012-02-05T22:31:00 <dreimark> ctime = os.path.getmtime(self._filename)
445 2012-02-05T22:31:06 <dreimark> the c is wrong
446 2012-02-05T22:31:22 <dreimark> and what happens if you copy the file on the fs?
447 2012-02-05T22:31:43 <sudo_dirk> so you mean better change all c to m?
448 2012-02-05T22:31:53 <sudo_dirk> including all calls
449 2012-02-05T22:32:22 <dreimark> if you use mtime it is not good to name the parameter ctime
450 2012-02-05T22:32:36 <dreimark> ThomasWaldmann: if you copy the file all times change
451 2012-02-05T22:32:49 <dreimark> or you have -p
452 2012-02-05T22:32:52 <xorAxAx> dreimark: not with -a
453 2012-02-05T22:32:52 <dreimark> used
454 2012-02-05T22:33:07 <dreimark> wb xorAxAx
455 2012-02-05T22:33:09 <dreimark> thx
456 2012-02-05T22:33:16 <xorAxAx> thx
457 2012-02-05T22:33:40 <dreimark> ThomasWaldmann: we don't ask the log
458 2012-02-05T22:34:25 <sudo_dirk> ctime was the upload time
459 2012-02-05T22:34:45 <sudo_dirk> mtime not
460 2012-02-05T22:35:04 <sudo_dirk> and uploading is a new file like copy
461 2012-02-05T22:35:13 <dreimark> yes, if we want to be correct we should use the log information
462 2012-02-05T22:35:28 <dreimark> anyway if you rename ctime you should also fix the parameter name
463 2012-02-05T22:36:25 <sudo_dirk> that not the problem. i do the change. but it sounds like mtime is not better then ctime
464 2012-02-05T22:36:44 <dreimark> xorAxAx: how are you?
465 2012-02-05T22:36:54 <xorAxAx> dreimark: fine
466 2012-02-05T22:37:04 <xorAxAx> how about you?
467 2012-02-05T22:38:32 <dreimark> it becomes better each week.
468 2012-02-05T22:39:08 <dreimark> I have lots of new jobs helping my mum
469 2012-02-05T22:40:22 <dreimark> xorAxAx: ^
470 2012-02-05T22:42:25 <xorAxAx> oh
471 2012-02-05T22:43:18 <dreimark> do you like to track down a httplib xmlrpc issue?
472 2012-02-05T22:44:04 <xorAxAx> no :)
473 2012-02-05T22:44:47 <dreimark> ok, then i try my best ;)
474 2012-02-05T22:46:31 <helixfelix> Argh, I cannot wait until moin2 will be released... ^^
475 2012-02-05T22:47:05 <dreimark> helixfelix: you should help us
476 2012-02-05T22:47:14 <dreimark> at least with issues on our tracker
477 2012-02-05T22:47:28 <sudo_dirk> dreimark: i understood that i have to change Image.py and text..arnica.py. i put my changes to cr again. ok.
478 2012-02-05T22:50:21 <dreimark> good
479 2012-02-05T22:55:49 <sudo_dirk> but this change changes the interface. img.ctime is not possible, when we change to mtime.
480 2012-02-05T22:59:29 <dreimark> yes, if you think it makes more sense to go with mtime this all must be solved. We always can turn back, by a revert. That's why ThomasWaldmann alwyays tells write down the plan beforehand
481 2012-02-05T23:01:09 * dreimark for now if there is no plan i would suggest to make a revert cs
482 2012-02-05T23:01:10 *** helixfelix
483 2012-02-05T23:05:15 <sudo_dirk> ok. we better clean up. see also http://codereview.appspot.com/5616065/
484 2012-02-05T23:08:12 <dreimark> sudo_dirk: don't overwrite time
485 2012-02-05T23:09:40 <dreimark> i look at the next one tom.
486 2012-02-05T23:21:43 <dreimark> use the id of the current one to make a diffed one
487 2012-02-05T23:25:18 <dreimark> gn
488 2012-02-05T23:31:51 <sudo_dirk> dreimark: gn8
489 2012-02-05T23:31:56 <sudo_dirk> i used http://codereview.appspot.com/5616065/ again.
490 2012-02-05T23:32:13 <sudo_dirk> bb
