MoinMoin: MoinMoinChat/Logs/moin-dev/2012-01-15

   1 2012-01-15T00:32:21  *** raignarok_ has quit IRC
   2 2012-01-15T02:45:13  *** qxcv has joined #moin-dev
   3 2012-01-15T03:56:13  *** xjjk has quit IRC
   4 2012-01-15T04:22:30  *** xjjk has joined #moin-dev
   5 2012-01-15T07:40:56  *** Dragooon_ has joined #moin-dev
   6 2012-01-15T07:42:52  *** Dragooon_ has quit IRC
   7 2012-01-15T08:09:47  *** Dragooon_ has joined #moin-dev
   8 2012-01-15T09:29:06  *** raignarok_ has joined #moin-dev
   9 2012-01-15T10:24:19  *** kanha has joined #moin-dev
  10 2012-01-15T10:51:43  *** raignarok_ has quit IRC
  11 2012-01-15T10:54:08  *** kanha has quit IRC
  12 2012-01-15T11:10:32  *** raignarok_ has joined #moin-dev
  13 2012-01-15T11:10:47  *** greg_f has joined #moin-dev
  14 2012-01-15T12:13:41  *** raignarok_ has quit IRC
  15 2012-01-15T12:55:09  *** raignarok_ has joined #moin-dev
  16 2012-01-15T13:30:50  *** Dragooon_ is now known as Dragooon|Away
  17 2012-01-15T13:39:11  *** qxcv has quit IRC
  18 2012-01-15T13:58:30  *** sudo_dirk has joined #moin-dev
  19 2012-01-15T13:58:46  <sudo_dirk> moin everybody
  20 2012-01-15T13:59:52  <dreimark> moin ;)
  21 2012-01-15T14:01:34  <dreimark> sudo_dirk: you work on arnica?
  22 2012-01-15T14:10:57  <sudo_dirk> yes i do
  23 2012-01-15T14:11:52  <sudo_dirk> i did a bug-fix (icon slideshow) and added a functionality to get an overview of pages with picturegalleries.
  24 2012-01-15T14:14:50  <dreimark> sudo_dirk: i'd seen, i replied to your mail a few minutes ago. there are some more lines i can comment on
  25 2012-01-15T14:15:34  <dreimark> e.g. add a new line for copyright 2012 or explain why you mean you have it since 2008
  26 2012-01-15T14:16:33  <sudo_dirk> ok. i am not so familiar with those comments. i will add a line with 2012 cause i started there. correct!
  27 2012-01-15T14:16:53  <dreimark> if you use cr it is easier to add comments to the code
  28 2012-01-15T14:17:02  <dreimark> instead of describing what and why and where
  29 2012-01-15T14:17:54  <sudo_dirk> what is cr?
  30 2012-01-15T14:18:08  <dreimark> codreview
  31 2012-01-15T14:18:16  <dreimark> codereview, see mail
  32 2012-01-15T14:18:42  <sudo_dirk> yes, i read it 1 min ago. i will have a look.
  33 2012-01-15T14:19:19  <dreimark> http://codereview.appspot.com/4432084/ is an example for that tool
  34 2012-01-15T14:19:26  <sudo_dirk> one line is the fix for the slide_show. i added webnail_width.
  35 2012-01-15T14:19:33  <dreimark> by the way it is from guido ;)
  36 2012-01-15T14:19:46  <dreimark> seen, that is the second cs
  37 2012-01-15T14:20:14  <dreimark> the other one looks a bit long for what it is doing. but that may be counts also for lots of the old code there
  38 2012-01-15T14:21:21  <sudo_dirk> i don't want to change the original code so much.
  39 2012-01-15T14:22:14  <dreimark> the 50 lines or so you showed is new
  40 2012-01-15T14:22:24  <dreimark> https://bitbucket.org/sudo_dirk/moin1-extensions/changeset/c9b9e4c8afe7
  41 2012-01-15T14:22:56  <dreimark> I think you abuse None for boolean
  42 2012-01-15T14:22:56  <sudo_dirk> really 50? it felt like half of the lines :-)
  43 2012-01-15T14:23:10  <dreimark> not exactly 47
  44 2012-01-15T14:23:22  <dreimark> and 5 -
  45 2012-01-15T14:23:24  <sudo_dirk> it really felt like half
  46 2012-01-15T14:23:46  <Dragooon|Away> Hello :)
  47 2012-01-15T14:24:04  <sudo_dirk> hi dragooon
  48 2012-01-15T14:24:16  <sudo_dirk> do you mean self.sort_image?
  49 2012-01-15T14:24:16  <dreimark> wb Dragooon|Away - still away ;)
  50 2012-01-15T14:24:25  <dreimark> sudo_dirk: yes
  51 2012-01-15T14:24:26  *** Dragooon|Away is now known as Dragooon
  52 2012-01-15T14:25:05  <dreimark> please use cr, because a) more people can/do review b) you collect more ideas c) it is easier to discuss
  53 2012-01-15T14:25:06  <sudo_dirk> there i store the (top picture name - sorted - in the list)
  54 2012-01-15T14:26:04  <sudo_dirk> None means that there is no picture
  55 2012-01-15T14:26:30  <dreimark> well if it is the top picture the name is completly wrong
  56 2012-01-15T14:26:35  <dreimark> you ofuscate it
  57 2012-01-15T14:26:37  <dreimark> +b
  58 2012-01-15T14:26:47  <sudo_dirk> with that change and the line below you get this picture in the thumb view as well.
  59 2012-01-15T14:28:04  <sudo_dirk> ok. you are right. i will change to top_image_sorted
  60 2012-01-15T14:28:57  <dreimark> have also a pep8 review, often vim with http://moinmo.in/CodingStyle
  61 2012-01-15T14:29:09  <dreimark> pyton.vim gives lots of ideas to improve
  62 2012-01-15T14:29:17  * dreimark sorry for typos
  63 2012-01-15T14:30:33  <dreimark> for what do you need cnt?
  64 2012-01-15T14:31:56  <sudo_dirk> if there is no sort criteria, i sort by the order getting the pages.
  65 2012-01-15T14:32:03  <dreimark> pylint also helps for naming conventions. We do have a little bit different style in 1.x. But mostly we follow the style
  66 2012-01-15T14:32:07  <sudo_dirk> this is possibly overdesigned
  67 2012-01-15T14:32:25  <dreimark> make sure that it works with xapian enabled wikis
  68 2012-01-15T14:33:24  <sudo_dirk> what is xapians?
  69 2012-01-15T14:34:29  <dreimark> is an index search machine we alternative have in MM, it is configurable
  70 2012-01-15T14:35:03  <dreimark> in m2 moinsearch and xapian is replaced by whoosh, which is a pure python index search machine
  71 2012-01-15T14:35:18  <dreimark> for example that can happen http://moinmo.in/MoinMoinBugs/PageListTooVerbose
  72 2012-01-15T14:35:30  <sudo_dirk> ah right. so my call for seaching pages will possibly not work then?
  73 2012-01-15T14:35:41  <dreimark> see HelpOnXapian
  74 2012-01-15T14:35:59  <dreimark> you should give the mimetype
  75 2012-01-15T14:37:10  <sudo_dirk> ok. i will hav a look after that.
  76 2012-01-15T14:37:20  <dreimark> I am also not sure if understand the meaning of album_recursive. I guess it is also obfuscated what it is
  77 2012-01-15T14:37:51  <dreimark> self.album_recursive=False don't understand that line
  78 2012-01-15T14:38:05  <sudo_dirk> so. album cause it is only used if album=True
  79 2012-01-15T14:38:40  <dreimark> yes, but where else do you use that var, later in the code
  80 2012-01-15T14:38:48  <dreimark> why do you set it to False ?
  81 2012-01-15T14:40:29  <sudo_dirk> ok. i call render from inside render. after i got in the section where i call render several times i switch of recursive cause i don't want to get in the section again. i want to get the thumb html like in the original version
  82 2012-01-15T14:41:11  <dreimark> make a function for that
  83 2012-01-15T14:41:55  <sudo_dirk> then i have to put the original stuff in another function if thats ok
  84 2012-01-15T14:42:46  <dreimark> sure, clean commits better readable code is welcome.
  85 2012-01-15T14:43:06  <sudo_dirk> no problem.
  86 2012-01-15T14:44:01  <dreimark> if possible check that no existing arnica gallery renders different
  87 2012-01-15T14:46:16  <sudo_dirk> what do you mean with that? i think there are two changes: you get in album mode the top_image_sorted instead of a random pic. and i added a <br> between ?images and the title. is that what you mean?
  88 2012-01-15T14:48:09  <dreimark> album_image=100_1194.JPG was one you could have selected before
  89 2012-01-15T14:48:12  <sudo_dirk> and i am not sure with the line added self.arnica_image.clear(). i think this will do no change, but i am not absolutly sure.
  90 2012-01-15T14:48:44  <sudo_dirk> ah, ok.
  91 2012-01-15T14:50:40  <dreimark> add a comment for that line, why and what
  92 2012-01-15T14:51:04  <sudo_dirk> you mean that one: ...clear()?
  93 2012-01-15T14:51:29  <sudo_dirk> self.arnica_image.clear()
  94 2012-01-15T14:51:39  <dreimark> yes, why was it added. if you say i think this will do no change
  95 2012-01-15T14:51:58  <sudo_dirk> ok. i will comment this
  96 2012-01-15T14:52:10  <sudo_dirk> you mean in the code?
  97 2012-01-15T14:52:19  <dreimark> yes
  98 2012-01-15T14:52:52  <sudo_dirk> ok
  99 2012-01-15T14:53:53  <sudo_dirk> so first of all i do the changes and put them to bitbucket. after that i will have a look after cr, ok
 100 2012-01-15T14:54:43  <sudo_dirk> there is a difference just writing code for myself or for public ;-)
 101 2012-01-15T14:55:07  <dreimark> it is easier if you have it first on cr, because better review
 102 2012-01-15T14:55:27  <sudo_dirk> ok
 103 2012-01-15T14:55:32  <dreimark> and less commits with refactoring, recursive
 104 2012-01-15T14:56:35  <dreimark> we have used in the past pastebin too, but since cr we try to convience everyone to use it
 105 2012-01-15T14:57:14  <dreimark> bbl
 106 2012-01-15T15:00:32  <sudo_dirk> ok i will have a look after cr.
 107 2012-01-15T15:00:43  <sudo_dirk> and it'll be the first step.
 108 2012-01-15T15:06:02  *** raignarok_ has quit IRC
 109 2012-01-15T15:06:05  *** raignarok__ has joined #moin-dev
 110 2012-01-15T15:09:02  *** raignarok has joined #moin-dev
 111 2012-01-15T15:09:22  *** raignarok__ has quit IRC
 112 2012-01-15T15:09:26  *** raignarok has joined #moin-dev
 113 2012-01-15T15:14:07  <sudo_dirk> one more question. you used os.path.getctime in Image. that give not the creation time under linux. i think under linux os.path.getmtime gives more the date which i would expect.
 114 2012-01-15T15:15:11  <sudo_dirk> dreimark: ...
 115 2012-01-15T15:28:21  *** raignarok_ has joined #moin-dev
 116 2012-01-15T15:32:10  *** raignarok has quit IRC
 117 2012-01-15T16:03:59  *** raignarok_ has quit IRC
 118 2012-01-15T16:09:24  <ThomasWaldmann> http://jacobian.org/writing/when-pypi-goes-down/
 119 2012-01-15T16:10:06  * Dragooon needs to make a presentation
 120 2012-01-15T16:28:22  *** raignarok_ has joined #moin-dev
 121 2012-01-15T16:34:13  <CIA-59> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1239:7d2a51d05e73 2.0/docs/admin/install.rst: docs: what to do if pypi is unavailable
 122 2012-01-15T16:40:59  *** raignarok_ is now known as raignarok
 123 2012-01-15T17:21:04  *** greg_f has quit IRC
 124 2012-01-15T18:04:42  *** raignarok has quit IRC
 125 2012-01-15T18:54:45  *** sudo_dirk has left #moin-dev
 126 2012-01-15T19:46:53  *** raignarok has joined #moin-dev
 127 2012-01-15T22:04:06  *** brunomartin has quit IRC
 128 2012-01-15T22:16:35  *** Dragooon has quit IRC
 129 2012-01-15T23:33:24  *** brunomartin has joined #moin-dev
 130 2012-01-15T23:34:56  <ThomasWaldmann> http://www.google-melange.com/gci/task/view/google/gci2011/7164203 there is one easy task left. if you know python, google and you use windows, you can likely easily do that.
 131 2012-01-15T23:35:50  <ThomasWaldmann> ^^ this is for gci students looking for last day quick tasks. mind the requirements.