MoinMoin: MoinMoinChat/Logs/moin-dev/2012-01-09

   1 2012-01-09T00:04:39  *** raignarok has quit IRC
   2 2012-01-09T00:12:41  <bilal> ThomasWaldmann: there? Could you review my pull request (the last comment you made was about a practical real-world test)
   3 2012-01-09T00:12:55  <bilal> https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/23/fix-issue-141
   4 2012-01-09T00:29:33  <bilal> oh wait, dreimark is my mentor so I guess he should review my branch
   5 2012-01-09T01:07:35  *** qxcv has joined #moin-dev
   6 2012-01-09T01:17:20  *** eSyr has quit IRC
   7 2012-01-09T01:17:25  *** eSyr has joined #moin-dev
   8 2012-01-09T01:20:22  <ThomasWaldmann> bilal: i was just doing that
   9 2012-01-09T01:20:25  <ThomasWaldmann> done now
  10 2012-01-09T01:20:33  <bilal> great, thanks!
  11 2012-01-09T01:20:51  <ThomasWaldmann> you've found a bit bigger problem than expected
  12 2012-01-09T01:21:38  <bilal> yeah, I just read your comment on melange
  13 2012-01-09T01:54:21  <bilal> ThomasWaldmann: you can look at the pull request now, and merge it if you like
  14 2012-01-09T01:59:10  * ThomasWaldmann looks
  15 2012-01-09T01:59:46  * bilal just closed issue #141
  16 2012-01-09T02:05:18  <ThomasWaldmann> ok, merged & closed
  17 2012-01-09T02:06:23  <bilal> thanks
  18 2012-01-09T02:07:59  * ThomasWaldmann kicks CIA-59 
  19 2012-01-09T02:07:59  <CIA-59> ow
  20 2012-01-09T02:08:40  * bilal mentioned the changeset on both issues
  21 2012-01-09T02:10:18  <ThomasWaldmann> http://geekandpoke.typepad.com/.a/6a00d8341d3df553ef0168e5339d40970c-pi
  22 2012-01-09T02:59:10  *** CIA-59 has quit IRC
  23 2012-01-09T03:30:19  *** CIA-65 has joined #moin-dev
  24 2012-01-09T05:36:24  *** Dragooon has joined #moin-dev
  25 2012-01-09T07:42:23  *** ronny has quit IRC
  26 2012-01-09T07:44:27  *** ronny has joined #moin-dev
  27 2012-01-09T07:48:22  *** eSyr has quit IRC
  28 2012-01-09T07:48:24  *** ChanServ has quit IRC
  29 2012-01-09T07:48:25  *** Dragooon has quit IRC
  30 2012-01-09T07:48:26  *** izibi has quit IRC
  31 2012-01-09T07:48:26  *** ThomasWaldmann has quit IRC
  32 2012-01-09T07:48:43  *** xjjk has quit IRC
  33 2012-01-09T07:48:43  *** CIA-65 has quit IRC
  34 2012-01-09T07:48:43  *** aa_ has quit IRC
  35 2012-01-09T07:48:43  *** vpv has quit IRC
  36 2012-01-09T07:48:43  *** bilal has quit IRC
  37 2012-01-09T07:48:43  *** marchael has quit IRC
  38 2012-01-09T07:48:43  *** waldi has quit IRC
  39 2012-01-09T07:48:43  *** TheSheep has quit IRC
  40 2012-01-09T07:48:43  *** dreimark has quit IRC
  41 2012-01-09T07:48:43  *** franklin has quit IRC
  42 2012-01-09T07:48:43  *** qxcv has quit IRC
  43 2012-01-09T07:48:43  *** MattMaker has quit IRC
  44 2012-01-09T07:48:43  *** yufra has quit IRC
  45 2012-01-09T07:53:51  *** Dragooon has joined #moin-dev
  46 2012-01-09T07:53:51  *** CIA-65 has joined #moin-dev
  47 2012-01-09T07:53:51  *** eSyr has joined #moin-dev
  48 2012-01-09T07:53:51  *** qxcv has joined #moin-dev
  49 2012-01-09T07:53:51  *** MattMaker has joined #moin-dev
  50 2012-01-09T07:53:51  *** xjjk has joined #moin-dev
  51 2012-01-09T07:53:51  *** yufra has joined #moin-dev
  52 2012-01-09T07:53:51  *** bilal has joined #moin-dev
  53 2012-01-09T07:53:51  *** ChanServ has joined #moin-dev
  54 2012-01-09T07:53:51  *** ThomasWaldmann has joined #moin-dev
  55 2012-01-09T07:53:51  *** izibi has joined #moin-dev
  56 2012-01-09T07:53:51  *** marchael has joined #moin-dev
  57 2012-01-09T07:53:51  *** dreimark has joined #moin-dev
  58 2012-01-09T07:53:51  *** vpv has joined #moin-dev
  59 2012-01-09T07:53:51  *** aa_ has joined #moin-dev
  60 2012-01-09T07:53:51  *** TheSheep has joined #moin-dev
  61 2012-01-09T07:53:51  *** waldi has joined #moin-dev
  62 2012-01-09T07:53:51  *** franklin has joined #moin-dev
  63 2012-01-09T07:53:51  *** adams.freenode.net sets mode: +o ChanServ
  64 2012-01-09T07:54:42  *** ronny is now known as Guest96208
  65 2012-01-09T08:12:54  <dreimark> moin
  66 2012-01-09T08:24:37  <Dragooon> Moin :)
  67 2012-01-09T08:30:49  *** moin9 has joined #moin-dev
  68 2012-01-09T08:37:02  <moin9> ThomasWaldmann: I have uploaded a CSV file with the unused CSS to bitbucket. I put it under issues in Moin-2.0.  Can you look at what I done so far?
  69 2012-01-09T08:40:28  <dreimark> moin9: url?
  70 2012-01-09T08:41:10  <moin9> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/146/unused-css-selectors-for-google-code-in
  71 2012-01-09T08:41:11  * dreimark has added two easy bugs to the tracker 
  72 2012-01-09T08:54:24  <dreimark> moin9: please add always on which tip you did this search
  73 2012-01-09T08:55:29  <dreimark> and compare with a positive result what is used by your method
  74 2012-01-09T08:55:50  <dreimark> it sounds strange that h1..h6 isn't used
  75 2012-01-09T08:56:46  <moin9> Still there?
  76 2012-01-09T08:57:09  <dreimark> how did you test for these?
  77 2012-01-09T08:59:34  <dreimark> moin9: ^
  78 2012-01-09T09:01:09  *** moin9 has quit IRC
  79 2012-01-09T09:01:52  <dreimark> may be google for "find unused css"
  80 2012-01-09T09:01:57  * dreimark too late
  81 2012-01-09T09:28:38  *** bndr has joined #moin-dev
  82 2012-01-09T09:37:54  <bndr> http://www.printfection.com/moinmoin/American-Apparel-T-Shirt/_p_6764724
  83 2012-01-09T10:05:01  <dreimark> bndr: this is only on the frontside?
  84 2012-01-09T10:05:26  <dreimark> is there more than a t-shirt?
  85 2012-01-09T10:07:39  <bndr> yep
  86 2012-01-09T10:08:27  <bndr> on the backside there is a big logo
  87 2012-01-09T10:09:39  <dreimark> bndr: and our url? a sentence ?
  88 2012-01-09T10:10:32  <dreimark> some colors don't look good, can they been removed
  89 2012-01-09T10:13:57  <bndr> i dont think they can
  90 2012-01-09T10:36:36  *** Trip_ has joined #moin-dev
  91 2012-01-09T10:36:36  *** MattMaker has quit IRC
  92 2012-01-09T10:41:41  *** greg_f has joined #moin-dev
  93 2012-01-09T11:36:01  *** Trip_ has quit IRC
  94 2012-01-09T11:38:42  *** MattMaker has joined #moin-dev
  95 2012-01-09T11:46:29  <CIA-65> Sam Toyer <samATqxcvDOTnet> default * 1227:18cb4213fc4d 2.0/MoinMoin/ (4 files in 4 dirs): Always show search box in layout.html
  96 2012-01-09T11:46:29  <CIA-65> Sam Toyer <samATqxcvDOTnet> default * 1228:c6ab64b8399a 2.0/MoinMoin/search/__init__.py: Remove unnecessary whitespace
  97 2012-01-09T11:46:30  <CIA-65> Sam Toyer <samATqxcvDOTnet> default * 1229:29301b8a2718 2.0/MoinMoin/ (items/__init__.py templates/layout.html): Hide search box in modify views.
  98 2012-01-09T11:46:31  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1230:4899314f049a 2.0/MoinMoin/ (5 files in 5 dirs): merged
  99 2012-01-09T11:53:48  <ThomasWaldmann> moin
 100 2012-01-09T11:53:52  <ThomasWaldmann> qxcv: ^^
 101 2012-01-09T12:00:52  <Dragooon> Moin
 102 2012-01-09T12:01:55  <ThomasWaldmann> hi Dragooon
 103 2012-01-09T12:02:01  <Dragooon> Hi :)
 104 2012-01-09T12:35:05  *** Dragooon has quit IRC
 105 2012-01-09T12:46:57  *** Dragooon has joined #moin-dev
 106 2012-01-09T12:48:05  *** bndr has quit IRC
 107 2012-01-09T12:48:56  *** Dragooon has quit IRC
 108 2012-01-09T12:49:36  *** Dragooon has joined #moin-dev
 109 2012-01-09T13:03:52  <qxcv> ThomasWaldmann dreimark: would fixing MoinMoin/converter/_tests/test_smiley.py so that it doesn't skip be appropriate for a "fix a failing test" task?
 110 2012-01-09T13:09:48  <ThomasWaldmann> well, it is not quite failing. but aside from that: how would you want to do that?
 111 2012-01-09T13:11:47  <qxcv> remove the importorskip line and use emeraldtree for xml parsing instead
 112 2012-01-09T13:12:42  <qxcv> I might look at test_frontend and fix the skips there, too - test_smiley alone seems a bit simple for a medium task
 113 2012-01-09T13:12:53  <ThomasWaldmann> that doesn't work
 114 2012-01-09T13:13:09  <qxcv> using emeraldtree?
 115 2012-01-09T13:13:18  <ThomasWaldmann> lxml likely was used back then because emeraldtree code wasn't able to do that
 116 2012-01-09T13:19:58  <qxcv> in that case it seems it would be easier to either not use xpath (and just check output in the same way as the other converter tests do) or make lxml a dependency and have quickinstall fetch it automatically
 117 2012-01-09T13:20:42  <ThomasWaldmann> not using xpath is just a mess that breaks easily
 118 2012-01-09T13:21:02  <ThomasWaldmann> and we also don't want to have a binary dependency that is just needed for running the tests
 119 2012-01-09T13:28:34  <qxcv> ah, I see - there are a whole bunch of tests that are skipped because they need lxml
 120 2012-01-09T13:28:58  * qxcv installs lxml and runs tests again
 121 2012-01-09T13:35:30  *** dave_largo has joined #moin-dev
 122 2012-01-09T13:44:00  * qxcv tries to make sense of lxml output
 123 2012-01-09T13:44:49  * qxcv forfeits
 124 2012-01-09T13:45:05  <Dragooon> Forfeit in a minute?
 125 2012-01-09T13:45:05  <qxcv> ThomasWaldmann dreimark: what difficulty level would this bug be https://bitbucket.org/thomaswaldmann/moin-2.0/issue/149/svgdraw-creates-wrong-item?
 126 2012-01-09T13:45:07  <Dragooon> Try harder!
 127 2012-01-09T13:45:13  *** Guest96208 has quit IRC
 128 2012-01-09T13:45:35  *** ronny has joined #moin-dev
 129 2012-01-09T13:46:21  <qxcv> Dragooon: I looked at it for 15min and couldn't make sense of it
 130 2012-01-09T13:56:21  <ThomasWaldmann> qxcv: i have no idea about the drawing stuff
 131 2012-01-09T13:57:20  <ThomasWaldmann> is jinja2 maybe generating that "undefined" name because some name is undefined?
 132 2012-01-09T13:58:32  <ThomasWaldmann> just noticed that the svgdraw ui for saving is still stupid
 133 2012-01-09T13:58:58  <qxcv> yes, it gives you a warning about "navigating off the page" and unsaved changes :P
 134 2012-01-09T13:59:57  <qxcv> twikidraw works fine as far as saving with the correct name is concerned
 135 2012-01-09T14:00:06  <qxcv> I'm trying out anywikidraw now
 136 2012-01-09T14:04:47  *** Dragooon has quit IRC
 137 2012-01-09T14:04:49  <qxcv> adraw won't work for me with icedtea, it just hangs
 138 2012-01-09T14:05:01  <qxcv> I'm assuming the issue is isolated to svgdraw
 139 2012-01-09T14:16:27  *** Dragooon has joined #moin-dev
 140 2012-01-09T14:55:52  *** dave_largo has quit IRC
 141 2012-01-09T15:11:25  <qxcv> ThomasWaldmann dreimark: can I claim an easy bugfix task for https://bitbucket.org/thomaswaldmann/moin-2.0/issue/147/title-wrong-on-search-call?
 142 2012-01-09T15:41:49  *** Dragooon_ has joined #moin-dev
 143 2012-01-09T15:42:12  *** Dragooon has quit IRC
 144 2012-01-09T15:42:13  *** Dragooon_ is now known as Dragooon
 145 2012-01-09T15:57:23  <dreimark> qxcv: 149 counts as easy
 146 2012-01-09T15:58:02  <dreimark> there must be some parameter parsing wrong now
 147 2012-01-09T16:07:41  <dreimark> qxcv: on the test.moimo.in svg-edit drawing works
 148 2012-01-09T16:08:03  <dreimark> ThomasWaldmann: which tip is on the test wiki
 149 2012-01-09T16:08:44  <dreimark> http://test.moinmo.in/dfdf
 150 2012-01-09T16:10:42  <qxcv> dreimark: can confirm it doesn't work on moin-2.0 tip
 151 2012-01-09T16:10:52  <qxcv> *default tip
 152 2012-01-09T16:11:08  <qxcv> also, I can't create svg items on test.moinmo.in
 153 2012-01-09T16:11:10  <qxcv> http://test.moinmo.in/svgedit-test?member=drawing.svg
 154 2012-01-09T16:11:18  <dreimark> why
 155 2012-01-09T16:11:21  <dreimark> it is pure js
 156 2012-01-09T16:12:12  <qxcv> ah, working now
 157 2012-01-09T16:12:39  <qxcv> I tried a couple of times and it would just redirect me to svgedit-test claiming the item doesn't exist
 158 2012-01-09T16:12:42  <dreimark> on a fresh item the mesage is not quite right
 159 2012-01-09T16:12:59  <dreimark> yes the press ok, and create it
 160 2012-01-09T16:14:34  <dreimark> +n
 161 2012-01-09T16:15:07  <dreimark> so it is finding which cs broke it
 162 2012-01-09T16:16:32  <dreimark> http://code.google.com/p/svg-edit/issues/detail?id=821&can=1&q=moin&colspec=ID%20Type%20Status%20Priority%20NeededFor%20Browser%20Owner%20Summary
 163 2012-01-09T16:16:57  <dreimark> i have not yet updated the xstatic package but that is what i added for saving.
 164 2012-01-09T16:17:20  <dreimark> env/lib/python2.6/site-packages/xstatic/pkg/svgedit_moin/data/editor/extensions/ext-server_moinsave.js
 165 2012-01-09T16:19:06  *** raignarok has joined #moin-dev
 166 2012-01-09T16:20:28  <qxcv> okay, claimed a task
 167 2012-01-09T16:20:49  <qxcv> I'll look into it tomorrow, but for now gn and ty for your help :)
 168 2012-01-09T16:21:01  *** qxcv has quit IRC
 169 2012-01-09T16:22:27  *** raignarok has quit IRC
 170 2012-01-09T17:03:16  *** raignarok has joined #moin-dev
 171 2012-01-09T17:51:13  *** greg_f has quit IRC
 172 2012-01-09T17:58:39  *** RogerHaase has joined #moin-dev
 173 2012-01-09T18:16:51  *** raignarok has quit IRC
 174 2012-01-09T18:55:55  *** Dragooon has quit IRC
 175 2012-01-09T19:26:47  *** MattMaker has quit IRC
 176 2012-01-09T19:47:58  *** MattMaker has joined #moin-dev
 177 2012-01-09T20:48:53  *** raignarok has joined #moin-dev
 178 2012-01-09T21:12:32  *** RogerHaase has left #moin-dev
 179 2012-01-09T21:30:53  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5817:d8ac2a401f8f 1.9/docs/CHANGES: updated CHANGES
 180 2012-01-09T22:34:54  *** RogerHaase has joined #moin-dev
 181 2012-01-09T23:19:02  *** RogerHaase has left #moin-dev
 182 2012-01-09T23:42:22  <dreimark> gn
 183 2012-01-09T23:44:52  *** raignarok has quit IRC
 184