1 2012-01-08T00:01:28 <izibi> submitted for review on melange: http://www.google-melange.com/gci/task/view/google/gci2011/7195216
2 2012-01-08T00:03:47 <ThomasWaldmann> ok, thanks for working on this
3 2012-01-08T00:06:29 <izibi> let's see what i can do next :)
4 2012-01-08T00:09:40 <izibi> closing the issue on bb
5 2012-01-08T00:10:37 <izibi> ThomasWaldmann: when will you pull the changes so that i can add a link to the cs?
6 2012-01-08T00:42:23 <ThomasWaldmann> izibi: you can link to your repo now and add another link later if you think it is better
7 2012-01-08T00:42:51 * ThomasWaldmann currently reviews the instance_path cs, which is a bit tricky
8 2012-01-08T00:54:14 <izibi> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/141/empty-item-gives-ugly-rendering that one looks very interesting :D
9 2012-01-08T01:13:17 <izibi> blame sam toyer for that bug! :D
10 2012-01-08T01:13:48 <izibi> the "#moin-content { display: table-cell; }" introduced in https://bitbucket.org/thomaswaldmann/moin-2.0/changeset/e92a157518e2 causes this
11 2012-01-08T01:14:15 <izibi> but i think you should better ask him
12 2012-01-08T01:14:37 <izibi> otherwise i'll break something else again :D
13 2012-01-08T01:14:48 <izibi> i guess there's a reason why he added that
14 2012-01-08T01:20:59 <izibi> i'll add a comment in the issue tracker
15 2012-01-08T01:24:14 <ThomasWaldmann> thanks
16 2012-01-08T01:49:55 <izibi> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/64/put-constants-from-moinmoinconfig-into hmm, looks like a lot of work :D
17 2012-01-08T01:51:29 <ThomasWaldmann> not the right time now
18 2012-01-08T01:51:57 <ThomasWaldmann> that need to be done when not another big branch is waiting for getting merged
19 2012-01-08T02:01:14 <izibi> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/108/deactivate-hide-views-for-non-existing what about this one?
20 2012-01-08T02:08:11 <ThomasWaldmann> also bad time now. namespaces branch might have / require some different views and i also work on a new theme...
21 2012-01-08T02:08:12 <izibi> oh wait, this looks already fixed
22 2012-01-08T02:08:45 <ThomasWaldmann> really?
23 2012-01-08T02:09:29 <izibi> if the item exists: Anzeigen Herunterladen Historie Bearbeiten Discussion Index Hervorheben Meta Link hinzufügen Abonnieren Umbenennen Löschen Vernichten Referenzen Sitemap Ähnliches
24 2012-01-08T02:09:38 <izibi> if it doesn't: Anzeigen Bearbeiten Discussion Index Link hinzufügen Abonnieren Umbenennen Löschen Vernichten Referenzen Ähnliches
25 2012-01-08T02:10:40 <izibi> probably you also want to hide delete, but the code to do so should already exist
26 2012-01-08T02:12:00 <izibi> https://bitbucket.org/thomaswaldmann/moin-2.0/src/d068e342c04e/MoinMoin/templates/itemviews.html
27 2012-01-08T02:12:14 <izibi> there's check_exists but it doesn't get checked for all endpoints
28 2012-01-08T02:13:50 <izibi> but i guess it would be a good idea to take this logic out of the template and instead only iterate over a simple list there
29 2012-01-08T02:15:42 <ThomasWaldmann> well, as you see there, this is not the only check needed
30 2012-01-08T02:18:10 <ThomasWaldmann> izibi: but you could fix that bug.
31 2012-01-08T02:18:34 <ThomasWaldmann> while the logic is already there for some other views, it makes sense to do it also for some more.
32 2012-01-08T02:18:47 <izibi> that it doesn't get checked for all endpoints?
33 2012-01-08T02:19:21 <ThomasWaldmann> as the bug says
34 2012-01-08T02:20:47 <ThomasWaldmann> also, rename_item is duplicate there
35 2012-01-08T02:23:33 <ThomasWaldmann> be careful with "show" though, this is the main view and also the one that offers creation, maybe should not get removed
36 2012-01-08T02:24:37 <ThomasWaldmann> otherwise you might be in navigational trouble if you e.g. go to "Referenzen" and the want to return back to "Anzeigen"
37 2012-01-08T02:25:41 <izibi> on Referenzen, the bar is completely missing
38 2012-01-08T02:27:15 <ThomasWaldmann> ah, yes, one can still click on the "title"
39 2012-01-08T02:27:24 <ThomasWaldmann> so you can also remove "show"
40 2012-01-08T02:28:01 <izibi> i'd just wrap the (not check_exists or check_exists and exists) check around the whole body of the loop
41 2012-01-08T02:28:09 <izibi> is there something wrong with this? ;)
42 2012-01-08T02:28:44 <izibi> if yes: what's the check_exists flag for, if it doesn't get checked for all endpoints?
43 2012-01-08T02:29:23 <izibi> and as this i set in the config, it might confuse an user as nothing changes if he updates the flag
44 2012-01-08T02:30:44 <ThomasWaldmann> there is some global stuff that does not depend on an item
45 2012-01-08T02:31:52 <izibi> for example?
46 2012-01-08T02:32:11 <izibi> but for these check_exists should be set to false
47 2012-01-08T02:32:44 <ThomasWaldmann> yeah, might work. you want to try? :)
48 2012-01-08T02:32:55 <ThomasWaldmann> sounds like an easy bugfix
49 2012-01-08T02:33:32 <izibi> yes
50 2012-01-08T02:35:02 <izibi> with the default config, only these views are left: Anzeigen Discussion Index Referenzen Ähnliches
51 2012-01-08T02:37:15 <ThomasWaldmann> left for?
52 2012-01-08T02:37:29 <izibi> which are exactly those with check_exists==False
53 2012-01-08T02:37:35 <izibi> for an non-existent item
54 2012-01-08T02:37:48 *** qxcv
55 2012-01-08T02:37:59 <izibi> for an existing item nothing changes
56 2012-01-08T02:40:13 <izibi> http://paste.pocoo.org/show/531565/ this is what i changes (say nothing about the indentation for now)
57 2012-01-08T02:40:32 <izibi> *changed
58 2012-01-08T02:41:45 <qxcv> ThomasWaldmann: ping
59 2012-01-08T02:43:50 <ThomasWaldmann> izibi: i suggest you take a note about the current state of the menu (which links are shown for existing / nonexisting)
60 2012-01-08T02:43:54 <ThomasWaldmann> then you modify
61 2012-01-08T02:44:24 <ThomasWaldmann> then you check again and ask yourself whether all changes you see are correct (do not remove useful links)
62 2012-01-08T02:46:25 <qxcv> ThomasWaldmann: are you free to discuss http://www.google-melange.com/gci/task/view/google/gci2011/7167202?
63 2012-01-08T02:46:56 <ThomasWaldmann> qxcv: yes
64 2012-01-08T02:47:19 <qxcv> awesome
65 2012-01-08T02:47:53 <qxcv> ok, I'm thinking that by your comments on CR I should just start again and remove the data_dir/index_dir/instance_dir configuration entries
66 2012-01-08T02:48:35 <qxcv> and hard code index/data directories as subdirectories of instance_path
67 2012-01-08T02:49:08 <qxcv> this solves the entire issue of having to pass instance_path into the configuration file
68 2012-01-08T02:50:34 <ThomasWaldmann> try to not make it unflexible
69 2012-01-08T02:50:52 <qxcv> perhaps index_dir/data_dir should be relative paths?
70 2012-01-08T02:50:58 <qxcv> relative to instance_dir?
71 2012-01-08T02:51:12 <ThomasWaldmann> for example, index_dir might be a common directory that is shared between multiple wikis, so it can't just always be a subdir of instance_path
72 2012-01-08T02:52:56 <izibi> ThomasWaldmann: little overview: http://paste.pocoo.org/show/531569/ (imo nothing important/useful was remove)
73 2012-01-08T02:55:52 <qxcv> does create_simple_mapping take relative paths?
74 2012-01-08T02:56:50 <ThomasWaldmann> izibi: strictly taken, it is valid to link to a nonexisting item (quicklink) and also to unquicklink, of course
75 2012-01-08T02:57:10 <ThomasWaldmann> same for subscribe and esp. unsubscribe
76 2012-01-08T02:58:12 <ThomasWaldmann> other than that, it looks fine
77 2012-01-08T02:58:43 <ThomasWaldmann> qxcv: relative pathes are usually asking for trouble
78 2012-01-08T03:00:25 <qxcv> so that means that I still have to pass instance_path into the configuration?
79 2012-01-08T03:01:02 <ThomasWaldmann> yes and no
80 2012-01-08T03:01:06 <izibi> ThomasWaldmann: claimed a task: http://www.google-melange.com/gci/task/view/google/gci2011/7236217
81 2012-01-08T03:01:32 <izibi> let's fix the indentation :D
82 2012-01-08T03:01:48 <ThomasWaldmann> it would be easy if one could do that. but i currently do not see how. i tried to talk to mitsuhiko about modifying flask slightly, but he is not online currently.
83 2012-01-08T03:02:50 <ThomasWaldmann> izibi: btw, you could do 2 changesets: first fixing function, then fixing indent
84 2012-01-08T03:03:00 <izibi> btw what is the prefered indentation style in html? 4 or 2 tabs?
85 2012-01-08T03:03:02 <ThomasWaldmann> that is easier to review
86 2012-01-08T03:03:25 <ThomasWaldmann> 4 spaces
87 2012-01-08T03:04:39 <qxcv> ThomasWaldmann: what was your proposed modification?
88 2012-01-08T03:05:27 <ThomasWaldmann> qxcv: to be able to set globals in the loaded configuration file
89 2012-01-08T03:05:49 <qxcv> yes, but the imports of that configuration file can't access the globals you pass in
90 2012-01-08T03:06:07 <izibi> ThomasWaldmann: ok, then part 1: http://paste.pocoo.org/show/531574/ ok? commit it like this?
91 2012-01-08T03:06:13 <ThomasWaldmann> what imports?
92 2012-01-08T03:06:31 <qxcv> I tried monkey patching to do that before, but if you go import the normal wikiconfig you have to redo all your instance_dir/data_dir/index_dir paths
93 2012-01-08T03:06:39 <qxcv> say if you "import wikiconfig"
94 2012-01-08T03:07:07 <qxcv> because you have a config specific to all instances, or something similar
95 2012-01-08T03:08:37 <ThomasWaldmann> izibi: ok
96 2012-01-08T03:09:09 <qxcv> I'm not sure if that's a real world scenario or if I'm just being pedantic, but I got caught out by that when I was testing before
97 2012-01-08T03:09:16 <ThomasWaldmann> qxcv: yes, class gets executed on import
98 2012-01-08T03:09:51 <izibi> ThomasWaldmann: i guess i'll also remove the brackets as they aren't needed any more
99 2012-01-08T03:09:54 <qxcv> I was thinking of using @property, but it seems a bit complex for a config file
100 2012-01-08T03:12:20 <qxcv> do you know of any different lazy evaluation strategies that could work here?
101 2012-01-08T03:15:00 <ThomasWaldmann> yeah, we need something simple
102 2012-01-08T03:15:25 <ThomasWaldmann> what's currently already done is some postprocessing, see MoinMoin.config.*
103 2012-01-08T03:15:58 <qxcv> but can the postprocessing alter the call to create_mapping/create_simple_mapping?
104 2012-01-08T03:16:09 <qxcv> because that's evaluated at import too
105 2012-01-08T03:18:44 <ThomasWaldmann> yup. no, i think we need something else.
106 2012-01-08T03:22:08 *** MattMaker
107 2012-01-08T03:26:32 <qxcv> ThomasWaldmann: perhaps if I altered my current solution to remove the "instance_path" attribute on thread_local_storage after the config file has been executed?
108 2012-01-08T03:26:35 <izibi> ThomasWaldmann: http://paste.pocoo.org/show/531581/ is the formatting ok like this? line 76 is a bit long though
109 2012-01-08T03:26:38 *** moin3
110 2012-01-08T03:26:58 <izibi> i've also add some minuses to the tags to reduce the amount of whitespace in the output
111 2012-01-08T03:27:09 <qxcv> that way we avoid race conditions AND confusing subsequent calls to create_app that do not pass a new instance_path
112 2012-01-08T03:28:13 <moin3> ThomasWaldmann: About the Google Code-In task. Is there a test server somewhere that I can access, or do I have to set up my own MoinMoin server
113 2012-01-08T03:33:00 <ThomasWaldmann> qxcv: like i said, threadlocal feels wrong
114 2012-01-08T03:33:21 <ThomasWaldmann> moin3: test.moinmo.in
115 2012-01-08T03:33:34 <qxcv> feels wrong?
116 2012-01-08T03:34:03 <ThomasWaldmann> but depending on your task, you maybe have to run your own moin. which, after cloning repo and running quickinstall script, is as easy as "moin<enter>"
117 2012-01-08T03:34:15 <moin3> ThomasWaldmann: Thanks
118 2012-01-08T03:34:25 <ThomasWaldmann> qxcv: stuff should be bound to app, not to thread
119 2012-01-08T03:36:16 <qxcv> flask.g and flask.current_app would be my preferred solutions, but they don't work outside of requests (or something along those lines)
120 2012-01-08T03:36:26 <qxcv> I think it's all to do with the way that flask's LocalProxy works
121 2012-01-08T03:36:45 * qxcv reads up
122 2012-01-08T03:37:53 <ThomasWaldmann> i am currently thinking about whether maybe some sort of "path templates" help us
123 2012-01-08T03:38:37 <qxcv> grrr http://flask.pocoo.org/docs/reqcontext/
124 2012-01-08T03:38:43 <qxcv> path templates?
125 2012-01-08T03:39:06 <ThomasWaldmann> something like "{instance_path}/data"
126 2012-01-08T03:39:23 <qxcv> ah
127 2012-01-08T03:39:42 <qxcv> and then use .format in the postprocessing stage?
128 2012-01-08T03:40:42 <ThomasWaldmann> izibi: did you only change indenting? looks ok on first glance.
129 2012-01-08T03:41:34 <izibi> ThomasWaldmann: as i said i also added some minuses, but they don't change the functionality
130 2012-01-08T03:42:02 <izibi> just makes the outputted html a bit nicer
131 2012-01-08T03:42:16 <ThomasWaldmann> qxcv: somewhere, yes
132 2012-01-08T03:42:37 <ThomasWaldmann> izibi: ok
133 2012-01-08T03:42:43 <qxcv> does that solve our problem with create_mapping, though?
134 2012-01-08T03:43:04 <izibi> ThomasWaldmann: commit?
135 2012-01-08T03:43:20 <qxcv> because it would be passed "{instance_path}/data" and I'm not sure where to intercept that to make it "/path/to/instance/data"
136 2012-01-08T03:45:00 <izibi> how does jinja call the {% %} stuff? tags like in django?
137 2012-01-08T03:47:17 <ThomasWaldmann> qxcv: the storage system maybe could process it with the variable part staying there
138 2012-01-08T03:47:42 <ThomasWaldmann> and delay the real stuff until a storage.open(instance_path) happens
139 2012-01-08T03:47:46 *** moin3
140 2012-01-08T03:48:31 <ThomasWaldmann> izibi: commit
141 2012-01-08T03:49:01 <ThomasWaldmann> izibi: not sure.
142 2012-01-08T03:49:24 <ThomasWaldmann> ronny: ^^ any idea?
143 2012-01-08T03:49:39 <ThomasWaldmann> somehow simple stuff sometimes can be rather complicated
144 2012-01-08T03:50:20 <izibi> yes they are, just looked in the docs
145 2012-01-08T03:50:29 <qxcv> perhaps I could use metaclasses to change any string attributes of config objects that have {instance_path} in them?
146 2012-01-08T03:51:17 <izibi> pushed to my bb repo, now submitting to melange
147 2012-01-08T03:52:33 <ThomasWaldmann> qxcv: open() would likely work
148 2012-01-08T03:52:38 <ThomasWaldmann> see app.py
149 2012-01-08T03:52:55 <izibi> done: http://www.google-melange.com/gci/task/view/google/gci2011/7236217
150 2012-01-08T03:54:27 <qxcv> open() as in exec(open(flask_config_file).read().replace('{instance_path}', instance_path), app.config.__dict__)?
151 2012-01-08T03:55:15 <ThomasWaldmann> qxcv: no, open() as in app.py init_backends() when it opens the storage
152 2012-01-08T03:55:22 <qxcv> oh, okay
153 2012-01-08T03:57:27 <ThomasWaldmann> izibi: did you run all unit tests and also done a manual test?
154 2012-01-08T03:58:25 <izibi> manual testing: yes; py.test: running
155 2012-01-08T03:59:17 <izibi> 1 failure
156 2012-01-08T03:59:42 <izibi> http://paste.pocoo.org/show/531600/
157 2012-01-08T03:59:46 <izibi> seems to be unrelated
158 2012-01-08T04:00:01 <izibi> let's run it on a revision before i made my changes
159 2012-01-08T04:01:06 *** MattMaker
160 2012-01-08T04:01:20 <ThomasWaldmann> qxcv: the interwiki map loader has same issue
161 2012-01-08T04:01:44 <izibi> getting the same failure on d068e342c04e
162 2012-01-08T04:01:51 *** Dragooon
163 2012-01-08T04:02:00 <ThomasWaldmann> hah, that was another task
164 2012-01-08T04:02:11 <ThomasWaldmann> Dragooon: ^^
165 2012-01-08T04:02:24 *** Dragooon
166 2012-01-08T04:02:31 <ThomasWaldmann> haha
167 2012-01-08T04:02:32 *** Dragooon
168 2012-01-08T04:02:34 <izibi> :D
169 2012-01-08T04:02:45 <izibi> looks just like a missing import
170 2012-01-08T04:02:59 <ThomasWaldmann> yes, let him fix that
171 2012-01-08T04:03:06 <Dragooon> Yes?
172 2012-01-08T04:03:17 <Dragooon> What is missing?
173 2012-01-08T04:03:21 <ThomasWaldmann> Dragooon: http://paste.pocoo.org/show/531600/
174 2012-01-08T04:03:31 <Dragooon> pocoo? :P
175 2012-01-08T04:03:35 <ThomasWaldmann> that comes from not running unit tests :)
176 2012-01-08T04:04:05 <ThomasWaldmann> Dragooon: that's a nice pastebin we use
177 2012-01-08T04:04:12 <Dragooon> I didn't have PIL defined when iI was running the unit tests, sorrt
178 2012-01-08T04:04:20 <Dragooon> sorry*
179 2012-01-08T04:04:28 <ThomasWaldmann> yeah, PIL is a bit a pain
180 2012-01-08T04:04:53 <Dragooon> Will commit in 30 minutes
181 2012-01-08T04:04:58 <Dragooon> Can you review my task?
182 2012-01-08T04:05:01 <ThomasWaldmann> ok
183 2012-01-08T04:05:08 <ThomasWaldmann> url?
184 2012-01-08T04:05:24 <Dragooon> http://codereview.appspot.com/5517058/
185 2012-01-08T04:06:30 <ThomasWaldmann> there are still not more tests than recently
186 2012-01-08T04:06:59 <Dragooon> Currently I'm only testing for the crash
187 2012-01-08T04:07:08 <Dragooon> Because otherwise the mediawiki file parser is fairly broken
188 2012-01-08T04:07:16 <Dragooon> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/144/better-handling-of-mediawiki-file-links
189 2012-01-08T04:09:13 <Dragooon> ^ I'll take that issue next
190 2012-01-08T04:10:08 <Dragooon> brb in 15 minutes
191 2012-01-08T04:16:20 <ThomasWaldmann> Dragooon: done
192 2012-01-08T04:20:11 <ThomasWaldmann> qxcv: maybe mitsuhiko has an idea when he wakes up again
193 2012-01-08T04:21:07 <qxcv> I'm thinking about implementing your path templates idea, but I think I might run into the same problem of current_app only being usable inside of request contexts
194 2012-01-08T04:21:39 <ThomasWaldmann> we have the app, we don't need current_app
195 2012-01-08T04:21:51 <ThomasWaldmann> see init_backends
196 2012-01-08T04:21:51 <qxcv> how do we pass it to open()?
197 2012-01-08T04:22:09 <ThomasWaldmann> storage.open(app.instance_path)
198 2012-01-08T04:22:18 <qxcv> ah okay
199 2012-01-08T04:22:33 <ThomasWaldmann> but we need such stuff at quite some places
200 2012-01-08T04:22:58 <qxcv> will that work for everything, though? like the interwiki code and the postprocessing config class attr postprocessing?
201 2012-01-08T04:23:06 <ThomasWaldmann> so this tiny change somehow gets a bit more complicated than expected
202 2012-01-08T04:23:53 <qxcv> are you sure relative paths aren't the way to go?
203 2012-01-08T04:24:12 <ThomasWaldmann> relative to cwd?
204 2012-01-08T04:24:31 <qxcv> relative to instance_path
205 2012-01-08T04:24:53 <ThomasWaldmann> well, there is no real semantic difference to template pathes
206 2012-01-08T04:25:21 <ThomasWaldmann> it is just '' vs. '{instance_path}/'
207 2012-01-08T04:25:42 <qxcv> fair point
208 2012-01-08T04:25:52 <ThomasWaldmann> or rather "not /..."
209 2012-01-08T04:26:10 <ThomasWaldmann> and cwd is unreliable
210 2012-01-08T04:26:29 <qxcv> I'm going to read up some more on execfile and see if I can get around to globals limitation, because I prefer the idea of passing instance_path straight into the config file
211 2012-01-08T04:26:32 <qxcv> it seems a lot easier
212 2012-01-08T04:27:05 <ThomasWaldmann> i read the flask code for this, it doesn't pass through the params
213 2012-01-08T04:27:35 <qxcv> pass through params?
214 2012-01-08T04:27:41 <ThomasWaldmann> and even if this works, the import other module problem remains, as you found out
215 2012-01-08T04:27:47 <ThomasWaldmann> globals
216 2012-01-08T04:27:50 <qxcv> oh
217 2012-01-08T04:28:07 <qxcv> that can be solved by monkey patching, but the import problem is still an issue
218 2012-01-08T04:28:57 <ThomasWaldmann> no, you cant solve by MP
219 2012-01-08T04:29:08 <ThomasWaldmann> because the class level code was already executed
220 2012-01-08T04:30:34 <ThomasWaldmann> we can also try to catch ronny or some other people here tomorrow to collect ideas
221 2012-01-08T04:30:59 <qxcv> that seems like the best way
222 2012-01-08T04:31:12 <qxcv> is it okay if I unclaim this task and work on something else for now?
223 2012-01-08T04:31:21 <qxcv> then come back and finish it when we have some more ideas?
224 2012-01-08T04:32:00 <ThomasWaldmann> Dragooon: i set priority to minor, maybe we can find more important bugs
225 2012-01-08T04:32:24 <Dragooon> Ok
226 2012-01-08T04:34:05 <Dragooon> ThomasWaldmann: Replied
227 2012-01-08T04:43:56 <bilal> ThomasWaldmann: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/141/empty-item-gives-ugly-rendering Is this issue okay for a Find a bug, Fix a bug (easy) task?
228 2012-01-08T04:44:16 <bilal> Dragooon: Hi, congratulations, you have been on the top of the GCI leaderboard for quite a while :)
229 2012-01-08T04:44:24 <Dragooon> bilal: Hi :)
230 2012-01-08T04:44:25 <Dragooon> Thanks
231 2012-01-08T04:45:29 <izibi> Dragooon: have you done anything else in the last few weeks? :D
232 2012-01-08T04:45:55 <Dragooon> izibi: Yea, quite a few things. Including a couple of exams, a school project and some personal projects
233 2012-01-08T04:47:46 <izibi> bilal: i looked at that bug earlier today and it seems like you can easily break something elsewhere
234 2012-01-08T04:47:52 <izibi> just keep that in mind ;)
235 2012-01-08T04:49:29 <bilal> Dragooon: Enjoy your trip to Mountain View this spring :)
236 2012-01-08T04:49:36 <Dragooon> Thanks
237 2012-01-08T04:50:10 <bilal> izibi: I fixed it in a somewhat hacky way, but it is by far the safest way to fix it
238 2012-01-08T04:50:18 <bilal> izibi: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/23/fix-issue-141
239 2012-01-08T04:52:04 <izibi> bilal: well. when i first looked at the patch i thought "are we talking about the same bug" as this clearly is a problem with the css...
240 2012-01-08T04:52:37 <Dragooon> Not really
241 2012-01-08T04:52:41 <qxcv> ^
242 2012-01-08T04:53:50 <bilal> izibi: Yes, its not a problem with CSS but rather a problem with how <div>s are rendered when there's nothing in them
243 2012-01-08T04:54:05 <bilal> because you have a table-cell that has practically nothing in it
244 2012-01-08T04:54:31 <Dragooon> Can't you just test if data is empty and return br instead of matching the div?
245 2012-01-08T04:54:51 <bilal> Dragooon: that's exactly what I did in that pull request
246 2012-01-08T04:55:06 <bilal> https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/23/fix-issue-141
247 2012-01-08T04:55:08 <Dragooon> Not really?
248 2012-01-08T04:55:16 <Dragooon> You're testing the output
249 2012-01-08T04:55:20 <Dragooon> I'm saying, test the input
250 2012-01-08T04:55:53 <bilal> hmm
251 2012-01-08T04:55:59 <bilal> yeah, that'd be a better approach
252 2012-01-08T04:56:14 <izibi> why don't you just fix the css...
253 2012-01-08T04:56:22 <bilal> that won't work :)
254 2012-01-08T04:56:34 <bilal> I can fix the template though
255 2012-01-08T04:56:39 <izibi> this is a template/theme-specific problem. you try to fix it in the python source
256 2012-01-08T04:56:51 <izibi> i'm quite sure you can
257 2012-01-08T04:56:52 <bilal> by adding a deliberate <br /> inside the diff
258 2012-01-08T04:57:06 <bilal> but that would be somewhat awkward, there will always be an extra break
259 2012-01-08T04:57:14 <qxcv> bilal: also, are you sure your current patch will work? you test against "<div xmlns=\"http://www.w3.org/1999/xhtml\" />" but on my machine I see empty data rendered as "<div xmlns="http://www.w3.org/1999/xhtml">"
260 2012-01-08T04:57:42 <qxcv> it seems to me like the problem is a lack of a closing tag
261 2012-01-08T04:58:08 <bilal> qxcv: is it? Not the case here, probably a werkzeug/flask problem?
262 2012-01-08T04:58:23 <bilal> anyway, I'm trying my best at fixing it in the template
263 2012-01-08T05:02:10 <izibi> why is there all this "display: table*" stuff in the first place?
264 2012-01-08T05:02:44 <bilal> izibi: for a cleaner UI
265 2012-01-08T05:02:47 <Dragooon> Is there something which trims trailing whitespace in Py?
266 2012-01-08T05:03:17 <bilal> izibi: You don't need to crap around with <table> elements, just write them with a table-* display in CSS
267 2012-01-08T05:03:34 <bilal> changing it to table-row does fix it but it breaks other stuff badly
268 2012-01-08T05:03:49 <bilal> izibi: and weirdly, changing the template doesn't help no matter what
269 2012-01-08T05:04:29 <qxcv> if you're talking about the display: table and display: table-cell for the sidebars, I did that for an earlier GCI task and the problem was still happening before I used display: table
270 2012-01-08T05:04:39 <qxcv> it's not css related
271 2012-01-08T05:05:24 <bilal> could explain why fixing it in the Python code helps for me, but nothing else works
272 2012-01-08T05:05:32 <qxcv> bilal: have a look at html_out.py, I have the feeling the problem is there
273 2012-01-08T05:05:34 * bilal investigates deeper
274 2012-01-08T05:06:12 <izibi> qxcv: i've seen the screenshots of the sidebar. can you explain how i get this sidebar to display?
275 2012-01-08T05:06:27 <qxcv> izibi: just make a subitem and it will appear
276 2012-01-08T05:06:38 <qxcv> so go to Home/Subitem and create that page, and Home will have a sidebar
277 2012-01-08T05:07:15 <izibi> qxcv: thx
278 2012-01-08T05:10:38 <qxcv> bilal: sorry about my comment before with the self-closing div tag, I was wrong there - it does self close (firefox was just removing the self-closing bit so it looked like <div> instead of <div />)
279 2012-01-08T05:20:03 <qxcv> bilal: actually, don't listen to me at all - I just realised that removing the display: table-cell and the margins around the content fixes the issue as well (but I still remember this happening before)
280 2012-01-08T05:20:35 <bilal> hmm
281 2012-01-08T05:21:35 <izibi> hint: Line 255, Column 52: Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag.
282 2012-01-08T05:22:20 <Dragooon> The bug's in that html tag parser
283 2012-01-08T05:23:07 <bilal> I don't think the html tag parser is to blame
284 2012-01-08T05:23:15 <bilal> <div /> and <div></div>
285 2012-01-08T05:23:17 <Dragooon> Self closing div tags are invalid
286 2012-01-08T05:23:49 <bilal> not exactly
287 2012-01-08T05:24:01 * bilal checks
288 2012-01-08T05:24:10 <izibi> moin just assumes html == xml?
289 2012-01-08T05:24:25 <qxcv> also: there seems to be an xhtml document (from html_out) nested in a html5 document
290 2012-01-08T05:24:37 <qxcv> izibi: yes, it assumes html = xhtml
291 2012-01-08T05:24:59 <Dragooon> http://dev.w3.org/html5/spec-author-view/syntax.html#syntax-start-tag
292 2012-01-08T05:25:20 <bilal> yeah, Dragooon is right
293 2012-01-08T05:25:26 <bilal> self-closing div tags are invalid
294 2012-01-08T05:26:00 <Dragooon> That's why I gave up on that bug :P
295 2012-01-08T05:26:06 <Dragooon> Didn't want to dig into the parser
296 2012-01-08T05:26:12 * bilal won't give up anyway :)
297 2012-01-08T05:26:24 <Dragooon> Go ahead, I don't know much Python anyway
298 2012-01-08T05:26:28 <qxcv> bilal: it IS valid xhtml, though
299 2012-01-08T05:26:30 <bilal> www.youtube.com/watch?v=dQw4w9WgXcQ
300 2012-01-08T05:26:41 <bilal> (hint: ^^ is rickroll)
301 2012-01-08T05:26:57 <bilal> right time to say "Never Gonna Give this bug up!"
302 2012-01-08T05:27:24 <Dragooon> qxcv: It's invalid in HTML4 as well, which Moin declares itself as
303 2012-01-08T05:27:38 <Dragooon> In HTML4 <foo /> means <foo> regardless of anythin
304 2012-01-08T05:27:40 <Dragooon> g
305 2012-01-08T05:28:13 <qxcv> Dragooon: are you sure it's HTML4 and not HTML5?
306 2012-01-08T05:28:22 <Dragooon> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
307 2012-01-08T05:28:26 <Dragooon> From moinmo.in
308 2012-01-08T05:28:37 <Dragooon> Even in html5 it'll be invalid
309 2012-01-08T05:28:41 <Dragooon> Only in XHTML it's valid
310 2012-01-08T05:28:41 <qxcv> that's moin 1.x
311 2012-01-08T05:28:47 <Dragooon> Oh
312 2012-01-08T05:28:54 <qxcv> moin 2 is <!DOCTYPE html>
313 2012-01-08T05:29:04 <Dragooon> Then that's HTML5, still invalid
314 2012-01-08T05:29:09 <qxcv> but yeah, you're right regardless
315 2012-01-08T05:30:31 <Dragooon> Are you a mentor?
316 2012-01-08T05:30:38 <bilal> so, that means, my fix stands for now
317 2012-01-08T05:30:51 <bilal> its straightforward even though its a little hacky
318 2012-01-08T05:30:57 <qxcv> Dragooon: no
319 2012-01-08T05:31:05 <Dragooon> izibi: Are you a mentor?
320 2012-01-08T05:31:45 <qxcv> I wonder what would happen if we served moin pages with a application/xhtml+xml mimetype?
321 2012-01-08T05:32:12 <qxcv> the browser might parse it as XHTML5
322 2012-01-08T05:32:12 <izibi> Dragooon: nope
323 2012-01-08T05:32:15 <Dragooon> I don't think so, afaik browsers give priority to doctype of mime
324 2012-01-08T05:32:22 <Dragooon> over mime*
325 2012-01-08T05:37:48 <izibi> as far as i know browser should use an xml parser if you send an html5 doc with an xml content-type
326 2012-01-08T05:38:06 <izibi> but you know, these are browser. don't rely on anything :D
327 2012-01-08T05:38:53 <qxcv> http://blog.whatwg.org/xhtml5-in-a-nutshell is interesting
328 2012-01-08T05:39:14 * qxcv might file a bug asking for moin to switch to XHTML5
329 2012-01-08T05:39:40 <qxcv> that may fix the problem we have now with XHTML nested in HTML5
330 2012-01-08T05:40:26 <Dragooon> I'd stay away because XHTML5 is not a standard and may cause problems
331 2012-01-08T05:40:54 <Dragooon> Considering there are a billion and one implementation of this
332 2012-01-08T05:41:44 <izibi> HTML5 isn't a standard either. it's still a draft
333 2012-01-08T05:43:11 <Dragooon> at least it's a draft
334 2012-01-08T05:44:19 <qxcv> the state of html5 makes me sad ;_;
335 2012-01-08T05:44:47 <Dragooon> Hm...
336 2012-01-08T05:44:48 <Dragooon> http://en.wikipedia.org/wiki/HTML5#XHTML5
337 2012-01-08T05:46:12 <Dragooon> You know what makes me sad?
338 2012-01-08T05:46:18 <Dragooon> W3 has one of the ugliest sites...
339 2012-01-08T05:52:42 <Dragooon> ThomasWaldmann, TheSheep: there?
340 2012-01-08T05:52:52 <izibi> chrome uses an xml parser when settings the right content-type
341 2012-01-08T05:52:53 <izibi> but...
342 2012-01-08T05:53:00 <izibi> error on line 66 at column 37: Opening and ending tag mismatch: img line 0 and a
343 2012-01-08T05:53:03 <izibi> yay!
344 2012-01-08T05:54:13 <Dragooon> lol
345 2012-01-08T05:56:38 <Dragooon> Are all the mentors in CET/
346 2012-01-08T05:56:38 <Dragooon> ?
347 2012-01-08T05:57:46 <qxcv> Dragooon: I think so
348 2012-01-08T05:57:54 <Dragooon> What kind of unfair world is this
349 2012-01-08T05:58:02 <qxcv> haha
350 2012-01-08T05:58:08 <qxcv> there are certainly none in aest :P
351 2012-01-08T05:58:31 <Dragooon> Even PST/EST would do :P
352 2012-01-08T06:00:38 <Dragooon> Can anyone of you review my patch?
353 2012-01-08T06:01:41 <Dragooon> qxcv izibi ^
354 2012-01-08T06:03:03 <izibi> no. and i'll go to bed now. UTC+1 FTW! :D
355 2012-01-08T06:03:17 <Dragooon> Ah well, good night
356 2012-01-08T06:03:18 <qxcv> Dragooon: I'm not a mentor but I can have a look over it
357 2012-01-08T06:03:28 <qxcv> izibi: I'm jealous
358 2012-01-08T06:03:32 <Dragooon> qxcv: That's what i meant, http://codereview.appspot.com/5517058
359 2012-01-08T06:13:06 <qxcv> "if link_args is not None and len(link_args) > 1:" unless a mentor told you to put it in, the "is not None" thing is a bit redundant because false-ish values should have a len() of 0 if they have a len at all
360 2012-01-08T06:14:16 <Dragooon> Let's see
361 2012-01-08T06:15:03 <Dragooon> TypeError: object of type 'NoneType' has no len()
362 2012-01-08T06:15:59 <qxcv> but None is a false-ish value, so if you write "if link_args" instead, it should be equivalent
363 2012-01-08T06:16:38 <qxcv> the second part of the expression won't be evaluated if link_args is a zero-length string or if it is none
364 2012-01-08T06:16:47 <Dragooon> But I need the length to be greater than 1
365 2012-01-08T06:17:07 <Dragooon> Oh
366 2012-01-08T06:17:09 <Dragooon> you mean
367 2012-01-08T06:17:16 <qxcv> exactly, so "if link_args and len(link_args > 1):" is equivalent
368 2012-01-08T06:17:18 <Dragooon> if link_args and len(link_args) > 1
369 2012-01-08T06:17:25 <qxcv> yeah
370 2012-01-08T06:17:30 <qxcv> misplaced my bracket :)
371 2012-01-08T06:17:41 <Dragooon> Ah
372 2012-01-08T06:18:25 <Dragooon> Uploaded
373 2012-01-08T06:18:25 *** xjjk
374 2012-01-08T06:19:39 <qxcv> what does parse_arguments do?
375 2012-01-08T06:20:03 <Dragooon> Converts things like "arg1 arg2" to proper arguments
376 2012-01-08T06:20:11 <Dragooon> Or "arg1 arg2=value"
377 2012-01-08T06:20:17 <qxcv> oh, and link_args_list[:] == link_args_list
378 2012-01-08T06:20:30 <Dragooon> Yes, but a copy and not reference linked
379 2012-01-08T06:20:35 <Dragooon> I think
380 2012-01-08T06:21:44 <qxcv> you shouldn't need it here
381 2012-01-08T06:21:45 <Dragooon> but that wouldn't make much difference, would it?
382 2012-01-08T06:21:51 <Dragooon> yeah, okay.
383 2012-01-08T06:22:06 <Dragooon> Python is interesting
384 2012-01-08T06:22:13 <Dragooon> It makes me cause a lot of parse errors in js/php
385 2012-01-08T06:22:57 <qxcv> indeed, python's referencing passing stuff can be annoying
386 2012-01-08T06:23:11 <Dragooon> That, and lack of curly braces and semi colons
387 2012-01-08T06:26:41 <Dragooon> Otherwise from the minor errors, is the patch itself fine?
388 2012-01-08T06:27:35 <qxcv> what happens if there is a space in one of the MW attributes?
389 2012-01-08T06:27:49 <Dragooon> they get treated as different arguments
390 2012-01-08T06:28:00 <Dragooon> If there is space they should be wrapped in quotes
391 2012-01-08T06:28:35 <qxcv> ah, so [[File:myimg.png|here is a caption]] should be [[File:myimg.png|"here is a caption"]]?
392 2012-01-08T06:29:02 <Dragooon> Yes
393 2012-01-08T06:30:08 <qxcv> are you sure that the splitting up of those args is handled by the regex?
394 2012-01-08T06:31:04 <Dragooon> Yeah, it was there before as well
395 2012-01-08T06:31:46 <Dragooon> the code just converts pipes to spaces so that moin parser can take care of it
396 2012-01-08T06:32:37 <qxcv> is del parsed_args.positional[-1] necessary?
397 2012-01-08T06:32:54 <Dragooon> yeah, since it's caption it shouldn't be passed in query
398 2012-01-08T06:33:06 <Dragooon> Or treated as argument
399 2012-01-08T06:33:12 <qxcv> try using .pop() instead
400 2012-01-08T06:33:24 <qxcv> so link_text = parsed_args.positional.pop()
401 2012-01-08T06:33:41 <qxcv> del really shouldn't be used in Python
402 2012-01-08T06:34:02 <Dragooon> Oh I see
403 2012-01-08T06:34:37 <Dragooon> Done
404 2012-01-08T06:36:08 <Dragooon> will upload those at once
405 2012-01-08T06:41:13 <qxcv> so [[File:myimg.png|this is a caption]] would be invalid mediawiki markup using this parser?
406 2012-01-08T06:41:43 <Dragooon> it will work, but the markup would be invalid in mediawiki
407 2012-01-08T06:41:49 <Dragooon> That will be equivalent to
408 2012-01-08T06:41:59 <Dragooon> [[File:myimg.png|this|is|a|caption]]
409 2012-01-08T06:42:22 <Dragooon> Just the way MoinMoin handled arguments
410 2012-01-08T06:42:38 <qxcv> I'm looking at https://www.mediawiki.org/wiki/Help:Links#Internal_links
411 2012-01-08T06:43:05 <qxcv> they seem to be fine with [[File:myimg.png|this is a caption]], are File: links different?
412 2012-01-08T06:45:58 <Dragooon> that's because Mediawiki only uses | as separator
413 2012-01-08T06:46:05 <Dragooon> Moin uses " " as separator
414 2012-01-08T06:46:35 <qxcv> but isn't this a parser for mediawiki markup, or do I misunderstand?
415 2012-01-08T06:46:35 <Dragooon> It's a bug, sorta
416 2012-01-08T06:46:45 <Dragooon> Yea
417 2012-01-08T06:47:11 <Dragooon> I should fix that
418 2012-01-08T06:47:13 <Dragooon> hm
419 2012-01-08T06:47:59 <qxcv> because if I put [[File:myimg.png|Graph showing width=k for 5 < k < 10]], will that parse the same as in mediawiki?
420 2012-01-08T06:48:13 <Dragooon> No
421 2012-01-08T06:49:13 <Dragooon> I can implement a simplestc mediawiki argument parser, but I don't know regex
422 2012-01-08T06:49:26 <Dragooon> So I can do it other way
423 2012-01-08T06:52:06 <qxcv> another thing: link_args_list = link_args[1:].split('|') - is link_args a string, or a list?
424 2012-01-08T06:52:32 <Dragooon> string
425 2012-01-08T06:52:53 <qxcv> why do you chop off the first character?
426 2012-01-08T06:53:02 <Dragooon> See the comment above
427 2012-01-08T06:53:34 <qxcv> ah, missed that
428 2012-01-08T06:53:39 * qxcv is not good at scanning :)
429 2012-01-08T06:58:08 <qxcv> I'm really not sure what the best way to address that argument parser issue is
430 2012-01-08T06:58:26 <Dragooon> I'm writing one of my own
431 2012-01-08T06:58:38 <qxcv> that sounds like the best idea
432 2012-01-08T06:59:17 <qxcv> moin's current arg parsing code makes my head hurt :P
433 2012-01-08T06:59:37 <Dragooon> actually that whole thing is quite broken
434 2012-01-08T06:59:50 <Dragooon> FIle: and normal links should be separately handled IMO
435 2012-01-08T07:01:56 <qxcv> mediawiki.py has a lot of scrappy code, not a fun file :)
436 2012-01-08T07:02:04 <qxcv> *mediawiki_in.py
437 2012-01-08T07:03:19 <Dragooon> Got it :D
438 2012-01-08T07:04:02 <Dragooon> No wait, nope
439 2012-01-08T07:04:43 <Dragooon> Wait, got it!
440 2012-01-08T07:04:58 <Dragooon> Is this valid?
441 2012-01-08T07:05:04 <Dragooon> if '=' in 'arg=value':
442 2012-01-08T07:05:24 <qxcv> yes
443 2012-01-08T07:06:00 <Dragooon> and for key, value in arg.split('=')
444 2012-01-08T07:06:00 <Dragooon> ?
445 2012-01-08T07:06:46 <qxcv> only if you have exactly one "=" in arg
446 2012-01-08T07:07:02 <qxcv> otherwise there will be more than two values produced
447 2012-01-08T07:07:57 <qxcv> perhaps arg.split('=')[0] could be the key, and ''.join(arg.split('=')[1:]) could be the value?
448 2012-01-08T07:09:05 <qxcv> but be wary of corner cases like [[File:myimg.png|Graph showing width=k for 5 < k < 10]]
449 2012-01-08T07:09:09 <Dragooon> Wouldn't [1:] return a list ?
450 2012-01-08T07:09:25 <qxcv> yes, and ''.join() would flatten the list into a string
451 2012-01-08T07:09:48 <qxcv> so ''.join(["Hello, ", "world!"]) == "Hello, world!"
452 2012-01-08T07:09:51 <Dragooon> That case is invalid in mediawiki as well, isn't it?
453 2012-01-08T07:10:00 <qxcv> I'm not sure
454 2012-01-08T07:14:18 <qxcv> you could write a regex like ((?P<key>\w+)=(?P<value>.+)|(?P<positional>.+)) to get k/v
455 2012-01-08T07:14:36 <qxcv> but I make no guarantees about the validity of that regex, and your method is probably easier :)
456 2012-01-08T07:16:17 <Dragooon> Why is it ''.join(list) and not list.join('')
457 2012-01-08T07:17:19 <qxcv> just the way python does things
458 2012-01-08T07:17:27 <qxcv> it has a lot of strange quirks
459 2012-01-08T07:19:01 <Dragooon> I'm not sure how to handle quotes
460 2012-01-08T07:19:53 <qxcv> quotes around pipe symbols, or quotes in positional arguments?
461 2012-01-08T07:20:17 <Dragooon> Both
462 2012-01-08T07:20:25 <Dragooon> If quotes should escape or what
463 2012-01-08T07:21:21 <qxcv> that's where regexes come in handy - are you using any regexes at the moment?
464 2012-01-08T07:21:27 <Dragooon> Nope
465 2012-01-08T07:21:29 <Dragooon> I should
466 2012-01-08T07:23:11 <qxcv> btw if you don't want to handle quotes I'd say the mentors are probably okay with it because the MW parser didn't do that beforehand
467 2012-01-08T07:23:52 <qxcv> and AFAICT the spec doesn't explicitly mention the use of quotes
468 2012-01-08T07:24:03 <qxcv> s/spec/reference documentation/
469 2012-01-08T07:25:17 <qxcv> if you really want a way to escape things, backslashes are probably easier to handle either way
470 2012-01-08T07:25:41 <qxcv> so a pipe preceded by a backslash is a literal pipe, and the same with spaces
471 2012-01-08T07:26:07 <qxcv> that way you don't have to check for quotes on either side, just immediately preceding the character in question
472 2012-01-08T07:26:34 <Dragooon> Or I can be more awesome and write a gigantic non-readable regex
473 2012-01-08T07:26:57 <qxcv> ^
474 2012-01-08T07:27:10 <qxcv> remove all the spaces and line breaks if you want to be extra l33t
475 2012-01-08T07:31:03 <qxcv> actually, speaking of unreadable code, here is the first version of the flask web framework the MoinMoin uses: https://github.com/denied/denied/blob/master/deny.py
476 2012-01-08T07:32:05 <qxcv> it was an april fools joke, but people liked it so much that the developer took most of the core ideas and the un-obfuscated code and turned it into Flask
477 2012-01-08T07:32:37 <Dragooon> Really
478 2012-01-08T07:32:38 <Dragooon> ?
479 2012-01-08T07:33:16 <Dragooon> btw, does py use posix or pcre/
480 2012-01-08T07:33:16 <Dragooon> ?
481 2012-01-08T07:34:04 <qxcv> kind of like PCRE
482 2012-01-08T07:34:21 <qxcv> http://docs.python.org/library/re.html see the first paragraph
483 2012-01-08T07:34:36 * Dragooon gets his brain
484 2012-01-08T07:34:43 <qxcv> I'm not sure if they're entirely perl compatible
485 2012-01-08T07:48:53 <Dragooon> (?:([\w-]+)=)?(?:([-\w\s]+)|"(.*?)(?<!\\)"|\'(.*?)(?<!\\)\')
486 2012-01-08T07:48:57 <Dragooon> ^ That did the trick
487 2012-01-08T07:49:36 <qxcv> nice
488 2012-01-08T07:50:01 <qxcv> you might want to used named groups (?P<group_name>...) for readability, though
489 2012-01-08T07:53:12 <Dragooon> Nyah
490 2012-01-08T07:53:19 <Dragooon> :P
491 2012-01-08T07:53:27 <Dragooon> Broke it with \ns and spaces
492 2012-01-08T07:56:58 <qxcv> gtg, brb in 45 min
493 2012-01-08T07:59:01 *** xjjk
494 2012-01-08T08:01:24 <Dragooon> Who is Prashant Kumar?
495 2012-01-08T08:18:21 <Dragooon> If any mentor comes online, please see http://codereview.appspot.com/5517058
496 2012-01-08T08:18:32 <Dragooon> I'm in the room so ping me if you're here
497 2012-01-08T09:11:34 <Dragooon> Who just replied?
498 2012-01-08T09:12:03 <Dragooon> dreimark: there?
499 2012-01-08T09:20:03 *** Dragooon_
500 2012-01-08T09:20:04 *** Dragooon
501 2012-01-08T09:20:05 *** Dragooon_
502 2012-01-08T09:33:16 <dreimark> Dragooon: for regex trainings you can use kodos
503 2012-01-08T09:33:36 <Dragooon> Thanks
504 2012-01-08T09:33:43 <Dragooon> dreimark: is the patch fine?
505 2012-01-08T09:34:07 <dreimark> from the backlog, is that valid media wiki syntax now?
506 2012-01-08T09:34:19 <Dragooon> Yes
507 2012-01-08T09:34:37 <Dragooon> I fixed a couple of bugs as well
508 2012-01-08T09:34:43 <Dragooon> Apart from the one I was working on
509 2012-01-08T09:34:50 <Dragooon> 1.) caption should be the last argument
510 2012-01-08T09:35:00 <Dragooon> 2) spaces were being treated as separator
511 2012-01-08T09:35:38 <dreimark> is there a test for 2)
512 2012-01-08T09:35:44 <Dragooon> Yes
513 2012-01-08T09:35:59 <dreimark> http://codereview.appspot.com/download/issue5517058_5005.diff
514 2012-01-08T09:36:01 <dreimark> which one
515 2012-01-08T09:36:27 <Dragooon> See the last one
516 2012-01-08T09:36:36 <Dragooon> test stuff has a space but is treated as one caption
517 2012-01-08T09:37:13 <Dragooon> Then [[File:Test.png|do=get|arg1=test|arg2=something else]]
518 2012-01-08T09:37:16 <Dragooon> is also there
519 2012-01-08T09:37:33 <Dragooon> 9th one from the top
520 2012-01-08T09:38:08 <Dragooon> Yeah, also one more
521 2012-01-08T09:38:22 <Dragooon> 3) links would not be treated properly unless in a quote
522 2012-01-08T09:43:18 <dreimark> there must be no new line after value = (match.group(2) or match.group(3) or match.group(4)).decode('unicode-escape')
523 2012-01-08T09:43:39 <Dragooon> Okay, I'm not exactly sure of your coding style
524 2012-01-08T09:43:49 <Dragooon> Just copied it from _args_wiki.py
525 2012-01-08T09:44:01 <dreimark> no problem
526 2012-01-08T09:44:19 <Dragooon> what about after the for loop and "return ret"
527 2012-01-08T09:44:21 <Dragooon> ?
528 2012-01-08T09:44:36 <dreimark> not necessaRY too
529 2012-01-08T09:45:03 <Dragooon> ?
530 2012-01-08T09:47:26 <dreimark> same
531 2012-01-08T09:47:35 <dreimark> emtpy line can be removed
532 2012-01-08T09:47:55 <Dragooon> So apart from function def, no empty lines are required
533 2012-01-08T09:47:59 <Dragooon> ?
534 2012-01-08T09:48:34 <dreimark> in some cases it can help to make it better readable but at most it is not needed
535 2012-01-08T09:49:01 <dreimark> and yes for class and def separation it is needed
536 2012-01-08T09:49:08 <dreimark> *required
537 2012-01-08T09:49:15 <dreimark> also imports
538 2012-01-08T09:50:05 <Dragooon> okay, removed unnessary imports
539 2012-01-08T09:50:08 <Dragooon> unnecessary*
540 2012-01-08T09:50:10 <dreimark> alt_text='' why not u'' ?
541 2012-01-08T09:50:20 <Dragooon> s/imports/removed
542 2012-01-08T09:50:25 <Dragooon> s/removed/lines
543 2012-01-08T09:50:34 <Dragooon> dreimark: what do you mean?
544 2012-01-08T09:50:41 <dreimark> + link_args=u'', external_link_url=None, alt_text=''):
545 2012-01-08T09:50:58 <Dragooon> What's wrong?
546 2012-01-08T09:51:06 <dreimark> and where is that alt_text used
547 2012-01-08T09:51:20 <Dragooon> Line 682
548 2012-01-08T09:51:33 <Dragooon> It's for other types of links
549 2012-01-08T09:51:43 <Dragooon> First two or three tests
550 2012-01-08T09:51:51 <Dragooon> It was there before as well, didn't change it
551 2012-01-08T09:52:04 <dreimark> it is now '' not u''
552 2012-01-08T09:52:18 <Dragooon> Ohhhh
553 2012-01-08T09:52:25 <Dragooon> Fixed
554 2012-01-08T09:54:04 <dreimark> what is link_Args[0] ?
555 2012-01-08T09:54:22 <dreimark> what is link_Aargs[0] ?
556 2012-01-08T09:54:24 <dreimark> arrr
557 2012-01-08T09:54:24 <Dragooon> See the comment above
558 2012-01-08T09:54:34 <Dragooon> # Remove the first pipe/space, example of link_args : |arg1|arg2 or " arg1 arg2
559 2012-01-08T09:55:40 <dreimark> ok
560 2012-01-08T09:56:57 <dreimark> + query = None (me has to look at the file) but that looks strange to initialize something with None
561 2012-01-08T09:58:10 <Dragooon> It's so that it doesn't cause problems if no arguments are given
562 2012-01-08T10:00:05 <dreimark> it goes to Iri as parameter
563 2012-01-08T10:00:24 <Dragooon> None is a valid value
564 2012-01-08T10:00:31 <dreimark> yes
565 2012-01-08T10:00:39 <Dragooon> So…what's wrong?
566 2012-01-08T10:01:00 <dreimark> it is correct, if i look at the diff only i dom't have all information
567 2012-01-08T10:01:17 <Dragooon> Ah, okay
568 2012-01-08T10:03:31 <dreimark> tests still run without a problem after your current fixes?
569 2012-01-08T10:03:40 <Dragooon> Yes
570 2012-01-08T10:03:44 <Dragooon> All the old ones as well as new ones
571 2012-01-08T10:08:47 <Dragooon> Should I upload the fixes?
572 2012-01-08T10:08:56 <dreimark> how muchfailing tests do you see
573 2012-01-08T10:09:26 <Dragooon> None?
574 2012-01-08T10:09:49 <Dragooon> test_mediawiki_in.py passes without any errors
575 2012-01-08T10:10:32 <dreimark> http://paste.pocoo.org/show/531656/
576 2012-01-08T10:11:18 <dreimark> this is moin-2 and the patch added, not your repo
577 2012-01-08T10:11:36 <dreimark> with PIL installed
578 2012-01-08T10:12:10 <dreimark> the PEP8 failure is yours
579 2012-01-08T10:14:34 *** Dragooon
580 2012-01-08T10:15:03 *** Dragooon
581 2012-01-08T10:15:15 <Dragooon> back, did I miss something?
582 2012-01-08T10:15:25 <dreimark> 10:08 < Dragooon> test_mediawiki_in.py passes without any errors
583 2012-01-08T10:15:25 <dreimark> 10:08 < dreimark> http://paste.pocoo.org/show/531656/
584 2012-01-08T10:15:25 <dreimark> 10:09 < dreimark> this is moin-2 and the patch added, not your repo
585 2012-01-08T10:15:25 <dreimark> 10:10 < dreimark> with PIL installed
586 2012-01-08T10:15:25 <dreimark> 10:10 < dreimark> the PEP8 failure is yours
587 2012-01-08T10:15:47 <Dragooon> oh that
588 2012-01-08T10:15:50 <Dragooon> Yeah I'll fix it
589 2012-01-08T10:16:03 <dreimark> run always all tests
590 2012-01-08T10:16:27 <dreimark> once before commit at least
591 2012-01-08T10:16:49 <dreimark> Dragooon: have you done a real test in the wiki itself?
592 2012-01-08T10:17:26 <Dragooon> Yeah, the intended behavior seems to be working
593 2012-01-08T10:17:38 <Dragooon> It still doesn't mimic MediaWiki's functionality but that's another issue
594 2012-01-08T10:18:17 <dreimark> I tried this on a wiki page http://paste.pocoo.org/show/531658/
595 2012-01-08T10:18:20 <dreimark> that are your tests
596 2012-01-08T10:18:59 <dreimark> which gives http://paste.pocoo.org/show/bniGGeWBEdQ1H5xpwDvV/
597 2012-01-08T10:19:40 <Dragooon> do=post might be invalid itself
598 2012-01-08T10:20:09 <Dragooon> I put in there to test if args['do'] is being updated correctly
599 2012-01-08T10:20:16 <Dragooon> But it is possible that it's an invalid value for do
600 2012-01-08T10:20:54 <dreimark> add a comment in the test about that
601 2012-01-08T10:21:34 <Dragooon> Done
602 2012-01-08T10:22:08 <dreimark> make a new review please, i want to have a look
603 2012-01-08T10:23:53 <Dragooon> Uploaded
604 2012-01-08T10:26:08 <dreimark> MoinMoin/items/_tests/test_Item.py should be a separate commit this was a different problem
605 2012-01-08T10:26:40 <Dragooon> Ok
606 2012-01-08T10:28:07 <qxcv> dreimark ThomasWaldmann & other mentors: is it ok if I claim an easy bugfix task for https://bitbucket.org/thomaswaldmann/moin-2.0/issue/59/history-misses-search-box ?
607 2012-01-08T10:29:11 <dreimark> qxcv: yes
608 2012-01-08T10:30:48 <dreimark> Dragooon: found a problem
609 2012-01-08T10:31:37 <dreimark> try non ascii in e.g. [[File:myimg.png|'ŧł€ŧł@ſđ˝ſ˝æđ˝æ˝đ']]
610 2012-01-08T10:32:20 <dreimark> [[File:myimg.png|'öööö']]
611 2012-01-08T10:32:28 <Dragooon> what does it say?
612 2012-01-08T10:32:45 <dreimark> http://paste.pocoo.org/show/Z4TPlzGG6C8mcPR8cyZA/
613 2012-01-08T10:34:35 <Dragooon> Hm..not sure why it was being decoded
614 2012-01-08T10:39:24 <Dragooon> Uploaded a new revision
615 2012-01-08T10:41:54 <dreimark> brb 10 mins
616 2012-01-08T11:02:57 <dreimark> Dragooon: please do a practicle test yourself with some none ascii chars and fix the [[File:myimg.png|'öööö']] issue
617 2012-01-08T11:03:08 <dreimark> it should not become \xf6\xf6\xf6\xf6
618 2012-01-08T11:07:46 <Dragooon> Uploaded a fix
619 2012-01-08T11:07:49 <Dragooon> Tested, works
620 2012-01-08T11:12:25 *** bndr
621 2012-01-08T11:12:49 *** raignarok
622 2012-01-08T11:25:02 <bndr> hey! so i try to work on GCI task: http://www.google-melange.com/gci/task/view/google/gci2011/7141269 and i get something like this: http://bit.ly/yno8Nx Is that good? and how many merch designs i must create?
623 2012-01-08T11:27:36 <Dragooon> dreimark: is it looking okay?
624 2012-01-08T11:28:40 * dreimark looks soon working on some other stuff parallel
625 2012-01-08T11:29:24 <Dragooon> I'll be sort of away, so I may reply late
626 2012-01-08T11:29:35 *** greg_f
627 2012-01-08T11:30:06 <dreimark> Dragooon: i guess you tested also some other places where non ascii can be inputted or ?
628 2012-01-08T11:30:27 <Dragooon> I did
629 2012-01-08T11:30:57 <Dragooon> just a couple of random tests though, in middle of something else
630 2012-01-08T11:48:46 <dreimark> Dragooon: that fails [[File:Test.jpg|üna]]
631 2012-01-08T11:48:59 <dreimark> try non ascii for all captions
632 2012-01-08T11:49:14 <dreimark> it shows only na
633 2012-01-08T11:50:38 <dreimark> bndr: I can't access http://bit.ly/yno8Nx can you use http://paste.pocoo.org/
634 2012-01-08T11:51:31 <dreimark> or if it is a page on moinmo.in give the link without bit.ly
635 2012-01-08T11:52:01 <dreimark> you should describe it on moinmo.in
636 2012-01-08T11:53:52 <Dragooon> dreimark: I'll have a look afterwards, I need to go atm
637 2012-01-08T11:53:58 <dreimark> ok
638 2012-01-08T11:54:52 <bndr> can u say is it good? http://goo.gl/DT3op
639 2012-01-08T11:55:34 <dreimark> i can't read
640 2012-01-08T11:55:41 <dreimark> give a qulified url
641 2012-01-08T11:56:00 <dreimark> or best write it onto a page of moinmo.in
642 2012-01-08T12:00:08 <dreimark> bbl
643 2012-01-08T12:19:00 *** raignarok
644 2012-01-08T12:50:48 *** raignarok
645 2012-01-08T13:15:12 *** raignarok
646 2012-01-08T13:20:52 *** raignarok
647 2012-01-08T13:33:16 *** raignarok
648 2012-01-08T13:42:42 *** bndr
649 2012-01-08T14:32:49 *** qxcv
650 2012-01-08T15:05:49 <Dragooon> ThomasWaldmann: there?
651 2012-01-08T15:06:03 <Dragooon> Or eSyr, TheSheep
652 2012-01-08T15:33:20 <Dragooon> dreimark: ?
653 2012-01-08T15:36:16 *** raignarok
654 2012-01-08T16:09:28 <Dragooon> dreimark: I've uploaded a new patch which fixes the unicoe issue, also added a test for Unicode
655 2012-01-08T17:22:53 *** bndr
656 2012-01-08T17:24:05 <bndr> hi! i work on GCI task: http://www.google-melange.com/gci/task/view/google/gci2011/7125293 can anyone give me account data?
657 2012-01-08T17:27:45 <ThomasWaldmann> bndr: see query
658 2012-01-08T17:29:38 <Dragooon> ThomasWaldmann: Can you have a look at my bugfix?
659 2012-01-08T17:30:41 <Dragooon> http://codereview.appspot.com/5517058/
660 2012-01-08T17:32:14 <ThomasWaldmann> soon
661 2012-01-08T17:32:58 <Dragooon> Ok, thank
662 2012-01-08T17:33:01 <Dragooon> thanks*
663 2012-01-08T17:54:40 <bilal> ThomasWaldmann: As for my pull request on the "empty content gives ugly rendering" fix, I did give it a practical try and it works
664 2012-01-08T17:56:00 <ThomasWaldmann> i had a quick look. my first idea was somehow "do we want to keep the container element the same?".
665 2012-01-08T18:00:35 <bilal> see my new comment on melange
666 2012-01-08T18:00:37 <bilal> g2g
667 2012-01-08T18:30:12 <ThomasWaldmann> ok, back to moin stuff :)
668 2012-01-08T18:30:20 <ThomasWaldmann> Dragooon: looking at it now
669 2012-01-08T18:30:27 <Dragooon> Oh no
670 2012-01-08T18:34:46 <ThomasWaldmann> Dragooon: where are the mediawiki docs for File: links?
671 2012-01-08T18:35:05 <Dragooon> http://www.mediawiki.org/wiki/Help:Images
672 2012-01-08T18:35:36 <Dragooon> ThomasWaldmann: ^
673 2012-01-08T18:39:13 <ThomasWaldmann> do you know how they know whether the last element is a caption or not?
674 2012-01-08T18:40:07 <Dragooon> I'd say if it's suffixed with px it's the width argument otherwise it's caption
675 2012-01-08T18:40:18 <Dragooon> As long as it's unnamed
676 2012-01-08T18:40:30 <Dragooon> Couldn't find anything that says otherwise
677 2012-01-08T18:40:46 <Dragooon> Been a long time since I developed MediaWiki
678 2012-01-08T18:41:02 <ThomasWaldmann> yeah, looks like caption is somehow default if nothing else matches
679 2012-01-08T18:41:05 <Dragooon> [[File:filename.extension|options|caption]]
680 2012-01-08T18:41:12 <Dragooon> So they presume caption to be last
681 2012-01-08T18:41:25 <ThomasWaldmann> which makes caption somehow an option also
682 2012-01-08T18:41:39 <Dragooon> To an extent, yea.
683 2012-01-08T18:41:44 <ThomasWaldmann> If a parameter does not match any of the other possibilities, it is assumed to be the caption text.
684 2012-01-08T18:42:06 <Dragooon> Not completely sure, need to test
685 2012-01-08T18:43:23 <Dragooon> Let me install MediaWiki and give it a spin
686 2012-01-08T18:46:45 <Dragooon> It's installing :D
687 2012-01-08T18:47:11 <Dragooon> That's one stupid installer <_<
688 2012-01-08T18:55:48 <Dragooon> yeah okay
689 2012-01-08T18:56:12 <Dragooon> The last parameter which doesn't match is taken as caption
690 2012-01-08T18:56:14 <Dragooon> ThomasWaldmann: ^
691 2012-01-08T18:56:47 <Dragooon> Even if it's arg=val type thing
692 2012-01-08T18:56:55 <Dragooon> Then it just shows arg=val in the caption
693 2012-01-08T18:57:10 <ThomasWaldmann> and in the middle, if it doesn't match?
694 2012-01-08T18:57:42 <Dragooon> Still taken as caption
695 2012-01-08T18:57:46 <ThomasWaldmann> ok
696 2012-01-08T18:57:52 <Dragooon> [[File:4T4.jpg|test=caption test|border]]
697 2012-01-08T18:57:57 <Dragooon> Will render test=caption test as caption
698 2012-01-08T18:58:14 <Dragooon> That's why I filed that bug report ^_^
699 2012-01-08T19:00:18 *** greg_f
700 2012-01-08T19:01:12 <ThomasWaldmann> ok, first review done
701 2012-01-08T19:02:20 <Dragooon> Eating, will reply in a bit
702 2012-01-08T19:05:03 <bndr> should i use "MoinMoin" instead of "MoinMoin Wiki" on tsirts and other merch?
703 2012-01-08T19:14:17 <dreimark> e
704 2012-01-08T19:14:18 <dreimark> re
705 2012-01-08T19:14:24 <Dragooon> ThomasWaldmann: How does named parameter work?
706 2012-01-08T19:14:31 <dreimark> Dragooon: hve you fixed encoding issues?
707 2012-01-08T19:14:35 <Dragooon> Yes
708 2012-01-08T19:14:42 <ThomasWaldmann> bndr: people who do not recognize the logo already maybe won't get much out of "MoinMoin" either
709 2012-01-08T19:15:40 <ThomasWaldmann> Dragooon: ?
710 2012-01-08T19:15:51 <Dragooon> ThomasWaldmann: You said to use named parameters in regex result
711 2012-01-08T19:16:02 <Dragooon> named groups*
712 2012-01-08T19:16:42 <ThomasWaldmann> Dragooon: moin is full of usage of this, see the parser regexes
713 2012-01-08T19:16:48 <Dragooon> Ah okay
714 2012-01-08T19:17:00 <ThomasWaldmann> there are also docs about python re module
715 2012-01-08T19:22:39 <dreimark> Dragooon: you can use kodos to test your regex
716 2012-01-08T19:24:02 <Dragooon> Replied
717 2012-01-08T19:26:51 <ThomasWaldmann> well, maybe as a general rule: don't put up stuff that looks like doing something special / having some semantics, if you just want to test special chars or syntax
718 2012-01-08T19:29:09 <Dragooon> I see, okay
719 2012-01-08T19:33:47 <Dragooon> Uploaded another revision
720 2012-01-08T19:38:06 <ThomasWaldmann> Dragooon: better. regarding that new arg parser: don't we parse that way anyway?
721 2012-01-08T19:38:14 <Dragooon> Nop
722 2012-01-08T19:38:19 <Dragooon> join breaks on spaces
723 2012-01-08T19:38:22 <Dragooon> moin*
724 2012-01-08T19:38:30 <Dragooon> Mediawiki breaks on pipes
725 2012-01-08T19:38:44 <Dragooon> Plus quite a few characters are not supports in Moin's parser
726 2012-01-08T19:38:49 <ThomasWaldmann> and if not, could you refer to the other parser from there and point out the differences in a comment?
727 2012-01-08T19:40:52 <Dragooon> Uploaded
728 2012-01-08T19:44:27 <ThomasWaldmann> i don't see a src change
729 2012-01-08T19:45:05 <Dragooon> <_<
730 2012-01-08T19:45:11 <Dragooon> Now?
731 2012-01-08T19:46:16 <ThomasWaldmann> ok
732 2012-01-08T19:49:00 <ThomasWaldmann> did you run all the tests after your last change?
733 2012-01-08T19:49:29 <Dragooon> I did
734 2012-01-08T19:49:41 <Dragooon> But a couple of hours back
735 2012-01-08T19:49:49 <Dragooon> Haven't run those after last couple of revisions
736 2012-01-08T19:52:53 <ThomasWaldmann> another review done
737 2012-01-08T19:53:07 <ThomasWaldmann> Dragooon: run the tests after doing the fixes suggested in latest review
738 2012-01-08T19:53:16 <ThomasWaldmann> all the tests
739 2012-01-08T19:53:59 <ThomasWaldmann> in general, len(x) > 0 is rarely used in python, because x has same truth value usually
740 2012-01-08T19:54:31 <ThomasWaldmann> this is because empty lists, dicts, strings, ... are falsy, non-empty are truthy
741 2012-01-08T19:55:51 <Dragooon> I see
742 2012-01-08T19:56:05 <Dragooon> Wasn't sure how that works in Python, so I decided to go the safe way
743 2012-01-08T19:57:01 <Dragooon> Running all the tests
744 2012-01-08T20:01:11 <Dragooon> ThomasWaldmann: Uploaded another revision
745 2012-01-08T20:01:15 <Dragooon> Passed all the tests
746 2012-01-08T20:07:20 <ThomasWaldmann> ok, looks good. did you do some practical tests also?
747 2012-01-08T20:07:50 <Dragooon> Yea, looks okay
748 2012-01-08T20:08:19 <ThomasWaldmann> ok, make some clean changesets
749 2012-01-08T20:08:42 <Dragooon> Multiple?
750 2012-01-08T20:09:21 <ThomasWaldmann> iirc you fixed an issue of your last task also, that should be separate
751 2012-01-08T20:09:44 <Dragooon> Oh, that's separate
752 2012-01-08T20:12:48 <Dragooon> Pushed to my repository
753 2012-01-08T20:12:55 <Dragooon> bitbucket.org/Dragooon/moin-2.0
754 2012-01-08T20:15:08 <Dragooon> bitbucket has some beautiful diff colors and fonts
755 2012-01-08T20:15:19 *** RogerHaase
756 2012-01-08T20:16:31 <Dragooon> ThomasWaldmann: ^
757 2012-01-08T20:18:34 * ThomasWaldmann pulls
758 2012-01-08T20:21:30 <ThomasWaldmann> Dragooon: submit something to melange
759 2012-01-08T20:21:54 <Dragooon> Done
760 2012-01-08T20:23:17 <Dragooon> Thanks :D
761 2012-01-08T20:23:26 <ThomasWaldmann> :)
762 2012-01-08T20:23:54 <Dragooon> Any suggestions for another task or is it back to issue tracker?
763 2012-01-08T20:24:28 *** RogerHaase
764 2012-01-08T20:31:13 <ThomasWaldmann> Dragooon: close the related bb issue please, link to hg.moinmo.in for the fix cs
765 2012-01-08T20:31:29 <ThomasWaldmann> #134
766 2012-01-08T20:32:57 <Dragooon> Done
767 2012-01-08T20:33:19 <ThomasWaldmann> well, an important issues is #124
768 2012-01-08T20:33:33 <ThomasWaldmann> but while it is easy, it is a lot of work
769 2012-01-08T20:34:13 <ThomasWaldmann> considering both, i think it would qualify for "medium"
770 2012-01-08T20:34:54 <ThomasWaldmann> "problem: str.format is used at a thousand places this way, needs global review / fixing."
771 2012-01-08T20:35:36 <Dragooon> Kinda boring
772 2012-01-08T20:36:03 <ThomasWaldmann> yup :)
773 2012-01-08T20:36:45 <ThomasWaldmann> #129, suspected easy
774 2012-01-08T20:37:30 <ThomasWaldmann> (i didn't search for the cause yet, though)
775 2012-01-08T20:38:25 <Dragooon> Any medium/hard stuff to do that are sort of challenging?
776 2012-01-08T20:38:37 <Dragooon> Would love to improve my Python
777 2012-01-08T20:47:31 <ThomasWaldmann> you use linux, mac or windows?
778 2012-01-08T20:50:22 <Dragooon> Mac and Windows
779 2012-01-08T20:50:30 <Dragooon> But can boot into Linux
780 2012-01-08T20:51:26 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/66/test-moin-load-save-on-windows-fix-if
781 2012-01-08T20:51:46 <ThomasWaldmann> easy, needs some research and like a few lines of code
782 2012-01-08T20:52:02 <ThomasWaldmann> and testing on windows
783 2012-01-08T20:52:21 <Dragooon> what would be the difficulty of task?
784 2012-01-08T20:52:43 <ThomasWaldmann> easy
785 2012-01-08T20:52:48 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/19/user-settings-are-incomplete
786 2012-01-08T20:53:13 <ThomasWaldmann> this is a hard one. you likely need to think/learn a lot about flatland
787 2012-01-08T20:53:44 <Dragooon> That sounds fun
788 2012-01-08T20:54:29 <ThomasWaldmann> you've been warned :D
789 2012-01-08T20:54:32 <Dragooon> One just needs to implement the settings or also the associated pages?
790 2012-01-08T20:54:54 <ThomasWaldmann> the settings are basically there in the user profile
791 2012-01-08T20:55:01 <ThomasWaldmann> but there is currently no UI for them
792 2012-01-08T20:55:12 <Dragooon> Oh, so I just need to add the UI?
793 2012-01-08T20:55:35 <ThomasWaldmann> we have some jinja2 macros and flatland based forms for simpler stuff, but not for that complex stuff
794 2012-01-08T20:56:06 <Dragooon> Subscribed pages would list the pages subcribed
795 2012-01-08T20:56:11 <Dragooon> What does quick links do?
796 2012-01-08T20:56:16 <ThomasWaldmann> simpler stuff == values like strings, integers, ... - complex stuff == values that are lists of something
797 2012-01-08T20:56:43 <ThomasWaldmann> you visit a page, find it interesting, and add a link to that page to the navi bar
798 2012-01-08T20:57:02 <ThomasWaldmann> that's quicklinking
799 2012-01-08T20:57:04 <Dragooon> Ah, so what all should the UI do apart from listing them?
800 2012-01-08T20:57:16 <izibi> ThomasWaldmann: i guess he should first pull the changes from my repo before working on that task, right?
801 2012-01-08T20:57:18 <ThomasWaldmann> subscribing is getting notified by email if a page changes
802 2012-01-08T20:57:43 <ThomasWaldmann> izibi: hmm, yeah, or rather i should do that...
803 2012-01-08T20:57:47 *** bndr
804 2012-01-08T21:00:13 <ThomasWaldmann> Dragooon: btw, flatland has quite some docs, but zero about jinja2 integration
805 2012-01-08T21:00:31 <Dragooon> This task keeps getting better
806 2012-01-08T21:00:51 <ThomasWaldmann> hehe
807 2012-01-08T21:00:55 <Dragooon> I'm still doubtful about what all UI should do
808 2012-01-08T21:01:05 <Dragooon> Apart from listing, what else will it handle?
809 2012-01-08T21:01:38 <ThomasWaldmann> in moin 1.x and for quicklinks, we had just a textarea to edit them all in one go
810 2012-01-08T21:02:24 <Dragooon> And subscribed?
811 2012-01-08T21:02:26 <ThomasWaldmann> for moin2 it could be similar or alternatively maybe something more list-like with some controls to remove each entry
812 2012-01-08T21:03:35 <ThomasWaldmann> subscribed was also a textarea, but more complex semantics, because subscriptions can not just be pagenames, but also regexes
813 2012-01-08T21:04:23 <Dragooon> Okay, will research on this tomorrow and decide whether I can do this
814 2012-01-08T21:04:32 <ThomasWaldmann> cool :)
815 2012-01-08T21:04:45 <Dragooon> Would love another 6 points
816 2012-01-08T21:04:58 <izibi> you're insane :P
817 2012-01-08T21:05:08 <Dragooon> Hell yeah
818 2012-01-08T21:09:24 *** raignarok
819 2012-01-08T21:12:25 <ThomasWaldmann> izibi: http://hg.moinmo.in/moin/2.0
820 2012-01-08T21:12:43 <ThomasWaldmann> can you update the related bb issues?
821 2012-01-08T21:13:25 <izibi> yup. no more notifications here? ;)
822 2012-01-08T21:13:45 <ThomasWaldmann> CIA-59: peng
823 2012-01-08T21:14:01 * Dragooon kicks CIA-59
824 2012-01-08T21:14:02 <CIA-59> ow
825 2012-01-08T21:17:08 <izibi> done
826 2012-01-08T21:20:52 *** Dragooon
827 2012-01-08T21:25:49 * ThomasWaldmann updated the related melange entries
828 2012-01-08T23:20:49 *** MattMaker
829 2012-01-08T23:35:20 *** RogerHaase
830 2012-01-08T23:38:19 *** MattMaker
831
