1 2011-12-25T01:58:31 *** bilal
2 2011-12-25T01:58:32 *** bilal
3 2011-12-25T02:05:46 *** bilal
4 2011-12-25T02:06:21 *** bilal
5 2011-12-25T02:19:43 <bilal> ThomasWaldmann: I've made the appropriate change in my branch and updated pull request: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/20/fix-three-test-failures
6 2011-12-25T02:54:35 *** bilal
7 2011-12-25T03:42:03 *** bilal
8 2011-12-25T03:46:35 <bilal> ThomasWaldmann: updated, could you check now? Sorry for repeatedly pinging you :/
9 2011-12-25T03:48:56 <ThomasWaldmann> yup :)
10 2011-12-25T03:51:16 <ThomasWaldmann> ok, looks good, running tests...
11 2011-12-25T03:53:32 <CIA-59> Bilal Akhtar <bilalakhtar@ubuntu.com> default * 1180:1c5a013b9ebd 2.0/MoinMoin/items/ (__init__.py _tests/test_Item.py):
12 2011-12-25T03:53:32 <CIA-59> Fix the three failing tests.
13 2011-12-25T03:53:32 <CIA-59> 1) For the DummyItem failures, just add a dummy destroy_all_revisions function
14 2011-12-25T03:53:32 <CIA-59> 2) For the image diff output difference, just use the escaped version of '+' in +diffraw
15 2011-12-25T03:53:32 <CIA-59> Bilal Akhtar <bilalakhtar@ubuntu.com> default * 1181:e8fdcafe8cdd 2.0/MoinMoin/items/_tests/test_Item.py: change assert statement in such a way so that it succeeds with both older and newer (0.8.2+) versions of werkzeug
16 2011-12-25T03:53:33 <CIA-59> Bilal Akhtar <bilalakhtar@ubuntu.com> default * 1182:bab76fc1ab45 2.0/MoinMoin/items/_tests/test_Item.py: Improve comment above assert line, and remove the Titanic-like verses from the assert statement that made it unsinkable :)
17 2011-12-25T03:53:34 <CIA-59> Bilal Akhtar <bilalakhtar@ubuntu.com> default * 1183:50ff3067234a 2.0/MoinMoin/items/_tests/test_Item.py: Simplify assert statement, thanks Thomas.
18 2011-12-25T03:53:35 <CIA-59> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1184:3cb39729ee3d 2.0/MoinMoin/items/ (__init__.py _tests/test_Item.py): merged
19 2011-12-25T03:53:48 <bilal> thanks!
20 2011-12-25T03:54:01 <ThomasWaldmann> can you close any related bug on the issue tracker?
21 2011-12-25T03:54:10 * bilal searches
22 2011-12-25T03:54:25 <ThomasWaldmann> (give a link in the closing comment, to the cs on the main repo)
23 2011-12-25T03:55:24 <bilal> well, I wasn't able to find any bug related to either the test failures or the %2B change or anything else
24 2011-12-25T03:55:54 <ThomasWaldmann> ok
25 2011-12-25T04:32:57 *** bilal
26 2011-12-25T05:40:28 *** bilal
27 2011-12-25T05:40:37 *** bilal
28 2011-12-25T05:41:43 *** bilal
29 2011-12-25T07:07:21 <dreimark> python.org down
30 2011-12-25T07:10:11 <dreimark> what changed http://localhost:8080/ to http://127.0.0.1:8080 ? and why ?
31 2011-12-25T07:20:09 <dreimark> ThomasWaldmann: http://neyeon.com/p/jquery.dform/doc/files2/examples-txt.html#Examples
32 2011-12-25T08:34:43 *** qxcv
33 2011-12-25T09:37:50 *** qxcv
34 2011-12-25T09:52:36 *** qxcv
35 2011-12-25T12:15:25 *** pkumar
36 2011-12-25T13:15:52 <ThomasWaldmann> moin
37 2011-12-25T13:16:04 <ThomasWaldmann> dreimark: we already use flatland for that (and more)
38 2011-12-25T13:29:17 *** raignarok
39 2011-12-25T13:53:27 *** raignarok
40 2011-12-25T13:55:37 *** raignarok
41 2011-12-25T13:57:36 *** raignarok
42 2011-12-25T14:09:03 *** qxcv
43 2011-12-25T14:42:49 *** RogerHaase
44 2011-12-25T14:57:39 <ThomasWaldmann> dreimark: with xmlrpc_get_format you are not conforming to the usual naming convention used for our xmlrpc calls
45 2011-12-25T14:58:36 <ThomasWaldmann> also, for what did you need this?
46 2011-12-25T15:03:41 <ThomasWaldmann> instead of hardcoding key == 'format', you could also give the key as parameter and return the value as result - so it can be used for any processing instruction.
47 2011-12-25T15:06:59 <ThomasWaldmann> also, you maybe have seen that most of those calls have a basic form and also a *Version form that works on some specific revision, not just the default one.
48 2011-12-25T15:09:08 <ThomasWaldmann> so, please check whether this rpc method is needed. if so, fix it (see above), if not, remove it.
49 2011-12-25T15:21:31 *** raignarok
50 2011-12-25T15:26:22 *** raignarok
51 2011-12-25T15:34:55 *** bilal
52 2011-12-25T15:58:48 *** bilal
53 2011-12-25T16:12:36 *** raignarok
54 2011-12-25T16:19:00 *** raignarok
55 2011-12-25T16:21:40 *** raignarok
56 2011-12-25T16:49:08 <CIA-59> Thomas Waldmann <tw AT waldmann-edv DOT de> editlogfixes * 5812:1d78194ecfeb 1.9/MoinMoin/script/migration/_conv160a.py: apply same fix to _conv160a as done for _conv160 in cs e1e79fab9cca
57 2011-12-25T16:49:08 <CIA-59> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5813:7d636ee769da 1.9/ (5 files in 4 dirs): merge editlogfixes branch
58 2011-12-25T16:49:09 <CIA-59> Thomas Waldmann <tw AT waldmann-edv DOT de> editlogfixes * 5814:8a3755a601a8 1.9/: closing editlogfixes branch, was merged into default branch
59 2011-12-25T17:50:58 *** raignarok
60 2011-12-25T18:06:06 <RogerHaase> dreimark: re. http://localhost:8080/, it was changed per issue #128. I just reopened it as there seem to be other issues: cannot login with Opera or Chrome on 127.0.0.1
61 2011-12-25T18:27:01 <izibi> btw what are the requirements for becoming an org at gci? i have enough tasks to do in my personal projects xD
62 2011-12-25T18:34:56 <dreimark> ThomasWaldmann: ok, yes thought also about parameter, have to look at other datatypes too
63 2011-12-25T18:35:51 <dreimark> I need the method for the case one has rst as default markup in wikiconfig and uses others on pages
64 2011-12-25T18:36:36 <dreimark> RogerHaase: ok, i wondered because localhost was set to 127.0.0.1 in my hosts file
65 2011-12-25T18:37:44 <dreimark> izibi: you need to have a gsoc project beforehand, gci is a set of projects selected from that
66 2011-12-25T18:37:58 <dreimark> after they show there interests
67 2011-12-25T18:40:59 <dreimark> izibi: what is your personal project
68 2011-12-25T18:51:39 <izibi> dreimark: a podcatcher for android
69 2011-12-25T18:51:54 <izibi> it somehow works at the moment but it's far from a release ;)
70 2011-12-25T18:52:35 <izibi> and of course i have many other ideas. but yeah, they're only ideas at the moment ;)
71 2011-12-25T18:53:24 <izibi> "this piece of software sucks. i have to write something on my own" :D
72 2011-12-25T18:54:00 <dreimark> izibi: one way is to find an umbrella org for gsoc
73 2011-12-25T19:00:01 *** raignarok
74 2011-12-25T19:08:01 *** raignarok
75 2011-12-25T19:27:33 <dreimark> ThomasWaldmann: http://paste.pocoo.org/show/525798/ i change it to something like this (think a little bit more about the names)
76 2011-12-25T19:31:51 <ThomasWaldmann> dreimark: no. just read the file you are modifying, so you get the style of the API.
77 2011-12-25T20:07:06 *** raignarok
78 2011-12-25T20:27:39 <dreimark> oh
79 2011-12-25T20:57:12 <izibi> http://codereview.appspot.com/5504083/ updated. maybe someone can try it out and give some feedback
80 2011-12-25T20:58:51 *** pkumar
81 2011-12-25T21:02:30 <ThomasWaldmann> izibi: it is still basically working as before, right?
82 2011-12-25T21:03:13 <ThomasWaldmann> is there a problem why you don't simplify it?
83 2011-12-25T21:07:21 <izibi> ThomasWaldmann: what do you want to simplify?
84 2011-12-25T21:08:49 <izibi> i don't see that much room for improvement if you want tabs and submitting via ajax
85 2011-12-25T21:09:24 <ThomasWaldmann> hmm, i think we talked already about non-ajax
86 2011-12-25T21:10:06 <izibi> huh? did we? :D
87 2011-12-25T21:11:37 <ThomasWaldmann> well, i already noted whether the complicated mechanisms you've implemented are really needed
88 2011-12-25T21:12:40 <izibi> which part is too complicated?
89 2011-12-25T21:12:40 <ThomasWaldmann> and suggested that you could just show the currently active stuff and hide the non-active stuff (except the tabs for it, of course)
90 2011-12-25T21:12:47 <izibi> there are 3 parts in the javascript
91 2011-12-25T21:12:54 <izibi> one that makes all the tab stuff work
92 2011-12-25T21:13:02 <izibi> one for change indicators on the tabs
93 2011-12-25T21:13:12 <izibi> and one for submitting the forms via ajax
94 2011-12-25T21:14:00 <izibi> ThomasWaldmann: what do you mean? i don't really understand what you want to say ;)
95 2011-12-25T21:15:26 <izibi> hiding non-active stuff is what tabs do ;)
96 2011-12-25T21:15:27 <ThomasWaldmann> i think the whole stuff could be as easy as using ONE form for all, some divs for the misc. tabs' contents and some tabs that have a similar id as the divs
97 2011-12-25T21:16:24 <ThomasWaldmann> first tab will be the selected at the beginning. it is highlighted and the respective div is displayed.
98 2011-12-25T21:17:16 <ThomasWaldmann> if you click on another tab, it'll deselect all divs, then select that one. hide all divs, display the respective one.
99 2011-12-25T21:17:41 <ThomasWaldmann> if you click on submit, it'll submit the form
100 2011-12-25T21:17:46 <izibi> that's what happens but there is one form per tab
101 2011-12-25T21:17:53 <ThomasWaldmann> that's all and should be rather few code.
102 2011-12-25T21:18:42 <ThomasWaldmann> my idea is completely without ajax
103 2011-12-25T21:19:44 <ThomasWaldmann> do you see any problem with that?
104 2011-12-25T21:20:23 <izibi> i already discussed that with dreimark and TheSheep and the outcome was to use one form per tab
105 2011-12-25T21:20:35 <ThomasWaldmann> url?
106 2011-12-25T21:20:48 <izibi> here. some day ago
107 2011-12-25T21:21:42 <izibi> Dec 18
108 2011-12-25T21:25:00 <dreimark> http://moinmo.in/MoinMoinChat/Logs/moin-dev/2011-12-18
109 2011-12-25T21:31:25 <ThomasWaldmann> (16:47) < TheSheep> izibi: maybe just a single form with indication of what has been changed is enough
110 2011-12-25T21:31:39 <ThomasWaldmann> that was the last thing at the end of the discussion
111 2011-12-25T21:32:27 <ThomasWaldmann> and the primary argument for ajax was code reusability for the item views display. so, is your code reusable for that?
112 2011-12-25T21:33:35 <izibi> you'd have to add some lines of code to load the tabs there but apart from that yes
113 2011-12-25T21:35:30 <ThomasWaldmann> ok, i maybe can have a look at it later, but now I have to pack some stuff for traveling to 28c3...
114 2011-12-25T21:36:35 <izibi> and with one big form there might be other problems like when you want to add other stuff to the tabs like the quicklinks or subscription list
115 2011-12-25T23:25:19 *** RogerHaase
116 2011-12-25T23:26:13 *** bilal
117 2011-12-25T23:26:14 *** bilal
118 2011-12-25T23:37:48 <CIA-59> Reimar Bauer <rb.proj AT googlemail DOT com> default * 5815:a7b3ccda38d8 1.9/MoinMoin/xmlrpc/__init__.py: MoinMoin.xmlrpc: reverted 83fe7e86cc0b
