1 2011-12-18T00:27:59 <izibi> ThomasWaldmann: should i create an issue for this test? or did you close it because it's completely done? ;)
2 2011-12-18T00:30:00 <izibi> btw the openintents guys have an interesting idea: "Check GCI translation tasks (easy)" :D
3 2011-12-18T00:38:52 *** raignarok_
4 2011-12-18T00:40:15 *** raignarok
5 2011-12-18T00:40:29 *** raignarok_
6 2011-12-18T00:57:47 <ThomasWaldmann> haha
7 2011-12-18T00:58:36 <ThomasWaldmann> that test is strange. it somehow tests that something is not working in cpython and then fails because it is working in pypy. :D
8 2011-12-18T01:01:44 *** raignarok
9 2011-12-18T01:09:29 <ThomasWaldmann> izibi:
10 2011-12-18T02:30:52 <cdbs> Hi, I'm trying to run the unit tests, is "python setup.py test" the right way to do that?
11 2011-12-18T02:43:34 <cdbs> that didn't work, anyone?
12 2011-12-18T02:54:26 <cdbs> ah, got it, py.test in virtualenv
13 2011-12-18T03:10:22 <ThomasWaldmann> yup
14 2011-12-18T03:11:57 <ThomasWaldmann> cdbs: btw, that is even documented :)
15 2011-12-18T03:34:34 <ThomasWaldmann> https://www.transifex.net/projects/p/MoinMoin/resource/moinmoinpot/ we've got quite some new strings
16 2011-12-18T03:45:21 <cdbs> ThomasWaldmann: In my test run, 2 tests failed. If I were to fix those tests, would I be able to complete this task? http://www.google-melange.com/gci/task/view/google/gci2011/7176231
17 2011-12-18T04:00:02 <ThomasWaldmann> 2 is normal
18 2011-12-18T04:02:26 <ThomasWaldmann> cdbs: well, maybe it is rather easy than medium to just fix it. but if you make sure that it is a GOOD fix, medium would be appropriate maybe.
19 2011-12-18T04:04:18 <ThomasWaldmann> just adding 2 dummy methods to make the attribute error go away would rather qualify as easy, so it depends whether there can be something more elegant. I didn't look deeply at it yet, so I can't tell whether there is a better way.
20 2011-12-18T04:05:12 <ThomasWaldmann> and as both fails are same issue, it is just one task, of course :)
21 2011-12-18T04:08:05 <cdbs> ThomasWaldmann: So, would fixing 2 failed and 1 skipped test do it?
22 2011-12-18T04:11:14 <ThomasWaldmann> maybe it is better to claim another task for another issue
23 2011-12-18T04:22:17 <cdbs> I'll have a go at this one, then see
24 2011-12-18T04:22:41 <cdbs> ah, well, un-claimed it
25 2011-12-18T04:27:09 <ThomasWaldmann> ehrm, i didn't mean "don't claim that task", i meant "claim 2 tasks for 2 issues"
26 2011-12-18T04:31:21 <ThomasWaldmann> ehrm, i didn't mean "don't claim that task", i meant "claim 2 tasks for 2 different issues"
27 2011-12-18T04:31:33 <ThomasWaldmann> cdbs: ^^
28 2011-12-18T04:32:00 <cdbs> ThomasWaldmann: ohk
29 2011-12-18T04:32:29 <cdbs> now, I'll complete the one which I just started, and then will look at that one after I'm done with this
30 2011-12-18T04:32:55 <cdbs> sh*t, I'll need to download flask-themes manually it seems
31 2011-12-18T04:35:13 <cdbs> ThomasWaldmann: Well, why is the flask-themes requirement 0.1.3.1?
32 2011-12-18T04:36:08 <cdbs> ah, I get the link in the setup.py
33 2011-12-18T04:36:08 <cdbs> thanks
34 2011-12-18T04:38:11 <ThomasWaldmann> cdbs: because the 0.1.3 has issues with theme templates
35 2011-12-18T04:38:20 <ThomasWaldmann> and flask 0.8.x
36 2011-12-18T04:38:51 <ThomasWaldmann> i did a quick fix for that in my fork of it
37 2011-12-18T04:39:33 <ThomasWaldmann> if you just use the quickinstall script, it should get all you need
38 2011-12-18T04:57:36 <cdbs> ThomasWaldmann: there? I've taken up this GCI task: http://www.google-melange.com/gci/task/view/google/gci2011/7241224
39 2011-12-18T04:57:55 <cdbs> ThomasWaldmann: and then taken issue #130 and fixed it here: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/17/fix-issue-130-account_create-fails
40 2011-12-18T10:11:00 <izibi> http://www.google-melange.com/gci/task/view/google/gci2011/7167202
41 2011-12-18T10:11:02 <izibi> http://www.google-melange.com/gci/task/view/google/gci2011/7172300
42 2011-12-18T10:11:30 <izibi> don't these tasks conflict somehow?
43 2011-12-18T10:29:14 *** raignarok
44 2011-12-18T10:44:16 <dreimark> izibi: why?
45 2011-12-18T10:48:05 <izibi> dreimark: you have no filesystem on GAE. so defining a filesystem structure for a wiki instance won't work there
46 2011-12-18T10:56:26 <izibi> i'd like to "fix" the following two bugs:
47 2011-12-18T10:56:28 <izibi> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/20/user-settings-and-other-forms-also-are
48 2011-12-18T10:56:34 <izibi> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/104/user-settings-usersettings
49 2011-12-18T10:57:09 <izibi> is this 1 or 2 tasks (as they're closely related) and which difficuty/ies?
50 2011-12-18T11:07:04 *** qxcv
51 2011-12-18T11:08:17 <dreimark> izibi: there is another one related
52 2011-12-18T11:08:28 <dreimark> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/19/user-settings-are-incomplete
53 2011-12-18T11:08:36 <dreimark> this would count hard
54 2011-12-18T11:09:08 <dreimark> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/104/user-settings-usersettings
55 2011-12-18T11:09:32 <dreimark> done in a way not only for usersettings I currently would say it is medium
56 2011-12-18T11:11:01 <dreimark> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/20/user-settings-and-other-forms-also-are
57 2011-12-18T11:11:13 *** pkumar
58 2011-12-18T11:11:15 <dreimark> would count as easy
59 2011-12-18T11:12:03 <izibi> what exactly does different views of an item mean? view/edit/history/...
60 2011-12-18T11:12:27 <izibi> basically the blue bar at the top?
61 2011-12-18T11:12:31 <dreimark> yes
62 2011-12-18T11:14:21 <izibi> well then there'd be two rows of tabs. i don't think this will look very good
63 2011-12-18T11:14:57 <izibi> and i think stuff like delete isn't really a different view, more like an action you can do
64 2011-12-18T11:15:56 <dreimark> yes, some are not real views.
65 2011-12-18T11:16:23 <izibi> or download. this doesn't even show anything, it just sends the item
66 2011-12-18T11:18:26 <dreimark> some don't need tabs. They are just functions in one tab
67 2011-12-18T11:19:50 <izibi> i could think of some kind of actions drop down menu
68 2011-12-18T11:19:55 <dreimark> if we for example have sections or transclusions each of the items can have their own ui elements
69 2011-12-18T11:20:57 <dreimark> the drop down has issues if it becomes too long. we had those in 1.x people don't scroll
70 2011-12-18T11:22:25 <izibi> i guess i'll just do it for the settings first and then we'll see how well it can be adopted to the item views
71 2011-12-18T11:22:45 <dreimark> ok
72 2011-12-18T11:25:46 <izibi> http://www.google-melange.com/gci/task/view/google/gci2011/7170218 claimed
73 2011-12-18T11:28:21 <dreimark> assigned
74 2011-12-18T11:33:46 <izibi> would it be better to make just one big form that displays as multiple tabs (where some javascript just shows and hides different parts of the html) or to fetch the different parts via ajax?
75 2011-12-18T11:35:54 <dreimark> pro ajax is that this can be easier reused than if everything is added into a form
76 2011-12-18T11:36:13 <dreimark> that would means quite similiar big forms on other places
77 2011-12-18T11:36:31 <dreimark> s/means/mean/
78 2011-12-18T11:37:00 <izibi> and it would add a good amount of load on the server if we do this for the item views i guess
79 2011-12-18T11:37:00 <dreimark> TheSheep: comments ^
80 2011-12-18T11:37:18 <izibi> when every tabs gets generated by the server, no matter if the use every clicks on it
81 2011-12-18T11:37:40 <dreimark> yes, and it becomes sended all the time
82 2011-12-18T11:38:01 <izibi> but for the settings form this wouldn't be a problem
83 2011-12-18T11:38:42 <dreimark> yes, but we have to look that it can scale
84 2011-12-18T11:39:01 <dreimark> or we have many similiar solutions and another refacoring later
85 2011-12-18T11:39:59 <izibi> if you do the ajax thing in the user settings, the user (or some code) has to save each tab individually
86 2011-12-18T11:40:43 <izibi> and it would take some time to load each tab for the first time
87 2011-12-18T11:41:43 <dreimark> without a number all time is very relative
88 2011-12-18T11:42:43 <TheSheep> dreimark: context?
89 2011-12-18T11:43:28 <dreimark> TheSheep: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/104/user-settings-usersettings
90 2011-12-18T11:44:08 <dreimark> doing that by a big form or partially load by ajax for each group
91 2011-12-18T11:44:24 <TheSheep> I think it's best to have those settings in separate divs, and convert them to tabs with js, this way it will also work with js disabled
92 2011-12-18T11:44:30 <TheSheep> and you minimize requests
93 2011-12-18T11:44:47 <TheSheep> it's not like there is any reason to load them dynamically
94 2011-12-18T11:44:52 <dreimark> ah good point - i miss sometimes that js can be disabled
95 2011-12-18T11:45:04 <izibi> that can be handled in both cases
96 2011-12-18T11:45:52 <izibi> the user would either see one big form or a click on a tab would load a new page
97 2011-12-18T11:46:32 <TheSheep> izibi: too complicated, plus the forms are not that big, so loading them in one request will actually be faster
98 2011-12-18T11:46:57 <TheSheep> izibi: not to mention more fluent tab switching when there are no additional requests
99 2011-12-18T11:47:34 <izibi> then i guess i'll do it like that
100 2011-12-18T11:47:39 <TheSheep> izibi: but you will probaby want them to be in separate <form> elements with separate submit buttons
101 2011-12-18T11:48:38 <izibi> why? then each tab has to be submitted separately
102 2011-12-18T11:48:58 <TheSheep> izibi: exactly
103 2011-12-18T11:49:06 <izibi> ok, then i'd have to change less code :D
104 2011-12-18T11:49:27 <TheSheep> izibi: we can discuss it, but that's how I see it -- they are separate settings
105 2011-12-18T11:49:33 <TheSheep> izibi: just a feeling though
106 2011-12-18T11:49:37 <TheSheep> izibi: may be wrong
107 2011-12-18T11:51:43 <izibi> i guess this makes it easier to add subscriptions to the settings for example
108 2011-12-18T11:52:15 <izibi> don't know if it would make that much sense to add them to a big form
109 2011-12-18T11:52:53 <TheSheep> then again you are running into the problem of changing some settings, switching tabs and forgetting to submit them
110 2011-12-18T11:54:04 <izibi> we could display a warning message if the user switches tabs without saving
111 2011-12-18T11:58:18 *** raignarok
112 2011-12-18T11:58:39 <TheSheep> izibi: whenever you need to display a message to the user, you know that you failed in usability
113 2011-12-18T11:58:46 <TheSheep> izibi: also, users don't read messages
114 2011-12-18T12:00:23 <izibi> better suggestions? ;)
115 2011-12-18T12:01:36 <TheSheep> izibi: lets see what are the possibilities
116 2011-12-18T12:02:00 <TheSheep> 1. separate forms in separate tabs
117 2011-12-18T12:02:25 <TheSheep> 1.1. make users remember to always save the data (wrong)
118 2011-12-18T12:02:42 <TheSheep> 1.2. reminfs users to save the data when they switch tabs
119 2011-12-18T12:03:13 <TheSheep> 1.3. remind users to save the data when they try to leave the settings page but there are any changed tabs
120 2011-12-18T12:03:33 <TheSheep> (you have to tell them which tabs are changed then, possibly switch to them)
121 2011-12-18T12:03:49 <TheSheep> 1.4. Save the changes automatically when users switch tabs
122 2011-12-18T12:04:49 <TheSheep> 2. one big form
123 2011-12-18T12:05:11 <TheSheep> 2.1. indicate somehow that saving will change more than is visible
124 2011-12-18T12:05:45 <TheSheep> 2.2. reset the parts of form when switching tabs, discarding the cahnges
125 2011-12-18T12:06:01 <TheSheep> 2.3. just save everything together and don't care
126 2011-12-18T12:06:29 <TheSheep> izibi: what do you think?
127 2011-12-18T12:10:21 <izibi> 1.5. highlight tabs with unsaved changes (asterisk, red color, ...)
128 2011-12-18T12:20:35 <TheSheep> izibi: possibly mixed with 1.3
129 2011-12-18T12:21:30 <TheSheep> izibi: 3. Just save the changes the moment they are made
130 2011-12-18T12:25:23 *** qxcv
131 2011-12-18T12:28:42 <izibi> is there any reason why the submit buttons are part of the form class in python?
132 2011-12-18T12:30:48 <izibi> afk
133 2011-12-18T12:39:19 *** qxcv
134 2011-12-18T13:11:34 <dreimark> bbl
135 2011-12-18T13:16:58 *** raignarok
136 2011-12-18T13:18:57 <izibi> do you think it's possible to add the tabs at the right side of headline?
137 2011-12-18T13:19:27 <izibi> like there's a horizontal line, on top of which it says "user settings" on the left and on the right are the tabs
138 2011-12-18T13:19:48 <izibi> or might this cause trouble with some locales if the strings get longer?
139 2011-12-18T13:19:58 <izibi> what's the minimum screen size to consider?
140 2011-12-18T13:22:29 <TheSheep> 640x480?
141 2011-12-18T13:25:46 <izibi> where do you find this resolution nowadays? :D
142 2011-12-18T13:26:01 <izibi> but ok
143 2011-12-18T13:26:15 *** qxcv
144 2011-12-18T13:36:16 <TheSheep> izibi: in a window that is not taking up the whole screen
145 2011-12-18T13:36:20 <raignarok> izibi: smartphones? ;)
146 2011-12-18T13:37:58 <izibi> TheSheep: well ok, but who does that? (so that window is that small)
147 2011-12-18T13:38:07 <TheSheep> me
148 2011-12-18T13:38:20 * dreimark too
149 2011-12-18T13:38:29 <dreimark> at least sometimes
150 2011-12-18T13:38:52 <TheSheep> izibi: the resolution is irrelevant, it should just scale to any window dimensions
151 2011-12-18T13:39:08 <TheSheep> izibi: the tabs should wrap when they don't fit
152 2011-12-18T13:39:28 <TheSheep> izibi: also, remember that some translations will have much longer text on the tabs
153 2011-12-18T13:39:39 <TheSheep> izibi: german can be pretty verbose
154 2011-12-18T13:41:03 *** qxcv
155 2011-12-18T13:41:17 <izibi> where's the right place for my javascript? in MoinMoin/static/js/ or should i add something in the theme's static dir?
156 2011-12-18T13:42:05 <TheSheep> izibi: depends whether it's something general or theme-specific
157 2011-12-18T13:42:49 <izibi> well is it? :D
158 2011-12-18T13:43:05 <izibi> are these tabs theme-specific or are they 'global'?
159 2011-12-18T13:45:47 <TheSheep> depends on implementation
160 2011-12-18T13:46:50 <TheSheep> global would be better, but may be tricky
161 2011-12-18T13:47:44 <izibi> i'll just add it there for now
162 2011-12-18T15:18:52 <izibi> so js stuff is basically working
163 2011-12-18T15:18:58 <izibi> now the form has to work again ;)
164 2011-12-18T15:28:02 *** qxcv
165 2011-12-18T15:37:31 *** RogerHaase
166 2011-12-18T16:10:57 *** raignarok
167 2011-12-18T16:30:43 <izibi> meh, there is one problem: if you have multiple forms, you can only save one at a time of course ;)
168 2011-12-18T16:31:32 <izibi> so if you change stuff in two tabs, you're screwed ;)
169 2011-12-18T16:41:09 *** raignarok
170 2011-12-18T16:48:28 <TheSheep> izibi: not necessarily, you can submit with an ajax call
171 2011-12-18T16:49:01 <TheSheep> izibi: but it is getting complicated
172 2011-12-18T16:49:18 <TheSheep> izibi: maybe just a single form with indication of what has been changed is enough
173 2011-12-18T17:11:58 *** raignarok
174 2011-12-18T17:17:05 *** raignarok
175 2011-12-18T18:14:54 <ThomasWaldmann> moin
176 2011-12-18T19:09:47 * ThomasWaldmann looks at qxcv's stuff
177 2011-12-18T19:41:23 <CIA-59> Sam Toyer <samATqxcvDOTnet> default * 1162:cb70ad7b6668 2.0/MoinMoin/converter/ (6 files):
178 2011-12-18T19:41:23 <CIA-59> Fix mediawiki/html/docbook/rst parsers to only output links with allowed
179 2011-12-18T19:41:23 <CIA-59> schemas
180 2011-12-18T19:41:49 <CIA-59> Sam Toyer <samATqxcvDOTnet> default * 1163:2001aa3abe11 2.0/MoinMoin/converter/ (_tests/test_rst_in.py html_in.py mediawiki_in.py rst_in.py): Fix MW parser, add rst_in XSS test
181 2011-12-18T19:42:22 <CIA-59> Sam Toyer <samATqxcvDOTnet> default * 1164:5ac1f215ba6d 2.0/MoinMoin/converter/_tests/ (5 files): Add tests for input parsers
182 2011-12-18T19:42:56 <CIA-59> Sam Toyer <samATqxcvDOTnet> default * 1165:1a5891559732 2.0/MoinMoin/converter/ (5 files in 2 dirs):
183 2011-12-18T19:42:56 <CIA-59> Fix tests, simplify code, use Iri class, new behaviour for links with
184 2011-12-18T19:42:56 <CIA-59> disallowed schemes
185 2011-12-18T19:43:30 <CIA-59> Sam Toyer <samATqxcvDOTnet> default * 1166:5b492c6ac6de 2.0/MoinMoin/ (8 files in 4 dirs): Grammar
186 2011-12-18T19:44:00 <CIA-59> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1167:3b56135e1beb 2.0/MoinMoin/ (17 files in 5 dirs): merged
187 2011-12-18T19:46:10 <izibi> ThomasWaldmann: you did not pull my fix for the test on pypy yet
188 2011-12-18T19:51:50 <ThomasWaldmann> izibi: can you give the task url please?
189 2011-12-18T19:54:33 <CIA-59> Julian Brost <julian.brost@googlemail.com> default * 1168:b826684567f7 2.0/MoinMoin/util/_tests/test_thread_monitor.py: Fixed failing test on PyPy 1.7.
190 2011-12-18T19:54:52 <CIA-59> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1169:db8d607748fb 2.0/MoinMoin/util/_tests/test_thread_monitor.py: merged
191 2011-12-18T19:57:06 <izibi> http://www.google-melange.com/gci/task/view/google/gci2011/7185227
192 2011-12-18T20:01:01 <ThomasWaldmann> ok, updated the issue with the usual reference
193 2011-12-18T20:09:32 *** MattMaker
194 2011-12-18T20:13:50 *** raignarok
195 2011-12-18T20:14:58 <ThomasWaldmann> eSyr: http://www.google-melange.com/gci/task/view/google/gci2011/7121279 do you know more than me?
196 2011-12-18T20:19:10 *** MattMaker
197 2011-12-18T20:55:35 <CIA-59> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 1172:a264c1d6d88f 2.0/: closed branch pytest2, was merged into default branch and is not needed any more
198 2011-12-18T20:55:35 <CIA-59> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1170:4b6f2c60586a 2.0/docs/admin/configure.rst: merged
199 2011-12-18T20:55:38 <CIA-59> Thomas Waldmann <tw AT waldmann-edv DOT de> storage-ng * 1171:f2590c788d76 2.0/: closed branch storage-ng, was merged into default branch and is not needed any more
200 2011-12-18T21:41:38 *** MattMaker
201 2011-12-18T21:49:50 *** MattMaker
202 2011-12-18T22:09:50 *** raignarok
203 2011-12-18T22:27:06 *** pkumar
204 2011-12-18T22:30:42 *** MattMaker
205 2011-12-18T22:30:57 *** MattMaker
206 2011-12-18T22:49:23 *** Trip_
207 2011-12-18T22:54:00 *** MattMaker
208 2011-12-18T23:05:33 *** RogerHaase
209
