1 2011-12-14T00:01:46 <ThomasWaldmann> not sure wheter that was changed. was it bad english?
2 2011-12-14T00:01:57 <ThomasWaldmann> why that*
3 2011-12-14T00:02:04 <ThomasWaldmann> ok, 13.12.11 is over :)
4 2011-12-14T00:26:03 *** raignarok
5 2011-12-14T00:49:35 <CIA-59> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1155:0807f3505c13 2.0/setup.py: use a fixed flask-themes
6 2011-12-14T01:41:25 *** qxcv
7 2011-12-14T02:31:41 <qxcv> dreimark: tested the subitems widget on FF-3.6.22 and it seems to display fine
8 2011-12-14T04:12:27 *** jek
9 2011-12-14T04:14:21 *** jek
10 2011-12-14T04:44:13 *** qxcv
11 2011-12-14T06:01:14 *** pkumar
12 2011-12-14T06:32:17 *** qxcv
13 2011-12-14T07:16:31 *** pkumar
14 2011-12-14T09:49:10 <dreimark> moin
15 2011-12-14T09:50:28 * dreimark it is always good before accepting a task to try to apply it
16 2011-12-14T09:50:51 <dreimark> this time 7 out of 27 hunks FAILED -- saving rejects to file docs/admin/configure.rst.rej
17 2011-12-14T10:08:07 *** greg_f
18 2011-12-14T11:18:18 <dreimark> re
19 2011-12-14T12:01:23 *** mkerrin
20 2011-12-14T13:02:37 <ThomasWaldmann> moin
21 2011-12-14T13:36:29 *** dave_largo
22 2011-12-14T13:41:41 <CIA-59> Sam Toyer <samATqxcvDOTnet> default * 1156:4cd6611b0cf8 2.0/MoinMoin/util/ (_tests/test_send_file.py send_file.py): Fix send_file(None) and send_file unittest
23 2011-12-14T13:48:35 <qxcv> ThomasWaldmann: could I claim a GCI task for https://bitbucket.org/thomaswaldmann/moin-2.0/issue/59/history-misses-search-box?
24 2011-12-14T13:50:14 <ThomasWaldmann> qxcv: well, it would be better not to work on that NOW.
25 2011-12-14T13:50:36 *** dave_largo
26 2011-12-14T13:50:39 * ThomasWaldmann is currently creating a new theme, and it will be rather different
27 2011-12-14T13:51:04 <ThomasWaldmann> so maybe keep it on the list for later, if it still applies then.
28 2011-12-14T13:51:18 <qxcv> ok, I'll look for something else
29 2011-12-14T13:51:29 <ThomasWaldmann> we might also soon have lots of similar tasks relating to the new theme
30 2011-12-14T13:53:15 <ThomasWaldmann> btw, great job on the memory issue. it will even improve send_file in upstream, hopefully.
31 2011-12-14T13:53:43 <ThomasWaldmann> i tried it with a .iso, much faster now. :)
32 2011-12-14T13:55:35 <qxcv> haha, I was a bit scared when I tried looking at the response data with the werkzeug debugger and it almost ate all my memory
33 2011-12-14T13:55:52 <qxcv> but I quick kill -9 fixed that one up :)
34 2011-12-14T13:55:57 *** raignarok
35 2011-12-14T14:04:46 <ThomasWaldmann> qxcv: you've seen that issue list at bottom of EasyToDo wikipage?
36 2011-12-14T14:06:39 * qxcv is reading it now
37 2011-12-14T14:07:49 <qxcv> is https://bitbucket.org/thomaswaldmann/moin-2.0/issue/2/security-rst-converter-javascript-urls still open?
38 2011-12-14T14:08:37 <ThomasWaldmann> yes. but it is fixed in 1.9.
39 2011-12-14T14:10:00 <qxcv> would it be helpful if I ported the fix to moin2 and closed the issue?
40 2011-12-14T14:12:05 <ThomasWaldmann> yes. also first reproduce issue on moin2 and then see later if it is fixed.
41 2011-12-14T14:12:26 <ThomasWaldmann> it might be no trivial port, as moin2 is different.
42 2011-12-14T14:12:37 <ThomasWaldmann> but still maybe easy.
43 2011-12-14T14:13:20 <qxcv> yep, bug is still there
44 2011-12-14T14:13:41 <ThomasWaldmann> if you'ld do a small review about whether there are other places with that issue, we can talk about medium. :)
45 2011-12-14T14:14:17 <qxcv> sounds like fun
46 2011-12-14T14:14:32 <qxcv> so I just have to search for and fix xss bugs in the markup parsers?
47 2011-12-14T14:15:31 <ThomasWaldmann> well, i just meant that specific javascript url issue
48 2011-12-14T14:15:59 <ThomasWaldmann> there are also tasks for doing security reviews on a wider scope
49 2011-12-14T14:16:19 <qxcv> I'll just look at the javascript: issue
50 2011-12-14T14:18:00 <qxcv> but I'll check all the parsers
51 2011-12-14T14:18:43 <ThomasWaldmann> yup
52 2011-12-14T14:18:51 <qxcv> is that a medium or an easy?
53 2011-12-14T14:19:02 <ThomasWaldmann> medium
54 2011-12-14T14:19:17 <ThomasWaldmann> write the fix + check all p. in your claim
55 2011-12-14T14:22:00 * qxcv claims task and writes description
56 2011-12-14T14:25:53 <ThomasWaldmann> you have it
57 2011-12-14T14:26:23 <qxcv> ty
58 2011-12-14T14:26:31 *** dave_largo
59 2011-12-14T14:44:46 *** raignarok
60 2011-12-14T14:44:55 *** raignarok
61 2011-12-14T14:49:01 *** dave_largo
62 2011-12-14T15:03:28 *** qxcv
63 2011-12-14T15:34:10 *** raignarok
64 2011-12-14T16:24:15 <ThomasWaldmann> ah, new whoosh release with quite some bugs fixed \o/
65 2011-12-14T16:28:16 <dreimark> :)
66 2011-12-14T16:28:56 <dreimark> next pyconde is planned on a worse date 15.10 - 21.10
67 2011-12-14T16:29:51 <ThomasWaldmann> well, likely some SOC mentors will be missing then.
68 2011-12-14T16:33:01 *** raignarok
69 2011-12-14T16:34:01 *** RogerHaase
70 2011-12-14T16:39:26 <izibi> there's that one problem with GCI: you have less time for your personal projects :-/
71 2011-12-14T16:41:34 <ThomasWaldmann> hmm, one of my suggested changes was not taken. wondering why...
72 2011-12-14T16:41:58 <ThomasWaldmann> so i guess i still can't enable the regex stuff, fsck.
73 2011-12-14T16:42:05 <dreimark> arg
74 2011-12-14T16:43:08 <ThomasWaldmann> izibi: make moin one of your personal projects. issue solved!
75 2011-12-14T16:47:09 <dreimark> ThomasWaldmann: http://www.google-melange.com/gci/task/view/google/gci2011/7179247
76 2011-12-14T16:47:31 <dreimark> i have the same issues 7 hunks with problems, can you have a look
77 2011-12-14T16:48:27 <RogerHaase> ThomasWaldmann: Is there a coding style preference regarding trailing blanks? eg strip them or leave them? All I can find is a reference that says don't change whitespace, which sort of implies leave them.
78 2011-12-14T16:48:52 <dreimark> RogerHaase: in which context
79 2011-12-14T16:48:53 <ThomasWaldmann> dreimark: you took the submiss of 2011-12-14 14:40?
80 2011-12-14T16:49:13 <dreimark> i thought, redo
81 2011-12-14T16:49:59 <ThomasWaldmann> RogerHaase: usually we don't want to have trailing blanks. but it is a good idea not to mix such a cleanup into another changeset, that also does meaningful changes.
82 2011-12-14T16:50:06 <dreimark> ThomasWaldmann: same problem, yes i did
83 2011-12-14T16:50:37 <ThomasWaldmann> dreimark: ok, i try it also, if it does not apply, he has more work to do.
84 2011-12-14T16:51:13 <ThomasWaldmann> - moin moin -r
85 2011-12-14T16:51:14 <ThomasWaldmann> + moin -r
86 2011-12-14T16:51:40 <ThomasWaldmann> that's questionable, does that work?
87 2011-12-14T16:53:43 <RogerHaase> Agree about the separate changeset. I set my editor to strip trailing blanks 'cause I thought that was wanted, but find them here and there.
88 2011-12-14T16:54:07 <ThomasWaldmann> tw@server:~/moin-2.0$ patch -p1 < configure.diff
89 2011-12-14T16:54:08 <ThomasWaldmann> patching file docs/admin/configure.rst
90 2011-12-14T16:54:15 <ThomasWaldmann> no rejects
91 2011-12-14T16:54:24 <ThomasWaldmann> tw@server:~/moin-2.0$ hg id
92 2011-12-14T16:54:24 <ThomasWaldmann> 4cd6611b0cf8+ tip
93 2011-12-14T16:56:51 <dreimark> ha, fsck b7414f4780bf+ (pytest)
94 2011-12-14T16:56:54 <dreimark> ha, fsck b7414f4780bf+ (pytest2)
95 2011-12-14T16:57:09 <ThomasWaldmann> dreimark: i am reviewing this
96 2011-12-14T16:57:22 <dreimark> that explains the mismatch but not why i am on that branch
97 2011-12-14T16:58:32 * dreimark clones new
98 2011-12-14T17:07:59 * dreimark goes to pycologne
99 2011-12-14T17:08:03 <dreimark> bbl
100 2011-12-14T17:13:24 *** RogerHaase
101 2011-12-14T17:19:28 <ThomasWaldmann> dreimark: http://www.google-melange.com/gci/task/view/google/gci2011/7180424 can you have a look at that one later?
102 2011-12-14T18:14:29 *** dave_largo
103 2011-12-14T18:27:38 *** greg_f
104 2011-12-14T18:35:04 *** sungji
105 2011-12-14T18:41:52 <dreimark> ThomasWaldmann: yes
106 2011-12-14T18:54:21 *** mkerrin
107 2011-12-14T19:18:21 *** brunomartin
108 2011-12-14T19:18:42 *** brunomartin
109 2011-12-14T19:37:15 *** sungji
110 2011-12-14T20:01:02 *** sungji
111 2011-12-14T20:11:20 *** sungji
112 2011-12-14T20:22:50 *** RogerHaase
113 2011-12-14T22:07:13 <RogerHaase> ThomasWaldmann: try 2 at windows documentation fix: https://bitbucket.org/RogerHaase/moin-2.0-temp
114 2011-12-14T22:08:31 * ThomasWaldmann looks
115 2011-12-14T22:11:40 <ThomasWaldmann> RogerHaase: the lines under the headline text, is it same char count as the headline (== you used a monospace font)?
116 2011-12-14T22:15:06 <RogerHaase> I did not use a monospace font, so they are not the same length.
117 2011-12-14T22:16:53 <ThomasWaldmann> i think they must be same length
118 2011-12-14T22:17:29 <ThomasWaldmann> if you like, you could try make html in the docs dir
119 2011-12-14T22:20:47 <RogerHaase> Some of the headings in serv.rst were not the same length, so I thought it did not matter (although the lengths are closer than mine). I will fix and add one more changeset. (I already did do the make docs and it looks OK).
120 2011-12-14T22:21:29 <ThomasWaldmann> well, it always happens if one forgets to use a monospace font...
121 2011-12-14T22:28:22 *** dave_largo
122 2011-12-14T22:32:48 <RogerHaase> ThomasWaldmann: pushed the fix for underlining
123 2011-12-14T22:44:01 <RogerHaase> ThomasWaldmann: btw, the pointer to readthedocs on https://bitbucket.org/thomaswaldmann/moin-2.0 is wrong, the working version is .../moin-20/...
124 2011-12-14T22:44:18 <ThomasWaldmann> thanks
125 2011-12-14T22:49:49 <ThomasWaldmann> hmm, they must have changed that, that worked :)
126 2011-12-14T22:50:54 <ThomasWaldmann> fixed
127 2011-12-14T22:51:57 <ThomasWaldmann> RogerHaase: vv
128 2011-12-14T22:52:08 <CIA-59> Roger Haase <crosseyedpenguin@yahoo.com> default * 1157:f5f70c50cc51 2.0/docs/ (admin/install.rst examples/deployment/test.wsgi): strip trailing blanks
129 2011-12-14T22:52:09 <CIA-59> Roger Haase <crosseyedpenguin@yahoo.com> default * 1158:fa625d1aca82 2.0/ (5 files in 4 dirs): fix installation and server documentation for windows, fix scripts to work as documented under windows; fixes #114, #122, #128
130 2011-12-14T22:52:09 <CIA-59> Roger Haase <crosseyedpenguin@yahoo.com> default * 1159:cd19b8f0ff6b 2.0/docs/admin/ (install.rst serve.rst): make title underlining the same length as title
131 2011-12-14T22:52:25 *** raignarok
132 2011-12-14T22:53:25 <ThomasWaldmann> bbl
133 2011-12-14T22:54:56 *** raignarok
134 2011-12-14T23:25:21 *** raignarok
135 2011-12-14T23:37:46 *** RogerHaase
136 2011-12-14T23:49:00 <dreimark> re
