1 2011-11-22T00:10:17  *** raignarok has quit IRC
   2 2011-11-22T00:10:23  *** raignarok has joined #moin-dev
   3 2011-11-22T00:17:30  *** raignarok has quit IRC
   4 2011-11-22T02:04:44  *** Trip_ has joined #moin-dev
   5 2011-11-22T02:08:28  *** MattMaker has quit IRC
   6 2011-11-22T02:22:12  *** jbillsgci11 has joined #moin-dev
   7 2011-11-22T02:22:32  <jbillsgci11> Hello
   8 2011-11-22T02:22:52  <jbillsgci11> I am working on the headings task in gci2011
   9 2011-11-22T02:28:33  <jbillsgci11> Is anyone here?
  10 2011-11-22T02:33:30  <jbillsgci11> I am begining to feel a bit lonely
  11 2011-11-22T02:50:10  *** nick|2 has joined #moin-dev
  12 2011-11-22T02:51:19  <jbillsgci11> hello
  13 2011-11-22T02:52:14  <nick|2> hey
  14 2011-11-22T02:54:38  *** CIA-49 has quit IRC
  15 2011-11-22T02:56:00  *** CIA-56 has joined #moin-dev
  16 2011-11-22T03:02:11  *** nick|2 is now known as nickr5
  17 2011-11-22T03:04:03  <jbillsgci11> Are we t
  18 2011-11-22T03:04:06  <jbillsgci11> he o
  19 2011-11-22T03:04:10  <jbillsgci11> oops
  20 2011-11-22T03:04:19  <jbillsgci11> are we the only ones on here
  21 2011-11-22T03:07:49  <nickr5> I don't think so...
  22 2011-11-22T03:08:11  <jbillsgci11> I think we're the only ones at the computers
  23 2011-11-22T03:11:34  <jbillsgci11> I am having clock errors upon using the moin command. I am on ubuntu 11.10 desktop. Anyone know what I am doing wrong?
  24 2011-11-22T03:21:27  *** MattMaker has joined #moin-dev
  25 2011-11-22T03:50:45  <nickr5> if anyone gets the chance, would you mind approving this claim: http://www.google-melange.com/gci/task/view/google/gci2011/7162202 ? thanks!
  26 2011-11-22T04:08:18  <ThomasWaldmann> jbillsgci11: hi
  27 2011-11-22T04:08:30  <ThomasWaldmann> nickr5: hi
  28 2011-11-22T04:08:36  <jbillsgci11> hi
  29 2011-11-22T04:08:40  <nickr5> Hi
  30 2011-11-22T04:09:09  <ThomasWaldmann> sorry for being slow, but in fact i should be sleeping :D
  31 2011-11-22T04:09:19  <nickr5> haha no problem :)
  32 2011-11-22T04:09:27  <jbillsgci11> I am getting the following error while trying to run moin: http://pastebin.com/zUFx9LYm
  33 2011-11-22T04:09:39  <jbillsgci11> I am on ubuntu 11.10
  34 2011-11-22T04:09:50  <jbillsgci11> can you help?
  35 2011-11-22T04:10:39  <ThomasWaldmann> nickr5: where are you born / what's your native language?
  36 2011-11-22T04:10:46  <nickr5> US/english
  37 2011-11-22T04:10:50  <ThomasWaldmann> ok
  38 2011-11-22T04:11:16  <ThomasWaldmann> you feel positive about orthography etc.? :)
  39 2011-11-22T04:12:16  <nickr5> yes
  40 2011-11-22T04:12:32  <ThomasWaldmann> ok, you have it
  41 2011-11-22T04:13:19  <nickr5> Thanks :)
  42 2011-11-22T04:13:28  <ThomasWaldmann> nickr5: please note on the task wiki page that you are working on that section
  43 2011-11-22T04:13:51  <ThomasWaldmann> jbillsgci11: any questions about the task?
  44 2011-11-22T04:13:56  <nickr5> I think I did already
  45 2011-11-22T04:14:02  <jbillsgci11> Not really
  46 2011-11-22T04:14:16  <ThomasWaldmann> jbillsgci11: ok, you have it
  47 2011-11-22T04:14:20  <jbillsgci11> I could use some help with getting moin running though
  48 2011-11-22T04:14:34  <ThomasWaldmann> just ask specific questions
  49 2011-11-22T04:14:49  <ThomasWaldmann> (that is a general advice for irc, you get answers much faster by doing so :)
  50 2011-11-22T04:15:34  <jbillsgci11> I have been getting this problem: http://pastebin.com/zUFx9LYm. What is wrong? Is it my system or moinmoin?
  51 2011-11-22T04:16:08  <ThomasWaldmann> did you try to follow the install docs?
  52 2011-11-22T04:16:55  <ThomasWaldmann> "Initializing the storage and the index
  53 2011-11-22T04:17:01  <ThomasWaldmann> esp. that part
  54 2011-11-22T04:17:11  <jbillsgci11> oh
  55 2011-11-22T04:17:26  <jbillsgci11> I thought that was optional
  56 2011-11-22T04:18:09  <ThomasWaldmann> well, if you start from scratch, it is not. if you have valuable content in storage, you maybe do not want to kill it.
  57 2011-11-22T04:18:31  <jbillsgci11> ok
  58 2011-11-22T04:18:40  <jbillsgci11> thanks for the advice
  59 2011-11-22T04:19:19  <ThomasWaldmann> jbillsgci11: nickr5: you both check out from mercurial repo?
  60 2011-11-22T04:19:24  <jbillsgci11> yup
  61 2011-11-22T04:19:25  <ThomasWaldmann> checked*
  62 2011-11-22T04:19:31  <nickr5> yeah
  63 2011-11-22T04:19:35  <ThomasWaldmann> what does hg id say?
  64 2011-11-22T04:20:31  <nickr5> I'm at revision 1072
  65 2011-11-22T04:20:50  <ThomasWaldmann> full output please
  66 2011-11-22T04:21:42  <nickr5> one second... I'm under tortoisehg right now
  67 2011-11-22T04:22:33  <ThomasWaldmann> ah, we have a brave windows tester :D
  68 2011-11-22T04:24:41  <jbillsgci11> Was I supposed to be looking at the "Loading some items" part of the moin 2.0 documentation? I tried the command in that, but it didnt work. Where is the documentation for loading items?
  69 2011-11-22T04:26:18  <ThomasWaldmann> we don't have the load file yet :|
  70 2011-11-22T04:26:28  <jbillsgci11> oh
  71 2011-11-22T04:26:30  <ThomasWaldmann> but you can manually create some items on the wiki UI
  72 2011-11-22T04:26:39  <jbillsgci11> ok
  73 2011-11-22T04:26:45  <jbillsgci11> then export
  74 2011-11-22T04:26:48  <jbillsgci11> ?
  75 2011-11-22T04:27:11  <jbillsgci11> I seem to remember having to do something like this last year.
  76 2011-11-22T04:28:02  <nickr5> so I'm getting '2e76f0d4f2ab tip' from hg id, but I had already made a commit so I imagine that might change things
  77 2011-11-22T04:29:16  <jbillsgci11> where do the pages go?
  78 2011-11-22T04:31:52  <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1073:203a17db4036 2.0/docs/admin/install.rst: docs: add note about using default branch, be more clear about index/storage init
  79 2011-11-22T04:32:01  <ThomasWaldmann> see there ^^ :)
  80 2011-11-22T04:32:38  <ThomasWaldmann> jbillsgci11: we changed a lot since last year. including recently killing all old storage code.
  81 2011-11-22T04:32:47  <jbillsgci11> ok
  82 2011-11-22T04:33:16  <ThomasWaldmann> but it is much better and easier now, so it was for good reason
  83 2011-11-22T04:33:35  <jbillsgci11> thats great
  84 2011-11-22T04:33:43  <jbillsgci11> I like moinmoin a lot
  85 2011-11-22T04:34:01  <ThomasWaldmann> nickr5: make sure you work on default branch. hg id or hg branch should tell.
  86 2011-11-22T04:34:10  <ThomasWaldmann> do not commit to namespaces branch
  87 2011-11-22T04:34:34  <ThomasWaldmann> if you already did, you can do a hg rollback
  88 2011-11-22T04:34:50  <nickr5> hg branch says default so I think I'm ok
  89 2011-11-22T04:35:15  <ThomasWaldmann> (it was a bit unfortunate, that the current tip was namespaces branch, but the last commit from me fixed that now)
  90 2011-11-22T04:35:23  <ThomasWaldmann> ok
  91 2011-11-22T04:40:05  <jbillsgci11> Where are headings handled?
  92 2011-11-22T04:40:34  <jbillsgci11> What files?
  93 2011-11-22T04:45:26  <ThomasWaldmann> themes/modernized/static/css/...
  94 2011-11-22T04:45:59  <jbillsgci11> What python files proscess them though?
  95 2011-11-22T04:46:32  <jbillsgci11> wait.
  96 2011-11-22T04:46:41  <jbillsgci11> I think I found it
  97 2011-11-22T04:49:40  <ThomasWaldmann> it's the text/html output converter
  98 2011-11-22T04:49:56  <ThomasWaldmann> do you need to touch that?
  99 2011-11-22T04:50:22  <jbillsgci11> to modify the headings
 100 2011-11-22T04:51:10  <jbillsgci11> In the bug report you said you wanted headings to be a bit like the ones in this: http://wiki.python.de/
 101 2011-11-22T04:51:46  <jbillsgci11> to get a few of the things there I will need to modify the output
 102 2011-11-22T04:54:18  <ThomasWaldmann> ah. so you need more than just a css modification?
 103 2011-11-22T04:54:57  <jbillsgci11> maybe
 104 2011-11-22T04:55:12  <jbillsgci11> would you prefer me not to touch those files?
 105 2011-11-22T04:55:27  <jbillsgci11> its in html_out.py
 106 2011-11-22T04:55:47  <ThomasWaldmann> maybe do a first changeset just for the style (css)
 107 2011-11-22T04:56:06  <jbillsgci11> ok
 108 2011-11-22T04:57:10  <ThomasWaldmann> what exactly did you want to modify in the code?
 109 2011-11-22T04:58:36  <jbillsgci11> the part that outputs the headers
 110 2011-11-22T04:58:47  <jbillsgci11> I need sleep
 111 2011-11-22T04:59:40  <jbillsgci11> I will be back in the morning with an idea on how to do this.
 112 2011-11-22T05:03:34  *** nickr5 has quit IRC
 113 2011-11-22T05:03:49  <ThomasWaldmann> ok, just directly ask here then
 114 2011-11-22T06:38:46  *** MattMaker has quit IRC
 115 2011-11-22T06:42:52  *** MattMaker has joined #moin-dev
 116 2011-11-22T07:04:41  *** raignarok has joined #moin-dev
 117 2011-11-22T07:33:26  *** raignarok has quit IRC
 118 2011-11-22T09:01:35  *** pkumar has joined #moin-dev
 119 2011-11-22T10:04:09  *** raignarok has joined #moin-dev
 120 2011-11-22T10:07:21  *** pkumar has quit IRC
 121 2011-11-22T10:17:27  *** greg_f has joined #moin-dev
 122 2011-11-22T10:31:43  *** pkumar has joined #moin-dev
 123 2011-11-22T10:54:16  *** qxcv has joined #moin-dev
 124 2011-11-22T10:57:19  *** MattMaker has quit IRC
 125 2011-11-22T10:59:00  *** MattMaker has joined #moin-dev
 126 2011-11-22T11:15:22  <ThomasWaldmann> moin
 127 2011-11-22T11:17:12  *** raignarok has quit IRC
 128 2011-11-22T11:30:48  <eSyr> moin
 129 2011-11-22T11:37:04  <ThomasWaldmann> moin eSyr. you have seen the hi task being claimed?
 130 2011-11-22T11:38:33  <eSyr> yes.
 131 2011-11-22T11:39:39  <ThomasWaldmann> did you alert sinha already?
 132 2011-11-22T11:41:31  <eSyr> not yet.
 133 2011-11-22T11:42:57  <ThomasWaldmann> although there is nothing yet to do, that might make sense, so he can monitor progress himself and he is available here in case of question
 134 2011-11-22T11:43:22  <eSyr> yes, i'm planning to write him.
 135 2011-11-22T12:24:31  *** raignarok has joined #moin-dev
 136 2011-11-22T12:26:30  <qxcv> hmm, I've cloned the moinmoin 2.0 master repo, done ./quickinstall and I'm in the development environment, and I'm trying to get the test suite to run
 137 2011-11-22T12:26:55  <qxcv> but I get ImportMismatchError: ('MoinMoin.conftest', '<moin path>/MoinMoin/conftest.py', local('<moin path>/build/lib/MoinMoin/conftest.py'))
 138 2011-11-22T12:27:50  <qxcv> anybody know what's happening there? I suspect it could be the py.test version (2.2 on my machine), but I can't find an older version of py.test
 139 2011-11-22T12:29:35  <TheSheep> qxcv: can you pastebin the full traceback?
 140 2011-11-22T12:31:33  <qxcv> http://paste.pocoo.org/show/v8CJQVJx3u5NCWy8O2AI/
 141 2011-11-22T12:38:37  <TheSheep> I would ask at #pylib
 142 2011-11-22T12:38:50  <TheSheep> if nobody here knows
 143 2011-11-22T12:39:02  <qxcv> ok
 144 2011-11-22T13:01:04  <ThomasWaldmann> qxcv: not sure if it helps you, but I use pytest 2.1.2 and it works for me
 145 2011-11-22T13:03:52  <qxcv> got a fix in #pylib - it works for me when I use "py.test MoinMoin" rather than just "py.test"
 146 2011-11-22T13:04:43  <ThomasWaldmann> ok
 147 2011-11-22T13:05:01  <ThomasWaldmann> so it is an issue in py.test 2.2.0?
 148 2011-11-22T13:06:02  <pkumar> well, as the error says it has some problem with conftest imports
 149 2011-11-22T13:06:20  <pkumar> onein MoinMoin and another in biuld dir
 150 2011-11-22T13:06:54  <pkumar> probably, specifying MoinMoin there tells where to get conftest specifically
 151 2011-11-22T13:07:03  <pkumar> in this case
 152 2011-11-22T13:07:20  <pkumar> qxcv, ^
 153 2011-11-22T13:07:55  <pkumar> cleaning up the build may help perhaps
 154 2011-11-22T13:08:00  <qxcv> yes, specifiying MoinMoin or cd'ing into MoinMoin makes it work fine
 155 2011-11-22T13:09:23  <ThomasWaldmann> btw, as already noted on the EasyToDo page, we won't be able to submit new tasks into melange after end of this week
 156 2011-11-22T13:10:02  <pkumar> qxcv, just for a test, can you just try removing the build dir and running py.test . probably you can cut and paste your build dir somewhere else outside your moin repo.?
 157 2011-11-22T13:11:13  <qxcv> test suite runs fine when I take out the build directory
 158 2011-11-22T13:11:39  <pkumar> even without specifying MoinMoin explicitly?
 159 2011-11-22T13:11:46  <pkumar> with py.test
 160 2011-11-22T13:11:47  <pkumar> ?
 161 2011-11-22T13:12:30  <pkumar> qxcv, ?
 162 2011-11-22T13:12:34  <qxcv> yes, just running py.test works when I move the build dir
 163 2011-11-22T13:16:03  <ThomasWaldmann> why do you have that build dir btw?
 164 2011-11-22T13:16:04  <pkumar> ok, not sure about different os and platform dependencies   but build  should get cleaned up at the end of quickinstall.
 165 2011-11-22T13:16:27  <qxcv> probably because of playing around with make
 166 2011-11-22T13:16:43  <qxcv> I'd say it's probably my fault :S
 167 2011-11-22T13:17:43  <pkumar> it's good to play around with stuffs, I would say.
 168 2011-11-22T13:31:45  *** qxcv has quit IRC
 169 2011-11-22T13:47:13  <ThomasWaldmann> http://moinmo.in/28c3 whoever will be there and is interested in moin stuff, please add yourself there
 170 2011-11-22T14:00:12  *** pkumar has quit IRC
 171 2011-11-22T14:25:38  <dreimark> re
 172 2011-11-22T14:33:17  <dreimark> eSyr: I sended a question as reply to http://www.google-melange.com/gci/task/view/google/gci2011/7122302
 173 2011-11-22T14:34:32  <dreimark> eSyr: http://www.google-melange.com/gci/task/view/google/gci2011/7134387
 174 2011-11-22T14:34:39  <dreimark> it needs review
 175 2011-11-22T14:49:01  <ThomasWaldmann> we need sinha
 176 2011-11-22T14:52:35  <ThomasWaldmann> dreimark: see http://www.google-melange.com/gci/task/view/google/gci2011/7134387
 177 2011-11-22T14:52:47  <ThomasWaldmann> (comments of me)
 178 2011-11-22T15:00:27  <dreimark> ThomasWaldmann: you found a bug
 179 2011-11-22T15:00:33  <dreimark> now he has two tasks
 180 2011-11-22T15:01:28  <dreimark> thats why i haven't tried to assign him to that task. i thought it won't work
 181 2011-11-22T15:02:19  <dreimark> bbl
 182 2011-11-22T15:20:59  *** pkumar has joined #moin-dev
 183 2011-11-22T15:22:43  <pkumar> didn't know we are working on hindi translations too. great!
 184 2011-11-22T15:28:22  <ThomasWaldmann> dreimark: (he thinks) he has completed the first task, so he can start next one.
 185 2011-11-22T15:28:36  <ThomasWaldmann> if i understood it correctly, this is allowed
 186 2011-11-22T15:29:07  <ThomasWaldmann> pkumar: sinha told us he can review it. would be great if he were here...
 187 2011-11-22T15:30:11  <ThomasWaldmann> of course it would be a bit unfortunate for the case we would find out his translation is not acceptable.
 188 2011-11-22T15:30:23  <ThomasWaldmann> but let's hope it is :)
 189 2011-11-22T15:31:24  <pkumar> ThomasWaldmann: yeah, I just looked into some of the translated lines. I think at some places it needs modifications to be good hindi and other few places to make sense in hindi
 190 2011-11-22T15:32:45  <ThomasWaldmann> does it look like google translate or so?
 191 2011-11-22T15:34:38  <pkumar> probably at some places.because direct word to word translations doesn't work of English and hindi conversions
 192 2011-11-22T15:34:53  <pkumar> for*
 193 2011-11-22T15:35:37  <pkumar> so few lines makes no sense
 194 2011-11-22T15:35:42  <pkumar> in hindi
 195 2011-11-22T15:36:28  <ThomasWaldmann> pkumar: can you just translate some suspect lines using GT or some other popular en-hi translation service and see if it matches
 196 2011-11-22T15:37:09  <pkumar> well, Hindi is my mother tongue.
 197 2011-11-22T15:37:27  <pkumar> so,..
 198 2011-11-22T15:37:28  <ThomasWaldmann> i don't mean to translate it, rather to check if sb is cheating
 199 2011-11-22T15:37:52  <pkumar> ok, sure
 200 2011-11-22T15:38:01  <pkumar> just a sec
 201 2011-11-22T15:39:43  <ThomasWaldmann> also, sometimes that PO metadata is interesting, whether a tool was used that automates GT translations
 202 2011-11-22T15:43:20  <pkumar> hmm.. I tried a few of them on GT but they doesn't match.
 203 2011-11-22T15:43:24  <pkumar> ThomasWaldmann ^
 204 2011-11-22T15:43:44  <pkumar> different hindi statements
 205 2011-11-22T15:44:13  <ThomasWaldmann> ok. so no LART needed. :) can you add some comments to the gci issue?
 206 2011-11-22T15:44:37  <pkumar> sure
 207 2011-11-22T15:47:28  <pkumar> ThomasWaldmann: just to confirm on this page right: http://www.google-melange.com/gci/task/view/google/gci2011/7134387
 208 2011-11-22T15:48:09  <pkumar> ?
 209 2011-11-22T15:54:11  <ThomasWaldmann> yes
 210 2011-11-22T15:56:42  <jbillsgci11> I am editing visit_moinpage_h in html_out.py. I am trying to add a class to the headings for easier modification of them all at once. How would you go about adding a class to the headers?
 211 2011-11-22T15:58:15  <jbillsgci11> My current atempt is here: http://pastebin.com/SHV1BD1f
 212 2011-11-22T16:01:05  <pkumar> done!
 213 2011-11-22T16:04:55  <ThomasWaldmann> jbillsgci11: you didn't tell yet why it is needed to modify the code
 214 2011-11-22T16:05:28  <jbillsgci11> to aid in cssing all the headings at once.
 215 2011-11-22T16:05:28  <ThomasWaldmann> do you think just using h1, h2, h3, h4, ... is bad?
 216 2011-11-22T16:05:42  <jbillsgci11> It seems a bit clunky
 217 2011-11-22T16:06:31  <jbillsgci11> I like having standardized code that can then be overwritten on a header by header basis
 218 2011-11-22T16:12:49  <ThomasWaldmann> hmm, i don't get it. AFAIK, we ONLY have one kind of headings, this is in the content area.
 219 2011-11-22T16:13:13  <ThomasWaldmann> the theme does not use <hn>
 220 2011-11-22T16:13:26  <izibi> moin
 221 2011-11-22T16:13:45  <ThomasWaldmann> jbillsgci11: so, what class do you want to give it?
 222 2011-11-22T16:13:57  <jbillsgci11> .headings
 223 2011-11-22T16:13:59  <ThomasWaldmann> hi izibi
 224 2011-11-22T16:14:23  <ThomasWaldmann> jbillsgci11: isn't that redundant redundancy? :)
 225 2011-11-22T16:14:59  <jbillsgci11> I guess so
 226 2011-11-22T16:15:42  * ThomasWaldmann is all for clean stuff, but here it seems we do not (yet?) have to tell anything except "this is a heading" and that is already told by the tag
 227 2011-11-22T16:16:26  <jbillsgci11> ok
 228 2011-11-22T16:16:27  <ThomasWaldmann> if we would have a need for differently styled headings (where?), some class="content" could make sense
 229 2011-11-22T16:16:39  <izibi> so let's find out how signup and password recovery work
 230 2011-11-22T16:17:29  <izibi> ThomasWaldmann: then you can select them by something like #content h1
 231 2011-11-22T16:17:45  <izibi> assuming that you want to add this class to all heading in the page content
 232 2011-11-22T16:18:07  <jbillsgci11> ok
 233 2011-11-22T16:18:29  <izibi> you rarely need to add classes to <h*>
 234 2011-11-22T16:18:50  <jbillsgci11> do you want the page title stylized?
 235 2011-11-22T16:19:00  <jbillsgci11> the only h1 on the page?
 236 2011-11-22T16:20:25  <jbillsgci11> the example page didnt have the title styled in the same way os the other headers
 237 2011-11-22T16:22:41  <ThomasWaldmann> izibi: yeah, that selector should also work
 238 2011-11-22T16:23:34  <ThomasWaldmann> jbillsgci11: maybe start with similar style as the others and suggest alternatives that you think are even better
 239 2011-11-22T16:23:41  <jbillsgci11> ok
 240 2011-11-22T16:23:49  <jbillsgci11> This will be fun :)
 241 2011-11-22T16:24:09  <ThomasWaldmann> you are doing important work, we need to make it look less crappy :)
 242 2011-11-22T16:24:18  <izibi> btw on the chrome cookie issue: it looks like it's only a problem if you send something like Domain=localhost in the header
 243 2011-11-22T16:24:28  <izibi> if you just omit the domain value, it works fine
 244 2011-11-22T16:24:53  <ThomasWaldmann> izibi: i read that issue on that tracker and my thoughts were like "WTF"
 245 2011-11-22T16:25:22  <izibi> ThomasWaldmann: yeah, it's pretty strange
 246 2011-11-22T16:25:48  <izibi> i don't know what the rfcs say exactly, but if its a bug, it's in flask or werkzeug
 247 2011-11-22T16:26:31  <izibi> at least i haven't found a place in moin where this domain value gets set
 248 2011-11-22T16:26:41  <ThomasWaldmann> izibi: you could poke mitsuhiko and point him to that issue on their tracker
 249 2011-11-22T16:27:40  <izibi> first i'll complete the email verification task
 250 2011-11-22T16:27:45  <izibi> and then, we'll see
 251 2011-11-22T16:28:07  <izibi> i'll just use firefox for now :D
 252 2011-11-22T16:28:20  <izibi> btw no moin developer using chrome/chromium? :D
 253 2011-11-22T16:29:30  <ThomasWaldmann> i usually use ff, sometimes chromium
 254 2011-11-22T16:29:43  <ThomasWaldmann> (I love adblock plus :)
 255 2011-11-22T16:30:00  <brunomartin> moin
 256 2011-11-22T16:30:01  <ThomasWaldmann> and cookies
 257 2011-11-22T16:30:23  <izibi> there's also an adblock version for chrome
 258 2011-11-22T16:30:30  <izibi> and cookies usually work :D
 259 2011-11-22T16:32:12  <jbillsgci11> The headers look bad without a pointer icon. Can I make the whole header a link rather than just the paragraph icon?
 260 2011-11-22T16:32:53  <brunomartin> izibi: I use chromium sometimes... I found the problem... now that you mention the Domain=localhost in the header stuff... I commented the SERVER_NAME = "localhost:8080" line in wikiconfig.py and I can login just fine in chromium....
 261 2011-11-22T16:34:08  <izibi> how does that openid stuff work in the register view?
 262 2011-11-22T16:35:11  <izibi> and there is code duplication, i think this can be done better
 263 2011-11-22T16:35:31  <ThomasWaldmann> jbillsgci11: what does "without the pointer icon" mean?
 264 2011-11-22T16:35:45  <jbillsgci11> a hand icon
 265 2011-11-22T16:35:53  <ThomasWaldmann> for?
 266 2011-11-22T16:36:11  <jbillsgci11> making the page look better
 267 2011-11-22T16:36:28  <jbillsgci11> When I add hover it looks strange unless the header is a link
 268 2011-11-22T16:37:23  <ThomasWaldmann> well, i don't think the hole heading should be a link. people might want to copy and paste headings and if it is a link that is harder. some also might wonder why it is a link. so that paragraph symbol link is preferrable imho.
 269 2011-11-22T16:37:58  <jbillsgci11> Hmm
 270 2011-11-22T16:38:07  <ThomasWaldmann> why is it strange, because of alignment?
 271 2011-11-22T16:38:34  <jbillsgci11> because the color change on hover makes me think that it should have the hand icon
 272 2011-11-22T16:39:09  <ThomasWaldmann> do you need hover for the headline or just for that paragraph symbol?
 273 2011-11-22T16:39:23  <jbillsgci11> headline
 274 2011-11-22T16:39:42  <jbillsgci11> It looks good on the german python wiki
 275 2011-11-22T16:40:00  <jbillsgci11> but it looks like that because the headlines are links
 276 2011-11-22T16:40:53  <dreimark> ThomasWaldmann: yes, last year multiple claims were impossible.
 277 2011-11-22T16:40:54  <ThomasWaldmann> hmm, didn't they use to have that "link to that paragraph" thing also?
 278 2011-11-22T16:41:23  <ThomasWaldmann> dreimark: no, they were possible. but it was unclear whether they were allowed.
 279 2011-11-22T16:41:37  <izibi> https://bitbucket.org/thomaswaldmann/moin-2.0/src/203a17db4036/MoinMoin/apps/frontend/views.py#cl-958
 280 2011-11-22T16:41:57  <ThomasWaldmann> and it is not really multiple claims working at once. for the student the first one is finished when he claims next one.
 281 2011-11-22T16:42:06  <izibi> the only difference between openid and not open id is a different form and template, why is the whole code duplicated there?
 282 2011-11-22T16:42:16  <ThomasWaldmann> it can just happen that the org is unhappy with the submitted results and wants more work.
 283 2011-11-22T16:42:30  <izibi> and some slightly different code when the request type is get
 284 2011-11-22T16:42:49  <ThomasWaldmann> jbillsgci11: http://wiki.python.de/PyConDe/2012 there headings are not links
 285 2011-11-22T16:43:08  <ThomasWaldmann> but they miss that "link to here" symbol, we want that
 286 2011-11-22T16:43:36  <jbillsgci11> the top heading is a link
 287 2011-11-22T16:43:39  <ThomasWaldmann> btw, we should also not make them links to self just in case we want to have them as links to somewhere else
 288 2011-11-22T16:43:58  <jbillsgci11> the others have no hover animation
 289 2011-11-22T16:44:32  <ThomasWaldmann> see that Mailing List heading. like that + our paragraph-link-to-here thing
 290 2011-11-22T16:45:18  <ThomasWaldmann> and for now, just assume that our headings themselves are usually NOT links
 291 2011-11-22T16:45:28  <jbillsgci11> ok
 292 2011-11-22T16:45:42  <jbillsgci11> Ill work on making them look pretty
 293 2011-11-22T16:47:00  <ThomasWaldmann> izibi: it is a bit more, but yes, it looks mostly duplicate
 294 2011-11-22T16:53:00  <jbillsgci11> I have figured out how to make the line below the header with only css! :)
 295 2011-11-22T16:54:22  <izibi> http://paste.pocoo.org/show/511432/ so this code should do exactly the same thing
 296 2011-11-22T17:00:17  <izibi> is that code ok?
 297 2011-11-22T17:00:45  <ThomasWaldmann> jbillsgci11: they also only use css, right? :)
 298 2011-11-22T17:02:26  <izibi> self.mail_enabled and True or False <-- what about bool(self.mail_enabled) :D
 299 2011-11-22T17:03:08  <ThomasWaldmann> izibi: yes, code looks ok. can you test it?
 300 2011-11-22T17:04:34  <ThomasWaldmann> izibi: please rather FormClass
 301 2011-11-22T17:05:27  <izibi> ThomasWaldmann: i don't know how this openid stuff works
 302 2011-11-22T17:05:35  <ThomasWaldmann> izibi: btw, if that is unrelated to you current task, please separate changeset
 303 2011-11-22T17:05:48  * ThomasWaldmann doesn't use it either :)
 304 2011-11-22T17:06:09  <izibi> it doesn't make a difference if i enter an openid or not
 305 2011-11-22T17:06:31  <ThomasWaldmann> btw, if you change there anyway, remove some useless comments, like pastebin line 4
 306 2011-11-22T17:09:23  <izibi> i don't know how to test this. there is no field openid_submit in the form i see
 307 2011-11-22T17:10:09  <ThomasWaldmann> what task are you working on currently, btw?
 308 2011-11-22T17:10:29  <izibi> email verification
 309 2011-11-22T17:10:46  <izibi> but i want to clean this up before as i would have to duplicate my code otherwise
 310 2011-11-22T17:11:03  <ThomasWaldmann> ok, then delay the openid stuff until you have a task for it. if it is broken, you can have a medium find/fix bug for it later.
 311 2011-11-22T17:11:30  <izibi> ok, then i'll leave it like this for now
 312 2011-11-22T17:11:31  <ThomasWaldmann> ok, then do your best to not make it more broken :D
 313 2011-11-22T17:11:49  <izibi> wasn't that a gci task last year? :D
 314 2011-11-22T17:12:03  <izibi> (the openid stuff)
 315 2011-11-22T17:12:32  <ThomasWaldmann> can be. maybe in 1.9? when going from 1.9 to 2, i had to rip out some stuff to be able to make it working.
 316 2011-11-22T17:13:22  <izibi> i'll commit this now
 317 2011-11-22T17:15:43  <ThomasWaldmann> so some of the more complicated stuff might be not or only partially there.
 318 2011-11-22T17:16:24  <izibi> how should i call the config option? enable_email_verification?
 319 2011-11-22T17:18:00  <ThomasWaldmann> no
 320 2011-11-22T17:18:45  <ThomasWaldmann> config options should somehow sort alphabetically in a way that makes sense. so they must not ever start with enable or disable or other stuff that does not tell anything
 321 2011-11-22T17:19:42  <ThomasWaldmann> so, look for related stuff. user*, account*, just look what we have and in what "group" it belongs
 322 2011-11-22T17:20:08  <ThomasWaldmann> see config/...
 323 2011-11-22T17:20:23  <izibi> https://bitbucket.org/thomaswaldmann/moin-2.0/src/203a17db4036/MoinMoin/config/default.py#cl-545
 324 2011-11-22T17:20:34  <izibi> is the user string automatically added as prefix?
 325 2011-11-22T17:20:48  <izibi> so is the next setting actually called user_email_unique?
 326 2011-11-22T17:21:07  <izibi> i'd then just add email_verification below that
 327 2011-11-22T17:25:01  <jbillsgci11> I am having trouble wrapping my header's border around the table of contents. http://www.dropmocks.com/mjIHw does anyone know a way to fix this?
 328 2011-11-22T17:26:19  *** raignarok has quit IRC
 329 2011-11-22T17:27:18  <ThomasWaldmann> izibi: yes, user_ is added as prefix
 330 2011-11-22T17:27:48  <ThomasWaldmann> izibi: yes, user_email_verification sounds good
 331 2011-11-22T17:28:18  <ThomasWaldmann> hmm, that reminds me of that we need to verify on email change also X)
 332 2011-11-22T17:28:39  <ThomasWaldmann> izibi: can you create an issue for that?
 333 2011-11-22T17:29:12  <izibi> jbillsgci11: you can try to set a high z-index and a background color on the floating TOC, but i don't know if this helps
 334 2011-11-22T17:29:26  <izibi> ThomasWaldmann: where? bb bugtracker?
 335 2011-11-22T17:29:48  <ThomasWaldmann> yes
 336 2011-11-22T17:29:50  <jbillsgci11> is there anything else which might apear on the right side>
 337 2011-11-22T17:29:52  <jbillsgci11> ?
 338 2011-11-22T17:30:39  <ThomasWaldmann> only that paragraph symbol right now, that appears on hover. don't think we have anything else.
 339 2011-11-22T17:31:04  <ThomasWaldmann> maybe if we get section editing, there might be something to click for editing, but we do not have that yet.
 340 2011-11-22T17:31:14  <jbillsgci11> ok
 341 2011-11-22T17:31:26  <jbillsgci11> well then Ill just fix the toc
 342 2011-11-22T17:33:45  <izibi> how do i access the config from my code?
 343 2011-11-22T17:34:59  <jbillsgci11> ThomasWaldmann: do you mind if the toc has a white background. It looks really good to me
 344 2011-11-22T17:38:01  <jbillsgci11> http://www.dropmocks.com/mjVsG
 345 2011-11-22T17:40:16  <ThomasWaldmann> izibi: app.cfg.foo
 346 2011-11-22T17:41:06  <izibi> ThomasWaldmann: thx
 347 2011-11-22T17:41:12  <ThomasWaldmann> jbillsgci11: i need to see it. i am bad at design theory, but i see if it looks good for me or not. :)
 348 2011-11-22T17:41:33  <ThomasWaldmann> ah. /me looks there.
 349 2011-11-22T17:41:55  <ThomasWaldmann> should that link show a picture to me?
 350 2011-11-22T17:42:04  <izibi> hmm, somehow dropmocks reminds me of dropbox... :D
 351 2011-11-22T17:42:25  <ThomasWaldmann> jbillsgci11: do you need to set it to "public" maybe?
 352 2011-11-22T17:42:43  <ThomasWaldmann> izibi: i am sure this is totally unintended.
 353 2011-11-22T17:43:05  <jbillsgci11> ok
 354 2011-11-22T17:43:55  <jbillsgci11> must have expired or something
 355 2011-11-22T17:44:24  * ThomasWaldmann set most bb issues to "open", so we can more easily see new ones.
 356 2011-11-22T17:45:12  <jbillsgci11> http://www.dropmocks.com/mjIHy
 357 2011-11-22T17:45:15  <jbillsgci11> try that
 358 2011-11-22T17:45:26  <jbillsgci11> I think it looks good personally
 359 2011-11-22T17:48:45  <jbillsgci11> heres what it might look like on an actual wiki page:http://www.dropmocks.com/mjHJq
 360 2011-11-22T17:49:25  <ThomasWaldmann> h1 is not having a line below?
 361 2011-11-22T17:49:55  <ThomasWaldmann> (there might be multiple h1 on a page)
 362 2011-11-22T17:50:02  <jbillsgci11> oh...
 363 2011-11-22T17:50:12  <jbillsgci11> Ill work on that
 364 2011-11-22T17:50:42  <ThomasWaldmann> h1 is different colour intentionally?
 365 2011-11-22T17:50:52  <jbillsgci11> yup
 366 2011-11-22T17:51:06  <jbillsgci11> H1 is inline
 367 2011-11-22T17:51:11  <jbillsgci11> messes with my line
 368 2011-11-22T17:51:21  <jbillsgci11> does it need to be inline?
 369 2011-11-22T17:51:28  <ThomasWaldmann> for next screenshot, do the hover
 370 2011-11-22T17:51:33  <jbillsgci11> ok
 371 2011-11-22T17:51:36  <ThomasWaldmann> no idea :)
 372 2011-11-22T17:51:47  <jbillsgci11> :0
 373 2011-11-22T17:51:52  <jbillsgci11> Ill check
 374 2011-11-22T17:54:23  <ThomasWaldmann> theoretically, there should be NO fundamental difference between any levels of headings. except of course that h(n) is somehow more impressive then h(n+1)
 375 2011-11-22T17:54:35  <ThomasWaldmann> than*
 376 2011-11-22T17:56:11  <jbillsgci11> I was just going by what I saw on the python wiki.
 377 2011-11-22T17:56:18  <jbillsgci11> Ill change it if nescessary
 378 2011-11-22T17:56:59  <jbillsgci11> http://www.dropmocks.com/mjLF_ hover screenshot
 379 2011-11-22T17:57:45  <ThomasWaldmann> python wiki is old moin and maybe a way of making themes that is very old and deprecated
 380 2011-11-22T17:58:05  <ThomasWaldmann> like abusing the pagename is title or the h1 as title or something
 381 2011-11-22T17:58:51  <izibi> should i add an disabled argument to the create_user function or just update it afterwards?
 382 2011-11-22T17:59:06  <jbillsgci11> ok
 383 2011-11-22T17:59:15  <jbillsgci11> Ill change
 384 2011-11-22T18:00:11  <jbillsgci11> Done
 385 2011-11-22T18:01:17  <ThomasWaldmann> izibi: maybe a kwarg makes sense
 386 2011-11-22T18:01:53  <jbillsgci11> Here is a screenshot of the changed updated h1 http://www.dropmocks.com/mjH7E
 387 2011-11-22T18:02:05  <jbillsgci11> oops
 388 2011-11-22T18:02:15  <jbillsgci11> I was just superflouse
 389 2011-11-22T18:02:48  <jbillsgci11> superfluwouse
 390 2011-11-22T18:03:04  <ThomasWaldmann> superfluous :)
 391 2011-11-22T18:03:27  <jbillsgci11> thanks
 392 2011-11-22T18:03:31  <izibi> what's the difference between User.disabled and User.valid? which one do i have to set?
 393 2011-11-22T18:03:58  <ThomasWaldmann> jbillsgci11: is that paragraph symbol using the same baseline as the heading text to the left?
 394 2011-11-22T18:04:18  <jbillsgci11> I dont know
 395 2011-11-22T18:04:31  <ThomasWaldmann> find out :(
 396 2011-11-22T18:04:33  <jbillsgci11> no. its not
 397 2011-11-22T18:04:34  <ThomasWaldmann> :)
 398 2011-11-22T18:05:49  <jbillsgci11> I think its something to do with them being inline
 399 2011-11-22T18:05:53  <dreimark> ThomasWaldmann: i look later pn #109, have to got to a apotheke
 400 2011-11-22T18:06:36  <ThomasWaldmann> pharmacy :)
 401 2011-11-22T18:06:46  <jbillsgci11> or not
 402 2011-11-22T18:07:03  <jbillsgci11> If I remove the inline then they disappear
 403 2011-11-22T18:07:45  <ThomasWaldmann> i am not totally sure, but i think it sits a bit lower than the headline text
 404 2011-11-22T18:08:32  <ThomasWaldmann> on next screenshot, please all sizes of headlines
 405 2011-11-22T18:09:07  <jbillsgci11> ok
 406 2011-11-22T18:09:16  <ThomasWaldmann> TheSheep: can you have a look also, we need somebody with taste :)
 407 2011-11-22T18:14:01  <jbillsgci11> http://www.dropmocks.com/mjH7E select the second image in the box on the right
 408 2011-11-22T18:14:12  <izibi> "Account created, please check your email inbox and verify your email address." <-- any better ideas how to say this?
 409 2011-11-22T18:15:35  <jbillsgci11> Account created, please check your email inbox *to* verify your email address.
 410 2011-11-22T18:15:52  <ThomasWaldmann> Account verification required, please see the e-mail we sent to your address.
 411 2011-11-22T18:16:20  <ThomasWaldmann> (and then tell in that e-mail what they need to do)
 412 2011-11-22T18:20:41  <jbillsgci11> What do you think is causing the 2-3px offset?
 413 2011-11-22T18:21:11  <ThomasWaldmann> jbillsgci11: and please use some letter like p, so we see whether it merges with the underlining
 414 2011-11-22T18:23:13  <ThomasWaldmann> also include some samples where h2 follows h1 directly (or h3 / h2)
 415 2011-11-22T18:24:09  <izibi> why does create_user return error messages? would be much easier if it just returned the user object :D
 416 2011-11-22T18:25:19  <ThomasWaldmann> izibi: old code
 417 2011-11-22T18:25:23  <jbillsgci11> http://www.dropmocks.com/mjH7E pic number 3
 418 2011-11-22T18:25:31  <ThomasWaldmann> the whole user module is a bit dusty
 419 2011-11-22T18:26:18  <ThomasWaldmann> jbillsgci11: read what i told above
 420 2011-11-22T18:26:25  <jbillsgci11> I did
 421 2011-11-22T18:26:45  <jbillsgci11> There should be an option on the right to scroll through 3 pics
 422 2011-11-22T18:27:20  <jbillsgci11> Number 3 has all headings a p and the  directly follow each other
 423 2011-11-22T18:27:34  <izibi> how should i name the method? mailVerificationLink or mail_verification_link?
 424 2011-11-22T18:28:35  <izibi> naming convention isn't clear in the User class :/
 425 2011-11-22T18:29:30  <ThomasWaldmann> ok, i need to go soon. just ask some other folks here. :)
 426 2011-11-22T18:30:01  <jbillsgci11> Who are you talking to?
 427 2011-11-22T18:30:16  <ThomasWaldmann> to *
 428 2011-11-22T18:30:42  <jbillsgci11> oh
 429 2011-11-22T18:30:54  <ThomasWaldmann> and there is no visible indication that it has multiple pics, but cursor keys up down work
 430 2011-11-22T18:31:01  <jbillsgci11> I am part of a wildcard!!!! :)
 431 2011-11-22T18:31:47  <ThomasWaldmann> i think we need a little more distance, just to avoid ugly p and g etc.
 432 2011-11-22T18:31:55  <jbillsgci11> yah
 433 2011-11-22T18:32:41  <jbillsgci11> I just tried padding, but it requires more padding for h1 than for h5 to fix
 434 2011-11-22T18:32:42  <ThomasWaldmann> also, not sure, maybe h1 should have thicker line than h6?
 435 2011-11-22T18:32:53  <jbillsgci11> ok
 436 2011-11-22T18:33:22  <ThomasWaldmann> i already like it more than what we have now :)
 437 2011-11-22T18:33:54  <jbillsgci11> Thanks
 438 2011-11-22T18:34:11  <jbillsgci11> Ill try to fix the odd pixel bug
 439 2011-11-22T18:36:02  <izibi> what should happen if sending the email failed?
 440 2011-11-22T18:38:04  <ThomasWaldmann> hmm, tell so and redisplay the creation form?
 441 2011-11-22T18:41:17  *** greg_f has quit IRC
 442 2011-11-22T18:43:03  <izibi> ThomasWaldmann: but at that time the user has already been created
 443 2011-11-22T18:44:19  <ThomasWaldmann> update it with new data entered?
 444 2011-11-22T18:44:26  * ThomasWaldmann needs to go, bbl
 445 2011-11-22T18:46:09  <izibi> i guess sending won't fail because the address in invalid but because the mail server is down or something like that
 446 2011-11-22T18:49:49  <jbillsgci11> I fixed  the pixel bug on my pc. Can you test on yours? I made a patch http://pastebin.com/JFduH7ke
 447 2011-11-22T18:53:47  <dreimark> re
 448 2011-11-22T19:02:37  <dreimark> about multiple claims on the ML It's an issue/bug and a violation of rules as far as I know.
 449 2011-11-22T19:02:49  <dreimark> Correct, we're investigating.
 450 2011-11-22T19:10:11  <dreimark> pkumar: do you edir easystodo?
 451 2011-11-22T19:11:47  <pkumar> yeah, I'm creating a subpage for the task under the heading Code, Code- Tests.
 452 2011-11-22T19:11:47  <pkumar> first task
 453 2011-11-22T19:12:06  <pkumar> dreimark :^
 454 2011-11-22T19:12:39  <pkumar> I'm not just sure how do I get that page link on EasyToDo page
 455 2011-11-22T19:13:47  <dreimark> pkumar: magically just save the page
 456 2011-11-22T19:13:56  <dreimark> it is done by a search macro
 457 2011-11-22T19:14:06  <dreimark> me has a new idea for a task
 458 2011-11-22T19:14:34  <dreimark> pkumar: can you look into this hi translation too http://www.google-melange.com/gci/task/view/google/gci2011/7122302
 459 2011-11-22T19:16:00  <pkumar> dreimark : I had looked into it a while back and found that it needs some modifications
 460 2011-11-22T19:16:28  <pkumar> though I did not go through the whole thing, just some initial sentences
 461 2011-11-22T19:16:50  <dreimark> please add some comments what you wanted to become changed on the melange page
 462 2011-11-22T19:17:01  <dreimark> we can then tell more work
 463 2011-11-22T19:17:12  <dreimark> *needed
 464 2011-11-22T19:17:32  <pkumar> http://www.google-melange.com/gci/task/view/google/gci2011/7134387
 465 2011-11-22T19:17:50  <pkumar> are both the links different?
 466 2011-11-22T19:18:00  <dreimark> pkumar: yes, he has both tasks
 467 2011-11-22T19:18:31  <pkumar> and both for hi translations, mm
 468 2011-11-22T19:18:44  <dreimark> yes
 469 2011-11-22T19:19:01  <pkumar> ok
 470 2011-11-22T19:19:33  <pkumar> then I have seen just one of them, the link I provided. will look into the other one too
 471 2011-11-22T19:19:56  <dreimark> thx
 472 2011-11-22T19:21:16  <izibi> http://paste.pocoo.org/show/511506/
 473 2011-11-22T19:21:25  <izibi> is that ok?
 474 2011-11-22T19:25:19  <pkumar> dreimark : again it has the same kind of problems as the previous ones. some sentences make no sense. prepositions are not on the correct place. Though the straight forward sentences are correct
 475 2011-11-22T19:26:03  <dreimark> pkumar: add an example what makes no sense
 476 2011-11-22T19:26:36  *** grzywacz has joined #moin-dev
 477 2011-11-22T19:26:37  *** grzywacz has joined #moin-dev
 478 2011-11-22T19:27:14  <dreimark> izibi: have your tried it?
 479 2011-11-22T19:28:34  <pkumar> eg: translation of Your edit lock on %(lock_page)s will expire in # minutes
 480 2011-11-22T19:29:02  <pkumar> dreimark : ^
 481 2011-11-22T19:30:46  <pkumar> well that is just one eg, we have more
 482 2011-11-22T19:31:10  <dreimark> gt, says me for that "Your edit lock on% (lock_page) s is finished!"
 483 2011-11-22T19:31:33  <dreimark> which is a different meaning
 484 2011-11-22T19:32:39  <pkumar> yeah, gt has different meanings from the translations here.
 485 2011-11-22T19:33:31  <pkumar> problem is this:
 486 2011-11-22T19:34:13  <pkumar> english-hindi word to word translation works only for few places.
 487 2011-11-22T19:34:54  <jbillsgci11> I have submitted my code.
 488 2011-11-22T19:35:02  <pkumar> even though, the hindi statement in there makes no sense, gt shows some valid translation here
 489 2011-11-22T19:35:13  <dreimark> ok, but what is the meaning what he wrote. I want to get some feeling if the just has some kind of slang or uses some forbidden tool
 490 2011-11-22T19:35:17  <pkumar> dreimark : ^
 491 2011-11-22T19:36:00  <dreimark> ok, you think he is cheating?
 492 2011-11-22T19:36:39  <dreimark> pkumar: ^
 493 2011-11-22T19:36:44  <pkumar> I can't say that. no idea abt it. atleast he is not using gt
 494 2011-11-22T19:36:51  <izibi> dreimark: yes, works fine
 495 2011-11-22T19:37:29  <dreimark> izibi: have you checked if it works with existing disabled users
 496 2011-11-22T19:37:42  <pkumar> when you look at the translation of the statement: Your edit lock on %(lock_page)s has expired!
 497 2011-11-22T19:37:45  <pkumar> in hindi
 498 2011-11-22T19:37:49  <dreimark> izibi: using the same email or same name
 499 2011-11-22T19:38:38  <izibi> dreimark: should it be possible to create users with the same username? o.O
 500 2011-11-22T19:38:44  <dreimark> no
 501 2011-11-22T19:39:18  *** jbillsgci11 has quit IRC
 502 2011-11-22T19:39:40  <pkumar> first half somehow means(though that structure is wrong too) lock on you edited. not exactly even that
 503 2011-11-22T19:39:49  *** jbillsgci11 has joined #moin-dev
 504 2011-11-22T19:39:56  <jbillsgci11> Hello
 505 2011-11-22T19:40:04  <jbillsgci11> Internet just went out
 506 2011-11-22T19:40:14  <dreimark> wb jbillsgci11
 507 2011-11-22T19:40:50  <jbillsgci11> thanks
 508 2011-11-22T19:41:20  <izibi> dreimark: then i don't understand what you want to tell me ;)
 509 2011-11-22T19:41:21  <pkumar> dreimark ^
 510 2011-11-22T19:42:24  <dreimark> izibi: i think the code is so far fine. I am just thinking about that we have a different workflow now. (not your problem)
 511 2011-11-22T19:42:41  <dreimark> the question is if an admin thinks a user is valid and removes the disabled flag
 512 2011-11-22T19:43:20  <pkumar> dreimark : though the words used in here are good ones, the framework of statements are incorrect at few places
 513 2011-11-22T19:43:39  <pkumar> s/few/some
 514 2011-11-22T19:45:31  <izibi> dreimark: then the user is active just as he would be if he clicked the link. i don't see a problem
 515 2011-11-22T19:45:33  <dreimark> pkumar: i write a note and ask him to work on it
 516 2011-11-22T19:46:03  <pkumar> ok, that would be good.
 517 2011-11-22T19:47:49  <dreimark> izibi: what does the user see, he did not know that he is already valid.
 518 2011-11-22T19:48:46  <izibi> well he wouldn't get any notification in that case
 519 2011-11-22T19:49:39  <izibi> and he would get an error message because i'm checking the disabled flag
 520 2011-11-22T19:50:53  <izibi> (when he clicks the link)
 521 2011-11-22T19:52:49  <dreimark> please add a note about that in the comment when you submit to melange.
 522 2011-11-22T19:55:05  <dreimark> the tool for changing that flag for an admin needs to verfy that the user account is created
 523 2011-11-22T19:55:21  <dreimark> or was created
 524 2011-11-22T19:56:09  <izibi> how can you set a flag on a user that hasn't been created?
 525 2011-11-22T20:05:01  <dreimark> izibi: i tried to apply your patch
 526 2011-11-22T20:05:07  <dreimark> what is your tip
 527 2011-11-22T20:05:37  <dreimark> mine is 1073:203a17db403
 528 2011-11-22T20:06:10  <izibi> i removed some duplicate code before
 529 2011-11-22T20:06:15  <izibi> https://bitbucket.org/julianbrost/moin-2.0/
 530 2011-11-22T20:15:58  * dreimark plays with it
 531 2011-11-22T20:18:07  <dreimark> izibi: found a problem
 532 2011-11-22T20:18:17  <dreimark> how long is the lifetime of the token?
 533 2011-11-22T20:18:31  <dreimark> what happens if you create two accounts
 534 2011-11-22T20:18:58  <izibi> it uses the code of the password recovery feature to create/verify the tokens
 535 2011-11-22T20:19:08  <izibi> i don't know if they have a limited lifetime
 536 2011-11-22T20:19:46  <izibi> dreimark: with the same email address?
 537 2011-11-22T20:19:54  <dreimark> no two different ones
 538 2011-11-22T20:20:10  <dreimark> only the last usere can be created
 539 2011-11-22T20:20:32  <izibi> o.O?
 540 2011-11-22T20:21:17  <izibi> then the password recovery feature must be broken, too
 541 2011-11-22T20:22:20  * dreimark repeats the test
 542 2011-11-22T20:23:22  <dreimark> same result, now testing password recovery
 543 2011-11-22T20:24:46  *** MattMaker has quit IRC
 544 2011-11-22T20:26:03  <izibi> what are the steps to replicate this? create acc1, create acc2, verify acc1?
 545 2011-11-22T20:27:33  <dreimark> yes
 546 2011-11-22T20:27:42  <izibi> hmm, that's strange
 547 2011-11-22T20:32:28  <izibi> but i could reproduce this
 548 2011-11-22T20:32:35  <dreimark> pasword recovery works with m2
 549 2011-11-22T20:34:16  <dreimark> izibi: have you reproduced?
 550 2011-11-22T20:34:44  <izibi> yes
 551 2011-11-22T20:34:50  <izibi> but i don't understand it :D
 552 2011-11-22T20:36:22  <dreimark> i can't compare the changes now, but usually it happens similar to
 553 2011-11-22T20:36:37  <dreimark> a) for some reason only one token is known
 554 2011-11-22T20:36:51  <dreimark> b) or all user objects believe they have the same token
 555 2011-11-22T20:37:05  <izibi> is there a way to dump the user storage in a human-readable format?
 556 2011-11-22T20:37:31  <dreimark> don't know
 557 2011-11-22T20:38:01  *** nickr5 has joined #moin-dev
 558 2011-11-22T20:41:59  <izibi> oh, metadata is json, that's human-readable enough
 559 2011-11-22T20:42:09  <dreimark> ah, yes
 560 2011-11-22T20:45:23  *** pkumar has quit IRC
 561 2011-11-22T20:53:16  <dreimark> TheSheep: can you have a look at http://www.google-melange.com/gci/task/view/google/gci2011/7160202
 562 2011-11-22T20:56:22  <izibi> somehow u.disabled is false oO
 563 2011-11-22T21:00:43  <izibi> so if i use not u.valid it should work (didn't test yet)
 564 2011-11-22T21:01:23  <izibi> looks like a bug in the storage stuff
 565 2011-11-22T21:08:07  <dreimark> ok
 566 2011-11-22T21:08:19  <dreimark> bbl, me goes home
 567 2011-11-22T21:15:44  *** grzywacz has quit IRC
 568 2011-11-22T21:16:13  *** grzywacz has joined #moin-dev
 569 2011-11-22T21:16:14  *** grzywacz has joined #moin-dev
 570 2011-11-22T21:16:53  <izibi> WTF?! now something is completely broken
 571 2011-11-22T21:28:42  <izibi> i need help, i don't understand what's going on here at all
 572 2011-11-22T21:35:06  <izibi> maybe using the disabled flag does cause some problems?
 573 2011-11-22T21:44:58  *** raignarok has joined #moin-dev
 574 2011-11-22T22:17:01  <ThomasWaldmann> re
 575 2011-11-22T22:17:58  <izibi> wb
 576 2011-11-22T22:18:51  <izibi> tl;dr: everything is broken :(
 577 2011-11-22T22:20:24  <jbillsgci11> ThomasWaldmann: I have submitted a patch
 578 2011-11-22T22:23:27  <ThomasWaldmann> jbillsgci11: please fix spacing
 579 2011-11-22T22:23:32  <ThomasWaldmann> in the css
 580 2011-11-22T22:23:43  <jbillsgci11> The p's?
 581 2011-11-22T22:23:57  <jbillsgci11> or the paragraph icons?
 582 2011-11-22T22:25:09  <ThomasWaldmann> the distribution of char 0x20 in the css file
 583 2011-11-22T22:26:48  <jbillsgci11> what is char 0x20?
 584 2011-11-22T22:27:20  <ThomasWaldmann> space
 585 2011-11-22T22:27:37  <jbillsgci11> oh
 586 2011-11-22T22:27:40  <jbillsgci11> that
 587 2011-11-22T22:27:49  <jbillsgci11> whats the emoticon for blushing?
 588 2011-11-22T22:28:07  <ThomasWaldmann> no idea
 589 2011-11-22T22:28:19  <jbillsgci11> Iok
 590 2011-11-22T22:28:23  <jbillsgci11> ok
 591 2011-11-22T22:28:54  <ThomasWaldmann> -.permalink { display: none; cursor: pointer; font-size: 80%; margin-left: 3px; }
 592 2011-11-22T22:28:58  <ThomasWaldmann> +.permalink { display: none; cursor: pointer; font-size: 80%; margin-left: 3px;}
 593 2011-11-22T22:29:01  <ThomasWaldmann> why do you do such changes?
 594 2011-11-22T22:29:09  <ThomasWaldmann> did you read the diff?
 595 2011-11-22T22:32:14  <jbillsgci11> I read it.
 596 2011-11-22T22:32:38  <jbillsgci11> It was an accident. I dont like unnessecary spaces in css files
 597 2011-11-22T22:33:03  <jbillsgci11> I tend to remove them whenever I edit a line
 598 2011-11-22T22:33:19  <jbillsgci11> the space I mean
 599 2011-11-22T22:35:00  <jbillsgci11> I will upload a new version
 600 2011-11-22T22:35:06  <nickr5> ThomasWaldmann: any chance you could review http://www.google-melange.com/gci/task/view/google/gci2011/7162202 ?
 601 2011-11-22T22:38:32  <izibi> ThomasWaldmann: do you have any idea what's going on with the storage stuff?
 602 2011-11-22T22:39:19  <jbillsgci11> ThomasWaldmann: I have uploaded a new version that does not include anything unnecessary.
 603 2011-11-22T22:54:59  <izibi> this can't be true...
 604 2011-11-22T22:55:17  <izibi> now recoverpass_key is None
 605 2011-11-22T22:55:32  <izibi> but it's set in the files on the disk
 606 2011-11-22T22:55:33  <izibi> wtf?
 607 2011-11-22T23:05:31  <izibi> who wrote all that storage stuff? the only thing i can imagine is that the disabled flag prevents the data from loading
 608 2011-11-22T23:05:39  <izibi> but i can't find anything in the code
 609 2011-11-22T23:13:46  <ThomasWaldmann> re (sorry, was busy otherwise)
 610 2011-11-22T23:13:52  <izibi> wb
 611 2011-11-22T23:13:55  <ThomasWaldmann> nickr5: i read it soon
 612 2011-11-22T23:14:15  <nickr5> alright, thanks!
 613 2011-11-22T23:14:58  <ThomasWaldmann> izibi: hmm, strange
 614 2011-11-22T23:15:37  <ThomasWaldmann> izibi: the new storage stuff shouldn't be the problem, it has good tests
 615 2011-11-22T23:15:44  <izibi> u = user.User(auth_username=request.values['username']) <-- is this the right way to load a user?
 616 2011-11-22T23:16:08  <izibi> recoverpass does it just like this
 617 2011-11-22T23:16:10  <ThomasWaldmann> (i mean backends, stores, etc. - as i said, user is mostly old code still, except that it calls new storage code)
 618 2011-11-22T23:16:51  <ThomasWaldmann> that looks like correct if you want to create an authenticated user
 619 2011-11-22T23:17:10  <ThomasWaldmann> ..object
 620 2011-11-22T23:17:24  <izibi> then how to do it right?
 621 2011-11-22T23:19:10  <ThomasWaldmann> use grep :)
 622 2011-11-22T23:20:05  <izibi> new task: port moin to bash script?
 623 2011-11-22T23:22:11  <izibi> search_users(name_exact='...') doesn't work either
 624 2011-11-22T23:22:57  <ThomasWaldmann> nickr5: there?
 625 2011-11-22T23:23:03  <nickr5> yeah
 626 2011-11-22T23:23:09  <ThomasWaldmann>        Running multiple wikis together on one server. Often, there is some
 627 2011-11-22T23:23:09  <ThomasWaldmann> -      shared, common configuration used (inherited) by all wikis, so that
 628 2011-11-22T23:23:09  <ThomasWaldmann> +      shared, common configuration used (inherited) by all wikis, so each
 629 2011-11-22T23:23:10  <ThomasWaldmann>        the individual wiki's configuration becomes rather small.
 630 2011-11-22T23:23:19  <ThomasWaldmann> "each the" is correct?
 631 2011-11-22T23:25:50  <nickr5> no, you're right, sorry I missed that.
 632 2011-11-22T23:28:21  <ThomasWaldmann> nickr5: when you upload a new version, use a better filename
 633 2011-11-22T23:28:30  <ThomasWaldmann> I'll have a lot of moin.patch soon :D
 634 2011-11-22T23:28:36  <nickr5> haha ok :)
 635 2011-11-22T23:29:11  <izibi> ok, the weird stuff only happens after generating the token
 636 2011-11-22T23:29:14  <ThomasWaldmann> do you think the rest is ok, or do you want to read through it as a whole once more?
 637 2011-11-22T23:29:23  <ThomasWaldmann> nickr5:
 638 2011-11-22T23:29:55  <ThomasWaldmann> izibi: maybe some unit tests would help?
 639 2011-11-22T23:30:27  <nickr5> well I have gone through it at least twice but it might be worth going through again
 640 2011-11-22T23:32:17  <izibi> ThomasWaldmann: but i don't know whats going wrong
 641 2011-11-22T23:32:51  <ThomasWaldmann> nickr5: ok, i just set it as needs more work for now, so you can update it and close it after your next upload
 642 2011-11-22T23:33:28  <ThomasWaldmann> izibi: can you summarize the problem in 3 sentences?
 643 2011-11-22T23:33:39  <nickr5> ok, thanks for looking at it
 644 2011-11-22T23:33:57  <izibi> you create one user, everything works fine
 645 2011-11-22T23:34:18  <izibi> you create two users without enabling the first one, you can't load the first one any more from the storage
 646 2011-11-22T23:34:48  <izibi> and i guess there also happen strange things to the first user when you enable it and then enable the second one
 647 2011-11-22T23:39:36  <ThomasWaldmann> jbillsgci11: why does h4 not specify font size (1em?)
 648 2011-11-22T23:41:07  <jbillsgci11> umm...
 649 2011-11-22T23:41:09  <izibi> i can't replicate this in a shell. wtf?
 650 2011-11-22T23:41:13  <jbillsgci11> I do not know.
 651 2011-11-22T23:41:19  <jbillsgci11> I will get on that.
 652 2011-11-22T23:42:12  <jbillsgci11> It was not there in the original version
 653 2011-11-22T23:43:00  <jbillsgci11> perhaps h4 has 1em by default
 654 2011-11-22T23:43:21  <jbillsgci11> and someone thought it was superfluous
 655 2011-11-22T23:43:30  <ThomasWaldmann> jbillsgci11: also, isn't it confusing if the complete heading is changing on hover, not only the paragraph?
 656 2011-11-22T23:44:00  <jbillsgci11> I do not understand
 657 2011-11-22T23:44:15  <ThomasWaldmann> +#moin-content h2:hover { color: #4D7DA9; }
 658 2011-11-22T23:44:29  <ThomasWaldmann> that means the complete headline changes if you hover it.
 659 2011-11-22T23:44:45  <ThomasWaldmann> but only the paragraph symbol should appear, right?
 660 2011-11-22T23:45:08  <ThomasWaldmann> otherwise people might think the headline is a link or some other functionality if it changes colour on hover
 661 2011-11-22T23:45:18  <jbillsgci11> ok
 662 2011-11-22T23:45:24  <izibi> http://paste.pocoo.org/show/511647/ there it's working fine
 663 2011-11-22T23:45:43  <jbillsgci11> Ill fix
 664 2011-11-22T23:45:47  <ThomasWaldmann> +h6:hover .permalink { display: inline;text-decoration: none; }
 665 2011-11-22T23:45:52  <ThomasWaldmann> blank missing in the middle
 666 2011-11-22T23:48:18  <jbillsgci11> ok
 667 2011-11-22T23:48:43  <ThomasWaldmann> sorry for nitpicking, but py coders like consistent spacing :)
 668 2011-11-22T23:48:57  <jbillsgci11> should the paragraph icon be grey
 669 2011-11-22T23:49:01  <jbillsgci11> still?
 670 2011-11-22T23:49:07  *** raignarok has quit IRC
 671 2011-11-22T23:49:20  <jbillsgci11> Or would a different color work better?
 672 2011-11-22T23:49:57  <ThomasWaldmann> choose whatever looks best. grey is maybe not bad, shouldn't be too intensive.
 673 2011-11-22T23:50:19  <ThomasWaldmann> is that background color for -webkit needed?
 674 2011-11-22T23:51:21  <jbillsgci11> no
 675 2011-11-22T23:51:32  <jbillsgci11> thats outside of webkit isnt it
 676 2011-11-22T23:51:55  <izibi> i guess my head is about to explode :D
 677 2011-11-22T23:52:28  <jbillsgci11> its to make sure the lines dont overlay the toc
 678 2011-11-22T23:52:32  <ThomasWaldmann> -            -webkit-box-shadow: 10px 10px 5px #679; -webkit-border-radius: 15px; }
 679 2011-11-22T23:52:35  <ThomasWaldmann> +            -webkit-box-shadow: 10px 10px 5px #679; -webkit-border-radius: 15px; background: #fff; }
 680 2011-11-22T23:52:52  <ThomasWaldmann> oh, yes, maybe format a bit differently then :)
 681 2011-11-22T23:52:57  <jbillsgci11> ok
 682 2011-11-22T23:53:13  <jbillsgci11> I personally think the toc looks better in white
 683 2011-11-22T23:53:27  <ThomasWaldmann> jbillsgci11: and please add a tooltip for the paragraph symbol
 684 2011-11-22T23:53:35  <jbillsgci11> ok
 685 2011-11-22T23:53:40  <ThomasWaldmann> like "this links to the current paragraph"
 686 2011-11-22T23:53:51  <ThomasWaldmann> ehrm, i18n?
 687 2011-11-22T23:54:05  <jbillsgci11> should it be that direct?
 688 2011-11-22T23:54:22  <ThomasWaldmann> (that is a code change then)
 689 2011-11-22T23:56:14  <ThomasWaldmann> if you have better wording, feel free
 690 2011-11-22T23:56:33  <ThomasWaldmann> izibi: don't let it explode :D
 691 2011-11-22T23:56:38  <izibi> WHY THE HELL DOESN'T THIS WORK?! AAAHHHH :D
 692 2011-11-22T23:57:14  <ThomasWaldmann> it must be something special, because (AFAIK) user profiles usually work, somehow

MoinMoin: MoinMoinChat/Logs/moin-dev/2011-11-22 (last edited 2011-11-21 23:45:03 by IrcLogImporter)