1 2011-10-16T00:25:40 *** away_
2 2011-10-16T00:33:06 <vedranm> ThomasWaldmann: back :)
3 2011-10-16T00:33:10 <vedranm> time to test format stuff
4 2011-10-16T00:36:37 <vedranm> ok, it fails
5 2011-10-16T00:36:42 <vedranm> :)
6 2011-10-16T00:47:24 <vedranm> ok, it seems I have broken ~15 tests
7 2011-10-16T00:53:02 <ThomasWaldmann> oops
8 2011-10-16T00:54:10 <vedranm> indeed
9 2011-10-16T00:54:29 <vedranm> can you help me to nail those down?
10 2011-10-16T00:54:46 <vedranm> it's actuall not 15, it's 17
11 2011-10-16T00:55:00 <vedranm> but I expected something like that
12 2011-10-16T00:55:03 <vedranm> MoinMoin/mail/sendmail.py
13 2011-10-16T00:55:05 <vedranm> sorry
14 2011-10-16T00:55:11 <vedranm> 107 files changed, 466 insertions(+), 515 deletions(-)
15 2011-10-16T01:01:07 <ThomasWaldmann> well, if you post a diff somewhere we can collaborate
16 2011-10-16T01:04:01 <vedranm> ok
17 2011-10-16T01:04:17 <vedranm> http://codereview.appspot.com/5277048/
18 2011-10-16T01:04:40 <vedranm> don't be too hard on me :)
19 2011-10-16T01:04:50 <ThomasWaldmann> ok, i'll just review it :)
20 2011-10-16T01:05:24 <ThomasWaldmann> we all need to watch that video about genius coders :)
21 2011-10-16T01:05:26 <vedranm> there is a lot of stuff, I suggest you to import the patch and run the tests instead of going thru all the lines
22 2011-10-16T01:05:45 <vedranm> genius coders=
23 2011-10-16T01:05:46 <vedranm> ?
24 2011-10-16T01:06:06 <ThomasWaldmann> google it, nice video from some python conf
25 2011-10-16T01:07:22 * ThomasWaldmann runs test after applying the diff
26 2011-10-16T01:08:00 <ThomasWaldmann> http://www.google.com/events/io/2009/sessions/MythGeniusProgrammer.html iirc that was it
27 2011-10-16T01:09:07 <vedranm> thx
28 2011-10-16T01:09:09 <vedranm> couldn't find it
29 2011-10-16T01:09:24 <vedranm> oh, I believe I watched that a while ago
30 2011-10-16T01:09:30 <vedranm> SVN guys, right?
31 2011-10-16T01:13:07 <ThomasWaldmann> ok, I'll look at the converter/ stuff, ok?
32 2011-10-16T01:13:14 <vedranm> sure
33 2011-10-16T01:42:28 <ThomasWaldmann> ok, converter tests fixed, looking for more stuff...
34 2011-10-16T01:43:34 <ThomasWaldmann> one problem is that if one needs verbatim { in a format string, one needs to double it
35 2011-10-16T01:43:43 <ThomasWaldmann> same for }
36 2011-10-16T01:44:55 <ThomasWaldmann> vedranm: which did you already fix?
37 2011-10-16T01:48:05 *** raignarok
38 2011-10-16T01:49:03 <vedranm> which what?
39 2011-10-16T01:49:24 <ThomasWaldmann> test failures / files
40 2011-10-16T01:49:33 <vedranm> none
41 2011-10-16T01:49:40 <vedranm> I don't know how to start on fixing them
42 2011-10-16T01:49:44 <vedranm> e.g. sendmail fails
43 2011-10-16T01:49:46 <ThomasWaldmann> ok, if fixed the items/__init__.py
44 2011-10-16T01:49:50 <vedranm> but I see no obvious error
45 2011-10-16T01:50:03 <ThomasWaldmann> so only sendmail left for you :)
46 2011-10-16T01:50:13 <ThomasWaldmann> return "{0!s}{1!s}<{2!s}>".format(phrase, blanks, addr)
47 2011-10-16T01:50:18 <ThomasWaldmann> line 53?
48 2011-10-16T01:50:29 <vedranm> yes
49 2011-10-16T01:50:45 <ThomasWaldmann> you fix it?
50 2011-10-16T01:51:01 <vedranm> no
51 2011-10-16T01:51:58 * ThomasWaldmann runs all tests again
52 2011-10-16T01:52:16 <vedranm> by the way, I would like to know what mistakes I had made
53 2011-10-16T01:52:16 <ThomasWaldmann> then you can just apply my diff on top of your work and see
54 2011-10-16T01:52:36 <ThomasWaldmann> you see it easily in the diff
55 2011-10-16T01:53:22 <ThomasWaldmann> few typos, sometimes increased counter when not needed, sometimes not when needed
56 2011-10-16T01:53:58 <vedranm> ok
57 2011-10-16T01:54:08 <vedranm> what was wrong with sendmail?
58 2011-10-16T01:54:15 <ThomasWaldmann> http://paste.ubuntu.com/709052/ < zero fails after this, please review before applying
59 2011-10-16T01:55:31 <ThomasWaldmann> the most difficult thing was the missing tuple unpack, because % does that automatically
60 2011-10-16T01:55:36 <vedranm> I see
61 2011-10-16T01:55:55 <ThomasWaldmann> maybe run the tests again also after applying
62 2011-10-16T01:56:03 <vedranm> absolutely
63 2011-10-16T01:56:11 <ThomasWaldmann> if you have 0 fails, make a changeset i can pull from you
64 2011-10-16T01:57:50 <vedranm> ok
65 2011-10-16T01:57:55 <vedranm> why are 10 tests skipped?
66 2011-10-16T01:58:45 <ThomasWaldmann> give -rs to py.test to see
67 2011-10-16T01:58:47 <ThomasWaldmann> - return "%s%s<%s>" % (str(phrase), str(blanks), str(addr))
68 2011-10-16T01:58:47 <ThomasWaldmann> + return "{0!s}{0!s}<{0!s}>".format(phrase, blanks, addr)
69 2011-10-16T01:58:56 <ThomasWaldmann> why is that !s there?
70 2011-10-16T02:00:01 <vedranm> it's for str() cast
71 2011-10-16T02:00:16 <ThomasWaldmann> ok
72 2011-10-16T02:00:24 <vedranm> ok, 1 failed
73 2011-10-16T02:00:33 <vedranm> TestTransformableBitmapImage.test__render_data_diff
74 2011-10-16T02:01:22 <ThomasWaldmann> strange, i had 0 fails
75 2011-10-16T02:02:11 <vedranm> indeed
76 2011-10-16T02:02:36 <ThomasWaldmann> do you have PIL installed?
77 2011-10-16T02:05:57 <ThomasWaldmann> vedranm: can you show the failing test output
78 2011-10-16T02:06:21 <ThomasWaldmann> i suspect that the test needs fixing, but wasn't yet because it does not run if one does not have pil installed
79 2011-10-16T02:07:50 <vedranm> hmm
80 2011-10-16T02:07:52 <vedranm> let me check
81 2011-10-16T02:07:56 <ThomasWaldmann> yes, for sure needs fixing. due to revno -> revid change.
82 2011-10-16T02:08:29 <ThomasWaldmann> if that is the only one, you can ignore it, it is not due to your changes.
83 2011-10-16T02:09:52 <ThomasWaldmann> i still would like to have the test output, though :)
84 2011-10-16T02:14:11 <vedranm> $ rpm -q python-imaging
85 2011-10-16T02:14:12 <vedranm> package python-imaging is not installed
86 2011-10-16T02:14:33 <vedranm> i will pastebin test output in a sec
87 2011-10-16T02:16:34 <vedranm> http://pastebin.ubuntu.com/709074/
88 2011-10-16T02:17:52 <vedranm> OK, I fixed a couple more
89 2011-10-16T02:18:38 <ThomasWaldmann> from PIL import Image as PILImage as that succeeds, you have it
90 2011-10-16T02:19:50 <vedranm> indeed
91 2011-10-16T02:19:58 <vedranm> so a mistake is somewhere else
92 2011-10-16T02:23:31 <ThomasWaldmann> you don't need to fix the image url issue, i can do that later
93 2011-10-16T02:24:52 <vedranm> ok
94 2011-10-16T02:25:24 <vedranm> should I upload it to Rietveld or commit to Bitbucket?
95 2011-10-16T02:27:44 <ThomasWaldmann> commit it :)
96 2011-10-16T02:27:49 <vedranm> yeah :)
97 2011-10-16T02:28:33 <ThomasWaldmann> http://readthedocs.org/docs/moin-20/en/latest/ now we have regularly built docs :)
98 2011-10-16T02:30:15 <vedranm> they look really nice :)
99 2011-10-16T02:30:38 <vedranm> is that new default sphinx theme or something else?
100 2011-10-16T02:30:53 <ThomasWaldmann> i have just used the default stuff iirc
101 2011-10-16T02:31:22 <ThomasWaldmann> but it looks a bit different on rtd as when locally generated
102 2011-10-16T02:31:52 <vedranm> oh
103 2011-10-16T02:31:54 <vedranm> ok
104 2011-10-16T02:32:08 <vedranm> well, their main site has the same theeme
105 2011-10-16T02:32:13 <vedranm> theme^
106 2011-10-16T02:32:35 <vedranm> so it's probably something custom that only rtd uses
107 2011-10-16T02:55:34 <vedranm> ok, going to sleep
108 2011-10-16T02:55:49 <vedranm> good night ThomasWaldmann :)
109 2011-10-16T02:56:19 <ThomasWaldmann> gn vedranm
110 2011-10-16T09:35:29 *** away_
111 2011-10-16T09:44:07 * dreimark nice speed now for tests
112 2011-10-16T09:45:03 <dreimark> can't install python-ldap with pip currently
113 2011-10-16T09:48:23 <dreimark> with lxml 6 failed, 647 passed, 254 skipped, 1 xfailed in 27.37 seconds
114 2011-10-16T09:50:05 <dreimark> http://paste.pocoo.org/show/493225/
115 2011-10-16T09:58:11 <dreimark> we miss those test im lxml is missing, that is bad
116 2011-10-16T09:59:22 <dreimark> can't we do that tests by emeraldtree? as we are based on it why are the tests by etree?
117 2011-10-16T10:02:20 <dreimark> extras_require should have alternative lxml listed
118 2011-10-16T10:13:01 <dreimark> bbl
119 2011-10-16T11:22:10 *** greg_f
120 2011-10-16T11:49:13 *** raignarok
121 2011-10-16T12:39:08 *** raignarok
122 2011-10-16T12:56:44 <ThomasWaldmann> moin
123 2011-10-16T12:57:15 <ThomasWaldmann> dreimark: please check the stuff you file to the bb issue tracker and close what's already fixed
124 2011-10-16T14:07:28 *** raignarok
125 2011-10-16T15:30:02 <vedranm> ThomasWaldmann: I made a commit
126 2011-10-16T15:30:05 <vedranm> yesterday
127 2011-10-16T15:30:13 <ThomasWaldmann> url?
128 2011-10-16T15:30:14 <vedranm> so you can pull it from my bb repo
129 2011-10-16T15:30:27 <vedranm> https://bitbucket.org/rivanvx/moin-2.0
130 2011-10-16T15:32:18 * ThomasWaldmann pulls
131 2011-10-16T15:46:44 <CIA-65> Vedran Mileti? <rivanvx@gmail.com> default * 969:5bf6d7a2ffcf 2.0/MoinMoin/ (110 files in 34 dirs): Convert all %r, %s, %x, %d, %i, %o to new Format String Syntax
132 2011-10-16T15:46:45 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 970:de23e50d1801 2.0/MoinMoin/apps/frontend/views.py: .format() usage: fix 2 places that triggered unicode exceptions
133 2011-10-16T15:47:02 <ThomasWaldmann> vedranm: ^^ (that stuff was found by clicking through the UI)
134 2011-10-16T16:23:23 *** raignarok
135 2011-10-16T17:22:49 *** jek
136 2011-10-16T17:22:49 *** jek
137 2011-10-16T19:18:22 *** raignarok
138 2011-10-16T19:44:49 <vedranm> ThomasWaldmann: thanks
139 2011-10-16T19:45:04 <vedranm> I probably should have checked that
140 2011-10-16T19:46:28 *** greg_f
141 2011-10-16T19:59:33 *** grzywacz
142 2011-10-16T19:59:33 *** grzywacz
143 2011-10-16T21:00:31 *** vedranm
144 2011-10-16T22:07:18 *** grzywacz
145 2011-10-16T22:10:57 *** MattMaker_afk
146 2011-10-16T22:51:29 *** raignarok
147 2011-10-16T23:09:22 *** away_
148 2011-10-16T23:12:09 *** raignarok
149 2011-10-16T23:25:35 *** raignarok
150 2011-10-16T23:26:26 *** raignarok
151 2011-10-16T23:40:25 <dreimark> ThomasWaldmann: i review that tom, there are some in question
152 2011-10-16T23:44:56 <dreimark> hmm, it would be better we could use bb issue tracker for preparation of gci tasks
153 2011-10-16T23:45:21 <dreimark> because then they are defined in an environment everyone interested can just take one
154 2011-10-16T23:51:58 <ThomasWaldmann> well, my thoughts were similar, but then we'ld need a new tool for uploading
155 2011-10-16T23:54:42 <ThomasWaldmann> (into melange)
