1 2011-10-15T01:09:44 *** grzywacz
2 2011-10-15T07:41:18 *** away_
3 2011-10-15T10:20:10 <dreimark> ThomasWaldmann: various mailinglist mails
4 2011-10-15T10:26:30 <dreimark> gci, gsoc etc. lists
5 2011-10-15T10:28:02 <dreimark> http://www.google-melange.com/gci/homepage/google/gci2011
6 2011-10-15T11:01:40 <ThomasWaldmann> found it
7 2011-10-15T11:08:04 <ThomasWaldmann> hmm, nothing about how an org applies for participation?
8 2011-10-15T11:47:05 <ronny> moinmoin
9 2011-10-15T12:06:14 <ThomasWaldmann> hi ronny
10 2011-10-15T12:22:28 <ThomasWaldmann> ronny: i am currently preparing a constants package with modules acl and meta
11 2011-10-15T12:22:55 <ThomasWaldmann> inside the modules, there are the constants defined on module level
12 2011-10-15T12:23:19 <ThomasWaldmann> so one can use from MoinMoin.constants import acl, meta
13 2011-10-15T12:23:34 <ThomasWaldmann> meta.ACL, acl.READ
14 2011-10-15T12:27:57 <dreimark> ThomasWaldmann: On November 9, we’ll announce the participating mentoring organizations.
15 2011-10-15T12:28:13 <dreimark> i guess they discuss this on the summit
16 2011-10-15T12:30:03 <ThomasWaldmann> maybe. but i guess they also need a procedure to apply for every org, not just summit participants.
17 2011-10-15T12:30:24 <ThomasWaldmann> at least if they want to run it on a bigger scale.
18 2011-10-15T12:30:26 <dreimark> yes, in the past it was nec. to be a gsoc org
19 2011-10-15T12:30:46 <dreimark> or they select another 20 or sim.
20 2011-10-15T12:30:58 <dreimark> bbl
21 2011-10-15T12:52:03 *** greg_f
22 2011-10-15T12:55:20 <ronny> ThomasWaldmann: sounds like a reasonable layout
23 2011-10-15T13:00:09 <ThomasWaldmann> i am thinking about module name for meta keys / whoosh field names
24 2011-10-15T13:00:33 <ThomasWaldmann> first wanted to use "meta", but this likely collides with local "meta" names everywhere
25 2011-10-15T13:00:47 <ThomasWaldmann> use "key"? "field"?
26 2011-10-15T13:04:33 <ThomasWaldmann> similar for "acl", maybe better "rights" as module name?
27 2011-10-15T13:05:54 *** raignarok
28 2011-10-15T13:17:06 <ThomasWaldmann> ronny: E AssertionError: Popped wrong request context. (<RequestContext 'http://localhost/' [GET] of MoinMoin> instead of <RequestContext 'http://localhost/' [GET] of MoinMoin>)
29 2011-10-15T13:17:36 <ThomasWaldmann> we see this since recently, maybe since some flask/werkzeug upgrade. any idea?
30 2011-10-15T13:18:07 *** vedranm
31 2011-10-15T13:19:06 <ThomasWaldmann> also, do you know if there is some generic method for py.test when tests need some tcp server listing on some specific port, so we can skip tests if that server/port does not listen?
32 2011-10-15T13:25:14 *** raignarok
33 2011-10-15T13:29:05 <ThomasWaldmann> current module names: chartypes, contenttypes, keys, misc, rights
34 2011-10-15T13:32:10 *** raignarok
35 2011-10-15T13:33:04 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 960:561424f1a662 2.0/MoinMoin/ (10 files in 4 dirs): (log message trimmed)
36 2011-10-15T13:33:04 <CIA-65> move constants to modules within new MoinMoin.constants package
37 2011-10-15T13:33:04 <CIA-65> typical usage:
38 2011-10-15T13:33:04 <CIA-65> from MoinMoin.constants import keys, rights
39 2011-10-15T13:33:04 <CIA-65> ...
40 2011-10-15T13:33:04 <CIA-65> meta[keys.ACL] = ...
41 2011-10-15T13:33:04 <CIA-65> ...
42 2011-10-15T13:40:00 <ronny> ThomasWaldmann: a setup hook that skups if a mark is set maybe
43 2011-10-15T14:07:31 <vedranm> hi ThomasWaldmann
44 2011-10-15T14:07:47 <vedranm> I'm almost done with replacing %s, %x, %r stuff
45 2011-10-15T14:07:59 <vedranm> %(foo)s is still todo
46 2011-10-15T14:08:09 <vedranm> can you include the partial patch?
47 2011-10-15T14:10:25 <ThomasWaldmann> vedranm: if you completed some specific sub task, yes, sure
48 2011-10-15T14:10:53 <ThomasWaldmann> btw, you know it must run on 2.6?
49 2011-10-15T14:31:47 <vedranm> yes
50 2011-10-15T14:31:50 <vedranm> it will run on 2.6
51 2011-10-15T14:32:01 <vedranm> I took care not to use {} without 0 or 1 or so inside
52 2011-10-15T14:32:07 <vedranm> 2.6 supports new format strings
53 2011-10-15T14:32:18 <ThomasWaldmann> ok
54 2011-10-15T14:32:38 * ThomasWaldmann resisted to do other global changes while you do
55 2011-10-15T14:32:54 <vedranm> that's nice of you :-)
56 2011-10-15T14:33:17 <vedranm> btw, you mentioned earlier that 2011-11-11 something will be out
57 2011-10-15T14:34:04 <vedranm> does that still seem realistic?
58 2011-10-15T14:34:45 <ThomasWaldmann> for alpha (maybe beta) yes, i never said it will be a production release :)
59 2011-10-15T14:35:04 <vedranm> sure, sure
60 2011-10-15T14:35:12 <vedranm> greate
61 2011-10-15T14:35:14 <vedranm> great^
62 2011-10-15T14:36:28 <ThomasWaldmann> vedranm: btw, please run unit tests before submitting a changeset / patch
63 2011-10-15T14:36:53 <ThomasWaldmann> test failure count with and without your changes should be the same and rather low
64 2011-10-15T14:37:48 <vedranm> sure
65 2011-10-15T14:39:28 <vedranm> by the way, unrelated, can I use MathJax with Moin?
66 2011-10-15T14:39:31 <vedranm> 2.0 or 1.9?
67 2011-10-15T14:39:44 <vedranm> either would be OK
68 2011-10-15T14:40:58 <vedranm> I saw in the logs that MathJax was removed at some point from 2.0
69 2011-10-15T14:41:08 *** raignarok_
70 2011-10-15T14:42:35 *** raignarok
71 2011-10-15T14:46:54 <ThomasWaldmann> vedranm: dreimark did some experiments with mathjax and we initially had it included in the default dependencies
72 2011-10-15T14:47:24 <ThomasWaldmann> but due to the vast amount of files mathjax installs and also the time it takes to install/uninstall it, we took it out agan
73 2011-10-15T14:47:38 <ThomasWaldmann> but iirc it is documented how to install it
74 2011-10-15T14:47:44 <ThomasWaldmann> (see moin2 docs)
75 2011-10-15T14:49:05 <vedranm> does it work on 1.9?
76 2011-10-15T14:49:34 <ThomasWaldmann> i didn't use that stuff personally, no idea
77 2011-10-15T14:49:42 <vedranm> ok
78 2011-10-15T14:49:44 <vedranm> will check
79 2011-10-15T14:50:01 <ThomasWaldmann> but as it is just some js / static files stuff, i think it should be doable somehow
80 2011-10-15T14:53:04 <vedranm> what is %-25s?
81 2011-10-15T14:53:09 <vedranm> what does it mean?
82 2011-10-15T14:58:26 *** raignarok_
83 2011-10-15T15:10:51 <ThomasWaldmann> vedranm: a string, 25 chars long, right aligned
84 2011-10-15T15:11:28 <vedranm> ok
85 2011-10-15T15:20:37 <vedranm> btw, MathJax works on 1.9
86 2011-10-15T15:20:41 <vedranm> and works nicely :)
87 2011-10-15T15:20:46 <vedranm> and it's really easy to set up
88 2011-10-15T15:20:59 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 961:1a1257db441c 2.0/MoinMoin/ (conftest.py _tests/test_logging.conf test_logging.conf): move test_logging.conf to _tests/ where also the wikiconfig for the tests is located
89 2011-10-15T15:21:10 <vedranm> i just had to change themes/__init__.py or something like that
90 2011-10-15T15:21:36 * ThomasWaldmann brb in 10 mins
91 2011-10-15T15:24:17 <vedranm> ThomasWaldmann: I want to discuss choice of fonts when you get back :)
92 2011-10-15T15:39:10 <ThomasWaldmann> i am happy with anything that works great and looks good in practice
93 2011-10-15T15:41:54 <ThomasWaldmann> xorAxAx: dreimark: shall we use bitbucket issue tracker this time for gci?
94 2011-10-15T15:42:22 <xorAxAx> you mean where students submit found bugs?
95 2011-10-15T15:42:47 <ThomasWaldmann> we can do that of course, but what i meant was for tasks
96 2011-10-15T15:43:22 <xorAxAx> may we use a non-google system to provide tasks?
97 2011-10-15T15:43:37 <ThomasWaldmann> would need adapting / rewriting that tool that uploads stuff to melange
98 2011-10-15T15:44:57 <ThomasWaldmann> of course the metadata available on bb issue tracker sucks as much as the one value google wants :)
99 2011-10-15T15:45:25 <ThomasWaldmann> (difficulty or whatever you call it)
100 2011-10-15T15:46:10 <ThomasWaldmann> we could also use moin2 to have any metadata we want :D
101 2011-10-15T15:46:11 <vedranm> ThomasWaldmann: I'm done with all non-%(foo)s %-style strings
102 2011-10-15T15:46:15 <vedranm> or at least grep says me so
103 2011-10-15T15:46:30 <vedranm> 107 files changed, 466 insertions(+), 515 deletions(-)
104 2011-10-15T15:46:36 <ThomasWaldmann> vedranm: use rietveld :)
105 2011-10-15T15:46:40 <vedranm> sure
106 2011-10-15T15:46:43 <vedranm> how do I test all this?
107 2011-10-15T15:46:50 <ThomasWaldmann> run py.test
108 2011-10-15T15:47:20 <ThomasWaldmann> (and also do a quick manual check using moin interactively)
109 2011-10-15T15:47:41 <vedranm> ok
110 2011-10-15T15:48:24 <vedranm> sorry, got to go urgently
111 2011-10-15T15:48:29 <vedranm> will test a bit later
112 2011-10-15T15:48:45 <vedranm> tomorrow at worst
113 2011-10-15T15:49:21 * ThomasWaldmann will be away on tuesday. far away :)
114 2011-10-15T15:59:36 <xorAxAx> ThomasWaldmann: i think we should keep the old solution, i worked fine
115 2011-10-15T16:41:12 * ThomasWaldmann just posted 2 mails to the gci ml about stuff that could be improved
116 2011-10-15T17:27:21 <ThomasWaldmann> ronny: ok, i have finished the socket code and will commit it soon. can you show what you mean exactly after that?
117 2011-10-15T18:37:36 <ThomasWaldmann> ronny: do we need OVERWRITE right?
118 2011-10-15T18:37:58 <ThomasWaldmann> i have thought about it and i think it is somehow equivalent with DESTROY
119 2011-10-15T18:39:00 <ThomasWaldmann> (because the previous information of the revision in question is GONE)
120 2011-10-15T18:53:04 *** jek
121 2011-10-15T18:53:25 *** jek
122 2011-10-15T18:55:08 <ronny> ThomasWaldmann: not sure if we need it, they are equivalent after all (both operations overwrite the rev content)
123 2011-10-15T19:02:13 <ThomasWaldmann> I'll try removing it.
124 2011-10-15T19:02:57 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 962:3684c2e7e843 2.0/MoinMoin/storage/stores/_tests/ (test_kc.py test_kt.py): kyoto tycoon/cabinet store tests: fix imports
125 2011-10-15T19:02:57 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 963:3c6e0fe3f48e 2.0/MoinMoin/ (3 files in 2 dirs):
126 2011-10-15T19:02:57 <CIA-65> add a test_connection function that tests whether a server:port can be connected to
127 2011-10-15T19:02:57 <CIA-65> use it for the kt store tests to skip if we can't reach the server
128 2011-10-15T19:03:22 <ThomasWaldmann> ronny: ^^
129 2011-10-15T19:13:38 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 964:9356e40c8108 2.0/MoinMoin/ (3 files in 3 dirs):
130 2011-10-15T19:13:38 <CIA-65> remove OVERWRITE right again, looks equivalent to DESTROY
131 2011-10-15T19:13:38 <CIA-65> if we overwrite one or multiple revisions with new meta/data, the previous
132 2011-10-15T19:13:38 <CIA-65> meta/data there is gone (== destroyed), so requiring DESTROY permissions
133 2011-10-15T19:13:38 <CIA-65> seems to be the right thing.
134 2011-10-15T19:23:34 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 965:5ae7ee396b6e 2.0/MoinMoin/constants/rights.py: ACL rights: add comments
135 2011-10-15T19:47:57 *** greg_f
136 2011-10-15T19:48:46 *** greg_f
137 2011-10-15T20:06:41 <ThomasWaldmann> btw, did someone review these conftest.py hacks? the code looks strange and one test fails due to it.
138 2011-10-15T20:06:59 <ThomasWaldmann> waldi: xorAxAx: ronny: ^^^
139 2011-10-15T20:07:29 <ThomasWaldmann> i mean that prev_* and get_previous stuff
140 2011-10-15T20:08:05 <ThomasWaldmann> that somehow does not look sane
141 2011-10-15T20:08:34 <xorAxAx> who wrote them? my student?
142 2011-10-15T20:13:41 <ThomasWaldmann> why do you ask me? :)
143 2011-10-15T20:14:05 <ThomasWaldmann> i suspect so, but you should know better
144 2011-10-15T20:14:13 <xorAxAx> probably
145 2011-10-15T20:20:38 <ThomasWaldmann> get_previous looks like only passing through the given values
146 2011-10-15T20:21:21 <ThomasWaldmann> as it misses a global declaration, it does not set the globals (not sure if that was intended, though)
147 2011-10-15T20:22:18 <ThomasWaldmann> somehow looks rather superfluous
148 2011-10-15T20:29:41 <ThomasWaldmann> omg
149 2011-10-15T20:35:02 *** away_
150 2011-10-15T20:52:42 * ThomasWaldmann tries killing most of that code
151 2011-10-15T20:59:47 <ronny> ThomasWaldmann: afair it was supposed to cache stuff if recreation wasnt necessary
152 2011-10-15T21:00:11 <ronny> ThomasWaldmann: since backends and memorybackend should be a lot faster now, we might get by wthout it
153 2011-10-15T21:00:35 <ronny> when i reviewed it last, it was correct,m aybe something changed
154 2011-10-15T21:02:16 <ThomasWaldmann> well, afaics, the code does not use the globals correctly, it is too much code, has strange functions, ...
155 2011-10-15T21:04:15 <ThomasWaldmann> ronny: http://paste.ubuntu.com/708820/ my current changes
156 2011-10-15T21:06:05 <ThomasWaldmann> it doesn't fix the "popped wrong request context" yet, but it seems to work as well as the previous code, same fail/pass/skip count
157 2011-10-15T21:07:59 <ronny> ThomasWaldmann: i think setup/teardown should always push/pop the ctx
158 2011-10-15T21:08:43 <ronny> to correctly solve it item/collector level funcargs would be best
159 2011-10-15T21:09:42 <ronny> (thats a upcoming pytest refactoring)
160 2011-10-15T21:10:48 <ThomasWaldmann> well, we can do that later then
161 2011-10-15T21:14:13 <ThomasWaldmann> ronny: is line 24 of MoinMoin/_tests/test_test_environ.py correct (needed)?
162 2011-10-15T21:26:02 <ronny> ThomasWaldmann: that looks completely wrong
163 2011-10-15T21:26:54 <ThomasWaldmann> ok, i also think so, i remove it
164 2011-10-15T21:39:09 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 966:d1d42a09b84a 2.0/MoinMoin/ (_tests/test_test_environ.py conftest.py): (log message trimmed)
165 2011-10-15T21:39:09 <CIA-65> simplify conftest code, remove a problematic line in test_test_environ
166 2011-10-15T21:39:09 <CIA-65> the conftest code had quite some issues:
167 2011-10-15T21:39:09 <CIA-65> * code was much too complex
168 2011-10-15T21:39:09 <CIA-65> * wrong (non-)usage of globals
169 2011-10-15T21:39:09 <CIA-65> * strange get_previous function that did nothing
170 2011-10-15T21:39:10 <CIA-65> i changed to code so it implements in a much easier way the basic idea of
171 2011-10-15T21:59:43 <ThomasWaldmann> ok, now we have 4 failures due to a whoosh issues (patch exists) and 1 in the mediawiki converter
172 2011-10-15T22:24:48 *** away_
173 2011-10-15T23:26:58 *** MattMaker_afk
174 2011-10-15T23:39:11 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 967:1dbb50b3cce3 2.0/MoinMoin/converter/_tests/test_mediawiki_in.py: (log message trimmed)
175 2011-10-15T23:39:11 <CIA-65> tune the mediawiki_in tests so they only test the implemented definition list syntax
176 2011-10-15T23:39:11 <CIA-65> the mediawiki_in converter currently does not support multi-line definition list markup like:
177 2011-10-15T23:39:11 <CIA-65> ; term
178 2011-10-15T23:39:11 <CIA-65> : definition
179 2011-10-15T23:39:11 <CIA-65> it does support the single-line syntax like:
180 2011-10-15T23:39:12 <CIA-65> ; term:definition
181 2011-10-15T23:45:02 * ThomasWaldmann gets whoosh 2.3.1 from repo to resolve the last 4 failures
182 2011-10-15T23:49:31 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 968:26bd2c7936f9 2.0/setup.py: require whoosh>=2.3.1 and pull it from the repo (not on pypi yet)
183 2011-10-15T23:49:49 <ThomasWaldmann> 0 test fails! \o/
