1 2011-08-27T00:35:55 <ThomasWaldmann> brunosmartin: greetings to all the others :)
2 2011-08-27T00:36:16 <brunosmartin> :-)
3 2011-08-27T00:36:53 <brunosmartin> greetings from all the others too :-). brunos is already gone
4 2011-08-27T00:36:57 <brunosmartin> great meeting!
5 2011-08-27T00:36:59 *** brunosmartin
6 2011-08-27T00:53:59 <ThomasWaldmann> ah, new whoosh release
7 2011-08-27T01:48:36 *** MattMaker
8 2011-08-27T04:11:01 *** MattMaker
9 2011-08-27T07:04:15 *** Marchael
10 2011-08-27T07:16:58 <Marchael> moin
11 2011-08-27T07:17:15 <Marchael> seem like I passed final evaluation :)
12 2011-08-27T07:20:45 <Marchael> ThomasWaldmann: thank you once again, I'll busy for 2 or 3 days due changing my flat and moving my junk to new place, but after I'll go back to maintain my code.
13 2011-08-27T08:13:38 *** pkumar
14 2011-08-27T08:13:56 <pkumar> yay, I passed the evaluation
15 2011-08-27T08:14:40 <pkumar> Thanks to everyone for the support and help. :)
16 2011-08-27T08:32:15 *** Marchael
17 2011-08-27T08:47:28 <dreimark> moin
18 2011-08-27T08:47:57 <dreimark> ThomasWaldmann: 22:30 ? What is wrong?
19 2011-08-27T09:45:31 <dreimark> bbl
20 2011-08-27T09:50:24 <pkumar> bbl
21 2011-08-27T09:50:26 *** pkumar
22 2011-08-27T10:25:42 <ThomasWaldmann> dreimark: it currently works somehow like "compute all, then select part of it to show"
23 2011-08-27T10:28:26 <ThomasWaldmann> my idea is to rely more on whoosh for this (search_page), use whoosh's sortedby / reverse keywords
24 2011-08-27T10:28:58 <ThomasWaldmann> see also that excessive memory consumption bug i filed recently
25 2011-08-27T10:32:57 *** MattMaker
26 2011-08-27T10:33:57 *** MattMaker
27 2011-08-27T10:39:38 <ThomasWaldmann> also, for some stuff we could use range queries for whoosh
28 2011-08-27T10:43:48 <ThomasWaldmann> so e.g. if we just want to show the last 7 days on global history, we could do something like search_page(DateRange(MTIME, from, to), sortedby=MTIME, reverse=True)
29 2011-08-27T12:40:33 *** MattMaker
30 2011-08-27T12:46:47 *** MattMaker
31 2011-08-27T12:55:02 *** greg_f
32 2011-08-27T13:08:46 <ThomasWaldmann> 2011-08-27 13:04:43,556 INFO werkzeug:116 127.0.0.1 "GET /+history HTTP/1.1" 200 -
33 2011-08-27T13:08:52 <ThomasWaldmann> 2011-08-27 13:04:43,556 INFO MoinMoin.util.clock:40 timer total(0): 2237.70ms
34 2011-08-27T13:08:59 <ThomasWaldmann> previous code ^^
35 2011-08-27T13:09:07 <ThomasWaldmann> 2011-08-27 13:04:48,332 INFO werkzeug:116 127.0.0.1 "GET /+historyw HTTP/1.1" 200 -
36 2011-08-27T13:09:13 <ThomasWaldmann> 2011-08-27 13:04:48,332 INFO MoinMoin.util.clock:40 timer total(0): 69.65ms
37 2011-08-27T13:09:21 <ThomasWaldmann> new code :) ^^
38 2011-08-27T13:14:09 <ThomasWaldmann> (both was with a bookmark set - the latter used that bookmark to add a DateRange term to the whoosh query)
39 2011-08-27T13:46:06 * ThomasWaldmann gets rid of backend.history()
40 2011-08-27T14:02:33 *** MattMaker
41 2011-08-27T14:11:43 <ThomasWaldmann> xorAxAx: do you have time today for the review? I'ld like to return to 1 branch in main repo. currently i am working on pytest2 branch, but there's always some uncertainty related to that.
42 2011-08-27T14:42:50 <xorAxAx> ThomasWaldmann: i am quite busy until wednesday when i will have a talk
43 2011-08-27T16:35:50 <CIA-23> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 778:338852297cfd 2.0/MoinMoin/ (5 files in 3 dirs): (log message trimmed)
44 2011-08-27T16:35:50 <CIA-23> add query_parser building method to storage, use index-based search in some scripts
45 2011-08-27T16:35:50 <CIA-23> moin maint_reduce_revisions and maint_set_meta now have a --query option that takes
46 2011-08-27T16:35:50 <CIA-23> a whoosh query
47 2011-08-27T16:35:50 <CIA-23> whoosh can not do regex yet, but you can use wildcards. also, you can search in
48 2011-08-27T16:35:50 <CIA-23> other fields than in name_exact (which is the default).
49 2011-08-27T16:35:51 <CIA-23> remove MoinMoin.storage.serialization.TermMatch - it is not used and we need
50 2011-08-27T16:57:45 <ThomasWaldmann> https://bitbucket.org/mchaput/whoosh/issue/189/regular-expression-term-support
51 2011-08-27T17:25:35 <CIA-23> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 777:21a6765b793d 2.0/MoinMoin/ (6 files in 6 dirs): (log message trimmed)
52 2011-08-27T17:25:35 <CIA-23> killed backend.history(), replace it by .search() and appropriate query/reverse/sortedby/limit params
53 2011-08-27T17:25:35 <CIA-23> killed the .history() tests, added a few tests for .search().
54 2011-08-27T17:25:35 <CIA-23> Note: whoosh has own tests, so we maybe do not need that many tests there.
55 2011-08-27T17:25:35 <CIA-23> global history view got a major speedup when the user uses a bookmark (because
56 2011-08-27T17:25:36 <CIA-23> we then can add a DateRange term to massively reduce the search results in
57 2011-08-27T17:25:37 <CIA-23> big wikis).
58 2011-08-27T17:27:01 *** pkumar
59 2011-08-27T17:29:49 <ThomasWaldmann> pkumar: good timing :D
60 2011-08-27T17:30:22 <ThomasWaldmann> i was just having an issue with testing when using whoosh index
61 2011-08-27T17:30:55 <pkumar> ThomasWaldmann : hi, please tell me what exactly?
62 2011-08-27T17:31:32 <ThomasWaldmann> http://pastebin.com/1uPcaSjL
63 2011-08-27T17:31:41 <pkumar> looking
64 2011-08-27T17:31:52 <ThomasWaldmann> the test worked before that change. the change should be correct, but the test fails then.
65 2011-08-27T17:32:45 *** Marchael
66 2011-08-27T17:32:50 <ThomasWaldmann> py.test -k template MoinMoin/items/_tests/test_Item.py
67 2011-08-27T17:33:18 <ThomasWaldmann> hi Marchael
68 2011-08-27T17:33:33 <Marchael> hi ThomasWaldmann
69 2011-08-27T17:34:45 * ThomasWaldmann does whooshy stuff :)
70 2011-08-27T17:34:53 <Marchael> heh :)
71 2011-08-27T17:35:57 <Marchael> hm, if wi-fi won't disconnect me whole night I'll try to work on issues
72 2011-08-27T17:36:31 <ThomasWaldmann> great :)
73 2011-08-27T17:36:52 * Marchael moved to new flat and wi-fi here even worster than on previous
74 2011-08-27T17:37:09 <ThomasWaldmann> uhoh
75 2011-08-27T17:38:26 <ThomasWaldmann> btw, py.test 2 leaves those __pycache__ all over the place
76 2011-08-27T17:39:16 <pkumar> ThomasWaldmann : hmm.. I'll pull pull the repo and see what has changed and fix the test accordingly
77 2011-08-27T17:40:25 <ThomasWaldmann> thanks!
78 2011-08-27T17:41:51 <pkumar> ThomasWaldmann : most welcome :)
79 2011-08-27T17:44:22 <Marchael> ThomasWaldmann: hm, I read your comments in last commits related with history, history using navigation(with whoosh?) as well as search, so may be history and search could share on code for navigating?
80 2011-08-27T17:46:43 <Marchael> *share one
81 2011-08-27T17:47:18 <ThomasWaldmann> if the code is general enough, it can be likely shared very much. but that needs some planning.
82 2011-08-27T17:47:27 <ThomasWaldmann> #31 looks easy and quick.
83 2011-08-27T17:48:26 <Marchael> ok
84 2011-08-27T17:50:50 <ThomasWaldmann> pkumar: ignore the issue from above, i have found the problem
85 2011-08-27T17:51:29 <ThomasWaldmann> it is because when constructing Term(CONTENTTYPE, contenttype), that exactly is used "as is"
86 2011-08-27T17:52:00 <ThomasWaldmann> and it looks like we only put pieces of contenttype into index, but not the whole thing
87 2011-08-27T17:53:08 <pkumar> hmm.. in the new one we put pieces right?
88 2011-08-27T17:53:15 <pkumar> ThomasWaldmann : ^
89 2011-08-27T17:53:17 <ThomasWaldmann> so it searches for "text/x.moin.wiki;charset=utf-8", but we had only indexed "text", "x.moin.wiki" ...
90 2011-08-27T17:53:36 <pkumar> yeah, right
91 2011-08-27T17:54:48 <pkumar> ThomasWaldmann : so may be we can change accordingly there right?
92 2011-08-27T17:59:14 <pkumar> brb
93 2011-08-27T18:03:56 <ThomasWaldmann> yes
94 2011-08-27T18:04:36 <Marchael> ThomasWaldmann: I pulled from your repo, but doesn't see commits to moin-2.0
95 2011-08-27T18:04:42 <Marchael> only to pytest2
96 2011-08-27T18:05:46 <Marchael> last commit 767:e00c0eeb6e55
97 2011-08-27T18:11:25 <ThomasWaldmann> Marchael: yes, i am currently working on that branch. waiting for xorAxAx to review that before merging it into one branch.
98 2011-08-27T18:12:41 <Marchael> m, ok. But your last commit https://bitbucket.org/thomaswaldmann/moin-2.0/changeset/338852297cfd and I don't see it after pulling
99 2011-08-27T18:13:13 <ThomasWaldmann> if you have a clean workdir and you want to look at stuff in the other branch, you do: hg up -C pytest2
100 2011-08-27T18:15:12 <Marchael> ok, so I should that branch for now?
101 2011-08-27T18:20:09 <ThomasWaldmann> like you want
102 2011-08-27T18:21:28 <Marchael> ok
103 2011-08-27T18:23:35 <CIA-23> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 779:815c46100e2c 2.0/MoinMoin/ (3 files in 3 dirs): whooshify get_templates, adapt MimeType analyzer so it yields also a full and normalized contenttype
104 2011-08-27T18:29:52 <ThomasWaldmann> pkumar: # Need to modify and add more stuffs
105 2011-08-27T18:30:05 <ThomasWaldmann> (from conftest.py)
106 2011-08-27T18:31:24 <pkumar> ThomasWaldmann : had there in the beginning for test cleanup and other stuffs.
107 2011-08-27T18:31:37 <pkumar> seems like missed to remove it
108 2011-08-27T18:32:11 <pkumar> sorry for that
109 2011-08-27T18:33:05 <ThomasWaldmann> key_list = test_item.keys()
110 2011-08-27T18:33:05 <ThomasWaldmann> if not 'uuid' in key_list:
111 2011-08-27T18:33:27 <ThomasWaldmann> is there some reason why you don't do if 'uuid' not in test_item:
112 2011-08-27T18:33:40 <ThomasWaldmann> pkumar:
113 2011-08-27T18:34:29 <pkumar> just to check there if uuid is there in key_list
114 2011-08-27T18:35:23 <pkumar> will do the other way
115 2011-08-27T18:45:15 * ThomasWaldmann whooshifies get_index
116 2011-08-27T18:51:31 <CIA-23> Reimar Bauer <rb.proj AT googlemail DOT com> * d5daf53230ad r759 pytest2/MoinMoin/ (templates/content.html apps/frontend/views.py): frontend.views: show_content reintroduced. Same as show_item, but we only show the content.
117 2011-08-27T18:51:31 <CIA-23> Reimar Bauer <rb.proj AT googlemail DOT com> * ab4083ea79ed r760 pytest2/MoinMoin/apps/frontend/views.py: frontend.views: renamed show_content to content_item
118 2011-08-27T18:51:32 <CIA-23> Reimar Bauer <rb.proj AT googlemail DOT com> * c9381c5ce219 r761 pytest2/MoinMoin/apps/frontend/views.py: frontend.views.content_item: simplified
119 2011-08-27T18:51:32 <CIA-23> Reimar Bauer <rb.proj AT googlemail DOT com> * 6d0ab44672d7 r762 pytest2/MoinMoin/templates/content.html: content template: used same div container as for show template
120 2011-08-27T18:51:32 <CIA-23> Thomas Waldmann <tw AT waldmann-edv DOT de> * 6097284a3cdc r763 pytest2/ (7 files in 5 dirs):
121 2011-08-27T18:51:32 <CIA-23> remove load_xml/save_xml support at wiki startup, use moin maint_xml script
122 2011-08-27T18:51:33 <CIA-23> updated wikiconfig.py
123 2011-08-27T18:51:33 <CIA-23> updated docs with instructions about how to load example items
124 2011-08-27T18:51:34 <CIA-23> updated docs about 1.9 to 2.0 upgrading
125 2011-08-27T18:51:34 <CIA-23> Thomas Waldmann <tw AT waldmann-edv DOT de> * bb3ea5043a4f r764 pytest2/MoinMoin/app.py: remove load/save xml timer calls
126 2011-08-27T18:51:35 <CIA-23> pkumar <contactprashantat@gmail.com> * 185f64deed0f r765 pytest2/ (7 files in 5 dirs): merged to default
127 2011-08-27T18:51:35 <CIA-23> pkumar <contactprashantat@gmail.com> * 3bfe393013e9 r766 pytest2/MoinMoin/ (templates/content.html apps/frontend/views.py): merged with default - had got two extra heads one from pytest2 and other from default
128 2011-08-27T18:51:56 <CIA-23> pkumar <contactprashantat@gmail.com> * de75a93b21fe r767 pytest2/MoinMoin/conftest.py: cleanup of conftest
129 2011-08-27T18:58:36 <ThomasWaldmann> Marchael: btw: https://bitbucket.org/mchaput/whoosh/issue/189/regular-expression-term-support
130 2011-08-27T18:59:10 <ThomasWaldmann> pkumar: ?
131 2011-08-27T18:59:53 <ThomasWaldmann> i hope you did not do what your commit comment says
132 2011-08-27T19:00:41 <pkumar> which commit statement?
133 2011-08-27T19:00:53 * Marchael looks
134 2011-08-27T19:01:35 <pkumar> ah, cleanup conftest?
135 2011-08-27T19:02:02 <ThomasWaldmann> "merged to default"
136 2011-08-27T19:03:34 <pkumar> when I pulled from main repo, I had got two extra heads, one from pytest2 and other from default
137 2011-08-27T19:04:36 <ThomasWaldmann> "to x" usually designates x as being the target
138 2011-08-27T19:05:01 <ThomasWaldmann> what you did in that changeset was to merge "from default branch into pytest2 branch"
139 2011-08-27T19:05:08 *** Marchael
140 2011-08-27T19:05:33 <ThomasWaldmann> so, the changeset seems ok, but the comment sucks.
141 2011-08-27T19:06:26 <pkumar> yeah, should have been merged with default right?
142 2011-08-27T19:06:40 * ThomasWaldmann usually just says "merged <theotherrepo>"
143 2011-08-27T19:07:08 <ThomasWaldmann> because your own one as target is usually clear
144 2011-08-27T19:07:31 <pkumar> yeah, this way is good will use the same
145 2011-08-27T19:07:55 <ThomasWaldmann> with branches it gets a bit more complicated but I hope we can get rid of one soon
146 2011-08-27T19:10:33 <pkumar> every time some one pulls will get two heads from pytest2 and default, so yeah its a bit complicated. have to take care of both branches at a time
147 2011-08-27T19:10:53 <pkumar> in the repo too
148 2011-08-27T19:13:51 <CIA-23> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 780:f5e0f85e66ce 2.0/MoinMoin/items/__init__.py: whooshify get_index()
149 2011-08-27T19:14:41 *** Marchael
150 2011-08-27T19:17:38 <ThomasWaldmann> waldi: do you have time? that include converter would need the same fix as my recent changesets
151 2011-08-27T20:00:46 *** Marchael
152 2011-08-27T20:28:55 *** greg_f
153 2011-08-27T20:38:43 *** pkumar
154 2011-08-27T21:29:47 *** LingLing
155 2011-08-27T21:34:06 <CIA-23> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 781:33bfaf10d752 2.0/MoinMoin/converter/__init__.py: better error message for conversion exceptions, including item name and revno, fixes #52
156 2011-08-27T22:13:02 <CIA-23> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 782:5c60754f8d1a 2.0/MoinMoin/apps/frontend/views.py: save memory by not including content in history list. Fixes #42
157 2011-08-27T22:13:32 <ThomasWaldmann> hi LingLing
158 2011-08-27T22:17:18 <LingLing> hi ThomasWaldmann
159 2011-08-27T22:30:17 <CIA-23> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 783:66c5f8bdfb2b 2.0/MoinMoin/items/ (__init__.py _tests/test_Item.py): remove count_items (unused, uses deprecated code)
160 2011-08-27T23:25:21 <dreimark> re
161 2011-08-27T23:26:52 <dreimark> ThomasWaldmann: hmm, if we compute it we need to freeze the state of the request somehow otherwise on e.g. history the result changes during pagination
