MoinMoin: MoinMoinChat/Logs/moin-dev/2011-08-25

   1 2011-08-25T06:47:43  *** Marchael has joined #moin-dev
   2 2011-08-25T06:49:30  <Marchael> moin
   3 2011-08-25T07:41:29  <dreimark> moin
   4 2011-08-25T11:15:30  *** greg_f has joined #moin-dev
   5 2011-08-25T12:11:32  <ThomasWaldmann> moin
   6 2011-08-25T13:37:59  *** pkumar has joined #moin-dev
   7 2011-08-25T14:11:47  *** greg_f has quit IRC
   8 2011-08-25T14:13:15  *** greg_f has joined #moin-dev
   9 2011-08-25T14:16:53  *** greg_f has quit IRC
  10 2011-08-25T14:16:53  *** greg_f has joined #moin-dev
  11 2011-08-25T14:17:07  *** greg_f has joined #moin-dev
  12 2011-08-25T14:32:59  *** greg_f has quit IRC
  13 2011-08-25T14:33:01  *** greg_f has joined #moin-dev
  14 2011-08-25T15:01:04  *** pkumar has quit IRC
  15 2011-08-25T15:34:29  *** mkerrin has joined #moin-dev
  16 2011-08-25T15:43:32  *** sinha has joined #moin-dev
  17 2011-08-25T16:04:52  *** MattMaker has quit IRC
  18 2011-08-25T16:09:15  *** MattMaker has joined #moin-dev
  19 2011-08-25T16:57:19  *** pkumar has joined #moin-dev
  20 2011-08-25T17:11:27  *** brunomartin has joined #moin-dev
  21 2011-08-25T17:45:36  <dreimark> bbl
  22 2011-08-25T18:07:15  *** Marchael has quit IRC
  23 2011-08-25T18:28:46  *** mkerrin has quit IRC
  24 2011-08-25T18:58:10  *** Marchael has joined #moin-dev
  25 2011-08-25T19:01:09  *** Marchael has quit IRC
  26 2011-08-25T19:01:16  *** Marchael has joined #moin-dev
  27 2011-08-25T19:41:34  *** Marchael has quit IRC
  28 2011-08-25T19:45:34  *** pkumar has quit IRC
  29 2011-08-25T19:46:36  *** greg_f has quit IRC
  30 2011-08-25T20:36:11  *** Marchael has joined #moin-dev
  31 2011-08-25T22:13:16  <ThomasWaldmann> re
  32 2011-08-25T22:31:47  <ThomasWaldmann> sinha: soon there are some global history changesets :)
  33 2011-08-25T22:32:33  <ThomasWaldmann> i did them in pytest2 branch of main repo, because i had to change tests, too
  34 2011-08-25T22:32:55  <dreimark> re
  35 2011-08-25T22:36:39  <sinha> ThomasWaldmann: yeah, seen them
  36 2011-08-25T22:36:51  <ThomasWaldmann> i didn't push them yet
  37 2011-08-25T22:38:36  <sinha> i have seen that bookmark thing change in history
  38 2011-08-25T22:38:48  <sinha> okay, waiting for your push
  39 2011-08-25T23:16:24  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 770:a4ec2c6f0bb7 2.0/MoinMoin/ (8 files in 7 dirs): (log message trimmed)
  40 2011-08-25T23:16:24  <CIA-114> history: do not yield Revision objects, but directly result documents from whoosh
  41 2011-08-25T23:16:24  <CIA-114> we have all that global and local history view (and also the atom feed) needs
  42 2011-08-25T23:16:24  <CIA-114> in the whoosh index. the whoosh documents yielded are dicts with all stored fields.
  43 2011-08-25T23:16:24  <CIA-114> by just using that, we do not need to access the backend storage any more for
  44 2011-08-25T23:16:25  <CIA-114> displaying history (which was one of the reasons for the slow global history
  45 2011-08-25T23:16:26  <CIA-114> for wikis with many revisions).
  46 2011-08-25T23:16:26  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 771:e5b51d4304c8 2.0/MoinMoin/templates/global_history.html: global history: render the bookmark in same way as the day headers
  47 2011-08-25T23:16:33  <ThomasWaldmann> sinha: ^^
  48 2011-08-25T23:24:12  <sinha> ThomasWaldmann: i am not seeing change in my repo, i just pulled again
  49 2011-08-25T23:24:28  <ThomasWaldmann> do you have changes in your workdir?
  50 2011-08-25T23:24:35  <dreimark> sinha: it is in the pytest2 branch
  51 2011-08-25T23:24:42  <dreimark> hg update pytest2
  52 2011-08-25T23:24:53  <dreimark> and if you want to go back hg update default
  53 2011-08-25T23:25:04  <sinha> okay, let me check
  54 2011-08-25T23:26:42  <dreimark> ThomasWaldmann: i get an error
  55 2011-08-25T23:27:09  <dreimark> http://paste.pocoo.org/show/464556/
  56 2011-08-25T23:28:19  * dreimark tries a fresh wiki
  57 2011-08-25T23:28:31  * sinha too
  58 2011-08-25T23:28:48  <ThomasWaldmann> performance stuff gets interesting with some thousand revisions
  59 2011-08-25T23:31:43  <ThomasWaldmann> btw, i didn't change that revno links stuff on global history
  60 2011-08-25T23:31:47  <ThomasWaldmann> can we discuss that now?
  61 2011-08-25T23:33:33  <ThomasWaldmann> https://bitbucket-assetroot.s3.amazonaws.com/sinha/moin2/20110820/5/moin2-history-suggestions.png that stuff
  62 2011-08-25T23:34:48  <ThomasWaldmann> you need to rebuils the index, schema changed
  63 2011-08-25T23:34:58  <sinha> ThomasWaldmann: yes, please tell me what other changes you want there
  64 2011-08-25T23:36:12  <ThomasWaldmann> see that image
  65 2011-08-25T23:36:31  <ThomasWaldmann> just wanted to check whether something is holding us back from doing that
  66 2011-08-25T23:37:22  <ThomasWaldmann> we could even do something better
  67 2011-08-25T23:37:59  <ThomasWaldmann> as we need to compute those "person x did changes 23-42" ranges, we could also use this for diff rev1=23&rev2=42
  68 2011-08-25T23:37:59  <sinha> ThomasWaldmann: which right column there you are talking about ? (for those revision number links)
  69 2011-08-25T23:38:25  <ThomasWaldmann> because one usually does not care how often someone saved in beetween, rather the total change is interesting
  70 2011-08-25T23:38:53  <ThomasWaldmann> the arrows point there
  71 2011-08-25T23:39:42  <sinha> left is the one beside item name
  72 2011-08-25T23:40:04  <ThomasWaldmann> left is the one with the red rectangle
  73 2011-08-25T23:40:11  <ThomasWaldmann> right is the one right of that
  74 2011-08-25T23:40:19  <sinha> okay
  75 2011-08-25T23:40:38  <sinha> so in that right one its like tx[4-7], so there will be link on 4 and 7
  76 2011-08-25T23:41:13  <ThomasWaldmann> read what i just said
  77 2011-08-25T23:41:29  <ThomasWaldmann> (23:36) < ThomasWal> as we need to compute those "person x did changes 23-42" ranges, we could also use this for diff rev1=23&rev2=42
  78 2011-08-25T23:41:45  <ThomasWaldmann> or, in that case, the diff link for diff between 4 and 7
  79 2011-08-25T23:43:04  <ThomasWaldmann> and if we want to be mathematically correct, we could even display that as[7-4]
  80 2011-08-25T23:43:04  <sinha> okay, got your point, and what to do in case of tw[4-7, 9-11], diff between 4 and 11 ?
  81 2011-08-25T23:43:32  <ThomasWaldmann> no, 2 diffs. one 4-7, another 9-11
  82 2011-08-25T23:43:40  <sinha> for that just has to display them in reverse order
  83 2011-08-25T23:43:48  <sinha> okay
  84 2011-08-25T23:44:34  <ThomasWaldmann> that'll be a great advance comparing to 1.9
  85 2011-08-25T23:44:45  <sinha> and for [4-7, 9, 11-13] ? i) diff between 4-7, ii) diff between 9 and 7? iii)diff between 11-13
  86 2011-08-25T23:45:28  <ThomasWaldmann> you always compute the diff for a whole run belonging to same person
  87 2011-08-25T23:45:51  <ThomasWaldmann> so if person only changed by saving rev 4, you compute diff 3 -> 4
  88 2011-08-25T23:46:12  <ThomasWaldmann> if person saved 4, 5, 6, you compute 3 -> 6
  89 2011-08-25T23:46:28  <ThomasWaldmann> so base rev is always one below the first edit
  90 2011-08-25T23:48:51  <sinha> okay so finally for [4-7, 9-11] i will show diff between 3->7 and 8->11 (base rev one less than first edit) ?
  91 2011-08-25T23:49:14  <ThomasWaldmann> (be careful of course if it is first rev, rev 0, then there is none before that)
  92 2011-08-25T23:50:05  <ThomasWaldmann> would be [11-9] [7-4]
  93 2011-08-25T23:51:30  <sinha> okay
  94 2011-08-25T23:54:37  <ThomasWaldmann> (if newer stuff is at top and older at bottom, newer stuff also show at left, older at right)
  95 2011-08-25T23:55:44  <ThomasWaldmann> for the x-y we display, i guess we have to decide: do we show the range of revisions save by person X, or do we display what diff we compute