1 2011-08-24T00:23:40 *** brunomartin
2 2011-08-24T00:26:29 *** sinha
3 2011-08-24T00:27:15 *** brunomartin
4 2011-08-24T04:00:29 *** Marchael
5 2011-08-24T04:15:17 *** Marchael
6 2011-08-24T04:21:33 *** Marchael
7 2011-08-24T04:27:48 *** Marchael
8 2011-08-24T05:22:55 *** Marchael
9 2011-08-24T05:29:13 <Marchael> moin
10 2011-08-24T06:53:55 *** Marchael
11 2011-08-24T06:58:29 *** Marchael
12 2011-08-24T08:03:48 *** pkumar
13 2011-08-24T08:59:03 <dreimark> moin
14 2011-08-24T09:48:01 <ThomasWaldmann> moin
15 2011-08-24T10:06:54 *** mkerrin
16 2011-08-24T10:12:45 * ThomasWaldmann thinks that global history could be 10-100x faster soon
17 2011-08-24T10:14:57 <Marchael> ThomasWaldmann: hm, how? I guess, it uses whoosh now.
18 2011-08-24T10:15:13 <Marchael> also, please check my project on google code https://code.google.com/p/moin2-whoosh/
19 2011-08-24T10:15:36 <ThomasWaldmann> one can make things lots faster by not doing stupid things :D
20 2011-08-24T10:15:57 <Marchael> ah, then may be I could check out
21 2011-08-24T10:16:55 <ThomasWaldmann> in case of history it first called whoosh to get history data from index (fast), but then it made Item/Revision object from that and yielded them
22 2011-08-24T10:17:34 <Marchael> but whole item isn't needed?
23 2011-08-24T10:17:43 <ThomasWaldmann> and in frontend code, it touched misc attributes of those objects, so it had to load them all from the backend
24 2011-08-24T10:18:11 <ThomasWaldmann> i am currently modifying the code to ONLY work with the index
25 2011-08-24T10:21:32 <ThomasWaldmann> btw, tonight i used index build on a medium sized wiki, MultiWriter worked nicely with multiple cores
26 2011-08-24T10:22:57 <Marchael> ThomasWaldmann: I have several commits after you merged my repo and I want continue working on moin at all. but what should I do with that commits? Merge latest repo and add them?
27 2011-08-24T10:23:17 <Marchael> s/that/theese/
28 2011-08-24T10:23:58 <ThomasWaldmann> in general, if there are changesets in main repo that you do not have, you can merge them into yours from time to time
29 2011-08-24T10:24:10 <ThomasWaldmann> and I'll do same for your repo
30 2011-08-24T10:24:34 <Marchael> hm, I tried merge but there are some conflicts with sinha's stuff
31 2011-08-24T10:25:04 <ThomasWaldmann> if you can't resolve them easily, then let me merge first
32 2011-08-24T10:25:07 <Marchael> so what better way, resolve conflicts or add manually add commits to fresh repo?
33 2011-08-24T10:25:19 <Marchael> s/add//
34 2011-08-24T10:25:51 <ThomasWaldmann> a fresh repo doesn't help, we'll have to merge sooner or later anyway
35 2011-08-24T10:26:45 <ThomasWaldmann> but i am wondering a bit that you get conflicts with changesets from main repo - you didn't change that much after we merged your stuff into there
36 2011-08-24T10:27:14 <Marchael> some conflicts coming from views.py
37 2011-08-24T10:28:38 *** pkumar
38 2011-08-24T10:28:53 <ThomasWaldmann> in general it is important that you have some merge tool / merge procedure you fully understand
39 2011-08-24T10:29:58 <ThomasWaldmann> i personally dislike merge tools (like vim or gui stuff) jumping at me when I run hg merge, so i rather have conflict markers in the source and resolve them manually.
40 2011-08-24T10:31:36 <Marchael> ThomasWaldmann: also, after pulling from your repo I see "pytest2" branch, is it ok?
41 2011-08-24T10:33:19 <ThomasWaldmann> yes. just make sure you are working on the right branch.
42 2011-08-24T10:40:38 * ThomasWaldmann tries to merge marchael's stuff
43 2011-08-24T10:41:02 <Marchael> ok, thx!
44 2011-08-24T10:42:55 <ThomasWaldmann> only one minor conflict in tests wikiconfig
45 2011-08-24T10:44:58 <ThomasWaldmann> ok, merged. running some tests now....
46 2011-08-24T11:04:12 *** greg_f
47 2011-08-24T11:24:18 <ThomasWaldmann> Marchael: did you run the tests recently?
48 2011-08-24T11:25:16 <Marchael> test_sourcecode and other tests that I written
49 2011-08-24T11:27:08 <ThomasWaldmann> exactly those show errors for me
50 2011-08-24T11:27:31 <Marchael> hm, I found errors in test_indexing.py
51 2011-08-24T11:31:56 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 761:2151ef2c8425 2.0/MoinMoin/ (_tests/wikiconfig.py storage/_tests/test_indexing.py): Added tests for checking runtime indexing
52 2011-08-24T11:31:57 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 762:25e07ced506f 2.0/MoinMoin/apps/frontend/views.py: backrefs using whoosh now Fixes #23.
53 2011-08-24T11:31:58 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 763:f06e9d502d6c 2.0/ (7 files in 4 dirs): merged
54 2011-08-24T11:31:58 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 764:3a042c4b99ee 2.0/ (6 files in 6 dirs): merged
55 2011-08-24T11:32:01 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 765:6c07d901c6b4 2.0/MoinMoin/ (3 files in 3 dirs): Fixing removing indexes from test dir, some changes in WhooshIndex API Fixes #34.
56 2011-08-24T11:32:02 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 766:788eb43bf3b7 2.0/ (6 files in 4 dirs): add api and user docs
57 2011-08-24T11:32:03 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 767:e00c0eeb6e55 2.0/ (11 files in 9 dirs): merged whoosh search repo
58 2011-08-24T11:33:16 <ThomasWaldmann> btw those 763:f06e9d502d6c and 764:3a042c4b99ee merges are a bit strange
59 2011-08-24T11:34:26 <ThomasWaldmann> usually one only needs to merge directly after pulling stuff from a different repo
60 2011-08-24T11:35:36 <ThomasWaldmann> (if that created an additional head)
61 2011-08-24T11:42:37 <Marchael> ok, thx
62 2011-08-24T11:42:43 <Marchael> I'll merge now
63 2011-08-24T12:10:57 <Marchael> ThomasWaldmann: should I create branch pytest2 in my repo?
64 2011-08-24T12:11:32 <Marchael> but seems like I should
65 2011-08-24T12:11:34 <Marchael> :)
66 2011-08-24T12:11:34 <xorAxAx> Marchael: ?
67 2011-08-24T12:12:11 <Marchael> xorAxAx: I merged with ThomasWaldmann's repo and now have 2 branches
68 2011-08-24T12:12:33 <xorAxAx> you mean two heads? or two branches?
69 2011-08-24T12:12:40 <xorAxAx> two branches are fine
70 2011-08-24T12:13:30 <Marchael> xorAxAx: http://paste.pocoo.org/show/463559/
71 2011-08-24T12:13:48 <xorAxAx> yeah, one head per branch is expected
72 2011-08-24T12:17:33 <Marchael> ThomasWaldmann: ok, I merged with your repo https://bitbucket.org/marchael/moin-2.0/changesets
73 2011-08-24T12:17:55 <Marchael> now need to solve small test_indexing issue
74 2011-08-24T12:33:38 <ThomasWaldmann> 2011-08-24 12:29:31,444 INFO MoinMoin.util.clock:40 timer total(0): 4163.94ms
75 2011-08-24T12:33:48 <ThomasWaldmann> down from 70s :)
76 2011-08-24T12:34:30 <ThomasWaldmann> still a bit much, though
77 2011-08-24T12:35:19 <ThomasWaldmann> xorAxAx: tell me when you have finished reviewing pkumars stuff
78 2011-08-24T12:35:38 <xorAxAx> will do
79 2011-08-24T12:37:31 <ThomasWaldmann> dreimark: btw, later we have to think about paging. currently it is slow because it always computes everything and then displays a subset of it.
80 2011-08-24T12:38:06 <Marchael> ThomasWaldmann: do you mean paging in history?
81 2011-08-24T12:38:13 <ThomasWaldmann> yes
82 2011-08-24T12:38:27 <ThomasWaldmann> but likely same problem elsewhere, too
83 2011-08-24T12:38:44 <Marchael> hm, I almost implemented that stuff, but problem comes form SearchForm
84 2011-08-24T12:38:59 <Marchael> that stuff requires submit, not url_for()
85 2011-08-24T12:39:11 <Marchael> or just missing something
86 2011-08-24T12:39:17 <Marchael> *I just
87 2011-08-24T12:39:28 <ThomasWaldmann> what stuff?
88 2011-08-24T12:39:42 <Marchael> SearchForm
89 2011-08-24T12:40:09 <Marchael> I added /+search to views.py, but without submit it just str
90 2011-08-24T12:40:10 <ThomasWaldmann> i don't understand what you mean, it is working
91 2011-08-24T12:41:04 <Marchael> yes, it's. I mean that I need submit form to be able to take values
92 2011-08-24T12:41:47 <Marchael> If I try pass that to url_for like "url_for(item, .., search_form)", I'll take str
93 2011-08-24T12:42:04 <ThomasWaldmann> maybe start by defining what exactly the problem is
94 2011-08-24T12:42:41 <Marchael> Problem: I'm need to pass SearchForm when user click on nabigation arrow
95 2011-08-24T12:42:48 <Marchael> *navigation
96 2011-08-24T12:42:59 <Marchael> not submit button
97 2011-08-24T12:43:33 <ThomasWaldmann> in case you are working on paging for search again: i don't think we need that at all. or if we need it, it has very low priority.
98 2011-08-24T12:44:07 <ThomasWaldmann> because you don't want to manually look through hundreds of search results anyway
99 2011-08-24T12:44:10 <Marchael> ThomasWaldmann: without that stuff user can see only 25 results, or whatever defined by wiki admin
100 2011-08-24T12:44:27 <ThomasWaldmann> yes, that's ok
101 2011-08-24T12:44:28 <Marchael> I mean 25 first results
102 2011-08-24T12:45:05 <ThomasWaldmann> if the user does not find what he looked for in the best 25 results, then he needs to refine his search
103 2011-08-24T12:46:08 <Marchael> ok
104 2011-08-24T12:46:39 <ThomasWaldmann> that's much quicker than finding your stuff on page 10, result #249 by manually paging forward 10 times
105 2011-08-24T12:47:17 <ThomasWaldmann> btw, if you search some more stuff to work on: your bb issue tracker has some more ideas
106 2011-08-24T12:52:23 <ThomasWaldmann> Marchael: btw it looks like we should track issues only in one tracker. so maybe move all open issues to the main tracker.
107 2011-08-24T12:53:29 <Marchael> hm, how can I do it? manually reopen them?
108 2011-08-24T12:53:36 <ThomasWaldmann> that bb "issues" service is just stupid. it has no information about to which repo a "fixes #42" commit comment belongs to.
109 2011-08-24T12:54:03 <ThomasWaldmann> so it just closes #42 everywhere such a changeset comment is seen. :|
110 2011-08-24T12:55:19 <ThomasWaldmann> i reported that in bb project issue tracker and suggested a working solution, but they didn't sound like this could get fixed anytime soon.
111 2011-08-24T12:56:02 <ThomasWaldmann> Marchael: only move the stuff that is still open
112 2011-08-24T12:56:10 <Marchael> ok
113 2011-08-24T12:56:11 <Marchael> brb
114 2011-08-24T12:58:47 <ThomasWaldmann> Marchael: and maybe switch off that issues service in your repo, see https://bitbucket.org/marchael/moin-2.0/issue/3/dicts-are-bad-for-sorting#comment-618196
115 2011-08-24T13:02:04 <ThomasWaldmann> Marchael: #31 looks simple and nice to have
116 2011-08-24T13:02:48 <Marchael> ok, let me take some food.
117 2011-08-24T13:30:01 *** Marchael1
118 2011-08-24T13:30:17 *** Marchael
119 2011-08-24T13:55:50 *** Marchael1
120 2011-08-24T13:55:54 *** Marchael
121 2011-08-24T14:01:38 *** aa_
122 2011-08-24T14:01:44 *** aa_
123 2011-08-24T14:05:48 <ThomasWaldmann> dreimark: xorAxAx: meeting tomorrow at 18:00 local time?
124 2011-08-24T14:06:05 <xorAxAx> too late
125 2011-08-24T14:06:34 <xorAxAx> 17:00 would be ok
126 2011-08-24T14:07:15 <ThomasWaldmann> dreimark: xorAxAx: meeting tomorrow at 17:00 local time?
127 2011-08-24T14:07:20 <xorAxAx> yes!
128 2011-08-24T14:07:24 <ThomasWaldmann> :)
129 2011-08-24T14:16:35 <Marchael> bbl
130 2011-08-24T14:16:54 *** Marchael
131 2011-08-24T14:26:41 <ThomasWaldmann> waldi: if you have time, you could also have a look at the pytest2 stuff (see main repo branch), please
132 2011-08-24T14:27:06 <waldi> okay
133 2011-08-24T14:27:12 <ThomasWaldmann> waldi: and if you like, also attend our meeting tommorrow
134 2011-08-24T16:14:44 *** pkumar
135 2011-08-24T17:42:47 <pkumar> ThomasWaldmann, xorAxAx : hi, please have a look at http://codereview.appspot.com/4919046/diff2/1:8001/docs/devel/mointests.rst. a little messed up due to changing names of files mointests > tests, sorry for that. use patch set 1 and patch set 4 to compare
136 2011-08-24T17:48:25 <ThomasWaldmann> pkumar: you did not really read it
137 2011-08-24T17:52:20 <pkumar> ThomasWaldmann : please tell me if I'm missing something, I've removed all the basic setup stuffs, added minor changes, rephrasing may be a little modifiable?
138 2011-08-24T17:52:32 <ThomasWaldmann> you did not read it
139 2011-08-24T17:54:48 <pkumar> ThomasWaldmann : are you referring to your comments? am I supposed to keep the initial setup stuffs, I gave a link there
140 2011-08-24T17:55:06 <ThomasWaldmann> i am referring to the text you write
141 2011-08-24T17:57:58 <pkumar> ThomasWaldmann : you are looking a patch set 4 right?
142 2011-08-24T17:59:57 <ThomasWaldmann> review done
143 2011-08-24T18:01:32 *** Marchael
144 2011-08-24T18:01:46 <pkumar> ThomasWaldmann: ah, lots of typo
145 2011-08-24T18:01:53 <pkumar> typos*
146 2011-08-24T18:02:02 <pkumar> I really need to work on that
147 2011-08-24T18:02:17 <pkumar> ThomasWaldmann : thanks
148 2011-08-24T18:03:18 <ThomasWaldmann> always read slowly whatever you have written (docs, code, ...)
149 2011-08-24T18:03:51 <pkumar> ok, will do that from now on
150 2011-08-24T18:04:02 <ThomasWaldmann> while reading it slowly, you will notice typos and all sorts of errors usually.
151 2011-08-24T18:04:52 <ThomasWaldmann> if it is a code diff, additionally think "is that really what I want / can this be done easier / did i change something accidentally / ...?"
152 2011-08-24T18:05:55 <pkumar> ok,
153 2011-08-24T18:06:25 <pkumar> brb
154 2011-08-24T18:08:08 * ThomasWaldmann debugs some localtime / utc issue
155 2011-08-24T18:22:12 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 768:9375b8a6a188 2.0/MoinMoin/apps/frontend/views.py: fix crash when user bookmark is None
156 2011-08-24T18:22:12 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> pytest2 * 769:813802d5072a 2.0/MoinMoin/search/indexing.py: we always use UTC internally (fix MTIME in index)
157 2011-08-24T18:22:46 <ThomasWaldmann> Marchael: https://bitbucket.org/thomaswaldmann/moin-2.0/changeset/813802d5072a always keep that rule in mind :)
158 2011-08-24T18:24:00 <Marchael> ok
159 2011-08-24T18:24:04 <ThomasWaldmann> internally always UTC and adjust to user's localtime before it leaves moin (== when rendering the template)
160 2011-08-24T18:25:11 <ThomasWaldmann> similar as for internally always unicode / encode to utf-8 when it leaves moin / decode from utf-8 (if needed) when it enters moin
161 2011-08-24T18:42:59 *** mkerrin
162 2011-08-24T19:15:36 *** pkumar
163 2011-08-24T19:56:09 *** greg_f
164 2011-08-24T20:20:56 *** Marchael
165 2011-08-24T20:22:18 *** Marchael
166 2011-08-24T20:32:26 <dreimark> re
167 2011-08-24T20:34:48 <dreimark> ThomasWaldmann: xorAxAx 17:00 local time sounds good
168 2011-08-24T21:23:56 <ThomasWaldmann> ok
169 2011-08-24T21:50:34 *** Marchael
170 2011-08-24T22:51:17 *** brunomartin
171
