1 2011-08-18T01:10:29 *** raignarok
2 2011-08-18T04:24:20 *** Marchael
3 2011-08-18T05:23:47 *** Marchael
4 2011-08-18T05:43:22 *** Marchael
5 2011-08-18T06:14:07 *** Marchael
6 2011-08-18T06:14:25 <Marchael> moin
7 2011-08-18T07:53:05 <ThomasWaldmann> moin
8 2011-08-18T08:13:47 *** pkumar
9 2011-08-18T08:28:07 <ronny> moin
10 2011-08-18T08:28:13 <ronny> pkumar: sup
11 2011-08-18T08:28:31 <pkumar> ronny : hey
12 2011-08-18T08:48:32 <CIA-114> Akash Sinha <akash2607@gmail.com> * e665d70b0278 r382 default/MoinMoin/ (4 files in 4 dirs): index page view modified (elements re-arranged on the page)
13 2011-08-18T08:50:17 <dreimark> moin
14 2011-08-18T08:50:59 <dreimark> sinha: please merge main, because Marchael repo is merged in
15 2011-08-18T08:51:23 <sinha> okay
16 2011-08-18T08:53:34 <dreimark> sinha: btw. you could have made more than one changeset for the last one.
17 2011-08-18T08:53:58 <dreimark> e.g. fixing http status is different from rearrange
18 2011-08-18T08:54:28 <sinha> dreimark: yes, it was but i though it as a small change
19 2011-08-18T08:55:29 <dreimark> you should resist for doing small changes in such a commit. it is sometimes hard to resist
20 2011-08-18T08:55:40 <dreimark> but cleaner changesets are important
21 2011-08-18T08:56:16 <sinha> dreimark:yes, i will be careful for next time
22 2011-08-18T08:57:06 <sinha> dreimark: after pulling there are certain files which do not exist in my repo (deleted by me), i guess i should leave it as deleted
23 2011-08-18T08:57:27 <sinha> e.g. index2.html global_index.html
24 2011-08-18T08:57:29 <dreimark> yes
25 2011-08-18T08:58:02 <dreimark> that is all the stuff you have removed in yours, marchael has used main
26 2011-08-18T08:58:22 <dreimark> so we untile don't have merged yours in they still alive
27 2011-08-18T08:58:50 <dreimark> but in yours they must remain removed
28 2011-08-18T09:01:41 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * a3c707668331 r392 default/MoinMoin/search/ (3 files in 2 dirs): Fix some name issues
29 2011-08-18T09:01:42 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * a1273e8734a3 r387 default/MoinMoin/search/indexing.py: Add opening\creating index files for Whoosh schema
30 2011-08-18T09:01:43 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * b0855eb191e1 r412 default/MoinMoin/script/maint/ (update_indexes.py build_indexes.py): Fix giant bug in update index script, add "--for" option for partly updating
31 2011-08-18T09:01:44 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * c41fdeb81880 r421 default/setup.py: fixing before merge
32 2011-08-18T09:01:46 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * d9d8e978323a r442 default/MoinMoin/search/ (analyzers.py indexing.py):
33 2011-08-18T09:01:46 <CIA-114> Improvments in contenttype analyzer, fixes in schema
34 2011-08-18T09:01:46 <CIA-114> - contenttype analyzer doesn't crash moin with query cotenttype:text/
35 2011-08-18T09:01:46 <CIA-114> - added additional parameter 'multitoken_query' for improving search
36 2011-08-18T09:01:46 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * f720cf1e8969 r443 default/setup.py: fixing multiple heads
37 2011-08-18T09:01:48 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 07271d66ea5b r390 default/MoinMoin/search/ (4 files in 2 dirs): Fixing wrong value names, add finally done with tests for indexing schemas
38 2011-08-18T09:01:49 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 65c2c01aa266 r459 default/MoinMoin/ (search/revision_converter.py storage/backends/indexing.py): Fixing issue with double content indexing, cosmetic changes in debug output
39 2011-08-18T09:01:51 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 215d7a8f5b3e r463 default/MoinMoin/ (3 files in 3 dirs):
40 2011-08-18T09:01:51 <CIA-114> Fixes #6.
41 2011-08-18T09:01:51 <CIA-114> Fixing https://bitbucket.org/marchael/moin-2.0/issue/6/unpretty-search-results-rendering
42 2011-08-18T09:01:53 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * ab4ac448d5d8 r464 default/ (15 files in 12 dirs): merged
43 2011-08-18T09:01:53 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 2dc35ebbc43a r467 default/MoinMoin/util/kvstore.py: removed MoinMoin.util.kvstore - not used any more
44 2011-08-18T09:01:54 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 598b1731069b r471 default/MoinMoin/ (config/default.py app.py storage/backends/indexing.py): remove cfg.index_rebuild and related code (not needed any more)
45 2011-08-18T09:01:54 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * ea001bcb5f90 r462 default/MoinMoin/ (script/maint/index.py storage/backends/indexing.py):
46 2011-08-18T09:01:54 <CIA-114> Fixed issue with runtime indexation https://bitbucket.org/marchael/moin-2.0/issue/9/content-entered-via-wiki-ui-is-not-indexed
47 2011-08-18T09:01:55 <CIA-114> Fixes issue with content indexing in building\updating script
48 2011-08-18T09:01:55 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 79d80bcd1d32 r465 default/MoinMoin/script/maint/index.py:
49 2011-08-18T09:01:55 <CIA-114> Fixes issue https://bitbucket.org/marchael/moin-2.0/issue/11/moin-index-script-wrong-unhelpful-texts
50 2011-08-18T09:01:56 <CIA-114> Fixes #11.
51 2011-08-18T09:01:56 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * e2d16dadf565 r482 default/MoinMoin/search/analyzers.py: merged whoosh repo
52 2011-08-18T09:01:57 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 1ed44f76458c r455 default/ (4 files in 2 dirs): merged
53 2011-08-18T09:01:58 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * e818c98d3790 r491 default/MoinMoin/util/interwiki.py: Merged
54 2011-08-18T09:02:11 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 8cc72401fc25 r470 default/ (9 files in 6 dirs): (log message trimmed)
55 2011-08-18T09:02:11 <CIA-114> indexing: remove sqlalchemy based indexing code (is done by whoosh now)
56 2011-08-18T09:02:11 <CIA-114> rename some methods from *_whoosh to * (as there are no others any more,
57 2011-08-18T09:02:11 <CIA-114> all indexing is based on whoosh now).
58 2011-08-18T09:02:11 <CIA-114> added some "XXX wrong" comments to indexing, where item and revision level
59 2011-08-18T09:02:11 <CIA-114> was confused.
60 2011-08-18T09:02:12 <CIA-114> cfg.index_uri was removed as well as index_uri Backend kwarg (both were only
61 2011-08-18T09:02:12 <CIA-114> Akash Sinha <akash2607@gmail.com> * 0268070335d1 r508 default/ (39 files in 20 dirs): branch merged with main repo
62 2011-08-18T09:02:15 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * e57259c40f74 r457 default/MoinMoin/themes/modernized/static/css/common.css: Using white backgroung for long search form
63 2011-08-18T09:02:17 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 14a9f545934d r452 default/MoinMoin/ (search/revision_converter.py storage/backends/indexing.py): Fix issue with content indexing, improve indexing perfomance for runtime and start up
64 2011-08-18T09:02:22 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * c14527438f0d r409 default/MoinMoin/script/maint/build_indexes.py:
65 2011-08-18T09:02:22 <CIA-114> Refactoring in build index script:
66 2011-08-18T09:02:22 <CIA-114> CHANGES:
67 2011-08-18T09:02:22 <CIA-114> Indexes build in index_dir_tmp(defined in local config)
68 2011-08-18T09:02:22 <CIA-114> Cleaning base indexes with --action clean
69 2011-08-18T09:02:23 <CIA-114> Moving indexes from index_dir_tmp location to index_dir_tmp(now working for all-revs and latest-revs)
70 2011-08-18T09:02:24 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 4dba3eece489 r406 default/MoinMoin/script/maint/update_indexes.py: Bugfixes in update_script.py
71 2011-08-18T09:02:24 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 21860894d4dd r396 default/MoinMoin/search/_tests/test_indexing.py: Rewrited some parts of test_indexing.py using new schemas
72 2011-08-18T09:02:25 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * beb99cd78481 r404 default/MoinMoin/script/ (maint/update_indexes.py __init__.py): Add draft for updating index
73 2011-08-18T09:02:26 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 459fda5f2079 r432 default/MoinMoin/ (4 files in 4 dirs): Add wikiname field support for runtime indexing and index script, now wiki admin can create wikis farm using one app.cfg.index_dir
74 2011-08-18T09:02:27 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * ea543ad2fb6c r445 default/MoinMoin/ (3 files in 2 dirs): temporarily remove acl fields from the schema due to pickle issues
75 2011-08-18T09:02:28 <Marchael> omg
76 2011-08-18T09:02:29 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 1de89cc3a6bd r389 default/MoinMoin/ (9 files in 8 dirs): Merged with Thomas Waldmann's repo
77 2011-08-18T09:02:30 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 3c1d17e77d1c r458 default/MoinMoin/storage/backends/indexing.py: Return removed line for converting backend revision to whoosh index
78 2011-08-18T09:02:31 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * cbf97d9067f3 r415 default/ (33 files in 15 dirs): Merging with main repo
79 2011-08-18T09:02:32 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 0f9a97f74a8d r472 default/MoinMoin/storage/backends/indexing.py: Fixed https://bitbucket.org/marchael/moin-2.0/issue/3/dicts-are-bad-for-sorting Fixes #3.
80 2011-08-18T09:02:34 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * dc04953b1ee8 r419 default/ (5 files in 5 dirs): (log message trimmed)
81 2011-08-18T09:02:34 <CIA-114> Testing and working:
82 2011-08-18T09:02:34 <CIA-114> MoinMoin.storage.backend.indexing
83 2011-08-18T09:02:34 <CIA-114> Add revisions to whoosh indexes
84 2011-08-18T09:02:34 <CIA-114> Remove revisions from whoosh indexes
85 2011-08-18T09:02:35 <CIA-114> Show history for given item or whole indexes
86 2011-08-18T09:02:35 <CIA-114> Show all items for given tag
87 2011-08-18T09:02:44 <Marchael> awesome
88 2011-08-18T09:02:47 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * d755f798fe66 r477 default/MoinMoin/ (8 files in 6 dirs):
89 2011-08-18T09:02:47 <CIA-114> fix some tests
90 2011-08-18T09:02:47 <CIA-114> make item name and contenttype constants unicode
91 2011-08-18T09:02:47 <CIA-114> give cfg kwarg to RouterBackend
92 2011-08-18T09:02:47 <CIA-114> delay tokenizer creation to test method call time, so that we're within a test
93 2011-08-18T09:02:47 <CIA-114> request environment and app is available.
94 2011-08-18T09:02:47 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * a64b59e52616 r483 default/MoinMoin/search/indexing.py: reduce duplication in indexing schemas
95 2011-08-18T09:02:51 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 91b72ea6039e r484 default/MoinMoin/search/indexing.py: indexing: misc src cosmetics
96 2011-08-18T09:02:52 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 2340dd0ee580 r502 default/MoinMoin/ (4 files in 3 dirs):
97 2011-08-18T09:02:52 <CIA-114> move backend_to_index function to MoinMoin.search.indexing module
98 2011-08-18T09:02:52 <CIA-114> as the schema is defined there, it makes sense that the conversion function
99 2011-08-18T09:02:52 <CIA-114> is also there.
100 2011-08-18T09:02:53 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * f7c91c4b601a r434 default/ (3 files in 3 dirs): Fixed issue with interwikiname
101 2011-08-18T09:02:54 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * e6fb11f35a84 r395 default/MoinMoin/search/indexing.py: Added wikiname/userid/address/hostname/ to whoosh schema
102 2011-08-18T09:02:55 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * ae63dc7cf921 r416 default/setup.py: Update whoosh to 1.8.4
103 2011-08-18T09:02:57 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 6111e4d47e04 r423 default/ (12 files in 6 dirs): merged
104 2011-08-18T09:02:58 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 8589afef0e6c r487 default/MoinMoin/storage/backends/indexing.py: indexing storage mixin: misc src cosmetics
105 2011-08-18T09:02:59 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * daedbbcaa1cb r426 default/MoinMoin/script/maint/index.py: Removed break import line
106 2011-08-18T09:03:00 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 2e8c562f7524 r481 default/MoinMoin/storage/backends/indexing.py: indexing: clarify ItemIndex.update_item/remove_item, remove wrong code
107 2011-08-18T09:03:01 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 6b4f5e5850a3 r506 default/MoinMoin/storage/backends/indexing.py: fixed issue with destroying items. Revisions don't deleted from all revisions index Fixes #33.
108 2011-08-18T09:03:02 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * f69fa81b34b6 r401 default/MoinMoin/script/maint/build_indexes.py: Saving revision number into indexes
109 2011-08-18T09:03:03 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 28858876a5f1 r405 default/MoinMoin/script/maint/update_indexes.py: Some fixes in update script with debug output
110 2011-08-18T09:03:05 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 46cda7e03229 r410 default/ (3 files in 3 dirs): Minor fixes at build indexes script, add documentation for admin
111 2011-08-18T09:03:06 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * fd28cf720d2c r433 default/wikiconfig.py: Added index_dir_tmp and wiki_name to default config
112 2011-08-18T09:03:07 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * d49d08bb5f50 r479 default/MoinMoin/ (3 files in 3 dirs): merged whoosh repo
113 2011-08-18T09:03:08 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * e362e7abfda6 r480 default/MoinMoin/search/ (analyzers.py _tests/test_indexing.py): merged whoosh repo
114 2011-08-18T09:03:09 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 72278e056ec4 r469 default/MoinMoin/storage/backends/indexing.py: indexing: removed/commented unused code
115 2011-08-18T09:03:11 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 3872b8328dd5 r384 default/MoinMoin/ (16 files in 8 dirs): Sync with Thomas Waldmann repo
116 2011-08-18T09:03:12 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 3ec32fa2fe01 r413 default/ (3 files in 2 dirs): Merge update index and build index script to one, improvements in cli syntax
117 2011-08-18T09:03:14 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 7d79c684123d r476 default/MoinMoin/search/analyzers.py: Fixed search in acl, fixed docstings Fixes #13.
118 2011-08-18T09:03:15 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 406966afa113 r495 default/MoinMoin/apps/frontend/views.py: Using name_exact schema field for wildcard searching Fixes #26.
119 2011-08-18T09:03:18 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 0fd6527bd6aa r444 default/ (3 files in 3 dirs): merged
120 2011-08-18T09:03:19 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * b8ebdf2c816e r505 default/docs/ (admin/index.rst index.rst): Updated admin docs
121 2011-08-18T09:03:20 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 81744c1ebd2e r501 default/docs/admin/buildindexes.rst: remove outdated docs
122 2011-08-18T09:03:21 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 7d32ff657987 r391 default/ (MoinMoin/search/analyzers.py setup.py): Add whoosh to dependencies, remove useless comment
123 2011-08-18T09:03:23 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 0248b030a814 r489 default/MoinMoin/templates/search_results.html: Fixes translation issue Fixes #25.
124 2011-08-18T09:03:24 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 5c6ef2031235 r431 default/MoinMoin/ (5 files in 3 dirs): Update dosctrings for MoinMoin.search, add (c) in MoinMoin.storage.backends.indexing
125 2011-08-18T09:03:28 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * a9b78e0231c6 r460 default/MoinMoin/ (templates/search_results.html apps/frontend/views.py): Remove small search field at top right on search result template
126 2011-08-18T09:03:32 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 66981eb25822 r494 default/MoinMoin/ (3 files in 2 dirs): Added searching in non-current revisions Fixes #18.
127 2011-08-18T09:03:33 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * dccbd79260ce r499 default/MoinMoin/search/indexing.py: Added several dynamic fields Fixes #17.
128 2011-08-18T09:03:34 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 5d06ad313f7d r417 default/MoinMoin/ (4 files in 4 dirs): WhooshIndex object creation at start up, implemented some functions for working with indexes
129 2011-08-18T09:03:35 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 369af927b0a8 r439 default/MoinMoin/ (3 files in 2 dirs): Merged
130 2011-08-18T09:03:36 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * c9653e23e167 r437 default/ (3 files in 3 dirs): Fixed runtime and offline indexation, if interwiki was None, moin crashed
131 2011-08-18T09:03:38 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 42f7af473347 r454 default/MoinMoin/script/maint/index.py: Fix issue with indexing users in backend
132 2011-08-18T09:03:39 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 05657b355ce4 r449 default/MoinMoin/search/ (_tests/test_analyzers.py analyzers.py indexing.py): Fix ACL indexing issue for preloaded items with acl field (thanks brunomartin and Thomas Waldmann)
133 2011-08-18T09:03:40 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 779eee3e39d8 r394 default/MoinMoin/search/ (_tests/test_indexing.py indexing.py): Removed "metadata" field from whoosh schema
134 2011-08-18T09:03:41 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 0f29cbb71223 r507 default/MoinMoin/search/indexing.py: Using scoring name and name_exact fields to improve search results Fixes #30.
135 2011-08-18T09:03:43 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * f5dd44e2f1fe r440 default/ (6 files in 4 dirs):
136 2011-08-18T09:03:43 <CIA-114> - Update whoosh to 2.0
137 2011-08-18T09:03:43 <CIA-114> - Search result template
138 2011-08-18T09:03:43 <CIA-114> - Search in headings
139 2011-08-18T09:03:43 <CIA-114> - Show search statistics
140 2011-08-18T09:03:43 <CIA-114> - Highlighting headings of found documents
141 2011-08-18T09:03:44 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 8b39c8a2140e r446 default/setup.py: return whoosh back
142 2011-08-18T09:03:45 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * dfa902b0bafa r435 default/MoinMoin/script/maint/index.py: Using multi writer for building indexes script
143 2011-08-18T09:03:46 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * c552332cb53e r425 default/MoinMoin/ (3 files in 3 dirs): Content indexing for runtime working and scripts, fix bug in move_index()
144 2011-08-18T09:03:47 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 76887b57c7d2 r427 default/MoinMoin/storage/backends/indexing.py: add a quick and dirty hack for data indexing to stop it crashing, needs more work
145 2011-08-18T09:03:48 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * fdd1b2dec689 r461 default/MoinMoin/ (3 files in 3 dirs): Improved index --for ... --action show output, syntax change in css class name
146 2011-08-18T09:03:50 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 3f7914a961e0 r399 default/MoinMoin/ (3 files in 3 dirs): Remove useless code, change whoosh schema fieldname for better MoinMoin backend compatibility.
147 2011-08-18T09:03:51 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 33249607fd48 r500 default/MoinMoin/script/maint/index.py: Refactoing crap in building script Fixes #32.
148 2011-08-18T09:03:52 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * bc7b8834eff5 r385 default/MoinMoin/search/ (_tests/test_analyzers.py analyzers.py): Fixed item_name_tokenizer() and test for it.
149 2011-08-18T09:03:53 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * ef401198ebf9 r478 default/MoinMoin/storage/ (8 files in 3 dirs): storage: remove history() from storage backends api, only RouterBackend+IndexingMixIn now implements history()
150 2011-08-18T09:03:54 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * fd2248ba64c8 r400 default/MoinMoin/script/maint/build_indexes.py: Fix some typos in build_indexes.py
151 2011-08-18T09:03:55 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 999e33243b26 r386 default/MoinMoin/search/ (_tests/test_analyzers.py analyzers.py): Add Whoosh MultiFilter() to item_name_analyzer, fix test.
152 2011-08-18T09:03:57 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 29cc4f25eec8 r424 default/ (setup.py MoinMoin/converter/moinwiki_out.py): Ignoring href splitting for IRI in moinwiki_out
153 2011-08-18T09:03:58 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 0b400626bc93 r486 default/MoinMoin/search/revision_converter.py: rev converter: misc src cosmetics
154 2011-08-18T09:03:59 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * a46852031865 r393 default/MoinMoin/search/_tests/test_indexing.py: Changes in test algorithm in test_indexing.py
155 2011-08-18T09:04:01 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 750781283141 r408 default/MoinMoin/script/maint/build_indexes.py:
156 2011-08-18T09:04:01 <CIA-114> Replace multisegment writer by normal writer because
157 2011-08-18T09:04:01 <CIA-114> it has bug with writing to indexes. I'll add it again
158 2011-08-18T09:04:01 <CIA-114> when new whoosh version will released.
159 2011-08-18T09:04:03 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 0ab852761ff2 r456 default/MoinMoin/apps/frontend/views.py: Using Multifield parser for searching in revisions name and content
160 2011-08-18T09:04:04 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 4b052f23b24a r403 default/MoinMoin/script/maint/build_indexes.py: Change date format
161 2011-08-18T09:04:06 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * a2aee9baecd3 r497 default/whoosh200-highlight-mode-fix.patch: removed whoosh-highlighting patch due issue was fixed in 2.1.0
162 2011-08-18T09:04:07 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 7ad7f9472ae0 r414 default/ (3 files in 3 dirs):
163 2011-08-18T09:04:07 <CIA-114> Fixing some names for better usability,
164 2011-08-18T09:04:07 <CIA-114> changes in move functions(not it remove old indexes before add new),
165 2011-08-18T09:04:07 <CIA-114> fix bug with copy empty indexes.
166 2011-08-18T09:04:07 <CIA-114> TODO: whoosh searcher can't find items moving to trash, so it continuely try to add trashed revisions to index.
167 2011-08-18T09:04:08 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * d5c124222533 r397 default/MoinMoin/ (5 files in 4 dirs): Building indexes, minor fixing in schemas, add forgotten imports
168 2011-08-18T09:04:09 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * b54d70026e30 r450 default/MoinMoin/ (9 files in 4 dirs): merged
169 2011-08-18T09:04:10 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 748523da8db6 r436 default/MoinMoin/ (26 files in 3 dirs): Merged
170 2011-08-18T09:04:12 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 79a8c0c5a820 r428 default/setup.py: Strict checking for whoosh version
171 2011-08-18T09:04:13 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 28093a47a961 r383 default/MoinMoin/search/ (4 files in 2 dirs): Whoosh schemas for items and revisions, analyzer for "item name" field and tokenizers for "acl" and "mimetype" fields of whoosh's schema. Write simple tests for acl and mimetype tokenizers.
172 2011-08-18T09:04:17 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 293e27b399b7 r453 default/MoinMoin/ (3 files in 3 dirs): Showing highlighted results on search results page
173 2011-08-18T09:04:18 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 78a2962bf192 r492 default/ (3 files in 3 dirs): Fixed displaying results for multiple wikis(wiki farm) Fixes #15.
174 2011-08-18T09:04:19 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 256c6e0ae8bf r468 default/MoinMoin/storage/backends/indexing.py: removed all_tags / tagged_items, replaced by *_whoosh
175 2011-08-18T09:04:20 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 6f6a29825a1e r473 default/MoinMoin/ (3 files in 3 dirs): Fixed test_sourcecode failures
176 2011-08-18T09:04:21 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * fb400cd3391f r441 default/MoinMoin/ (3 files in 3 dirs): Add long search input field on search results page, remove highlighing search results due bugs, some fixes in css
177 2011-08-18T09:04:22 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 951c8edf9776 r466 default/MoinMoin/storage/backends/indexing.py:
178 2011-08-18T09:04:22 <CIA-114> remove ItemIndex.history (was replaced by history_whoosh)
179 2011-08-18T09:04:24 <CIA-114> remove all kvstore usage (was intended to store user-defined metadata,
180 2011-08-18T09:04:24 <CIA-114> but we'll use whoosh dynamic fields for that soon)
181 2011-08-18T09:04:24 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 09d1d55dc8e6 r438 default/setup.py: Update whoosh to 2.0
182 2011-08-18T09:04:25 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 53420a55b1bc r388 default/MoinMoin/search/ (analyzers.py indexing.py):
183 2011-08-18T09:04:25 <CIA-114> Fix some places in open_index(), add draft for indexing schema test
184 2011-08-18T09:04:25 <CIA-114> (great thanks to Thomas Waldmann!)
185 2011-08-18T09:04:26 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * d91abc361954 r418 default/MoinMoin/ (script/maint/index.py app.py storage/backends/indexing.py): Implemented add revision to whoosh indexes, some minor fixes in names
186 2011-08-18T09:04:27 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 98cbec45cffb r398 default/MoinMoin/ (3 files in 3 dirs): Fiexes in flask-script for rebuilding indexes. Python2.6 compatibility. Make changes in schema for better integration with Moin.
187 2011-08-18T09:04:29 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 748054b11929 r422 default/ (31 files in 9 dirs): Fixing multiple heads
188 2011-08-18T09:04:29 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * d71800ea7e4c r504 default/ (4 files in 3 dirs): merged
189 2011-08-18T09:04:30 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 430223bb9701 r430 default/whoosh184-fix.patch: Add missing ^M in whoosh patch
190 2011-08-18T09:04:32 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 0173477e11bc r474 default/MoinMoin/search/analyzers.py: Update docstring
191 2011-08-18T09:04:33 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * b646d3764eb6 r407 default/MoinMoin/script/maint/build_indexes.py: Add building path option to rebuild indexes script
192 2011-08-18T09:04:34 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 6119699cec2f r485 default/MoinMoin/search/analyzers.py: analyzers: misc src cosmetics
193 2011-08-18T09:04:35 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 6c407c842f4c r475 default/MoinMoin/search/_tests/test_indexing.py: Updated query string for acl tokenizer
194 2011-08-18T09:04:36 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 348f20628eb8 r488 default/MoinMoin/search/_tests/test_analyzers.py: Fixed acl analyzer test Fixes #21.
195 2011-08-18T09:06:54 <Marchael> sinha: seems like you have found new irc trolling way.
196 2011-08-18T09:06:59 <Marchael> :)
197 2011-08-18T09:07:13 <sinha> Marchael: yeah :)
198 2011-08-18T09:19:27 <ThomasWaldmann> pkumar: keep us update about the impact on tests
199 2011-08-18T09:21:50 <Marchael> ThomasWaldmann: please, review http://codereview.appspot.com/4896049/ ps 4.
200 2011-08-18T09:24:25 <dreimark> bbl
201 2011-08-18T09:25:14 <pkumar> ThomasWaldmann : ok, working on it. though with whoosh cleanup is working as it is supposed to i.e with up storage only. will update once I confirm some stuffs
202 2011-08-18T09:25:32 <dreimark> sinha: don't miss to run pip install upgrade -e .
203 2011-08-18T09:25:50 * sinha running pip upgrade
204 2011-08-18T09:27:42 <dreimark> sinha: typo pip install --upgrade -e .
205 2011-08-18T09:28:16 <sinha> dreimark: yes i am running the correct command, btw thanks for helping
206 2011-08-18T09:29:21 <sinha> dreimark: i just have to do 2 more changes (one little one other need some thinking) and after that i will write those docs
207 2011-08-18T09:31:04 <dreimark> sinha: ok
208 2011-08-18T09:31:56 <dreimark> make html in that docs dir creates locally the html of the docs
209 2011-08-18T09:33:51 <sinha> okay
210 2011-08-18T09:39:43 <ThomasWaldmann> Marchael: review done
211 2011-08-18T09:40:06 * Marchael looks
212 2011-08-18T10:07:14 <Marchael> ThomasWaldmann: i removed rev_no from revision, but error RevisionNumberMismatchError: still occurs
213 2011-08-18T10:12:43 <ThomasWaldmann> if it "still" occurs, the problem is not new :P
214 2011-08-18T10:15:21 <Marchael> may wrong order?
215 2011-08-18T10:16:41 <Marchael> because if test_create_rev() execited before test_create_item() then error is clear
216 2011-08-18T10:16:56 <Marchael> *executed
217 2011-08-18T10:17:14 <ThomasWaldmann> if your tests depend on order, they are wrong
218 2011-08-18T10:18:05 <ThomasWaldmann> and btw, if you use setup_method, that is executed before each test method
219 2011-08-18T10:18:19 <Marchael> ah
220 2011-08-18T10:18:23 <ThomasWaldmann> so if you do a rmtree there, you don't need it in teardown_method
221 2011-08-18T10:20:07 <Marchael> teardown executed after each method too?
222 2011-08-18T10:20:46 <ThomasWaldmann> teardown_method is, that's why it's called *_method
223 2011-08-18T10:36:38 <dreimark> sinha: i havw some something.tex files of "contenttype": "text/x-tex",
224 2011-08-18T10:36:59 <dreimark> which are shown by selecting filter images (only)
225 2011-08-18T10:38:33 <dreimark> if we are on an item which has no subitems and you select all and e.g. delete the browser hangs
226 2011-08-18T10:38:58 <dreimark> or everthing is grayed
227 2011-08-18T10:40:33 <sinha> dreimark: it doesnt grays, first a semi-transparent back div appears and over that a popup box
228 2011-08-18T10:41:06 <sinha> that back div is for the purpose that one can not click on anything else, unless he closes the popup
229 2011-08-18T10:41:13 <dreimark> ok, i don't get the popup currently
230 2011-08-18T10:41:18 <dreimark> i kill the testwiki
231 2011-08-18T10:42:08 <dreimark> hmm, no popup noq
232 2011-08-18T10:42:11 <dreimark> s/w/w
233 2011-08-18T10:42:26 <dreimark> s/q/w - my fingers are wrong today
234 2011-08-18T10:43:24 *** raignarok
235 2011-08-18T10:44:55 <dreimark> sinha: it fails on a new item without any subitems
236 2011-08-18T10:45:36 <dreimark> e.g. http://localhost:8080/+index/not_existing
237 2011-08-18T10:45:43 <sinha> dreimark: yes, i am looking into it
238 2011-08-18T10:46:49 <dreimark> thx
239 2011-08-18T10:49:04 <sinha> dreimark: i got the problem, actually when i created that popup block, i wasn't embedding it when the index is None (because no delete/download etc could be done), but after that i added new item thing but forgot to move that block outside of the 'if' case, thus its not getting embedded for empty index case
240 2011-08-18T10:51:23 <CIA-114> Akash Sinha <akash2607@gmail.com> * 814bcdcd9651 r509 default/MoinMoin/templates/index.html: popup block html moved outside of index test condition
241 2011-08-18T10:51:43 <sinha> dreimark: it works now
242 2011-08-18T10:56:39 <ronny> ThomasWaldmann: https://tools.ietf.org/html/rfc5789 -> http patch verb
243 2011-08-18T10:58:21 *** greg_f
244 2011-08-18T11:00:30 *** pkumar
245 2011-08-18T11:03:00 <Marchael> http://test.moinmo.in/html gives me 500
246 2011-08-18T12:00:42 <dreimark> sinha: i have only one cancel button now in the upload file for Create item
247 2011-08-18T12:05:51 <dreimark> sinha: with dragging it works
248 2011-08-18T12:07:08 <dreimark> sinha: div size for translated i18n of e.g. Download to small
249 2011-08-18T12:08:06 <dreimark> this cancel thing was once only
250 2011-08-18T12:08:31 <dreimark> thanks for the X
251 2011-08-18T12:37:49 <dreimark> bbl
252 2011-08-18T12:50:41 <ThomasWaldmann> ronny: yes i know. not sure what we could practically use it for.
253 2011-08-18T12:51:17 <ThomasWaldmann> Marchael: you have a much more current moin2 locally :)
254 2011-08-18T12:52:32 *** pkumar
255 2011-08-18T12:57:24 <Marchael> oh, /me still fighting with setup\teardown
256 2011-08-18T13:01:25 <Marchael> I would like init some params after class creation and I tried setup_class, but seems like that stuff more sneaky than I think
257 2011-08-18T13:59:10 <Marchael> ThomasWaldmann: I add some working crap http://codereview.appspot.com/4896049 ps 5
258 2011-08-18T14:04:57 <Marchael> brb
259 2011-08-18T14:09:22 *** Marchael
260 2011-08-18T14:10:53 <pkumar> ThomasWaldmann , dreimark : http://codereview.appspot.com/4893049/diff/1/MoinMoin/conftest.py
261 2011-08-18T14:17:36 *** Marchael
262 2011-08-18T14:20:10 <pkumar> ThomasWaldmann : in the test test_backend while running test_middleware_acl and test_backend_router, test_destroy_revision() is creating some problem
263 2011-08-18T14:20:58 <pkumar> it shows IndexError: list index out of range on first item.commit() in the function
264 2011-08-18T14:21:53 <pkumar> but interestingly, if the smiley from itemname i.e :-( is removed, test passes without failure
265 2011-08-18T14:22:39 <pkumar> the error is raises in whoosh/analysis
266 2011-08-18T14:22:45 <pkumar> raised*
267 2011-08-18T14:24:15 <pkumar> there are 4 more tests in test_backends_router that are failing likely due to whoosh, I'm looking into them presently
268 2011-08-18T14:24:54 <pkumar> rest all tests are quite fine it seems
269 2011-08-18T14:43:36 <ThomasWaldmann> pkumar: that whoosh bug is known and fixed in whoosh trunk, but not in latest release
270 2011-08-18T14:43:50 <ThomasWaldmann> so just ignore that for now
271 2011-08-18T14:48:12 <pkumar> all right, also, in test_traversal in test_backends_router give StopIteration error in whoosh/compact. removal of u'' : self.root fixes it. seems like it has some issue wit empty values
272 2011-08-18T14:48:19 <pkumar> ThomasWaldmann : ^
273 2011-08-18T14:48:33 <pkumar> with*
274 2011-08-18T14:49:16 <ThomasWaldmann> if you want me to look at it, use CR
275 2011-08-18T14:50:03 <pkumar> ThomasWaldmann : please look at new clean up function http://codereview.appspot.com/4893049/diff/1/MoinMoin/conftest.py
276 2011-08-18T14:50:32 <pkumar> I'll just put the other function there
277 2011-08-18T14:51:14 <ThomasWaldmann> that code is better, but still not great
278 2011-08-18T14:51:49 <ThomasWaldmann> if you just read that code once, what comes to your mind?
279 2011-08-18T14:52:55 <pkumar> yeah, it doesn't look so sophisticated to me
280 2011-08-18T14:53:42 <ThomasWaldmann> what exactly?
281 2011-08-18T14:55:09 <ThomasWaldmann> hmm, there are even 2 issues
282 2011-08-18T14:55:33 <pkumar> ThomasWaldmann : which ones?
283 2011-08-18T14:55:42 <pkumar> please tell me
284 2011-08-18T14:56:01 <ThomasWaldmann> if you do
285 2011-08-18T14:56:05 <ThomasWaldmann> if foo:
286 2011-08-18T14:56:07 <ThomasWaldmann> a
287 2011-08-18T14:56:09 <ThomasWaldmann> b
288 2011-08-18T14:56:13 <ThomasWaldmann> else:
289 2011-08-18T14:56:15 <ThomasWaldmann> b
290 2011-08-18T14:56:23 <ThomasWaldmann> then you are doing it wrong
291 2011-08-18T14:56:45 <ThomasWaldmann> because b should not be within the if/else block
292 2011-08-18T14:58:22 <pkumar> ok, i think I got it, just a mom
293 2011-08-18T14:58:23 <ThomasWaldmann> and the 2nd issues is that you do not need to get .keys() first to use "in" operator, that should work directly on the item also
294 2011-08-18T14:59:07 <ThomasWaldmann> and also there should be some XXX at that place pointing out that this is a workaround and the this should get fixed elsewhere
295 2011-08-18T15:01:27 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4896049 ps 6. I see traceback when trying nuke_item() http://paste.pocoo.org/show/460236/
296 2011-08-18T15:04:50 <pkumar> ThomasWaldmann : hmm, if I'm not wrong about your second point, are you referring to use item.has_key()? it raises AccessError on change_metadata().
297 2011-08-18T15:06:23 <pkumar> or there should be no need of that check there, all items should have uuid genuinely ?
298 2011-08-18T15:07:15 *** sinha
299 2011-08-18T15:11:39 <pkumar> ThomasWaldmann : http://codereview.appspot.com/4911044/diff/1/MoinMoin/storage/_tests/test_backends_router.py line number 73. just commenting that fixes StopIteration error. not sure why.
300 2011-08-18T15:11:48 <pkumar> bbl
301 2011-08-18T15:12:15 *** pkumar
302 2011-08-18T15:14:19 *** MattMaker
303 2011-08-18T15:14:54 <ThomasWaldmann> Marchael: review done
304 2011-08-18T15:15:16 <Marchael> thx
305 2011-08-18T15:23:58 <dreimark> re
306 2011-08-18T15:26:07 <Marchael> ThomasWaldmann: could leave some comments about traceback?
307 2011-08-18T15:26:14 <Marchael> *could you
308 2011-08-18T15:31:42 <ThomasWaldmann> that's an acl issue
309 2011-08-18T15:32:10 <Marchael> yes, but I haven't any acl in that dict
310 2011-08-18T15:32:25 <Marchael> I rather remove user_id from there
311 2011-08-18T15:32:31 <ThomasWaldmann> default acl does not allow anyone to destroy contents
312 2011-08-18T15:32:41 <ThomasWaldmann> (of course)
313 2011-08-18T15:33:09 <Marchael> so i should grant rights to do it?
314 2011-08-18T15:33:25 <Marchael> hm, I already tried
315 2011-08-18T15:33:35 <Marchael> no, it's bad idead
316 2011-08-18T15:33:41 <Marchael> *idea
317 2011-08-18T15:44:22 <Marchael> ThomasWaldmann: may be change default user_id to admin?
318 2011-08-18T15:44:54 <Marchael> I mean user_id in dict
319 2011-08-18T15:59:02 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4896049/ ps 7, but I didn't find a way to solve acl issue
320 2011-08-18T16:27:16 <Marchael> bbl
321 2011-08-18T16:27:34 <dreimark> bbl
322 2011-08-18T16:27:47 *** Marchael
323 2011-08-18T16:31:33 *** raignarok
324 2011-08-18T16:33:31 *** raignarok
325 2011-08-18T16:33:39 <ThomasWaldmann> Marchael: well, as you are not testing acls, but indexing, maybe you could use a backend without ACLs / with lax acls
326 2011-08-18T16:33:53 <ThomasWaldmann> hm, gna
327 2011-08-18T16:36:22 *** pkumar
328 2011-08-18T17:33:06 *** pkumar
329 2011-08-18T17:51:37 *** Marchael
330 2011-08-18T17:54:58 <Marchael> re
331 2011-08-18T17:57:05 <ThomasWaldmann> (16:32) < ThomasWal> Marchael: well, as you are not testing acls, but indexing, maybe you could use a backend without ACLs / with lax acls
332 2011-08-18T17:57:39 <Marchael> hm, how can I use it?
333 2011-08-18T17:58:13 <ThomasWaldmann> well, see wikiconfig?
334 2011-08-18T17:59:04 <ThomasWaldmann> (tests can setup an app with special config)
335 2011-08-18T17:59:23 <ThomasWaldmann> but maybe this is stuff we should do after merging pkumar's stuff
336 2011-08-18T17:59:27 <Marchael> I see content_acl = None here
337 2011-08-18T17:59:38 <Marchael> or that should be another option?
338 2011-08-18T18:00:30 <ThomasWaldmann> maybe temporarily edit the tests wikiconfig.py and see if your test works then
339 2011-08-18T18:01:03 <ThomasWaldmann> if so, place a py.test.skip("...") in it for now, explaining what the problem is
340 2011-08-18T18:01:24 <Marchael> ok
341 2011-08-18T18:05:43 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 446:d9845a326f12 2.0/MoinMoin/storage/backends/__init__.py: create_simple_mapping() only returns one value (fix for fs19:)
342 2011-08-18T18:05:44 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 447:16bd4f3dbab8 2.0/MoinMoin/storage/backends/fs19.py: fix fs19 crash if a user has no subscribed pages
343 2011-08-18T18:05:45 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 448:3d3230f84e5f 2.0/docs/admin/ (configure.rst upgrade.rst): update docs: create_simple_mapping only returns 1 value
344 2011-08-18T18:07:00 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4896049/ ps 8
345 2011-08-18T18:07:36 <ThomasWaldmann> "destroy", not delete
346 2011-08-18T18:07:51 <ThomasWaldmann> delete could also mean moving it to trash
347 2011-08-18T18:08:53 <Marchael> ok
348 2011-08-18T18:15:12 *** brunomartin
349 2011-08-18T18:43:20 *** sinha
350 2011-08-18T18:47:24 <Marchael> re
351 2011-08-18T18:47:38 <Marchael> ThomasWaldmann: could you please make review?
352 2011-08-18T18:51:22 <dreimark> re
353 2011-08-18T18:51:30 <dreimark> sinha: i added 2 issues to your tracker
354 2011-08-18T19:02:51 <sinha> dreimark: yes i have seen them, but for the issue 2 "filter of image only shows other contenttypes", few days ago we had this discussion and you said that when a contenttype doesn't belong to any contenttype_group, then it will be shown there irrespective of the filter
355 2011-08-18T19:06:12 <dreimark> sinha: then this was a misunderstanding, there must be an other contenttype
356 2011-08-18T19:06:17 <dreimark> so that it can be shown there
357 2011-08-18T19:06:57 <dreimark> and be enabled or disable
358 2011-08-18T19:08:45 <sinha> but how to show the others i mean, we pass selected contenttype_groups to the flat_index function , in other we dont know what to pass, so if only "Others" is selected then i have to see which contenttype doesnt belong to any group
359 2011-08-18T19:08:55 <dreimark> i think i confused myself with "other item" diALOG
360 2011-08-18T19:10:13 <dreimark> sinha: it is a question of sets
361 2011-08-18T19:10:23 <dreimark> now you know all defined contenttypes
362 2011-08-18T19:10:37 <dreimark> and the undefined is Unknown
363 2011-08-18T19:11:34 *** raignarok
364 2011-08-18T19:11:49 *** MattMaker
365 2011-08-18T19:13:37 *** raignarok
366 2011-08-18T19:22:22 <sinha> dreimark: so you want me to add one more filter their in that filter box (as we already have 6 there including "other")
367 2011-08-18T19:22:55 <sinha> dreimark: i think best solution to this problem would be change the contenttype of file when they are actually being uploaded
368 2011-08-18T19:23:21 <sinha> because no matter how much test cases we put in this filter, we may not have full correctness
369 2011-08-18T19:24:11 <sinha> so if the contenttype of uploaded files is unkown, we change them to application/octet-stream or something
370 2011-08-18T19:28:15 *** greg_f
371 2011-08-18T19:49:25 *** pkumar
372 2011-08-18T19:59:19 <CIA-114> Akash Sinha <akash2607@gmail.com> * 373f2e992a06 r510 default/MoinMoin/apps/frontend/views.py: some lines of code removed(to get range list) from global history as similar function exists under util
373 2011-08-18T20:02:19 <pkumar> ThomasWaldmann : can you please tell me about index dir in _test_wiki. I'm not sure if it is fine but I get some files there after tests are run. shouldthey be cleaned after after eac test run?
374 2011-08-18T20:02:39 <pkumar> each*
375 2011-08-18T20:03:25 <Marchael> this directory contains whoosh index files
376 2011-08-18T20:06:36 <Marchael> when you runs test for backend this directory will be created automatically
377 2011-08-18T20:07:07 <pkumar> Marchael : hmm, talking in terms of tests, seems like a large number of such files effect the backend history.
378 2011-08-18T20:07:59 <pkumar> and that effect is not wanted there
379 2011-08-18T20:08:40 <Marchael> I guess you could safely clean this dir after tests are done
380 2011-08-18T20:09:27 <Marchael> acually, I do the same thing in test_indexing
381 2011-08-18T20:09:40 <Marchael> *actually
382 2011-08-18T20:09:52 *** raignarok
383 2011-08-18T20:10:13 <pkumar> Marchael : yeah, thats was I was thinking too, have implemented too temporarily. write a script to clean the dir at teardown for the test
384 2011-08-18T20:10:27 <Marchael> yep
385 2011-08-18T20:11:03 <pkumar> Marchael : k, thanks
386 2011-08-18T20:17:54 <Marchael> sinha: could you try to implement navigation widget using whoosh? This way have some advanteges, like: you now actually page number, you could know previous and next page numbers.
387 2011-08-18T20:19:06 <Marchael> I almost done this, but url_for is bad solution because SearchForm object passed to views.py like unicode obj.ect, thus I can't use this
388 2011-08-18T20:20:00 *** brunomartin
389 2011-08-18T20:21:48 <Marchael> actually, histrory using whoosh now, so I guess that won't be big problem
390 2011-08-18T20:24:14 <pkumar> seems like history don't keep record of different revisions of same item
391 2011-08-18T20:28:34 <Marchael> m?
392 2011-08-18T20:30:22 <pkumar> test in tests_backends_router fails due to above reason. line 13 and 14 show Index error http://paste.pocoo.org/show/460384/
393 2011-08-18T20:31:03 <pkumar> well at least with test it seems like that
394 2011-08-18T20:32:38 <Marchael> hm, you renaming only one revision
395 2011-08-18T20:32:57 <Marchael> so, others will stay as is
396 2011-08-18T20:35:44 <pkumar> ah, thats what it is. if I don't rename and just create another revision, I have that in history
397 2011-08-18T20:35:59 <Marchael> yep
398 2011-08-18T20:36:56 <pkumar> Marchael: thanks again, it works that way
399 2011-08-18T20:37:55 <Marchael> but I think that bug, because after renaming all revisions will keep old name
400 2011-08-18T20:39:22 <Marchael> ThomasWaldmann: should I fix that?
401 2011-08-18T20:39:48 <pkumar> Marchael : yeah, even renaming should have been there in the history. I think you should look into that
402 2011-08-18T20:41:09 <Marchael> the problem that when you renaming something, you renaming only last revision, but others in all revision index will stay.
403 2011-08-18T20:42:09 <Marchael> just need some changes in whoosh schema and history()
404 2011-08-18T20:42:37 <pkumar> Marchael : so currently I keep that test as it is. please tell me if you are planning to work on it after you talk ThomasWaldmann
405 2011-08-18T20:44:12 <Marchael> ok
406 2011-08-18T20:44:21 <pkumar> damn battery
407 2011-08-18T20:45:56 <pkumar> no, sorry damn electricity condition
408 2011-08-18T20:48:18 *** pkumar
409 2011-08-18T20:57:50 <Marchael> gn/bbl
410 2011-08-18T21:02:02 *** Marchael
411 2011-08-18T21:18:46 *** MattMaker
412 2011-08-18T21:28:13 *** raignarok
413 2011-08-18T21:33:28 <dreimark> sinha: no only in the list
414 2011-08-18T21:33:55 <dreimark> you must keep the contentype stored, this is very important
415 2011-08-18T21:34:36 <dreimark> but you can filter it by your filters into one for "yet not supported"
416 2011-08-18T21:35:10 <dreimark> the reason is that one who wants to download images don'T want to dowonload "yet not supported" items
417 2011-08-18T21:36:03 <dreimark> you know all supported contentypes
418 2011-08-18T21:36:11 <dreimark> just create one for not supported ones
419 2011-08-18T21:36:49 <dreimark> create this set dynamically so that it needs not a code change when we add a new content type
420 2011-08-18T21:39:46 <dreimark> sinha: please don't change its uploaded contenttype
421 2011-08-18T22:08:38 <sinha> dreimark: okay so i add one more list there as "Unknown types", when it will be selected i will show unknown ones, when it isn't they will be hidden
422 2011-08-18T22:19:31 <dreimark> sinha: yes, thats it
423 2011-08-18T22:19:57 <sinha> okay
424 2011-08-18T22:40:00 *** grad
425 2011-08-18T22:40:34 *** grad
426 2011-08-18T22:42:30 <sinha> dreimark: what should be the right label for that "unknown types" or just "unknown" ?
427 2011-08-18T22:45:57 <ThomasWaldmann> re
428 2011-08-18T22:54:44 <dreimark> sinha: for now Unknown
429 2011-08-18T22:54:53 <dreimark> i have no better name yet
430 2011-08-18T22:55:33 <dreimark> we also have to think over the "Other" label, if we can move that to a better name
431 2011-08-18T22:55:42 <dreimark> i would prefer to use that
432 2011-08-18T22:58:26 <CIA-114> Akash Sinha <akash2607@gmail.com> * 110dd32e5822 r511 default/MoinMoin/ (3 files in 3 dirs): small change in contenttype filter (now items with unknown mime types have a different filter, as earlier it was shown regardless of the filter selected)
433 2011-08-18T23:01:09 <sinha> dreimark: please verify that
434 2011-08-18T23:10:54 <dreimark> sinha: doing
435 2011-08-18T23:13:45 <dreimark> sinha: works, you can also use fixes #issue in your commit, because that fixes the issue tracking then
436 2011-08-18T23:14:24 <sinha> dreimark: okay, i wasn't aware about that
437 2011-08-18T23:16:36 <CIA-114> Akash Sinha <akash2607@gmail.com> * 28e3cc89530c r512 default/MoinMoin/themes/modernized/static/css/common.css: fixes issue 3 (increased size of div in actions)
438 2011-08-18T23:16:58 <dreimark> sinha: the # is important
439 2011-08-18T23:17:16 <dreimark> see commit message there http://hg.moinmo.in/moin/2.0/rev/0f29cbb71223
440 2011-08-18T23:18:07 <sinha> dreimark: thanks, i will follow that from now on
441 2011-08-18T23:30:38 <dreimark> sinha: http://paste.pocoo.org/show/460498/
442 2011-08-18T23:31:46 <sinha> dreimark: is that happening for english names ?
443 2011-08-18T23:31:48 <dreimark> this is likly a problem in moin-2 currently
444 2011-08-18T23:31:51 <dreimark> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/46/unifying-item-names-with-suffix
445 2011-08-18T23:32:13 <dreimark> and https://bitbucket.org/thomaswaldmann/moin-2.0/issue/47/limit-number-of-separators
446 2011-08-18T23:32:37 <dreimark> sinha: if we have fixed it there it will be fixed for you too
447 2011-08-18T23:32:59 <dreimark> it happens because one could create currently a subitem of Example//
448 2011-08-18T23:33:13 <dreimark> or Example//sdsdssd
449 2011-08-18T23:33:51 <dreimark> sinha: so nothing for you currently
450 2011-08-18T23:34:16 <sinha> :)
451 2011-08-18T23:37:37 <dreimark> sinha: you should close the issues in the tracker
452 2011-08-18T23:44:40 <dreimark> sinha: https://bitbucket.org/sinha/moin2/changeset/110dd32e5822#chg_MoinMoin/items/__init__.py_newline608 pep8
453 2011-08-18T23:44:46 <dreimark> blannks
454 2011-08-18T23:45:36 <dreimark> check also the comment in that section
455 2011-08-18T23:49:12 <sinha> dreimark: comment for blanks or for verbosity
456 2011-08-18T23:50:01 <dreimark> in the line are two blanks, where you should have one
457 2011-08-18T23:50:51 <dreimark> and line 614 the comment is now wrong, or?
458 2011-08-18T23:51:19 <sinha> yes comment needs to be changes
459 2011-08-18T23:51:22 <sinha> *changed
460 2011-08-18T23:52:19 <dreimark> I ve added a feature request to your tracker
461 2011-08-18T23:52:40 <sinha> yes that toggle thing, where could we have it ?
462 2011-08-18T23:52:59 <sinha> we have select all/unselect all now
463 2011-08-18T23:53:55 <sinha> OR we can use that select all as toggle button itself ?
464 2011-08-18T23:53:55 <dreimark> where is select all/unselect all ?
465 2011-08-18T23:54:04 <sinha> that beside the Action
466 2011-08-18T23:54:56 <dreimark> i am talking about "Filter by content type"
467 2011-08-18T23:55:09 <dreimark> e.g. if you want only images
468 2011-08-18T23:55:21 <dreimark> this is much clicking currently
469 2011-08-18T23:55:35 <dreimark> but it could be deselect images, toggle, filter
470 2011-08-18T23:56:45 <sinha> okay in that, yes now there are 7 such things, and select/unselect takes time
471 2011-08-18T23:56:49 <dreimark> i have not thought on the other in action yet
472 2011-08-18T23:58:02 <dreimark> In Action, I think it is better understandable if it is in the menu, e.g. Select all []
473 2011-08-18T23:58:59 <sinha> but in menu there are actions but select all is activity before proceeding to action, so i put it differently
474 2011-08-18T23:59:57 <dreimark> i understand that, it can be also separatly, it needs a lable
