1 2011-08-14T00:03:53 <Marchael> ThomasWaldmann: I added field foo=ID(stored=True) to schema without rebuilding.
2 2011-08-14T00:04:04 <Marchael> It isn't working
3 2011-08-14T00:04:31 <Marchael> but after rebuild, yes.
4 2011-08-14T00:05:59 <ThomasWaldmann> that's not a dynamic field. and rebuild is no problem, this is not configurable, but builtin.
5 2011-08-14T00:06:34 *** MattMaker
6 2011-08-14T00:06:45 <Marchael> hm, then what point of it?
7 2011-08-14T00:07:54 <ThomasWaldmann> the point is that it's dynamic
8 2011-08-14T00:08:19 <Marchael> o_0
9 2011-08-14T00:09:19 <ThomasWaldmann> so users can use any key as long as it matches the right glob
10 2011-08-14T00:09:25 <Marchael> how not dynamic field could be dinamic?
11 2011-08-14T00:09:53 <Marchael> I already paste my code with dynamic fields on cr
12 2011-08-14T00:14:57 <Marchael> hm, may be the reason in add_rev() in indexing.py
13 2011-08-14T00:15:13 <Marchael> because it looks only on defined fields
14 2011-08-14T00:15:35 <ThomasWaldmann> why don't you just do what I say?
15 2011-08-14T00:16:17 <Marchael> add another field to schema and try to search in that?
16 2011-08-14T00:16:49 <Marchael> I already did that, but didn't find anything
17 2011-08-14T00:17:35 <ThomasWaldmann> (23:56) < ThomasWal> revert that all and make a SIMPLE change to the builtin schema, as I said
18 2011-08-14T00:17:58 <ThomasWaldmann> (some dynamic fields using globs that make sense)
19 2011-08-14T00:18:01 <Marchael> ok
20 2011-08-14T00:18:25 <Marchael> but I need some sleep to make my mind clear
21 2011-08-14T00:18:36 <Marchael> will continue after sleep
22 2011-08-14T00:18:43 <ThomasWaldmann> ok, gn
23 2011-08-14T00:18:45 <Marchael> gn/bbl
24 2011-08-14T00:18:51 *** Marchael
25 2011-08-14T00:19:00 *** sinha
26 2011-08-14T00:37:28 *** MattMaker
27 2011-08-14T00:54:56 *** MattMaker
28 2011-08-14T06:52:46 *** Marchael
29 2011-08-14T06:53:32 <Marchael> moin
30 2011-08-14T07:57:14 *** MattMaker
31 2011-08-14T08:01:30 <Marchael> Seems like whoosh doesn't care about glob param
32 2011-08-14T08:02:00 <Marchael> so if someone tries to pass "glob=True" to writer.add_field() it'll failed
33 2011-08-14T08:02:29 <Marchael> I also found that bug in 1.8.3
34 2011-08-14T08:02:50 <Marchael> and seems for me that was unfixed since 1.8.3 to 2.1.0
35 2011-08-14T08:03:18 <Marchael> I added fix for that and it's working now
36 2011-08-14T08:03:54 <Marchael> and will report that soon
37 2011-08-14T08:04:15 <Marchael> but I still don't understand why I can't find stuff in that fields
38 2011-08-14T08:08:11 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/458090/
39 2011-08-14T08:32:42 <ThomasWaldmann> moin
40 2011-08-14T08:33:17 <ThomasWaldmann> if you'ld like a comment, show ALL the code you have written/modified
41 2011-08-14T08:37:46 *** raignarok
42 2011-08-14T08:46:32 <Marchael> https://bitbucket.org/mchaput/whoosh/issue/170/with-fix
43 2011-08-14T08:46:33 <Marchael> https://bitbucket.org/mchaput/whoosh/issue/171/search-doesnt-working-for-dynamic-fields
44 2011-08-14T08:46:36 <Marchael> ThomasWaldmann: ^^
45 2011-08-14T08:49:43 <ThomasWaldmann> 170 reads strange.
46 2011-08-14T08:50:40 <Marchael> mm?
47 2011-08-14T08:53:04 <ThomasWaldmann> read it
48 2011-08-14T08:54:04 <ThomasWaldmann> ... and see this [nothing?]
49 2011-08-14T08:54:34 <ThomasWaldmann> you also should end sentences with a dot.
50 2011-08-14T08:56:25 <ThomasWaldmann> 171 -> the schema does not have dynamic fields. so no point in trying to use them.
51 2011-08-14T08:59:14 <Marchael> no
52 2011-08-14T08:59:41 <Marchael> I applied fix from #170 and have no results
53 2011-08-14T09:00:11 <ThomasWaldmann> (08:54) < ThomasWal> 171 -> the schema does not have dynamic fields. so no point in trying to use them.
54 2011-08-14T09:00:29 <Marchael> do you see my paste?
55 2011-08-14T09:00:37 <Marchael> > [{'path': u'/a', 'test_id': u'alfa', 'title': u'First document'}, {'class_id': u'MyClass', 'path': u'/b', 'title': u'Second document'}
56 2011-08-14T09:00:47 <ThomasWaldmann> (08:54) < ThomasWal> 171 -> the schema does not have dynamic fields. so no point in trying to use them.
57 2011-08-14T09:01:42 <Marchael> ThomasWaldmann: I was add this fields earlier
58 2011-08-14T09:02:34 <Marchael> I point that in comment > # test_id was added earlier
59 2011-08-14T09:03:22 <Marchael> because if I tried to add this fields again I'll take a tracebacl
60 2011-08-14T09:03:29 <Marchael> *traceback
61 2011-08-14T09:04:36 *** Marchael
62 2011-08-14T09:04:50 <dreimark> ThomasWaldmann: <script src="{{ url_for('serve.files', name='mathjax', filename='MathJax.js') }}
63 2011-08-14T09:04:53 <dreimark> "> </script>
64 2011-08-14T09:05:33 <dreimark> can you add this to your mathjax whoever wants this
65 2011-08-14T09:06:26 *** Marchael
66 2011-08-14T09:06:49 <ThomasWaldmann> Marchael: you have to show full source or it won't work out
67 2011-08-14T09:06:53 <Marchael> http://paste.pocoo.org/show/458101/
68 2011-08-14T09:07:07 <Marchael> that's happening if I tried add already added field
69 2011-08-14T09:08:18 <ThomasWaldmann> am i talking chinese?
70 2011-08-14T09:08:40 <ThomasWaldmann> show the full source that reproduces the problem of 171
71 2011-08-14T09:08:52 <Marchael> ok
72 2011-08-14T09:08:56 <ThomasWaldmann> (and that works)
73 2011-08-14T09:09:12 <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> default * 320:90c9f951c2e7 2.0/ (MoinMoin/templates/base.html setup.py wikiconfig.py): mathjax removed because of its vast size, time needed to download/install/upgrade, fixes #43
74 2011-08-14T09:09:51 <ThomasWaldmann> moin dreimark
75 2011-08-14T09:09:59 <ThomasWaldmann> (09:03) < dreimark> can you add this to your mathjax whoever wants this
76 2011-08-14T09:10:10 <ThomasWaldmann> what exactly is "my mathjax"?
77 2011-08-14T09:11:28 <dreimark> ThomasWaldmann: #43 you describe what one has to do, one line is missing
78 2011-08-14T09:12:11 <dreimark> whoever wants to use mathjax ...
79 2011-08-14T09:13:11 <dreimark> hmm, i think i confused edit function with g+ or can one edit also on bb
80 2011-08-14T09:13:16 <Marchael> ThomasWaldmann: there is full version http://paste.pocoo.org/show/458102/
81 2011-08-14T09:18:08 <ThomasWaldmann> dreimark: bug updated. but: if you want mathjax to be usable by moin users, you better update the moin admin docs with a section about it,
82 2011-08-14T09:20:37 <ThomasWaldmann> Marchael: why don't you use python files instead of python interpreter copy&paste
83 2011-08-14T09:20:51 <ThomasWaldmann> make it easy to reproduce...
84 2011-08-14T09:22:09 <Marchael> sorry, in next time I'll add file
85 2011-08-14T09:22:59 <dreimark> ThomasWaldmann: its on my todo
86 2011-08-14T09:23:09 <dreimark> s/its/it is/
87 2011-08-14T09:25:58 <dreimark> bbl
88 2011-08-14T09:29:04 <ThomasWaldmann> tw@x300:~/w/moin-2.0-whoosh$ python df.py
89 2011-08-14T09:29:04 <ThomasWaldmann> <Top 1 Results for Term(u'test_id', u'alfa') runtime=0.000662088394165>
90 2011-08-14T09:30:06 <ThomasWaldmann> Marchael: http://paste.pocoo.org/show/458106/
91 2011-08-14T09:30:30 <Marchael> ThomasWaldmann: it's only for create
92 2011-08-14T09:30:41 <Marchael> try to open schema and search for this fields
93 2011-08-14T09:30:48 <ThomasWaldmann> and that's what I am saying since yesterday "add dynamic fields to the builtin schema"
94 2011-08-14T09:31:26 <Marchael> then they become static fields
95 2011-08-14T09:31:35 <Marchael> and wiki admin should rebuild schema
96 2011-08-14T09:31:42 <Marchael> s/schema/index/
97 2011-08-14T09:31:50 <ThomasWaldmann> use my code, modify it to show whatever you want to show
98 2011-08-14T09:32:36 <ThomasWaldmann> i currently do not understand your point, so show me some complete code that produces an issue
99 2011-08-14T09:41:38 <ThomasWaldmann> ma code works like a charm for me :)
100 2011-08-14T09:42:06 <ThomasWaldmann> but the 170 issue seems valid, thanks for finding and fixing it
101 2011-08-14T09:45:34 <Marchael> yes, 171 is seems strange for me too
102 2011-08-14T09:45:54 <Marchael> now I'm trying to refactor my code with new changes
103 2011-08-14T09:46:52 <Marchael> I can't reproduce it, but I something tells me what this is not the end of 171
104 2011-08-14T09:47:21 <Marchael> *but something
105 2011-08-14T09:49:48 <ThomasWaldmann> so, can we have some moin code now? :)
106 2011-08-14T09:52:21 <Marchael> yep :)
107 2011-08-14T09:52:25 *** m4k3r
108 2011-08-14T10:04:47 *** raignarok
109 2011-08-14T10:06:41 * ThomasWaldmann listens to deep purple :)
110 2011-08-14T10:14:31 *** xjjk
111 2011-08-14T10:25:47 *** m4k3r
112 2011-08-14T10:41:05 <ThomasWaldmann> Marchael: you're having progress?
113 2011-08-14T10:42:03 <Marchael> I having difficulties with determinig schema fields
114 2011-08-14T10:42:55 <Marchael> becuase dynamic fields may have different names I don't know their names beforehand
115 2011-08-14T10:43:22 <Marchael> but I'm need some way to check this fields anyway
116 2011-08-14T10:43:39 <ThomasWaldmann> yup
117 2011-08-14T10:43:41 *** raignarok
118 2011-08-14T10:43:53 <Marchael> now, I'm looking in whoosh api trying to find something like "has_field(fieldname)"
119 2011-08-14T10:43:57 <ThomasWaldmann> you can't know them form schema
120 2011-08-14T10:44:09 <ThomasWaldmann> does it matter?
121 2011-08-14T10:44:14 <ThomasWaldmann> from*
122 2011-08-14T10:45:14 <Marchael> yes, because otherwise I'm need hack whoosh to implement has_field
123 2011-08-14T10:45:22 <ThomasWaldmann> why?
124 2011-08-14T10:46:08 <Marchael> and how I check this field belongs to schema?
125 2011-08-14T10:46:17 <Marchael> *check what
126 2011-08-14T10:46:35 <Marchael> I mean field coming from web UI
127 2011-08-14T10:46:58 <ThomasWaldmann> do you need to check?
128 2011-08-14T10:47:04 <Marchael> yes
129 2011-08-14T10:47:19 <ThomasWaldmann> why?
130 2011-08-14T10:47:23 <Marchael> hm
131 2011-08-14T10:48:50 <Marchael> if we want to add field that not belongs to schema, than we'll see something like this http://paste.pocoo.org/show/458127/
132 2011-08-14T10:49:01 <Marchael> s/than/then/
133 2011-08-14T10:49:48 <Marchael> and add_document hasn't ignore options
134 2011-08-14T10:50:54 <ThomasWaldmann> ok, see fields.Schema.__contains__
135 2011-08-14T10:52:24 <Marchael> ah, cool
136 2011-08-14T10:52:30 <Marchael> that's what I searching or
137 2011-08-14T10:52:33 <Marchael> *for
138 2011-08-14T10:52:58 <ThomasWaldmann> you know how to use that?
139 2011-08-14T10:53:09 <Marchael> am?
140 2011-08-14T10:53:32 <ThomasWaldmann> __contains__ i mean
141 2011-08-14T10:54:58 * Marchael will make some experiments
142 2011-08-14T10:58:49 <ThomasWaldmann> (this is standard python magic and there is only one usual way to cast that spell)
143 2011-08-14T11:00:44 <Marchael> :D
144 2011-08-14T11:04:42 <Marchael> ThomasWaldmann: yep, this stuff working \
145 2011-08-14T11:05:25 <dreimark> bbl
146 2011-08-14T11:06:44 * Marchael makes test
147 2011-08-14T11:17:22 * Marchael fixed building scripts
148 2011-08-14T11:18:17 <Marchael> that stuff working ok for, me. But I don't understand why fields weren't added to latest revision
149 2011-08-14T11:21:46 <Marchael> ThomasWaldmann: do you remeber issues with duplicating indexes?
150 2011-08-14T11:22:03 <Marchael> s/indexes/revisions/
151 2011-08-14T11:22:09 <ThomasWaldmann> i remember duplicate in results
152 2011-08-14T11:22:20 <Marchael> yes, I could reproduce this issue
153 2011-08-14T11:22:35 <Marchael> that's happening after rebuilding and moving indexes
154 2011-08-14T11:22:52 <Marchael> when some of old index files stay without changes
155 2011-08-14T11:23:12 <Marchael> so, new indexes were moved and some of old just stays
156 2011-08-14T11:23:53 <Marchael> after rm -rf /wiki/index/ works good :)
157 2011-08-14T11:24:17 <Marchael> * rm -rf wiki/index/
158 2011-08-14T11:25:12 <Marchael> actually, moving indexes only replaces indexes with the same names
159 2011-08-14T11:25:24 <ThomasWaldmann> well, clean is supposed to clean the index
160 2011-08-14T11:25:43 <ThomasWaldmann> but as long as we have load_xml, there is this known issue...
161 2011-08-14T11:28:41 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4876047 ps 1
162 2011-08-14T11:30:36 <Marchael> ThomasWaldmann: I tried to add dynamic fields, and it's working good for all revisions index, but isn't working for latest revs. I'm still working on that issue.
163 2011-08-14T11:40:28 <Marchael> ThomasWaldmann: seems like that's async_writer.update_document(**converted_rev) issue
164 2011-08-14T11:41:03 <ThomasWaldmann> review done
165 2011-08-14T11:44:52 <Marchael> ThomasWaldmann: I don't understand what you mean saying "dynamic field"
166 2011-08-14T11:45:29 <Marchael> what you suggested me, it's static field
167 2011-08-14T11:46:15 <ThomasWaldmann> we are talking about dynamic fields right now
168 2011-08-14T11:46:34 <ThomasWaldmann> and i suggested you just put them into the builtin schema
169 2011-08-14T11:46:54 <Marchael> then that fields become static
170 2011-08-14T11:46:55 <ThomasWaldmann> i am saying this the 3rd time now at least
171 2011-08-14T11:47:07 <ThomasWaldmann> no
172 2011-08-14T11:47:25 <Marchael> ThomasWaldmann: you could't search in that fields without rebuilding schema
173 2011-08-14T11:47:47 <ThomasWaldmann> what's your problem all the time with rebuilding schema?
174 2011-08-14T11:48:00 <ThomasWaldmann> it is BUILTIN, it is there, always
175 2011-08-14T11:48:18 <ThomasWaldmann> and you have to build an index at some time, so it'll be in there also
176 2011-08-14T11:48:46 <ThomasWaldmann> don't make trivial stuff so complicated
177 2011-08-14T11:50:15 <ThomasWaldmann> http://paste.pocoo.org/show/458143/ works like a charm
178 2011-08-14T11:51:39 * Marchael confusing
179 2011-08-14T11:52:24 <Marchael> what difference between schema.add() and writer.add_field() ?
180 2011-08-14T11:52:35 <Marchael> they do the same actions
181 2011-08-14T11:52:39 <ThomasWaldmann> the first one adds it to the schema
182 2011-08-14T11:53:02 <ThomasWaldmann> == easy
183 2011-08-14T11:53:14 <Marchael> second do the same thing
184 2011-08-14T11:53:25 <Marchael> what's the difference?
185 2011-08-14T11:53:53 <ThomasWaldmann> the 2nd one add it to a schema that is stored in an index.
186 2011-08-14T11:54:34 <ThomasWaldmann> but there is no need to add it to an index. you can build the index with it already being in the schema.
187 2011-08-14T11:55:09 <ThomasWaldmann> also, the Schema.add is not broken and does not need your patch
188 2011-08-14T11:56:13 <Marchael> ThomasWaldmann: ok, but why you don't want let wiki admin define dynamic fields in wikiconfig?
189 2011-08-14T11:56:40 <ThomasWaldmann> because for dynamic fields it is neither needed nor useful?
190 2011-08-14T11:57:13 <Marchael> and hacking moin source is usefull? for what?
191 2011-08-14T11:57:43 <ThomasWaldmann> there are a limited amount of whoosh field types and they are known
192 2011-08-14T11:58:09 <ThomasWaldmann> so you will just define dynamic fields for them now and we're done
193 2011-08-14T12:00:20 <Marchael> ok
194 2011-08-14T12:14:06 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4876047 ps 2
195 2011-08-14T12:14:44 <Marchael> ThomasWaldmann: also, update_document() works incorrect for dynamic fields
196 2011-08-14T12:27:00 <ThomasWaldmann> Marchael: make a simple test case to show that issue
197 2011-08-14T12:46:09 *** greg_f
198 2011-08-14T12:49:08 <Marchael> heisenbug
199 2011-08-14T12:49:50 <Marchael> update_document() magic
200 2011-08-14T12:55:03 *** greg_f
201 2011-08-14T12:55:51 *** greg_f
202 2011-08-14T13:12:05 <Marchael> ThomasWaldmann: I found what issue appearing only at building time
203 2011-08-14T13:12:13 <Marchael> so runtime indexing working ok
204 2011-08-14T13:12:48 <dreimark> re
205 2011-08-14T13:29:17 <Marchael> hm, not
206 2011-08-14T13:29:28 <Marchael> isuue appearing after moving indexes
207 2011-08-14T13:34:16 <Marchael> ThomasWaldmann: seems like dynamic fields sensitive to moving
208 2011-08-14T13:37:51 <ThomasWaldmann> show your current code
209 2011-08-14T13:38:05 <Marchael> I don't change it since last cr
210 2011-08-14T13:38:20 <Marchael> (just add some debug prints)
211 2011-08-14T13:38:24 <ThomasWaldmann> wtf
212 2011-08-14T13:39:25 <Marchael> m?'
213 2011-08-14T13:40:08 <ThomasWaldmann> ok, so give some code or procedure to reproduce your "issue"
214 2011-08-14T13:40:17 <Marchael> also, I don't know why. But dynamic fields not moving only for last revs
215 2011-08-14T13:41:07 <Marchael> I even don't know how can it be
216 2011-08-14T13:41:44 <Marchael> I rebuild indexes, and in the end using search in last revs. All good
217 2011-08-14T13:42:26 <Marchael> after --action move I use --action show and don't see dynamic fields in latest revs
218 2011-08-14T13:42:56 <Marchael> wtf
219 2011-08-14T13:45:21 <Marchael> I also tried "mv" for moving and have same results
220 2011-08-14T14:00:29 <ThomasWaldmann> more review comments
221 2011-08-14T14:00:55 <ThomasWaldmann> and after you have fixed the stuff from recent reviews, you please commit it
222 2011-08-14T14:01:15 <ThomasWaldmann> and push. i'll pull and try some stuff then.
223 2011-08-14T14:01:45 <Marchael> should I remove this dynamic fields?
224 2011-08-14T14:03:34 <Marchael> ThomasWaldmann: ^
225 2011-08-14T14:08:28 <Marchael> I mean adding dynamic fields like schema.add(...) stuff
226 2011-08-14T14:09:28 <ThomasWaldmann> how shall i try it if you remove it?
227 2011-08-14T14:09:33 <Marchael> ok
228 2011-08-14T14:15:24 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * a2aee9baecd3 r433 moin-2.0/whoosh200-highlight-mode-fix.patch: removed whoosh-highlighting patch due issue was fixed in 2.1.0
229 2011-08-14T14:15:24 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 6d1f88659ab1 r434 moin-2.0/MoinMoin/ (4 files in 3 dirs): Add dynamic fields support(may be don't work for last revs after rebuilding)
230 2011-08-14T14:16:03 <Marchael> ThomasWaldmann: ^^
231 2011-08-14T14:16:14 * Marchael going to catch some food
232 2011-08-14T14:17:53 *** MattMaker
233 2011-08-14T14:26:10 <ThomasWaldmann> Marchael: after you had something, start working on next issue from tracker
234 2011-08-14T14:36:34 <ThomasWaldmann> Marchael: i can't reproduce a problem with what you have
235 2011-08-14T14:36:46 <ThomasWaldmann> please give an exact problem definition
236 2011-08-14T14:37:39 <ThomasWaldmann> do you expect that the dynamic fields show with index show script?
237 2011-08-14T14:37:54 <ThomasWaldmann> they don't because you did not store them, just index them
238 2011-08-14T14:40:05 <Marchael> ThomasWaldmann: I expected results when searching from search form
239 2011-08-14T14:40:15 <ThomasWaldmann> i got results
240 2011-08-14T14:40:21 <Marchael> and I see results only for all revs
241 2011-08-14T14:40:38 <Marchael> hm, do you see results for latest revs too?
242 2011-08-14T14:41:31 <ThomasWaldmann> i only tried latest revs, yes
243 2011-08-14T14:42:44 <Marchael> now, shut down moin, make rm -rf wiki/index*, moin index --for both --action {build,move} and try to search for something in dynamic fields
244 2011-08-14T14:43:28 <Marchael> I found that issue only after rebuilding and moving
245 2011-08-14T14:43:45 <Marchael> if you change stuff from web UI then it successfully added
246 2011-08-14T14:44:01 <ThomasWaldmann> works
247 2011-08-14T14:44:33 <ThomasWaldmann> i added "foo_id": "bar" to metadata of a current revision
248 2011-08-14T14:44:46 <ThomasWaldmann> if i search for foo_id:bar, if find that
249 2011-08-14T14:45:14 <Marchael> after rebuilding and moving?
250 2011-08-14T14:45:28 <Marchael> because for runtime adding it works
251 2011-08-14T14:45:32 <ThomasWaldmann> yes
252 2011-08-14T14:45:58 <Marchael> starnge
253 2011-08-14T14:45:58 <Marchael> *strange
254 2011-08-14T14:46:06 <ThomasWaldmann> ok, another thing:
255 2011-08-14T14:46:17 <ThomasWaldmann> we need more dynamic fields and less code duplication
256 2011-08-14T14:46:46 <Marchael> so?
257 2011-08-14T14:46:52 <ThomasWaldmann> think and discuss about what we need and how to avoid c.d.
258 2011-08-14T14:48:20 <Marchael> use stuff like I do in wikiconfig
259 2011-08-14T14:48:35 <Marchael> {'schema': [fields\]}
260 2011-08-14T14:49:39 <ThomasWaldmann> just directly use the 2 schemas
261 2011-08-14T14:49:59 <ThomasWaldmann> but the fields and globs can be done easily by a loop
262 2011-08-14T14:50:13 <ThomasWaldmann> so, what dynamic fields do we need?
263 2011-08-14T14:51:02 <Marchael> I think what wiki admin will define dynamic fiels
264 2011-08-14T14:51:05 <Marchael> *fields
265 2011-08-14T14:51:54 <ThomasWaldmann> why?
266 2011-08-14T14:52:11 <ThomasWaldmann> and which?
267 2011-08-14T14:52:22 <Marchael> because he knows better us about fields what he need :)
268 2011-08-14T14:53:08 <Marchael> any fields from whoosh.fields
269 2011-08-14T14:53:12 <ThomasWaldmann> just give one usecase
270 2011-08-14T14:53:49 *** raignarok
271 2011-08-14T14:54:08 *** MattMaker
272 2011-08-14T14:54:43 <Marchael> hm, need to think
273 2011-08-14T14:57:43 <ThomasWaldmann> or just think why it is not needed to be configurable for the admin
274 2011-08-14T14:59:07 <Marchael> ThomasWaldmann: for example wiki have some "undone" articles and wiki admin just add dynamic fields "undone_article", so users may search for this articles and edit them.
275 2011-08-14T15:01:28 <ThomasWaldmann> that's a static field, not a dynamic field
276 2011-08-14T15:01:51 <ThomasWaldmann> we are only discussion dynamic fields right now
277 2011-08-14T15:02:00 <ThomasWaldmann> ing*
278 2011-08-14T15:03:44 <Marchael> may be mark system? so pages may have "bad_mark", "good_mark", "awesome_mark"
279 2011-08-14T15:04:04 <ThomasWaldmann> that are not dynamic fields either
280 2011-08-14T15:04:26 <ThomasWaldmann> a dynamic field is defined by a glob
281 2011-08-14T15:04:50 <ThomasWaldmann> so give usecases, glob and type
282 2011-08-14T15:04:58 <Marchael> hm, I mean something like ("*_mark", ID, glob=True)
283 2011-08-14T15:05:18 <ThomasWaldmann> we already have *_id if you need any id
284 2011-08-14T15:08:45 <ThomasWaldmann> so?
285 2011-08-14T15:09:37 <Marchael> hm. _id is enough wide
286 2011-08-14T15:09:58 <Marchael> may be wiki admin want something particulare
287 2011-08-14T15:10:11 <Marchael> *particular
288 2011-08-14T15:10:11 <ThomasWaldmann> so give usecases, glob and type
289 2011-08-14T15:10:32 <ThomasWaldmann> if you can't make something up, maybe there is none
290 2011-08-14T15:11:12 <Marchael> If I can't find usecase, then it doesn't mean what it is none.
291 2011-08-14T15:11:39 <ThomasWaldmann> true, but i can prove the opposite :P
292 2011-08-14T15:11:56 <Marchael> mm?
293 2011-08-14T15:12:13 <ThomasWaldmann> if we have *_id builtin, wiki users can define any ID field they want
294 2011-08-14T15:12:32 <ThomasWaldmann> so you don't need an admin configuring any ID field in the config.
295 2011-08-14T15:13:40 <ThomasWaldmann> (the only slight disadvantage of this is that you need to match that glob, but that is the case for any dynamic field)
296 2011-08-14T15:13:55 <ThomasWaldmann> so, what's really missing?
297 2011-08-14T15:16:21 <ThomasWaldmann> that's pretty obvious, come on
298 2011-08-14T15:16:40 <Marchael> but say, why you don't want to give wiki admin choose right? If it isn't needed he just won't use that. If so, then he can use that in any way as he want and build different structure with it. That stuff rather flexible
299 2011-08-14T15:17:22 <ThomasWaldmann> we are still at step one and i want to complete it and not discuss for ages about it
300 2011-08-14T15:17:47 <ThomasWaldmann> we can later discuss about step 2, which might be making it configurable, if we find good reason for it
301 2011-08-14T15:19:33 <Marchael> then what you want? just make loop what add some schema fields?
302 2011-08-14T15:19:45 <ThomasWaldmann> yes
303 2011-08-14T15:19:52 <Marchael> and which fields?
304 2011-08-14T15:20:20 <ThomasWaldmann> and of course you need to cover more fieldtypes offered by whoosh
305 2011-08-14T15:21:32 <Marchael> why I can't just use all types of whoosh fields?
306 2011-08-14T15:22:08 <ThomasWaldmann> well, what's the use case for STORED?
307 2011-08-14T15:23:42 <Marchael> hm, then may be all fields except STORED and NGRAM?
308 2011-08-14T15:24:04 <Marchael> (because NGRAM is not reay yet)
309 2011-08-14T15:24:08 <Marchael> *ready
310 2011-08-14T15:24:29 <ThomasWaldmann> yes
311 2011-08-14T15:25:48 <Marchael> ok
312 2011-08-14T15:28:59 <ThomasWaldmann> NUMERIC needs more thought
313 2011-08-14T15:33:51 <Marchael> brb
314 2011-08-14T16:14:45 *** raignarok
315 2011-08-14T16:59:13 * ThomasWaldmann made a patch for whoosh so it supports same datetime string parsing at index time as it does at query time
316 2011-08-14T17:09:29 *** raignarok
317 2011-08-14T17:38:59 *** raignarok
318 2011-08-14T17:48:08 *** Marchael
319 2011-08-14T18:02:59 *** pkumar
320 2011-08-14T18:52:20 *** raignarok
321 2011-08-14T18:54:14 *** raignarok
322 2011-08-14T19:00:21 *** Marchael
323 2011-08-14T19:01:56 <Marchael> re
324 2011-08-14T19:04:24 <pkumar> dreimark : please go though my reply on codereview: http://codereview.appspot.com/4900041/
325 2011-08-14T19:09:57 *** sinha
326 2011-08-14T19:13:52 <waldi> moin
327 2011-08-14T19:24:45 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4889045 ps 1
328 2011-08-14T19:24:47 *** pkumar
329 2011-08-14T19:36:01 <ThomasWaldmann> Marchael: deeply nested again, without reason, duplicated
330 2011-08-14T19:37:16 <Marchael> I don't what type of fields you want, so I just making for all
331 2011-08-14T19:37:23 <ThomasWaldmann> and the flexibility you have bought with that deep nesting is useless, because the schema attributes are hardcoded a few lines above anyway
332 2011-08-14T19:37:48 <ThomasWaldmann> make something simpler
333 2011-08-14T19:39:45 <Marchael> may be you give me a hint how to do it simplier?
334 2011-08-14T19:39:49 <ThomasWaldmann> and for simplicity, just use lowercase of class name for the glob
335 2011-08-14T19:42:13 <Marchael> you mean use _datetime and _boolean?
336 2011-08-14T19:43:32 <ThomasWaldmann> yes
337 2011-08-14T19:43:57 <ThomasWaldmann> (we'll have to think about all those field names, but we'll do this separately)
338 2011-08-14T19:45:16 <Marchael> ok, done
339 2011-08-14T19:48:16 *** pkumar
340 2011-08-14T19:49:33 <Marchael> ThomasWaldmann: what next?
341 2011-08-14T19:53:18 <ThomasWaldmann> i don't see a CR or commit yet
342 2011-08-14T19:54:11 <Marchael> ThomasWaldmann: ps 2
343 2011-08-14T19:56:29 <ThomasWaldmann> it didn't change much, see my comments above, they still apply
344 2011-08-14T19:58:14 <Marchael> hm, I used fields names as you suggested, what else?
345 2011-08-14T19:58:25 <ThomasWaldmann> (19:34) < ThomasWal> Marchael: deeply nested again, without reason, duplicated
346 2011-08-14T19:58:33 <ThomasWaldmann> (19:36) < ThomasWal> make something simpler
347 2011-08-14T20:00:36 *** greg_f
348 2011-08-14T20:01:35 <Marchael> ThomasWaldmann: ps 3
349 2011-08-14T20:05:40 <ThomasWaldmann> better, see comments
350 2011-08-14T20:09:07 <Marchael> ThomasWaldmann: ps 4
351 2011-08-14T20:10:40 *** pkumar
352 2011-08-14T20:13:11 <ThomasWaldmann> better, see comments
353 2011-08-14T20:13:25 <ThomasWaldmann> and commit
354 2011-08-14T20:13:52 <ThomasWaldmann> #32
355 2011-08-14T20:14:32 <Marchael> ThomasWaldmann: that commit fixes #17?
356 2011-08-14T20:15:56 <ThomasWaldmann> well, it won't completely work, but this is unclear yet. maybe issue in whoosh, maybe not.
357 2011-08-14T20:16:00 <ThomasWaldmann> so close it.
358 2011-08-14T20:16:17 <Marchael> ok
359 2011-08-14T20:17:36 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * dccbd79260ce r435 moin-2.0/MoinMoin/search/indexing.py: Added several dynamic fields Fixes #17.
360 2011-08-14T20:18:36 * Marchael very proud own issue tracker
361 2011-08-14T20:18:46 <Marchael> :)
362 2011-08-14T20:21:51 <ThomasWaldmann> (you see the issues if you try to use datetime or boolean and maybe also numeric)
363 2011-08-14T20:26:35 *** raignarok
364 2011-08-14T20:38:55 * ThomasWaldmann cleans up whoosh src
365 2011-08-14T20:39:32 * Marchael refactoring some crap
366 2011-08-14T20:51:22 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4903042 ps 1
367 2011-08-14T20:55:51 <ThomasWaldmann> https://bitbucket.org/mchaput/whoosh/changesets that was quick
368 2011-08-14T20:58:15 <ThomasWaldmann> Marchael: great :)
369 2011-08-14T20:58:56 <Marchael> :)
370 2011-08-14T20:59:09 <ThomasWaldmann> test/commit/close
371 2011-08-14T20:59:29 <Marchael> do you read my comment?
372 2011-08-14T20:59:41 <Marchael> about locals()
373 2011-08-14T21:00:11 * ThomasWaldmann reads
374 2011-08-14T21:00:45 <ThomasWaldmann> ah, right. well, usually one does not do such stuff.
375 2011-08-14T21:01:02 <ThomasWaldmann> if you make sure that the name is defined / assigned, you do not need that
376 2011-08-14T21:01:24 <ThomasWaldmann> and i think you already made sure...
377 2011-08-14T21:01:27 <Marchael> hm, but this item is user then rev_no is undefined...
378 2011-08-14T21:01:39 <ThomasWaldmann> ah
379 2011-08-14T21:01:43 <Marchael> s/this/if/
380 2011-08-14T21:05:05 <ThomasWaldmann> see review
381 2011-08-14T21:05:23 <ThomasWaldmann> not very pretty either, but better than checking locals()
382 2011-08-14T21:08:12 <Marchael> ah, simple :)
383 2011-08-14T21:13:56 <Marchael> seems working
384 2011-08-14T21:15:21 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 33249607fd48 r436 moin-2.0/MoinMoin/script/maint/index.py: Refactoing crap in building script Fixes #32.
385 2011-08-14T21:16:28 <Marchael> ThomasWaldmann: thank you, what next?
386 2011-08-14T21:18:30 <ThomasWaldmann> see the priorities
387 2011-08-14T21:19:02 <Marchael> #16?
388 2011-08-14T21:20:02 <ThomasWaldmann> yes, one day it needs to get done :)
389 2011-08-14T21:20:23 <ThomasWaldmann> maybe first cleanup on EP
390 2011-08-14T21:21:11 <Marchael> ok, I'll start next morning.
391 2011-08-14T21:21:16 <Marchael> gn/bbl
392 2011-08-14T21:21:21 <ThomasWaldmann> gn Marchael
393 2011-08-14T21:21:27 *** Marchael
394 2011-08-14T21:42:38 <CIA-114> Akash Sinha <akash2607@gmail.com> * 050c5d125762 r377 default/MoinMoin/ (5 files in 4 dirs): New item tab added on index page, and Upload file button also moved under that new item box (but drag-drop area kept to whole screen as it was earlier)
395 2011-08-14T21:48:23 <sinha> dreimark: i have pushed the changes for that new item creation on index page, please try that when you will get some time
396 2011-08-14T22:10:43 *** raignarok
397 2011-08-14T22:49:36 <dreimark> sinha: thx, looking
398 2011-08-14T22:56:13 <dreimark> sinha: please merge main
399 2011-08-14T22:56:20 <sinha> yes
400 2011-08-14T22:56:29 <dreimark> we can talk with starshine on #moin about ideas for ui
401 2011-08-14T22:56:48 <dreimark> next time she is available
402 2011-08-14T22:59:44 <dreimark> sinha: move create item on top of the actions
403 2011-08-14T23:00:13 <sinha> okay
404 2011-08-14T23:00:18 <dreimark> and write the prefix for the current location e.g. the item item where we create subitems into the textbox
405 2011-08-14T23:00:36 <dreimark> so one sees where it becomes created and can change it too
406 2011-08-14T23:01:33 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * b5c4372d5194 r378 default/MoinMoin/util/interwiki.py: add missing log/logging import
407 2011-08-14T23:01:33 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 0c5673f5faa1 r379 default/docs/admin/install.rst: updated install docs with some hints for non-system non-default python interpreters, like pypy or other python versions
408 2011-08-14T23:01:33 <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> * 90c9f951c2e7 r380 default/ (wikiconfig.py MoinMoin/templates/base.html setup.py): mathjax removed because of its vast size, time needed to download/install/upgrade, fixes #43
409 2011-08-14T23:01:33 <CIA-114> Akash Sinha <akash2607@gmail.com> * aeb5bc216f21 r381 default/ (5 files in 4 dirs): branch merged with main repo
410 2011-08-14T23:03:56 <dreimark> sinha: how can we close the "Create new item" form if one decides not to do that
411 2011-08-14T23:04:09 <sinha> click Later
412 2011-08-14T23:04:16 <sinha> dreimark: ^
413 2011-08-14T23:04:22 <dreimark> ah, ok
414 2011-08-14T23:04:45 <sinha> dreimark: the prefix thing will be similar to the picture you shown earlier, but one can change that also, right ? i mean if i set prefix in textbox itself, one can even remove that and then newly created item will be at global level
415 2011-08-14T23:05:03 <dreimark> please upload asap a image for the forms
416 2011-08-14T23:05:21 <dreimark> yes needs to be possible to change
417 2011-08-14T23:05:49 <sinha> dreimark: http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-08-14?action=AttachFile&do=get&target=index.png
418 2011-08-14T23:05:59 <dreimark> thats a user failure then if he don't want that
419 2011-08-14T23:07:23 <dreimark> sinha: i am not sure if it is a good idea to move "filter by content type" also into the action list
420 2011-08-14T23:07:57 <dreimark> starshine has in the past designed some themes
421 2011-08-14T23:08:26 <dreimark> sinha: what do you think?
422 2011-08-14T23:08:59 <sinha> dreimark: action is for the items on page, but that contenttype is filter for the items
423 2011-08-14T23:09:08 <dreimark> ok
424 2011-08-14T23:51:31 <dreimark> gn
