1 2011-08-09T00:51:44 *** MattMaker
2 2011-08-09T05:47:42 *** MattMaker
3 2011-08-09T07:43:45 *** pkumar
4 2011-08-09T08:27:52 *** pkumar
5 2011-08-09T09:09:31 *** raignarok
6 2011-08-09T09:15:36 *** pkumar
7 2011-08-09T09:28:27 <ThomasWaldmann> moin
8 2011-08-09T09:58:13 *** raignarok
9 2011-08-09T10:43:36 <ThomasWaldmann> dreimark: pkumar: waldi: xorAxAx: meeting is today as usual.
10 2011-08-09T10:44:30 <pkumar> ThomasWaldmann : ok, will be there.
11 2011-08-09T11:03:44 *** pkumar
12 2011-08-09T11:17:34 <xorAxAx> ThomasWaldmann: i will be at the chaos camp setting up my tent
13 2011-08-09T11:20:40 <ThomasWaldmann> xorAxAx: say hello to waldi :)
14 2011-08-09T11:26:34 <ronny> sup
15 2011-08-09T11:29:08 <ThomasWaldmann> ronny: as our testing mentors seem to be busy with tents today, can you help at 16:00 UTC meeting?
16 2011-08-09T11:31:25 <ronny> ThomasWaldmann: at 16:00 CEST i have to meet one of my professors, also sadly i lost track of the state of the testing stuff
17 2011-08-09T11:32:45 <ThomasWaldmann> well, just finish with your prof in 2h, so you are ready at 16:00 UTC :)
18 2011-08-09T11:33:30 <ThomasWaldmann> and you only have to look at pkumar's stuff :)
19 2011-08-09T11:33:45 <ronny> ThomasWaldmann: i need to get up2date, suppose all his stuff is in his repo
20 2011-08-09T11:33:53 *** greg_f
21 2011-08-09T11:34:02 <ThomasWaldmann> yes, i think so
22 2011-08-09T11:35:11 *** greg_f
23 2011-08-09T11:51:41 *** MattMaker_
24 2011-08-09T11:54:09 *** MattMaker
25 2011-08-09T11:54:09 *** MattMaker_
26 2011-08-09T12:16:10 *** raignarok
27 2011-08-09T12:23:50 * waldi got power and network
28 2011-08-09T12:23:58 <waldi> xorAxAx: location?
29 2011-08-09T12:56:15 *** MattMaker
30 2011-08-09T15:01:30 *** MattMaker
31 2011-08-09T15:03:42 *** MattMaker
32 2011-08-09T15:04:09 *** MattMaker
33 2011-08-09T15:13:10 *** MattMaker
34 2011-08-09T15:27:49 *** raignarok
35 2011-08-09T15:28:06 <dreimark> moin
36 2011-08-09T15:28:55 <ThomasWaldmann> hi dreimark
37 2011-08-09T16:00:17 * dreimark e get a coffee and I'm back to the meeting in 2h
38 2011-08-09T16:21:09 *** MattMaker
39 2011-08-09T16:21:51 *** greg_f
40 2011-08-09T16:24:06 *** sinha
41 2011-08-09T16:25:14 *** greg_f
42 2011-08-09T16:39:23 *** pkumar
43 2011-08-09T16:52:51 *** MattMaker
44 2011-08-09T16:54:59 *** MattMaker
45 2011-08-09T17:15:35 *** greg_f
46 2011-08-09T17:20:15 *** greg_f
47 2011-08-09T17:33:41 *** raignarok
48 2011-08-09T17:49:23 *** greg_f
49 2011-08-09T17:50:51 *** greg_f
50 2011-08-09T17:57:16 *** MattMaker
51 2011-08-09T17:57:34 *** MattMaker
52 2011-08-09T18:00:50 <dreimark> re
53 2011-08-09T18:02:37 <dreimark> ThomasWaldmann: waldi xorAxAx pkumar sinha tell me that you are here
54 2011-08-09T18:02:47 <sinha> present
55 2011-08-09T18:03:21 <waldi> here
56 2011-08-09T18:03:22 <pkumar> hey
57 2011-08-09T18:03:30 <pkumar> I'm here
58 2011-08-09T18:04:15 * dreimark we mait 2min for a sign of ThomasWaldmann. sinha please prepare to start
59 2011-08-09T18:04:27 <sinha> just in a min
60 2011-08-09T18:04:30 <ThomasWaldmann> welcome to our weekly meeting
61 2011-08-09T18:04:47 <ThomasWaldmann> pkumar: do you want to begin?
62 2011-08-09T18:05:10 <pkumar> ThomasWaldmann : please gimme 2 mins
63 2011-08-09T18:05:30 <ThomasWaldmann> any one else ready now?
64 2011-08-09T18:06:38 <dreimark> sinha: can you start?
65 2011-08-09T18:06:52 <sinha> just a sec
66 2011-08-09T18:07:58 * ThomasWaldmann has his alarm set to 15:50 UTC :)
67 2011-08-09T18:08:22 <pkumar> shall I?
68 2011-08-09T18:09:15 *** raignarok
69 2011-08-09T18:09:18 <ThomasWaldmann> pkumar: please begin
70 2011-08-09T18:09:29 <pkumar> this week:
71 2011-08-09T18:09:33 <pkumar> worked on improvement of test coverage
72 2011-08-09T18:09:33 <pkumar> on modules auth, security, macro - wrote tests for these
73 2011-08-09T18:09:33 <pkumar> worked on issue regarding import_export_xml in app. removed it's dependency in tests
74 2011-08-09T18:09:33 <pkumar> will take 1 or max 2 days on test coverage, will work on test cleanup after that
75 2011-08-09T18:09:33 <pkumar> Blockers: None
76 2011-08-09T18:10:51 <pkumar> also have do write a documentation of the work
77 2011-08-09T18:11:18 <pkumar> as mentioned in my application
78 2011-08-09T18:11:30 <ThomasWaldmann> pkumar: so you modified the tests so that they still make sense without those counters?
79 2011-08-09T18:11:58 <pkumar> yeah, they don't need import_export_xml any more
80 2011-08-09T18:12:19 <ThomasWaldmann> did you run the tests with an empty backend?
81 2011-08-09T18:12:39 <ThomasWaldmann> so no stuff in wiki/data/* and MoinMoin/_tests/wiki/... ?
82 2011-08-09T18:12:40 <dreimark> or with a fresh clone
83 2011-08-09T18:14:12 <pkumar> no, I didn't. I just removed that method and ran the test
84 2011-08-09T18:14:18 <pkumar> before and after
85 2011-08-09T18:14:33 <ThomasWaldmann> ok, so please try later with a fresh clone and load_xml = None
86 2011-08-09T18:14:41 <ThomasWaldmann> you'll see then if everything is still happy
87 2011-08-09T18:14:53 <pkumar> ok, I'll do that
88 2011-08-09T18:15:05 <ThomasWaldmann> waldi: xorAxAx: ronny: questions for pkumar?
89 2011-08-09T18:15:40 <ronny> ThomasWaldmann: not yet, have to pull and run a quick review
90 2011-08-09T18:16:01 <pkumar> ronny : hey,
91 2011-08-09T18:16:20 <ThomasWaldmann> ok, anyone else?
92 2011-08-09T18:16:55 <ThomasWaldmann> ok, sinha, are you ready?
93 2011-08-09T18:17:00 <sinha> yes
94 2011-08-09T18:17:03 * dreimark pulls too
95 2011-08-09T18:17:04 <pkumar> ronny : tell me if you find any thing for improvement there
96 2011-08-09T18:17:16 <ThomasWaldmann> ok, please begin
97 2011-08-09T18:17:19 <ThomasWaldmann> (sinha)
98 2011-08-09T18:17:22 <sinha> LAST: i) Added select item feature on index page
99 2011-08-09T18:17:22 <sinha> CS: https://bitbucket.org/sinha/moin2/changeset/e65f9a5ee6df
100 2011-08-09T18:17:22 <sinha> ii) following above added multiple downloading of item
101 2011-08-09T18:17:22 <sinha> CS: https://bitbucket.org/sinha/moin2/changeset/85c3759de3a6
102 2011-08-09T18:17:22 <sinha> iii) to get rid of so many poup boxes on downloading, added a new mimetype for the items being downloaded
103 2011-08-09T18:17:57 <ThomasWaldmann> sinha: do you have a current screenshot?
104 2011-08-09T18:18:15 <sinha> posting it
105 2011-08-09T18:19:24 <sinha> http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-08-09?action=AttachFile&do=get&target=index.png
106 2011-08-09T18:19:30 <sinha> ThomasWaldmann: ^
107 2011-08-09T18:19:47 <ThomasWaldmann> https://bitbucket.org/sinha/moin2/changeset/85c3759de3a6#chg_MoinMoin/static/js/index_action.js_newline64 i18n?
108 2011-08-09T18:20:08 <ThomasWaldmann> the screenshot shows >= 2 typos
109 2011-08-09T18:20:42 <sinha> ThomasWaldmann: yes i was going to ask that, how to do i18n in javascript
110 2011-08-09T18:20:51 <sinha> i have to do that in that dialog box also
111 2011-08-09T18:20:51 <dreimark> in one sentence
112 2011-08-09T18:21:15 <dreimark> s/coment/comment/
113 2011-08-09T18:21:24 <dreimark> s/you/your/
114 2011-08-09T18:21:28 <sinha> yes i have seen that
115 2011-08-09T18:21:31 <ThomasWaldmann> i don't think we have infrastructure for i18n in js yet
116 2011-08-09T18:21:33 <dreimark> and I rather won't use Add
117 2011-08-09T18:23:02 <dreimark> sinha: in svg-edit is a i18n translation, i look this later up
118 2011-08-09T18:23:16 <ThomasWaldmann> why does some stuff has checkboxes and other items not?
119 2011-08-09T18:23:45 <sinha> checkboxes appear when the item is hovered, such that page would look clean
120 2011-08-09T18:24:06 <ThomasWaldmann> ah, ok
121 2011-08-09T18:24:08 <sinha> and when the are selected, they remain there
122 2011-08-09T18:25:23 <ThomasWaldmann> i think the ui needs some improvement, but I have to think about it before pointing at it.
123 2011-08-09T18:25:44 <dreimark> yes, i am too in that state
124 2011-08-09T18:25:54 <dreimark> one idea wa to have something like a sidebar
125 2011-08-09T18:26:17 <dreimark> or a box with "upload" ,"filer", "download"
126 2011-08-09T18:26:23 <ronny> pkumar: there is a few changesets that have unrelated changes in them, like dozen of times py.test to pytest renames, then sudenly a new test
127 2011-08-09T18:26:37 <sinha> yes because when there are lots of items, upload button goes much down
128 2011-08-09T18:28:06 <ronny> pkumar: so far th changes look well, its a bit much to review quickly
129 2011-08-09T18:29:07 <dreimark> sinha: the delete function is not pushed, or?
130 2011-08-09T18:29:14 <dreimark> you work on that currently
131 2011-08-09T18:29:22 <sinha> yes working, will push in few hours
132 2011-08-09T18:29:37 <dreimark> ok
133 2011-08-09T18:29:50 <sinha> dreimark: in passing the file names from js to backend, i am sending them as a comma separated value
134 2011-08-09T18:29:58 <sinha> i mean what other method should i adopt
135 2011-08-09T18:30:21 <ronny> pkumar: 30f4fb350ad1 contains a NO DO, if a test breaks for a weird reason, mark it as xfail instead of commenting a assert out
136 2011-08-09T18:30:27 <ronny> see test_new_item_create_revision
137 2011-08-09T18:30:53 <dreimark> sinha: , is a problem, because you can create items with a comma
138 2011-08-09T18:31:12 <ThomasWaldmann> sinha: if you pass around filenames, make sure there are no encoding/decoding issues
139 2011-08-09T18:31:20 <sinha> dreimark: so what delimeter i should use ?
140 2011-08-09T18:31:42 <sinha> s/delemeter/delimiter
141 2011-08-09T18:32:14 <sinha> ThomasWaldmann: yes i am yet to test that
142 2011-08-09T18:33:15 <ronny> pkumar: and the try/finally in MoinTestFunction is a WTF OMG
143 2011-08-09T18:33:42 <sinha> ThomasWaldmann: can i use some kind of integer for items
144 2011-08-09T18:33:54 <sinha> is there any unique id associated with each item
145 2011-08-09T18:34:10 <ThomasWaldmann> theoretically there is a uuid, but its buggy still
146 2011-08-09T18:34:18 <dreimark> the name is always unicode
147 2011-08-09T18:34:50 <dreimark> the uuid is not defined to be only a number
148 2011-08-09T18:35:02 <sinha> dreimark: so when i will pass names for js to backend it may not be the same in case of unicodes?
149 2011-08-09T18:35:19 <dreimark> why?
150 2011-08-09T18:36:05 <ronny> brb
151 2011-08-09T18:36:07 <sinha> i mean if a pass any chinese names it will go in backend as it is not in unicode
152 2011-08-09T18:36:19 <ThomasWaldmann> sinha: if you always encode to utf-8 and decode from utf-8, there is no problem
153 2011-08-09T18:36:24 <pkumar> ronny : sorry for the delayed response, having a connection problem right now. regarding the changeset 30f4fb350ad1, I have corrected it in the next ones. the comment has been removed
154 2011-08-09T18:36:40 <sinha> ThomwasWaldmann: okay
155 2011-08-09T18:37:00 <sinha> so i have to decode it when i receive the names
156 2011-08-09T18:37:32 <ThomasWaldmann> btw, marchael is not here because it's his birthday today
157 2011-08-09T18:38:49 <dreimark> ok
158 2011-08-09T18:38:53 <dreimark> good reason
159 2011-08-09T18:38:54 <pkumar> ronny : regarding py.test, those imports should have been converted to pytest for long back in porting part itself, but these tests were assigned to hardy89 and seems like he missed to do those
160 2011-08-09T18:40:08 <dreimark> sinha: a pipe symbol | may be as separator? ThomasWaldmann any other idea?
161 2011-08-09T18:40:40 <pkumar> ronny : I'll remove that try, finally from there,
162 2011-08-09T18:40:46 <ThomasWaldmann> for what do you need a separator?
163 2011-08-09T18:41:22 <dreimark> sending a list of items in one request for e.g. deleting
164 2011-08-09T18:41:29 <dreimark> sinha: ^
165 2011-08-09T18:41:44 <sinha> yes
166 2011-08-09T18:41:50 <sinha> or we can send them one by one
167 2011-08-09T18:41:59 <sinha> but it may take much time
168 2011-08-09T18:42:16 <ThomasWaldmann> json has lists
169 2011-08-09T18:43:15 <ThomasWaldmann> ok, i guess we are through with the formal part, free discussion from now on. thanks to everybody who managed to be here.
170 2011-08-09T18:43:45 <sinha> ThomasWaldmann: but in the list can we add variable number of entries
171 2011-08-09T18:43:55 <sinha> i mean in the list we have to give key-value pair
172 2011-08-09T18:45:11 <ThomasWaldmann> k/v is usually a dict, json has that too. see how our metadata looks like when you modify an item on the web ui. the metadata editor has a json serialization of the metadata.
173 2011-08-09T18:45:43 <sinha> okay i will look into that
174 2011-08-09T18:49:54 <dreimark> good point
175 2011-08-09T18:51:32 <dreimark> sinha: svg-edit http://code.google.com/p/svg-edit/source/browse/#svn%2Ftrunk%2Feditor%2Flocale
176 2011-08-09T18:51:58 <ronny> pkumar: then consider the NO GO warning wrt 30f4fb350ad1 a hint, if something breaks for known/unknown reasons, marking it as xfail is better than commenting away assertions
177 2011-08-09T18:52:26 <dreimark> e.g. http://code.google.com/p/svg-edit/source/browse/trunk/editor/locale/lang.de.js
178 2011-08-09T18:53:05 *** greg_f
179 2011-08-09T18:53:10 <pkumar> ronny : ok,
180 2011-08-09T18:53:10 <sinha> it saves the translated texts
181 2011-08-09T18:53:24 <dreimark> this is how they did it
182 2011-08-09T18:53:52 *** greg_f
183 2011-08-09T18:54:31 <dreimark> without having a plan for js translations everything is a workaround
184 2011-08-09T18:54:41 <sinha> yes
185 2011-08-09T18:54:50 <dreimark> because we can have a varity of plugins with different approaches
186 2011-08-09T18:55:27 <dreimark> e.g. ckeditor, any other jquery plugin
187 2011-08-09T18:55:50 <dreimark> i would prefer a common framework which can be used in all of those
188 2011-08-09T18:57:05 <sinha> yes from now on we will be adding more javascripts to the code, so we need something for that
189 2011-08-09T18:57:13 <dreimark> sinha: if you have an idea how to solve that add it to the etherpad
190 2011-08-09T18:57:45 <dreimark> we need to collect that first and may be ask some others too
191 2011-08-09T18:57:57 <sinha> one thing is we can write the message in template itself, and just show/hide from javascript
192 2011-08-09T18:58:37 <dreimark> yeah thats good, then we can do the translation by template function
193 2011-08-09T18:59:04 <sinha> yes
194 2011-08-09T19:00:00 <dreimark> we should do this always for our stuff that way
195 2011-08-09T19:08:20 * dreimark has two talks on pycon de
196 2011-08-09T19:24:37 <dreimark> http://de.pycon.org/2011/schedule/lists/talks/
197 2011-08-09T19:24:44 <dreimark> bbl
198 2011-08-09T19:28:04 <sinha> bbl
199 2011-08-09T19:28:06 *** sinha
200 2011-08-09T19:43:41 *** pkumar
201 2011-08-09T19:51:17 *** greg_f
202 2011-08-09T20:53:21 <ThomasWaldmann> re
203 2011-08-09T21:00:14 <brunomartin> ThomasWaldmann: Hi! I'm trying to solve the object tag but (https://bitbucket.org/thomaswaldmann/moin-2.0/issue/42/problem-rendering-object-tag-on-page)... could you give me some help?
204 2011-08-09T21:00:23 <brunomartin> *bug
205 2011-08-09T21:01:28 <brunomartin> ThomasWaldmann: Roger has commented that is out of ideias on this...
206 2011-08-09T21:17:37 <ThomasWaldmann> i can try
207 2011-08-09T21:17:51 <ThomasWaldmann> any specific question?
208 2011-08-09T21:23:18 <ThomasWaldmann> brunomartin:
209 2011-08-09T21:23:52 <brunomartin> ThomasWaldmann: lots of then... :-P I think the problem is in html_in (and rst_in) as Roger said. I'm not familiar with element tree.... I realised that html_in uses moin_page and creole_in (that works) uses xinclude. Seems that xinclude closes the object tag the right way, while moin_page makes <object ... />. Does this make any sense?! :-|
210 2011-08-09T21:29:46 <brunomartin> ThomasWaldmann: could be this issue related to emeraldTree?
211 2011-08-09T21:31:22 <ThomasWaldmann> no, it doesn't make sense to me
212 2011-08-09T21:32:52 <ThomasWaldmann> first, a normal item rendering works like this: moinwiki_in (or rst_in or some other _in converter) -> dom tree -> html_out
213 2011-08-09T21:33:07 <ThomasWaldmann> so i don't know why you are mentioning html_in
214 2011-08-09T21:36:16 <brunomartin> I have html contenttype here, so it pass through html_in, but it's the same problem with rst_in...
215 2011-08-09T21:36:44 <ThomasWaldmann> how about making a test case that fails
216 2011-08-09T21:37:10 <brunomartin> here is it: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/42/problem-rendering-object-tag-on-page
217 2011-08-09T21:37:24 <ThomasWaldmann> maybe a rather minimal one
218 2011-08-09T21:37:29 <brunomartin> there is two examples there, on moin2 test page...
219 2011-08-09T21:37:40 <ThomasWaldmann> that's an issue report, not a test case
220 2011-08-09T21:41:08 <brunomartin> well, the test case is quite simple,create an item, witch contenttype is html or rst, insert an image on that item, and nothing after the image is rendered. Not even the footer.
221 2011-08-09T21:43:51 <ThomasWaldmann> with test case i mean a unit test
222 2011-08-09T21:47:15 <ThomasWaldmann> for me, this looks a bit like a serialization issue
223 2011-08-09T21:48:21 <ThomasWaldmann> because it is not that the <object> is unclosed there, it is <object ... />, self-closing.
224 2011-08-09T21:51:22 <ThomasWaldmann> how exactly looked it like when you saw </object>? was there something in between opening and closing tag.
225 2011-08-09T21:55:10 <brunomartin> the closing tag </object> only appears with creole content, not with html or rst. How could I set it to always use de closing tag </object>, never the self-closing <object ... />? I think this is the issue.. the self closing <object ... /> is not accepted on html 5.
226 2011-08-09T21:56:33 <ThomasWaldmann> show me all from <object> to </object>
227 2011-08-09T21:57:23 <dreimark> re
228 2011-08-09T21:58:16 <ThomasWaldmann> or just put it into the issue with some info about how you got it
229 2011-08-09T22:04:02 <brunomartin> well, when it uses the closing tag </object>, all works fine, doesn't matter what goes from <object> to </object>...
230 2011-08-09T22:04:32 <ThomasWaldmann> the question was: what is between those tags?
231 2011-08-09T22:06:52 <brunomartin> if I use {{http://localhost:8080/logo}} with creole or MoinMoin, it puts the address http://localhost:8080/logo between then... this roger's test illustrate that: http://test.moinmo.in/ObjectTagBug-OverlayPatch
232 2011-08-09T22:21:19 <ThomasWaldmann> brunomartin: fix the rst_in so it emits the item name as text (inside object)
233 2011-08-09T22:29:52 <brunomartin> ThomasWaldmann: ok... may I try do the same for html_in?
234 2011-08-09T22:33:24 <ThomasWaldmann> first try rst_in
235 2011-08-09T22:34:32 <brunomartin> ok
236 2011-08-09T22:43:32 <brunomartin> ThomasWaldmann: I think this is a conceptual error... reading some stuff, seens that html5 accept self closing tags just for void elements, witch is not the case. So, using <object .../> its just like <object> in html5, but emitting the item name as text inside object should work, and solves my problem.
237 2011-08-09T22:44:35 <brunomartin> ThomasWaldmann: so I will do this now, and put feedback on that issue... Thanks!
238 2011-08-09T22:54:05 <ThomasWaldmann> yes, but i didn't find where this goes wrong
239 2011-08-09T23:08:40 <brunomartin> ThomasWaldmann: well, the tests expect self closing form, but it wont work for object tag in html5
240 2011-08-09T23:11:02 <ThomasWaldmann> are you talking of html_out output?
241 2011-08-09T23:33:31 <brunomartin> ThomasWaldmann: yes...
242 2011-08-09T23:38:04 <ThomasWaldmann> if the test is wrong, fix it
243 2011-08-09T23:38:16 <ThomasWaldmann> but make sure you don't confuse it with xml
244 2011-08-09T23:43:24 <brunomartin> ok...
