1 2011-07-09T00:07:12 <RogerHaase> ThomasWaldmann: dreimark: I created a code review for the changes to the comments button: http://codereview.appspot.com/4681046/
2 2011-07-09T00:10:25 <dreimark> RogerHaase: i read that tom, i am currently not able to find my own selfmade probs
3 2011-07-09T00:10:50 <dreimark> better i sleep soon
4 2011-07-09T00:11:58 <RogerHaase> dreimark: OK, I have had non-stop interruptions these past few days
5 2011-07-09T00:15:14 <ThomasWaldmann> hi RogerHaase
6 2011-07-09T00:15:43 <RogerHaase> ThomasWaldmann: moin :-)
7 2011-07-09T00:25:04 <ThomasWaldmann> RogerHaase: review done, only a minor comment
8 2011-07-09T00:27:05 <RogerHaase> ThomasWaldmann: thx, will wait for dreimark tomorrow and push if there are no other issues.
9 2011-07-09T00:32:06 <RogerHaase> gtg
10 2011-07-09T00:32:12 *** RogerHaase
11 2011-07-09T00:36:47 *** raignarok
12 2011-07-09T00:58:02 *** brunomartin
13 2011-07-09T00:58:15 *** brunomartin
14 2011-07-09T00:59:11 *** sinha
15 2011-07-09T01:36:05 *** MattMaker
16 2011-07-09T05:51:20 *** m4k3r
17 2011-07-09T07:30:18 *** m4k3r
18 2011-07-09T09:31:06 <Marchael> moin
19 2011-07-09T10:07:51 *** raignarok
20 2011-07-09T10:09:20 <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> default * 282:d28a3434b40c 2.0/ (4 files in 2 dirs): use XStatic-svg-edit-moin==2011.07.07.1, require it via setup.py, remove it from quickinstall scripts
21 2011-07-09T10:23:52 *** raignarok
22 2011-07-09T10:25:36 <dreimark> ThomasWaldmann: there it is ^
23 2011-07-09T10:56:43 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4675066/diff/4/MoinMoin/storage/backends/indexing.py
24 2011-07-09T10:56:43 <Marchael> I try to write code as you suggested, but when I try to convert dom tree to text I get this traceback http://paste.pocoo.org/show/434171/
25 2011-07-09T10:57:16 <Marchael> what I'm doing wrong?
26 2011-07-09T11:08:07 <dreimark> Marchael: try a page without a href to convert
27 2011-07-09T11:14:58 <Marchael> dreimark: but how I can avoid href convertion?
28 2011-07-09T11:17:33 <Marchael> hm, ok
29 2011-07-09T11:20:19 <Marchael> dreimark: yes, without href it's working
30 2011-07-09T11:21:50 *** m4k3r
31 2011-07-09T11:22:40 *** m4k3r
32 2011-07-09T11:27:55 <Marchael> but what I should do with commented code? ignore?
33 2011-07-09T11:30:21 *** sinha
34 2011-07-09T11:32:58 <Marchael> ThomasWaldmann: patchset 4
35 2011-07-09T11:33:02 <Marchael> http://codereview.appspot.com/4675066/
36 2011-07-09T11:47:07 <ThomasWaldmann> moin
37 2011-07-09T11:50:06 *** m4k3r
38 2011-07-09T11:51:15 *** m4k3r
39 2011-07-09T11:53:56 <Marchael> ThomasWaldmann: why you reviewed patchset 3?
40 2011-07-09T12:02:46 <ThomasWaldmann> because iirc i did not yet
41 2011-07-09T12:09:03 <ThomasWaldmann> Marchael: if moinwiki_out does not work for you, you can also try creole_out
42 2011-07-09T12:09:35 <ThomasWaldmann> btw, I'll be away soon for some hours
43 2011-07-09T12:11:53 <Marchael> ThomasWaldmann: but what about input markups? I should place "if" in add_rev_whoosh to check markup and get appropriate *_in.py?
44 2011-07-09T12:13:24 <ThomasWaldmann> you still didn't read Item code
45 2011-07-09T12:13:41 <ThomasWaldmann> that is already done for you, if you use it correctly
46 2011-07-09T12:14:07 <Marchael> ok
47 2011-07-09T12:19:09 <ThomasWaldmann> dreimark: is there some reason why svgedit is still downloaded in quickinstall?
48 2011-07-09T12:24:51 * ThomasWaldmann kills it, looks like it was forgotten
49 2011-07-09T12:29:43 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 283:da04ea3f5817 2.0/quickinstall: remove download of svgedit from quickinstall, it is handled via XStatic package now
50 2011-07-09T12:29:44 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 284:5afd19296f66 2.0/ (quickinstall quickinstall.bat): removed unneeded stuff from quickinstall*
51 2011-07-09T12:29:46 <dreimark> thx, missed that . readded it because some problems yesterday
52 2011-07-09T12:31:12 <dreimark> brb 1h
53 2011-07-09T12:38:50 *** m4k3r
54 2011-07-09T12:58:15 <ThomasWaldmann> bbl
55 2011-07-09T13:12:15 <Marchael> hm, but there isn't creole_out
56 2011-07-09T13:13:55 <dreimark> Marchael: try rst_out
57 2011-07-09T13:16:25 <Marchael> dreimark: hm, I can try any other *_out? How is it affect on result?
58 2011-07-09T13:19:09 <Marchael> Althought, even with moinwiki_out content will have markup
59 2011-07-09T13:19:49 <Marchael> so I don't see differerence between {moinwiki,creole,rst} here
60 2011-07-09T13:36:50 <Marchael> dreimark: I try other *_out converters, but moinwiki generates lesser markup tags]
61 2011-07-09T13:38:03 <Marchael> may be try - except to just ignore "href" problem?
62 2011-07-09T13:43:38 *** greg_f
63 2011-07-09T13:49:09 <sinha> dreimark: it seems like POST is not allowed for the url /+index
64 2011-07-09T13:49:23 <sinha> where to enable this ? in which file ?
65 2011-07-09T14:06:39 <sinha> okay got it
66 2011-07-09T14:11:46 <Marchael> dreimark: I tried to edit preload document http://localhost:8080/moin, but get this traceback for docbook_out http://paste.pocoo.org/show/434250/
67 2011-07-09T14:11:46 <Marchael> http://paste.pocoo.org/show/434253/ for rst_out
68 2011-07-09T14:39:12 *** m4k3r
69 2011-07-09T14:50:07 <dreimark> Marchael: you should file a bug because of iri problems, this is likliy on all parts using iri
70 2011-07-09T14:51:29 <Marchael> you sure? can you help fill this bug? because I know nothing about iri
71 2011-07-09T14:53:33 <dreimark> do you have a unit test for the stuff you are trying?
72 2011-07-09T14:54:15 <Marchael> you mean convertors?
73 2011-07-09T14:55:08 <Marchael> I could add test for that, but why?
74 2011-07-09T15:01:07 <dreimark> Marchael: for your code
75 2011-07-09T15:01:25 <dreimark> if you know the model you want to use for coding you usually write first the unit test
76 2011-07-09T15:01:28 <dreimark> then the code
77 2011-07-09T15:01:47 <dreimark> then you verify that by the test you have done what you wanted to do
78 2011-07-09T15:02:25 <dreimark> thats the meanting of Test driven development
79 2011-07-09T15:03:11 <Marchael> dreimark: for writing test I need to know input\output data format, i know input, but output unknown
80 2011-07-09T15:11:40 <dreimark> bbl
81 2011-07-09T15:32:20 *** grzywacz
82 2011-07-09T15:32:20 *** grzywacz
83 2011-07-09T15:40:22 *** m4k3r
84 2011-07-09T15:57:53 <Marchael> patchset 5 http://codereview.appspot.com/4675066/
85 2011-07-09T15:58:08 <Marchael> dreimark: i add temporary fix for IRI in moinwiki_out
86 2011-07-09T15:58:24 <Marchael> *I added
87 2011-07-09T15:59:37 <Marchael> now I have converting "Markup -> DOM, DOM -> text/x.moin.wiki"
88 2011-07-09T15:59:43 <Marchael> *convertion
89 2011-07-09T16:02:32 <ThomasWaldmann> re
90 2011-07-09T16:24:47 *** greg_f
91 2011-07-09T16:34:29 <Marchael> ThomasWaldmann: I answered
92 2011-07-09T16:38:07 <ThomasWaldmann> no, you didn't
93 2011-07-09T16:38:39 <ThomasWaldmann> if you give contenttype, you should know what it's good for
94 2011-07-09T16:41:14 <ThomasWaldmann> and (after reading the code), it seems to be good only for the case when item/revision does not exist or does not have contenttype data
95 2011-07-09T16:41:23 <Marchael> > contenttype = rev.get(CONTENTTYPE) or contenttype
96 2011-07-09T16:41:23 <Marchael> I guess what contenttype doesn't required
97 2011-07-09T16:42:22 <Marchael> create() can give contenttype from revision, so I can don't give it.
98 2011-07-09T16:45:58 <ThomasWaldmann> so, if it is good for nothing, you can leave it away
99 2011-07-09T16:48:51 <Marchael> 398 whoosh accept unicode objects, but I don't know then what output in unicode
100 2011-07-09T16:50:53 <Marchael> ThomasWaldmann: ^
101 2011-07-09T16:52:15 *** sinha
102 2011-07-09T16:53:23 <ThomasWaldmann> if it does accept unicode, why do you encode it?
103 2011-07-09T16:57:03 <Marchael> yes, but I removed encode() in patchset 5
104 2011-07-09T16:57:23 <ThomasWaldmann> and if you are asking yourself what type of object you have, using repr(x) is quite easy
105 2011-07-09T17:04:28 <Marchael> ThomasWaldmann: btw, moin config hasn't CONTENT, may I add this?
106 2011-07-09T17:04:53 <Marchael> CONTENT = "content" may be good
107 2011-07-09T17:09:58 <Marchael> ThomasWaldmann: this is example of document what will be stored in indexes http://paste.pocoo.org/show/434368/
108 2011-07-09T17:12:50 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4675066 patchset 5
109 2011-07-09T17:22:55 <Marchael> bbl
110 2011-07-09T17:37:56 <ThomasWaldmann> CONTENT is data, not metadata, so you only need that for whoosh (not for moin storage), same as "rev_no", etc.
111 2011-07-09T18:08:44 <dreimark> may be we sould only allow to add urls by iterwiki mapping
112 2011-07-09T18:09:16 <dreimark> or someone has to approve external urls
113 2011-07-09T18:09:32 <dreimark> before they become links
114 2011-07-09T19:06:03 <dreimark> http://www.jslint.com/ isn't very happy with common.js
115 2011-07-09T19:10:46 <dreimark> that remebers me about jonathan js comparison talk
116 2011-07-09T19:18:17 <dreimark> we have many lines where Expected '===' and instead saw '=='
117 2011-07-09T19:18:40 <dreimark> other errors sound like a pep8 a like check
118 2011-07-09T19:18:59 <dreimark> e.g. Unexpected space between 'postError' and ')'.
119 2011-07-09T19:19:54 <ThomasWaldmann> dreimark: do you have time later to change xstatic stuff to 0.0.2?
120 2011-07-09T19:22:05 <dreimark> I guess yes, it depends a little bit how much word support i have to give later
121 2011-07-09T19:23:48 <dreimark> ThomasWaldmann: ^
122 2011-07-09T19:24:20 <dreimark> i add an issue for jslint and our js stuff
123 2011-07-09T19:35:11 *** m4k3r
124 2011-07-09T20:34:36 <Marchael> re
125 2011-07-09T20:34:38 <Marchael> ThomasWaldmann: please review http://codereview.appspot.com/4675066 Patchset 7
126 2011-07-09T20:34:38 <Marchael> but get this traceback when try to run script http://paste.pocoo.org/show/434496/
127 2011-07-09T20:36:12 <dreimark> Marchael: does the wiki itselfs run?
128 2011-07-09T20:36:29 <Marchael> yes
129 2011-07-09T20:40:12 <Marchael> but when at moin runtime I can add content without problems
130 2011-07-09T20:40:28 <Marchael> s/when//
131 2011-07-09T20:43:22 <Marchael> may be it happends because storage doesn't initialized at this time?
132 2011-07-09T21:01:42 <Marchael> dreimark: could you give me a hint, what reason may call this traceback?
133 2011-07-09T21:03:12 *** raignarok
134 2011-07-09T21:10:48 *** sinha
135 2011-07-09T21:11:32 <dreimark> Marchael: i am busy with completly different stuff, i guess it related to the storage object you currently have
136 2011-07-09T21:13:01 <dreimark> I have not looked into your complete script, but at least http://codereview.appspot.com/4675066
137 2011-07-09T21:13:16 <dreimark> this works for the cli script for creating an item
138 2011-07-09T21:13:31 <dreimark> oops
139 2011-07-09T21:13:39 <dreimark> http://hg.moinmo.in/moin/2.0/file/5afd19296f66/MoinMoin/script/maint/create_item.py#l33
140 2011-07-09T21:13:45 <dreimark> i meant that urls
141 2011-07-09T21:14:29 <Marchael> thx! I look at this
142 2011-07-09T21:22:33 * ThomasWaldmann uploaded xstatic 0.0.2
143 2011-07-09T21:26:37 * ThomasWaldmann uploaded xstatic-jquery 1.6.1.4
144 2011-07-09T21:28:11 <ThomasWaldmann> dreimark: can you adapt your stuff like https://bitbucket.org/thomaswaldmann/xstatic-jquery/changeset/fb3603f42c3a
145 2011-07-09T21:33:48 <dreimark> ThomasWaldmann: yes
146 2011-07-09T21:35:33 *** esyr_
147 2011-07-09T21:51:53 * ThomasWaldmann uploaded xstatic-ckeditor 3.6.1.2
148 2011-07-09T22:10:45 * ThomasWaldmann uploaded xstatic-jquery-file-upload 4.4.2
149 2011-07-09T22:11:11 * dreimark needs to change 3 init files (1 is complete now)
150 2011-07-09T22:31:50 <Marchael> ThomasWaldmann: could you review http://codereview.appspot.com/4675066 patchset 8
151 2011-07-09T22:31:50 <Marchael> I can create() item, but having troubles with creating DOM tree http://paste.pocoo.org/show/434589/
152 2011-07-09T22:32:22 <Marchael> why I can't access to "clock"?
153 2011-07-09T22:32:34 * ThomasWaldmann uploaded xstatic-svgweb 2011.2.3.2
154 2011-07-09T22:41:15 * dreimark uploads XStatic-MathJax-1.1.2
155 2011-07-09T22:43:12 * dreimark uploads XStatic-TWikiDraw-moin-2004.10.2
156 2011-07-09T22:44:07 * dreimark uploads XStatic-AnyWikiDraw-0.14.2.
157 2011-07-09T22:45:11 * dreimark uploads XStatic-svg-edit-moin-2011.07.07.2
158 2011-07-09T22:45:23 <dreimark> ok now lets push the changes
159 2011-07-09T22:50:04 <dreimark> nice XStatic peak on pypi
160 2011-07-09T22:53:29 <Marchael> flaskg.clock setting up in before_wiki() in app.py, so seems like I should defin it before
161 2011-07-09T22:53:50 <Marchael> in create_app_ext() e.g.
162 2011-07-09T22:59:08 <Marchael> is there any way to set up flaskg.clock in create_app_ext()?
163 2011-07-09T23:02:58 <ThomasWaldmann> dreimark: ok, so we have everything?
164 2011-07-09T23:04:22 <dreimark> looks like
165 2011-07-09T23:05:14 <dreimark> Marchael: why do you need .clock?
166 2011-07-09T23:05:14 * ThomasWaldmann tries locally
167 2011-07-09T23:05:29 <ThomasWaldmann> File "/home/tw/w/moin-2.0/env/build/xstatic-mathjax/setup.py", line 10, in <module>
168 2011-07-09T23:05:32 <ThomasWaldmann> name=xs.PACKAGE_NAME,
169 2011-07-09T23:05:39 <Marchael> dreimark: Item class using clock
170 2011-07-09T23:05:50 <Marchael> I don't
171 2011-07-09T23:06:51 <dreimark> arg
172 2011-07-09T23:07:41 <dreimark> then i have all wrong
173 2011-07-09T23:08:41 <sinha> dreimark: i am getting some issues in this contenttype filtering and startswith integration, as when contenttypes filter is used, we get some filtered items on page and now when user clicks on top list of characters to filter with startswith param, that time that contenttypes are not getting posted, and i have to use the default one, so things get disturbed.
174 2011-07-09T23:08:43 <Marchael> heh, working
175 2011-07-09T23:09:40 <dreimark> ThomasWaldmann: what is wrong, same line in jquery example?
176 2011-07-09T23:10:33 <dreimark> I have tested all in a new env
177 2011-07-09T23:10:39 <ThomasWaldmann> dreimark: ignore, it happens if there is old stuff in env
178 2011-07-09T23:13:04 <dreimark> sinha: this is an order problem, first startswith, then contentype filter
179 2011-07-09T23:13:41 <dreimark> Marchael: why was it not working?
180 2011-07-09T23:14:16 <Marchael> because flaskg unreacheble in create_app_ext()
181 2011-07-09T23:14:30 <Marchael> i just try .. except those lines :P
182 2011-07-09T23:14:43 <Marchael> lines with timers
183 2011-07-09T23:16:44 <sinha> dreimark: okay, then i guess this flow is fine, so whenever startswith is set , contenttypes is reset to default and whenever contenttypes is posted, startswith is removed
184 2011-07-09T23:17:03 <sinha> ah no startswith will be intact
185 2011-07-09T23:17:44 <dreimark> no, i mean it that way you build the startwith list and filter then
186 2011-07-09T23:18:52 <dreimark> if one changes from A to B he likly don't want to select interesting content types again
187 2011-07-09T23:25:20 * ThomasWaldmann tries updated quickinstall
188 2011-07-09T23:25:43 <sinha> yeah but when i build startswith with new prefix, that time filter isnt getting posted
189 2011-07-09T23:25:55 <sinha> i have to use the default filters
190 2011-07-09T23:28:13 <dreimark> yes, thats ok
191 2011-07-09T23:33:04 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 285:865c3780d091 2.0/ (quickinstall quickinstall.bat setup.py wikiconfig.py): upgrade to XStatic 0.0.2 and packages made for it
192 2011-07-09T23:36:14 <ThomasWaldmann> seems to work :)
193 2011-07-09T23:37:50 * dreimark tries
194 2011-07-09T23:38:46 <Marchael> finally
195 2011-07-09T23:39:07 <Marchael> content now adding to indexes at build and update
196 2011-07-09T23:56:16 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 286:f0288e2a7d09 2.0/docs/admin/ (install.rst requirements.rst): update docs: now every dependency is installed via setup.py, no wget any more
