1 2011-06-29T00:53:02 *** grzywacz
2 2011-06-29T05:24:29 <Marchael> moin
3 2011-06-29T05:25:45 <Marchael> how script can check what moin is running or not?
4 2011-06-29T06:15:05 *** sinha
5 2011-06-29T06:19:41 <Marchael> ThomasWaldmann: please review http://codereview.appspot.com/4650059
6 2011-06-29T06:26:31 *** sinha
7 2011-06-29T06:26:55 *** sinha
8 2011-06-29T06:39:02 *** sinha
9 2011-06-29T06:39:16 *** sinha
10 2011-06-29T07:06:38 <Marchael> ThomasWaldmann: you could also review this doc http://codereview.appspot.com/4650059/patch/5001/5002
11 2011-06-29T07:53:41 <dreimark> moin
12 2011-06-29T07:55:06 *** hardy89
13 2011-06-29T07:58:13 <sinha> dreimark: moin
14 2011-06-29T07:58:52 <sinha> dreimark: For that global index i started in this direction, http://codereview.appspot.com/4661057 , should i keep moving ?
15 2011-06-29T08:08:05 <dreimark> sinha: i look in a few mins
16 2011-06-29T08:08:28 <sinha> okay
17 2011-06-29T08:23:27 <Marchael> dreimark: thx
18 2011-06-29T08:35:16 <dreimark> sinha: please pull from 2.0 always before you commit something new to your repo
19 2011-06-29T08:36:24 <sinha> i did in last commit, forget to do yesterday, will keep this in mind afterwards
20 2011-06-29T08:37:14 <dreimark> thx, I sometime try on other platforms
21 2011-06-29T08:40:56 <sinha> dreimark: that prefix is actually the alphabets
22 2011-06-29T08:41:56 <sinha> dreimark: i mean for larger wikis, rather than alphabets ( A, B, C ..) we can also have list of prefix like "Aa, Ab, Ac .. like this "
23 2011-06-29T08:43:30 <dreimark> ok, the name of that var should be a better one
24 2011-06-29T08:44:18 <sinha> dreimark: do you have any more comment on the approach ?
25 2011-06-29T08:44:27 <dreimark> or it needs a docstring which explains it
26 2011-06-29T08:44:41 <sinha> dreimark: i mean is it ok to edit the flat_index function itself ?
27 2011-06-29T08:44:47 <dreimark> soon, wanted to look physical on the patch
28 2011-06-29T08:45:05 <dreimark> thats why I have downloaded the repo again and run into the flask problem
29 2011-06-29T08:45:55 <sinha> dreimark: as of now, just try editing the url as /+index/?prefix=a , will add the bar soon
30 2011-06-29T08:53:24 <dreimark> startswith=a describes better what it is selecting.
31 2011-06-29T08:53:49 <sinha> okay
32 2011-06-29T08:54:04 <dreimark> i have created an item "aaaa"
33 2011-06-29T08:54:06 <ThomasWaldmann> moin
34 2011-06-29T08:54:13 <ThomasWaldmann> Marchael: review done
35 2011-06-29T08:55:45 <dreimark> sinha: ok, selecting early is a good point
36 2011-06-29T08:56:05 <dreimark> may be you also need endswith
37 2011-06-29T08:56:54 <sinha> dreimark: for input 'a', select startswith("a") and endswith("a") ?
38 2011-06-29T08:57:43 <dreimark> not for that case
39 2011-06-29T08:58:09 <dreimark> ignore it for now
40 2011-06-29T08:58:56 <dreimark> it is a question if one wants A-C, D-F, E
41 2011-06-29T09:01:08 <dreimark> think about that while implementing the 1.x compatible case
42 2011-06-29T09:01:24 <sinha> okay, for these cases we can use regex
43 2011-06-29T09:01:54 <dreimark> yay, it should be on default a regex
44 2011-06-29T09:02:46 <dreimark> so it is more like a filter parameter (don't overwrite that builtin)
45 2011-06-29T09:02:46 <sinha> so how should i start taking the input ?
46 2011-06-29T09:03:40 <dreimark> r:"a.*"
47 2011-06-29T09:05:04 <sinha> where to use this filter parameter, in flat_index itself ?
48 2011-06-29T09:05:15 <sinha> or in views
49 2011-06-29T09:05:15 <dreimark> instead of your prefix parameter
50 2011-06-29T09:06:29 <sinha> you mean first create a regex for the input and then match each relname
51 2011-06-29T09:09:26 <dreimark> you can also first match all in the list and then get the rest of it. the list is then shorter
52 2011-06-29T09:10:02 <Marchael> ThomasWaldmann: please, read my comments
53 2011-06-29T09:10:04 <dreimark> otherwise you need to feed always thousand entries to the loop
54 2011-06-29T09:14:43 <dreimark> sinha: look at get_index
55 2011-06-29T09:15:12 <sinha> yes i was looking that only :)
56 2011-06-29T09:16:53 <sinha> one thing i didn't get there, why u"" is used more than once, i mean first prefix is declared as u'' and then re also has u'' in start ?
57 2011-06-29T09:16:58 <sinha> dreimark: ^
58 2011-06-29T09:19:00 <dreimark> that is described in the comment before
59 2011-06-29T09:19:18 <dreimark> the idea behind that is that everything is a subitem
60 2011-06-29T09:19:28 <dreimark> so Example/a
61 2011-06-29T09:19:36 <dreimark> has Example as prefix
62 2011-06-29T09:19:49 <sinha> dreimark: and also can't we just call get_index() with a prefix from flat_index
63 2011-06-29T09:19:57 <sinha> makes life easier
64 2011-06-29T09:20:13 <sinha> ah, it uses prefix in different manner
65 2011-06-29T09:20:44 <dreimark> that's the point
66 2011-06-29T09:20:59 <sinha> what if we can tweak it a little bit ?
67 2011-06-29T09:21:26 <sinha> pass an additional param ?
68 2011-06-29T09:21:57 *** greg_f
69 2011-06-29T09:22:19 <dreimark> look at testIndex and don't break it, if you add an additional parameter also write a test for that
70 2011-06-29T09:22:31 <dreimark> this is a quite important method
71 2011-06-29T09:23:18 <dreimark> that are all rules
72 2011-06-29T09:23:54 <dreimark> bbl
73 2011-06-29T09:27:37 <ThomasWaldmann> Marchael: review done
74 2011-06-29T10:08:02 *** mkerrin
75 2011-06-29T10:24:33 *** m4k3r
76 2011-06-29T10:34:59 *** hardy89
77 2011-06-29T11:36:48 <Marchael> oh, seems like refactoring done
78 2011-06-29T11:39:47 <Marchael> ThomasWaldmann: please, review http://codereview.appspot.com/4654074
79 2011-06-29T11:40:56 <Marchael> now that stuff can be calling by moin rebuild_indexes --for all-revs --action clean --path indexdir
80 2011-06-29T12:07:47 *** sinha
81 2011-06-29T12:08:03 *** sinha
82 2011-06-29T12:43:54 *** pkumar
83 2011-06-29T13:06:31 <Marchael> ThomasWaldmann: could you review my code before irc meeteing starts?
84 2011-06-29T13:10:51 <ThomasWaldmann> Marchael: are you reading what I am writing? sometimes it seems to me you are not.
85 2011-06-29T13:12:00 <ThomasWaldmann> and I'ld like to suggest you first complete stuff you already got as feedback before asking for next review
86 2011-06-29T13:14:57 <Marchael> ThomasWaldmann: hm, but I rewrited most part of building script
87 2011-06-29T13:15:12 <Marchael> and of course I read your comments befre do that
88 2011-06-29T13:15:25 <Marchael> *before
89 2011-06-29T13:15:29 <ThomasWaldmann> you just suggested using --path option and I already told you that it would be better to have all index_dir stuff in config
90 2011-06-29T13:15:43 <ThomasWaldmann> e.g. index_dir_tmp if one wants it flexible
91 2011-06-29T13:29:33 <ThomasWaldmann> Marchael: review done
92 2011-06-29T13:54:25 *** pkumar
93 2011-06-29T13:57:52 <Marchael> ThomasWaldmann: then may be we need first build indexes in tmp_index_dir and then move it to index_dir?
94 2011-06-29T13:58:52 <Marchael> btw, --action clean then become useless
95 2011-06-29T13:59:10 <Marchael> (because we always building from scratch)
96 2011-06-29T14:16:35 *** xorAxAx
97 2011-06-29T14:17:26 *** [bsx]
98 2011-06-29T14:17:33 *** xorAxAx
99 2011-06-29T14:18:16 *** TheSheep
100 2011-06-29T14:18:21 *** TheSheep
101 2011-06-29T14:20:10 *** [bsx]
102 2011-06-29T14:23:40 <ThomasWaldmann> (13:58) < Marchael> ThomasWaldmann: then may be we need first build indexes in tmp_index_dir and then move it to index_dir?
103 2011-06-29T14:23:57 <ThomasWaldmann> did we ever talk about something else?
104 2011-06-29T14:24:31 <ThomasWaldmann> and it was index_dir_tmp, not tmp_index_dir. this is important for sort order in docs / index of docs.
105 2011-06-29T14:25:01 <ThomasWaldmann> and no, we don't always build from scratch
106 2011-06-29T14:25:20 <ThomasWaldmann> Marchael: ^^
107 2011-06-29T14:26:02 <Marchael> but why? If admin want's to rebuild, probably he doesn't need old indexes
108 2011-06-29T14:26:18 <Marchael> *wants
109 2011-06-29T14:30:45 <Marchael> I mean indexes in index_dir_tmp
110 2011-06-29T14:33:48 <ThomasWaldmann> you need a not-from-scratch index build to support wiki farms
111 2011-06-29T14:34:24 <ThomasWaldmann> so e.g. you have 3 wikis and for all of them we do a full index build to the same index_dir(_tmp)
112 2011-06-29T14:37:20 <ThomasWaldmann> later, on the wiki ui, you can search for content in any of these wikis and it'll have interwiki links in the search results
113 2011-06-29T14:38:24 <Marchael> ok
114 2011-06-29T14:39:05 <Marchael> it's a bit problem to move needed indexes
115 2011-06-29T14:39:24 <ThomasWaldmann> because you do not know their file names?
116 2011-06-29T14:39:28 <Marchael> yes
117 2011-06-29T14:40:00 <Marchael> and I think what better: try reading whoosh src to know their names, or use stuff like ls | grep
118 2011-06-29T14:42:15 <CIA-45> pkumar <contactprashantat@gmail.com> * 1476764d3857 r291 pytest2/MoinMoin/util/_tests/test_filesys.py: added test_dir_exist to raise error if dir already exist in util/test_filesys.py
119 2011-06-29T14:42:15 <CIA-45> pkumar <contactprashantat@gmail.com> * 837d949a4539 r292 pytest2/MoinMoin/util/_tests/ (test_mime.py test_filesys.py): added test for Type.__repr__ in test_mime
120 2011-06-29T14:42:16 <CIA-45> pkumar <contactprashantat@gmail.com> * c86e1f677ebc r293 pytest2/MoinMoin/util/_tests/test_version.py: added test for unexpected version string format in util/test_version.py
121 2011-06-29T14:42:16 <CIA-45> pkumar <contactprashantat@gmail.com> * af0b6a1c3764 r294 pytest2/MoinMoin/util/_tests/test_lock.py: added class TestWrilteLock for lock.WriteLock in util/test_lock.py
122 2011-06-29T14:42:16 <CIA-45> pkumar <contactprashantat@gmail.com> * e5c573426595 r295 pytest2/MoinMoin/util/_tests/test_lock.py: TestReadLock added for lock.ReadLock in util.test_lock
123 2011-06-29T14:42:17 <CIA-45> pkumar <contactprashantat@gmail.com> * b2366bb97894 r296 pytest2/MoinMoin/util/_tests/test_lock.py: added test_haveReadLock to TestWriteLock in test_lock - check if a readlock already exist
124 2011-06-29T14:42:17 <CIA-45> pkumar <contactprashantat@gmail.com> * f67e58bf2f3e r297 pytest2/MoinMoin/util/_tests/test_lock.py: added test for error in test_writelock_acquire and test_haveReadLocks improved for different conditions
125 2011-06-29T14:42:17 <CIA-45> pkumar <contactprashantat@gmail.com> * cc24cc284cde r298 pytest2/MoinMoin/util/_tests/test_lock.py: should raise RuntimeError if a lock is already there in test_readlock_acquire.
126 2011-06-29T14:42:33 <CIA-45> pkumar <contactprashantat@gmail.com> * 7fe35e3453a6 r299 pytest2/MoinMoin/util/_tests/test_lock.py: read_lock.acquire and write_lock.acquire should return True.
127 2011-06-29T14:46:16 <ThomasWaldmann> Marchael: for the tmp dir, you start from a clean dir somehow
128 2011-06-29T14:46:22 <Marchael> ThomasWaldmann: I found Whoosh.storage.list()
129 2011-06-29T14:46:29 <ThomasWaldmann> then you build one or multiple indexes there
130 2011-06-29T14:46:47 <ThomasWaldmann> and then you just move all files you have there over the files in index_dir
131 2011-06-29T14:47:16 <ThomasWaldmann> i didn't find anything helpful in whoosh
132 2011-06-29T14:47:44 <ThomasWaldmann> we maybe should suggest some improvements after you have implemented something working and proven
133 2011-06-29T14:48:25 <ThomasWaldmann> because what we do is not unusual, everybody who has a large index size and some uptime requirement has that problem
134 2011-06-29T14:48:39 <ThomasWaldmann> ok, gtg/bbl
135 2011-06-29T14:52:19 *** pkumar
136 2011-06-29T14:55:11 *** Marchael
137 2011-06-29T14:57:16 *** Marchael
138 2011-06-29T15:09:16 <xorAxAx> waldi: ?
139 2011-06-29T15:09:49 <xorAxAx> waldi: can you fill in for me?
140 2011-06-29T15:09:58 <xorAxAx> i am too busy to do the meeting today
141 2011-06-29T15:12:35 <waldi> okay
142 2011-06-29T15:12:45 <waldi> is somehow here at all?
143 2011-06-29T15:13:40 <pkumar> waldi, xorAxAx : hi
144 2011-06-29T15:13:53 <waldi> i see pkumar, but miss hardy
145 2011-06-29T15:13:54 <xorAxAx> hi pkumar
146 2011-06-29T15:16:36 <dreimark> hi waldi
147 2011-06-29T15:19:23 <waldi> okay, is there something we have to talk about for the testing projects?
148 2011-06-29T15:19:49 <pkumar> I was working on tests improvement(as mentioned in EP). though I was working on util module, I felt that coverage need to improved a lot
149 2011-06-29T15:20:07 <waldi> it contains a lot of code
150 2011-06-29T15:21:33 <pkumar> I had just an idea if we could divide the work of test improvement in following two parts:
151 2011-06-29T15:21:59 <pkumar> 1> modify/add codes in the current tests
152 2011-06-29T15:22:26 <pkumar> 2> write tests for the files which don't ave any.
153 2011-06-29T15:22:43 <pkumar> what do you suggest?
154 2011-06-29T15:23:48 <pkumar> waldi , dreimark : ^
155 2011-06-29T15:25:16 <dreimark> modify only if you know that the test is broken and not the code
156 2011-06-29T15:25:53 <dreimark> then check coverage of existing tests about what they test
157 2011-06-29T15:26:03 <dreimark> then improve coverage
158 2011-06-29T15:26:24 <pkumar> ok, I did that and working the same way as you said.
159 2011-06-29T15:26:54 <pkumar> dreimark : ^
160 2011-06-29T15:27:14 <dreimark> you also add additional tests which don't have any
161 2011-06-29T15:27:28 <pkumar> ok.
162 2011-06-29T15:27:35 <dreimark> sometimes it is easier to solve a different problem and a blocker disappears then
163 2011-06-29T15:27:53 <dreimark> magically just because brain has some more time
164 2011-06-29T15:28:11 <pkumar> yeah
165 2011-06-29T15:29:08 <dreimark> for some tests it may be difficult to find out if the test lies or not, may be collect them and talk
166 2011-06-29T15:30:35 <pkumar> also, I was wondering about util/test_pysupport. though it has low coverage, 3%
167 2011-06-29T15:31:23 <pkumar> what about the statement :- We don't make any testing for files, assuming that moin package is not broken' in the test
168 2011-06-29T15:31:31 <pkumar> dreimark : ^
169 2011-06-29T15:31:56 <pkumar> does it mean we don't add tests regarding files?
170 2011-06-29T15:32:13 <pkumar> in this test
171 2011-06-29T15:32:14 <pkumar> ?
172 2011-06-29T15:33:36 *** hardy89
173 2011-06-29T15:33:46 <hardy89> moin
174 2011-06-29T15:33:55 <dreimark> pkumar: that tests are based on that you have a MoinMoin package
175 2011-06-29T15:34:11 <waldi> hi hardy89
176 2011-06-29T15:34:14 <waldi> hardy89: you are late
177 2011-06-29T15:34:22 <hardy89> i'm sorry waldi
178 2011-06-29T15:34:28 <hardy89> no electricity == no net
179 2011-06-29T15:34:31 <dreimark> pkumar: if you don't have the tests are pointless
180 2011-06-29T15:34:37 <waldi> hardy89: okay
181 2011-06-29T15:35:16 <hardy89> waldi: did i miss something important?
182 2011-06-29T15:36:15 <hardy89> waldi: have we decided about the work for upcoming week?
183 2011-06-29T15:36:55 <pkumar> dreimark : yeah, I went through the code. isn't it that if we have MoinMoin tests to run, we would be having MoinMoin package?
184 2011-06-29T15:39:33 *** hardy89
185 2011-06-29T15:39:51 *** hardy89
186 2011-06-29T15:40:01 <dreimark> pkumar: you can have a wiki instance with plugins (1.x)
187 2011-06-29T15:40:43 <dreimark> but then however - may be the author of that line can explain it better
188 2011-06-29T15:42:11 <pkumar> dreimark : yeah, got it :)
189 2011-06-29T15:44:06 <hardy89> waldi: have we decided about the work for upcoming week?
190 2011-06-29T15:44:26 <waldi> hardy89: no, we did not
191 2011-06-29T15:46:06 <hardy89> waldi: how can i get a list of the items which are collected when a test is run?
192 2011-06-29T15:46:30 <waldi> hardy89: pytest -h?
193 2011-06-29T15:46:50 <waldi> at least pytest 1 lists it in the command help
194 2011-06-29T15:49:02 <pkumar> shall we decide next week's work?
195 2011-06-29T15:49:09 <pkumar> hardy89 , waldi : ^
196 2011-06-29T15:49:12 <hardy89> sure
197 2011-06-29T15:49:18 <waldi> yes
198 2011-06-29T15:49:56 <pkumar> in my opinion let's work on the first part of the task, i.e. 1> modify/add codes in the current tests
199 2011-06-29T15:50:36 <pkumar> hardy89 : 2> write tests for the files which don't ave an
200 2011-06-29T15:50:42 <pkumar> any*
201 2011-06-29T15:50:58 <pkumar> hardy89 : I mentioned it earlier :)
202 2011-06-29T15:51:19 <hardy89> i'm clear and fine with the 2 part. pls2explain 1 :)
203 2011-06-29T15:51:22 <hardy89> pkumar: ^
204 2011-06-29T15:51:44 <pkumar> so we can also work on improvement of test coverge too.
205 2011-06-29T15:51:47 <pkumar> hardy89 : ^
206 2011-06-29T15:52:15 <hardy89> ok.
207 2011-06-29T15:52:18 <pkumar> you may like to go through logs to view dreimark 's suggestions
208 2011-06-29T15:52:33 <pkumar> about writing tests
209 2011-06-29T15:52:58 <pkumar> hardy89 : ^
210 2011-06-29T15:53:10 <hardy89> pkumar: reading
211 2011-06-29T15:53:49 <pkumar> hardy89 : use coverage tools, add new tests if low coverage and required.
212 2011-06-29T15:54:39 <hardy89> pkumar: coverage tools?
213 2011-06-29T15:55:27 <pkumar> hardy89 : may be use pytest-cov.
214 2011-06-29T15:56:05 <pkumar> hardy89 : you'll need to install that 'pytest-cov'
215 2011-06-29T15:56:34 <pkumar> hardy89 : it is py.test plugin for coverage reporting
216 2011-06-29T15:57:00 <hardy89> yeah got it
217 2011-06-29T15:57:12 <hardy89> thanks :)
218 2011-06-29T15:57:19 <pkumar> np :)
219 2011-06-29T15:58:18 <ThomasWaldmann> dreimark: hardy89: Marchael: pkumar: ronny: sinha: waldi: xorAxAx: official meeting in 2 mins
220 2011-06-29T15:58:26 <pkumar> ok
221 2011-06-29T15:58:34 <hardy89> ThomasWaldmann: all right
222 2011-06-29T15:59:37 <CIA-45> Michael Mayorov <marchael@kb.csu.ru> * c14527438f0d r279 moin-2.0/MoinMoin/script/maint/build_indexes.py:
223 2011-06-29T15:59:37 <CIA-45> Refactoring in build index script:
224 2011-06-29T15:59:37 <CIA-45> CHANGES:
225 2011-06-29T15:59:37 <CIA-45> Indexes build in index_dir_tmp(defined in local config)
226 2011-06-29T15:59:37 <CIA-45> Cleaning base indexes with --action clean
227 2011-06-29T15:59:38 <CIA-45> Moving indexes from index_dir_tmp location to index_dir_tmp(now working for all-revs and latest-revs)
228 2011-06-29T16:00:38 <ThomasWaldmann> ok, welcome everybody to our weekly meeting
229 2011-06-29T16:00:50 * dreimark waves
230 2011-06-29T16:00:50 <ThomasWaldmann> first topic is meeting time, see http://www.doodle.com/srhzaz7h56fmb5nh
231 2011-06-29T16:01:32 <hardy89> hi
232 2011-06-29T16:01:37 <pkumar> present :)
233 2011-06-29T16:01:58 <ThomasWaldmann> it looks like best time is at monday, tuesday, thursday 18:00 german time (utc+2)
234 2011-06-29T16:02:14 <ThomasWaldmann> or friday 1800 + 1900 german time (utc+2)
235 2011-06-29T16:02:52 * dreimark votes for tuesday
236 2011-06-29T16:02:58 <ThomasWaldmann> so any last words about it or shall I just pick one?
237 2011-06-29T16:03:06 <hardy89> you mean 1800 UTC?
238 2011-06-29T16:03:06 <sinha> tuesday
239 2011-06-29T16:03:09 <ThomasWaldmann> tuestday is fine for me also
240 2011-06-29T16:03:18 <pkumar> tuesday/thursday
241 2011-06-29T16:03:29 <ThomasWaldmann> hardy89: 1800 utc+2 == 1600 utc
242 2011-06-29T16:04:03 <sinha> hardy89: its 2100 hrs (IST) ( 9:00 PM)
243 2011-06-29T16:04:10 <ThomasWaldmann> everybody told in the doodle he has time then
244 2011-06-29T16:04:14 <sinha> sry, 2130
245 2011-06-29T16:04:25 <hardy89> sinha: yeah correct
246 2011-06-29T16:04:44 <hardy89> ThomasWaldmann: time is fine. any day you wish to :)
247 2011-06-29T16:04:50 <hardy89> sinha: thanks :)
248 2011-06-29T16:04:54 <dreimark> the time should not be discussed because all of us stated it to be available
249 2011-06-29T16:05:13 <ThomasWaldmann> ok, so it will be tuesday 16:00 UTC starting next tuesday
250 2011-06-29T16:05:26 <pkumar> ok
251 2011-06-29T16:05:33 <pkumar> seems fine
252 2011-06-29T16:05:35 <pkumar> :)
253 2011-06-29T16:05:50 <ThomasWaldmann> sinha: dreimark: can you begin with progress / blockers / plans?
254 2011-06-29T16:06:01 <dreimark> sinha: your staghe
255 2011-06-29T16:06:03 <dreimark> -h
256 2011-06-29T16:06:17 <sinha> LAST:
257 2011-06-29T16:06:17 <sinha> i) Added the paging functionality to item history results, Changeset: https://bitbucket.org/sinha/moin2/changeset/c04d1ca903c7
258 2011-06-29T16:06:17 <sinha> ii) Added the code to take the value for results_per_page from users (in usersettings)
259 2011-06-29T16:06:17 <sinha> iii) Added diff links and replaced contenttype from icons on global history page
260 2011-06-29T16:06:17 <sinha> CURRENT:
261 2011-06-29T16:06:18 <sinha> Working on the alphabetic listing for global indexes.
262 2011-06-29T16:06:18 <sinha> BLOCKER: needs to discuss idea regarding how to keep the frontend, will get to it after meeting.
263 2011-06-29T16:06:47 <sinha> dreimark: pushing the changes in few mins, then we can discuss regarding the frontend part
264 2011-06-29T16:06:58 <dreimark> ok
265 2011-06-29T16:08:00 <sinha> ThomasWaldmann: for item searching, i have made changes to flat_index function itself
266 2011-06-29T16:08:15 <dreimark> we had already some discussions in the morning, i am happy with progress, anyone else feel free to ask
267 2011-06-29T16:08:54 <ThomasWaldmann> sinha: you took some icons from tango, but some of them do not look like from a "mimetype items" collection
268 2011-06-29T16:09:27 <sinha> ThomasWaldmann: which one, i have taken from the mime folder in the icons package
269 2011-06-29T16:09:29 <ThomasWaldmann> is this because there is no such collection? one would think something like that should exist, because file managers also want pretty icons for different mimetypes.
270 2011-06-29T16:10:02 <waldi> no, they want previews
271 2011-06-29T16:10:41 <ThomasWaldmann> sinha: e.g. the movie one rather looks like a search icon http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-06-26 3rd from top
272 2011-06-29T16:11:31 <sinha> ThomasWaldmann: yes i know, but it was there in that mime folder, so i thought to use it
273 2011-06-29T16:11:32 <ThomasWaldmann> waldi: previews are rather expensive to compute and only work for some stuff
274 2011-06-29T16:11:45 <sinha> the lib name was "tango-claroline-1.9"
275 2011-06-29T16:12:11 <sinha> i have taken everything from a web/mime folder inside it
276 2011-06-29T16:12:14 <waldi> ThomasWaldmann: i know. but a file manager that displays previews don't need pretty icons
277 2011-06-29T16:12:29 *** sinha
278 2011-06-29T16:12:46 *** sinha
279 2011-06-29T16:12:57 <sinha> if these are not okay, then i will pick some others
280 2011-06-29T16:13:02 <ThomasWaldmann> sinha: maybe have a look for better alternatives. don't waste much time on it though.
281 2011-06-29T16:13:11 <sinha> sure
282 2011-06-29T16:13:43 <ThomasWaldmann> btw, border is quite a lot in that screenshot
283 2011-06-29T16:14:30 <ThomasWaldmann> http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-06-26 i mean the vspace above portrait and below Movie
284 2011-06-29T16:15:06 <sinha> okay, thats padding
285 2011-06-29T16:15:22 <sinha> i will make it a little bit lesser
286 2011-06-29T16:15:29 <ThomasWaldmann> ok
287 2011-06-29T16:15:40 <dreimark> this makes the centered look and feel
288 2011-06-29T16:16:19 <ThomasWaldmann> maybe also try more verbose comments and longer item names, how they influence layout
289 2011-06-29T16:16:40 <ThomasWaldmann> dreimark: it looks like more vpadding than leftpadding
290 2011-06-29T16:17:03 <sinha> every column has fixed width, so it wont matter with length of content
291 2011-06-29T16:17:18 <ThomasWaldmann> but we can talk more later. anything else for sinha? (ah, ok)
292 2011-06-29T16:18:19 <ThomasWaldmann> thanks sinha/dreimark. marchael, your stage. :)
293 2011-06-29T16:18:27 <Marchael> This week I worked on update index script which currently done, but need some improvements.
294 2011-06-29T16:18:27 <Marchael> Also I submited multi index wrter bug to whoosh issue tracker, and I hope at next release Matt will published ThomasWaldmann's patch
295 2011-06-29T16:18:27 <Marchael> Also I worked on improvement build indexes script, you could see changes in my previous commit.
296 2011-06-29T16:18:27 <Marchael> And documentation for wiki admin, which currently undone but I'm working on it.
297 2011-06-29T16:18:27 <Marchael> Next week I will working on updating indexes at moin runtime, documentation in src, and improvements in scripts
298 2011-06-29T16:18:27 <Marchael> blockers: none
299 2011-06-29T16:19:41 <ThomasWaldmann> questions for Marchael?
300 2011-06-29T16:19:59 <waldi> no
301 2011-06-29T16:21:04 <ThomasWaldmann> Marchael: we really should get finished with that stuff asap.
302 2011-06-29T16:21:08 <dreimark> Marchael: do you have some timings
303 2011-06-29T16:21:21 <dreimark> and what hardware is the base for it
304 2011-06-29T16:21:43 <Marchael> ThomasWaldmann: sure
305 2011-06-29T16:22:06 <Marchael> dreimark: not quite understand your question
306 2011-06-29T16:22:08 <dreimark> are there any timing tests`
307 2011-06-29T16:22:11 <ThomasWaldmann> dreimark: I'll make some bigger xml dump as soon as I have time for it. currently I don't think Marchael has enough data to give useful timings.
308 2011-06-29T16:22:21 <dreimark> ThomasWaldmann: ok
309 2011-06-29T16:22:37 <ThomasWaldmann> and we are not indexing content yet, only metadata.
310 2011-06-29T16:22:45 <Marchael> for 15 documents rebuild script working 20-30 secs
311 2011-06-29T16:22:48 <dreimark> ah, ok
312 2011-06-29T16:22:54 <Marchael> but it's not good for test
313 2011-06-29T16:23:27 <ThomasWaldmann> i think performance measurement will only make sense after multiwriter fix is applied/released
314 2011-06-29T16:23:46 <Marchael> ThomasWaldmann: but for update indexes it is useless
315 2011-06-29T16:23:48 <Marchael> we can
316 2011-06-29T16:24:09 <Marchael> *can't use multiwriter because it can't remove documents by internal id
317 2011-06-29T16:24:22 <ThomasWaldmann> yes, but indexing 1 document shouldn't take ages anyway
318 2011-06-29T16:24:27 <Marchael> althought for building it working quite well
319 2011-06-29T16:25:07 <Marchael> I'll look at BufferedWriter and AsycWriter
320 2011-06-29T16:25:26 <ThomasWaldmann> Marchael: do you have any idea how you could speed up / improve focus?
321 2011-06-29T16:26:13 <Marchael> sorry, but what is focus?
322 2011-06-29T16:26:27 <ThomasWaldmann> concentration on some task
323 2011-06-29T16:27:29 <Marchael> I try to concentrate on task and do it(sometime long), but you are not always answer quickly
324 2011-06-29T16:27:46 <Marchael> but it's normal, I should work on it harder
325 2011-06-29T16:27:49 <ThomasWaldmann> you shouldn't wait for I/O
326 2011-06-29T16:28:19 <ThomasWaldmann> just schedule some other task until I/O unblocks
327 2011-06-29T16:28:30 <Marchael> ok
328 2011-06-29T16:28:57 <ThomasWaldmann> multitasking design principles :)
329 2011-06-29T16:29:31 <ThomasWaldmann> ok, anything else for Marchael?
330 2011-06-29T16:30:37 <ThomasWaldmann> if not, I'ld like to give meeting lead to xoraxax and waldi, because I need to do other stuff now mostly.
331 2011-06-29T16:31:03 <waldi> okay
332 2011-06-29T16:33:00 <waldi> pkumar: your are next
333 2011-06-29T16:33:08 <pkumar> ok
334 2011-06-29T16:33:16 <pkumar> task of this was to improve the tests of MoinMoin.
335 2011-06-29T16:33:17 <pkumar> it can be classified into two main tasks:
336 2011-06-29T16:33:17 <pkumar> 1> add/modify the code in current tests.
337 2011-06-29T16:33:17 <pkumar> 2> add new tests for the files which don't have any.
338 2011-06-29T16:33:17 <pkumar> so, I started with the former task. After discussing with my mentor, I also started to work on the improvement of test coverage.
339 2011-06-29T16:33:18 <pkumar> I worked on the util module, added some tests and now it has improved test coverage.
340 2011-06-29T16:33:20 <pkumar> there are some files with no tests though, which are pulling down the test coverage.
341 2011-06-29T16:33:22 <pkumar> Planning to work on other modules for next week too.
342 2011-06-29T16:33:56 <pkumar> Blockers: nothing as if now.
343 2011-06-29T16:33:57 <pkumar> questions?
344 2011-06-29T16:34:28 <pkumar> will add tasks on EP by today
345 2011-06-29T16:35:30 <waldi> i have no questions right now as we discussed that earlier. anyone else?
346 2011-06-29T16:35:51 * dreimark not
347 2011-06-29T16:36:46 <waldi> thanks pkumar. hardy89 is next
348 2011-06-29T16:36:52 <hardy89> sure
349 2011-06-29T16:36:53 <pkumar> :)
350 2011-06-29T16:37:00 <hardy89> LAST & BLOCKERS
351 2011-06-29T16:37:01 <hardy89> *Redirected the output of gc.collect() to a file.
352 2011-06-29T16:37:01 <hardy89> *With use of gc.DEBUG_SAVEALL and pdb, i now have the list of the objects which is responsible for memory leaks but will now carry it on along-with the project to stick to schedule.
353 2011-06-29T16:37:01 <hardy89> *Worked on storage module and have now fixed few failures.
354 2011-06-29T16:37:15 <hardy89> NEXT
355 2011-06-29T16:37:15 <hardy89> * Will finish storage module in next two/three days.
356 2011-06-29T16:37:15 <hardy89> * Will work on the project which will be decided for further dates on EP by me,pkumar and our mentors.
357 2011-06-29T16:38:04 <dreimark> bold?
358 2011-06-29T16:38:40 <hardy89> accidentally :|
359 2011-06-29T16:38:44 <dreimark> hardy89: can you point to changesets?
360 2011-06-29T16:39:23 <hardy89> sure
361 2011-06-29T16:39:28 <hardy89> https://bitbucket.org/89hardy/pytest_moin2
362 2011-06-29T16:39:59 <waldi> i see none since three weeks
363 2011-06-29T16:40:24 <hardy89> waldi: its there in my repo --> https://bitbucket.org/89hardy/pytest_moin2
364 2011-06-29T16:40:28 <dreimark> in the list there are some from today
365 2011-06-29T16:40:50 <dreimark> hardy89: can you configure your repo that is sends to this channel please
366 2011-06-29T16:41:04 <dreimark> so we get a notification about it
367 2011-06-29T16:41:09 <dreimark> and please merge more often
368 2011-06-29T16:41:59 <hardy89> dreimark: i did all the commits today. worked for the whole week. will do the commits more often from now on.
369 2011-06-29T16:42:46 <waldi> please do at least one commit on all working days
370 2011-06-29T16:43:50 <hardy89> waldi: i'll do it regularly over the weekend rather than doing all of them on one single day from now on :)
371 2011-06-29T16:43:51 <dreimark> hardy89: you need to pull from the main repo more often
372 2011-06-29T16:44:02 <dreimark> may be always before you do a new commit
373 2011-06-29T16:44:30 <hardy89> dreimark: ok. got your point. will sure do it :)
374 2011-06-29T16:45:08 <pkumar> bbl
375 2011-06-29T16:45:35 <hardy89> dreimark: one blocker btw, i'm still not able to make a diary entry of 21st
376 2011-06-29T16:45:49 *** pkumar
377 2011-06-29T16:48:31 <hardy89> waldi: i'll finish off the storage module in upcoming week.
378 2011-06-29T16:48:42 <waldi> okay
379 2011-06-29T16:48:49 <hardy89> waldi: what else should i add with it?
380 2011-06-29T16:49:12 <waldi> help pkumar with utils, it is a lot of work
381 2011-06-29T16:49:43 <waldi> okay. anything else for hardy89?
382 2011-06-29T16:49:51 <hardy89> waldi: i'll help him out
383 2011-06-29T16:50:57 <dreimark> hardy89: how much internet time can you have at a day?
384 2011-06-29T16:51:23 <hardy89> dreimark: time on #moin-dev?
385 2011-06-29T16:56:00 <hardy89> dreimark: ?
386 2011-06-29T16:57:22 *** hardy89
387 2011-06-29T16:57:51 *** hardy89
388 2011-06-29T16:58:08 <hardy89> sry...got dc
389 2011-06-29T16:58:10 <hardy89> dreimark: ?
390 2011-06-29T17:00:01 <waldi> okay. i'm closing the meeting. thank you for your time
391 2011-06-29T17:03:45 *** hardy89
392 2011-06-29T17:10:14 <sinha> dreimark: this is how i implemented it now, http://codereview.appspot.com/4661057/ | As you said that time, now if one wants to see the items having name from a-c, we will just give the param /+index?startsWith=a-c , OR if one want to see items starting with chars a,e,i,o then url will be +index/startsWith=aeio
393 2011-06-29T17:10:26 <sinha> dreimark: Please do comment on this
394 2011-06-29T17:46:07 <dreimark> sinha: sounds nice
395 2011-06-29T17:46:28 <dreimark> but have you tried with non ascii letters too?
396 2011-06-29T17:46:38 <dreimark> try russian or chinese
397 2011-06-29T17:59:29 <dreimark> sinha: reviewed
398 2011-06-29T18:01:20 <Marchael> ThomasWaldmann: please review http://codereview.appspot.com/4654074/diff2/1:7001/MoinMoin/script/maint/build_indexes.py
399 2011-06-29T18:01:58 <Marchael> you can view full version here http://paste.pocoo.org/show/423726/
400 2011-06-29T18:03:18 <sinha> dreimark: you mean just add the item name in russian ?
401 2011-06-29T18:05:08 <dreimark> /+index?startsWith=Ви
402 2011-06-29T18:05:33 <dreimark> or /+index?startsWith=В-З
403 2011-06-29T18:05:52 <sinha> dreimark: i mean for these kind of names, we have to give input in that form only, i mean suppose for МойнМойн, simple english M, isn't working but if i add `М` of Russian it shows
404 2011-06-29T18:05:55 <dreimark> http://master19.moinmo.in/ has lots of pages
405 2011-06-29T18:07:07 <dreimark> http://master19.moinmo.in/TitleIndex
406 2011-06-29T18:07:13 <sinha> i am talking about adding translation to the input which goes with the startsWith param
407 2011-06-29T18:07:26 <dreimark> you have to make a nicer solution than that
408 2011-06-29T18:07:38 <dreimark> no translation please
409 2011-06-29T18:08:03 <dreimark> just think about that people don't have english content in their wiki
410 2011-06-29T18:08:12 <dreimark> they use it completly in their language
411 2011-06-29T18:08:23 <dreimark> and they want an index of their items
412 2011-06-29T18:09:17 <dreimark> so there is no need for a translation
413 2011-06-29T18:09:17 <sinha> yes, so for the startsWith param they will input the alphabets in their language
414 2011-06-29T18:09:51 <dreimark> no, you do that by that script similiar to TitleIndex
415 2011-06-29T18:09:59 <dreimark> look into its source
416 2011-06-29T18:10:44 <sinha> in this titleindex for chinese literals, some unicode is used in href tag
417 2011-06-29T18:10:55 <sinha> or some other encoding
418 2011-06-29T18:11:27 <dreimark> http://hg.moinmo.in/moin/1.9/file/5752497d5b03/MoinMoin/macro/__init__.py#l192
419 2011-06-29T18:12:20 <dreimark> master19 is the wiki for all translated pages
420 2011-06-29T18:12:59 <dreimark> if you select a package for your lang after installing 1.9 you can choose only russian
421 2011-06-29T18:13:21 <dreimark> then you don't have any english page besides LanguageSetup and BadContent
422 2011-06-29T18:13:31 <sinha> okay, i am asking this thing as in this master19 titleindex there is list of alphabets on the top, some english and some others
423 2011-06-29T18:13:43 <sinha> so in russian wiki these alphabets are supposed to be in russian
424 2011-06-29T18:13:48 <dreimark> yes
425 2011-06-29T18:13:49 <sinha> not english alphabets
426 2011-06-29T18:14:05 <dreimark> you get those by collecting first char of all items
427 2011-06-29T18:14:35 <sinha> okay
428 2011-06-29T18:14:38 <dreimark> then by set you know which you need to show
429 2011-06-29T18:15:13 <sinha> and thus when one clicks on any alphabet we can search with that regex, the item which starts with that alphabet
430 2011-06-29T18:15:15 <dreimark> the code links i showed must be separated in code and template and refactored
431 2011-06-29T18:15:26 <dreimark> correct
432 2011-06-29T18:15:51 <sinha> as our regex is compiled with unicode, current code may work
433 2011-06-29T18:16:02 <dreimark> :)
434 2011-06-29T18:17:10 <sinha> so i guess here, the question is whether this range of alphabets would work or not
435 2011-06-29T18:17:25 <sinha> i mean whether a-c kind of things work with chinese/russian
436 2011-06-29T18:17:39 <dreimark> you need the range may be only if you have only few items
437 2011-06-29T18:17:56 <dreimark> so that one can have a different template for that
438 2011-06-29T18:18:17 <dreimark> that is for example intersting for user accounts
439 2011-06-29T18:18:34 <dreimark> not all wikis have more that 20 accounts
440 2011-06-29T18:18:44 <dreimark> s/than/that/
441 2011-06-29T18:18:52 <dreimark> ops
442 2011-06-29T18:18:57 <dreimark> s/that/than
443 2011-06-29T18:19:01 <ThomasWaldmann> Marchael: review done
444 2011-06-29T18:19:16 <sinha> so no need to consider the range thing
445 2011-06-29T18:19:31 <sinha> so how would want the frontend to be
446 2011-06-29T18:19:43 * Marchael looks
447 2011-06-29T18:19:46 <sinha> just similar to this TitleIndex page what you shown
448 2011-06-29T18:20:01 <sinha> where we will put all the distinct first characters of item
449 2011-06-29T18:20:10 <dreimark> sinha: or to WordIndex
450 2011-06-29T18:20:26 <dreimark> ThomasWaldmann: do we want both in 2.0 ?
451 2011-06-29T18:21:39 <dreimark> ok, both make sense they have a different scope
452 2011-06-29T18:21:56 <dreimark> sinha: for now similiar as TitleIndex
453 2011-06-29T18:22:54 <sinha> okay, cool
454 2011-06-29T18:23:06 <sinha> so by default on that page, are we showing all the items
455 2011-06-29T18:23:11 <sinha> or just the indexes
456 2011-06-29T18:23:35 <sinha> and when someone clicks on one of them, we can show item related to it
457 2011-06-29T18:23:58 <dreimark> it also needs pagination
458 2011-06-29T18:24:11 <sinha> yes
459 2011-06-29T18:24:18 <sinha> so by default show all the items
460 2011-06-29T18:24:28 <dreimark> yes
461 2011-06-29T18:25:08 <sinha> okay, and also pagination after when one input is selected ?
462 2011-06-29T18:26:03 <dreimark> yes, if a user don't want pagination he can change the counter in his config
463 2011-06-29T18:27:10 <sinha> and also as currently there is single item per line in index page
464 2011-06-29T18:27:16 <sinha> i am thinking to put 4 there
465 2011-06-29T18:27:26 <sinha> so we will have rows-columns
466 2011-06-29T18:27:34 <sinha> and we can show items in less space
467 2011-06-29T18:27:40 <dreimark> :)
468 2011-06-29T18:27:40 <sinha> what say ?
469 2011-06-29T18:27:44 <dreimark> :):):
470 2011-06-29T18:28:10 <sinha> cool, then i better get started
471 2011-06-29T18:28:13 <dreimark> you may need a glag also to group ungroup with subitems
472 2011-06-29T18:28:23 <dreimark> s/glag/flag/
473 2011-06-29T18:28:33 * dreimark keyboard hates me today
474 2011-06-29T18:28:55 <dreimark> because otherwise you have a/b a/b/c a/b/b
475 2011-06-29T18:29:11 <dreimark> may be it makes sense to show only the major item
476 2011-06-29T18:29:30 <sinha> so in above case the output will be a single 'a'
477 2011-06-29T18:29:34 <dreimark> yes
478 2011-06-29T18:29:46 <sinha> i have some wikis, which shows all the subitems also
479 2011-06-29T18:29:47 <dreimark> and on demand all dependent subitems
480 2011-06-29T18:30:10 <dreimark> i am asking that because we wrote a book by wiki
481 2011-06-29T18:30:27 <dreimark> and the hierarchy can become very complex and long
482 2011-06-29T18:30:53 <sinha> so subitems on demand
483 2011-06-29T18:31:07 <dreimark> make it supress on demand
484 2011-06-29T18:31:15 <ThomasWaldmann> dreimark: maybe no WordIndex for now
485 2011-06-29T18:31:21 <dreimark> sinha: ^
486 2011-06-29T18:31:34 <ThomasWaldmann> that was somehow tied to camelcase word splitting in 1.9
487 2011-06-29T18:31:43 <sinha> okay, gtg | back after dinner
488 2011-06-29T18:33:57 * dreimark too
489 2011-06-29T18:38:35 <Marchael> ThomasWaldmann: I don't find anything related with file moving in MoinMoin.util.filesys.py
490 2011-06-29T18:39:13 <Marchael> copy files is not what I want
491 2011-06-29T18:41:10 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4654074/diff2/7001:11001/MoinMoin/script/maint/build_indexes.py
492 2011-06-29T18:41:37 <Marchael> I don't want remove shutil because it's working :P
493 2011-06-29T18:41:48 <Marchael> *shutil.move()
494 2011-06-29T18:47:13 <Marchael> ThomasWaldmann: for documentation http://codereview.appspot.com/4634111
495 2011-06-29T18:49:34 <Marchael> also, I haven't any task right now, what should I do?
496 2011-06-29T18:52:52 <ThomasWaldmann> you have about 2 months of todo left :P
497 2011-06-29T18:53:58 <ThomasWaldmann> there are also things to think about on EP, docs to read, ...
498 2011-06-29T18:54:33 <Marchael> may be start to work on MoinMoin.storage.backend.indexind?
499 2011-06-29T19:01:26 *** mkerrin
500 2011-06-29T19:03:35 <ThomasWaldmann> Marchael: review done
501 2011-06-29T19:03:57 <ThomasWaldmann> i suggested some rearrangement to make the command structure more consistent
502 2011-06-29T19:04:58 <ThomasWaldmann> one could try to do such stuff right from the beginning, btw.
503 2011-06-29T19:05:40 <ThomasWaldmann> an alternative to moin index --action foo ... could be moin index-foo ...
504 2011-06-29T19:06:18 <ThomasWaldmann> did you run your documented highlevel script already?
505 2011-06-29T19:06:36 <Marchael> yes
506 2011-06-29T19:06:39 <Marchael> I tested it
507 2011-06-29T19:10:14 <ThomasWaldmann> yes, working on index update when saving items would be next
508 2011-06-29T19:10:49 <ThomasWaldmann> you need a plan for that first, though. we are entering multithread multiprocess land now.
509 2011-06-29T19:20:22 <Marchael> ThomasWaldmann: > moin --action update
510 2011-06-29T19:20:22 <Marchael> how can I merge this 2 scripts?
511 2011-06-29T19:20:38 <Marchael> I don't think what I'll be look readable
512 2011-06-29T19:20:53 <Marchael> s/I'll/it/
513 2011-06-29T19:20:57 <Marchael> :)
514 2011-06-29T19:21:31 <Marchael> Althought I can use import for that
515 2011-06-29T19:22:18 <Marchael> ThomasWaldmann: what you think about:
516 2011-06-29T19:22:18 <Marchael> from MoinMoin.script.maint.update_indexes import UpdateIndex
517 2011-06-29T19:22:19 <ThomasWaldmann> you can just have 2 functions
518 2011-06-29T19:22:27 <Marchael> and them use this object
519 2011-06-29T19:22:30 <Marchael> *then
520 2011-06-29T19:23:15 <Marchael> ThomasWaldmann: in one file?
521 2011-06-29T19:23:17 <ThomasWaldmann> you can also do it the other way i suggested, but currently it is way too inconsistent
522 2011-06-29T19:24:32 <Marchael> so I should use import ... ?
523 2011-06-29T19:24:37 <ThomasWaldmann> and if you just use 1 "index" main command, it's not that far fetched to put everything into index.py
524 2011-06-29T19:27:00 <Marchael> ThomasWaldmann: ^
525 2011-06-29T19:27:35 <ThomasWaldmann> i just answered it
526 2011-06-29T19:28:56 <Marchael> %(
527 2011-06-29T19:29:59 <ThomasWaldmann> btw, before you move all the stuff around, I suggest you fix the minor issues first and commit
528 2011-06-29T19:32:19 <Marchael> ok
529 2011-06-29T19:35:15 <ThomasWaldmann> https://bitbucket.org/marchael/moin-2.0/overview < "2 hours left"? :D
530 2011-06-29T19:35:31 <ThomasWaldmann> looks like bb has some tz issues
531 2011-06-29T19:35:57 <Marchael> I commited before meeting :)
532 2011-06-29T19:36:36 <CIA-45> Michael Mayorov <marchael@kb.csu.ru> * 46cda7e03229 r280 moin-2.0/ (3 files in 3 dirs): Minor fixes at build indexes script, add documentation for admin
533 2011-06-29T19:36:36 <CIA-45> Thomas Waldmann <tw AT waldmann-edv DOT de> * 37c117ad8f7e r281 moin-2.0/MoinMoin/apps/__init__.py: add docstring to MoinMoin.apps
534 2011-06-29T19:36:37 <CIA-45> Reimar Bauer <rb.proj AT googlemail DOT com> * 91330de48b9c r282 moin-2.0/MoinMoin/ (items/__init__.py templates/modify_svg-edit.html): items: implemented 2.6 r:2031 alpha of svg-edit using a save extension for doing a single post for svg and png data.
535 2011-06-29T19:36:38 <CIA-45> Thomas Waldmann <tw AT waldmann-edv DOT de> * 76a4e3cc8705 r283 moin-2.0/MoinMoin/ (6 files in 6 dirs):
536 2011-06-29T19:36:38 <CIA-45> add +download view for just downloading a revision with forced content-disposition: attachment
537 2011-06-29T19:36:38 <CIA-45> minor code cleanups, removed MimeType.content_disposition as it did not match send_file api,
538 2011-06-29T19:36:41 <CIA-45> replaced it by a as_attachment method.
539 2011-06-29T19:36:41 <CIA-45> removed duplicate get_item list entry.
540 2011-06-29T19:36:41 <CIA-45> removed unused content_disposition argument from wikiutil.file_headers.
541 2011-06-29T19:36:41 <CIA-45> bsx <bsx+bitbucket@0xcafec0.de> * 02888ad76719 r284 moin-2.0/MoinMoin/items/__init__.py: added exception handling if PIL can't diff the image
542 2011-06-29T19:36:41 <CIA-45> Thomas Waldmann <tw AT waldmann-edv DOT de> * eea3a94a4061 r285 moin-2.0/MoinMoin/ (6 files in 2 dirs):
543 2011-06-29T19:36:41 <CIA-45> refactored calling convention of converters, add rev=n qs argument for Iris (fixes #21)
544 2011-06-29T19:37:00 <CIA-45> Now converters get fed either with the revision (for binary items) or
545 2011-06-29T19:37:00 <CIA-45> the markup lines (for text items).
546 2011-06-29T19:37:00 <CIA-45> Converters getting revisions (rev=... in qs) now create links to specific revnos.
547 2011-06-29T19:37:00 <CIA-45> Cleaned up some code in the link converter and enabled it to create links to
548 2011-06-29T19:37:00 <CIA-45> specific revisions.
549 2011-06-29T19:37:00 <CIA-45> Thomas Waldmann <tw AT waldmann-edv DOT de> * f6ca659f4a4f r286 moin-2.0/MoinMoin/templates/history.html: use +download for download link in revision history
550 2011-06-29T19:37:01 <CIA-45> Thomas Waldmann <tw AT waldmann-edv DOT de> * 50cc68af8874 r287 moin-2.0/MoinMoin/templates/ (base.html layout.html show.html):
551 2011-06-29T19:37:01 <CIA-45> modify templates to not use 'with context' because this kills pypy's performance
552 2011-06-29T19:37:02 <CIA-45> this is due to use of sys._getframe by jinja2.
553 2011-06-29T19:37:02 <CIA-45> one also needs to patch logging/__init__.py of pypy and set _srcfile to None for
554 2011-06-29T19:37:08 <Marchael> WHAT
555 2011-06-29T19:38:00 <CIA-45> same reasons.
556 2011-06-29T19:38:00 <CIA-45> Thomas Waldmann <tw AT waldmann-edv DOT de> * 51e077feea0b r288 moin-2.0/MoinMoin/templates/ (base.html layout.html show.html):
557 2011-06-29T19:38:00 <CIA-45> revert changset 50cc68af8874 because of issues
558 2011-06-29T19:38:00 <CIA-45> itemviews (and maybe other templates) need the context, so "without context"
559 2011-06-29T19:38:00 <CIA-45> gives wrong results.
560 2011-06-29T19:38:00 <CIA-45> (8 lines omitted)
561 2011-06-29T19:38:52 <Marchael> seems like I do something wrong with hg merge
562 2011-06-29T19:39:03 <ThomasWaldmann> Marchael: why?
563 2011-06-29T19:39:48 <Marchael> I commited my changes, pulled from your repo and then merge
564 2011-06-29T19:39:58 <Marchael> and push
565 2011-06-29T19:40:03 <ThomasWaldmann> for me that looks like bitbucket does not have dupe detection / cia does not have dupe detection
566 2011-06-29T19:40:52 <ThomasWaldmann> gtg / bbl
567 2011-06-29T19:50:09 *** greg_f
568 2011-06-29T20:49:45 *** RogerHaase
569 2011-06-29T20:55:19 <CIA-45> Michael Mayorov <marchael@kb.csu.ru> * b0855eb191e1 r295 moin-2.0/MoinMoin/script/maint/ (update_indexes.py build_indexes.py): Fix giant bug in update index script, add "--for" option for partly updating
570 2011-06-29T20:56:25 <Marchael> I should wake up early, so gn/bbl
571 2011-06-29T21:02:20 *** m4k3r
572 2011-06-29T21:42:07 *** m4k3r
573 2011-06-29T21:46:31 <ronny> re
574 2011-06-29T21:46:35 <ronny> whops
575 2011-06-29T21:46:42 <ronny> i was on a bike tour at the meeting
576 2011-06-29T21:47:18 *** sinha
577 2011-06-29T21:51:15 *** m4k3r_
578 2011-06-29T21:51:53 *** m4k3r
579 2011-06-29T22:11:56 * dreimark Flask 0.7.1 bug fix release
580 2011-06-29T22:45:53 <ThomasWaldmann> ah :)
581 2011-06-29T22:48:17 *** m4k3r_
582 2011-06-29T23:20:19 *** moin7
583 2011-06-29T23:22:31 <moin7> Good afternoon. Could somebody maybe give some hints for writting a macro that take a huge web link and get a simpler one?
584 2011-06-29T23:26:37 <moin7> Maybe which functions from wikiutils should we use?
585 2011-06-29T23:28:30 <ThomasWaldmann> you could use bit.ly or tinyurl
586 2011-06-29T23:49:50 <RogerHaase> ThomasWaldmann: dreimark: I updated http://codereview.appspot.com/4535086 -- wrapper and overlays created in javascript to avoid A's within A's. Overlays are A's so MMB works in Firefox and Opera.
587 2011-06-29T23:51:31 <RogerHaase> Temporary test page: http://97.117.226.172:8081/Transclusions
588 2011-06-29T23:56:16 *** grzywacz
589 2011-06-29T23:56:17 *** grzywacz
590 2011-06-29T23:56:33 <dreimark> RogerHaase: should that work with 3.6.18
591 2011-06-29T23:57:22 <dreimark> ah, i found the link
592 2011-06-29T23:58:10 <dreimark> pretty cool
593 2011-06-29T23:58:54 <RogerHaase> dreimark: hopefully, but I am testing with firefox 4.01 here
