1 2011-06-26T00:45:40  *** sinha has quit IRC
   2 2011-06-26T00:55:24  *** MattMaker has quit IRC
   3 2011-06-26T00:55:42  *** MattMaker has joined #moin-dev
   4 2011-06-26T04:13:10  *** waldbaer has joined #moin-dev
   5 2011-06-26T04:15:53  *** balu has quit IRC
   6 2011-06-26T07:13:02  *** Marchael has quit IRC
   7 2011-06-26T07:16:43  *** Marchael has joined #moin-dev
   8 2011-06-26T07:20:57  *** Marchael has quit IRC
   9 2011-06-26T07:25:13  *** Marchael has joined #moin-dev
  10 2011-06-26T08:42:41  <Marchael> moin
  11 2011-06-26T09:04:58  *** Marchael has quit IRC
  12 2011-06-26T09:06:47  <dreimark> moin
  13 2011-06-26T09:10:08  *** Marchael has joined #moin-dev
  14 2011-06-26T09:14:39  *** Marchael has quit IRC
  15 2011-06-26T09:54:32  *** Marchael has joined #moin-dev
  16 2011-06-26T10:05:05  *** [bsx] has joined #moin-dev
  17 2011-06-26T10:05:36  <ThomasWaldmann> moin
  18 2011-06-26T10:08:02  <dreimark> ThomasWaldmann: i got a tweet about a mail to you because of the power supply
  19 2011-06-26T10:08:09  <dreimark> have you seen it
  20 2011-06-26T10:21:49  <Marchael> hi ThomasWaldmann
  21 2011-06-26T10:22:09  <Marchael> I made some changes yerstaday, could you review?
  22 2011-06-26T10:23:36  <ThomasWaldmann> dreimark: i got an email from him, but I don't read twitter
  23 2011-06-26T10:25:03  <dreimark> ok
  24 2011-06-26T10:43:27  *** greg_f has joined #moin-dev
  25 2011-06-26T10:43:58  <ThomasWaldmann> Marchael: review done
  26 2011-06-26T10:50:24  *** sinha has joined #moin-dev
  27 2011-06-26T10:53:02  <dreimark> sinha: reviewed
  28 2011-06-26T10:53:30  <sinha> dreimark: yeah did the changes, push it now ?
  29 2011-06-26T10:54:02  <dreimark> yes
  30 2011-06-26T10:54:09  <dreimark> and merge more often
  31 2011-06-26T10:55:15  <sinha> yeah okay, merging after this commit
  32 2011-06-26T10:58:05  <CIA-70> Akash Sinha <akash2607@gmail.com> * b33a2dca5e8f r273 default/MoinMoin/ (2 files in 2 dirs): diff link added on global history page, to view diff between latest revision and first revision
  33 2011-06-26T10:58:05  <CIA-70> Akash Sinha <akash2607@gmail.com> * b32034020a58 r274 default/MoinMoin/ (config/default.py user.py apps/frontend/views.py): change in action in case of user's default value for results_per_page, now on '0' NO PAGINATION.
  34 2011-06-26T10:59:48  <sinha> dreimark: what have you thought regarding the placing of icons on history page ?
  35 2011-06-26T11:00:51  <dreimark> I ansered on the page with the image
  36 2011-06-26T11:01:02  <dreimark> we had choosen left of item
  37 2011-06-26T11:01:19  * dreimark has to leave now
  38 2011-06-26T11:01:43  <dreimark> cu in some hours
  39 2011-06-26T11:02:33  <dreimark> bbl
  40 2011-06-26T11:05:04  <CIA-70> Reimar Bauer <rb.proj AT googlemail DOT com> * 91330de48b9c r275 default/MoinMoin/ (items/__init__.py templates/modify_svg-edit.html): items: implemented 2.6 r:2031 alpha of svg-edit using a save extension for doing a single post for svg and png data.
  41 2011-06-26T11:05:06  <CIA-70> Thomas Waldmann <tw AT waldmann-edv DOT de> * 76a4e3cc8705 r276 default/MoinMoin/ (6 files in 6 dirs):
  42 2011-06-26T11:05:06  <CIA-70> add +download view for just downloading a revision with forced content-disposition: attachment
  43 2011-06-26T11:05:06  <CIA-70> minor code cleanups, removed MimeType.content_disposition as it did not match send_file api,
  44 2011-06-26T11:05:06  <CIA-70> replaced it by a as_attachment method.
  45 2011-06-26T11:05:06  <CIA-70> removed duplicate get_item list entry.
  46 2011-06-26T11:05:06  <CIA-70> removed unused content_disposition argument from wikiutil.file_headers.
  47 2011-06-26T11:05:09  <CIA-70> bsx <bsx+bitbucket@0xcafec0.de> * 02888ad76719 r277 default/MoinMoin/items/__init__.py: added exception handling if PIL can't diff the image
  48 2011-06-26T11:05:09  <CIA-70> Thomas Waldmann <tw AT waldmann-edv DOT de> * eea3a94a4061 r278 default/MoinMoin/ (6 files in 2 dirs):
  49 2011-06-26T11:05:09  <CIA-70> refactored calling convention of converters, add rev=n qs argument for Iris (fixes #21)
  50 2011-06-26T11:05:35  <CIA-70> specific revisions.
  51 2011-06-26T11:05:35  <CIA-70> Thomas Waldmann <tw AT waldmann-edv DOT de> * f6ca659f4a4f r279 default/MoinMoin/templates/history.html: use +download for download link in revision history
  52 2011-06-26T11:05:35  <CIA-70> Thomas Waldmann <tw AT waldmann-edv DOT de> * 50cc68af8874 r280 default/MoinMoin/templates/ (base.html layout.html show.html):
  53 2011-06-26T11:05:35  <CIA-70> modify templates to not use 'with context' because this kills pypy's performance
  54 2011-06-26T11:05:36  <CIA-70> this is due to use of sys._getframe by jinja2.
  55 2011-06-26T11:06:35  <CIA-70> gives wrong results.
  56 2011-06-26T11:06:35  <CIA-70> Armin Ronacher told to fix the "with context" pypy performance issue in jinja2,
  57 2011-06-26T11:06:35  <CIA-70> so we'll just wait for that.
  58 2011-06-26T11:06:35  <CIA-70> Reimar Bauer <rb.proj AT googlemail DOT com> * 4c5e7dbfe63d r282 default/ (wikiconfig.py MoinMoin/templates/base.html quickinstall): mathjax call implemented and to quickinstall added
  59 2011-06-26T11:06:36  <CIA-70> Akash Sinha <akash2607@gmail.com> * 630c21e18398 r283 default/ (18 files in 8 dirs): branch merged with main repo
  60 2011-06-26T11:15:17  <Marchael> ThomasWaldmann: review http://codereview.appspot.com/4539114
  61 2011-06-26T11:34:14  *** m4k3r has joined #moin-dev
  62 2011-06-26T11:45:55  <ThomasWaldmann> Marchael: review done
  63 2011-06-26T11:46:40  <ThomasWaldmann> http://uncyclopedia.wikia.com/wiki/Redundancy < :)
  64 2011-06-26T11:48:47  <Marchael> :D
  65 2011-06-26T11:55:54  <Marchael> sometimes my inattention just horrable :)
  66 2011-06-26T12:11:03  <Marchael> ThomasWaldmann: please review http://codereview.appspot.com/4539114
  67 2011-06-26T12:19:34  <sinha> bbl
  68 2011-06-26T12:19:36  *** sinha has quit IRC
  69 2011-06-26T12:38:58  <ThomasWaldmann> sometimes it helps to read ones own code and try to explain to oneself "what am I doing here" and also check if that is in sync with "what is the easiest way to solve the problem I have"
  70 2011-06-26T12:41:23  <Marchael> yeah, but first I'm need to know what's the problem :)
  71 2011-06-26T12:48:22  <Marchael> ThomasWaldmann: but what I should do now? I tested that code for some cases(reverting, adding,trashing documents, also destroying+adding revs) and seems like it work fine(from my point of view).
  72 2011-06-26T12:58:20  <ThomasWaldmann> well, working for some cases is not enough, it needs to work for all :)
  73 2011-06-26T12:58:47  <ThomasWaldmann> so maybe just comment on codereview and either fix or ask there
  74 2011-06-26T13:00:55  <Marchael> hm, but I fixed issues what you poin me in 31 changeset
  75 2011-06-26T13:01:00  <Marchael> *point
  76 2011-06-26T13:02:55  <Marchael> If I don't fixed something in previous changeset just tell me
  77 2011-06-26T13:03:42  <ThomasWaldmann> there is no 31 changeset
  78 2011-06-26T13:03:53  <ThomasWaldmann> oh, now there is
  79 2011-06-26T13:04:05  <Marchael> last changeset is 32
  80 2011-06-26T13:05:32  *** greg_f has quit IRC
  81 2011-06-26T13:07:10  <ThomasWaldmann> Marchael: revs_found = searcher.documents(name=name)
  82 2011-06-26T13:07:24  <ThomasWaldmann> what does it return if it doesn't find any revs?
  83 2011-06-26T13:07:34  <Marchael> None
  84 2011-06-26T13:08:38  <ThomasWaldmann> not []?
  85 2011-06-26T13:08:44  <Marchael> I mean what searcher.documents(name=name) returns None
  86 2011-06-26T13:09:22  <ThomasWaldmann> that's a bit strange
  87 2011-06-26T13:11:00  <Marchael> hm, wait
  88 2011-06-26T13:11:08  <Marchael> yes, it returns []
  89 2011-06-26T13:11:52  <ThomasWaldmann> ok, then you can simplify your code
  90 2011-06-26T13:13:36  <Marchael> you remove  item_index_revs() and use that code below?
  91 2011-06-26T13:13:41  <Marchael> *you mean
  92 2011-06-26T13:18:47  <ThomasWaldmann> see there
  93 2011-06-26T13:20:37  <Marchael> ok
  94 2011-06-26T13:32:41  <Marchael> ThomasWaldmann: sometimes I see strage traceback http://paste.pocoo.org/show/420111/
  95 2011-06-26T13:32:49  <Marchael> *strange
  96 2011-06-26T13:33:09  <Marchael> but I don't modify stuff in storage
  97 2011-06-26T13:34:52  <Marchael> I mean modify using this script
  98 2011-06-26T13:43:02  <Marchael> ThomasWaldmann: review http://codereview.appspot.com/4539114/diff2/61001:36003/MoinMoin/script/maint/update_indexes.py
  99 2011-06-26T13:46:09  <ThomasWaldmann> Marchael: looks fine afaics
 100 2011-06-26T13:46:21  <ThomasWaldmann> does it work? :)
 101 2011-06-26T13:46:30  <Marchael> yeah
 102 2011-06-26T13:47:11  <Marchael> may I commit this?
 103 2011-06-26T13:47:46  <ThomasWaldmann> yeah, and start a new codereview id for stuff afterwards, this one is getting too long
 104 2011-06-26T13:47:57  <Marchael> ok
 105 2011-06-26T13:49:04  <CIA-70> Michael Mayorov <marchael@kb.csu.ru> * 28858876a5f1 r275 moin-2.0/MoinMoin/script/maint/update_indexes.py: Some fixes in update script with debug output
 106 2011-06-26T13:49:04  <CIA-70> Michael Mayorov <marchael@kb.csu.ru> * 4dba3eece489 r276 moin-2.0/MoinMoin/script/maint/update_indexes.py: Bugfixes in update_script.py
 107 2011-06-26T13:49:50  <Marchael> ThomasWaldmann: what next?
 108 2011-06-26T13:55:11  *** greg_f has joined #moin-dev
 109 2011-06-26T13:56:02  <ThomasWaldmann> you have a quite big todo list on EP
 110 2011-06-26T14:06:21  <Marchael> hm, I don't see line numbers on ep, it's just for me?
 111 2011-06-26T14:08:42  *** greg_f has quit IRC
 112 2011-06-26T14:08:45  <Marchael> ah, now ok
 113 2011-06-26T14:18:43  *** greg_f has joined #moin-dev
 114 2011-06-26T14:20:52  <ThomasWaldmann> Marchael: btw, I filed one bug for whoosh MultiSegmentWriter - if you have more than #150 issue, you should file more bugs
 115 2011-06-26T14:21:54  <Marchael> ok, but I haven't for now
 116 2011-06-26T14:39:40  *** greg_f has quit IRC
 117 2011-06-26T14:46:31  *** greg_f has joined #moin-dev
 118 2011-06-26T15:45:01  <CIA-70> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 262:d1b8dc0abe68 2.0/ (quickinstall quickinstall.bat setup.py wikiconfig.py): use jquery from XStatic-jQuery package
 119 2011-06-26T15:45:02  <CIA-70> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 263:85d1cbf6922a 2.0/ (MoinMoin/templates/base.html quickinstall wikiconfig.py): merged main
 120 2011-06-26T15:46:51  <Marchael> ThomasWaldmann: please review http://codereview.appspot.com/4657051
 121 2011-06-26T16:01:45  <ThomasWaldmann> dreimark: btw, if you require stuff, you should update the quickinstall.bat stuff also
 122 2011-06-26T16:02:20  <ThomasWaldmann> (and we should think about a better solution, maybe not everybody needs/wants mathjax installed)
 123 2011-06-26T16:20:44  <Marchael> ThomasWaldmann: see ep
 124 2011-06-26T16:48:15  *** m4k3r has quit IRC
 125 2011-06-26T17:05:46  <Marchael> bbl
 126 2011-06-26T17:06:16  *** Marchael has quit IRC
 127 2011-06-26T18:46:01  *** pkumar has joined #moin-dev
 128 2011-06-26T18:52:53  *** hardy89 has joined #moin-dev
 129 2011-06-26T19:16:20  <hardy89> where does one need to start reading up with the code, if one is interested in contributions ?
 130 2011-06-26T19:21:27  <ronny> ThomasWaldmann: when do we want to go for food
 131 2011-06-26T19:22:44  <hardy89> i gave that particular *ONE* link to thomas's repo :)
 132 2011-06-26T19:27:08  *** greg_f has quit IRC
 133 2011-06-26T19:35:22  <ronny> ThomasWaldmann: im considering taking another nap
 134 2011-06-26T19:56:04  <hardy89> hi waldi
 135 2011-06-26T19:57:25  <hardy89> waldi: will it be fine if I continue the mem leak thing for a while along with the rest of the project.
 136 2011-06-26T19:58:02  <hardy89> waldi: cos i'm working on storage module as of now and i need to take care of the schedule on EP.
 137 2011-06-26T20:38:34  *** grzywacz has joined #moin-dev
 138 2011-06-26T20:38:34  *** grzywacz has joined #moin-dev
 139 2011-06-26T20:43:28  *** hardy89 has left #moin-dev
 140 2011-06-26T21:24:53  *** pkumar has quit IRC
 141 2011-06-26T21:37:04  *** xorAxAx has quit IRC
 142 2011-06-26T21:41:39  *** xorAxAx has joined #moin-dev
 143 2011-06-26T21:44:39  <ronny> ThomasWaldmann: ping?
 144 2011-06-26T21:48:01  *** sinha has joined #moin-dev
 145 2011-06-26T22:07:16  <ronny> ok, im out to the town, food&stuff
 146 2011-06-26T22:34:18  <ThomasWaldmann> re
 147 2011-06-26T22:39:31  *** sinha has left #moin-dev
 148 2011-06-26T22:46:53  *** grzywacz has quit IRC
 149 2011-06-26T23:08:51  <dreimark> re
 150 2011-06-26T23:44:33  <ThomasWaldmann> re
 151 2011-06-26T23:45:03  * ThomasWaldmann has accidentally seen some of the nicer parts of florence :D
 152 2011-06-26T23:47:36  <dreimark> ThomasWaldmann: walking?
 153 2011-06-26T23:47:54  <ThomasWaldmann> yes
 154 2011-06-26T23:48:42  <dreimark> but why accidentally?
 155 2011-06-26T23:52:55  <dreimark> gn

MoinMoin: MoinMoinChat/Logs/moin-dev/2011-06-26 (last edited 2011-06-25 23:00:02 by IrcLogImporter)