1 2011-06-22T00:19:03 <dreimark> re
2 2011-06-22T00:19:07 <dreimark> sinha: reviewed
3 2011-06-22T00:19:23 <sinha> okay
4 2011-06-22T00:29:24 <dreimark> sinha: i talked today with thomas about what next can be done. We think it is good to add pagination to item history as next step
5 2011-06-22T00:29:48 <dreimark> because there is not any additional parameter given
6 2011-06-22T00:29:55 <sinha> yes
7 2011-06-22T00:30:54 <dreimark> try to make the pagintion code reusable so that we don't need various copies of it
8 2011-06-22T00:33:56 <sinha> if there wont be any grouping in item history, then pagination would be a lot different than the global history and also lot simpler
9 2011-06-22T00:34:36 <sinha> just have the pass the offset parameter to storage function at backend
10 2011-06-22T00:34:46 <dreimark> yes
11 2011-06-22T00:36:21 <sinha> and do you want to have some cleaning of view there
12 2011-06-22T00:37:06 <sinha> or leave this part as of now
13 2011-06-22T00:54:05 *** sinha
14 2011-06-22T00:54:20 *** sinha
15 2011-06-22T01:03:39 <dreimark> sinha: cleaning move it to the ui part
16 2011-06-22T01:03:54 <dreimark> the +count stuff
17 2011-06-22T01:04:10 <sinha> yeah i have read your comments there
18 2011-06-22T01:04:12 <sinha> will do it
19 2011-06-22T01:04:18 <sinha> and also regarding that form thing
20 2011-06-22T01:04:22 <dreimark> ok
21 2011-06-22T01:04:33 <sinha> i copied the almost same code from "register.html" template
22 2011-06-22T01:04:45 <sinha> but still it was giving error that form in not defined
23 2011-06-22T01:04:54 <sinha> i mean do i have to do anything else
24 2011-06-22T01:04:55 <sinha> ?
25 2011-06-22T01:05:06 <dreimark> if you import it it should work
26 2011-06-22T01:05:23 <dreimark> may be register is dependent on something else
27 2011-06-22T01:05:38 <dreimark> try with the import first
28 2011-06-22T01:05:46 <sinha> or i need to pass a form, from function itself
29 2011-06-22T01:05:52 <sinha> yes i did import it
30 2011-06-22T01:06:01 <dreimark> I look at it later again after some sleep
31 2011-06-22T01:06:22 <sinha> okay, gn
32 2011-06-22T01:06:27 <dreimark> sorry but i had two meetings after the conference and need sleep
33 2011-06-22T01:06:45 <sinha> no prob :)
34 2011-06-22T02:47:04 *** sinha
35 2011-06-22T05:12:47 *** MattMaker_
36 2011-06-22T05:14:36 *** MattMaker_
37 2011-06-22T05:16:12 *** MattMaker
38 2011-06-22T05:16:12 *** MattMaker_
39 2011-06-22T05:42:25 *** MattMaker_
40 2011-06-22T05:44:45 *** MattMaker
41 2011-06-22T05:44:45 *** MattMaker_
42 2011-06-22T05:49:54 *** pileofrogs
43 2011-06-22T05:54:55 <pileofrogs> Hi. Is anyone around?
44 2011-06-22T05:55:14 <pileofrogs> I'm curious about Moin2
45 2011-06-22T06:12:06 *** pileofrogs
46 2011-06-22T07:44:51 *** MattMaker
47 2011-06-22T07:47:01 *** MattMaker
48 2011-06-22T08:51:01 *** hardy89
49 2011-06-22T08:51:20 <hardy89> hi waldi
50 2011-06-22T08:51:28 <hardy89> hi xorAxAx
51 2011-06-22T08:52:31 <xorAxAx> hi hardy89
52 2011-06-22T08:52:46 <hardy89> xorAxAx: when i do
53 2011-06-22T08:52:47 <hardy89> import gc
54 2011-06-22T08:52:48 <hardy89> gc.enable()
55 2011-06-22T08:52:48 <hardy89> gc.set_debug(gc.DEBUG_LEAK)
56 2011-06-22T08:52:48 <hardy89> print gc.garbage
57 2011-06-22T08:52:53 <hardy89> in conftest.py
58 2011-06-22T08:53:14 <hardy89> it is supposed to get me the list of objects which cause mem leaks
59 2011-06-22T08:53:22 <hardy89> but it doesn't
60 2011-06-22T08:53:38 <hardy89> rather, gives a huge amount of memory locations of random stuff
61 2011-06-22T08:54:41 <xorAxAx> well, thats exactly what you enabled
62 2011-06-22T08:54:55 <xorAxAx> it gives you all objects that were allocated since you set DEBUG_LEAK
63 2011-06-22T08:55:03 <xorAxAx> not only those that are still alvie
64 2011-06-22T08:55:35 <xorAxAx> try without DEBUG_LEAK and gc.get_objects()
65 2011-06-22T08:55:41 <xorAxAx> thats probably more useful
66 2011-06-22T08:55:49 <hardy89> i even did that
67 2011-06-22T08:55:54 <hardy89> it gave me some error
68 2011-06-22T08:55:55 <hardy89> wait
69 2011-06-22T08:56:00 <hardy89> will show you
70 2011-06-22T08:57:19 <xorAxAx> brb
71 2011-06-22T08:58:07 <ThomasWaldmann> moin
72 2011-06-22T08:58:33 <waldi> moinmoin
73 2011-06-22T08:59:37 <ThomasWaldmann> wired internet, yay!
74 2011-06-22T09:00:17 <ThomasWaldmann> debugging and profiling techniques
75 2011-06-22T09:00:29 <ThomasWaldmann> ^^ current talk
76 2011-06-22T09:01:31 <dreimark> moin
77 2011-06-22T09:02:15 <hardy89> hi waldi
78 2011-06-22T09:02:43 <hardy89> xorAxAx, waldi : this is what i get with gc.set_debug(gc.DEBUG_LEAK)
79 2011-06-22T09:02:44 <hardy89> gc.set_debug(gc.DEBUG_LEAK)
80 2011-06-22T09:02:48 <hardy89> er
81 2011-06-22T09:02:53 <hardy89> http://www.pastie.org/2105081
82 2011-06-22T09:07:50 <hardy89> and with gc.get_objects()
83 2011-06-22T09:07:51 <waldi> looks sane to me
84 2011-06-22T09:07:56 <hardy89> http://paste.pocoo.org/show/416787/
85 2011-06-22T09:08:02 <hardy89> waldi: same?
86 2011-06-22T09:08:25 <hardy89> waldi: gc.set_debug(gc.DEBUG_LEAK) gives unnecessary mem locations
87 2011-06-22T09:08:59 <hardy89> gc.get_objects() is supposed to give a list of objects not doing good. But it doesn't
88 2011-06-22T09:09:33 <hardy89> waldi: also, gc.set_debug(gc.DEBUG_LEAK) increases the mem used by manifolds. :/
89 2011-06-22T09:12:09 <xorAxAx> hardy89: i dont see any error related to get_objects in your second paste
90 2011-06-22T09:12:53 <hardy89> xorAxAx: exactly. that should Returns a list of all objects tracked by the collector, excluding the list returned.
91 2011-06-22T09:12:59 <hardy89> but it does not.
92 2011-06-22T09:14:35 <hardy89> moreover if i use gc.set_debug(gc.DEBUG_LEAK), it should cause garbage-collected objects to be saved in gc.garbage for inspection.
93 2011-06-22T09:14:48 <hardy89> but print gc.garbage does not return anything
94 2011-06-22T09:15:29 <hardy89> I discussed this on #python, some said its cos its a variable, rest were clueless.
95 2011-06-22T09:24:33 <hardy89> xorAxAx, waldi: ^
96 2011-06-22T09:28:43 *** brunomartin
97 2011-06-22T09:30:51 <hardy89> ok Mac battery bout to give up and no electricity for 8 hrs now. Will be back after a while.
98 2011-06-22T09:30:59 *** hardy89
99 2011-06-22T09:38:22 <ThomasWaldmann> gc.collet(); gc.garbage should be empty afterwards. if not, THAT are the uncollectable object == our leaks.
100 2011-06-22T09:54:31 *** MattMaker
101 2011-06-22T09:54:49 *** MattMaker
102 2011-06-22T10:41:51 <Marchael> this script blows up my brain
103 2011-06-22T10:42:52 * Marchael bbl
104 2011-06-22T11:33:46 *** greg_f
105 2011-06-22T11:46:53 *** hardy89
106 2011-06-22T11:47:36 <hardy89> waldi, xorAxAx : hey
107 2011-06-22T11:47:45 <xorAxAx> hey hardy89
108 2011-06-22T11:47:52 <dreimark> 09:38 < ThomasWaldmann> gc.collet(); gc.garbage should be empty afterwards. if not, THAT are the uncollectable object == our leaks.
109 2011-06-22T11:48:33 <xorAxAx> i fear thats not directly true
110 2011-06-22T11:48:49 <xorAxAx> gc.garbage would only contain objects in referential unbreakable cycyles
111 2011-06-22T11:49:00 <xorAxAx> but we might also leak through caches
112 2011-06-22T11:49:01 <hardy89> xorAxAx: finally laptop charged to work for few more hours. Major fault with electricity today :|
113 2011-06-22T11:49:08 <xorAxAx> hardy89: ah :-(
114 2011-06-22T11:49:43 <ThomasWaldmann> xorAxAx: yeah, right
115 2011-06-22T11:49:45 <hardy89> xorAxAx: hm...well yeah, but coming back to the issue we were talking
116 2011-06-22T11:50:31 <xorAxAx> 10 minutes till lunch here
117 2011-06-22T11:50:45 <hardy89> xorAxAx: with and without gc.collect() in conftest.py gives the same output :|
118 2011-06-22T11:50:52 <ThomasWaldmann> btw, the speaker of that debugging talk recommended meliae when i asked for some good tool
119 2011-06-22T11:51:21 <dreimark> that is used to debug bb
120 2011-06-22T11:51:29 <ThomasWaldmann> but, i had tried that some time ago and it didn't even compile or import for me
121 2011-06-22T11:51:35 <dreimark> or was it bazar ?
122 2011-06-22T11:53:01 <hardy89> xorAxAx: moreover if i use gc.set_debug(gc.DEBUG_LEAK), it should cause garbage-collected objects to be saved in gc.garbage for inspection. But print gc.garbage does not return anything.
123 2011-06-22T11:53:53 <xorAxAx> hardy89: probably because its catched by the output redirection of py.test?
124 2011-06-22T11:53:57 <xorAxAx> hardy89: write it to a file
125 2011-06-22T11:54:31 <hardy89> xorAxAx: ok
126 2011-06-22T11:54:48 <hardy89> but as you said, gc.collect() will be more useful
127 2011-06-22T11:55:07 <hardy89> xorAxAx: why it does not make any change to the output
128 2011-06-22T11:55:27 <xorAxAx> which change would you expect?
129 2011-06-22T11:55:59 <hardy89> gc.collect() should give the list of objects, it does not.
130 2011-06-22T11:56:27 <xorAxAx> no, it should return none
131 2011-06-22T11:58:21 <hardy89> xorAxAx: hm...it returns the number of objects unreachable
132 2011-06-22T11:59:21 <xorAxAx> yeah, a number probably
133 2011-06-22T11:59:52 <hardy89> xorAxAx: so how would that be helpful?
134 2011-06-22T12:00:12 <xorAxAx> not much
135 2011-06-22T12:00:18 * xorAxAx &
136 2011-06-22T12:01:07 <hardy89> cos if do
137 2011-06-22T12:01:19 <hardy89> import gc
138 2011-06-22T12:01:20 <hardy89> gc.enable()
139 2011-06-22T12:01:20 <hardy89> gc.collect()
140 2011-06-22T12:01:31 <hardy89> it turns out to be useless
141 2011-06-22T12:03:20 <hardy89> xorAxAx: ^
142 2011-06-22T12:04:49 <hardy89> xorAxAx: so the only way left is writing the output of gc.set_debug(gc.DEBUG_LEAK) to a file. right?
143 2011-06-22T12:05:01 *** greg_f
144 2011-06-22T12:34:37 *** hardy89
145 2011-06-22T12:36:50 *** hardy89
146 2011-06-22T12:44:37 <xorAxAx> hell no
147 2011-06-22T12:44:49 <xorAxAx> writing gc.garbage or gc.get_objects to a file
148 2011-06-22T12:44:55 <xorAxAx> but not set_debug() or collect()
149 2011-06-22T12:45:10 <xorAxAx> hardy89:
150 2011-06-22T12:45:57 <hardy89> xorAxAx: yes yes
151 2011-06-22T12:47:05 <xorAxAx> and its not the only way either
152 2011-06-22T12:47:13 <xorAxAx> but one that would work
153 2011-06-22T12:48:04 <hardy89> xorAxAx: i still have one trivial doubt
154 2011-06-22T12:48:05 <hardy89> :|
155 2011-06-22T12:48:12 <hardy89> To debug a leaking program
156 2011-06-22T12:48:15 <hardy89> we do
157 2011-06-22T12:48:23 <hardy89> gc.set_debug(gc.DEBUG_LEAK)
158 2011-06-22T12:48:28 <hardy89> which in turn
159 2011-06-22T12:48:45 <xorAxAx> i never said that you should use DEBUG_LEAK
160 2011-06-22T12:48:49 <hardy89> causes garbage-collected objects to be saved in gc.garbage for inspection.
161 2011-06-22T12:49:39 <hardy89> xorAxAx: i should use gc.collect() and write its output to a file?
162 2011-06-22T12:50:06 <hardy89> if not DEBUG_LEAK
163 2011-06-22T12:50:39 <xorAxAx> hello no
164 2011-06-22T12:50:47 <xorAxAx> -o
165 2011-06-22T12:50:56 <xorAxAx> sigh, i resign
166 2011-06-22T12:51:59 <hardy89> xorAxAx: ok i'll read the wiki yet AGAIn and then do it :|
167 2011-06-22T12:52:48 <hardy89> xorAxAx: ok. writing gc.get_objects to a file.
168 2011-06-22T13:20:39 *** pkumar
169 2011-06-22T13:34:26 <pkumar> xorAxAx : hi, instead of calling init_test_app I just modified the conftest.py to initialize new app in storage module, since it is mostly need there.
170 2011-06-22T13:35:29 <pkumar> so no need to call individually in each test in storage module
171 2011-06-22T13:35:43 <xorAxAx> ok
172 2011-06-22T13:38:50 <pkumar> hardy89 : hey, did you get a chance to work on Sanitsing code of the modules especially on storage one.
173 2011-06-22T13:41:16 <hardy89> pkumar: no.not yet
174 2011-06-22T13:42:13 <hardy89> pkumar: still working on mem leaks.
175 2011-06-22T13:42:19 <hardy89> pkumar: and sorry, hi :)
176 2011-06-22T13:47:21 <pkumar> hardy89 : ok, because the only errors left are in storage module.
177 2011-06-22T13:48:26 <hardy89> pkumar: what is visible from the test runs is only storage and util module had errors apart from 1/2 more here and there
178 2011-06-22T13:49:18 <pkumar> hardy89 : in util?
179 2011-06-22T13:49:25 <pkumar> no its not
180 2011-06-22T13:49:33 <hardy89> pkumar: also, we have not decided yet on which module we would be working on during this duration.
181 2011-06-22T13:50:02 <hardy89> pkumar: ah. sorry. datastruct
182 2011-06-22T13:50:10 <pkumar> hardy89 : have a look at the EP please
183 2011-06-22T13:50:25 <hardy89> pkumar: :/
184 2011-06-22T13:50:55 <pkumar> hardy89 : no datastruct is also clean
185 2011-06-22T13:50:59 <hardy89> pkumar: but when did we decide this thing, or you took this modules on your own?
186 2011-06-22T13:52:28 <pkumar> hardy89 : from line 93 to 129.
187 2011-06-22T13:52:48 <pkumar> hardy89 : isn't that the common plan.
188 2011-06-22T13:53:22 <pkumar> hardy89 : now, if you don't want to work on any one of them I'm glad to switch.
189 2011-06-22T13:53:36 *** sinha
190 2011-06-22T13:53:36 <hardy89> pkumar: i thot that was for that period of time
191 2011-06-22T13:53:44 <hardy89> pkumar: all right. i'll do it
192 2011-06-22T13:53:48 <hardy89> thanks
193 2011-06-22T13:54:07 <hardy89> :)
194 2011-06-22T13:54:07 <pkumar> period of time starts from line 132
195 2011-06-22T13:55:11 <hardy89> pkumar: but we did discuss that we'll divide the work for this week last time we had a chat as far as i remember.
196 2011-06-22T13:55:15 <hardy89> but thats fine
197 2011-06-22T13:55:22 <hardy89> i'll work on my share
198 2011-06-22T13:55:48 <pkumar> FIRST, please try to work on storage module as soon as possible, ask if any doubts.
199 2011-06-22T13:57:37 <hardy89> pkumar: ok. so converter/_tests/test_moinwiki_in_out.py had few Fs
200 2011-06-22T13:58:12 <pkumar> hardy89 : I'm talking about ERRORS. not failures.
201 2011-06-22T13:58:12 <hardy89> rest, only storage mod has everything wrong with it
202 2011-06-22T13:58:31 <hardy89> pkumar: so you worked on all the Es
203 2011-06-22T13:59:08 <pkumar> I fixed a few in converter module and now there are no more there.
204 2011-06-22T13:59:30 <pkumar> if you need help with storage one then temme
205 2011-06-22T13:59:34 <hardy89> pkumar: you have all in all 3 Es as sum total of your modules and you fixed them
206 2011-06-22T13:59:35 <hardy89> hmm
207 2011-06-22T13:59:37 <hardy89> got it
208 2011-06-22T13:59:57 <hardy89> pkumar: since you were working on fs2, you can take that
209 2011-06-22T14:00:00 <hardy89> rest i can do
210 2011-06-22T14:00:14 <hardy89> if fs2 has any Es
211 2011-06-22T14:02:22 <pkumar> those errors were fixed a while ago, in the first week I guess.
212 2011-06-22T14:02:47 <hardy89> pkumar: which errors?
213 2011-06-22T14:03:12 <pkumar> in converter module
214 2011-06-22T14:04:10 <hardy89> owait
215 2011-06-22T14:04:17 <hardy89> why am i tracking your progress
216 2011-06-22T14:04:24 <hardy89> report that in meeting
217 2011-06-22T14:04:25 <hardy89> :)
218 2011-06-22T14:04:32 <hardy89> i ain't no mentor
219 2011-06-22T14:05:13 <pkumar> hardy89 : though it is our project and we should be aware of each other's progress.
220 2011-06-22T14:05:44 <hardy89> pkumar: agreed. i got the details. rest we do have meeting m8 :)
221 2011-06-22T14:07:52 <pkumar> hardy89 : also, I would suggest you to work according to the schedule. I don't think you wanna end up working on memory leakage problem.
222 2011-06-22T14:08:57 <pkumar> hardy89 : also, it is the need of the project as a whole
223 2011-06-22T14:09:30 <hardy89> inorite
224 2011-06-22T14:23:24 <sinha> dreimark: have an issue in adding the default result_count value in wikiconfig.py file, as you said we should add it to wikiconfig_local file rather than default wikiconfig file, but what if a user wont be having this wikiconfig_local file, i mean in that case the default result_count value would be None, so in script i got to check whether the default exists or not ?
225 2011-06-22T14:35:41 <pkumar> brb
226 2011-06-22T14:35:43 *** pkumar
227 2011-06-22T14:39:27 *** greg_f
228 2011-06-22T14:40:00 *** hardy89
229 2011-06-22T14:40:44 *** sinha
230 2011-06-22T14:42:26 *** hardy89
231 2011-06-22T14:42:31 *** sinha
232 2011-06-22T14:49:12 *** greg_f
233 2011-06-22T14:57:39 *** pkumar
234 2011-06-22T15:02:30 <Marchael> Do we have irc meeting today?
235 2011-06-22T15:05:57 *** brunomartin
236 2011-06-22T15:08:34 <hardy89> Marchael: yes. 1400 UTC
237 2011-06-22T15:08:54 <Marchael> ThomasWaldmann: please, review http://codereview.appspot.com/4539114/patch/56001/57001
238 2011-06-22T15:10:00 <xorAxAx> hardy89, pkumar, waldi: welcome to our weekly coordination meeting
239 2011-06-22T15:10:08 <xorAxAx> please shout if you ar ewith us
240 2011-06-22T15:10:22 <hardy89> xorAxAx: here
241 2011-06-22T15:10:25 <pkumar> hi everyone
242 2011-06-22T15:10:40 <xorAxAx> waldi: esp. you :-P
243 2011-06-22T15:11:00 <xorAxAx> ok, he doesnt seem with us
244 2011-06-22T15:11:41 <waldi> muh
245 2011-06-22T15:11:55 <xorAxAx> ok, have you both detected any conflicting tasks, hardy89, pkumar?
246 2011-06-22T15:12:55 <pkumar> conflicting tasks, as working on modules?
247 2011-06-22T15:13:00 <xorAxAx> according to the EP, HA doesnt have any planned tasks this week
248 2011-06-22T15:13:29 <xorAxAx> pkumar: well, generally - do you still work on distinct tasks?
249 2011-06-22T15:13:38 <hardy89> xorAxAx: yes. because we never discussed this part.
250 2011-06-22T15:13:54 <hardy89> xorAxAx: so i did not wanted to add it without discussion
251 2011-06-22T15:13:59 <hardy89> and we discussed it today
252 2011-06-22T15:14:11 <xorAxAx> then you should discuss it earlier
253 2011-06-22T15:14:13 <pkumar> xorAxAx : not at all. I think we are working on the project
254 2011-06-22T15:14:26 <hardy89> xorAxAx: we are although not working on same tasks so far
255 2011-06-22T15:14:34 <xorAxAx> hardy89: good
256 2011-06-22T15:14:57 <xorAxAx> its the mentors as well as the students job to gather new work tasks
257 2011-06-22T15:15:18 <pkumar> line no 93 EP
258 2011-06-22T15:15:21 <pkumar> hardy89 : ^
259 2011-06-22T15:15:42 <xorAxAx> short anticipation of our upcoming sync meeting, whats your state of the tasks that you planned to do last week?
260 2011-06-22T15:15:44 <hardy89> pkumar: we have already had a discussion on this
261 2011-06-22T15:15:50 <pkumar> there is nothing to discuss according to me, also the week gonna get over
262 2011-06-22T15:17:05 <pkumar> hardy89 : ^
263 2011-06-22T15:17:17 <hardy89> xorAxAx: i've been working on mem leak issue. STILL
264 2011-06-22T15:17:27 <xorAxAx> hardy89: yes, with suboptimal progress
265 2011-06-22T15:17:35 <hardy89> xorAxAx: agreed
266 2011-06-22T15:17:42 <xorAxAx> and devotion
267 2011-06-22T15:17:53 <hardy89> xorAxAx: but i've already approached the same problem with too many ways
268 2011-06-22T15:18:03 <hardy89> xorAxAx: devotion :/
269 2011-06-22T15:18:32 <hardy89> xorAxAx: which includes reading in detail about every single aspect and then implementing it
270 2011-06-22T15:18:50 <xorAxAx> hardy89: well, usually, one memory profiling tool is enough to tackle this problem
271 2011-06-22T15:18:50 <hardy89> cos Memory Leak task is mammoth.
272 2011-06-22T15:19:01 <xorAxAx> trying many and stopping early with everyone is not leading to success
273 2011-06-22T15:19:11 <xorAxAx> s/every/each /
274 2011-06-22T15:19:16 <hardy89> xorAxAx: logging has made things difficult here
275 2011-06-22T15:19:19 <hardy89> xorAxAx: i agree
276 2011-06-22T15:19:42 <xorAxAx> how is logging related to mem leaks?
277 2011-06-22T15:19:47 <hardy89> xorAxAx: Dozer was a waste of time, and so was profiling which was caught early by waldi thankfully
278 2011-06-22T15:20:09 <hardy89> xorAxAx: then came in gc module and i've been working with it since then
279 2011-06-22T15:20:26 <xorAxAx> i hardly remember the day when you stopped working with profiling tools ... i.e. it has been a while
280 2011-06-22T15:20:29 *** greg_f
281 2011-06-22T15:20:44 <xorAxAx> and i saw the first gc related questions today
282 2011-06-22T15:20:46 <waldi> last wednesday
283 2011-06-22T15:20:48 <xorAxAx> here on irc
284 2011-06-22T15:21:05 <hardy89> xorAxAx: exactly. i used memory profiling just for a day and waldi made me stop it fortunately on time
285 2011-06-22T15:21:22 <xorAxAx> all on which were full of confusion which function name to call
286 2011-06-22T15:21:32 <xorAxAx> s/on/of/
287 2011-06-22T15:21:42 <dreimark> sinha: i mean you need to add it to config
288 2011-06-22T15:21:55 <hardy89> xorAxAx: logging stops the required stdout of every gc module which shuld come up after every run
289 2011-06-22T15:22:17 <hardy89> xorAxAx: i'm learning :|
290 2011-06-22T15:22:18 <xorAxAx> hardy89: i rather think its pytest's output redirection as i said
291 2011-06-22T15:22:38 <dreimark> sinha: http://hg.moinmo.in/moin/2.0/file/91330de48b9c/MoinMoin/config/default.py
292 2011-06-22T15:22:43 <hardy89> xorAxAx: yeah right.
293 2011-06-22T15:23:06 <pkumar> hardy89 : its not logging but the pytest execution
294 2011-06-22T15:23:18 <hardy89> xorAxAx: now even redirecting it to a file also doesn't help and file chooses to stay empty , after being created
295 2011-06-22T15:23:30 <hardy89> pkumar: sorry
296 2011-06-22T15:23:33 <xorAxAx> hardy89: pastebin your code
297 2011-06-22T15:23:36 <sinha> dreimark: in user preference ?
298 2011-06-22T15:25:07 <pkumar> hardy89 : actually, it won't show anything stdout until an error or a test failure.
299 2011-06-22T15:25:28 <hardy89> xorAxAx: http://www.pastie.org/2106273
300 2011-06-22T15:25:40 <pkumar> hardy89 : did you try pdb?
301 2011-06-22T15:25:50 <hardy89> pkumar: not much
302 2011-06-22T15:25:52 * xorAxAx whines
303 2011-06-22T15:25:59 <xorAxAx> :''''-(
304 2011-06-22T15:26:33 <hardy89> xorAxAx: i even tried redirecting output of just gc.collect which gives up some random hex
305 2011-06-22T15:26:48 <xorAxAx> gc.garbage is a list ...
306 2011-06-22T15:26:58 <xorAxAx> whats the point of changing it into a file?
307 2011-06-22T15:27:09 <xorAxAx> you should be lucky that cpython doesnt crash
308 2011-06-22T15:27:40 <xorAxAx> you need to call "print >>myfile, gc.garbage" at the correct point in time
309 2011-06-22T15:27:53 <xorAxAx> whereas myfile is what you are assigning to .garbage currently
310 2011-06-22T15:28:05 <hardy89> xorAxAx: but the gc.garbage gives all mem loc.
311 2011-06-22T15:28:24 <xorAxAx> to be honest, i am not sure whether the performance of your python skills shown in this snippet warrants a mid term pass
312 2011-06-22T15:28:30 <waldi> hardy89: gc.garbage is a _list_ and the documentation is explicit on don't replace it
313 2011-06-22T15:28:35 <xorAxAx> but i am not the one to decide
314 2011-06-22T15:28:43 <xorAxAx> esp. given the fact that this is well documented
315 2011-06-22T15:28:59 <hardy89> i agree i agree
316 2011-06-22T15:29:00 <waldi> hardy89: somehow i don't see that you understood the documentation at all
317 2011-06-22T15:30:02 <hardy89> gc.garbage does/should give the list of the objects collected
318 2011-06-22T15:30:05 <hardy89> i agree
319 2011-06-22T15:30:08 <hardy89> but here
320 2011-06-22T15:30:15 <hardy89> on doing
321 2011-06-22T15:30:25 <hardy89> 1. "print >>myfile, gc.garbage" at the correct point in time
322 2011-06-22T15:30:35 <hardy89> says no such file found
323 2011-06-22T15:30:53 <hardy89> 2. gives all random mem loc while py.test is running
324 2011-06-22T15:30:55 <hardy89> :|
325 2011-06-22T15:31:59 <dreimark> sinha: that depends a bit on if it is a value for pagination if so it should gets its own section
326 2011-06-22T15:32:33 <sinha> okay
327 2011-06-22T15:33:17 <dreimark> if it is only for initialisation the var for the user you can hav it there
328 2011-06-22T15:33:49 <hardy89> xorAxAx: unfortunately i'm not as leet as the other student but yeah i do work on it and yes, i am trying to learn.
329 2011-06-22T15:33:54 <hardy89> :|
330 2011-06-22T15:34:14 <xorAxAx> hardy89: you didnt read everything i wrote
331 2011-06-22T15:34:22 <pkumar> hmm...
332 2011-06-22T15:34:46 <xorAxAx> i feel that our communication attempts seem fragile and a bit useless from my side
333 2011-06-22T15:35:03 <hardy89> xorAxAx: but you are one of the core mentors of this project and you can judge me well
334 2011-06-22T15:35:37 <hardy89> i said my performance has been dismal so far but i do work on it.
335 2011-06-22T15:36:17 <hardy89> xorAxAx: i don't grab things that quickly. it takes time in my case.
336 2011-06-22T15:37:23 <xorAxAx> it would be fine if was just that
337 2011-06-22T15:37:37 <xorAxAx> but currently you are blocked by lack of elementary python skills
338 2011-06-22T15:38:41 <hardy89> xorAxAx: i am also learning the darker side of python from this project.
339 2011-06-22T15:39:52 <xorAxAx> sorry, but writing a list to a file is neither dark nor advanced
340 2011-06-22T15:40:04 <hardy89> xorAxAx: i'll stick to schedule from now on and repair the rest of the modules and side by side work on mem leaks.
341 2011-06-22T15:40:13 <hardy89> xorAxAx: hmm...
342 2011-06-22T15:40:21 * hardy89 faces keyboard.
343 2011-06-22T15:40:43 <xorAxAx> hardy89: its fine to shuffle tasks around, please reflect that in the EP and coordinate with your very active mentor
344 2011-06-22T15:43:07 <xorAxAx> waldi:
345 2011-06-22T15:43:30 *** hardy89_
346 2011-06-22T15:43:54 <hardy89_> xorAxAx: i'm sorry. i'll work harder from now on.
347 2011-06-22T15:46:11 <hardy89_> waldi: ^
348 2011-06-22T15:46:33 *** hardy89
349 2011-06-22T15:46:34 *** hardy89_
350 2011-06-22T15:49:40 * xorAxAx detects a suboptimal meeting attendance ratio for waldi
351 2011-06-22T15:50:14 <sinha> dreimark: i tried adding it this way http://paste.pocoo.org/show/416951/, but getting NameError
352 2011-06-22T15:50:30 <sinha> `NameError: global name 'result_count' is not defined`
353 2011-06-22T15:53:19 <Marchael> ThomasWaldmann: are you reviewing? I want to update that code, because it contains useless prints
354 2011-06-22T16:03:04 * ThomasWaldmann is currently in a talk, so someone else please lead the meeeting
355 2011-06-22T16:05:23 <xorAxAx> welcome to our second meeting today
356 2011-06-22T16:05:37 <xorAxAx> please speak up if you are not there^W^Where
357 2011-06-22T16:05:48 <pkumar> hi
358 2011-06-22T16:05:57 <hardy89> hi
359 2011-06-22T16:05:59 <Marchael> hi
360 2011-06-22T16:06:00 <xorAxAx> dreimark: what about you?
361 2011-06-22T16:06:08 <sinha> hi
362 2011-06-22T16:06:23 <xorAxAx> looks like i am the only mentor
363 2011-06-22T16:06:45 <xorAxAx> i think Marchael should begin
364 2011-06-22T16:06:46 <pkumar> :)
365 2011-06-22T16:06:54 <Marchael> This weak I'm working on rebuild indexes script which currenlty can build indexes for all, latest or both revisions. Also it can clean index(es) before building.
366 2011-06-22T16:06:54 <Marchael> Also, I'm start working on updating indexes script which allows wiki admin to update indexes if wiki was interrupted and some documents wasn't writed to indexes.
367 2011-06-22T16:06:54 <Marchael> Next week I'll done update indexes script and will work on update indexes in MoinMoin.storage.backends.indexing
368 2011-06-22T16:06:54 <Marchael> Blockers: none
369 2011-06-22T16:07:18 <xorAxAx> Marchael: do you think that you are on time?
370 2011-06-22T16:08:20 <Marchael> nope, I should write better quality code, but I spend too much time on it
371 2011-06-22T16:08:37 <Marchael> but I trying
372 2011-06-22T16:08:58 <xorAxAx> have you talked to your mentor which things from your master plan to skip because you are behind schedule?
373 2011-06-22T16:09:55 <Marchael> no, Thomas are too busy now, and I talk with him when he will return
374 2011-06-22T16:10:06 <Marchael> from ep
375 2011-06-22T16:10:21 <xorAxAx> yeah
376 2011-06-22T16:10:27 <xorAxAx> next student, sinha
377 2011-06-22T16:10:39 <sinha> LAST: Completed paging feature for the history results
378 2011-06-22T16:10:39 <sinha> Changeset 1) without the option of taking count as input from user : https://bitbucket.org/sinha/moin2/changeset/511a2a2e9950
379 2011-06-22T16:10:39 <sinha> Changeset 2) input box to take count added in the usersettings page: (at rietveld, pushing it soon) http://codereview.appspot.com/4633059/
380 2011-06-22T16:10:39 <sinha> CURRENT:
381 2011-06-22T16:10:39 <sinha> 1) Working on improving the look at global history page (using icons etc)
382 2011-06-22T16:10:40 <sinha> 2) Adding paging option for item history results also.
383 2011-06-22T16:10:40 <sinha> (this might get completed by tomorrow)
384 2011-06-22T16:10:41 <sinha> NEXT: Probably, will start on alphabetically listing the gloabl index
385 2011-06-22T16:11:21 <xorAxAx> any blockers, sinha?
386 2011-06-22T16:11:56 <sinha> a little one, that i asked dreimark, may be he will answer when he returns
387 2011-06-22T16:12:10 <xorAxAx> ok
388 2011-06-22T16:12:39 <xorAxAx> ok, hardy89 is next
389 2011-06-22T16:12:55 <hardy89> LAST & BLOCKERS
390 2011-06-22T16:12:56 <hardy89> * Used gc.GARBAGE_LEAK for memory leaks problems. It should have given a list of an objects but it did not probably because of catching by output redirection of pytest and also because of my stupidity.
391 2011-06-22T16:12:56 <hardy89> * Used gc.collect() which returns random hex.
392 2011-06-22T16:13:06 <hardy89> NEXT
393 2011-06-22T16:13:06 <hardy89> * Will try use PyPy and reproducing the code to check if the leak is because of a bug in CPython or in the code itself, ONLY IF gc module does not work at all for me.
394 2011-06-22T16:13:06 <hardy89> * Need to catch up on the schedule, work on modules allotted to me, esp. storage mod and work on memory module side by side.
395 2011-06-22T16:13:35 * dreimark has a very unstable connection
396 2011-06-22T16:14:37 <xorAxAx> ok, pkumar next
397 2011-06-22T16:14:50 <pkumar> here it goes:
398 2011-06-22T16:14:51 <pkumar> I was working on making the tests faster.
399 2011-06-22T16:14:51 <pkumar> so, now the tests are significantly faster by approx 70-75 secs.
400 2011-06-22T16:14:51 <pkumar> also memory usage is about 200-225 mb less. It should be better after having some cleanup mechanism in tests I guess,
401 2011-06-22T16:14:51 <pkumar> As suggested by my mentor, also working on test cleanup, but seems like it needs more time.
402 2011-06-22T16:14:52 <pkumar> so, it's been added in TODO List in EP. This task would be scheduled some week soon.
403 2011-06-22T16:14:53 <pkumar> for blockers: though not a blocker as such, but ideas on the tasks in line 208 and 210 in EP would surely be helpful
404 2011-06-22T16:16:19 <xorAxAx> pkumar: i dont have any ad hoc ideas where complexity and duplication reside, maybe peek a bit in the code and ask thomas who likely added this task
405 2011-06-22T16:16:35 <ThomasWaldmann> pkumar: you should rather tell it takes 0.xx the time as before, secs are meaningless
406 2011-06-22T16:17:07 <pkumar> ThomasWaldmann : ok, I'll check and tell
407 2011-06-22T16:17:15 <pkumar> more precisely
408 2011-06-22T16:17:18 <pkumar> xorAxAx : ok
409 2011-06-22T16:18:25 <ThomasWaldmann> (same applies for memory usage somehow)
410 2011-06-22T16:18:50 <pkumar> ThomasWaldmann : ok
411 2011-06-22T16:19:11 <pkumar> will do it by today
412 2011-06-22T16:20:00 <ThomasWaldmann> and maybe as a general note: one can tell that a problem is fixed, if you can explain why it happened before and why it does not happen any more now
413 2011-06-22T16:20:42 <ThomasWaldmann> so, you have the bug, if you can point at it
414 2011-06-22T16:22:43 <pkumar> also, what about the new meeting timings?
415 2011-06-22T16:24:36 <pkumar> we had a doodle for that I guess :)
416 2011-06-22T16:27:27 <xorAxAx> pkumar: well, they depend on the organiser
417 2011-06-22T16:27:43 <xorAxAx> if he or she doesnt publish the time, it wont happen :)
418 2011-06-22T16:28:04 <pkumar> xorAxAx : yeah, :)
419 2011-06-22T16:28:25 <hardy89> bbl
420 2011-06-22T16:28:27 *** hardy89
421 2011-06-22T16:29:27 <xorAxAx> wasnt it hardy who is organising the new meeting time, pkumar?
422 2011-06-22T16:31:47 <pkumar> he had told me about this earlier, and I too was comfortable with the idea since this time clashes wit my mess timings
423 2011-06-22T16:31:52 <ThomasWaldmann> as his doodle was missing internationalisation as well as options for all days, i made a new one
424 2011-06-22T16:32:33 <ThomasWaldmann> but whoever wants a new time shall work on it, I am pretty indifferent about the time as long as I am awake at the time
425 2011-06-22T16:32:52 <dreimark> sinha: you need to define it in the init method also, and result_count sounds not good
426 2011-06-22T16:33:04 <xorAxAx> playing havoc with time planning is fun, aint it
427 2011-06-22T16:33:15 <xorAxAx> pkumar: so both please push more :)
428 2011-06-22T16:33:54 <sinha> dreimark: results_per_page ?
429 2011-06-22T16:34:04 <dreimark> better
430 2011-06-22T16:34:11 <pkumar> xorAxAx : ok, will try that :)
431 2011-06-22T16:35:25 <dreimark> sinha: in principle you can tell it in init that it is an int because the value becomes set later
432 2011-06-22T16:35:47 <Marchael> ThomasWaldmann: I use that C style while(True) because we need to iterate over 2 indexes(from revision and from backend)
433 2011-06-22T16:36:44 <ThomasWaldmann> i remember people who got larted to death because of programming C style in Python. :)
434 2011-06-22T16:37:29 <Marchael> also, count of revisions in backend for indexes and backend may differ from each other
435 2011-06-22T16:37:31 <Marchael> :)
436 2011-06-22T16:37:41 <dreimark> we have heard at the keynote you can even program fortran style in python but you have not
437 2011-06-22T16:37:46 <Marchael> but how can I avoid this?
438 2011-06-22T16:38:01 <ThomasWaldmann> Marchael: don't explain the algorithm to me, just use python syntax and formatting
439 2011-06-22T16:38:02 * dreimark needs a coffee and then a new akku
440 2011-06-22T16:38:51 <ThomasWaldmann> it is "while True:"
441 2011-06-22T16:39:50 <Marchael> I pasted my code to codereview
442 2011-06-22T16:40:00 <Marchael> with traceback :)
443 2011-06-22T16:40:39 <Marchael> ok, got it :)
444 2011-06-22T16:40:42 <Marchael> btw, while(True) working fine in 2.6
445 2011-06-22T16:41:51 *** pkumar
446 2011-06-22T16:42:17 <Marchael> ThomasWaldmann: also, backend uses os.path.mtime() for documents, but I convert it to datetime because whoosh can search only using datetime.
447 2011-06-22T16:43:36 <ThomasWaldmann> in that case it is not a thing of working vs. not working, but just of style
448 2011-06-22T16:43:45 <dreimark> sinha: see review
449 2011-06-22T16:44:09 * sinha seeing
450 2011-06-22T16:44:25 * dreimark gets now a coffee
451 2011-06-22T16:44:27 <dreimark> bbl
452 2011-06-22T16:44:58 <ThomasWaldmann> Marchael: and if you want me to review something specific, you give a URL so I do not have to waste time to search for it
453 2011-06-22T16:45:29 <Marchael> ok
454 2011-06-22T16:45:30 <ThomasWaldmann> or waste time to repeat myself because I told that already a few times in the recent past
455 2011-06-22T16:52:35 <sinha> ThomasWaldmann: i am trying to add default value for result_count_per_page in config/default file, but when i uses that value, I get a NameError, this is the diff for adding into config http://paste.pocoo.org/show/416982/
456 2011-06-22T16:52:49 <sinha> what am i doing wrong there ?
457 2011-06-22T16:55:44 <ThomasWaldmann> you don't need 110
458 2011-06-22T16:56:30 <sinha> ThomasWaldmann: yes previously i didnt use it, and then i was getting the same error, so i thought may be it required
459 2011-06-22T16:56:30 <ThomasWaldmann> and 400 is a naming vs. description inconsistency
460 2011-06-22T16:57:24 <ThomasWaldmann> but other than that, it looks ok for me
461 2011-06-22T16:57:51 <ThomasWaldmann> so, maybe the error is in the code where you try to use it?
462 2011-06-22T16:58:29 <sinha> ThomasWaldmann: Traceback http://paste.pocoo.org/show/416987/
463 2011-06-22T17:01:41 *** diofeher
464 2011-06-22T17:03:46 <ThomasWaldmann> sinha: from flask import current_app as app ; n = app.cfg.results_per_page
465 2011-06-22T17:04:53 <ThomasWaldmann> == there is some magic, but not like you expected (and having that as globals would be rather ugly anyway)
466 2011-06-22T17:07:26 <sinha> initially i have declared it in wikiconfig.py file, and was working fine from there, so thought it may work in this case also
467 2011-06-22T17:08:02 <sinha> anyways, doing it in correct way :)
468 2011-06-22T17:09:11 <ThomasWaldmann> maybe read about how python resolves names
469 2011-06-22T17:10:04 <ThomasWaldmann> brb
470 2011-06-22T17:18:27 <Marchael> ThomasWaldmann: If using iterator for checking last revision mtime in indexes is bad, then may be just update it from backend?
471 2011-06-22T17:19:21 <dreimark> re
472 2011-06-22T17:20:52 <ThomasWaldmann> Marchael: i don't understand your question
473 2011-06-22T17:20:53 <Marchael> Althought it just the same as rebuilding latest indexes
474 2011-06-22T17:21:10 <ThomasWaldmann> but in general you use an iterator to iterate over stuff
475 2011-06-22T17:41:54 * Marchael found a reason of AttributeError in traceback
476 2011-06-22T17:42:33 <Marchael> I tried to modify value in backend with incorrect type, it's rather obvious
477 2011-06-22T18:56:54 *** moinBot
478 2011-06-22T19:18:54 *** xorAxAx
479 2011-06-22T19:19:35 *** xorAxAx
480 2011-06-22T19:39:23 *** greg_f
481 2011-06-22T19:39:38 *** sinha
482 2011-06-22T19:39:51 *** sinha
483 2011-06-22T19:58:40 <Marchael> ThomasWaldmann: please, review http://codereview.appspot.com/4539114/diff/35005/MoinMoin/script/maint/update_indexes.py
484 2011-06-22T20:16:25 <Marchael> found one issue while testing
485 2011-06-22T20:16:33 <Marchael> s/issue/bug/
486 2011-06-22T20:32:33 <Marchael> seems like whoosh can't invert order of searcher.documents(uuid=uuid)
487 2011-06-22T20:37:16 <Marchael> but using functions for sorting is killing memory
488 2011-06-22T20:37:28 <Marchael> s/is/will/
489 2011-06-22T20:38:11 <Marchael> but I think what we need small whoosh hack
490 2011-06-22T20:38:17 <Marchael> ThomasWaldmann: ^
491 2011-06-22T20:47:05 <CIA-70> Akash Sinha <akash2607@gmail.com> * 82261b274b68 r269 default/MoinMoin/ (4 files in 4 dirs): Option to configure result count per page for pagination of history results, added in usersettings.
492 2011-06-22T20:47:05 <CIA-70> Akash Sinha <akash2607@gmail.com> * bba40d458d9e r270 default/MoinMoin/templates/global_history.html: minor change, a closing div tag corrected
493 2011-06-22T21:23:48 <Marchael> ThomasWaldmann: I fixed that issue, but now seems whoosh doesn't commited updated documents to index
494 2011-06-22T21:38:28 <Marchael> I don't understand, but whoosh really don't commiting changes to schema
495 2011-06-22T21:44:47 <Marchael> The fields of this documents almost equal(rev_no and mtime are different)
496 2011-06-22T21:44:57 <Marchael> s/documents/revisions/
497 2011-06-22T21:49:42 <Marchael> ThomasWaldmann: I put my changes to codereview http://codereview.appspot.com/4539114/patch/35007/51003 and debugging output http://paste.pocoo.org/show/417105/
498 2011-06-22T21:50:24 <Marchael> output doesn't changing for every time I run moin update_indexes
499 2011-06-22T21:56:26 <Marchael> gn/bbl
500 2011-06-22T23:55:35 *** sinha
501
