1 2011-06-06T00:02:49 *** fjacob
2 2011-06-06T00:54:20 *** RogerHaase
3 2011-06-06T00:56:20 *** m4k3r
4 2011-06-06T01:08:02 *** MattMaker
5 2011-06-06T01:32:41 *** MattMaker
6 2011-06-06T01:49:59 *** ronny
7 2011-06-06T01:52:26 *** ronny
8 2011-06-06T02:15:50 *** jek
9 2011-06-06T02:15:50 *** jek
10 2011-06-06T02:19:10 *** grzywacz
11 2011-06-06T02:23:47 *** Marchael
12 2011-06-06T03:11:37 *** Marchael
13 2011-06-06T05:09:42 *** Marchael
14 2011-06-06T05:16:47 *** MattMaker
15 2011-06-06T05:25:09 *** Marchael
16 2011-06-06T05:59:16 *** MattMaker
17 2011-06-06T06:39:36 *** Marchael
18 2011-06-06T06:56:50 <eSyr> btw, does anyone know, which python binding for gdchart should be used for stats charts? I've found two (one in debian repo and one over the internet), but none of them have suited.
19 2011-06-06T07:01:59 *** m4k3r
20 2011-06-06T07:38:39 *** m4k3r
21 2011-06-06T07:55:14 <ThomasWaldmann> eSyr: iirc it is gdchart 1, which is not maintained any more, so better forget it
22 2011-06-06T08:10:59 <eSyr> oook.
23 2011-06-06T08:32:21 *** gwork
24 2011-06-06T09:24:27 <dreimark> moin
25 2011-06-06T09:41:01 *** m4k3r
26 2011-06-06T09:52:04 *** m4k3r
27 2011-06-06T10:21:51 <ronny> moin
28 2011-06-06T11:10:53 *** greg_f
29 2011-06-06T11:23:08 *** sinha
30 2011-06-06T11:40:23 *** fjacob
31 2011-06-06T12:13:33 *** fjacob
32 2011-06-06T12:17:27 *** raignarok
33 2011-06-06T12:18:59 <ThomasWaldmann> https://bitbucket.org/89hardy/pytest_moin/changeset/e18eb0e986ab
34 2011-06-06T12:19:02 <ThomasWaldmann> waldi: ^^
35 2011-06-06T12:23:41 <ThomasWaldmann> and also tell your student that diary updates have to happen daily (on work days). no entries for non-work days.
36 2011-06-06T12:26:20 <sinha> ThomasWaldmann: you told yesterday to use revno to number the comments, so is this ok http://www.moinmo.in/AkashSinha/Gsoc2011Diary/2011-06-05?action=AttachFile&do=view&target=historygrouping1.png ?
37 2011-06-06T12:29:30 <ThomasWaldmann> the left column in the marked area is linking to a single change diff?
38 2011-06-06T12:31:48 <sinha> no diff between two revisions
39 2011-06-06T12:32:19 <sinha> like for revision 4 showing there, the diff will be between rev1=3 and rev2=2
40 2011-06-06T12:32:41 <ThomasWaldmann> huh?
41 2011-06-06T12:32:43 <sinha> since our revision starts from 0, i had to do a increament in rev number to show there
42 2011-06-06T12:33:00 <sinha> yes i know thats little wierd
43 2011-06-06T12:33:15 <sinha> but if a start from 0
44 2011-06-06T12:33:22 <ThomasWaldmann> didn't we talk about directly using the revno?
45 2011-06-06T12:33:43 <sinha> but comment will be marked as 0th comment, then
46 2011-06-06T12:34:43 <ThomasWaldmann> no, it will be marked as comment for revno 0
47 2011-06-06T12:35:13 <ThomasWaldmann> which is just a different interpretation of the number
48 2011-06-06T12:35:24 <sinha> and the position beside the editor name will have [0-1] like this ? will it be ok
49 2011-06-06T12:35:46 <ThomasWaldmann> yes, it is all about revnos then
50 2011-06-06T12:36:35 <sinha> ok fine for me, cleared my confusion there
51 2011-06-06T12:37:06 <sinha> and reg namedtuple is it supported in version < 2.7
52 2011-06-06T12:37:46 <ThomasWaldmann> find out. it must work on 2.6. and as you should use 2.6 for development, you'll notice quickly.
53 2011-06-06T12:41:03 <sinha> and reg the list usage, i am using list at places where i cant use any other data structure (i need to append data which cant be done in case of tuples) so there are few lines left (3-4) which have that [idx] usage ? any comment on this ?
54 2011-06-06T12:43:43 <ThomasWaldmann> well, maybe you need to combine them appropriately?
55 2011-06-06T12:44:15 *** raignarok
56 2011-06-06T12:45:06 <ThomasWaldmann> if you need to use [0] and [1:] just because 0 is something different than all the rest, but all the rest being the same somehow, you are doing it wrong
57 2011-06-06T12:45:40 <sinha> okay i have skipped that cases
58 2011-06-06T12:45:55 <sinha> currently one list has same type of data
59 2011-06-06T12:47:12 <ThomasWaldmann> well, post the code on codereview to get more specific comments
60 2011-06-06T12:47:57 <sinha> okay
61 2011-06-06T13:22:23 <ronny> oO
62 2011-06-06T13:23:30 <ronny> ThomasWaldmann, waldi uppon a quick skimming it seems hardy does random pytest2 things on the default branch while ignoring the pytest2 branch
63 2011-06-06T13:34:23 <ThomasWaldmann> well, maybe it wasn't a good idea to use a branch for hg newbies
64 2011-06-06T13:35:11 <ThomasWaldmann> but that is just another reason to re-start that repo from scratch
65 2011-06-06T14:48:03 *** pkumar
66 2011-06-06T16:19:25 <sinha> bbl
67 2011-06-06T16:19:27 *** sinha
68 2011-06-06T16:44:33 <pkumar> bbl
69 2011-06-06T16:44:37 *** pkumar
70 2011-06-06T16:55:59 *** jek
71 2011-06-06T17:22:01 <Marchael> moin
72 2011-06-06T17:23:04 *** hardy89
73 2011-06-06T17:23:55 <Marchael> ThomasWaldmann: about meta[ACL]. I look on some examples in ./build/lib/MoinMoin/storage/_tests/test_middleware_acl.py. So, seems like I should do the same things as in create_item_acl(), right?
74 2011-06-06T17:32:25 *** jek
75 2011-06-06T17:49:09 *** gwork
76 2011-06-06T17:57:01 <ThomasWaldmann> hi Marchael
77 2011-06-06T17:57:59 <Marchael> this stuff using flask.g for creating items in backed, but I don't wan it
78 2011-06-06T17:58:09 <Marchael> *backend
79 2011-06-06T17:58:28 <ThomasWaldmann> you mean if you want to create test items for indexing?
80 2011-06-06T17:59:11 <Marchael> hm, no I mean meta[ACL]
81 2011-06-06T17:59:27 <ThomasWaldmann> well, you need to ask more specifically
82 2011-06-06T17:59:55 * ThomasWaldmann has no clue what you want to do
83 2011-06-06T18:00:48 * Marchael want that whoosh can understand our ACL list
84 2011-06-06T18:01:19 * Marchael looking for a way how to make unicode string from list
85 2011-06-06T18:01:56 <Marchael> but I'm still don't understand how meta[ACL] can helps me with this
86 2011-06-06T18:02:40 <ThomasWaldmann> the value type of ACL in metadata is a unicode string, exactly what you need
87 2011-06-06T18:03:21 <ThomasWaldmann> don't make problems without reasons, there are enough real ones to solve :)
88 2011-06-06T18:04:44 <ThomasWaldmann> (until one of my latest changesets there was some code that also supported lists, but I removed that)
89 2011-06-06T18:05:04 <ThomasWaldmann> (it wasn't used anyway)
90 2011-06-06T18:06:51 <Marchael> I'm looking in ./build/lib/MoinMoin/storage/_tests/test_middleware_acl.py but have no idea what you mean
91 2011-06-06T18:07:40 <Marchael> may be that stupid, but I couldn't find any meta[ACL] in that code
92 2011-06-06T18:09:31 <ThomasWaldmann> btw, why are you looking in build?
93 2011-06-06T18:10:03 <Marchael> mm, strange
94 2011-06-06T18:10:16 <ThomasWaldmann> that's temporary stuff and should be same as in your workdir
95 2011-06-06T18:10:35 <Marchael> before I merged with your repo find . -name test_middleware_acl.py shows only ./build/lib/MoinMoin/storage/_tests/test_middleware_acl.py
96 2011-06-06T18:11:20 <Marchael> buy now ./MoinMoin/storage/_tests/test_middleware_acl.py appeared :)
97 2011-06-06T18:11:36 <ThomasWaldmann> maybe you called find the wrong way somehow
98 2011-06-06T18:11:56 <Marchael> s/buy/but/
99 2011-06-06T18:12:03 <ThomasWaldmann> btw, do you know mc?
100 2011-06-06T18:12:47 <Marchael> yes, but I don't use it
101 2011-06-06T18:12:48 <ThomasWaldmann> (if you have ever worked with norton commander or compatible stuff, that's the linux clone of it)
102 2011-06-06T18:13:00 <ThomasWaldmann> includes a nice search function
103 2011-06-06T18:13:48 <ThomasWaldmann> the important part of meta[ACL] is the ACL (case-sensitive)
104 2011-06-06T18:13:58 <ThomasWaldmann> can be also rev[ACL] or whatever
105 2011-06-06T18:14:18 <ThomasWaldmann> but the whole point was that you find out it is unicode, not a list of unicode
106 2011-06-06T18:14:54 <Marchael> I know how to use searching in code :)
107 2011-06-06T18:17:42 *** raignarok
108 2011-06-06T18:18:13 <ThomasWaldmann> btw, upload your code to codereview now and then to get feedback
109 2011-06-06T18:20:52 *** jek
110 2011-06-06T18:20:52 *** jek
111 2011-06-06T18:21:46 <Marchael> what url?
112 2011-06-06T18:26:56 <ThomasWaldmann> http://codereview.appspot.com/
113 2011-06-06T18:27:46 <ThomasWaldmann> just click on create issue and then use the upload.py it offers there. it works with mercurial.
114 2011-06-06T18:28:35 *** raignarok_
115 2011-06-06T18:29:08 *** raignarok__
116 2011-06-06T18:29:35 <ThomasWaldmann> interesting
117 2011-06-06T18:30:22 <ThomasWaldmann> raignarok_: raignarok__: you use 2 dsl accounts? :)
118 2011-06-06T18:32:36 *** raignarok
119 2011-06-06T18:33:20 *** raignarok_
120 2011-06-06T18:33:25 *** raignarok__
121 2011-06-06T18:33:38 <Marchael> oh, that stuff wants my mail password
122 2011-06-06T18:33:55 <ThomasWaldmann> you can use your google account to log in
123 2011-06-06T18:34:16 <ThomasWaldmann> appspot = google appengine farm
124 2011-06-06T18:34:23 <Marchael> http://codereview.appspot.com/4580042
125 2011-06-06T18:34:36 <Marchael> but seems like I do something wrong
126 2011-06-06T18:34:47 <raignarok> well, actually i needed a new IP and did a reconnect.. and as I couldn't believe the new fritzbox did this so fast as compared to the old router, i reconnected again ;)
127 2011-06-06T18:35:00 <Marchael> argh
128 2011-06-06T18:35:06 <ThomasWaldmann> is that all? :)
129 2011-06-06T18:35:09 <ThomasWaldmann> Marchael:
130 2011-06-06T18:35:20 <Marchael> no
131 2011-06-06T18:35:29 <Marchael> I forgot to add new files to repo
132 2011-06-06T18:35:50 <ThomasWaldmann> raignarok: ah. it just looked strange because two join messages appeared at the same time here.
133 2011-06-06T18:36:30 <Marchael> http://codereview.appspot.com/4539114
134 2011-06-06T18:37:15 <ThomasWaldmann> btw, make sure you use same id if you "update" the code there after you fixed stuff found in review, so it ends up at the same place and does not create a new id
135 2011-06-06T18:38:40 <Marchael> http://codereview.appspot.com/4539114 here I try working with acl
136 2011-06-06T18:38:48 <Marchael> http://codereview.appspot.com/4539114/patch/1/2
137 2011-06-06T18:41:40 <Marchael> I got this traceback when pytesting test_acl.py http://paste.pocoo.org/show/401696/
138 2011-06-06T18:50:07 <ThomasWaldmann> ok, reviewed
139 2011-06-06T18:50:15 <ThomasWaldmann> fix the stuff please
140 2011-06-06T18:50:54 <ThomasWaldmann> you need to have admin rights to change ACLs
141 2011-06-06T18:52:58 <ThomasWaldmann> and maybe you do not need a test_acl.py file in the end. you tested the acl tokenizer already.
142 2011-06-06T18:53:32 <ThomasWaldmann> so, currently it is mostly about testing the indexing.
143 2011-06-06T18:56:32 <Marchael> > It is unicode, not a list of unicode.
144 2011-06-06T18:56:32 <Marchael> So, why whoosh raises error if I try use this string?
145 2011-06-06T18:56:55 <ThomasWaldmann> traceback > pastebin
146 2011-06-06T18:58:23 <Marchael> ok, but first I fix errors in test_indexing.py
147 2011-06-06T19:00:08 <ThomasWaldmann> Subject: No (issue4539114)
148 2011-06-06T19:00:10 *** RogerHaase
149 2011-06-06T19:00:32 <ThomasWaldmann> i guess it wanted some description of your changeset there, like "whoosh indexing work" or so
150 2011-06-06T19:02:14 <Marchael> hm, ok I add that later
151 2011-06-06T19:02:26 <Marchael> build/lib/MoinMoin/search/ is that directory for tests?
152 2011-06-06T19:02:36 <Marchael> I mean temp files
153 2011-06-06T19:06:06 <ThomasWaldmann> no
154 2011-06-06T19:06:17 <ThomasWaldmann> rm -rf build :)
155 2011-06-06T19:07:55 <ThomasWaldmann> self.tempdir = tempfile.mkdtemp('', 'moin-')
156 2011-06-06T19:08:18 <ThomasWaldmann> and clean it up when finished
157 2011-06-06T19:23:18 <RogerHaase> ThomasWaldmann: dreimark: I updated transclusion overlay patch again: http://codereview.appspot.com/4535086
158 2011-06-06T19:25:17 <RogerHaase> clicking the transclusion overlay with the mouse middle button to open a new window/tab works in every browser I tested except Firefox :-(
159 2011-06-06T19:26:17 <dreimark> o.o
160 2011-06-06T19:26:52 <dreimark> btw. because also svg-edit uses right mouseclick for context menue, we should discuss that too
161 2011-06-06T19:27:07 <dreimark> htg, bbl
162 2011-06-06T19:30:03 <Marchael> ThomasWaldmann http://codereview.appspot.com/4539114/
163 2011-06-06T19:31:39 <Marchael> also there is traceback for this code http://paste.pocoo.org/show/401720/
164 2011-06-06T19:42:06 <ThomasWaldmann> RogerHaase: huh? strange.
165 2011-06-06T19:42:20 <ThomasWaldmann> i use the MMB with ordinary links all day.
166 2011-06-06T19:45:23 *** greg_f
167 2011-06-06T19:46:54 <ThomasWaldmann> Marchael: what do you see in line 27 of that traceback?
168 2011-06-06T19:47:20 <Marchael> "------"
169 2011-06-06T19:47:22 <RogerHaase> ThomasWaldmann: Firefox does not consider the MMB a click event. Javascript can detect the MMB with a mousedown or mouseup event, but then FF and IE complain of blocked popups and assorted other bad things happen.
170 2011-06-06T19:47:55 <ThomasWaldmann> hmm, sucks :|
171 2011-06-06T19:48:22 <ThomasWaldmann> looks like we can't easily emulate normal link behaviour
172 2011-06-06T19:48:32 <RogerHaase> I am beginning to like chrome and ie 9.
173 2011-06-06T19:48:56 <ThomasWaldmann> O.O
174 2011-06-06T19:49:45 <ThomasWaldmann> RogerHaase: one idea, not sure it it makes stuff easier: instead of using something different than <a> for the inner thing, we could also dynamically change the outer <a> to something different maybe?
175 2011-06-06T19:50:21 <ThomasWaldmann> or even patch the outer thing so it acts like what we added inside? :)
176 2011-06-06T19:51:08 <ThomasWaldmann> Marchael: acl=[u'JoeDoe:read,write'],
177 2011-06-06T19:51:15 <ThomasWaldmann> that's line 27 for me
178 2011-06-06T19:51:44 *** hardy89
179 2011-06-06T19:51:58 <Marchael> oops, wrong traceback :)
180 2011-06-06T19:52:33 <Marchael> yes, I see, something wrong with this line?
181 2011-06-06T19:53:20 <ThomasWaldmann> correct traceback please
182 2011-06-06T19:54:08 <RogerHaase> Well, that would be a different approach. In [[SomePage|{{SomeLogo}}]] the outer thing is also an image that could be MMBed.
183 2011-06-06T19:55:22 <Marchael> ThomasWaldmann: you see correct traceback, I just confuse it with other
184 2011-06-06T19:59:44 <ThomasWaldmann> ok, what is the data type you give to acl there?
185 2011-06-06T20:00:16 <Marchael> list with unicode line
186 2011-06-06T20:00:19 <Marchael> *sting
187 2011-06-06T20:01:08 <ThomasWaldmann> and what do you read in line 92?
188 2011-06-06T20:01:41 <Marchael> > E ValueError: [u'JoeDoe:read,write'] is not unicode
189 2011-06-06T20:01:52 <Marchael> hm
190 2011-06-06T20:02:06 <RogerHaase> ThomasWaldmann: I will make up a jsfiddle example and post to a jquery board to see if there are any ideas that would work. But I am thinking this is another issue like Firefox not doing word breaks within tables.
191 2011-06-06T20:02:59 <ThomasWaldmann> RogerHaase: thanks for investigating :)
192 2011-06-06T20:03:08 <ThomasWaldmann> Marchael: so, conclusion?
193 2011-06-06T20:04:07 <Marchael> I should give unicode string as input
194 2011-06-06T20:04:29 <ThomasWaldmann> yeah.
195 2011-06-06T20:05:05 <ThomasWaldmann> i am telling you that since some days, but somehow the message didn't reach the target.
196 2011-06-06T20:05:24 <Marchael> :)
197 2011-06-06T20:06:08 <ThomasWaldmann> do you have troubles to understand my english?
198 2011-06-06T20:07:26 <Marchael> few minutes ago I put test_acl.py on codereview, there is example when I try to use meta[ACL]
199 2011-06-06T20:07:51 <ThomasWaldmann> give a link to it
200 2011-06-06T20:07:59 <ThomasWaldmann> (most stuff there is linkable)
201 2011-06-06T20:08:22 <ThomasWaldmann> gtg/brb
202 2011-06-06T20:16:11 *** sinha
203 2011-06-06T20:41:28 <ThomasWaldmann> re
204 2011-06-06T20:45:45 <Marchael> seems like whoosh requires .pos from tokenizer
205 2011-06-06T20:45:55 *** hardy89
206 2011-06-06T20:49:42 <Marchael> gn/bbl
207 2011-06-06T21:13:24 <sinha> ThomasWaldmann: can i push my current changes ? i have uploaded them at rietveld for eeview
208 2011-06-06T21:15:17 <sinha> s/eeview/review
209 2011-06-06T21:15:27 *** m4k3r
210 2011-06-06T21:44:25 <ThomasWaldmann> give url
211 2011-06-06T22:29:59 <sinha> ThomasWaldmann: http://codereview.appspot.com/4539113/
212 2011-06-06T22:35:37 *** m4k3r
213 2011-06-06T22:49:40 <dreimark> re
214 2011-06-06T22:52:53 <dreimark> sinha: explain item_info["action"] = current_rev.get(ACTION)
215 2011-06-06T22:53:11 <dreimark> and all similiar, i think i added about that a comment already
216 2011-06-06T22:53:16 <dreimark> last time
217 2011-06-06T22:54:16 <sinha> dreimark: i have also asked for example there, i didnt got your point
218 2011-06-06T22:57:44 <dreimark> print ACTION ?
219 2011-06-06T22:57:51 <dreimark> sinha: ^
220 2011-06-06T22:58:23 <dreimark> if you use the varibales isn't it more flexible?
221 2011-06-06T22:59:05 * dreimark is redoing other comments
222 2011-06-06T23:00:40 <dreimark> if the value of ACTION becomes changed, we have to change your code
223 2011-06-06T23:00:50 <dreimark> so why not using this patameter
224 2011-06-06T23:01:00 <dreimark> and the others
225 2011-06-06T23:02:55 <sinha> you want me to replace that ACTION by a variable ? and use that variable also in the key for dict ?
226 2011-06-06T23:08:13 <ThomasWaldmann> btw, the point of this ACTION constant is that typos in it lead to an error (typos in strings don't)
227 2011-06-06T23:09:56 <ThomasWaldmann> sinha: did you begin a new codereview instead of continuing the last one?
228 2011-06-06T23:12:19 <sinha> yes i have uploaded it again
229 2011-06-06T23:13:44 <sinha> last time also tried to include it in earlier review, but it failed somehow ? remember ?
230 2011-06-06T23:14:20 <dreimark> well i think it should use the same value and not a guessed one
231 2011-06-06T23:14:42 <dreimark> and if the guessed one is the same it can be the same var used
232 2011-06-06T23:27:32 <ThomasWaldmann> review done
233 2011-06-06T23:27:56 <ThomasWaldmann> sinha: python upload.py --help
234 2011-06-06T23:30:47 * dreimark too
235 2011-06-06T23:35:55 <sinha> ThomasWaldmann: Reg that translation of [1].. in global_history.html file , i though 5 may be written as 'V' in Roman, so put the translation ? doesnt this happen ?
236 2011-06-06T23:42:15 <ThomasWaldmann> we have no latin translation :P
237 2011-06-06T23:42:26 <ThomasWaldmann> and most romans are dead anyway :D
238 2011-06-06T23:45:33 <ThomasWaldmann> (and even if we had that, such stuff can't be handled by a gettext style translation function)
239 2011-06-06T23:46:55 <sinha> okay will remove that :)
