1 2011-06-04T00:02:48 <ThomasWaldmann> RogerHaase: done
2 2011-06-04T00:03:24 <sinha> dreimark: any comments for now ?
3 2011-06-04T00:04:04 <dreimark> sinha: i had read backlog and you seems to be prepared to solve it by ordered dict now
4 2011-06-04T00:04:17 <dreimark> and also seen your reply
5 2011-06-04T00:04:19 <sinha> yes, took lots of time
6 2011-06-04T00:04:35 <sinha> but done finally
7 2011-06-04T00:04:42 <dreimark> :)
8 2011-06-04T00:11:16 <ThomasWaldmann> sinha: please clean up your spacing
9 2011-06-04T00:11:36 <ThomasWaldmann> and be more careful in future (i already told you this some time ago)
10 2011-06-04T00:12:08 <ThomasWaldmann> https://bitbucket.org/sinha/moin2/changeset/72dbe801338e#chg_MoinMoin/apps/frontend/views.py_newline559
11 2011-06-04T00:12:27 <sinha> ThomasWaldmann: yes i remember that, was careful also but somehow left some :(
12 2011-06-04T00:13:58 <RogerHaase> ThomasWaldmann: I pushed transclusions change to bitbucket
13 2011-06-04T00:14:00 <dreimark> sinha: if you look sometimes with python.vim on it or run the test_sourcecode you'll see
14 2011-06-04T00:14:10 <ThomasWaldmann> https://bitbucket.org/sinha/moin2/changeset/72dbe801338e#chg_MoinMoin/apps/frontend/views.py_newline570
15 2011-06-04T00:14:27 <ThomasWaldmann> https://bitbucket.org/sinha/moin2/changeset/72dbe801338e#chg_MoinMoin/apps/frontend/views.py_newline576
16 2011-06-04T00:14:34 <dreimark> http://moinmo.in/CodingStyle
17 2011-06-04T00:15:04 <ThomasWaldmann> https://bitbucket.org/sinha/moin2/changeset/72dbe801338e#chg_MoinMoin/apps/frontend/views.py_newline584 -> x += 1
18 2011-06-04T00:15:51 <dreimark> sinha: please use string substitution
19 2011-06-04T00:16:27 <ThomasWaldmann> https://bitbucket.org/sinha/moin2/changeset/72dbe801338e#chg_MoinMoin/apps/frontend/views.py_newline600 please read about operator precedence in python
20 2011-06-04T00:16:43 <ThomasWaldmann> https://bitbucket.org/sinha/moin2/changeset/72dbe801338e#chg_MoinMoin/apps/frontend/views.py_newline603
21 2011-06-04T00:16:52 <ThomasWaldmann> https://bitbucket.org/sinha/moin2/changeset/72dbe801338e#chg_MoinMoin/apps/frontend/views.py_newline605
22 2011-06-04T00:17:04 <ThomasWaldmann> https://bitbucket.org/sinha/moin2/changeset/72dbe801338e#chg_MoinMoin/apps/frontend/views.py_newline606
23 2011-06-04T00:18:40 <dreimark> why str ?
24 2011-06-04T00:19:33 <ThomasWaldmann> https://bitbucket.org/sinha/moin2/changeset/72dbe801338e#chg_MoinMoin/templates/global_history.html_newline21 ugly usage of [idx]
25 2011-06-04T00:19:49 <ThomasWaldmann> ...
26 2011-06-04T00:19:59 <ThomasWaldmann> i strongly suggest you use rietveld in future
27 2011-06-04T00:20:22 <sinha> ThomasWaldmann: will do.
28 2011-06-04T00:20:33 <ThomasWaldmann> and you read your diffs before posting them there and fix all trivial stuff yourself
29 2011-06-04T00:24:56 <dreimark> pos_str = "["+pos_str+"]" use for that and similiar substitutions
30 2011-06-04T00:26:02 <sinha> used in editor grouping and to show which revision belong to him,eg. Akash [1-2,4] ..
31 2011-06-04T00:26:16 <dreimark> ok
32 2011-06-04T00:26:47 <sinha> here is the screen shot http://www.moinmo.in/AkashSinha/Gsoc2011Diary/2011-06-04?action=AttachFile&do=get&target=historygrouping.png
33 2011-06-04T00:27:03 <ThomasWaldmann> about that [idx] usage all over the place: you can use a tuple assignment in the for statement
34 2011-06-04T00:27:11 <dreimark> it is a question if it makes sense to show all rev diffs then and no span
35 2011-06-04T00:27:25 <ThomasWaldmann> for a, b, c, d in tuples: ...
36 2011-06-04T00:28:24 <sinha> okay, wasn't aware of that
37 2011-06-04T00:29:52 <sinha> ThomasWaldmann: Regarding this https://bitbucket.org/sinha/moin2/changeset/72dbe801338e#chg_MoinMoin/templates/global_history.html_newline21 , you are pointing towards that rev.action substitution ?
38 2011-06-04T00:32:26 <ThomasWaldmann> ?
39 2011-06-04T00:33:23 <ThomasWaldmann> it looks like you replaced the revision objects by tuples
40 2011-06-04T00:33:33 <sinha> yes
41 2011-06-04T00:33:45 <ThomasWaldmann> if you split the tuples into componentents in the for statement, this gets much more readable
42 2011-06-04T00:33:56 <ThomasWaldmann> an alternative is using namedtuples
43 2011-06-04T00:34:03 <ThomasWaldmann> or dicts
44 2011-06-04T00:34:19 <sinha> will try them.
45 2011-06-04T00:35:04 * dreimark is too tired from travelling today - good night
46 2011-06-04T00:36:09 <ThomasWaldmann> gn dreimark
47 2011-06-04T00:37:24 <ThomasWaldmann> sinha: btw, operator precedence in python is quite "natural" (unlike C), so parens are often not needed
48 2011-06-04T00:37:36 <sinha> yes thats why i left it out
49 2011-06-04T00:37:56 <sinha> i tested the code first without parenthesis then used there
50 2011-06-04T00:41:53 * sinha feeling sleepy now, gn
51 2011-06-04T00:42:26 *** sinha
52 2011-06-04T00:48:01 *** pkumar
53 2011-06-04T00:49:36 *** m4k3r
54 2011-06-04T00:50:30 *** RogerHaase
55 2011-06-04T01:48:57 *** ronny
56 2011-06-04T01:51:28 *** ronny
57 2011-06-04T03:33:15 *** m4k3r
58 2011-06-04T08:27:12 *** Marchael
59 2011-06-04T08:36:15 <Marchael> moin
60 2011-06-04T08:37:54 <dreimark> moin
61 2011-06-04T08:58:21 <Marchael> ThomasWaldmann: I update code on ep, please look
62 2011-06-04T09:12:03 <dreimark> how can we avoid that for download an item becomes rendered in the browser if that is possible
63 2011-06-04T09:12:29 <dreimark> e.g. if I want to download an svg with an embedded image
64 2011-06-04T09:12:44 <dreimark> then in history I see it as one file
65 2011-06-04T09:13:16 <dreimark> e.g. size is 371993
66 2011-06-04T09:13:35 <dreimark> there the data is completly in the items file
67 2011-06-04T09:13:59 <dreimark> but if I involve the browser for downloading
68 2011-06-04T09:14:49 <dreimark> then downloading is managed to have one svg file plus a directory e.g. historygrouping_files with the png.
69 2011-06-04T09:16:43 <dreimark> the naming of the directory is locale dependent
70 2011-06-04T09:19:07 <dreimark> if I upload the svg again it is only my annotation shown.
71 2011-06-04T09:19:28 <dreimark> if I do the same in inkscape it also loads the image
72 2011-06-04T10:41:22 <Marchael> ThomasWaldmann: In what time are you will be here?
73 2011-06-04T11:42:10 *** greg_f
74 2011-06-04T12:11:18 <ThomasWaldmann> moin
75 2011-06-04T14:27:27 <Marchael> ThomasWaldmann: please, look at ep
76 2011-06-04T14:38:36 <ThomasWaldmann> you already asked that 1 or 2 days ago and the answer is still the same
77 2011-06-04T14:40:57 <Marchael> I asked, but it was other trouble
78 2011-06-04T14:41:59 <ThomasWaldmann> your analyser/tokenizers do not implement the expected api (call params)
79 2011-06-04T14:42:27 <ThomasWaldmann> just look at some standard a/t in whoosh and use the same params
80 2011-06-04T14:58:50 *** m4k3r
81 2011-06-04T14:59:25 *** franklin
82 2011-06-04T15:00:15 *** franklin_
83 2011-06-04T15:15:16 <Marchael> strange
84 2011-06-04T15:15:40 <Marchael> seems like I should use __new__() instead of __call__()
85 2011-06-04T15:16:01 <Marchael> Althought all a/t using __call__()
86 2011-06-04T15:16:38 <ThomasWaldmann> no, not __new__
87 2011-06-04T15:17:48 *** sinha
88 2011-06-04T15:17:52 <ThomasWaldmann> but you need to give an instance, not the class
89 2011-06-04T15:18:00 <Marchael> I know what it strange, but it's somehow work with __new__
90 2011-06-04T15:20:28 <ThomasWaldmann> that's because class instantiation is X() and calling is x()
91 2011-06-04T15:20:54 <ThomasWaldmann> but still, you want call
92 2011-06-04T15:27:34 <Marchael> but seems like it want what __new__() do the same things as __call__()
93 2011-06-04T15:29:17 <Marchael> s/it want//
94 2011-06-04T15:30:05 <Marchael> because when I renamed __call__ -> __new__ it works
95 2011-06-04T15:31:29 <ThomasWaldmann> how about just doing it right? :)
96 2011-06-04T15:32:59 * Marchael trying
97 2011-06-04T15:33:45 <ThomasWaldmann> you may have noticed that what it expects at that place is something that behaves like a function.
98 2011-06-04T15:34:04 <Marchael> ah
99 2011-06-04T15:34:38 <ThomasWaldmann> that is, either a function (obviously), or a class that implements __call__ (and thus, an instance of that class behaves like a function and can be called)
100 2011-06-04T15:35:45 <Marchael> You mean something like this http://paste.pocoo.org/show/400575/ ?
101 2011-06-04T15:38:23 <ThomasWaldmann> why don't you just look at existing code in whoosh?
102 2011-06-04T15:39:19 <ThomasWaldmann> whoosh/analysis.py
103 2011-06-04T15:40:56 <ThomasWaldmann> and also check the place where you use your analysers/tokenizers. if you used a class to implement, you need T(...), not T
104 2011-06-04T15:44:48 * ThomasWaldmann brb in 20mins
105 2011-06-04T16:07:00 *** m4k3r_
106 2011-06-04T16:07:18 *** Marchael
107 2011-06-04T16:08:07 *** m4k3r
108 2011-06-04T16:08:08 *** Marchael
109 2011-06-04T16:14:42 *** Marchael
110 2011-06-04T16:44:29 *** sinha
111 2011-06-04T16:55:56 <ThomasWaldmann> re
112 2011-06-04T17:49:07 *** RogerHaase
113 2011-06-04T18:06:57 <dreimark> re
114 2011-06-04T18:35:07 * ThomasWaldmann thinks about dataflow and uuid generation
115 2011-06-04T18:38:03 <ThomasWaldmann> http://etherpad.osuosl.org/moin-uuid
116 2011-06-04T19:34:29 *** greg_f
117 2011-06-04T20:03:46 *** m4k3r_
118 2011-06-04T20:08:24 *** m4k3r
119 2011-06-04T20:23:19 *** sinha
120 2011-06-04T21:21:14 * dreimark looks at stx2any
121 2011-06-04T21:26:30 *** m4k3r
122 2011-06-04T21:26:47 *** m4k3r
123 2011-06-04T21:41:02 <sinha> dreimark: there is a existing implementation in the file utils.html to parse editor data http://hg.moinmo.in/moin/2.0/file/4654343b5abd/MoinMoin/templates/utils.html#l1 which i am using it here https://bitbucket.org/sinha/moin2/changeset/72dbe801338e#chg_MoinMoin/templates/global_history.html_newline45 , there is only one basic difference that here i have editro info already but in that utils.html it is fetching, so do you suggest writing a new macro to do
124 2011-06-04T21:41:20 <sinha> s/editro/editor
125 2011-06-04T21:43:50 <dreimark> sinha: please rephrase, what is the question
126 2011-06-04T21:46:42 <sinha> dreimark: my question is, i am doing parsing for editor data in my template file, but similar implementation is present in utils.html file with slight difference, so i want to write a new macro in that utils.html file which can be used by both of them and the code get reduced by few lines
127 2011-06-04T21:47:29 <sinha> so i want to know that whether i can create the macro which is being called from the same file
128 2011-06-04T21:51:12 <dreimark> sinha: yes that's good but please show it before pushing
129 2011-06-04T21:51:30 <dreimark> you can modify it for your needs
130 2011-06-04T21:51:38 <sinha> yes i will show them
131 2011-06-04T21:51:49 <dreimark> but also it should run on the other places
132 2011-06-04T21:51:49 <ThomasWaldmann> maybe first check the calling code
133 2011-06-04T21:52:21 <ThomasWaldmann> and please show a current version with the cleanups done we talked yesterday about
134 2011-06-04T22:03:18 <ThomasWaldmann> and use rietveld
135 2011-06-04T22:07:36 <RogerHaase> ThomasWaldmann: re. http://codereview.appspot.com/4535086/ : I misunderstood your "done" comment yesterday. I have replied to your comments a few minutes ago.
136 2011-06-04T22:12:39 <ThomasWaldmann> RogerHaase: about the trailing blanks: i don't see it any more either. yesterday it looked strange, like with 100 trailing blanks or so.
137 2011-06-04T22:14:00 <RogerHaase> ah, I think I have seen that effect as well and didn't understand what it was.
138 2011-06-04T22:15:04 <ThomasWaldmann> about the new window opening click
139 2011-06-04T22:15:22 <ThomasWaldmann> can you use a <a> somehow, so all this magic is not needed?
140 2011-06-04T22:17:21 <RogerHaase> I had to remove the A because the wrapper sometimes wraps an A.
141 2011-06-04T22:18:57 <dreimark> RogerHaase: thats not only about your changes, I had seen that we now have lots of duplication of code because of enterint it directly as a dict as param
142 2011-06-04T22:19:24 <dreimark> there is then mostly only one key/val different
143 2011-06-04T22:19:36 <ThomasWaldmann> RogerHaase: do you know why the wrapper wraps A?
144 2011-06-04T22:26:56 <RogerHaase> Because of the change I made to moinwiki_in.py ~1078, allowing images to be used within links. [[mailto: me@foo.bar|{{me.jpg}}]]
145 2011-06-04T22:27:39 <RogerHaase> dreimark: I don't understand
146 2011-06-04T22:28:33 <RogerHaase> links/transclusions
147 2011-06-04T22:30:46 <RogerHaase> bad answer, looking...
148 2011-06-04T22:31:43 <ThomasWaldmann> RogerHaase: hmm, that is a <a> that contains a transclusion.
149 2011-06-04T22:32:15 <ThomasWaldmann> it could behave normally (a) in normal mode and show the link to the transclusion + the angles in transclusion-showing mode
150 2011-06-04T22:34:46 <RogerHaase> No, my short term memory is going. I am trying to think of the markup that cause a within a...
151 2011-06-04T22:39:10 <RogerHaase> It was interwiki: [[MoinMoin:FrontPage|{{../logo}}]]
152 2011-06-04T22:40:16 <ThomasWaldmann> ok, so in transclusion mode, this is <a> within <a>. and this is invalid html?
153 2011-06-04T22:43:10 <RogerHaase> Yes. http://paste.pocoo.org/show/400788/ With the patch applied, moin-item-overlay-xx is a span, thus avoiding an A within an A
154 2011-06-04T22:46:41 <sinha> ThomasWaldmann: dreimark: http://codereview.appspot.com/4536112/
155 2011-06-04T22:53:02 <ThomasWaldmann> RogerHaase: hm, ok, can you add some comment about all this so we don't wonder when looking at it in the future?
156 2011-06-04T22:53:15 <RogerHaase> Restating in case I was unclear: The <span>'s within <span class="moin-item-wrapper"> were formerly <a>'s
157 2011-06-04T22:54:25 <RogerHaase> ThomasWaldmann: Yes, obviously I need the comment so I can remember it next week :-)
158 2011-06-04T23:03:51 <dreimark> RogerHaase: see rietveld
159 2011-06-04T23:10:13 <RogerHaase> dreimark: thanks for the suggestion, will do
160 2011-06-04T23:10:52 <dreimark> there are many other places, probably, guess needs a review
161 2011-06-04T23:17:01 <dreimark> sinha: have you html5 validation already checked?
162 2011-06-04T23:19:12 <sinha> dreimark: i didnt get your point ? where ?
163 2011-06-04T23:19:35 <dreimark> sinha: at the output - in general
164 2011-06-04T23:19:47 <sinha> yes works for me
165 2011-06-04T23:20:08 <sinha> is there mistake somewhere ?
166 2011-06-04T23:20:45 <sinha> dreimark: i missed a closing td tag
167 2011-06-04T23:21:11 <sinha> maybe doing some undo has taken that away
168 2011-06-04T23:23:58 <ThomasWaldmann> sinha: your code just ran through my wetware validator
169 2011-06-04T23:24:11 <dreimark> Error Line 20, Column 45: Bad value archives for attribute rel on element link: Keyword archives is not registered.
170 2011-06-04T23:24:14 <dreimark> <link rel="archives" href="/+history/" />
171 2011-06-04T23:24:22 <dreimark> was in changeset: 254:72dbe801338e
172 2011-06-04T23:24:46 <sinha> i havent touched it
173 2011-06-04T23:25:20 <dreimark> well, ok
174 2011-06-04T23:25:26 <dreimark> but have an eye on it
175 2011-06-04T23:25:29 <dreimark> make it better
176 2011-06-04T23:25:30 <sinha> i guess archives is included in html5
177 2011-06-04T23:25:58 <dreimark> it marks on />
178 2011-06-04T23:36:11 <dreimark> you got my mail?
179 2011-06-04T23:49:23 <sinha> yes
