1 2011-06-01T00:27:14 *** m4k3r
2 2011-06-01T00:29:24 *** RogerHaase
3 2011-06-01T00:52:38 *** m4k3r
4 2011-06-01T01:49:24 *** ronny
5 2011-06-01T01:51:30 *** ronny
6 2011-06-01T03:38:54 <Marchael> hm, ./quickinstall need root rights to install some packages?
7 2011-06-01T05:33:13 *** kursor
8 2011-06-01T06:15:49 *** kursor
9 2011-06-01T06:18:54 *** kursor
10 2011-06-01T06:45:23 <ThomasWaldmann> moin
11 2011-06-01T06:45:43 <ThomasWaldmann> Marchael: for which packages?
12 2011-06-01T06:46:23 *** kursor
13 2011-06-01T08:02:44 <dreimark> moin
14 2011-06-01T08:02:52 <dreimark> Marchael: no
15 2011-06-01T08:02:55 <dreimark> never
16 2011-06-01T08:37:58 <ThomasWaldmann> the only trouble i had yet with installing stuff to virtual env was with PIL. it needs to compile some stuff and has some dependencies so that the compile works...
17 2011-06-01T11:01:17 *** ronny
18 2011-06-01T11:23:37 *** greg_f
19 2011-06-01T11:28:54 *** sinha
20 2011-06-01T11:32:06 *** pkumar
21 2011-06-01T11:49:51 <CIA-69> Thomas Waldmann <tw AT waldmann-edv DOT de> * 5028c04190a9 r251 default/MoinMoin/converter/html_out.py: html_out converter: remove unused code from moinpage_object that crashed on transclusions with URLs without path. Fixes #30.
22 2011-06-01T11:49:51 <CIA-69> Akash Sinha <akash2607@gmail.com> * f04fafdd629f r252 default/MoinMoin/converter/html_out.py: branch merged with main repo
23 2011-06-01T11:51:56 *** andialbrecht_
24 2011-06-01T12:17:30 *** ronny
25 2011-06-01T12:18:09 <pkumar> ronny: hi
26 2011-06-01T12:19:38 <pkumar> ronny: after changes (MoinTestFunction) it works well for many many tests but not all, unfortunately
27 2011-06-01T12:19:46 <pkumar> many*
28 2011-06-01T12:20:49 <ronny> pkumar: what breaks where?
29 2011-06-01T12:20:59 <pkumar> ronny: Can you please tell me, in self.app, self.ctx = init_test_app(given_config) does it calls init_test_app for each class item?
30 2011-06-01T12:21:01 <ronny> also code + maybe errors
31 2011-06-01T12:21:19 <ronny> pkumar: it will do it for each single test item
32 2011-06-01T12:22:53 <pkumar> here 'self' is a function item, now does self.app makes sense I don't know?
33 2011-06-01T12:23:16 <pkumar> after changes I mean
34 2011-06-01T12:23:51 <ronny> i think so
35 2011-06-01T12:24:06 <ronny> its just put there to be able to undo the setup later
36 2011-06-01T12:26:24 <pkumar> here is conftest.py. Logically, do I need to add something more to it? http://paste.pocoo.org/show/398771/
37 2011-06-01T12:26:27 <pkumar> ronny:^
38 2011-06-01T12:27:29 <pkumar> ronny: pyfunc_call() is working fine, just about MoinTestFunction
39 2011-06-01T12:28:31 <ronny> pkumar: wrt pyfunc_call, it might make sense to print each call it does
40 2011-06-01T12:28:45 <ronny> (for better debugging when stuff breaks
41 2011-06-01T12:28:59 <ronny> pkumar: also docstrings belong into a function, not before it
42 2011-06-01T12:29:08 <pkumar> yeah, pyfunc_call is working fine.
43 2011-06-01T12:29:18 <pkumar> I checked with print statements
44 2011-06-01T12:29:38 <pkumar> ronny: what about MoinTestFunction?
45 2011-06-01T12:29:50 <pkumar> ronny: something missing?
46 2011-06-01T12:30:03 <ronny> pkumar: it should check if parent is really a class
47 2011-06-01T12:30:45 <ronny> pkumar: can you take a look at py.test --collectonly?
48 2011-06-01T12:30:59 <pkumar> ronny: ok, will add a condition there.
49 2011-06-01T12:31:17 <pkumar> ronny: just a mom
50 2011-06-01T12:36:26 <pkumar> ronny: ok, condition added, it works,
51 2011-06-01T12:37:02 <pkumar> ronny: py.test --collectonly shows hierarchy
52 2011-06-01T12:39:36 <ronny> pkumar: can you paste?
53 2011-06-01T12:40:48 <pkumar> http://paste.pocoo.org/show/398777/
54 2011-06-01T12:40:52 <pkumar> ronny: ^
55 2011-06-01T12:41:56 <ronny> would have liked the full tree
56 2011-06-01T12:44:30 <ronny> pkumar: wheere can i pull from again?
57 2011-06-01T12:45:10 <pkumar> just a mom, I'll push to my bitbucket
58 2011-06-01T12:50:10 <CIA-69> pkumar <contactprashantat@gmail.com> * a41acf254474 r259 pytest2/MoinMoin/converter/_tests/ (7 files): some left over py.test in converter module changed to pytest.
59 2011-06-01T12:50:10 <CIA-69> pkumar <contactprashantat@gmail.com> * 183deebe0c0b r260 pytest2/MoinMoin/conftest.py: pytest_pyfunc_call() added to intercept generators and MoinClassCollector replaced with MoinTestFunction to get rid of messy hacks.
60 2011-06-01T12:50:10 <CIA-69> pkumar <contactprashantat@gmail.com> * 50239292c3ad r261 pytest2/MoinMoin/conftest.py: pyfunc_call() changed since MoinTestFunction returns function items, needless to use parent obj now.
61 2011-06-01T12:50:10 <CIA-69> pkumar <contactprashantat@gmail.com> * b759201f2812 r262 pytest2/MoinMoin/conftest.py: condition added in MoinTestFunction.setup() to check for the class in conftest.py
62 2011-06-01T12:50:38 <pkumar> ronny: https://bitbucket.org/pkumar/pytest_moin/
63 2011-06-01T12:51:15 <pkumar> ronny: try running tests for apps
64 2011-06-01T12:58:32 <ronny> pkumar: ok, need to move app/ctx from the item to the object instance
65 2011-06-01T12:59:23 <pkumar> ronny: yeah, I doubted
66 2011-06-01T13:00:20 <pkumar> ronny: how do we do that?
67 2011-06-01T13:01:34 <pkumar> ronny : using hierarchy do we need to get to parents or something?
68 2011-06-01T13:04:02 <ronny> pkumar: i made a hack, this should eventually be turned into a funcarg
69 2011-06-01T13:04:12 <ronny> needs a pytest refactoring we are unsure of first
70 2011-06-01T13:04:18 <ronny> (in pytest itself)
71 2011-06-01T13:07:29 <ronny> pkumar: pull from me
72 2011-06-01T13:07:49 <pkumar> ronny: ok, a mom
73 2011-06-01T13:09:42 <pkumar> ronny: wow, great. It works
74 2011-06-01T13:11:34 <CIA-69> Ronny Pfannschmidt <Ronny.Pfannschmidt@gmx.de> * 9feca3bb9395 r263 pytest2/MoinMoin/conftest.py: pass app object to test classes for now - needs better funcargs
75 2011-06-01T13:12:01 <ronny> pkumar: i tihnk the coverage stuff can be replaced by the pytest-cov plugin
76 2011-06-01T13:13:54 <pkumar> ronny: is it external plugin?
77 2011-06-01T13:14:32 <pkumar> ronny: yeah, I see it
78 2011-06-01T13:16:05 <ThomasWaldmann> dreimark: Marchael: pkumar: sinha: waldi: xorAxAx: meeting today 14:00 UTC (== in 2:45 from now), please prepare
79 2011-06-01T13:16:25 <xorAxAx> i will be busy then, waldi, can you handle my part?
80 2011-06-01T13:16:35 <pkumar> ronny: can you please try the test: _tests.sourcecode.py?
81 2011-06-01T13:17:09 <pkumar> ThomasWaldmann: sure :)
82 2011-06-01T13:18:19 <pkumar> ronny: seems like we don't have path as an argument.
83 2011-06-01T13:18:21 <ronny> pkumar: ah, you left trailing whitespace somewhere
84 2011-06-01T13:18:53 <pkumar> ronny: no, it doesn't show failure but an error
85 2011-06-01T13:19:10 <waldi> xorAxAx: yes. i'll be there
86 2011-06-01T13:19:44 <ronny> pkumar: your editor leaves trailing whitespace, pep8 disallows
87 2011-06-01T13:20:54 <pkumar> ronny: http://paste.pocoo.org/show/398791/
88 2011-06-01T13:23:00 <pkumar> ronny: says 'path' is not a function argument.
89 2011-06-01T13:38:04 <CIA-69> pkumar <contactprashantat@gmail.com> * 1ea65bb705e6 r264 pytest2/MoinMoin/conftest.py: coverage part in conftest.py removed and is replaced by pytest-cov plugin.
90 2011-06-01T13:47:54 <CIA-69> pkumar <contactprashantat@gmail.com> * 0d19b3f6d2fc r265 pytest2/MoinMoin/conftest.py: condition added in MoinTestFunction.setup to avoid the errors temporarily due to hack made
91 2011-06-01T13:48:07 <pkumar> bbl
92 2011-06-01T13:48:11 *** pkumar
93 2011-06-01T13:53:16 <Marchael> moin
94 2011-06-01T13:54:49 <Marchael> ThomasWaldmann: now I testing IntraWordFilter() for item name parsing, and seems like it could do what we need without MultiFilter()
95 2011-06-01T14:01:31 <Marchael> also there is good reason to use LowercaseFilter for item name analyzing
96 2011-06-01T14:14:08 <ThomasWaldmann> well, write tests and try :)
97 2011-06-01T14:14:22 <Marchael> ok
98 2011-06-01T14:14:51 <Marchael> ThomasWaldmann: may be you advice me some values for test?
99 2011-06-01T14:15:38 <ThomasWaldmann> EP line 17
100 2011-06-01T14:16:53 <ThomasWaldmann> btw, did you add whoosh to setup.py?
101 2011-06-01T14:17:31 <Marchael> not yet
102 2011-06-01T14:18:03 <Marchael> ThomasWaldmann: also, may be using of LowercaseFilter will be good for analyzer?
103 2011-06-01T14:18:39 <Marchael> so it'll be case independent
104 2011-06-01T14:18:57 <Marchael> and search'll be more resultative
105 2011-06-01T14:19:37 <ThomasWaldmann> yes, that's maybe useful
106 2011-06-01T14:20:03 <ThomasWaldmann> depends a bit, sometimes one wants to be exact
107 2011-06-01T14:20:06 <Marchael> for example if we want search for "gsoc", we can find "GSOC" or "GSoC" or may be "GsOc:
108 2011-06-01T14:21:15 <Marchael> heh, looks like we can't :)
109 2011-06-01T14:21:47 <Marchael> "GSOC" -> "gsoc", "GSoC" -> "gsco", "c"
110 2011-06-01T14:22:11 <Marchael> *"gso", "c"
111 2011-06-01T14:22:59 <ThomasWaldmann> check how whoosh uses the tokenizer/analyzer
112 2011-06-01T14:23:27 <ThomasWaldmann> iirc, it uses same t/a when indexing a field and also when processing a query for that field
113 2011-06-01T14:23:51 <ThomasWaldmann> so it doesn't matter if tokenizer output is a bit strange, because it is the same for both
114 2011-06-01T14:24:34 <Marchael> ok
115 2011-06-01T14:26:34 <ThomasWaldmann> waldi: xorAxAx: dreimark: ronny: hmm, bad news: i need to meet a customer on-site soon due to a computer emergency there, so i am not sure whether i can attend the meeting today.
116 2011-06-01T14:26:54 * dreimark is currently at a meeting
117 2011-06-01T14:27:08 <dreimark> there is not really an end of defined
118 2011-06-01T14:30:31 *** hardy89
119 2011-06-01T14:32:27 <Marchael> ThomasWaldmann: please check when I'll come http://paste.pocoo.org/show/398820/
120 2011-06-01T14:46:35 <ThomasWaldmann> Marchael: did you consider how that behaves differently from MultiFilter approach?
121 2011-06-01T14:47:35 <Marchael> nope
122 2011-06-01T14:47:52 <Marchael> because with MultiFilter it isn't working
123 2011-06-01T14:48:19 <Marchael> or may I do something wrong
124 2011-06-01T14:48:44 <Marchael> but, py.test shows no errors
125 2011-06-01T14:49:15 <Marchael> also, sorry for annoying question, but how can I attach CIA.vc to my repo?
126 2011-06-01T14:49:51 <Marchael> I open Service Administration on bb, but what "Module:" and "Project:"?
127 2011-06-01T14:53:37 <ThomasWaldmann> Marchael: iirc cia.vc has docs to read...
128 2011-06-01T14:54:06 <ThomasWaldmann> also please read the docs about multifilter and intrawordfilter, iirc that setup was recommended in the docs for some reason
129 2011-06-01T14:55:34 <ThomasWaldmann> bbl
130 2011-06-01T14:56:13 <Marchael> but if I try to use MultiFilter I get this traceback http://paste.pocoo.org/show/398831/
131 2011-06-01T15:08:57 *** pkumar
132 2011-06-01T15:09:00 <pkumar> re
133 2011-06-01T15:13:49 <pkumar> ronny: seems like some function objects do not have im_self attribute like test_iri.py
134 2011-06-01T15:14:25 <pkumar> ronny: so, for the time being I've added a condition for that in conftest.py
135 2011-06-01T15:15:33 <pkumar> ronny : https://bitbucket.org/pkumar/pytest_moin
136 2011-06-01T15:24:13 *** pkumar
137 2011-06-01T15:24:44 *** pkumar
138 2011-06-01T15:29:54 <hardy89> don't we have a meeting today?
139 2011-06-01T15:30:51 <waldi> yes, we have. at 1400 hours
140 2011-06-01T15:31:03 <dreimark> 31mins
141 2011-06-01T15:31:18 <hardy89> all right
142 2011-06-01T15:49:08 *** waldi
143 2011-06-01T15:49:51 *** waldi
144 2011-06-01T15:49:52 *** waldi
145 2011-06-01T15:56:23 <xorAxAx> waldi: umm, no, you should have called in the first meeting at 13:00 UTC
146 2011-06-01T15:58:38 *** moin9
147 2011-06-01T15:59:01 *** moin9
148 2011-06-01T16:04:21 <tw-work> waldi: dreimark: xorAxAx: can you lead the meeting please?
149 2011-06-01T16:05:23 <waldi> welcome to todays meeting
150 2011-06-01T16:05:31 <pkumar> :)
151 2011-06-01T16:05:32 <waldi> if you are here, please speak up
152 2011-06-01T16:06:01 <pkumar> hey
153 2011-06-01T16:06:11 <hardy89> hey
154 2011-06-01T16:06:44 <pkumar> hardy89: a copy :)
155 2011-06-01T16:06:56 <hardy89> uniformity :)
156 2011-06-01T16:07:03 <dreimark> re
157 2011-06-01T16:07:11 <Marchael> hi
158 2011-06-01T16:07:13 <dreimark> sinha: ping
159 2011-06-01T16:09:13 <waldi> okay. sinha seems to be missing right now. all other students are here
160 2011-06-01T16:09:25 <pkumar> guess so
161 2011-06-01T16:09:30 <sinha> dreimark:present
162 2011-06-01T16:09:35 <waldi> ah, okay
163 2011-06-01T16:09:37 <sinha> pesent
164 2011-06-01T16:10:34 <waldi> hardy89: you are first
165 2011-06-01T16:11:46 <hardy89> waldi: seems so :) compensating for last meeting's absence
166 2011-06-01T16:12:32 <dreimark> hardy89: please report progress
167 2011-06-01T16:13:22 <hardy89> i've went through the changes which has taken place from py.test 1.3.4 to pytest 2.0.3
168 2011-06-01T16:13:40 <hardy89> i made minor changes in the code too
169 2011-06-01T16:14:08 <hardy89> but even noticed that most of the module run fine even if left untouched
170 2011-06-01T16:14:40 <hardy89> code commits with minor changes are done.
171 2011-06-01T16:16:01 <hardy89> second thing is intercepting generators but that is still very new to me
172 2011-06-01T16:16:25 <hardy89> so changes will be done accordingly in next 20 odd hours hopefully
173 2011-06-01T16:16:34 <hardy89> rest i'm more or les
174 2011-06-01T16:16:38 <hardy89> +s
175 2011-06-01T16:16:45 <hardy89> one schedule with my module
176 2011-06-01T16:16:45 <waldi> okay. so what is your plan for next week?
177 2011-06-01T16:16:57 <hardy89> waldi: now is the bug fixing week
178 2011-06-01T16:17:15 <hardy89> so all the tests will be run individually which have been ported already
179 2011-06-01T16:17:32 *** andialbrecht
180 2011-06-01T16:17:43 <hardy89> and those which are skipping, have errors, or failing will be fixed in upcoming time bracket
181 2011-06-01T16:18:16 <waldi> any blockers?
182 2011-06-01T16:19:03 <waldi> please read http://moinmo.in/GoogleSoc2011 again, you are supposed to prepare your statement so this can be done more quickly
183 2011-06-01T16:19:11 <hardy89> no as of now. whatsoever blocker comes in i get em cleared here from time to time
184 2011-06-01T16:19:28 <hardy89> read it
185 2011-06-01T16:19:37 <hardy89> i have one minor doubt though
186 2011-06-01T16:19:52 <hardy89> wat doest it mean when the terminal says 'xpassed'
187 2011-06-01T16:20:07 <hardy89> i have 7 tests which get 'xpassed'
188 2011-06-01T16:20:38 <waldi> the test is supposed to fail but for some reason passed
189 2011-06-01T16:21:40 <hardy89> all right.
190 2011-06-01T16:22:08 <waldi> any question left?
191 2011-06-01T16:22:13 <hardy89> many tests which have too many errors are supposed to be tweaked or to be re-written?
192 2011-06-01T16:23:27 <dreimark> or the code needs to be fixed?
193 2011-06-01T16:24:44 <hardy89> yeah.
194 2011-06-01T16:25:28 <dreimark> if i look at the change sets they are mostly about changing py.test in pytest
195 2011-06-01T16:25:53 <hardy89> dreimark: even if thats not done, they're doing fine.
196 2011-06-01T16:26:10 <hardy89> but at least creates a doubt if someone is new to this
197 2011-06-01T16:26:32 <hardy89> so changes were done to indicate it runs on pytest
198 2011-06-01T16:26:51 <dreimark> where do you have that list, is it on the wiki or WP ?
199 2011-06-01T16:26:57 <dreimark> /W/E/
200 2011-06-01T16:27:17 <tw-work> btw, as a general comment for every student:
201 2011-06-01T16:27:23 <hardy89> dreimark: of the modules i'm working on?
202 2011-06-01T16:27:30 <dreimark> hardy89: yes
203 2011-06-01T16:27:43 <hardy89> dreimark: http://etherpad.osuosl.org/moin2-unittest
204 2011-06-01T16:27:45 <dreimark> and where you set that indication
205 2011-06-01T16:27:45 <tw-work> you are required to updated your diary daily. that means that is your last task each workday.
206 2011-06-01T16:28:05 <dreimark> hardy89: "were done to indicate it runs on pytest"
207 2011-06-01T16:28:11 <tw-work> (not every 5 days for the past days)
208 2011-06-01T16:28:11 <dreimark> where do you do this
209 2011-06-01T16:28:26 <pkumar> tw-work: will take care of that. :)
210 2011-06-01T16:28:48 <hardy89> dreimark: that hasn't been made yet
211 2011-06-01T16:29:04 <hardy89> dreimark: i'll make it
212 2011-06-01T16:29:19 <hardy89> tw-work: sure
213 2011-06-01T16:30:24 <hardy89> dreimark: i'll include the list which already has been ported to pytest.
214 2011-06-01T16:30:25 <dreimark> ok, not more questions from me now
215 2011-06-01T16:30:45 <waldi> thank you hardy89. pkumar is next
216 2011-06-01T16:30:52 <pkumar> :)
217 2011-06-01T16:31:11 <pkumar> here it goes:
218 2011-06-01T16:31:19 <tw-work> also, you just need to write in your diary what you did on that day. and please be specific. stuff like "continuing to work on my project" doesn't say enough.
219 2011-06-01T16:31:30 <pkumar> First of all we didn't have much porting ideas.
220 2011-06-01T16:31:36 <hardy89> tw-work: sure.
221 2011-06-01T16:31:47 <pkumar> Thanks to Ronny, conftest.py has become a lot neater
222 2011-06-01T16:32:09 <pkumar> Now the generator tests can be intercepted and run as single test items.
223 2011-06-01T16:32:18 <pkumar> MoinClassCollector replaced with MoinTestFunction.
224 2011-06-01T16:32:30 <pkumar> some issues are still there like 'missing factory for function argument' due to changes made. Can be fixed though.
225 2011-06-01T16:32:55 <pkumar> https://bitbucket.org/pkumar/pytest_moin
226 2011-06-01T16:33:47 <pkumar> thats it.
227 2011-06-01T16:33:55 <tw-work> btw, apropos tests: a lot of the time, cpu and disk the tests take right now (in main repo) are due to how conftest works there
228 2011-06-01T16:35:30 <pkumar> tw-work: we still need to work on different issues of Tests
229 2011-06-01T16:35:49 <pkumar> 1/2 days more for conftest.py, I mean fixing errors and issues due to newly made changes. Then can move to 'already reported test issues' as mentioned in EP.
230 2011-06-01T16:35:56 <dreimark> yeah, it would be good we also can try different storage backends within the tests in a not to expensive time
231 2011-06-01T16:38:12 <pkumar> and for blockers, ronny is helping me out.
232 2011-06-01T16:38:58 <pkumar> ok I'm done here.
233 2011-06-01T16:39:07 <pkumar> with my report.
234 2011-06-01T16:39:37 <waldi> any questions?
235 2011-06-01T16:40:13 <pkumar> not at present. will ask if I'll have on irc :)
236 2011-06-01T16:40:37 <waldi> thank you pkumar. Marchael, your turn.
237 2011-06-01T16:41:00 <Marchael> Last week I'm working on tests for mimetype, acl and item_name
238 2011-06-01T16:41:10 <Marchael> so I commit my changes here https://bitbucket.org/marchael/moin-2.0/changeset/bc7b8834eff5 and here https://bitbucket.org/marchael/moin-2.0/changeset/28093a47a961
239 2011-06-01T16:41:19 <Marchael> Also I think what I've done working on whoosh schema and now can start testing it.
240 2011-06-01T16:41:30 <Marchael> For the next week I'll write test for indexing schema and try to write base class WhooshIndex.
241 2011-06-01T16:41:51 <Marchael> that's all for now
242 2011-06-01T16:42:20 <waldi> any blockers?
243 2011-06-01T16:42:24 <Marchael> nope
244 2011-06-01T16:42:44 <Marchael> ThomasWaldmann helps me so much
245 2011-06-01T16:44:03 <Marchael> any questions?
246 2011-06-01T16:44:46 * dreimark not now
247 2011-06-01T16:45:17 <waldi> okay. thank you Marchael. sinha comes next
248 2011-06-01T16:45:27 <sinha> okay
249 2011-06-01T16:45:59 <sinha> LAST: i was working on the grouping of revision results on day basis.Commited the first chageset here https://bitbucket.org/sinha/moin2/changeset/b07dfe4ceb8d followed by 2 small correction changesets https://bitbucket.org/sinha/moin2/changeset/6177be92aa33 and other.
250 2011-06-01T16:46:07 <sinha> CURRENT: Reading the code of Moin1.9 RecentChanges module, to do the grouping by item name also in moin2.
251 2011-06-01T16:46:13 <sinha> BLOCKERS:
252 2011-06-01T16:46:19 <sinha> - Moin1.9 uses a lot of loops to do the grouping and all and i am stuck on how should i implement it in moin2.
253 2011-06-01T16:46:26 <sinha> - Should i first group the revision by item wise, then group them daywise or do them vice versa.
254 2011-06-01T16:46:32 <sinha> - Currently we are passing the generators to the template, by doing above we have to ceate lists of our own based on grouping and then pass it to template. So won't these things will slow down everything.
255 2011-06-01T16:46:48 <sinha> - And also, Suppose i have an item which is changed on each of the last 5 days, So currently this item will appear in five different groups (date wise grouping), So while doing grouping of revision on the basis of item, does this item will only appear at one group (i.e the latest one). I guess this approach is used in moin1.9 OR item falling in same group after daywise grouping only be grouped together ?
256 2011-06-01T16:47:07 <sinha> - I just need heads up in using this sort of implemenation, does extracting each attributes from the generator and appending it to a list and then passing the list to the template fine is fine ?
257 2011-06-01T16:47:18 <sinha> ^ s/fine/file
258 2011-06-01T16:48:21 <dreimark> you should not show each change on each day
259 2011-06-01T16:48:37 <dreimark> because that can made a horrible long list
260 2011-06-01T16:49:03 <sinha> you mean aggregate the results on item name first then do the grouping
261 2011-06-01T16:49:19 <sinha> on date basis of the latest result.
262 2011-06-01T16:49:25 <dreimark> yes
263 2011-06-01T16:49:49 <dreimark> and there is also a FR on the wiki for lining to the different revisions shown for the day
264 2011-06-01T16:50:13 <sinha> FR ?
265 2011-06-01T16:50:22 <dreimark> http://moinmo.in/FeatureRequests/EnhancedDiffsForRecentChanges
266 2011-06-01T16:50:29 <dreimark> FeatureRequest
267 2011-06-01T16:50:50 <pkumar> bbl
268 2011-06-01T16:50:52 <dreimark> nicer and fast code is prefered#
269 2011-06-01T16:51:54 *** pkumar
270 2011-06-01T16:52:41 <waldi> sorry, i have to go
271 2011-06-01T16:52:50 <hardy89> waldi: anything important that i might me missing out on porting?
272 2011-06-01T16:52:52 <dreimark> ok, waldi
273 2011-06-01T16:53:00 <hardy89> *be
274 2011-06-01T16:54:03 <dreimark> you show better only links of diffs which are from the last day it is changed too. all others are available by the history of the item
275 2011-06-01T16:54:42 <sinha> dreimark: from where i will get these links ?
276 2011-06-01T16:55:14 <dreimark> e.g. http://test.moinmo.in/+history/Home
277 2011-06-01T16:55:43 <dreimark> the diff is then to the revision which fits the bookmark time stamp
278 2011-06-01T16:55:45 <dreimark> e.g.
279 2011-06-01T16:56:00 <dreimark> http://test.moinmo.in/+diff/Home?rev1=7&rev2=5
280 2011-06-01T16:56:55 <dreimark> or if no timestamps it is only one diff
281 2011-06-01T16:57:13 <dreimark> to the last change
282 2011-06-01T16:57:26 <dreimark> s/timestamps/bokkmark time/
283 2011-06-01T16:58:02 <sinha> okay, by extracting the revision number of each change i could do the linking based on it
284 2011-06-01T16:58:10 <dreimark> yes
285 2011-06-01T16:58:32 <sinha> and what about the revision 0
286 2011-06-01T16:59:14 <dreimark> it has the create icon then
287 2011-06-01T17:00:24 <dreimark> it just links to the item, and in 1.9 it tells "No older revisions available!"
288 2011-06-01T17:00:37 <sinha> okay then what attribute i will keep on grouping. i) the item name ii) Last change time iii)List of editors and diff links in fron of them iv) comments by each of them
289 2011-06-01T17:00:47 <sinha> s/fron/front
290 2011-06-01T17:01:11 <dreimark> and content type
291 2011-06-01T17:01:51 <sinha> okay, and i guess as we are showing that diff links we don't need grouping by editors here ? right ?
292 2011-06-01T17:02:41 <dreimark> no, it is just listing them
293 2011-06-01T17:02:59 <sinha> editor name in front of diff link
294 2011-06-01T17:03:07 <sinha> and comment, if pesent
295 2011-06-01T17:03:26 <dreimark> yes
296 2011-06-01T17:03:58 <dreimark> currently we show only last comment, sometimes it would be good to be able to expand that
297 2011-06-01T17:04:08 <dreimark> but also we can have a different plugin for that
298 2011-06-01T17:04:30 <sinha> yes i can write javascript code for that
299 2011-06-01T17:04:39 <sinha> but currently i show all the comments
300 2011-06-01T17:04:49 <sinha> will do this hide/show after that
301 2011-06-01T17:04:59 <dreimark> because some people tend to write/save/write... instead of preview
302 2011-06-01T17:05:11 <dreimark> so there are lots of changesets.
303 2011-06-01T17:05:20 *** tw-work
304 2011-06-01T17:05:32 <dreimark> then if there is no comment it is better to show it like [1-7]
305 2011-06-01T17:06:12 <sinha> what does this mean
306 2011-06-01T17:06:24 <sinha> change 1-7 is done by that editor
307 2011-06-01T17:06:41 <dreimark> this means the last 7 changes by the user
308 2011-06-01T17:06:55 <dreimark> if you look at http://moinmo.in/4ct10n/bookmark/RecentChanges
309 2011-06-01T17:07:06 <dreimark> PrashantKumar [1-6]
310 2011-06-01T17:07:25 <hardy89> ronny: anything important that we might be missing out in porting?
311 2011-06-01T17:07:33 <dreimark> it means since today he has 6 times changed the page
312 2011-06-01T17:07:46 <dreimark> http://moinmo.in/4ct10n/info/pkumar_diary/2011-05-28?action=info
313 2011-06-01T17:08:21 <dreimark> hardy89: ronny just a minute
314 2011-06-01T17:08:28 <sinha> so the name of editor will be grouped ?
315 2011-06-01T17:08:38 <dreimark> for the changes yes
316 2011-06-01T17:09:09 <sinha> and we will have a different column with list of those revision links, in above case that would be 7
317 2011-06-01T17:09:12 <hardy89> dreimark: sure
318 2011-06-01T17:09:23 <dreimark> another example look at HimanshuAwasthi 2011-05-29
319 2011-06-01T17:09:49 *** hardy89
320 2011-06-01T17:09:56 <dreimark> there Thomas has done the 2 and all others by HimanshuAwasthi
321 2011-06-01T17:09:59 <ronny> re
322 2011-06-01T17:10:17 <dreimark> so it is a compressing of information by grouping
323 2011-06-01T17:11:05 <sinha> yes i have also gone through the codes of these grouping in moin1.9, there a lot of iterations are done to these groupings
324 2011-06-01T17:11:56 <sinha> so i was trying to find some way to do it in simpler way
325 2011-06-01T17:12:17 <sinha> but i guess thats the only way
326 2011-06-01T17:12:18 <dreimark> please do - try to keep features
327 2011-06-01T17:12:30 <sinha> yeah no problem
328 2011-06-01T17:12:33 *** m4k3r
329 2011-06-01T17:12:39 <dreimark> I how we can get off some of these loops
330 2011-06-01T17:12:46 <dreimark> because that code is pretty old
331 2011-06-01T17:13:05 <dreimark> s/how/hope/
332 2011-06-01T17:13:08 <sinha> i was just wondering can these things be done in the query itseld, like some grouping thing there itself
333 2011-06-01T17:13:15 <sinha> s/itseld/itself
334 2011-06-01T17:14:52 <sinha> okay i will start this by first grouping these results by item name
335 2011-06-01T17:15:02 <dreimark> ok
336 2011-06-01T17:15:17 <sinha> then using that date grouping over it.
337 2011-06-01T17:15:41 <sinha> okay i guess i am done here for today !
338 2011-06-01T17:16:03 <dreimark> we should also look again at indexing. may be we can add something which makes query / filtering easier
339 2011-06-01T17:16:19 <dreimark> thanks sinha
340 2011-06-01T17:16:26 <sinha> yes we will have to, when doing that bookmark thing
341 2011-06-01T17:16:57 <dreimark> thanks all attendees
342 2011-06-01T17:19:48 <Marchael> ThomasWaldmann: when you go back please look here http://paste.pocoo.org/show/398856/ looks like there is a whoosh issue
343 2011-06-01T17:24:49 <Marchael> but I think that isn't critical because this stuff can work without MultiFilter()
344 2011-06-01T17:27:47 <dreimark> Marchael: is this the complete traceback?
345 2011-06-01T17:28:42 <Marchael> it's rather short, but seems yes
346 2011-06-01T17:31:44 <dreimark> Marchael: with which whoosh version do you work on?
347 2011-06-01T17:31:51 <Marchael> 1.8.3
348 2011-06-01T17:32:50 <Marchael> python 2.7.1
349 2011-06-01T17:33:29 <Marchael> dreimark: if you'll test that please write here about your results.
350 2011-06-01T17:35:24 <dreimark> do you have that in a test?
351 2011-06-01T17:35:41 <Marchael> no
352 2011-06-01T17:35:54 <Marchael> I don't use MultiFilter
353 2011-06-01T17:38:01 <Marchael> Matt recommends use MultiFilter in comments to Intra word filter, but I think what in our case we can continue work without it
354 2011-06-01T17:38:40 <dreimark> if it is buggy and you have that in a test you should open an issue on the tracker there
355 2011-06-01T17:38:54 <Marchael> dreimark: I'm not sure
356 2011-06-01T17:39:07 <Marchael> may this not a bug
357 2011-06-01T17:43:12 <dreimark> Marchael: there is a test for that
358 2011-06-01T17:43:18 <dreimark> test_analysis
359 2011-06-01T17:50:41 <Marchael> which modul responsible for getting data from backend?
360 2011-06-01T17:51:11 <dreimark> nosetests did not get an error with that test
361 2011-06-01T17:53:19 <dreimark> Marchael: which data? you mean an item?
362 2011-06-01T17:53:39 <Marchael> dreimark: content, metadata
363 2011-06-01T17:54:10 <Marchael> test_analysis? where did you get that?
364 2011-06-01T17:54:20 <dreimark> it is part of whoosh
365 2011-06-01T17:55:15 <dreimark> item = Item.create('itemname')
366 2011-06-01T17:55:33 <dreimark> if not isinstance(item, NonExistent):
367 2011-06-01T17:55:36 <Marchael> are you installing whoosh with pip?
368 2011-06-01T17:55:41 <dreimark> meta, data = item.meta, item.data assert meta == {CONTENTTYPE: 'application/x
369 2011-06-01T17:56:11 <dreimark> Marchael: I cloned the repo to my workspace and installed it by pip to my env
370 2011-06-01T17:56:33 <dreimark> meta, data = item.meta, item.data
371 2011-06-01T17:56:41 <dreimark> the prev. line was wrong
372 2011-06-01T17:57:28 <dreimark> https://bitbucket.org/mchaput/whoosh/src/cc7f53b726ab/tests/test_analysis.py
373 2011-06-01T17:57:39 * Marchael looks
374 2011-06-01T17:58:08 *** ronny
375 2011-06-01T18:01:12 <Marchael> yes, whoosh pass all test in test_analysis
376 2011-06-01T18:01:52 <dreimark> verify if the test is valid or what the differnce to your finding is
377 2011-06-01T18:02:21 <dreimark> also looking on tests sometimes gives inspiration what else can be done by the code
378 2011-06-01T18:15:19 <Marchael> argh
379 2011-06-01T18:15:29 <Marchael> sneaky documentation
380 2011-06-01T18:15:33 <Marchael> :)
381 2011-06-01T18:16:07 <Marchael> there is need "mode" parameter when parsing
382 2011-06-01T18:16:30 <Marchael> there is missed in documentation even in src
383 2011-06-01T18:17:35 <Marchael> there is correct http://paste.pocoo.org/show/398969/
384 2011-06-01T18:18:01 <Marchael> dreimark: thanks for your advice
385 2011-06-01T18:18:55 <dreimark> Marchael: file a docu bug
386 2011-06-01T18:30:08 <Marchael> ThomasWaldmann: so this is the general point of using Multifilter http://paste.pocoo.org/show/398982/
387 2011-06-01T18:30:44 <Marchael> for indexing we are using index mode and query for querying
388 2011-06-01T18:50:01 *** ronny
389 2011-06-01T18:59:52 <ThomasWaldmann> re
390 2011-06-01T19:00:09 <dreimark> bbl
391 2011-06-01T19:00:46 <dreimark> coincidence !
392 2011-06-01T19:05:18 *** ronny
393 2011-06-01T19:14:07 <Marchael> ThomasWaldmann: rewrite part of test for item_name http://paste.pocoo.org/show/399010/
394 2011-06-01T19:14:41 <Marchael> *I rewrote
395 2011-06-01T19:33:54 *** greg_f
396 2011-06-01T19:34:47 <ThomasWaldmann> Marchael: 8 looks strange
397 2011-06-01T19:35:01 <ThomasWaldmann> should be gsoc 201
398 2011-06-01T19:35:06 <ThomasWaldmann> gsoc 2011
399 2011-06-01T19:35:17 <Marchael> why?
400 2011-06-01T19:35:34 <Marchael> GSoC2011 is pretty fine too
401 2011-06-01T19:39:09 <ThomasWaldmann> 16 is crap
402 2011-06-01T19:40:04 <ThomasWaldmann> the test case in 8 is mixing 2 things: camelcase and alpha vs. numeric
403 2011-06-01T19:40:46 <dreimark> re
404 2011-06-01T19:41:55 <Marchael> hm, then may be I need to think on better example
405 2011-06-01T19:42:05 <dreimark> or make more
406 2011-06-01T19:42:48 <Marchael> dreimark: I don't see a reason. This tested in whoosh
407 2011-06-01T19:43:16 <dreimark> Marchael: ok, then not
408 2011-06-01T19:43:20 <ThomasWaldmann> Marchael: you know why 16 is crap?
409 2011-06-01T19:44:03 <Marchael> using [0] and [1]?
410 2011-06-01T19:44:43 <ThomasWaldmann> it does about the same thin as 13..15 but only works for n==1
411 2011-06-01T19:45:53 <Marchael> no
412 2011-06-01T19:46:05 <Marchael> mode="index"
413 2011-06-01T19:46:18 <Marchael> in 13..15 mode="query"
414 2011-06-01T19:46:24 <ThomasWaldmann> i said "about"
415 2011-06-01T19:46:45 <ThomasWaldmann> so why don't you use a for loop also, so that it scales?
416 2011-06-01T19:47:46 <Marchael> hm, but there is only one exmple
417 2011-06-01T19:49:04 <Marchael> using loop for list of one value is a bit strange
418 2011-06-01T19:49:45 <ThomasWaldmann> well, see your other code, same thing
419 2011-06-01T19:50:04 <Marchael> is it crap?
420 2011-06-01T19:50:05 <ThomasWaldmann> but the point is just processing a list of test cases, no matter how long it is
421 2011-06-01T19:51:39 <ThomasWaldmann> maybe one could even add the mode to the test_cases data, so that the code is also generic and in the base class
422 2011-06-01T19:52:29 <Marchael> there is http://paste.pocoo.org/show/399030/
423 2011-06-01T20:00:00 <ThomasWaldmann> do you think you have more cases where you need to test query and index?
424 2011-06-01T20:03:17 <Marchael> ThomasWaldmann: I don't think what we need more cases, because that stuff are already tested in test_analysis
425 2011-06-01T20:05:15 <ThomasWaldmann> please use different tests for camelcase and alpha vs. numeric
426 2011-06-01T20:17:49 <Marchael> for "index" and "query"?
427 2011-06-01T20:25:26 <ThomasWaldmann> the GSoC2011 test cases mixes them
428 2011-06-01T20:28:07 <Marchael> http://paste.pocoo.org/show/399048/
429 2011-06-01T20:38:22 <ThomasWaldmann> does 9 succeed?
430 2011-06-01T20:38:32 <ThomasWaldmann> why is the last token there?
431 2011-06-01T20:40:10 <Marchael> because it's for mode="index"
432 2011-06-01T20:40:56 <Marchael> there are test_cases for mode="query" and test_cases_index for mode="index"
433 2011-06-01T20:45:34 <ThomasWaldmann> someitemsubitem does that make sense?
434 2011-06-01T20:47:35 <Marchael> yes
435 2011-06-01T20:48:18 <Marchael> test fails with
436 2011-06-01T20:48:18 <Marchael> E assert set([u'some', u'item', u'sub', u'item']) == set([u'some', u'item', u'sub', u'item', u'someitemsubitem'])
437 2011-06-01T20:51:50 <ThomasWaldmann> why is it there?
438 2011-06-01T20:53:39 <Marchael> what is it?
439 2011-06-01T20:58:42 <Marchael> I mean if I remove "someitemsubitem" from expected_tokens then test fails
440 2011-06-01T21:13:37 <ThomasWaldmann> yes, but why would we like to have someitemsubitem in one piece?
441 2011-06-01T21:16:31 <Marchael> may be in this case it looks strange, but for something like "GSOC2011", "GSoC2011", "gsoc 2011" it would be reasonable
442 2011-06-01T21:17:40 <Marchael> otherwise we won't found some documents
443 2011-06-01T21:18:14 <Marchael> s/found/find/
444 2011-06-01T21:23:49 <ThomasWaldmann> ok, we'll see
445 2011-06-01T21:30:14 <ThomasWaldmann> btw, after you're w finished with analyzers/tokernizers, do the indexer
446 2011-06-01T21:31:03 <Marchael> ThomasWaldmann: I also want to ask you about indexing. When we should build indexes? At wiki start?
447 2011-06-01T21:32:02 <ThomasWaldmann> see etherpad
448 2011-06-01T21:34:20 <ThomasWaldmann> and first read the whoosh docs about indexing
449 2011-06-01T21:49:29 <Marchael> ThomasWaldmann: I read whoosh docs about indexing. So, when wiki starts we should create indexes(or open if they are exist), but if we couldn't find them than we are performing full index rebuild using moin backend.
450 2011-06-01T21:50:24 <Marchael> I mean get all information from backend what can be put in indexes
451 2011-06-01T21:53:40 <Marchael> and I think what it will be good if we create one WhooshIndex object at the start and will be using it all time while wiki works.
452 2011-06-01T21:53:48 <Marchael> like current_app in flask
453 2011-06-01T21:59:59 <Marchael> gn/bbl
454 2011-06-01T22:02:46 <ThomasWaldmann> Marchael: i'ld suggest to not build index on wiki start, that usually takes too long
455 2011-06-01T22:54:21 *** ronny
456 2011-06-01T23:29:01 *** RogerHaase
457 2011-06-01T23:36:52 *** sinha
458 2011-06-01T23:38:59 <RogerHaase> ThomasWaldmann: One more try at transclusion overlay design. This has itemview "button" similar to comments: http://75.167.35.159:8081/Transclusions
459 2011-06-01T23:40:17 * ThomasWaldmann looks
460 2011-06-01T23:41:57 <ThomasWaldmann> ah, interesting
461 2011-06-01T23:42:42 <RogerHaase> I think this is less of a easter egg hunt trying to find transcluded items.
462 2011-06-01T23:44:04 <ThomasWaldmann> yeah, just showing all the stuff is nice
463 2011-06-01T23:44:15 <ThomasWaldmann> just 2 things on the negative list:
464 2011-06-01T23:44:16 <RogerHaase> And less annoying if you are not interested in knowing what is transcluded.
465 2011-06-01T23:44:34 <ThomasWaldmann> we need some more space in the menu for "transclusions" of course
466 2011-06-01T23:45:08 <ThomasWaldmann> if you are right in the middle of a longer page, you first need to scroll back to the top to click on "transclusions"
467 2011-06-01T23:45:42 <RogerHaase> perhaps it can be included in the sidebar.
468 2011-06-01T23:46:28 <ThomasWaldmann> yeah
469 2011-06-01T23:46:51 <RogerHaase> Scrolling to top or bottom is always annoying for me, which is why I like fixedleft theme.
470 2011-06-01T23:47:44 <ThomasWaldmann> ok, i think i like it overall
471 2011-06-01T23:47:50 <ThomasWaldmann> :)
472 2011-06-01T23:47:54 <RogerHaase> Will we have language translation for Javascript?
473 2011-06-01T23:48:13 <ThomasWaldmann> not yet, there's a open issue for that in the tracker
474 2011-06-01T23:49:39 <RogerHaase> OK, I will note todos where it is needed. Cleaning up the code will probably take me to the weekend.
475 2011-06-01T23:50:50 <ThomasWaldmann> i don't know how i18n is usually handled in js
476 2011-06-01T23:54:03 <RogerHaase> btw, if you do this [[MoinMoin:FrontPage|{{../logo}}]] at current tip, you get a weird display due to the bug introduced in the interwiki/mailto patch. Fixing the bug is how I got started on this overlay patch.
477 2011-06-01T23:55:11 <ThomasWaldmann> are you doing that on a subpage?
478 2011-06-01T23:55:56 <RogerHaase> Yes, under Logos heading... using a logo as a link image...
479 2011-06-01T23:57:53 <ThomasWaldmann> ok, so you're working on that fix also?
480 2011-06-01T23:59:35 <RogerHaase> Yes, it is in this patch. I had to eliminate A tags in the overlay and use Spans with onclick because it was creating A tags within A tags.
