1 2011-05-31T00:00:27 <pkumar> ok
2 2011-05-31T00:07:22 <ronny> pkumar: does it work now, im going to sleep soon, im rather tired today
3 2011-05-31T00:08:35 <pkumar> ronny: yeah, still some errors but different ones. I'll first see if I can fix it myself. thanks
4 2011-05-31T00:09:11 <pkumar> ronny: gn
5 2011-05-31T00:09:30 <ronny> night
6 2011-05-31T00:16:01 *** pkumar
7 2011-05-31T00:33:23 *** RogerHaase
8 2011-05-31T00:37:41 *** m4k3r
9 2011-05-31T01:00:59 *** ronny
10 2011-05-31T04:26:29 *** yakoi
11 2011-05-31T05:03:40 *** yakoi
12 2011-05-31T05:22:09 *** Marchael
13 2011-05-31T05:22:43 <Marchael> moin
14 2011-05-31T05:44:37 *** kursor
15 2011-05-31T06:41:56 *** kursor
16 2011-05-31T07:31:14 *** ronny
17 2011-05-31T08:13:57 <dreimark> moin
18 2011-05-31T09:07:19 <dreimark> Marchael: ThomasWaldmann do you have plans to create a search index which can be used in a farm
19 2011-05-31T09:07:47 <dreimark> e.g. interwikiname as a key too
20 2011-05-31T09:39:41 <ThomasWaldmann> moin
21 2011-05-31T09:39:50 <ThomasWaldmann> dreimark: i added it to the etherpad
22 2011-05-31T09:49:56 <dreimark> :)
23 2011-05-31T09:50:12 <dreimark> see question on #moin
24 2011-05-31T10:08:08 <Marchael> hi ThomasWaldmann
25 2011-05-31T10:08:55 <Marchael> For first wiki run we should build index files, but how we know what items need to be add to index?
26 2011-05-31T10:09:20 <Marchael> I think what we can get them from backend
27 2011-05-31T10:11:58 <Marchael> also there is state of my current repo http://paste.pocoo.org/show/398135/
28 2011-05-31T10:12:34 <Marchael> I want to commit them yerstaday, but wi-fi don't let me to do it.
29 2011-05-31T10:15:46 <ThomasWaldmann> s/testing_acl_right/acl/
30 2011-05-31T10:16:06 <ThomasWaldmann> and you're still using lists?
31 2011-05-31T10:17:02 <Marchael> for what?
32 2011-05-31T10:17:22 <Marchael> test_cases?
33 2011-05-31T10:18:44 <Marchael> acl_tokenizer() will generate AE if I'll using something different from list
34 2011-05-31T10:19:27 <ThomasWaldmann> i mean for expected_tokens / result tokens
35 2011-05-31T10:19:39 <Marchael> yes
36 2011-05-31T10:19:50 <ThomasWaldmann> and btw, i don't think you ever ran that code
37 2011-05-31T10:22:05 <ThomasWaldmann> (analyzers.py)
38 2011-05-31T10:24:39 <ThomasWaldmann> 19 TestAclTokenizer
39 2011-05-31T10:25:43 <ThomasWaldmann> 104 testAclTokenizer
40 2011-05-31T10:25:55 <Marchael> yes, I never run this code because there is no things to run. I just want you look on this and discuss ideas about methods in Index class.
41 2011-05-31T10:26:43 <ThomasWaldmann> 110 add docstring what this test is testing exactly
42 2011-05-31T10:28:08 <ThomasWaldmann> currently, that is not a test at all btw, because it does not use assert, nor py.test.raises
43 2011-05-31T10:28:56 <Marchael> hm, what's wrong with 19 and 104?
44 2011-05-31T10:29:52 <ThomasWaldmann> 19 as this code is rather long already, you maybe only want to test acl tokenizing in that class
45 2011-05-31T10:30:33 <ThomasWaldmann> and it is about always choosing good names
46 2011-05-31T10:30:43 <Marchael> I try to use py.test.raises() in testUnicode(), but seems like it's can not catch exception.
47 2011-05-31T10:31:03 <Marchael> because it's raises from parent class of ContentACL
48 2011-05-31T10:31:26 <ThomasWaldmann> maybe just remove that unicode test
49 2011-05-31T10:31:34 <Marchael> oops, wrong :)
50 2011-05-31T10:31:37 <ThomasWaldmann> it doesn't fit there well anyway
51 2011-05-31T10:31:43 <Marchael> ok
52 2011-05-31T10:32:01 <ThomasWaldmann> if we want to test that ContentACL raises, we should do that in a test there
53 2011-05-31T10:32:40 <ThomasWaldmann> tell me when you finished abovementioned things
54 2011-05-31T10:32:45 <Marchael> no, in unicode test AE raises from MimeTokenizer.__call__()
55 2011-05-31T10:33:16 <Marchael> ok
56 2011-05-31T10:34:06 <ThomasWaldmann> you mean AclTokenizer.__call__
57 2011-05-31T10:34:51 <Marchael> mm, yes :)
58 2011-05-31T10:36:07 <ThomasWaldmann> btw, you could move the tokenisers to analyzers.py, they are almost the same anyway
59 2011-05-31T10:39:49 <ThomasWaldmann> (and rename the test accordingly)
60 2011-05-31T10:40:20 <ThomasWaldmann> if you used hg add on these files already, use hg mv / hg rm etc.
61 2011-05-31T10:40:58 <Marchael> ok
62 2011-05-31T10:49:53 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/398153/
63 2011-05-31T10:50:32 <Marchael> but may be better use TestTokenizers for 19
64 2011-05-31T10:51:36 <Marchael> in case what I'll write test for MimeTokenizer()
65 2011-05-31T10:51:55 <ThomasWaldmann> remove 130
66 2011-05-31T10:52:07 <ThomasWaldmann> remove 161
67 2011-05-31T10:52:17 <ThomasWaldmann> (see class names)
68 2011-05-31T10:52:45 <ThomasWaldmann> use a new test class for MimeTokenizer tests
69 2011-05-31T10:53:30 <ThomasWaldmann> fix 9
70 2011-05-31T10:56:16 <ThomasWaldmann> and between module level definitions please leave 2 empty lines, except if the stuff is directly related somehow
71 2011-05-31T10:57:08 <ThomasWaldmann> 204 use new style classes (ever!)
72 2011-05-31T10:58:32 <Marchael> WhooshIndex will be good for it?
73 2011-05-31T10:58:40 <ThomasWaldmann> 238 240 242 you need at least a docstring or pass there, otherwise it'll be a syntax error
74 2011-05-31T10:59:08 <ThomasWaldmann> yes
75 2011-05-31T10:59:24 <ThomasWaldmann> ...(object)
76 2011-05-31T11:02:58 *** Marchael
77 2011-05-31T11:04:25 *** Marchael
78 2011-05-31T11:09:03 * Marchael try to get back through one hour
79 2011-05-31T12:20:42 <ThomasWaldmann> dreimark: xorAxAx: waldi: i'ld suggest that if no work was done, no diary page is created
80 2011-05-31T12:21:02 <ThomasWaldmann> that makes it easier to see which days were work days (and which not)
81 2011-05-31T12:21:27 * Marchael back
82 2011-05-31T12:23:13 <Marchael> http://paste.pocoo.org/show/398186/
83 2011-05-31T12:24:39 <Marchael> but there is still no test for MimeTokenizer, I'll doing it right now
84 2011-05-31T12:28:54 <ThomasWaldmann> Marchael: please do a type consistency check for the stuff yielded by MimeTokenizer
85 2011-05-31T12:29:07 <ThomasWaldmann> either all str or all unicode, no mixing
86 2011-05-31T12:29:31 * ThomasWaldmann suggests all unicode
87 2011-05-31T12:30:13 <Marchael> hm
88 2011-05-31T12:30:32 <Marchael> MimeType yield only unicode
89 2011-05-31T12:30:52 <ThomasWaldmann> test it :)
90 2011-05-31T12:30:56 <Marchael> he takes unicode string and return unicode string
91 2011-05-31T12:31:34 * Marchael confuses
92 2011-05-31T12:31:55 <Marchael> I tested it, and it's return unicode string
93 2011-05-31T12:32:05 <ThomasWaldmann> assert isinstance(x, unicode) # in the test you write right now
94 2011-05-31T12:32:45 <ThomasWaldmann> 166..175 please check if that is needed
95 2011-05-31T12:33:32 <ThomasWaldmann> iirc one can use a Tokenizer instead of an Analyzer, right?
96 2011-05-31T12:33:39 <Marchael> no
97 2011-05-31T12:33:44 <ThomasWaldmann> why not?
98 2011-05-31T12:33:56 <Marchael> because we must use filter
99 2011-05-31T12:34:05 <ThomasWaldmann> why?
100 2011-05-31T12:34:14 <Marchael> PassFilter doing nothing, but without it nothing will work
101 2011-05-31T12:34:39 <ThomasWaldmann> can you be more specific? :)
102 2011-05-31T12:35:36 * Marchael looking in whoosh manual
103 2011-05-31T12:36:11 <ThomasWaldmann> http://packages.python.org/Whoosh/api/analysis.html
104 2011-05-31T12:36:52 <ThomasWaldmann> the only thing special is that the first thing in a pipeline need to be a Tokenizer (not a filter)
105 2011-05-31T12:37:08 <ThomasWaldmann> but a filter gets tokens and yields tokens
106 2011-05-31T12:37:26 <ThomasWaldmann> a Tokenizer gets a string and yields tokens
107 2011-05-31T12:37:36 <ThomasWaldmann> a analyzer gets a string and yield tokens
108 2011-05-31T12:37:52 <Marchael> so, seems like there is no different between Tokenizer and Analyzer for whoosh schema...
109 2011-05-31T12:38:32 <ThomasWaldmann> if you want naming consistency, you could do something like acl_analyzer = AclTokenizer
110 2011-05-31T12:38:36 * Marchael just see on analyzers in whoosh and do same for own analyzer :)
111 2011-05-31T12:39:24 <ThomasWaldmann> 211 (and others) please, if you format like this, end the line with a comma
112 2011-05-31T12:39:56 <ThomasWaldmann> this is a style recommendation for function params, lists, dicts, etc.
113 2011-05-31T12:40:34 <ThomasWaldmann> it is better that way because if you want to add another element in the next line, you only have to add that next line, not also edit the previous one (because you need to add the comma)
114 2011-05-31T12:40:54 <ThomasWaldmann> see 230, there it is correct
115 2011-05-31T12:42:12 <Marchael> I start with new line because PEP-8 recomends use only 79 symbols per line :)
116 2011-05-31T12:42:17 <Marchael> 211
117 2011-05-31T12:43:30 <ThomasWaldmann> you may well ignore that part of pep8
118 2011-05-31T12:43:56 <ThomasWaldmann> there are a few things in pep8 i consider outdated (while most of it is great)
119 2011-05-31T12:44:36 <ThomasWaldmann> one is that 80 (79) chars limit. nowadays we usually don't have 80x25 screen any more. even printers print more than 80 cpl.
120 2011-05-31T12:45:11 <ThomasWaldmann> thus, I don't do a hard break to respect 80, but I rather try to format nicely, even if it means 100
121 2011-05-31T12:45:50 <ThomasWaldmann> same sort of anachronism is that ctrl-L part of pep8. that's for printing, but who prints src nowadays?
122 2011-05-31T12:46:28 <Marchael> Students
123 2011-05-31T12:46:55 <ThomasWaldmann> after you printed the moin src, tell me how many pages it was :P
124 2011-05-31T12:46:55 <Marchael> in our university students print src for doing labs
125 2011-05-31T12:47:08 <Marchael> heh :)
126 2011-05-31T12:47:10 *** hardy_89
127 2011-05-31T12:47:10 *** hardy89
128 2011-05-31T12:47:21 *** hardy_89
129 2011-05-31T12:47:32 * Marchael brb
130 2011-05-31T12:53:03 *** hardy89
131 2011-05-31T13:10:10 *** yakoi
132 2011-05-31T13:12:51 * Marchael back
133 2011-05-31T13:16:37 *** yakoi
134 2011-05-31T13:17:19 *** greg_f
135 2011-05-31T13:35:10 *** hardy_89
136 2011-05-31T13:35:10 *** hardy89
137 2011-05-31T13:35:27 *** hardy_89
138 2011-05-31T13:55:08 *** hardy89
139 2011-05-31T13:57:33 *** hardy89
140 2011-05-31T14:19:31 *** m4k3r
141 2011-05-31T14:21:25 *** hardy89_
142 2011-05-31T14:23:05 *** m4k3r
143 2011-05-31T14:24:25 *** hardy89
144 2011-05-31T14:24:26 *** hardy89_
145 2011-05-31T14:25:25 *** m4k3r
146 2011-05-31T14:32:56 <CIA-69> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 247:5028c04190a9 2.0/MoinMoin/converter/html_out.py: html_out converter: remove unused code from moinpage_object that crashed on transclusions with URLs without path. Fixes #30.
147 2011-05-31T14:35:29 *** hardy89
148 2011-05-31T14:42:03 *** hardy89
149 2011-05-31T15:02:16 *** hardy89
150 2011-05-31T15:11:57 <ThomasWaldmann> waldi: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/29/transcluded-csv-page-is-not-wrapped-with
151 2011-05-31T15:12:05 <ThomasWaldmann> can you please comment?
152 2011-05-31T15:14:46 <waldi> ThomasWaldmann: this is not my code. so no idea
153 2011-05-31T15:19:32 <ThomasWaldmann> waldi: but you should now how the right way is :)
154 2011-05-31T15:19:37 <ThomasWaldmann> know*
155 2011-05-31T16:02:10 *** hardy89
156 2011-05-31T16:05:32 *** ronny
157 2011-05-31T16:11:11 <hardy89> hi waldi
158 2011-05-31T16:11:35 <hardy89> yesterday i cloned a new repo for making code commits.
159 2011-05-31T16:11:59 <hardy89> i did a venv
160 and ./quickinstall in that
161 2011-05-31T16:12:16 <hardy89> but now i'm unable to run any of the tests
162 2011-05-31T16:13:09 <hardy89> waldi: this is wat i get http://paste.pocoo.org/show/398311/
163 2011-05-31T16:13:25 <hardy89> i even did a easy_install of flask
164 2011-05-31T16:13:36 <hardy89> and pip install Flask-Cache too
165 2011-05-31T16:13:49 <hardy89> but didn't work out
166 2011-05-31T16:29:53 <dreimark> hardy89: show me the result of quickinstall
167 2011-05-31T16:30:42 <hardy89> that was a day back dreimark
168 2011-05-31T16:30:47 <hardy89> dreimark: should i do it again
169 2011-05-31T16:30:48 <hardy89> ?
170 2011-05-31T16:32:14 <ThomasWaldmann> looks like there was some issues with quickinstall (like breakage of your internet connection, server down, whatever), your install is incomplete
171 2011-05-31T16:32:28 <ThomasWaldmann> yes, do it again
172 2011-05-31T16:32:40 <hardy89> let me do it. will let you know.
173 2011-05-31T16:32:45 <hardy89> ThomasWaldmann: ^
174 2011-05-31T16:33:42 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/398324/ wrote test for MimeTokenizer
175 2011-05-31T16:37:44 *** m4k3r
176 2011-05-31T16:38:02 *** m4k3r
177 2011-05-31T16:38:33 <hardy89> ThomasWaldmann , dreimark :things went well with quickinstall until this happened. http://paste.pocoo.org/show/398330/
178 2011-05-31T16:39:30 <dreimark> Marchael: 107
179 2011-05-31T16:39:51 <dreimark> we have to assume that it is a list so you could name it as tokens
180 2011-05-31T16:40:28 <Marchael> list_of_tokens are more precise :)
181 2011-05-31T16:40:37 <Marchael> s/are/is/
182 2011-05-31T16:42:12 <ThomasWaldmann> Marchael: 116 is invalid, but nice that it doesn't crash :)
183 2011-05-31T16:42:45 <ThomasWaldmann> 118 is also invalid, there are no mimetypes with blanks
184 2011-05-31T16:42:55 <Marchael> it is only for test
185 2011-05-31T16:43:11 <dreimark> you also don't tell us dict_of_ tuple_of ...
186 2011-05-31T16:43:37 <ThomasWaldmann> 122 shows a major issue if your way to test
187 2011-05-31T16:44:10 <ThomasWaldmann> of*
188 2011-05-31T16:44:39 <ThomasWaldmann> Marchael: please remove 116, 118
189 2011-05-31T16:44:50 <ThomasWaldmann> but add a test case for '' as input
190 2011-05-31T16:45:10 <dreimark> charset, should be valid too? or is there one with blanks?
191 2011-05-31T16:45:26 *** m4k3r
192 2011-05-31T16:45:29 <ThomasWaldmann> afaik there are no charsets with blanks
193 2011-05-31T16:46:10 <dreimark> if there is no charset given, which is the default?
194 2011-05-31T16:46:27 <ThomasWaldmann> that is irrelevant for that stuff
195 2011-05-31T16:46:42 <ThomasWaldmann> we are just tokenizing what we have
196 2011-05-31T16:47:01 <dreimark> ok
197 2011-05-31T16:47:27 <ThomasWaldmann> (if the item was created the usual way, it is all charset=utf-8)
198 2011-05-31T16:47:42 <dreimark> hardy89: if that crash happens do you be in the env?
199 2011-05-31T16:48:08 <hardy89> dreimark: yes. i did everything while i was in env
200 2011-05-31T16:48:29 <dreimark> can you redo please, first
201 2011-05-31T16:48:37 <dreimark> * deactivate
202 2011-05-31T16:48:43 <dreimark> * rm -r env
203 2011-05-31T16:48:49 <dreimark> ./quickinstall
204 2011-05-31T16:49:01 <Marchael> ThomasWaldmann: what's wrong with 122/
205 2011-05-31T16:49:02 <Marchael> ?
206 2011-05-31T16:49:05 <ThomasWaldmann> Marchael: when you compare the testing code of mimetype and acl tokenizer, is there something jumping at you?
207 2011-05-31T16:49:10 <hardy89> dreimark: sure sure.
208 2011-05-31T16:49:38 <ThomasWaldmann> Marchael: i doubt that you wrote that test and it succeeded in the first place
209 2011-05-31T16:49:53 <ThomasWaldmann> it first failed and then you edited it so it succeeds
210 2011-05-31T16:50:44 <ThomasWaldmann> and you'ld need to do that for every test case like that, because you are still using lists
211 2011-05-31T16:51:48 <ThomasWaldmann> (in the specific case of mimetype params, the issue is because the params get into a dict and dicts don't have ORDER)
212 2011-05-31T16:52:07 <ThomasWaldmann> but lists have order
213 2011-05-31T16:52:54 *** hardy89
214 2011-05-31T16:53:58 *** ronny
215 2011-05-31T16:54:12 <ThomasWaldmann> Marchael: so how can you fix that?
216 2011-05-31T16:54:56 * ThomasWaldmann already mentioned it some hours ago, but somehow the message did not reach its destianation :)
217 2011-05-31T16:55:44 <Marchael> I'm sorry, but I'm don't quite understand what problem with lists?
218 2011-05-31T16:56:12 <ThomasWaldmann> 121 u'text/html;value1=foo;value2=bar',
219 2011-05-31T16:56:22 <ThomasWaldmann> 122 [u'text', u'html', u'value2=bar', u'value1=foo']
220 2011-05-31T16:56:46 <ThomasWaldmann> you had to switch order of value1 and value2 because the test failed
221 2011-05-31T16:57:00 <Marchael> of course
222 2011-05-31T16:57:19 <ThomasWaldmann> that's because you are testing order of results
223 2011-05-31T16:57:45 <ThomasWaldmann> which is not really important for such a tokenizer
224 2011-05-31T16:58:01 <Marchael> Is it bad what value1 and value2 will be in wrong order?
225 2011-05-31T16:58:12 <ThomasWaldmann> especially as you can not predict order of params at all
226 2011-05-31T16:58:17 <Marchael> they values don't change from that
227 2011-05-31T16:58:31 *** m4k3r
228 2011-05-31T16:58:40 <dreimark> which type is not dependent for order ?
229 2011-05-31T16:58:48 <ThomasWaldmann> thus, you fix it be not using an ordered data type
230 2011-05-31T16:58:55 <ThomasWaldmann> by*
231 2011-05-31T16:59:03 <dreimark> :)
232 2011-05-31T16:59:17 <ronny> oO
233 2011-05-31T17:02:03 *** hardy89
234 2011-05-31T17:02:29 <hardy89> dreimark: now i get this http://paste.pocoo.org/show/398347/
235 2011-05-31T17:03:04 <hardy89> dreimark: things were going fine till yesterday and then this happened.
236 2011-05-31T17:03:07 <hardy89> interesting :)
237 2011-05-31T17:03:59 <ThomasWaldmann> IOError: [Errno 13] Permission denied: '/Users/himanshuawasthi/.pip/pip.log'
238 2011-05-31T17:04:10 <ThomasWaldmann> why do you have permission issues?
239 2011-05-31T17:05:05 <ThomasWaldmann> and that log is not complete. next time please save the complete log.
240 2011-05-31T17:05:49 <hardy89> ThomasWaldmann: i have the entire quickinstall log. i just gave the error thing
241 2011-05-31T17:05:57 <hardy89> just a moment
242 2011-05-31T17:06:17 <ThomasWaldmann> (by reading such a log, one can usually find the issue)
243 2011-05-31T17:06:51 <dreimark> hardy89: which user id is running quickinstall ?
244 2011-05-31T17:07:05 <hardy89> http://paste.pocoo.org/show/398354/
245 2011-05-31T17:07:08 <dreimark> and to which user belongs /Users/himanshuawasthi/.pip/pip.log
246 2011-05-31T17:07:45 <hardy89> dreimark: just one user on my local system, and by default admin.
247 2011-05-31T17:07:57 <hardy89> himanshuawasthi == me
248 2011-05-31T17:09:09 <ThomasWaldmann> it doesn't install all the python dependencies
249 2011-05-31T17:09:31 <dreimark> which python version do you have?
250 2011-05-31T17:09:44 <hardy89> ThomasWaldmann: yeah right.
251 2011-05-31T17:09:49 <hardy89> dreimark: 2.6.1
252 2011-05-31T17:11:23 <ThomasWaldmann> hardy89: show your MoinMoin/__init__.py
253 2011-05-31T17:12:27 <hardy89> ThomasWaldmann: http://paste.pocoo.org/show/398358/
254 2011-05-31T17:13:02 <ThomasWaldmann> that's not the correct content
255 2011-05-31T17:13:21 <ThomasWaldmann> that's obviously the datastruct init, not the MoinMoin init
256 2011-05-31T17:13:49 <ThomasWaldmann> are you have filesystem issues or did you mess that up manually? :)
257 2011-05-31T17:14:16 <hardy89> ThomasWaldmann: that is all i have in MoinMoin/_init_.py :/
258 2011-05-31T17:14:33 <hardy89> ThomasWaldmann: i probably wud have done it manually :)
259 2011-05-31T17:14:52 <dreimark> # Copyright: 2009 MoinMoin:DmitrijsMilajevs
260 2011-05-31T17:15:03 <dreimark> that sounds completly wrong
261 2011-05-31T17:15:09 <dreimark> from where is that a clone ?
262 2011-05-31T17:15:36 <ThomasWaldmann> hg st
263 2011-05-31T17:15:38 <ThomasWaldmann> hg diff
264 2011-05-31T17:15:39 <ThomasWaldmann> ...
265 2011-05-31T17:15:49 <ThomasWaldmann> should give some insights
266 2011-05-31T17:15:56 <hardy89> dreimark, ThomasWaldmann : https://bitbucket.org/89hardy/pytest_moin
267 2011-05-31T17:16:01 <hardy89> i cloned it from here
268 2011-05-31T17:16:12 <hardy89> before that, i forked it from pkumar's repo
269 2011-05-31T17:16:13 <ThomasWaldmann> and make sure you are not having fs issues (e.g. fun a filesystem check)
270 2011-05-31T17:16:13 <dreimark> and what did you fork?
271 2011-05-31T17:16:36 <hardy89> dreimark: https://bitbucket.org/pkumar/pytest_moin
272 2011-05-31T17:17:02 <ThomasWaldmann> it's correct there
273 2011-05-31T17:17:08 <dreimark> https://bitbucket.org/pkumar/pytest_moin/src/17931e46e2df/MoinMoin/__init__.py
274 2011-05-31T17:17:10 <dreimark> yeah
275 2011-05-31T17:17:41 <dreimark> hardy89: which mercurial version do you use?
276 2011-05-31T17:17:54 <ThomasWaldmann> hg revert MoinMoin/__init__.py
277 2011-05-31T17:18:18 <hardy89> version 1.8.2+20110401
278 2011-05-31T17:18:30 <ThomasWaldmann> and look through hg st and hg diff if they only contain intended changes (or if you messed up more)
279 2011-05-31T17:19:38 <ThomasWaldmann> Marchael: any progress?
280 2011-05-31T17:19:58 <Marchael> I'll try use dict instead of list
281 2011-05-31T17:20:05 <ThomasWaldmann> nope
282 2011-05-31T17:20:08 <ThomasWaldmann> use a set
283 2011-05-31T17:20:21 <hardy89> ThomasWaldmann: it says 'no changes needed to MoinMoin/__init__.py'
284 2011-05-31T17:20:22 <hardy89> :)
285 2011-05-31T17:21:01 <ThomasWaldmann> hardy89: you run the command from the workdir directory? where setup.py is?
286 2011-05-31T17:21:18 <hardy89> ThomasWaldmann: yes yes
287 2011-05-31T17:21:36 <ThomasWaldmann> put hg diff and hg st into a pastebin
288 2011-05-31T17:22:55 <hardy89> ThomasWaldmann: http://paste.pocoo.org/show/398367/
289 2011-05-31T17:23:03 <ThomasWaldmann> Marchael: and you have to change less, if you first think about where to put that set() exactly
290 2011-05-31T17:23:34 <ThomasWaldmann> hardy89: that's completely fscked
291 2011-05-31T17:23:48 <hardy89> ThomasWaldmann: seems so
292 2011-05-31T17:23:50 <ThomasWaldmann> ? means that the file is not under revision control
293 2011-05-31T17:24:07 <ThomasWaldmann> but all the files it lists should be under revision control
294 2011-05-31T17:24:25 <ThomasWaldmann> so i suggest your run a filesystem check next and then start with a fresh clone
295 2011-05-31T17:24:47 <hardy89> ThomasWaldmann: it'll be a good idea i guess to remove repo from my system and bitbucket too
296 2011-05-31T17:24:53 <ThomasWaldmann> and then try to put stuff you already worked on into that fresh clone
297 2011-05-31T17:24:57 <hardy89> ThomasWaldmann: and then make things neat
298 2011-05-31T17:25:54 * hardy89 has some work to be done now :|
299 2011-05-31T17:26:20 <hardy89> ThomasWaldmann: is this included in daily diary entry? :D
300 2011-05-31T17:26:55 <ThomasWaldmann> that's good for 30 minutes of your 8h day
301 2011-05-31T17:27:20 <hardy89> ThomasWaldmann: indeed.
302 2011-05-31T17:31:09 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/398373/
303 2011-05-31T17:33:49 <ThomasWaldmann> Marchael: which python version are you using?
304 2011-05-31T17:34:00 <Marchael> 2.7.1
305 2011-05-31T17:34:13 *** RogerHaase
306 2011-05-31T17:34:26 <ThomasWaldmann> Marchael: that code does not work on 2.6
307 2011-05-31T17:34:47 <ThomasWaldmann> (17:23) < ThomasWal> Marchael: and you have to change less, if you first think about where to put that set() exactly
308 2011-05-31T17:35:29 <ThomasWaldmann> {} for set literals is new in 2.7 iirc
309 2011-05-31T17:36:03 <Marchael> may be replace {} to set() ?
310 2011-05-31T17:36:20 <ThomasWaldmann> before one had to use set([...])
311 2011-05-31T17:36:39 <ThomasWaldmann> but just read what I told twice before you change many lines
312 2011-05-31T17:38:31 <ThomasWaldmann> >>> set([1,2,3]) == set([3,2,1,1,1])
313 2011-05-31T17:38:31 <ThomasWaldmann> True
314 2011-05-31T17:41:39 <hardy89> ThomasWaldmann: this it has to be quickinstall first. and then venv
315 2011-05-31T17:41:41 <hardy89> right?
316 2011-05-31T17:41:58 <ThomasWaldmann> Marchael: and after that, you should write a TokenizerTestBase class and move all common stuff there
317 2011-05-31T17:42:06 <Marchael> http://paste.pocoo.org/show/398384/
318 2011-05-31T17:42:21 <ThomasWaldmann> then derive your acl and mimetype test classes from that one and have no code duplication
319 2011-05-31T17:43:00 <ThomasWaldmann> you need set() exactly 2 times in the whole file
320 2011-05-31T17:43:24 <ThomasWaldmann> (your code works, but is too complicated)
321 2011-05-31T17:43:54 <Marchael> %(
322 2011-05-31T17:44:14 <hardy89> ThomasWaldmann: it has to be quickinstall first. and then venv this time? I've checked the _init_.py although. looks fine.
323 2011-05-31T17:44:46 <ThomasWaldmann> hardy89: rephrase your question
324 2011-05-31T17:45:28 <hardy89> this time it should be 1. ./quickinstall and 2. venv
325 2011-05-31T17:45:32 <hardy89> isn't it/
326 2011-05-31T17:45:34 <hardy89> ?
327 2011-05-31T17:45:41 <hardy89> ThomasWaldmann: ^
328 2011-05-31T17:45:52 <ThomasWaldmann> hardy89: there are docs about how to do that, please read them
329 2011-05-31T17:46:09 <ThomasWaldmann> (that would've been a task for ~5 weeks ago btw)
330 2011-05-31T17:46:37 <ThomasWaldmann> docs/install.rst or follow the link from the MoinMoin2.0 wiki page
331 2011-05-31T17:46:39 <hardy89> ThomasWaldmann: i've done it many a times and it has worked. but its just that i want t play safe this time :|
332 2011-05-31T17:46:50 <hardy89> *to
333 2011-05-31T17:47:37 <ThomasWaldmann> Marchael: you found the right place?
334 2011-05-31T17:49:15 <Marchael> TypeError: unhashable type: 'list' means not :(
335 2011-05-31T17:49:35 <Marchael> but I still finding
336 2011-05-31T17:50:52 <ThomasWaldmann> what code gives that error?
337 2011-05-31T17:51:26 <Marchael> http://paste.pocoo.org/show/398390/
338 2011-05-31T17:51:56 <ThomasWaldmann> no, keep the list of 2-tuples, no set there
339 2011-05-31T17:52:15 <ThomasWaldmann> assert set(one) == set(two)
340 2011-05-31T17:52:32 <ThomasWaldmann> that's all you need
341 2011-05-31T17:52:51 * Marchael idiot
342 2011-05-31T17:53:02 <Marchael> It' sobvious
343 2011-05-31T17:53:11 *** hardy89
344 2011-05-31T17:53:14 <Marchael> 's obviuos
345 2011-05-31T17:53:37 <ThomasWaldmann> and one and two need to be lists of elements
346 2011-05-31T17:54:07 <Marchael> I've done it
347 2011-05-31T17:54:34 <ThomasWaldmann> btw, of course this method is only valid if the count of elements of same value is not important
348 2011-05-31T17:54:48 <ThomasWaldmann> otherwise you need sorted() == sorted()
349 2011-05-31T17:55:39 <ThomasWaldmann> did you understand my point about the common base class for the tokenizer tests?
350 2011-05-31T17:57:05 <Marchael> one base class with classes of all tests
351 2011-05-31T17:57:38 <ThomasWaldmann> one base class with no tests, just common code
352 2011-05-31T17:58:02 <ThomasWaldmann> because currently you have duplicate code
353 2011-05-31T17:58:26 <ThomasWaldmann> and each time you add another tokenizer/analyzer test, you would copy&paste it once more
354 2011-05-31T18:00:23 <ThomasWaldmann> idea is clear?
355 2011-05-31T18:00:34 <Marchael> yup
356 2011-05-31T18:15:07 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/398400/
357 2011-05-31T18:16:15 <Marchael> s/list_of_tokens/tokens/
358 2011-05-31T18:19:45 <ThomasWaldmann> nope
359 2011-05-31T18:20:04 <ThomasWaldmann> you move all into the base class, not just the code
360 2011-05-31T18:20:47 <ThomasWaldmann> the idea was to have the test method in the base class (just rename some names there so they are generic)
361 2011-05-31T18:21:16 <Marchael> ah, ok
362 2011-05-31T18:21:19 <ThomasWaldmann> and then have TestACLTokenizer(TokenizerTestBase):
363 2011-05-31T18:21:25 <ThomasWaldmann> test_cases = ...
364 2011-05-31T18:21:27 <ThomasWaldmann>
365 2011-05-31T18:21:41 <ThomasWaldmann> TestMimeTokenizer(TokenizerTestBase):
366 2011-05-31T18:21:47 <ThomasWaldmann> test_cases = ...
367 2011-05-31T18:21:49 <ThomasWaldmann>
368 2011-05-31T18:22:12 <ThomasWaldmann> and both inherit the test code from the base class
369 2011-05-31T18:23:02 <ThomasWaldmann> class ...*
370 2011-05-31T18:31:29 *** hardy89
371 2011-05-31T18:38:18 <hardy89> ThomasWaldmann: this is what i get now http://paste.pocoo.org/show/398417/ :/
372 2011-05-31T18:39:10 <ThomasWaldmann> wasn't that stuff already fixed?
373 2011-05-31T18:39:36 <ThomasWaldmann> hardy89: are you working on wrong branch?
374 2011-05-31T18:39:58 <hardy89> i don't think so
375 2011-05-31T18:40:32 <hardy89> i even did a easy_install SQLAlchemy
376 2011-05-31T18:40:36 <hardy89> nothing happened
377 2011-05-31T18:40:43 <ThomasWaldmann> hg branch tells?
378 2011-05-31T18:41:01 <hardy89> default
379 2011-05-31T18:41:41 <ThomasWaldmann> you need the pytest2 branch
380 2011-05-31T18:42:09 <hardy89> ThomasWaldmann: changes need to be done in setup.py
381 2011-05-31T18:42:20 <hardy89> and then a ./quickinstall
382 2011-05-31T18:42:22 <hardy89> ?
383 2011-05-31T18:42:27 <ThomasWaldmann> you need the pytest2 branch
384 2011-05-31T18:42:42 <hardy89> oh ok
385 2011-05-31T18:44:44 <hardy89> ThomasWaldmann: i need to create it?
386 2011-05-31T18:45:02 <ThomasWaldmann> if you clone from pkumar, it is already there
387 2011-05-31T18:46:51 <hardy89> ThomasWaldmann: ok i'm there
388 2011-05-31T18:46:58 <hardy89> hg branch now shows pytest2
389 2011-05-31T18:58:14 <hardy89> ThomasWaldmann: God gracious. Finally it works :)
390 2011-05-31T19:00:35 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/398431/
391 2011-05-31T19:01:48 *** hardy89
392 2011-05-31T19:07:04 <dreimark> bbl
393 2011-05-31T19:07:11 *** kursor
394 2011-05-31T19:21:07 <ThomasWaldmann> Marchael: the tests succeed?
395 2011-05-31T19:21:57 <Marchael> yes
396 2011-05-31T19:22:19 <ThomasWaldmann> minor thing: expected_value -> expected_tokens
397 2011-05-31T19:22:28 <ThomasWaldmann> remove 117
398 2011-05-31T19:22:33 <ThomasWaldmann> then it's perfect
399 2011-05-31T19:22:55 <ThomasWaldmann> check hg st and hg diff
400 2011-05-31T19:23:03 <ThomasWaldmann> commit with a good comment
401 2011-05-31T19:23:06 <ThomasWaldmann> push :)
402 2011-05-31T19:23:23 <Marchael> oh, finally
403 2011-05-31T19:27:47 <ThomasWaldmann> did you set your name/email in ~/.hgrc?
404 2011-05-31T19:28:36 <Marchael> yes
405 2011-05-31T19:29:33 * Marchael don't see how he can sync with ThomasWaldmann on bitbucket
406 2011-05-31T19:30:01 <Marchael> I fork moin-2.0 repo 8 days ago
407 2011-05-31T19:30:05 <Marchael> *forked
408 2011-05-31T19:30:48 <ThomasWaldmann> first push
409 2011-05-31T19:34:22 <ronny> bbl, going o the training
410 2011-05-31T19:54:32 *** greg_f
411 2011-05-31T20:00:47 <Marchael> ThomasWaldmann: https://bitbucket.org/marchael/moin-2.0/changeset/28093a47a961
412 2011-05-31T20:02:11 *** m4k3r
413 2011-05-31T20:03:56 *** m4k3r
414 2011-05-31T20:04:46 <ThomasWaldmann> Marchael: add some test for item_name_analyzer
415 2011-05-31T20:12:33 *** m4k3r
416 2011-05-31T20:14:20 *** m4k3r
417 2011-05-31T20:21:55 <Marchael> ThomasWaldmann: and how I can now sync with your repo?
418 2011-05-31T20:22:10 <ThomasWaldmann> you pull from it and merge
419 2011-05-31T20:22:21 <Marchael> ok
420 2011-05-31T20:23:28 <ThomasWaldmann> and do no other changes before committing the merge
421 2011-05-31T20:25:24 *** sinha
422 2011-05-31T20:37:57 <Marchael> ThomasWaldmann: I merged with your repo, then commiting changes, but I don't see any results on bb
423 2011-05-31T20:38:17 <ThomasWaldmann> push?
424 2011-05-31T20:38:46 <Marchael> oh, yeah :)
425 2011-05-31T20:39:51 <ThomasWaldmann> see EP chat
426 2011-05-31T20:40:20 *** m4k3r
427 2011-05-31T20:48:22 <dreimark> re
428 2011-05-31T20:58:52 *** kursor
429 2011-05-31T21:18:25 *** pkumar
430 2011-05-31T21:18:40 <pkumar> ronny: hi
431 2011-05-31T21:21:43 <pkumar> ronny: seems like it works, but one or two tests in few files are failing, seems like they were meant to work for pytest.collect.Class. Not sure though.
432 2011-05-31T21:22:12 <pkumar> ronny: can be fixed I guess
433 2011-05-31T21:47:04 * Marchael going sleep
434 2011-05-31T21:47:06 <Marchael> bbl
435 2011-05-31T21:47:49 <ThomasWaldmann> gn Marchael
436 2011-05-31T22:01:19 *** pkumar
437 2011-05-31T22:25:19 <ronny> re
438 2011-05-31T22:26:53 *** sinha
439 2011-05-31T22:37:31 *** yakoi
440 2011-05-31T22:46:20 *** yakoi
441 2011-05-31T23:06:19 *** ronny
442 2011-05-31T23:22:53 *** ronny
443 2011-05-31T23:22:54 <ronny> re
444 2011-05-31T23:31:41 <ThomasWaldmann> hehe, 23:23
445 2011-05-31T23:31:48 <ThomasWaldmann> coincidence!?
