1 2011-05-25T00:14:11 *** m4k3r
2 2011-05-25T00:30:29 *** pkumar
3 2011-05-25T00:31:22 <pkumar> ronny: finally, my changes are in pytest2 branch. Also I have removed some of the commits
4 2011-05-25T00:31:37 <pkumar> ronny: https://bitbucket.org/pkumar/pytest_moin
5 2011-05-25T00:32:47 <ronny> pkumar: mom, taking a look
6 2011-05-25T00:34:02 <ronny> pkumar: looks as expected now
7 2011-05-25T00:35:05 <pkumar> ronny: yeah, I was missing the updating part till pytest2
8 2011-05-25T00:35:52 <pkumar> ronny: now should I add those changes suggested by you to conftest.py?
9 2011-05-25T00:36:14 <ronny> yeah
10 2011-05-25T00:36:59 <pkumar> ronny: Also if you could help me with some porting ideas as this week is suppose to be poring week.
11 2011-05-25T00:37:37 <pkumar> porting moinmoin tests over to pytest 2.0.3
12 2011-05-25T00:38:16 <ronny> pkumar: one temporary idea is to intercept generators and run them as single test items for now
13 2011-05-25T00:39:18 <pkumar> ronny: can you please tell more about 'intercept generators'
14 2011-05-25T00:39:43 <pkumar> ronny: I'm not sure about what it is.
15 2011-05-25T00:40:36 <ronny> pkumar: currently generator tests (tests using yield to do parts of a test) are setuup at collection time, then their seupstate is destroyed by the actual testrun
16 2011-05-25T00:40:48 <ronny> (in pytest1 it didnt matter, since it ran tests as it found them)
17 2011-05-25T00:41:37 <pkumar> okay
18 2011-05-25T00:43:31 <pkumar> so, I should not change py.test imports to pytest as the tests should also be compatible with py.test 1.3. right?
19 2011-05-25T00:43:37 <pkumar> ronny: ^
20 2011-05-25T00:44:57 <ronny> pkumar: in the pytest2 branch its ok
21 2011-05-25T00:45:12 <ronny> pkumar: but on default, where pytest1.3 is needed, its kind of a bad thing
22 2011-05-25T00:46:14 <pkumar> ronny: yeah, right.
23 2011-05-25T01:08:16 *** pkumar
24 2011-05-25T01:50:06 *** ronny
25 2011-05-25T01:51:37 *** ronny
26 2011-05-25T05:14:08 *** MattMaker
27 2011-05-25T06:18:13 *** sinha
28 2011-05-25T06:34:30 *** Marchael
29 2011-05-25T06:34:42 <Marchael> moin
30 2011-05-25T07:00:09 *** MattMaker
31 2011-05-25T07:05:04 *** sinha
32 2011-05-25T07:14:57 *** Marchael
33 2011-05-25T07:31:38 *** m4k3r
34 2011-05-25T08:07:22 *** MattMaker
35 2011-05-25T08:08:17 *** m4k3r
36 2011-05-25T08:37:30 *** Marchael
37 2011-05-25T08:45:02 *** m4k3r
38 2011-05-25T09:14:38 *** andialbrecht_
39 2011-05-25T10:01:06 *** m4k3r
40 2011-05-25T10:06:06 <ThomasWaldmann> moin
41 2011-05-25T10:06:40 <Marchael> hi ThomasWaldmann
42 2011-05-25T10:15:20 *** MattMaker
43 2011-05-25T10:58:54 *** Marchael
44 2011-05-25T11:02:12 *** Marchael
45 2011-05-25T11:10:50 *** MattMaker
46 2011-05-25T11:29:37 <CIA-69> pkumar <contactprashantat@gmail.com> * fb5d880d7b86 r251 pytest2/MoinMoin/conftest.py: pytest_pycollect_makeitem() in conftest.py changed since collector._istestclasscandidate doesn't exist anymore.
47 2011-05-25T11:29:37 <CIA-69> pkumar <contactprashantat@gmail.com> * a182d358871c r252 pytest2/MoinMoin/util/_tests/ (10 files): py.test changed to pytest in all tests of util module
48 2011-05-25T11:56:29 *** Gnarlodious
49 2011-05-25T12:07:05 *** Gnarlodious
50 2011-05-25T12:10:56 *** sinha
51 2011-05-25T12:27:33 <sinha> ThomasWaldmann: I am converting a timestamp to date tiem format through python code, but it comes out different when the same timestamp is converted in templates using some filter ? How to make them sync ?
52 2011-05-25T12:27:58 <sinha> s/tiem/time
53 2011-05-25T12:29:19 <sinha> and is the time conversion done in templates based on UTC ?
54 2011-05-25T12:50:47 <ThomasWaldmann> sinha: you simply do not convert it in python code, but give the timestamp to them template and use the usual filter there
55 2011-05-25T12:51:15 <sinha> ok yes i could do that.
56 2011-05-25T12:53:29 <sinha> ThomasWaldmann: reg todays meeting, i have some serious net issues here it goes off anytime, so there may be chances that i may not be on time.
57 2011-05-25T12:55:01 <ThomasWaldmann> can you fix that?
58 2011-05-25T12:55:57 <sinha> i will try to solve that, after 2 days i am moving to a better place where there wont be any such issues
59 2011-05-25T12:57:33 <sinha> ThomasWaldmann: i have to use a dateformat filter of timestamp in templates, filters like datetimeformat,timeformat exists but not dateformat ? should i use the datetimeformat and extract a substring from that or there need to create a new filter ?
60 2011-05-25T13:11:18 *** ronny
61 2011-05-25T13:23:11 <dreimark> moin
62 2011-05-25T13:25:37 <dreimark> sinha: a new filter is better readable code
63 2011-05-25T13:26:46 <dreimark> but isn't there not already something with patterns implemented?
64 2011-05-25T13:26:55 <sinha> so you are saying to create a new one
65 2011-05-25T13:27:54 <dreimark> sinha: do you have looked into the existing code?
66 2011-05-25T13:28:05 <dreimark> i guess it has a format keyword
67 2011-05-25T13:29:12 <sinha> no i haven't i thought it may have existed as timeformat exists
68 2011-05-25T13:29:20 <sinha> where should i look for them ?
69 2011-05-25T13:29:42 <dreimark> in eclipse search for datetimeformat
70 2011-05-25T13:29:59 <sinha> dreimark: here http://115.117.202.27:8080/+history so far done
71 2011-05-25T13:30:16 <dreimark> it is usually in babel
72 2011-05-25T13:30:31 <sinha> please see it soon, my power is dying
73 2011-05-25T13:30:59 <dreimark> i try
74 2011-05-25T13:31:14 <dreimark> do you have some changesets i can look at too
75 2011-05-25T13:31:42 <dreimark> at least the tab tells now "My MoinMoin" me is waiting for the content
76 2011-05-25T13:32:47 <sinha> i dont have now, i will put it soon
77 2011-05-25T13:32:52 <dreimark> looks like I don't get a request
78 2011-05-25T13:32:58 <sinha> i just wanted to test it first
79 2011-05-25T13:33:08 <dreimark> sinha: please do small commits, not too much changes in one
80 2011-05-25T13:33:25 <dreimark> trying is always good :)
81 2011-05-25T13:33:45 * dreimark don't get access to the page
82 2011-05-25T13:33:48 <sinha> weird net issues
83 2011-05-25T13:34:34 <sinha> i started moin in that host name
84 2011-05-25T13:35:10 <Marchael> ThomasWaldmann: I read about py.test. So what I should doing now, write tests for MimeTokenizer and AclTokenizer?
85 2011-05-25T13:36:18 <dreimark> sinha: def format_datetime(datetime=None, format=None, rebase=True)
86 2011-05-25T13:36:41 <dreimark> you should be able to pass a format string
87 2011-05-25T13:36:44 <sinha> is this the filter name ?
88 2011-05-25T13:37:10 <sinha> where in template file ? or python code
89 2011-05-25T13:38:06 <dreimark> sinha: do you have eclipse? I think it is easier to search for stuff which is in libraries of env
90 2011-05-25T13:38:09 <Marchael> afk
91 2011-05-25T13:38:59 <sinha> i have it but currently i am using vim, i found it difficulty in doing commit and pull and also having slow net so not able to install plugins.
92 2011-05-25T13:39:25 * sinha moving back to hostel in 2-3 days, will have a better working condition there
93 2011-05-25T13:39:26 <dreimark> I usually do use hg from a terminal
94 2011-05-25T13:39:42 <dreimark> and eclipse for editing/searching/refactoring
95 2011-05-25T13:40:01 <sinha> did you see that page ?
96 2011-05-25T13:40:01 <sinha> or not able to access that
97 2011-05-25T13:40:25 <dreimark> it is waiting
98 2011-05-25T13:40:54 <dreimark> I can let try it a bit longer
99 2011-05-25T13:41:30 <dreimark> sinha: PING 115.117.202.27 (115.117.202.27) 56(84) bytes of data.
100 2011-05-25T13:41:40 <dreimark> no access from my location
101 2011-05-25T13:43:22 <sinha> Exception happening in moin when you try to access
102 2011-05-25T13:43:32 <dreimark> now i get it time=1620 ms
103 2011-05-25T13:43:32 <sinha> see this http://paste.pocoo.org/show/394813/
104 2011-05-25T13:43:43 <sinha> brb, power is almost nil :(
105 2011-05-25T13:43:44 <dreimark> traceroute from MM needs 29 hops
106 2011-05-25T13:43:48 *** sinha
107 2011-05-25T13:45:46 *** m4k3r
108 2011-05-25T13:50:34 *** ronny
109 2011-05-25T14:24:09 *** Marchael
110 2011-05-25T15:05:39 *** Marchael
111 2011-05-25T15:08:47 *** m4k3r
112 2011-05-25T15:09:16 *** m4k3r
113 2011-05-25T15:13:17 *** Gnarlodious
114 2011-05-25T15:14:25 *** pkumar
115 2011-05-25T15:14:57 <pkumar> xorAxAx: hi
116 2011-05-25T15:15:31 <pkumar> xorAxAx: I was wondering if we have to keep our tests compatible with py.test 1.3
117 2011-05-25T15:15:42 <pkumar> in pytest2 branch
118 2011-05-25T15:18:07 <pkumar> ThomasWaldmann: ^
119 2011-05-25T15:29:30 <ThomasWaldmann> pkumar: if you succeed converting them all: no
120 2011-05-25T15:30:01 <ThomasWaldmann> but if you don't have a special reason to make them inkompatible, then do not
121 2011-05-25T15:30:19 *** Gnarlodious
122 2011-05-25T15:34:06 <xorAxAx> pkumar: whats the point of 82aab0626558?
123 2011-05-25T15:34:32 <xorAxAx> pkumar: i think the apis differ too much to make them not incompatible
124 2011-05-25T15:34:40 <Marchael> ThomasWaldmann: I read about py.test, but I still confused with writing test for AclTokenizer.
125 2011-05-25T15:34:58 <pkumar> xorAxAx: lemme check
126 2011-05-25T15:35:24 <xorAxAx> waldi: welcome to our 3 person meeting
127 2011-05-25T15:35:43 <xorAxAx> waldi: whats the status of your student?
128 2011-05-25T15:35:43 <Marchael> I should use test_request_context() for it, but I don't see any way how I can get current_app.cfg from moin.
129 2011-05-25T15:36:21 <pkumar> xorAxAx: yeah, that was what I planned to do earlier but seems like that was a bad idea
130 2011-05-25T15:36:24 <ThomasWaldmann> Marchael: you get that like one always gets that, just use grep in existing code
131 2011-05-25T15:36:40 <xorAxAx> pkumar: yes, its unpythonic to duplicate launcher code in every test file
132 2011-05-25T15:36:48 <xorAxAx> we are not in the ruby world here :)
133 2011-05-25T15:37:34 <ThomasWaldmann> Marchael: that stuff is a bit magic, so don't wonder. if you want to understand it, read the flask docs about threadlocals (requestlocals?)
134 2011-05-25T15:38:54 <pkumar> xorAxAx: Lets say for example, in pytest we have different skip methods which look more clean, though it won't work in py.test 1.3
135 2011-05-25T15:39:11 <xorAxAx> pkumar: yes, go for 2.0, thats fine
136 2011-05-25T15:39:20 <pkumar> xorAxAx: as in af96b35a6a42
137 2011-05-25T15:39:25 <pkumar> xorAxAx: okay
138 2011-05-25T15:50:55 <CIA-69> pkumar <contactprashantat@gmail.com> * 8eb54b6d9537 r253 pytest2/MoinMoin/config/_tests/test_defaultconfig.py: py.test changed to pytest in config module
139 2011-05-25T15:50:55 <CIA-69> pkumar <contactprashantat@gmail.com> * cd629258f343 r254 pytest2/MoinMoin/apps/frontend/_tests/test_frontend.py: py.test changed to pytest in all tests of module apps
140 2011-05-25T15:50:55 <CIA-69> pkumar <contactprashantat@gmail.com> * 256d000ae06b r255 pytest2/MoinMoin/ (conftest.py util/_tests/test_filesys.py): witespaces in conftes.py and test_filesys.py removed to fix failure in test_sourcecode.py
141 2011-05-25T15:50:56 <CIA-69> pkumar <contactprashantat@gmail.com> * a547161f1b74 r256 pytest2/MoinMoin/conftest.py: Information in conftest.py added about the test validation only for pytest-2
142 2011-05-25T15:50:56 <CIA-69> pkumar <contactprashantat@gmail.com> * a311a1addca3 r257 pytest2/MoinMoin/_tests/ (6 files): py.test changed to pytest in all tests of module MoinMoin
143 2011-05-25T15:50:56 <CIA-69> pkumar <contactprashantat@gmail.com> * 17931e46e2df r258 pytest2/MoinMoin/ (13 files in 2 dirs): py.test changed to pytest in conftest.py and all the tests of converter module.
144 2011-05-25T16:04:09 <pkumar> xorAxAx: Why does it take more time in executing tests in pytest-2 tests compared to py.test 1.3?
145 2011-05-25T16:04:44 <xorAxAx> pkumar: good question, try python -m cProfile `which pytest`
146 2011-05-25T16:04:56 <xorAxAx> pkumar: good question, try python -m cProfile -s time `which pytest`
147 2011-05-25T16:04:58 * dreimark regular meeting ?
148 2011-05-25T16:05:04 <xorAxAx> dreimark: yes!
149 2011-05-25T16:05:15 <xorAxAx> dreimark: after we had our 2 out of 4 person meeting, we now start into the regular meeting
150 2011-05-25T16:05:30 <xorAxAx> waldi: i am not amused
151 2011-05-25T16:05:42 <pkumar> xorAxAx: ok I'll check that out.
152 2011-05-25T16:05:45 <dreimark> what is with waldi and hardy_89 ?
153 2011-05-25T16:06:21 <xorAxAx> pkumar, Marchael: you seem to be the only two students here
154 2011-05-25T16:06:34 <pkumar> seems so :)
155 2011-05-25T16:06:53 <xorAxAx> dreimark: please report about the progress of your student
156 2011-05-25T16:07:15 <dreimark> sinha told some hours ago he has network problems and will fix that in the next 2-3 days
157 2011-05-25T16:07:15 <xorAxAx> pkumar: it is called "whitespace" and not "witespace" :)
158 2011-05-25T16:07:32 <Marchael> :D
159 2011-05-25T16:07:36 <dreimark> he is working on global history
160 2011-05-25T16:07:49 <dreimark> I have not seen any code yet
161 2011-05-25T16:08:14 <pkumar> xorAxAx: oh, a typo :)
162 2011-05-25T16:08:17 <ThomasWaldmann> re
163 2011-05-25T16:08:33 <dreimark> diary page is also incomplete for yesterday
164 2011-05-25T16:10:59 <xorAxAx> ok, then please tell us, what you did, what you want to do and what blocks you, pkumar
165 2011-05-25T16:13:06 <pkumar> I think it'll be good if we(testing students) could know about other changes in MoinMoin so that we can add tests to it in future
166 2011-05-25T16:13:39 <pkumar> so, current state is like this:
167 2011-05-25T16:13:49 * Marchael also writing test for pytest2
168 2011-05-25T16:15:00 <pkumar> All the changes will be there in branch pytest2 from Ronny's pulled from repo
169 2011-05-25T16:15:16 <pkumar> I mean pytest2 related changes
170 2011-05-25T16:15:52 <pkumar> Currently the plan it to get over with small change within one or two days
171 2011-05-25T16:17:25 <pkumar> http://moinmo.in/pkumar_diary
172 2011-05-25T16:18:18 <ThomasWaldmann> did you compare amount of fail before and after conversion?
173 2011-05-25T16:18:36 <pkumar> well, currently only thing I need is to collect more ideas on porting py.test over to pytest-2
174 2011-05-25T16:18:42 <pkumar> ThomasWaldmann: yup
175 2011-05-25T16:19:01 <pkumar> I'm checking with each change I make
176 2011-05-25T16:19:14 <xorAxAx> pkumar: you could ask ronny if he comes up with new ideas of improved api things
177 2011-05-25T16:19:43 * waldi arrives from the dead
178 2011-05-25T16:20:10 *** andialbrecht
179 2011-05-25T16:20:42 <pkumar> yeah, he has suggested one to intercept generators and run them as single test items. I need to look into that
180 2011-05-25T16:21:30 <pkumar> though I would surely be expecting more ideas from him :)
181 2011-05-25T16:24:09 <pkumar> xorAxAx: and why do we have some failures even in py.test 1.3 in some tests of converter module as in test_moinwiki_in_out.py and test_mediawiki_in.py?
182 2011-05-25T16:24:28 <xorAxAx> pkumar: because people dont care? :)
183 2011-05-25T16:25:37 <pkumar> xorAxAx: so, those need to be fixed and are not some configuration problem on my side right?
184 2011-05-25T16:26:28 <xorAxAx> pkumar: most likely, yes
185 2011-05-25T16:26:39 <xorAxAx> a zero tolerance policy is very useful when unittesting
186 2011-05-25T16:26:49 <xorAxAx> but if devs dont adhere to it, its useless
187 2011-05-25T16:27:06 <xorAxAx> maybe we should let NYC mayors code
188 2011-05-25T16:28:41 <ThomasWaldmann> can we maybe get through the formal points of the meeting before generic chat?
189 2011-05-25T16:29:45 <xorAxAx> ThomasWaldmann: we already started with that
190 2011-05-25T16:29:51 <xorAxAx> i think Marchael can now proceed
191 2011-05-25T16:30:16 <ThomasWaldmann> Marchael: what you did, blockers, plans for this week please
192 2011-05-25T16:31:37 <ronny> hey
193 2011-05-25T16:31:52 <Marchael> For last week I was a bit busy when prepeared for exams and offsets. One of exam was yerstaday, so I was blocked to write record in my diary
194 2011-05-25T16:32:07 <Marchael> oops, 23th
195 2011-05-25T16:32:27 <Marchael> 24 I was working on tokenizer for acl
196 2011-05-25T16:32:56 <Marchael> now I'm working on writing test for my code
197 2011-05-25T16:33:39 <Marchael> also I write content-type tokenizer(with big ThomasWaldman`s help)
198 2011-05-25T16:34:22 <Marchael> for next week I planning to deal with indexing whoosh schema
199 2011-05-25T16:34:31 <Marchael> *I'll
200 2011-05-25T16:34:43 <xorAxAx> *I am
201 2011-05-25T16:34:49 <Marchael> thx
202 2011-05-25T16:35:21 <Marchael> it has issues with fileds type
203 2011-05-25T16:35:24 <Marchael> for now
204 2011-05-25T16:35:46 <xorAxAx> any blockers?
205 2011-05-25T16:36:08 <Marchael> nothing serioulsy
206 2011-05-25T16:36:27 <Marchael> except 2 exams in future :)
207 2011-05-25T16:36:44 <Marchael> 7 june and 14 if I don't mistake
208 2011-05-25T16:37:59 <Marchael> something else what I could say?
209 2011-05-25T16:38:08 <xorAxAx> i dont think so, anything else, ThomasWaldmann?
210 2011-05-25T16:38:12 <ThomasWaldmann> blockers means something that keeps you back from working right now
211 2011-05-25T16:38:32 <dreimark> Marchael: for which pytest version doy ou write tests?
212 2011-05-25T16:38:35 <xorAxAx> otherwise we could close the meeting, also with 2/4 success rate :)
213 2011-05-25T16:38:41 <xorAxAx> dreimark: he said py.test 2
214 2011-05-25T16:38:43 <Marchael> dreimark: 2.0.3
215 2011-05-25T16:39:05 <dreimark> i know, but how does it match to current test state
216 2011-05-25T16:39:28 <dreimark> Marchael: ^
217 2011-05-25T16:39:52 <ThomasWaldmann> waldi: email your student about his failure to be here
218 2011-05-25T16:40:13 <ThomasWaldmann> in general, and especially for the meeting
219 2011-05-25T16:40:31 * xorAxAx will be back in 30 minutes
220 2011-05-25T16:41:15 <Marchael> dreimark: you mean version of py.test?
221 2011-05-25T16:41:54 <dreimark> Marchael: yes, because the current configuration in moin-2 is not pytest2 friendly
222 2011-05-25T16:43:16 <Marchael> dreimark: I try to write tests working with old and new pytest
223 2011-05-25T16:43:36 <Marchael> if can't do this then I'll discuss this with ThomasWaldmann
224 2011-05-25T16:44:34 *** pkumar
225 2011-05-25T16:44:48 <Marchael> sorry, need to go. I'll try go back through 1 hour
226 2011-05-25T16:44:50 <Marchael> bbl
227 2011-05-25T16:44:55 *** Marchael
228 2011-05-25T17:50:50 *** sinha
229 2011-05-25T17:51:12 <sinha> re
230 2011-05-25T17:53:30 <ronny> bbl
231 2011-05-25T17:57:59 <dreimark> sinha: can we continue with the meeting?
232 2011-05-25T17:58:10 <sinha> yes
233 2011-05-25T17:58:22 <sinha> dreimark: lets see you can open it http://115.117.235.22:8080/+history
234 2011-05-25T17:58:23 <dreimark> xorAxAx: ThomasWaldmann waldi available ?
235 2011-05-25T17:58:24 *** ronny
236 2011-05-25T17:58:37 <xorAxAx> no, busy
237 2011-05-25T17:58:51 <dreimark> sinha: summery of what you did, blockers, plans for this week
238 2011-05-25T18:01:17 <dreimark> sinha: yes, looks much better than the "old one"
239 2011-05-25T18:01:54 <dreimark> don't use speparate blocks that makes always different column sizes
240 2011-05-25T18:03:41 <sinha> i have kept it same
241 2011-05-25T18:04:01 <sinha> i was aware of that problem
242 2011-05-25T18:04:25 <dreimark> it is not same for me, ah now the icons arrived
243 2011-05-25T18:05:02 <dreimark> - now it is, looks like that it is fixed after some time
244 2011-05-25T18:05:09 <sinha> http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-05-25#preview
245 2011-05-25T18:05:20 <sinha> dreimark: yes
246 2011-05-25T18:05:37 <sinha> dreimark: do we need to keep any heading ?
247 2011-05-25T18:06:11 <dreimark> sinha: make small changesets not all on that tool by only one
248 2011-05-25T18:06:49 <sinha> as i will put icons before every text depicting them, like comment icon before comment, editor icon before editor, what say ?
249 2011-05-25T18:07:22 <sinha> dreimark: any suggestions on that ?
250 2011-05-25T18:07:24 <dreimark> i am not sure if I understand this
251 2011-05-25T18:07:37 <dreimark> we are currently in regular discussion
252 2011-05-25T18:07:47 <sinha> like first edition in python file + template
253 2011-05-25T18:07:48 <dreimark> can we first do the meeting part please
254 2011-05-25T18:08:02 <sinha> and after that css editing ?
255 2011-05-25T18:08:22 <sinha> or do you want it be something different
256 2011-05-25T18:08:24 <dreimark> if python file and css is belonging to the same change then you can commit both
257 2011-05-25T18:09:11 <dreimark> you should just not add e.g. a change for bookmark or some refactoring or some pep8 fix ... together in the same one
258 2011-05-25T18:09:20 <sinha> all three belong to same change
259 2011-05-25T18:09:36 <sinha> i am getting confused on this part
260 2011-05-25T18:09:37 <dreimark> then do it by one. check beforehand pep8
261 2011-05-25T18:10:01 <dreimark> ah ok
262 2011-05-25T18:10:04 <dreimark> i try again
263 2011-05-25T18:10:29 <sinha> yes i understand that
264 2011-05-25T18:10:36 <dreimark> now you have done some changes for grouping
265 2011-05-25T18:10:40 <dreimark> this is one cs
266 2011-05-25T18:10:51 <dreimark> if you chang it again for bookmark make a new one
267 2011-05-25T18:11:44 <dreimark> this makes better readable diffs/patches
268 2011-05-25T18:11:52 <dreimark> and also it is easier to discuss those
269 2011-05-25T18:12:22 <dreimark> and at the end all this change sets goes into the main repo
270 2011-05-25T18:12:53 <dreimark> and then someone there did easier understand what the path of all that was
271 2011-05-25T18:13:18 <dreimark> sinha: is that clearer?
272 2011-05-25T18:15:25 <sinha> okay i will push the changes related to this basic grouping once, and then will do the rest afterwards
273 2011-05-25T18:15:33 <dreimark> thx
274 2011-05-25T18:15:54 <sinha> dreimark: still problem in converting the timestamp into date format in template file
275 2011-05-25T18:15:57 <dreimark> you have written the meating part to the diary. We also want it here too
276 2011-05-25T18:16:07 <dreimark> next time be prepared
277 2011-05-25T18:16:13 * sinha copying
278 2011-05-25T18:17:15 <sinha> Summary so far : So far I have done the grouping of history results on day basis, i have done grouping in python function itself and edited the template according to that. I have to do customization of the output and after completing i have kept 2 things on row i) Adding pagination ii) Bookmark functionality. dreimark: tell me which thing should i do first ? Blockers Currently having problem in converting the revision timestamp in template file, if i
279 2011-05-25T18:17:47 <ThomasWaldmann> sinha: did you look at how 1.9 RC works?
280 2011-05-25T18:18:11 <ThomasWaldmann> (and you need to hit enter more often, you last post was truncated after ", if i"
281 2011-05-25T18:18:39 <sinha> ThomasWaldmann: yes you mean code ? or frontend ?
282 2011-05-25T18:18:50 <ThomasWaldmann> both
283 2011-05-25T18:19:10 <ThomasWaldmann> you'll likely need to read and understand the code to see how it works
284 2011-05-25T18:20:59 *** MattMaker
285 2011-05-25T18:21:46 <sinha> ThomasWaldmann: you want some specific change in current one ? i will be looking for a specific thing then .
286 2011-05-25T18:23:17 <dreimark> sinha: look at 2011-05-24
287 2011-05-25T18:23:28 <dreimark> you have twice Sinha
288 2011-05-25T18:23:45 <dreimark> this did not happen in moin-1.x
289 2011-05-25T18:24:17 <dreimark> but this is another kind of grouping
290 2011-05-25T18:24:41 <dreimark> you can work on this afterwards
291 2011-05-25T18:25:18 <sinha> dreimark: yes, i guess, i have to do lot of improvement in this part
292 2011-05-25T18:25:49 <dreimark> i think you should work first on all that grouping stuff
293 2011-05-25T18:25:56 <dreimark> in small changesets
294 2011-05-25T18:26:20 <dreimark> bookmarks and pagination are different functions from that point of view
295 2011-05-25T18:27:48 <dreimark> after grouping is done, then maybe some changesets for getting functions to icons
296 2011-05-25T18:28:14 * dreimark means the whole grouping everything of moin-1.x
297 2011-05-25T18:28:29 <dreimark> then afterwards bookmarks
298 2011-05-25T18:28:33 <dreimark> then pagination
299 2011-05-25T18:28:49 <sinha> dreimark: okay i will refer 1.9 to do this grouping, afterwards start new things
300 2011-05-25T18:29:24 <sinha> dreimark: what else is there other than this same item grouping ?
301 2011-05-25T18:29:45 <dreimark> it is also rev grouping
302 2011-05-25T18:30:23 <dreimark> http://moinmo.in/RecentChanges
303 2011-05-25T18:31:02 <dreimark> e.g. WikiSandBox
304 2011-05-25T18:32:32 <sinha> yes, in there timestamp and comment is only shown for the last change
305 2011-05-25T18:34:56 <sinha> dreimark: btw this 1.9 RecentChange is a bit changed, it used to like somewhat different
306 2011-05-25T18:35:30 <dreimark> rephrase please
307 2011-05-25T18:35:48 <dreimark> changed, means different?
308 2011-05-25T18:36:51 <sinha> yes
309 2011-05-25T18:37:34 <dreimark> it must not look like identical but a lot of its functions are very good compared to other wiki engines
310 2011-05-25T18:38:25 <sinha> In 1.9 RC there used to be list of days like 20,50,90 on top on clicking the shows the change for last 20,50,90 days respectively
311 2011-05-25T18:38:41 <sinha> s/clicking the/clicking them
312 2011-05-25T18:38:50 <dreimark> you want that if you have a bookmark
313 2011-05-25T18:38:58 <dreimark> and that bookmark is recent
314 2011-05-25T18:39:08 <sinha> i am not logged in into the wili
315 2011-05-25T18:39:21 <dreimark> that's a failure
316 2011-05-25T18:39:26 <sinha> s/wili/wiki
317 2011-05-25T18:40:00 <dreimark> if you are not logged in than it is not that useful may be
318 2011-05-25T18:40:19 <dreimark> such stated could be separated in the template now
319 2011-05-25T18:40:46 <dreimark> ;)
320 2011-05-25T18:41:22 <dreimark> s/stated/status/ may be better word
321 2011-05-25T18:41:43 <sinha> dreimark: still problem in converting the timestamp into date format in template file
322 2011-05-25T18:42:02 <sinha> where does the filter exists ? and if not where should i write one
323 2011-05-25T18:42:11 <dreimark> give me an example what you want and what you have
324 2011-05-25T18:42:42 <dreimark> did you looked at flask babel extension
325 2011-05-25T18:43:33 <dreimark> # please note that these filters are installed by flask-babel:
326 2011-05-25T18:43:38 <dreimark> datetimeformat, dateformat, timeformat, timedeltaformat
327 2011-05-25T18:44:06 <sinha> but when i use dateformat filter in template, it raises an error
328 2011-05-25T18:44:28 <sinha> do i have to pass something also on calling that function
329 2011-05-25T18:46:16 <sinha> dreimark: see this is coming, on using dateformat filter
330 2011-05-25T18:46:37 * dreimark reads babel
331 2011-05-25T18:50:10 *** m4k3r
332 2011-05-25T18:51:32 <dreimark> sinha: have you looked in diff_text.html
333 2011-05-25T18:51:46 <dreimark> {% set date_time = rev1.timestamp %}
334 2011-05-25T18:51:59 <dreimark> {{ _('Revision %(revno)d as of %(date_time)s', revno=revno, date_time=date_time|datetimeformat) }}
335 2011-05-25T18:54:25 <sinha> it is using datetimeformat, i need to use dateformat
336 2011-05-25T18:54:47 *** ronny
337 2011-05-25T18:57:00 <ThomasWaldmann> sinha: btw, 2 ways to show RC would be nice. one "dead simple" way and the "1.9 way"
338 2011-05-25T18:57:50 <dreimark> sinha: do you get a traceback if you try to use it ?
339 2011-05-25T18:58:00 <ThomasWaldmann> i now and then got email from some people thinking that the 1.9 way has bugs / was malfunctioning (it didn't). but that only gets obvious if one reads and understands the code.
340 2011-05-25T18:59:20 <dreimark> brb
341 2011-05-25T19:43:33 <sinha> brb
342 2011-05-25T19:43:34 *** sinha
343 2011-05-25T19:50:20 *** Marchael
344 2011-05-25T19:52:15 *** Marchael
345 2011-05-25T20:05:44 *** marchael
346 2011-05-25T20:07:04 <marchael> strange, I couldn't connect to freenode via pidgin
347 2011-05-25T20:10:19 <marchael> ThomasWaldmann: I played with pytest and see stange thing. When I looking for test_security.py I don't see any errors related with app.cfg
348 2011-05-25T20:10:59 <marchael> But when I played with it from ipython I continuosly get error
349 2011-05-25T20:11:47 <marchael> lines 200-257 in MoinMoin/security/_tests/test_security.py
350 2011-05-25T20:14:45 *** m4k3r
351 2011-05-25T20:16:51 *** Marchael1
352 2011-05-25T20:18:06 <Marchael1> ping
353 2011-05-25T20:18:19 *** marchael
354 2011-05-25T20:19:56 *** hardy_89
355 2011-05-25T20:25:44 <waldi> hardy_89: we missed you at the meeting today
356 2011-05-25T20:26:09 *** Marchael1
357 2011-05-25T20:26:36 <hardy_89> had my exam today waldi
358 2011-05-25T20:26:39 <hardy_89> i'm sorry
359 2011-05-25T20:27:20 *** marchael[wc]
360 2011-05-25T20:28:26 *** m4k3r
361 2011-05-25T20:36:47 <hardy_89> waldi: any new changes in today's meeting?
362 2011-05-25T20:37:01 <hardy_89> i don't see any on EP
363 2011-05-25T20:38:53 *** Marchael
364 2011-05-25T20:45:03 *** marchael[wc]
365 2011-05-25T20:46:18 *** Marchael
366 2011-05-25T20:49:01 *** hardy_89
367 2011-05-25T20:50:53 <dreimark> ThomasWaldmann: do we have something like #format in moin-2
368 2011-05-25T20:51:26 <dreimark> I use that currently often to write some parser which reads tons of attachments
369 2011-05-25T20:51:43 <dreimark> instead of writting lots of table lines in markup
370 2011-05-25T20:52:21 <dreimark> or is that later more something like a new view
371 2011-05-25T21:01:41 *** sinha
372 2011-05-25T21:04:50 <ThomasWaldmann> dreimark: contenttype
373 2011-05-25T21:07:02 <dreimark> yes
374 2011-05-25T21:07:19 <dreimark> then these are items without data only meta maybe
375 2011-05-25T21:08:17 <sinha> dreimark: that dateformat filter isn't working
376 2011-05-25T21:09:33 <sinha> this is the complete traceback http://paste.pocoo.org/show/395070/
377 2011-05-25T21:15:28 <sinha> but i guess that dateformat filter is available in the file env/lib/python2.7/site-packages/flaskext/babel.py
378 2011-05-25T21:22:06 <ThomasWaldmann> sinha: next time select python traceback for the pastebin
379 2011-05-25T21:22:37 <sinha> okay
380 2011-05-25T21:22:59 <ThomasWaldmann> sinha: your are feeding it wrong
381 2011-05-25T21:23:05 <ThomasWaldmann> wrong datatype
382 2011-05-25T21:23:07 <sinha> means
383 2011-05-25T21:23:15 <sinha> no its a timestamp
384 2011-05-25T21:23:24 <ThomasWaldmann> assert isinstance(value, (date, datetime, time))
385 2011-05-25T21:23:55 <ronny> hmm
386 2011-05-25T21:24:53 <sinha> i am calling it as rev|dateformat, where rev is timestamp
387 2011-05-25T21:25:01 <sinha> how should i call it then ?
388 2011-05-25T21:27:19 <ThomasWaldmann> what type is rev?
389 2011-05-25T21:27:36 <sinha> timestamp
390 2011-05-25T21:27:45 <ThomasWaldmann> why is it called rev then?
391 2011-05-25T21:28:18 <sinha> just a variable naming here, there is it something different and i will name it appropriately
392 2011-05-25T21:29:10 <sinha> i have verified the value, when i remove this filter i get a timestamp and no error, but when i add this filter i get this error
393 2011-05-25T21:29:16 <ThomasWaldmann> rev is isually a revision object
394 2011-05-25T21:29:25 <sinha> yes i know that
395 2011-05-25T21:29:40 <ThomasWaldmann> print repr(rev)
396 2011-05-25T21:30:06 <sinha> where in template ?
397 2011-05-25T21:32:52 <ThomasWaldmann> output it somehow, whereever you like
398 2011-05-25T21:35:46 <sinha> it is printing the timestamp value in numbers
399 2011-05-25T21:36:34 <sinha> 1306322179, like this
400 2011-05-25T21:38:08 <ThomasWaldmann> check the code of the other filter and compare it
401 2011-05-25T21:40:39 <sinha> okay
402 2011-05-25T21:46:06 <sinha> this function is called when dateformat filter is called def format_date(date=None, format=None, rebase=True): do i have to pass anything to it ?
403 2011-05-25T21:46:29 <sinha> as the other filter functions are quite similar to this
404 2011-05-25T21:46:44 *** m4k3r
405 2011-05-25T21:48:22 <dreimark> sinha: http://babel.edgewall.org/wiki/Documentation/0.9/dates.html
406 2011-05-25T21:51:35 <ThomasWaldmann> sinha: check the code of there functions, esp. what data types it accepts
407 2011-05-25T21:52:25 <sinha> i have used dateformat and timeformat function , they both accepts timestamp
408 2011-05-25T21:52:48 <dreimark> is it a float?
409 2011-05-25T21:53:23 <dreimark> because of
410 2011-05-25T21:53:25 <dreimark> The dates.format_datetime currently only accept either an integer or long integer type for passing to datetime.fromtimestamp, and passing a float will result in an exception.
411 2011-05-25T21:53:43 <dreimark> http://babel.edgewall.org/ticket/242
412 2011-05-25T21:55:17 <sinha> no its a integer i guess, i have printed it as native form
413 2011-05-25T21:56:58 <sinha> how can i pass other params to filter from the template ? means i want to pass format to the filter
414 2011-05-25T21:58:05 <dreimark> sinha: from babel.dates import format_date, format_datetime, format_time
415 2011-05-25T21:58:11 <dreimark> format_datetime(1)
416 2011-05-25T21:58:24 <dreimark> instead of 1 your value
417 2011-05-25T21:58:30 <dreimark> from the variable
418 2011-05-25T21:58:39 <dreimark> not typed
419 2011-05-25T21:59:34 <sinha> but when passing through template we call them as timestamp_var|dateformat , here how one can pass additional params
420 2011-05-25T22:02:36 <dreimark> dateformat=format_date look at help(format_date)
421 2011-05-25T22:03:00 <dreimark> and compare it with the other one
422 2011-05-25T22:03:21 <sinha> i have called it through python code, i guess timestamp is not the passing data type for that function
423 2011-05-25T22:03:32 <dreimark> read the help page
424 2011-05-25T22:04:05 <dreimark> yes you need to pass the right type
425 2011-05-25T22:08:24 <sinha> at help(format_date) its saying that this object isnt defined, i have ran it in moin shell
426 2011-05-25T22:08:29 *** sinha
427 2011-05-25T22:10:11 <ThomasWaldmann> bug in babel
428 2011-05-25T22:10:16 <ThomasWaldmann> or "missing feature"
429 2011-05-25T22:13:24 <dreimark> strange, works for me
430 2011-05-25T22:13:33 <dreimark> from babel.dates import format_date
431 2011-05-25T22:13:41 <dreimark> help(format_date)
432 2011-05-25T22:14:50 <ThomasWaldmann> look into babel.dates, the type checks are rather clear
433 2011-05-25T22:14:54 *** RogerHaase
434
